| *** whoami-rajat_ is now known as whoami-rajat | 14:07 | |
| stephenfin | M0weng[m]: Took a look at that error message: it's not keystoneclient's fault but rather the fault of '_process_identity_and_resource_options' in 'openstackclient/identity/v3/role.py' | 16:25 |
|---|---|---|
| stephenfin | M0weng[m]: It's an if-else ladder and there's a missing fallthrough/else case | 16:26 |
| stephenfin | M0weng[m]: IMO, it would be better if we started nesting and had three cases: if user: {do stuff}; elif project: {do stuff}; else {fail} | 16:28 |
| stephenfin | and then another one for if system: {do stuff}; elif project: {do stuff}; elif domain; {do stuff}; else {fail} | 16:30 |
| stephenfin | not sure if the else in that second one is necessary or not. I'll let you figure that out | 16:30 |
| opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'service' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/906395 | 17:23 |
| opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add support for default volume type commands https://review.opendev.org/c/openstack/python-openstackclient/+/920465 | 21:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!