| mikal | Hey, twice now openstacksdk has been broken for python3.8 by mypy changes. This seems to be happening because there isn't any CI for that python version upstream, despite python 3.8 being in the support matrix for 2024.1. I get that the universe is imperfect, but I am mostly catching these by pure luck in a downstream project at the moment. Apart from playing whackamole when I find them, is there something w | 07:38 |
|---|---|---|
| mikal | e can do to make this less of a thing? | 07:38 |
| opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: Add support for default volume types https://review.opendev.org/c/openstack/openstacksdk/+/920464 | 07:42 |
| frickler | mikal: are you referring to the stable/2024.1 branch or master? and sure you can do something, create reviews adding testing jobs for what you think is missing | 08:14 |
| mikal | Master is definitely broken for python3.8. I need to rehydrate my state on what pythons OpenStack says they support for 2024.2 to be honest. | 08:15 |
| mikal | I think the issue with upstream CI is I'm not sure there's any distro that has python 3.8 in the supported list any more. | 08:16 |
| mikal | I'm using Rocky 9 out of tree to find these issues. | 08:16 |
| frickler | doesn't that have python3.9 by default? in general, support for py3.8 has been dropped, see https://governance.openstack.org/tc/reference/runtimes/2024.2.html | 08:17 |
| frickler | so testing that would need to be specific to sdk/osc | 08:17 |
| mikal | Yeah, just found the same page. | 08:17 |
| mikal | Definitely the error I see states that you need python 3.10+ for the syntax that is being used. | 08:18 |
| mikal | Let me spin up a quick test VM and double check what version of python it has by default. | 08:18 |
| mikal | Sorry, you're right, Rocky 9 is indeed python 3.9. However, that is still too old for this syntax. | 08:24 |
| frickler | so that's certainly a bug then, that should be fixed | 08:35 |
| mikal | Yeah, I am waiting for my CI to finish running before uploading a fix. I just want to make sure it actually works first. | 08:36 |
| opendevreview | Michael Still proposed openstack/openstacksdk master: Use mypy syntax compatible with older pythons. https://review.opendev.org/c/openstack/openstacksdk/+/920814 | 08:48 |
| frickler | gtema: ^^ iirc we've seen more regressions like this earlier. maybe need a mypy py39 job? (cc stephenfin who has voiced interest in also keeping support for py38) | 09:04 |
| gtema | Have I told how I love modern py madness? | 09:07 |
| opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'service' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/906395 | 17:54 |
| M0weng[m] | <stephenfin> "0weng: Took a look at that error..." <- Ahh I see; I'll take a look at that. Should I fix this in the same patch as the SDK migration or make a separate one? | 23:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!