Tuesday, 2015-09-01

« Monday, 2015-08-31 Index Wednesday, 2015-09-02 »
*** sigmavirus24_awa is now known as sigmavirus2401:00
*** sigmavirus24 has quit IRC03:48
*** sigmavirus24 has joined #openstack-searchlight03:52
*** sigmavirus24 is now known as sigmavirus24_awa03:59
*** lakshmiS has joined #openstack-searchlight07:19
openstackgerritLakshmi N Sampath proposed openstack/searchlight: Fix for updated/missing fields in python glance client for image members  https://review.openstack.org/21916807:51
openstackgerritLakshmi N Sampath proposed openstack/searchlight: WIP - Functional Tests for Searchlight  https://review.openstack.org/21758008:02
*** lakshmiS has quit IRC10:11
*** sballe has joined #openstack-searchlight12:14
*** sigmavirus24_awa is now known as sigmavirus2412:51
openstackgerritEndre Karlson proposed openstack/searchlight: Optimize client handling  https://review.openstack.org/21927113:16
ekarlsosigmavirus24: / sjmc7 / TravT  ^13:16
*** lakshmiS has joined #openstack-searchlight13:20
ekarlsowtf..13:20
ekarlsothat was not supposed to happen :|13:20
openstackgerritEndre Karlson proposed openstack/searchlight: Refactor clients handling to use Sessions.  https://review.openstack.org/21927113:24
ekarlsothere u go13:24
*** sigmavirus24 is now known as sigmavirus24_awa13:24
*** sigmavirus24_awa is now known as sigmavirus2413:39
ekarlsoTravT: https://review.openstack.org/#/c/199099/13/searchlight/elasticsearch/plugins/designate/notification_handlers.py < how to test your comment there ?13:51
ekarlsomy ES skilsl are a tad low13:51
sjmc7ekarlso i haven't verified the issue Travis was seeing yet, but looking at the code i think i see why it's happening. in any case we're recommending using engine.index14:29
sjmc7the body should just be the doc though, not {"doc": payload} like we're currently doing - i think that's what's causing the bug14:29
sjmc7doc_as_upsert allows operations equivalent to SQL's UPDATE, but it doesn't remove attributes that are no longer present14:30
TravTsjmc7: i can try that out.14:30
sjmc7ok. i missed it when i looked at it the other day. took two shots of coffee to take a fresh look14:31
sjmc7if you re-run your test, take a careful look at the documents in e-s14:31
TravTi'm actually awake today myself.14:31
TravTalthough, i need breakfast14:31
sjmc7it may not fully explain it though, because i would have thought the original would still be there14:31
*** TravT_ has joined #openstack-searchlight14:48
*** TravT has quit IRC14:50
ekarlsowould you guys mind testing if that's the case sjmc7 / TravT_ ?15:05
TravT_ekarlso, i'm looking at it now, but i'm running into some auth problems.  trying to figure out what's going on there.15:05
sjmc7ekarlso - if you call engine.index with body=payload, it will work15:05
TravT_sjmc7: oddly getting this error: 2015-09-01 09:00:31.704 ERROR searchlight.elasticsearch.plugins.nova.servers_notification_handler [-] Invalid user / password (Disable debug mode to suppress these details.) (HTTP 401)15:06
sjmc7service credentials ?15:06
TravT_those appear to be correct15:06
TravT_when i manually hit nova api, it works.15:07
ekarlsoTravT_: I think I know why actually15:07
ekarlsosearchlight user is missing admin on service tenant I believe15:07
*** TravT_ is now known as TravT15:07
TravTekarlso, we added that in a follow on patch.15:07
TravTbut let me check15:07
ekarlsoTravT: kk kewl15:08
TravTi can manually hit nova API and get the server using searchlight user15:08
sjmc7"invalid user password" is pretty specifuc15:08
TravTlet me see if glance gives the same error15:08
TravTno, worked fine.15:09
TravTwell, i'll modify glance plugin for payload instead of nova15:10
sjmc7ok15:10
ekarlsommms15:12
ekarlsohow you propose to split the plugin vs notification handler ?15:13
TravTekarlso, sorry, not following15:15
TravTsjmc7: making that switch to payload fixed what I was seeing in glance.15:15
TravTguys, i gotta jump on a call15:15
TravTjust realized i'm 15 minutes late15:15
ekarlsoTravT: sjmc7 has a note in the handlers to move the get topic call down into the ntoification handlers15:16
ekarlsovs the plugin15:16
TravTekarlso: do you have a link to that comment?15:20
ekarlsohttps://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/glance/images.py#L13315:22
sjmc7ah, yes. i think for now leave things as they are; we can change them wholesale (I'll file a bug for it)15:23
sjmc7it won't affect functionalituy15:23
* TravT multitasking (in 1:1 phone call)15:24
TravTekarlso, can you go ahead and make that change to the payload in the designate plugin?15:24
david-lyleTravT: the other end of that call must feel special15:24
david-lyle:D15:25
TravTlol15:25
TravTlakshmiS: nova delete works for me15:25
ekarlsosjmc7: u mean for M1? :p15:25
TravTwere you able to go back through any of those tests?15:25
sjmc7possibly. it's not a functional bug, just structural15:26
sjmc7more important to get the plugins in15:26
lakshmiSTravT: maybe its just slow to send the correct state in initial update itself for me. will test it further15:27
* TravT brain melting will check back here shortly.15:28
openstackgerritEndre Karlson proposed openstack/searchlight: Refactor clients handling to use Sessions.  https://review.openstack.org/21927115:29
TravTomg sjmc715:32
TravTthat doc / payload thing15:32
TravTso obvious when you look closely15:32
TravTyeah, two cups of coffee15:33
TravTgood eyes15:33
sjmc7yeah..15:34
sjmc7and because we specify an id, we wipe the old one15:34
sjmc7and it's not obvious when staring at the json payload15:34
sjmc7mystery solved. will update the nova patch15:34
TravT            "_source": {15:34
TravT               "doc": {15:34
sjmc7yep15:34
TravTto quote david-lyle15:34
TravTfacepalm15:35
sjmc7:D15:35
ekarlsowhat to update ?15:35
ekarlsoin the designate thin15:35
sjmc7ekarlso - like i was saying earlier, use engine.index15:35
TravTi'll put a comment on your patch15:35
sjmc7but body=payload15:35
sjmc7not body={"doc": payload}15:35
sjmc7and, this is why functional tests would be splendid15:35
sjmc7because you can't catch that kind of thing with unit tests15:36
TravTekarlso, just added a comment on the lines you should change15:36
TravTsjmc7, yep15:36
TravTat least now i know i'm not crazy.15:37
openstackgerritSteve McLellan proposed openstack/searchlight: Add nova instances plugin  https://review.openstack.org/19885215:37
ekarlsoself.engine.index then vs self.engine.create ?15:40
sjmc7ekarlso yeah15:41
ekarlsokewl15:41
sjmc7create will give you an error if it exists already15:41
ekarlsodone15:41
ekarlso:P15:42
openstackgerritEndre Karlson proposed openstack/searchlight: Add Designate plugin.  https://review.openstack.org/19909915:46
*** lakshmiS has quit IRC15:48
openstackgerritTravis Tripp proposed openstack/searchlight: Fix Glance Indexing after Notification  https://review.openstack.org/21933116:16
sjmc7ekarlso - i'm gonna upload a new version of the designate patch with a fix to RBAC that we found a couple of weeks ago16:26
sjmc7second thoughts, i'll leave a comment, since i want to be able to review it :)16:28
TravTnick of time sjmc7, i was just going to pull the patch.16:29
TravTwell, i'll pull nova again16:29
TravTi don't understand why i was getting user name password fail on that16:29
TravTwhen it worked fine for glance.16:29
TravTbut i have a brand new devstack with designate, so i might as well re-test the nova notification indexing now with it.16:30
sjmc7k16:30
*** david-ly_ has joined #openstack-searchlight16:49
*** david-lyle has quit IRC16:49
sjmc7glanceclient got a 1.0.0 release! it's first birthday!16:58
TravTwoot!17:00
sjmc7it broke our glance image member code :)  lakshmi put up a fix already17:03
*** david-ly_ has quit IRC17:07
TravTsjmc7:17:09
TravTjust testing the nova patch again.17:09
TravTVM booted.  Ended with these17:09
TravT"OS-EXT-STS:vm_state": "active",17:09
TravT "status": "ACTIVE",17:10
TravTThat is what I would expect to see.17:10
sjmc7hurrah :)17:10
sjmc7me too. possible nova got fixed?17:10
TravTlistener picked it up17:10
TravTand it is searchable17:10
sjmc7mine's several weeks old17:10
sjmc7hurray17:10
TravTtesting delete now17:10
TravThmm, actually, i'll try a few actions on it first17:11
TravTremoving security group worked.  old one is gone17:11
TravTsuspend17:12
TravT"OS-EXT-STS:vm_state": "suspended",17:12
TravT"status": "SUSPENDED",17:12
TravTresume:17:13
TravT"OS-EXT-STS:vm_state": "active",17:13
TravT"status": "ACTIVE",17:13
sjmc7that's good news. sort of curious if it was something that got fixed in nova or something in the envs lakshmi and i were using, but i guess it doesn't matter overmuch17:13
TravTshutdown17:13
TravT"OS-EXT-STS:vm_state": "stopped"17:13
TravT"status": "SHUTOFF",17:14
TravTstartup17:14
TravT "OS-EXT-STS:vm_state": "active",17:14
TravT"status": "ACTIVE",17:14
TravTwill try delete now17:15
TravTgone from index17:15
sjmc7ship it!17:15
TravTok, i'm going to double check rbac query again, but not expecting issues17:15
TravTit worked last time17:15
sjmc7i think i adjusted rbac for the indices filter17:15
TravTin the last patch since I +2'd?17:16
TravTI didn't think you did?17:16
TravTwhatever the case, i'm trying again.17:16
sjmc7no, not since then17:16
TravTsjmc7: ok, rbac filtering only returned back the instances I'd expect and the OS-EXT-SRV-ATTR: fields were filtered17:39
TravT+217:39
sjmc7good times. hey, y'all, somebody give the nova patch some love!17:40
TravTnikhil_k: sigmavirus24: what version of glanceclient can we rely on now17:47
TravTi see in global requirements https://github.com/openstack/requirements/blob/master/global-requirements.txt#L14917:47
TravTand upper contstraints https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L24317:48
sjmc7hmm, good catch17:48
TravTso, sjmc7 you comments here: https://review.openstack.org/#/c/219168/117:49
sjmc7devstack will pull in 1.0.0 i think17:49
TravTwell, i can just pull it17:49
sjmc7i don't think it cares about global reqs17:50
*** david-lyle has joined #openstack-searchlight17:54
*** sigmavirus24 is now known as sigmavirus24_awa17:54
*** david-lyle has quit IRC18:01
*** david-lyle has joined #openstack-searchlight18:19
ekarlsosjmc7: ok :p19:03
*** sigmavirus24_awa is now known as sigmavirus2419:04
TravTekarlso, if you get that updated tonight, i'll go ahead and go through it today.20:24
sjmc7it doesn't look like glance sends notifications on image member changes21:07
TravTsjmc7 are you making a general statement or in reply to the bug I filed?21:10
sjmc7i filed a bug too!21:11
TravThmm...21:11
TravTi mentioned it in review here: https://review.openstack.org/#/c/219168/21:11
sjmc7ah, you got there first!21:12
TravTwhich bug is yours?21:12
TravTwe'll just duplicate one of them21:12
sjmc7https://bugs.launchpad.net/searchlight/+bug/149105321:12
openstackLaunchpad bug 1491053 in OpenStack Search (Searchlight) "No notification received on glance member update" [Critical,New] - Assigned to Steve McLellan (sjmc7)21:12
sjmc7i'll mark mine as a dupe21:12
sjmc7there appears to not be a fix for it21:14
TravTneed to trace glance code... but i'm surprised this isn't coming with an image.update notification21:17
TravThttps://github.com/openstack/glance/blob/d4cf5a015b49b8163a71726781aee54da9c252ec/glance/notifier.py#L45721:17
sjmc7looking through the code now21:17
TravThttps://github.com/openstack/glance/blob/d4cf5a015b49b8163a71726781aee54da9c252ec/glance/api/v2/image_members.py#L15221:18
TravTfwiw, i was using v2 API requests and not getting notifications21:19
TravTwhat were you using?21:19
TravTglanceclient?21:19
sjmc7same21:19
TravThmm..21:19
sjmc7err.. yeah21:19
sjmc7glanceclient21:19
TravTah, i was just doing them by hand.21:19
sjmc7same deal i guess21:20
TravTwell, just wondering if v1 vs v2 would exhibit diff notification behavior21:20
TravTlast i checked glance client defaulted to v121:20
TravTcli21:20
TravTnikhil_k^21:20
TravTwe don't seem to be getting notifications for member update21:21
TravTsjmc7 FYI: the cross project meeting is going on and streaming kinda fast right now.21:21
sjmc7tried with v2 as well, no dice21:22
sjmc7still rambling through the code21:22
nikhil_kTravT: 1.0.0 should be v221:23
nikhil_kTravT: hence the major bump21:24
TravT1.0 is v2. got it21:24
sjmc7nikhil_k do you know if we should expect notifications on image member changes?21:30
sjmc7looks like no - the various proxies are chained together and there isn't a notification one for image members21:32
TravTlooks like you have an opportunity to get a glance commit this release21:50
sjmc7:)21:51
TravTjust put some comments on the index arguments patch.21:53
TravTtake a look. if you want to talk about them we can21:53
sjmc7pistols at dawn!21:59
sjmc7those make sense. i'll make some quick alterations22:00
sjmc7it continually annoys me we don't already have those options :)  it also needs to be MUCH quieter22:00
sjmc7actually, i have to pop out for a bit; i'll make the changes later tonight22:01
TravTyeah22:06
TravTit wasn't so bad with just glance22:06
TravTbut i've experienced the same annoyance22:06
*** sigmavirus24 is now known as sigmavirus24_awa22:18
« Monday, 2015-08-31 Index Wednesday, 2015-09-02 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!