| *** sballe has quit IRC | 00:46 | |
| *** TravT_ has joined #openstack-searchlight | 02:50 | |
| *** TravT has quit IRC | 02:51 | |
| *** TravT_ has quit IRC | 03:27 | |
| *** TravT has joined #openstack-searchlight | 03:28 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Allow indexing of single type or index https://review.openstack.org/210759 | 04:34 |
|---|---|---|
| *** lakshmiS has joined #openstack-searchlight | 05:31 | |
| *** lakshmiS has quit IRC | 05:36 | |
| *** lakshmiS has joined #openstack-searchlight | 05:50 | |
| openstackgerrit | Endre Karlson proposed openstack/searchlight: Add Designate plugin. https://review.openstack.org/199099 | 10:47 |
| ekarlso | TravT: ^ | 10:48 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 12:08 | |
| *** david-lyle has quit IRC | 12:27 | |
| *** david-lyle has joined #openstack-searchlight | 12:28 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 12:45 | |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: WIP - Functional Tests for Searchlight https://review.openstack.org/217580 | 13:24 |
| openstackgerrit | Merged openstack/searchlight: Fix Glance Indexing after Notification https://review.openstack.org/219331 | 13:32 |
| *** lakshmiS has quit IRC | 14:01 | |
| nikhil_k | sjmc7: oops, just saw your msg. I'm not sure on the image members notification, may be it's getting missed in the domain somewhere. However, I would like to check your commit to see if there's any gotcha; it may be that notifications aren't expected for members for there wasn't any use case for such. may be image-members were to be considered as a separate entity like images, though it can be debatable. billing doesn't need members so far. | 14:06 |
| *** lakshmiS has joined #openstack-searchlight | 14:09 | |
| *** mugsie has quit IRC | 14:10 | |
| *** mugsie has joined #openstack-searchlight | 14:11 | |
| *** GB21 has joined #openstack-searchlight | 14:21 | |
| *** TravT has quit IRC | 14:31 | |
| *** TravT has joined #openstack-searchlight | 14:31 | |
| sjmc7 | nikhil_k - i suspect it's the latter, that there was never a use case for it | 14:32 |
| nikhil_k | yeah :=/ | 14:33 |
| sjmc7 | billing's not the only use case for notifications (even aside from what we're doing) so i don't think it'd be unreasonable to add it | 14:34 |
| sjmc7 | image members are also considered a separate entity | 14:34 |
| nikhil_k | they can be | 14:34 |
| nikhil_k | but they depend on images to exist | 14:34 |
| sjmc7 | i mean in terms of the codebase | 14:35 |
| nikhil_k | umm, yeah. it'r sorta tangled | 14:35 |
| nikhil_k | db schema is different, but the pile up of query isn't | 14:35 |
| nikhil_k | and there are cross checks for members on images | 14:35 |
| sjmc7 | in any event, we're not going to get notifications for them | 14:35 |
| nikhil_k | yes | 14:36 |
| nikhil_k | I mean no :) | 14:36 |
| *** TravT_ has joined #openstack-searchlight | 14:37 | |
| *** TravT has quit IRC | 14:37 | |
| sjmc7 | nikhil_k - i'm guessing it's too late in the cycle to add now, but is there any reason you can see why we wouldn't be able to add notificaitons on member changes early in M ? | 14:46 |
| nikhil_k | sjmc7: I think that would be quite possible | 14:46 |
| sjmc7 | ok. if only i'd found this out a couple of weeks ago! | 14:47 |
| nikhil_k | sjmc7: I am planning to propose pre-approved specs for M so we can have this in that bunch | 14:47 |
| nikhil_k | sjmc7: haha, yeah! | 14:47 |
| sjmc7 | is there anywhere i can add this as an ask, or have you already done so? | 14:49 |
| nikhil_k | sjmc7: I haven't. Think a spec is the best place | 14:52 |
| nikhil_k | sjmc7: also, it won't be hurting anyone else (most prop) so relatively easier to get thru | 14:53 |
| sjmc7 | yeah, it doesn't seem too controversial | 14:53 |
| TravT_ | nikhil_k, any chance it could be considered a bug? Missing notifications? maybe a long shot, but then possible in L? | 14:55 |
| *** TravT_ is now known as TravT | 14:56 | |
| nikhil_k | TravT: may be :) | 14:58 |
| nikhil_k | TravT: there's been some debate around it. we are considering short specs (3 liner ones) for changes like such but process is still not in place. I guess we will have to see how it affects others. | 14:59 |
| TravT | It is just that without membership data, we can't do the queries right. | 15:00 |
| TravT | and horizon uses the membership data when displaying. | 15:00 |
| nikhil_k | TravT: ah I see | 15:00 |
| nikhil_k | TravT: I think we could be able to work this out. rc period is till oct 9 so seems possible | 15:01 |
| sjmc7 | i can file a bug now? | 15:02 |
| sjmc7 | in glance, and we can get a patch up today | 15:03 |
| TravT | Well, I guess we could ask for FFE as well if this isn't considered a bug. | 15:03 |
| nikhil_k | TravT: yeah, but I have one already and it will have to go to ML for FFE. | 15:04 |
| TravT | So, how about we start with a bug and if sjmc7 has a patch up | 15:04 |
| nikhil_k | sjmc7: surely! | 15:04 |
| nikhil_k | TravT: sounds like a plan | 15:04 |
| nikhil_k | I meant baby steps | 15:05 |
| sjmc7 | ok, gimme a sec. are we looking for a notification specific to image members? or to send an image update notification when they change? | 15:07 |
| sjmc7 | the former seems more consistent with other parts of glace | 15:07 |
| TravT | well, from our standpoint there are two things that affect us. | 15:08 |
| TravT | 1) when an image member accepts membership | 15:08 |
| sjmc7 | wait, this is already there | 15:08 |
| TravT | 2) when an image member is removed | 15:08 |
| sjmc7 | https://bugs.launchpad.net/glance/+bug/1441453 | 15:08 |
| openstack | Launchpad bug 1441453 in Glance "Image members CRUD doesn't generate notifications which will impact Catalog Index service by not having latest changes to Image memberships" [Undecided,In progress] - Assigned to Lakshmi N Sampath (lakshmi-sampath) | 15:08 |
| sjmc7 | from april | 15:09 |
| nikhil_k | lakshmiS: ^ | 15:09 |
| nikhil_k | :D | 15:09 |
| lakshmiS | forgot :) | 15:09 |
| TravT | says you already have it in progress? | 15:09 |
| TravT | Just need to change the title to say Searchlight | 15:10 |
| lakshmiS | it probably slipped. | 15:10 |
| sjmc7 | TravT - yeah. i meant from glance's perspective, it probably makes more sense to send a notification specific to the image membership rather than the image itself | 15:10 |
| openstackgerrit | Merged openstack/searchlight: Add nova instances plugin https://review.openstack.org/198852 | 15:10 |
| sjmc7 | if you do have a patch for it, we can hopefully get it reviewed in L | 15:10 |
| lakshmiS | i remember there was some issue with the way image members were coded in the layered approach of glance which was preventing it to send a notification | 15:10 |
| lakshmiS | I will check that out again | 15:11 |
| sjmc7 | it looks like the gateway's just missing a proxy to send a notification | 15:11 |
| TravT | ekarlso: are you around? | 15:12 |
| TravT | nova - woot! | 15:12 |
| lakshmiS | sjmc7: it wasn't the straightforward as images or namespaces. I should have that code somewhere. | 15:12 |
| TravT | ekarlso: mugsie: https://review.openstack.org/#/c/199099/ now has a merge conflict because of nova. I think it will be in setup.cfg and requirements.txt | 15:13 |
| *** lakshmiS has quit IRC | 15:25 | |
| *** TravT_ has joined #openstack-searchlight | 16:05 | |
| *** TravT has quit IRC | 16:06 | |
| *** TravT has joined #openstack-searchlight | 16:19 | |
| *** TravT_ has quit IRC | 16:22 | |
| *** TravT has quit IRC | 16:26 | |
| *** lakshmiS has joined #openstack-searchlight | 16:29 | |
| *** lakshmiS has quit IRC | 16:32 | |
| *** TravT has joined #openstack-searchlight | 16:39 | |
| *** lakshmiS has joined #openstack-searchlight | 16:42 | |
| *** TravT_ has joined #openstack-searchlight | 16:47 | |
| *** TravT has quit IRC | 16:49 | |
| *** GB21 has quit IRC | 16:49 | |
| ekarlso | TravT_: omg :p | 16:51 |
| TravT_ | ekarlso: :S yay for merge conflicts | 16:53 |
| *** TravT_ is now known as TravT | 16:54 | |
| *** lakshmiS has quit IRC | 17:21 | |
| sjmc7 | TravT - wondering if i should put up a patch for the image member notifications; lakshmi didn't seem too confident of finding a patch from 6 months ago :) | 18:21 |
| TravT | i can't see why it would hurt | 18:21 |
| sjmc7 | i guess it'd be enough to send a notification with image-id, tenant-id | 18:22 |
| sjmc7 | though maybe more useful to have all the members for the image | 18:23 |
| TravT | I think sending all members would be better, if we can get it. | 18:26 |
| TravT | i am headed out to lunch | 18:26 |
| TravT | bbiab | 18:26 |
| *** TravT has quit IRC | 19:24 | |
| *** TravT has joined #openstack-searchlight | 19:25 | |
| *** TravT has quit IRC | 19:41 | |
| *** TravT has joined #openstack-searchlight | 19:45 | |
| *** TravT has quit IRC | 19:49 | |
| *** TravT has joined #openstack-searchlight | 19:58 | |
| *** sballe has joined #openstack-searchlight | 22:19 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 22:23 | |
| *** TravT has quit IRC | 23:12 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!