| *** nikhil has quit IRC | 02:06 | |
| *** nikhil has joined #openstack-searchlight | 04:01 | |
| *** nikhil has quit IRC | 05:51 | |
| *** nikhil has joined #openstack-searchlight | 05:51 | |
| *** nikhil has quit IRC | 07:51 | |
| *** nikhil has joined #openstack-searchlight | 07:51 | |
| *** nikhil_ has joined #openstack-searchlight | 07:58 | |
| *** nikhil_ is now known as Guest51951 | 07:59 | |
| *** nikhil has quit IRC | 08:03 | |
| *** lakshmiS has joined #openstack-searchlight | 08:44 | |
| *** GB21 has joined #openstack-searchlight | 08:56 | |
| *** GB21 has quit IRC | 10:58 | |
| *** sballe has joined #openstack-searchlight | 11:31 | |
| *** lakshmiS has quit IRC | 12:27 | |
| *** lakshmiS has joined #openstack-searchlight | 12:30 | |
| *** Guest51951 is now known as nikhil | 13:56 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: More efficient result filtering https://review.openstack.org/207682 | 14:40 |
|---|---|---|
| sjmc7 | lakshmiS - addressed your comment on 207682 ^ | 14:41 |
| sjmc7 | TravT - were you able to run endre's session patch ok? want to check it's not something in my config that's messed up | 14:42 |
| TravT | sjmc7: i didn't try it... was seeing if ekarlso had a response to you first. | 14:43 |
| TravT | i will try it out after meeting. | 14:43 |
| TravT | i'm running through faceting rbac right now | 14:43 |
| sjmc7 | lakshmiS - still not sure why i'm getting errors from the metadef update tests. i'll debug it after the meeting | 14:50 |
| lakshmiS | sjmc7: sure. let me know if its not your environment. since it works on zuul and my env, i am guessing its not the code | 14:54 |
| sjmc7 | zuul's not running them | 14:55 |
| sjmc7 | or at least, the testr log says they're skipped | 14:55 |
| lakshmiS | ah right. lets check with travis then | 14:55 |
| sjmc7 | what version of elasticsearch are you using? | 14:55 |
| sjmc7 | those tests all use scripting, which i'm suspicious of | 14:56 |
| lakshmiS | 1.7.2 | 14:58 |
| lakshmiS | "lucene_version" : "4.10.4" | 14:58 |
| TravT | Courtesy Searchlight meeting reminder in #openstack-meeting-4: lakshmiS, mclaren, nikhil_k, rosmaita, sigmavirus24, TravT, krykowski, david-lyle, wokuma, kragniz, sjmc7, ekarlso | 15:00 |
| TravT | sjmc7: | 16:30 |
| TravT | for nova server facets | 16:30 |
| sjmc7 | yessir | 16:30 |
| TravT | would it be possible to get the options for flavor id and image id? | 16:30 |
| sjmc7 | absolutely | 16:30 |
| sjmc7 | but they will just be IDs | 16:30 |
| TravT | well, that's better than nothing, i think. | 16:31 |
| sjmc7 | while i'm at it... should we store them as image_id and flavor_id? | 16:31 |
| sjmc7 | are we ever going to denormalize it? | 16:31 |
| sjmc7 | they're nested, as a hangover from when it was denormalized | 16:31 |
| TravT | i haven't looked any more at that, but i have been wondering if there is a way to setup a parent child relationship with a nested doc over to the image or flavor | 16:32 |
| sjmc7 | i don't thikn that's a good idea | 16:32 |
| sjmc7 | it makes sense for designate | 16:32 |
| TravT | wait | 16:33 |
| TravT | that won't work because m to m | 16:33 |
| sjmc7 | that's not what the relationship is here | 16:33 |
| sjmc7 | right | 16:33 |
| TravT | if we just get the ids, then we can do client side query to get the other data (at least images - we don't have flavors yet). | 16:33 |
| sjmc7 | sure | 16:34 |
| sjmc7 | i could add flavors! :) | 16:34 |
| TravT | makes for a much nicer search experience, that's for sure. | 16:34 |
| sjmc7 | a parent child MIGHT make sense for flavors | 16:34 |
| sjmc7 | ok.. i'm going to change them to flavor_id and image_id, and i'll add facet terms for them | 16:35 |
| TravT | well wait a second on that. | 16:35 |
| TravT | if you go to image_id then the structure doesn't match nova API results | 16:36 |
| TravT | i'm not sure image.id has another problem.. | 16:36 |
| sjmc7 | hmm.. ok | 16:36 |
| TravT | with nested, then we could consider in the future doing searchlight side merging at some point.. | 16:36 |
| *** sballe has quit IRC | 16:36 | |
| sjmc7 | yep. ok, will leave them | 16:37 |
| sjmc7 | facet terms coming right up | 16:37 |
| TravT | BTW, all my rbac testing succeeded on the facets patch | 16:39 |
| sjmc7 | i'm sure i'll break it with this change :) | 16:39 |
| TravT | well, i'm thinking of pushing the current through | 16:39 |
| TravT | and then you could change to add the extra terms | 16:39 |
| sjmc7 | spoilsport | 16:39 |
| TravT | in follow on patch | 16:39 |
| sjmc7 | yeah, ok | 16:39 |
| sjmc7 | then i'll be able to test it or something | 16:39 |
| TravT | ok, i added comments on to that patch for additional facet option ideas. | 16:48 |
| openstackgerrit | Merged openstack/searchlight: Add faceting https://review.openstack.org/222388 | 16:51 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: More efficient result filtering https://review.openstack.org/207682 | 17:10 |
| sjmc7 | TravT - do i need to look at 207682 again? something went in underneath it? | 17:20 |
| sjmc7 | i thought i checked it against designate | 17:20 |
| sjmc7 | i get the same error. one moment please | 17:24 |
| sjmc7 | grr | 17:24 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: More efficient result filtering https://review.openstack.org/207682 | 17:25 |
| sjmc7 | sorry | 17:25 |
| sjmc7 | TravT - about removing created/updated from facets, you want that in this patch? | 17:31 |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Functional Tests for Searchlight Tests added - Initial Load - API - Event Listener https://review.openstack.org/217580 | 17:33 |
| *** lakshmiS has quit IRC | 17:42 | |
| TravT | sjmc7: i don't know what do you think? | 17:44 |
| sjmc7 | don't see any harm with it | 17:45 |
| sjmc7 | looks like the functional tests may have been a problem with elasticsearch config | 17:45 |
| sjmc7 | so at least i've not got gremlins | 17:45 |
| TravT | it would be nice to see the created normalized in facets as well. | 17:46 |
| TravT | because right now i'm not filtering those out on client side | 17:46 |
| TravT | so i end up with both created and created_at | 17:46 |
| TravT | when showing available facets | 17:46 |
| sjmc7 | sure. i can filter them out; each plugin knows whether it's doing it | 17:47 |
| ekarlso | ello | 18:08 |
| ekarlso | I just got home TravT ... | 18:08 |
| ekarlso | been in the land of mugsie and kiall | 18:08 |
| ekarlso | :P | 18:08 |
| TravT | fun! | 18:09 |
| TravT | so that session patch | 18:10 |
| TravT | steve had a question on it | 18:10 |
| TravT | i haven't tried it yet, was waiting to see your response on it | 18:10 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Standardize created_at, updated_at https://review.openstack.org/226524 | 18:11 |
| sjmc7 | TravT ^ removed facets for server.created, server.updated | 18:11 |
| TravT | sjmc7: cool, will pull it now | 18:12 |
| sjmc7 | will do the image id, flavor id facet terms very shortly, need to eat | 18:13 |
| TravT | ok, on the bottom of the original facet patch, i mentioned others that i think we'll want. | 18:15 |
| sjmc7 | ok. back in 20 minutes | 18:15 |
| TravT | k, i'll likely be out to lunch when you get back. | 18:15 |
| ekarlso | uhm, sjmc7 have you tested that glanceclient works with it ? | 18:31 |
| ekarlso | I wont look at it until tmrw but | 18:31 |
| sjmc7 | with what, ekarlso? | 18:48 |
| sjmc7 | the session patch? | 18:48 |
| sjmc7 | no - i got stuck with an error from nova | 18:49 |
| sjmc7 | glanceclient 1.0 will work with sessions, don't think earlier versions do | 18:49 |
| ekarlso | sjmc7: I remember jamielennox saying something about it not working properly in the glance chan earlier ? | 18:52 |
| sjmc7 | ah.. that's not one of the ten places i'm watching right now | 18:52 |
| sjmc7 | your patch doesn't rely on it for glance client anyway, so i think we're ok | 18:53 |
| ekarlso | sjmc7: ? | 19:16 |
| sjmc7 | yo | 19:17 |
| ekarlso | sjmc7: what is your comment about ? :p | 19:28 |
| sjmc7 | err, don't know. the time lag's too much for me :) testing the config patch now - i think i'm missing a configuration option | 19:28 |
| sjmc7 | i was! | 19:37 |
| *** nikhil has quit IRC | 19:58 | |
| *** TravT has quit IRC | 22:24 | |
| openstackgerrit | Brad Pokorny proposed openstack/searchlight: Fix typos in documentation https://review.openstack.org/227583 | 23:16 |
| openstackgerrit | Merged openstack/searchlight: Fix typos in documentation https://review.openstack.org/227583 | 23:25 |
| *** TravT has joined #openstack-searchlight | 23:44 | |
| *** TravT_ has joined #openstack-searchlight | 23:54 | |
| *** TravT has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!