*** david-lyle has quit IRC | 01:01 | |
*** nikhil has joined #openstack-searchlight | 02:21 | |
*** nikhil_ has joined #openstack-searchlight | 02:21 | |
*** nikhil_ is now known as Guest3768 | 02:21 | |
*** Guest3768 is now known as nikhil_k | 02:21 | |
*** nikhil has quit IRC | 02:34 | |
*** nikhil_k is now known as nikhil | 02:35 | |
*** nikhil has quit IRC | 03:44 | |
*** nikhil has joined #openstack-searchlight | 03:44 | |
*** nikhil_ has joined #openstack-searchlight | 03:51 | |
*** nikhil_ is now known as Guest87432 | 03:52 | |
*** Guest87432 is now known as nikhil_k | 03:52 | |
*** nikhil is now known as nikhil_k_ | 03:54 | |
*** nikhil_k_ has quit IRC | 03:55 | |
*** nikhil_k is now known as nikhil | 03:55 | |
*** nikhil_k has joined #openstack-searchlight | 04:42 | |
*** nikhil has quit IRC | 04:43 | |
*** nikhil_k is now known as nikhil | 05:01 | |
*** lakshmiS has joined #openstack-searchlight | 05:03 | |
*** lakshmiS has quit IRC | 05:49 | |
*** lakshmiS has joined #openstack-searchlight | 05:51 | |
*** nikhil has quit IRC | 05:55 | |
*** nikhil has joined #openstack-searchlight | 05:55 | |
*** lakshmiS has quit IRC | 06:00 | |
*** openstackgerrit has quit IRC | 06:01 | |
*** openstackgerrit has joined #openstack-searchlight | 06:02 | |
*** nikhil has quit IRC | 06:07 | |
*** nikhil has joined #openstack-searchlight | 06:07 | |
*** nikhil has quit IRC | 06:18 | |
*** nikhil has joined #openstack-searchlight | 06:19 | |
*** nikhil has quit IRC | 07:00 | |
*** nikhil has joined #openstack-searchlight | 07:11 | |
*** lakshmiS has joined #openstack-searchlight | 07:15 | |
*** GB21 has joined #openstack-searchlight | 08:01 | |
*** openstackgerrit has quit IRC | 08:16 | |
*** openstackgerrit has joined #openstack-searchlight | 08:17 | |
*** lakshmiS has quit IRC | 12:02 | |
*** lakshmiS has joined #openstack-searchlight | 12:16 | |
*** GB21 has quit IRC | 12:41 | |
openstackgerrit | Endre Karlson proposed openstack/searchlight: Refactor clients handling to use Sessions. https://review.openstack.org/219271 | 12:42 |
---|---|---|
openstackgerrit | Endre Karlson proposed openstack/searchlight: Refactor clients handling to use Sessions. https://review.openstack.org/219271 | 12:43 |
*** GB21 has joined #openstack-searchlight | 13:55 | |
*** david-lyle has joined #openstack-searchlight | 14:23 | |
*** david-lyle has quit IRC | 14:35 | |
openstackgerrit | Merged openstack/searchlight: Functional Tests for Searchlight Tests added - Initial Load - API - Event Listener https://review.openstack.org/217580 | 14:40 |
nikhil | TravT_: lakshmiS: hey guys, I had to cut RC1 as the patch had -1 and did not look like it was going to get in today before rel-mgrs could cut Glance out | 14:40 |
TravT_ | nikhil: ok. still plan for rc2? | 14:41 |
nikhil | So, let's target that for backport if RC2 doesn't happen | 14:41 |
sjmc7 | :( sad | 14:41 |
sjmc7 | thanks for the update. good luck with the release | 14:41 |
lakshmiS | yeah hemanth had a small question. will address it but anyway its late i guess for now | 14:42 |
TravT_ | lakshmiS: can you look over this patch? 226524 | 14:42 |
TravT_ | https://review.openstack.org/#/c/226524/ | 14:42 |
TravT_ | i'm testing it out right now against my horizon plugin. | 14:43 |
lakshmiS | TravT_: will check right after patching the glance patch | 14:43 |
TravT_ | yeah, that is more important | 14:43 |
*** lakshmiS has quit IRC | 14:46 | |
TravT_ | ekarlso: in case you didn't notice, the session patch has a pep8 failure. | 14:48 |
TravT_ | https://review.openstack.org/#/c/219271/ | 14:48 |
*** lakshmiS has joined #openstack-searchlight | 14:50 | |
*** david-lyle has joined #openstack-searchlight | 15:02 | |
*** david-lyle has quit IRC | 15:18 | |
*** david-lyle has joined #openstack-searchlight | 15:20 | |
*** lakshmiS has quit IRC | 15:21 | |
*** david-lyle has quit IRC | 15:34 | |
*** lakshmiS has joined #openstack-searchlight | 15:35 | |
*** david-lyle has joined #openstack-searchlight | 15:44 | |
*** david-lyle has quit IRC | 15:48 | |
sjmc7 | nikhil, https://review.openstack.org/#/c/219271/ adds keystone session support where we instantiate the various python clients. glanceclient didn't support sessions until 1.0, and i'm not sure it's the case that we can mandate that 1.0 be installed until it's the global-requirements default | 15:56 |
sjmc7 | any thoughts/opinions? | 15:56 |
*** lakshmiS has quit IRC | 15:57 | |
ekarlso | updated TravT_ | 16:02 |
*** lakshmiS has joined #openstack-searchlight | 16:02 | |
nikhil | sjmc7: I would recommend going with 1.x.x as that's going to be the stable API | 16:16 |
sjmc7 | ok - but global-reqs has 0.18 | 16:16 |
sjmc7 | so it'll be possible/likely delpoyers will be using 0.18 or 0.19, especially if it's capped in another project | 16:17 |
sjmc7 | and we can't enforce 1.0 in requirements | 16:17 |
nikhil | tht's true | 16:18 |
nikhil | sjmc7: is there a way for fallback in case someone has 1.0 installed? | 16:18 |
sjmc7 | and i'm guessing we're not going to update global-reqs for liberty | 16:18 |
nikhil | sjmc7: no | 16:18 |
sjmc7 | yeah, there was, though ekarlso took it out in one of the recent patchsets | 16:18 |
nikhil | sjmc7: what I am getting at is , if we are to go with a stable branch for searchlight | 16:19 |
nikhil | then 1.x is better | 16:19 |
sjmc7 | yeah | 16:19 |
sjmc7 | better not not 'only', i guess | 16:19 |
nikhil | yes :) | 16:19 |
sjmc7 | the fallback will work for 0.18 and 1.0 | 16:24 |
sjmc7 | so rather than two codepaths i think we'd have to stick with the fallback | 16:24 |
sjmc7 | ekarlso, you still around, or have we missed you? | 16:26 |
nikhil | sjmc7: sounds good | 16:33 |
lakshmiS | sjmc7: with the latest git pull I get an error on GET facets api. do you see that too? | 16:43 |
lakshmiS | ERROR searchlight.api.v1.search [req-8f6c636...- - -] 'aggregations' | 16:43 |
sjmc7 | no, it's been working fine for me and travis | 16:46 |
sjmc7 | can you narrow down where the problem is? | 16:47 |
lakshmiS | yeah let me put some log | 16:47 |
lakshmiS | around aggregations query | 16:47 |
lakshmiS | sjmc7: _get_facet_terms() in base.py throws the error. Strangely all that exception says is 'aggregations' | 16:54 |
lakshmiS | i am running it as admin | 16:55 |
sjmc7 | shouldn't matter who you're running as. it sounds like the error's coming from elasticsearch | 16:55 |
sjmc7 | ah... maybe if the result set is empty | 16:56 |
sjmc7 | that might be it. bug time! | 16:57 |
sjmc7 | for term, aggregation in six.iteritems(results['aggregations']): | 16:57 |
sjmc7 | try putting a check in | 16:57 |
sjmc7 | or dumping out 'results' | 16:58 |
lakshmiS | thats it. aggregations key doesnt exist | 17:00 |
lakshmiS | will file a bug | 17:00 |
lakshmiS | https://bugs.launchpad.net/searchlight/+bug/1499805 | 17:06 |
openstack | Launchpad bug 1499805 in OpenStack Search (Searchlight) "GET /search/facets throws an 500 internal server error" [Undecided,New] | 17:06 |
*** GB21 has quit IRC | 17:08 | |
*** lakshmiS has quit IRC | 17:27 | |
sjmc7 | i can put a patch up for that lakshmiS unless you wanted to | 17:34 |
sjmc7 | i think for https://review.openstack.org/#/c/219271/ we need to go back to one of the previous patchsets for the glanceclient; what's there won't work with anything less than 1.0. we need to get this patch in because it fixes the long-running listener problem travis mentioned | 17:35 |
ekarlso | sjmc7: back | 18:25 |
ekarlso | :P | 18:25 |
ekarlso | sjmc7: around ? | 18:25 |
ekarlso | ... | 18:27 |
ekarlso | someone kick sjmc7 in the balls! | 18:27 |
sjmc7 | i am kicked | 18:32 |
sjmc7 | yeah | 18:32 |
sjmc7 | ekarlso - the glanceclient thing, we can't rely on 1.0 | 18:33 |
ekarlso | sjmc7: :( | 18:34 |
ekarlso | sjmc7: so you couldn't have said that before the last PS ? ... | 18:34 |
sjmc7 | i didn't know | 18:34 |
ekarlso | *grin* | 18:34 |
sjmc7 | i can put up a PS later to revert the glanceclient bit back to #10 or whichever it was, i know it's late for you | 18:35 |
ekarlso | meh | 18:40 |
ekarlso | was thinking of coding something else but ok :p | 18:40 |
ekarlso | sjmc7: so waht you want me to do = | 19:06 |
sjmc7 | if you can do it, great, otherwise i'll do it later | 19:06 |
sjmc7 | sorry, putting out a bunch of fires | 19:06 |
ekarlso | sjmc7: i'll skip then sorry :) | 19:09 |
ekarlso | doing gocode with a friend atm | 19:09 |
sjmc7 | sure, ok. i'll try and put a patch up later | 19:09 |
sjmc7 | ok, no worries | 19:09 |
sjmc7 | thanks for all the worko n this | 19:09 |
ekarlso | I aint done yet! just not more today ;p | 19:09 |
sjmc7 | :) | 19:09 |
ekarlso | sjmc7: coding a firmware for the ESP826 chip based off of the Particle team's stuff | 19:25 |
ekarlso | www.particle.io | 19:25 |
ekarlso | for reference ;) | 19:25 |
sjmc7 | goodness | 20:14 |
ekarlso | sjmc7: it's awesome Fun! | 21:07 |
ekarlso | more fun then openstack for sure :p | 21:07 |
*** openstackgerrit has quit IRC | 21:16 | |
*** openstackgerrit has joined #openstack-searchlight | 21:17 | |
*** nikhil has quit IRC | 21:45 | |
*** nikhil has joined #openstack-searchlight | 21:53 | |
*** openstackgerrit has quit IRC | 22:01 | |
*** openstackgerrit has joined #openstack-searchlight | 22:02 | |
*** openstack has joined #openstack-searchlight | 22:35 | |
openstackgerrit | Merged openstack/searchlight: Standardize created_at, updated_at https://review.openstack.org/226524 | 22:44 |
*** openstack has joined #openstack-searchlight | 22:50 | |
-cameron.freenode.net- [freenode-info] if you're at a conference and other people are having trouble connecting, please mention it to staff: http://freenode.net/faq.shtml#gettinghelp | 22:50 | |
openstackgerrit | Steve McLellan proposed openstack/searchlight: Refactor clients handling to use Sessions. https://review.openstack.org/219271 | 22:52 |
openstackgerrit | Steve McLellan proposed openstack/searchlight: Fix sorting behavior for common problematic fields https://review.openstack.org/226378 | 23:06 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!