| *** yingjun has joined #openstack-searchlight | 00:24 | |
| openstackgerrit | Li Yingjun proposed openstack/python-searchlightclient: Support token based auth options for osc https://review.openstack.org/274480 | 01:34 |
|---|---|---|
| *** TravT_ has joined #openstack-searchlight | 02:50 | |
| *** TravT has quit IRC | 02:52 | |
| *** yingjun_ has joined #openstack-searchlight | 03:42 | |
| *** yingjun has quit IRC | 03:42 | |
| openstackgerrit | Merged openstack/searchlight: Don't use _id path mapping https://review.openstack.org/274221 | 03:52 |
| *** RickA-HP__ has quit IRC | 04:26 | |
| *** sigmavirus24_awa has quit IRC | 05:49 | |
| *** sigmavirus24_awa has joined #openstack-searchlight | 05:57 | |
| *** yingjun_ has quit IRC | 09:37 | |
| *** yingjun has joined #openstack-searchlight | 09:37 | |
| *** yingjun has quit IRC | 09:38 | |
| *** yingjun has joined #openstack-searchlight | 09:38 | |
| *** yingjun has quit IRC | 09:43 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit_ has joined #openstack-searchlight | 11:54 | |
| *** openstackgerrit_ is now known as openstackgerrit | 11:55 | |
| *** openstackgerrit has quit IRC | 11:59 | |
| *** openstackgerrit has joined #openstack-searchlight | 12:08 | |
| *** exploreshaifali has joined #openstack-searchlight | 12:12 | |
| *** exploreshaifali has quit IRC | 13:20 | |
| *** yingjun has joined #openstack-searchlight | 13:39 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:09 | |
| *** yingjun has quit IRC | 15:29 | |
| *** yingjun has joined #openstack-searchlight | 15:29 | |
| *** yingjun has quit IRC | 15:34 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Separate documents by role https://review.openstack.org/257516 | 15:40 |
| *** sjmc7 has quit IRC | 16:18 | |
| *** bpokorny has joined #openstack-searchlight | 16:26 | |
| *** RickA-HP has joined #openstack-searchlight | 16:26 | |
| *** bpokorny has quit IRC | 16:28 | |
| *** bpokorny has joined #openstack-searchlight | 16:29 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 16:39 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 16:41 | |
| *** sjmc7 has joined #openstack-searchlight | 16:51 | |
| *** bpokorny has quit IRC | 17:03 | |
| *** sjmc7 has quit IRC | 17:26 | |
| *** sjmc7 has joined #openstack-searchlight | 17:26 | |
| *** TravT_ has quit IRC | 17:26 | |
| *** TravT has joined #openstack-searchlight | 17:28 | |
| *** sjmc7 has left #openstack-searchlight | 17:45 | |
| *** sjmc7 has joined #openstack-searchlight | 17:45 | |
| sjmc7 | TravT: have you heard anything about removing .pot files from your various meetings? i’m ok approving https://review.openstack.org/#/c/274454/ but i don’t know anything about the change to the translation framework | 17:59 |
| *** sjmc7_ has joined #openstack-searchlight | 17:59 | |
| *** sjmc7_ has quit IRC | 18:03 | |
| TravT | sjmc7_: i don't really understand the translation framework too well. I guess since it is an approved spec I thought it should go through. | 18:03 |
| TravT | sjmc7 ^ | 18:04 |
| sjmc7 | ok. sorry, i have a rogue public cloud server pretending to be me on irc :| | 18:04 |
| TravT | hmm, are you not able to kill it now? | 18:06 |
| sjmc7 | it comes and goes :) | 18:06 |
| TravT | gasping for its last breaths, I suppose | 18:07 |
| sjmc7 | i was able to get in just now and kill it, but it’s like the terminator | 18:07 |
| TravT | sjmc7: did you see that i added highlighting to the search panel on friday? | 18:08 |
| TravT | i rather like it. | 18:08 |
| sjmc7 | oo, no. i need to look at that patch | 18:08 |
| sjmc7 | is it easy to install? | 18:08 |
| TravT | yesh | 18:08 |
| sjmc7 | was that a yes-ish or a sean connery? | 18:09 |
| TravT | just git review -d it and ./run_tests.sh --runserver 0.0.0.0 | 18:09 |
| TravT | on horizon | 18:09 |
| TravT | it is actually rather illuminiating | 18:09 |
| TravT | you can see things that don't match which you would think would match | 18:09 |
| TravT | i still need to do a bit of work on it of course | 18:10 |
| sjmc7 | yeah, there’s an open bug for tweaking how we deal with strings | 18:10 |
| *** sjmc7_ has joined #openstack-searchlight | 18:10 | |
| TravT | he's back | 18:10 |
| sjmc7 | argh, the machine has risen from the ashes | 18:10 |
| TravT | git review -d 227036 | 18:10 |
| TravT | under horizon | 18:10 |
| TravT | if we could just get irc version of steve to code like real version of steve, we could solve world hunger | 18:11 |
| *** sjmc7_ has quit IRC | 18:14 | |
| *** bpokorny has joined #openstack-searchlight | 18:22 | |
| openstackgerrit | Merged openstack/searchlight: Remove outdated pot files https://review.openstack.org/274454 | 19:06 |
| *** nikhil_k has joined #openstack-searchlight | 19:28 | |
| *** nikhil has quit IRC | 19:31 | |
| *** TravT has quit IRC | 22:08 | |
| *** TravT has joined #openstack-searchlight | 22:11 | |
| sjmc7 | TravT: about hardcoding the admin role; i’m open to suggestions. one thing we could do is make it configurable, either the role names and/or the number of roles we can support | 22:49 |
| sjmc7 | there will be problems like figuring out the preference order | 22:49 |
| TravT | yeah, so i was asked to read this spec today: | 22:49 |
| TravT | https://review.openstack.org/#/c/245629/ | 22:49 |
| sjmc7 | i was kind of trying to keep somewhat consistent with what we already had | 22:50 |
| sjmc7 | or that patch will get massive | 22:50 |
| TravT | it is a cross-project spec | 22:50 |
| TravT | which means we won't have to deal with it until Newton, at least | 22:50 |
| sjmc7 | yeah, it’s come up before in HP, too | 22:50 |
| sjmc7 | maybe we can have a rethink for N | 22:50 |
| TravT | but it is yet another attack on admin on / off issue | 22:50 |
| sjmc7 | yeah. and it does make sense, although i’d love to see the actual usage cases | 22:50 |
| sjmc7 | i mean, i can imagine some, but i’d like to hear from actual operators that are maintaining multiple levels of role | 22:51 |
| TravT | just sec, looking at something (related to this conversations) | 22:52 |
| TravT | ok, so *maybe* one thing that could be done here is to make configuration property a little more expandable in the future... | 22:54 |
| TravT | admin_only_field is very specific... | 22:54 |
| TravT | would be better if we could use a dict approach perhaps | 22:54 |
| TravT | e.g. roles to fields mapping | 22:55 |
| sjmc7 | ok. let me have a think about it. i think it’ll be a pretty decent amount of extra code | 22:55 |
| TravT | internally only support admin for now? | 22:55 |
| TravT | maybe just throw an exception at startup | 22:56 |
| sjmc7 | ah, you mean just change the option parsing? | 22:56 |
| *** bpokorny_ has joined #openstack-searchlight | 22:56 | |
| sjmc7 | yeah, that’d be no big deal | 22:56 |
| sjmc7 | and i’ll update docs etc | 22:56 |
| TravT | ok, well, i have my debugger just about to fire up and step through the current code to make sure I really understand it | 22:57 |
| TravT | will let you know if anything else jumps out | 22:57 |
| *** bpokorny has quit IRC | 22:59 | |
| sjmc7 | you want me to do that as part of this, or file a separate patch? | 23:01 |
| sjmc7 | if i do it as part of this one you might want to hold off testing | 23:03 |
| TravT | i'm just thinking about it a moment... | 23:03 |
| TravT | i hate to see this patch grow, but kind of silly to also push it in knowing the fundamental config option will change | 23:03 |
| sjmc7 | ok. any ideas for renaming it?> | 23:04 |
| TravT | field_redaction | 23:05 |
| TravT | does the conf file support dicts as value? | 23:06 |
| TravT | field_role_requirements = | 23:07 |
| TravT | field_roles | 23:07 |
| TravT | required_field_roles = | 23:07 |
| sjmc7 | yeah, there’s a DictOpt | 23:08 |
| TravT | { "admin": "OS-EXT-SRV-ATTR:*" } | 23:09 |
| TravT | but that wouldn't work great if multiple roles should use the same setting (that spec has like 4 - 5 admin roles) | 23:09 |
| TravT | maybe that other spec is orthogonal | 23:10 |
| TravT | actually, it makes things way more complicated | 23:11 |
| TravT | we'll have to do a resource type to policy role mapping to field role mapping. | 23:11 |
| TravT | e.g. compute_admin can see OS::Nova::Server admin fields | 23:12 |
| sjmc7 | err.. yeah. | 23:12 |
| TravT | so, maybe admin_only_fields just feeds into that logic (which wouldn't be this patch) | 23:13 |
| TravT | basically, all those other roles are used by searchlight to just see whether or not the current user making request can see particular resource type. | 23:15 |
| *** david-lyle has quit IRC | 23:15 | |
| TravT | and then we'd have to have some resource_type to admin mapping to decide if they can see admin fields. | 23:15 |
| TravT | as long as the other services don't get more granular (domain admin can't see service admin fields like the compute host) fields, then it would work. | 23:16 |
| sjmc7 | sorry, got called into something. yeah, i think it’s more complicated than me renaming the field | 23:18 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:22 | |
| sjmc7 | TravT: i can change the name of it and add a bit of plumbing in this patch if you want, but i think implementing it properly will be a pretty decent amount of work | 23:25 |
| TravT | sjmc7: i don't think this patch needs to implement it. If you look at the field name and can think of something that would be better, then let's do it. Otherwise, i think we might account for this other concept as part of the work we'll need to do for this BP: https://blueprints.launchpad.net/searchlight/+spec/per-resource-type-policy-control | 23:27 |
| sjmc7 | something like role_only_fields i guess | 23:27 |
| sjmc7 | the format’s a bit awkward | 23:28 |
| TravT | yeah, i was just looking at it... | 23:28 |
| sjmc7 | it’d be role_only_fields=admin:something|something|something,user:other_things | 23:29 |
| TravT | could do regex like matching maybe... | 23:29 |
| sjmc7 | ? | 23:30 |
| sjmc7 | we allow wildcards now | 23:30 |
| TravT | like what you have now. | 23:30 |
| TravT | <role>_fields = | 23:30 |
| TravT | admin_fields = project_admin_fields = foo_observer_fields | 23:31 |
| sjmc7 | ah, i see. that’s a little tricky in oslo, i think? | 23:31 |
| sjmc7 | i’d need to research it a bit | 23:31 |
| TravT | probably | 23:31 |
| TravT | okay, well, i think all these extra roles concept will need a little spec work of its own. | 23:32 |
| sjmc7 | ok. i’ll update the docs for the current patch | 23:32 |
| TravT | ok. | 23:32 |
| TravT | so, the thing that is tough about this patch | 23:33 |
| TravT | is it touches the CRUD code in all resource types, but we only have func tests for images. | 23:33 |
| sjmc7 | i added some generic tests | 23:34 |
| sjmc7 | having to modify loads of mostly identical tests for changes to base code seems like an antipattern | 23:34 |
| TravT | yeah, it is better than it was before. | 23:34 |
| sjmc7 | i intended for the tests for e.g. nova to test nova things | 23:35 |
| sjmc7 | and the base tests to test the code functionality; otherwise, modifying the base code becomes REALLY tedious | 23:35 |
| TravT | well, i'm still looking at doing some manual testing of the current resource types | 23:36 |
| sjmc7 | ok. if there are holes, i can add tests; i don’t really want to add loads of identical tests to each resource type though | 23:37 |
| *** kragniz_ is now known as kragniz | 23:38 | |
| *** bpokorny_ has quit IRC | 23:57 | |
| *** bpokorny has joined #openstack-searchlight | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!