| *** yingjun has joined #openstack-searchlight | 00:38 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Only evaluate RBAC filter for current request https://review.openstack.org/274965 | 01:46 |
|---|---|---|
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Add config-file to dev env setup instructions https://review.openstack.org/274966 | 01:51 |
| *** bpokorny has quit IRC | 01:55 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Only evaluate RBAC filter for current request https://review.openstack.org/274965 | 02:00 |
| *** lei-zh has joined #openstack-searchlight | 02:17 | |
| openstackgerrit | Akihiro Motoki proposed openstack/python-searchlightclient: Remove duplicated take_action logging https://review.openstack.org/274975 | 02:25 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Separate documents by role https://review.openstack.org/257516 | 02:46 |
| *** sjmc7 has quit IRC | 02:50 | |
| *** lei-zh has left #openstack-searchlight | 02:54 | |
| *** RickA-HP has quit IRC | 03:04 | |
| *** exploreshaifali has joined #openstack-searchlight | 05:39 | |
| *** exploreshaifali has quit IRC | 07:00 | |
| openstackgerrit | Li Yingjun proposed openstack/python-searchlightclient: Support DSL query for the query cli https://review.openstack.org/275046 | 07:24 |
| openstackgerrit | Merged openstack/python-searchlightclient: Remove duplicated take_action logging https://review.openstack.org/274975 | 07:42 |
| *** exploreshaifali has joined #openstack-searchlight | 08:53 | |
| *** yingjun has quit IRC | 09:33 | |
| *** openstackgerrit has quit IRC | 10:17 | |
| *** openstackgerrit has joined #openstack-searchlight | 10:18 | |
| *** exploreshaifali has quit IRC | 11:09 | |
| *** lei-zh1 has joined #openstack-searchlight | 11:27 | |
| *** lei-zh1 has quit IRC | 11:29 | |
| *** sjmc7 has joined #openstack-searchlight | 11:44 | |
| *** sjmc7 has quit IRC | 11:52 | |
| *** exploreshaifali has joined #openstack-searchlight | 11:56 | |
| *** lei-zh has joined #openstack-searchlight | 12:45 | |
| *** sjmc7 has joined #openstack-searchlight | 12:50 | |
| *** sjmc7 has quit IRC | 12:55 | |
| *** sjmc7 has joined #openstack-searchlight | 13:01 | |
| *** exploreshaifali has quit IRC | 13:06 | |
| *** sjmc7 has quit IRC | 13:06 | |
| *** lei-zh has quit IRC | 14:40 | |
| *** RickA-HP has joined #openstack-searchlight | 14:47 | |
| *** RickA-HP_ has joined #openstack-searchlight | 14:49 | |
| *** RickA-HP_ has quit IRC | 14:49 | |
| *** RickA-HP has quit IRC | 14:49 | |
| *** RickA-HP has joined #openstack-searchlight | 14:49 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:10 | |
| *** sjmc7 has joined #openstack-searchlight | 15:11 | |
| *** sjmc7_ has joined #openstack-searchlight | 15:43 | |
| *** sjmc7_ has quit IRC | 15:45 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-specs: Add OpenStack Newton release to spec repo https://review.openstack.org/273824 | 15:46 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add plugin options to generated config https://review.openstack.org/265469 | 16:01 |
| *** david-lyle has joined #openstack-searchlight | 16:02 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Only evaluate RBAC filter for current request https://review.openstack.org/274965 | 16:16 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Only evaluate RBAC filter for current request https://review.openstack.org/274965 | 16:18 |
| sjmc7 | TravT: 274965 looks good, but any reason you put the line breaks in for the exception lines? | 16:22 |
| sjmc7 | haha, you beat me to it | 16:29 |
| TravT | sjmc7: i needed them when it was in the if block... but once we got rid of that could take them out | 16:33 |
| sjmc7 | right. ps4 came in while i was warming up my fingers to type | 16:33 |
| TravT | :) | 16:34 |
| *** bpokorny has joined #openstack-searchlight | 16:43 | |
| *** bpokorny has quit IRC | 16:45 | |
| *** bpokorny has joined #openstack-searchlight | 16:46 | |
| *** openstackgerrit has quit IRC | 17:32 | |
| *** openstackgerrit has joined #openstack-searchlight | 17:32 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 18:03 | |
| *** exploreshaifali has joined #openstack-searchlight | 18:38 | |
| *** pkarikh has quit IRC | 19:12 | |
| *** pkarikh has joined #openstack-searchlight | 19:13 | |
| *** exploreshaifali has quit IRC | 19:24 | |
| *** TravT_ has joined #openstack-searchlight | 19:45 | |
| *** TravT_ has quit IRC | 19:46 | |
| *** TravT has quit IRC | 19:47 | |
| *** TravT has joined #openstack-searchlight | 20:44 | |
| sjmc7 | RickA-HP: you there? | 21:24 |
| RickA-HP | sjmc7: Hi Steve | 21:24 |
| sjmc7 | can you take a look at something real quick? i’m hoping i’m wrong about something | 21:24 |
| RickA-HP | Sure. | 21:24 |
| sjmc7 | the test in https://github.com/openstack/searchlight/blob/master/searchlight/tests/unit/v1/test_search.py#L539 is checking the query that’s created for an admin when using the all_projects flag and when not | 21:25 |
| sjmc7 | the first check (without all_projects) looks correct | 21:25 |
| sjmc7 | the second does not; it’s not restricting on the type at all | 21:25 |
| RickA-HP | sjmc7: The second "expected_query" in the "test_rbac_admin" test looks wrong. It should be more than jist "{ 'match_all' : {} }" | 21:36 |
| sjmc7 | yeah | 21:36 |
| sjmc7 | ok, at least i’m not going mad | 21:36 |
| sjmc7 | i won’t git blame it, because i think i already know which fool wrote it :) | 21:36 |
| RickA-HP | Or it's a shared, group delusion. I'd use the latin phrase for that, butr Travis would get upset. | 21:37 |
| sjmc7 | he’s not a fan of romantic langauges | 21:37 |
| RickA-HP | There's also a list of fools who reviewed it :) | 21:37 |
| sjmc7 | :) it’s not quite as bad as it seems since the doc type is passed in to the search function | 21:38 |
| sjmc7 | so the only place this’d fall over would be if you had a pair of indices with the same types on them | 21:39 |
| sjmc7 | filed https://bugs.launchpad.net/searchlight/+bug/1541115 | 21:51 |
| openstack | Launchpad bug 1541115 in OpenStack Search (Searchlight) "all_projects doesn't limit on resource type" [High,New] | 21:51 |
| *** bpokorny_ has joined #openstack-searchlight | 23:50 | |
| *** bpokorny has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!