| *** jmckind has quit IRC | 00:26 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 00:48 | |
| *** bpokorny has quit IRC | 00:50 | |
| *** bpokorny has joined #openstack-security | 00:51 | |
| *** bknudson has joined #openstack-security | 00:54 | |
| *** bpokorny has quit IRC | 00:56 | |
| *** browne has quit IRC | 01:08 | |
| *** elo has joined #openstack-security | 01:09 | |
| *** elo1 has quit IRC | 01:12 | |
| *** salv-orlando has joined #openstack-security | 01:20 | |
| *** tmcpeak has quit IRC | 01:21 | |
| *** salv-orlando has quit IRC | 01:25 | |
| *** lexholden has quit IRC | 01:43 | |
| openstackgerrit | Merged openstack/anchor: Migrate to ldap3 module https://review.openstack.org/199449 | 01:46 |
|---|---|---|
| *** bpokorny has joined #openstack-security | 02:28 | |
| *** browne has joined #openstack-security | 02:40 | |
| *** tmcpeak has joined #openstack-security | 02:49 | |
| *** tmcpeak has quit IRC | 02:51 | |
| *** juriannys has joined #openstack-security | 03:03 | |
| openstackgerrit | Merged openstack/anchor: Finalise py34 compatibility https://review.openstack.org/199450 | 03:06 |
| *** juriannys has quit IRC | 03:08 | |
| *** tkelsey has joined #openstack-security | 03:14 | |
| *** elo has quit IRC | 03:14 | |
| *** tkelsey has quit IRC | 03:18 | |
| *** tmcpeak has joined #openstack-security | 03:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor: Updated from global requirements https://review.openstack.org/205044 | 03:38 |
| *** bpokorny has quit IRC | 03:47 | |
| *** rmarathu has quit IRC | 04:00 | |
| openstackgerrit | Merged openstack/bandit: Revised XML tests https://review.openstack.org/205527 | 04:03 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 04:14 | |
| openstackgerrit | Eric Brown proposed openstack/bandit: Add all available plugins to an example profile https://review.openstack.org/206868 | 05:21 |
| *** tmcpeak has quit IRC | 05:30 | |
| openstackgerrit | Darren Chan proposed openstack/security-doc: Renamed Future section and added domain information https://review.openstack.org/199393 | 05:36 |
| *** b10n1k has quit IRC | 05:41 | |
| *** be3 has joined #openstack-security | 06:12 | |
| *** be3 has quit IRC | 06:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Imported Translations from Transifex https://review.openstack.org/206886 | 06:24 |
| *** shohel has joined #openstack-security | 06:26 | |
| *** Marii has joined #openstack-security | 06:40 | |
| *** Marii has left #openstack-security | 06:42 | |
| *** browne has quit IRC | 06:49 | |
| *** alex_klimov has joined #openstack-security | 06:56 | |
| *** salv-orlando has joined #openstack-security | 07:12 | |
| openstackgerrit | Andreas Jaeger proposed openstack/security-doc: Build Japanese RST Security Guide https://review.openstack.org/206918 | 07:34 |
| *** y_sawai has joined #openstack-security | 07:42 | |
| openstackgerrit | Stanislaw Pitucha proposed openstack/anchor: [WIP] Implement new API format https://review.openstack.org/190473 | 07:44 |
| openstackgerrit | Stanislaw Pitucha proposed openstack/anchor: Add stub for Sphinx documentation https://review.openstack.org/206920 | 07:44 |
| *** seppho has joined #openstack-security | 07:48 | |
| *** y_sawai has quit IRC | 07:49 | |
| *** webhat has quit IRC | 07:50 | |
| *** webhat has joined #openstack-security | 07:51 | |
| *** seppho has quit IRC | 07:53 | |
| *** seppho has joined #openstack-security | 07:54 | |
| *** seppho has joined #openstack-security | 07:54 | |
| *** seppho has quit IRC | 07:56 | |
| *** y_sawai has joined #openstack-security | 07:58 | |
| *** y_sawai has quit IRC | 08:02 | |
| *** Windir has quit IRC | 08:14 | |
| *** Windir has joined #openstack-security | 08:16 | |
| *** tkelsey has joined #openstack-security | 08:21 | |
| *** lexholden has joined #openstack-security | 09:17 | |
| *** seppho has joined #openstack-security | 09:38 | |
| openstackgerrit | Darren Chan proposed openstack/security-doc: Renamed Future section and added domain information https://review.openstack.org/199393 | 09:46 |
| *** alex_klimov has quit IRC | 10:00 | |
| *** mitz has quit IRC | 10:00 | |
| *** airen has quit IRC | 10:00 | |
| *** dlitz has quit IRC | 10:00 | |
| *** dlitz has joined #openstack-security | 10:00 | |
| *** airen has joined #openstack-security | 10:00 | |
| *** mitz has joined #openstack-security | 10:00 | |
| *** alex_klimov has joined #openstack-security | 10:01 | |
| *** viraptor has quit IRC | 10:05 | |
| *** viraptor has joined #openstack-security | 10:06 | |
| *** lexholden has quit IRC | 10:46 | |
| *** tkelsey has quit IRC | 10:51 | |
| *** seppho has quit IRC | 10:58 | |
| *** singlethink has joined #openstack-security | 11:59 | |
| *** tkelsey has joined #openstack-security | 12:04 | |
| *** tkelsey has quit IRC | 12:09 | |
| *** salv-orl_ has joined #openstack-security | 12:22 | |
| *** salv-orlando has quit IRC | 12:25 | |
| *** salv-orlando has joined #openstack-security | 12:26 | |
| *** salv-orl_ has quit IRC | 12:26 | |
| *** edmondsw has joined #openstack-security | 12:27 | |
| *** salv-orl_ has joined #openstack-security | 12:27 | |
| *** salv-orlando has quit IRC | 12:30 | |
| *** salv-orlando has joined #openstack-security | 12:35 | |
| *** singlethink has quit IRC | 12:36 | |
| *** salv-orl_ has quit IRC | 12:38 | |
| *** shohel has quit IRC | 12:38 | |
| *** shohel has joined #openstack-security | 12:43 | |
| *** salv-orl_ has joined #openstack-security | 12:44 | |
| *** salv-orlando has quit IRC | 12:47 | |
| *** salv-orl_ has quit IRC | 12:47 | |
| *** salv-orlando has joined #openstack-security | 12:48 | |
| *** tkelsey has joined #openstack-security | 12:50 | |
| *** salv-orl_ has joined #openstack-security | 12:57 | |
| *** salv-orlando has quit IRC | 13:00 | |
| *** salv-or__ has joined #openstack-security | 13:00 | |
| *** bknudson has quit IRC | 13:01 | |
| *** tjt263 has quit IRC | 13:03 | |
| *** salv-orl_ has quit IRC | 13:04 | |
| *** tjt263 has joined #openstack-security | 13:04 | |
| *** tkelsey has quit IRC | 13:07 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:08 | |
| *** salv-or__ has quit IRC | 13:09 | |
| *** salv-orlando has joined #openstack-security | 13:11 | |
| *** dave-mccowan has joined #openstack-security | 13:13 | |
| *** tkelsey has joined #openstack-security | 13:13 | |
| *** salv-orl_ has joined #openstack-security | 13:14 | |
| *** bknudson has joined #openstack-security | 13:16 | |
| *** salv-orlando has quit IRC | 13:17 | |
| *** salv-orlando has joined #openstack-security | 13:18 | |
| *** salv-orl_ has quit IRC | 13:21 | |
| *** singlethink has joined #openstack-security | 13:24 | |
| *** lexholden has joined #openstack-security | 13:26 | |
| *** singleth_ has joined #openstack-security | 13:29 | |
| *** singlethink has quit IRC | 13:31 | |
| *** jmckind has joined #openstack-security | 13:39 | |
| openstackgerrit | Merged openstack/security-doc: Imported Translations from Transifex https://review.openstack.org/206886 | 13:41 |
| *** markvoelker has joined #openstack-security | 13:44 | |
| *** tmcpeak has joined #openstack-security | 13:45 | |
| *** singlethink has joined #openstack-security | 13:47 | |
| *** singleth_ has quit IRC | 13:50 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/207052 | 13:51 |
| *** salv-orlando has quit IRC | 13:52 | |
| *** dwyde has joined #openstack-security | 13:56 | |
| *** singleth_ has joined #openstack-security | 13:59 | |
| openstackgerrit | Merged openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/207052 | 14:00 |
| *** singlethink has quit IRC | 14:02 | |
| *** markvoelker has quit IRC | 14:04 | |
| *** y_sawai has joined #openstack-security | 14:07 | |
| *** browne has joined #openstack-security | 14:12 | |
| *** markvoelker_ has joined #openstack-security | 14:21 | |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding documentation for configuration https://review.openstack.org/205501 | 14:25 |
| Daviey | tkelsey: wow, some nice docs there! | 14:26 |
| tkelsey | thanks Daviey, there are some others in the pipeline as well | 14:27 |
| browne | Daviey: agreed, looking at them now. very nice tkelsey | 14:27 |
| *** voodookid has joined #openstack-security | 14:28 | |
| tkelsey | thanks browne, its getting there, reviews welcome im sure there are grammar/spelling/typoes etc | 14:28 |
| tkelsey | I want to move the stuff we had previously into the developer guidance project, since I think its very valuable in its own right | 14:31 |
| Daviey | For the Debian/Ubuntu package I created a rough man page.. Do you think it belongs in git? | 14:31 |
| tkelsey | hence leaving it in /old/ for now | 14:31 |
| sigmavirus24 | browne: re your LP bug report about InvocationError, I think that's a problem with tox | 14:32 |
| sigmavirus24 | Is bandit in Nova's tox.ini or were you testing something else out? | 14:32 |
| tkelsey | Daviey: humm, the "tox -e docs" will also build a manpage version of this stuff, maybe we should merge stuff in? | 14:32 |
| browne | sigmavirus24: yuck ok. well i can try without tox | 14:33 |
| sigmavirus24 | browne: well put it like this, the only InvocationError results on Google are for tox | 14:33 |
| sigmavirus24 | I've never seen that otherwise | 14:33 |
| sigmavirus24 | browne: the curious thing is that it usually means a command is missing that it's being told to execute | 14:34 |
| *** viraptor has quit IRC | 14:34 | |
| Daviey | tkelsey: Well, i'd much rather use a richer man page than the crap i put together | 14:35 |
| browne | i suspect it's somehow bandit. like one of the checks ignores the -ll parameter | 14:35 |
| tkelsey | heh, maybe drop it into an pastebin ? im sure there is valuable stuff in it we can use in the main docs? | 14:35 |
| tkelsey | Daviey: ^ | 14:35 |
| sigmavirus24 | browne: oh, maybe it's just that bandit is exiting non-zero | 14:36 |
| browne | ha, yep, its probably that simple | 14:36 |
| Daviey | tkelsey: Nah, i basically just took a subset of the readme and formatted it | 14:36 |
| sigmavirus24 | someone posted a Q on StackOverflow about running Flake8 with tox and getting an invocation error and Flake8 is working fine it's just exiting non-zero because of warnings/errors found | 14:36 |
| *** tjt263 has quit IRC | 14:37 | |
| tkelsey | Daviey: fair enough :) | 14:37 |
| *** markvoelker_ has quit IRC | 14:38 | |
| Daviey | tkelsey: I didn't realise tox -edoc created manpage format aswell.. that is much nicer.. http://anonscm.debian.org/cgit/openstack/bandit.git/tree/debian/manpages/bandit.1 | 14:38 |
| *** markvoelker has joined #openstack-security | 14:39 | |
| tkelsey | Daviey: yeah, it build a few versions of the docs | 14:39 |
| tkelsey | ls ./docs/build/ doctrees html man | 14:39 |
| browne | sigmavirus24: i ran bandit outside of tox. no errors and the exit code was 0 | 14:40 |
| sigmavirus24 | browne: odd. Did the warning not show up that showed up in the issue? | 14:41 |
| browne | sigmavirus24: http://paste.openstack.org/show/406243/ | 14:41 |
| tmcpeak | nkinder: you around? | 14:42 |
| browne | sigmavirus24: with tox: http://paste.openstack.org/show/406245/ | 14:42 |
| nkinder | tmcpeak: yeah, but in meetings for the next few hours | 14:42 |
| tmcpeak | nkinder: ok - I think I'm going to throw back that OSSN, seems very in depth for me right now | 14:42 |
| tmcpeak | I'll pick up another one | 14:42 |
| nkinder | ok | 14:43 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding documentation for test plugins https://review.openstack.org/205505 | 14:43 |
| sigmavirus24 | browne: and the bandit env is checked into nova, yes? So I can just pull it and run it? | 14:43 |
| browne | sigmavirus24: yep | 14:44 |
| * sigmavirus24 would also argue that we shouldn't be installing the projects to run bandit on the source. There's no point in that. =P | 14:44 | |
| Daviey | browne: Are you running bandit from git or latest release? | 14:44 |
| browne | Daviey: latest release | 14:44 |
| sigmavirus24 | If we were doing dynamic introspection of dependencies like hacking sort of does, then that'd be fine, but we don't so we shouldn't be installing the project or its deps | 14:45 |
| Daviey | browne: Can you try git? The reason I say is that the release on pip happily ran 0 tests giving a false sense of confidence.. now it errors out | 14:45 |
| sigmavirus24 | (for example, we never import a module so that we can test if what's being imported is a function, class, module, etc | 14:45 |
| sigmavirus24 | Daviey: it's saying 0 files were skipped, not that 0 tests were being run | 14:45 |
| Daviey | sigmavirus24: right, but did it run 0 tests on all of those files? | 14:46 |
| sigmavirus24 | Oh right, that's only in master. I understand what you mean now Daviey | 14:46 |
| *** markvoelker has quit IRC | 14:47 | |
| *** markvoelker has joined #openstack-security | 14:47 | |
| browne | hmm, so how can i run the latest bandit from source within tox? | 14:50 |
| *** janonymous_ has joined #openstack-security | 14:50 | |
| sigmavirus24 | browne: in deps do -e git+https://github.com/openstack/bandit | 14:51 |
| browne | sigmavirus24: nice, thank you | 14:51 |
| sigmavirus24 | yw | 14:51 |
| browne | hmm, it didn't like it | 14:54 |
| browne | ERROR: could not install deps [-egit+https://github.com/openstack/bandit] | 14:54 |
| sigmavirus24 | odd | 14:56 |
| sigmavirus24 | try adding .git at the end? | 14:56 |
| browne | ERROR: could not install deps [-e git+https://github.com/openstack/bandit.git] | 14:56 |
| browne | [testenv:bandit] | 14:57 |
| browne | deps = -e git+https://github.com/openstack/bandit.git | 14:57 |
| browne | commands = bandit -c bandit.yaml -r nova -n 5 -p gate -ll | 14:57 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding a more informative help message for "-l" https://review.openstack.org/207080 | 15:00 |
| *** sweston has quit IRC | 15:02 | |
| *** jmckind has quit IRC | 15:03 | |
| *** hiddentoken has joined #openstack-security | 15:03 | |
| browne | sigmavirus24: looks like the -e wasn't needed | 15:04 |
| sigmavirus24 | odd | 15:04 |
| sigmavirus24 | okay | 15:04 |
| sigmavirus24 | Didn't used to be needed | 15:04 |
| sigmavirus24 | *Used to be needed | 15:04 |
| sigmavirus24 | sorry, I'm juggling multiple issues again | 15:04 |
| * sigmavirus24 puts out all the fires | 15:04 | |
| *** alex_klimov has quit IRC | 15:04 | |
| browne | np | 15:04 |
| browne | sigmavirus24, Daviey: ok, i still get the InvocationError | 15:06 |
| sigmavirus24 | browne: right, but does it tell you that it's not running any tests? | 15:06 |
| browne | http://paste.openstack.org/show/406251/ | 15:06 |
| Daviey | Ah, well - it isn't that then | 15:07 |
| Daviey | browne: can you give your history to recreate this? | 15:07 |
| browne | sure i'll update the bug | 15:09 |
| *** hiddentoken has quit IRC | 15:09 | |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding documentation for configuration https://review.openstack.org/205501 | 15:11 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding documentation for test plugins https://review.openstack.org/205505 | 15:12 |
| *** jmckind has joined #openstack-security | 15:13 | |
| *** janonymous_ has left #openstack-security | 15:13 | |
| *** jmckind has quit IRC | 15:13 | |
| *** jmckind has joined #openstack-security | 15:14 | |
| *** alex_klimov has joined #openstack-security | 15:14 | |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding documentation for configuration https://review.openstack.org/205501 | 15:18 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding a more informative help message for "-l" https://review.openstack.org/207080 | 15:19 |
| tkelsey | any bandit folks fancy looking over: https://review.openstack.org/#/c/205499/ | 15:21 |
| tmcpeak | tkelsey: I'll take a look | 15:22 |
| tkelsey | not you tmcpeak :P | 15:22 |
| tkelsey | anyone else (tmcpeak already +2'd it) | 15:22 |
| tmcpeak | oh, lol | 15:22 |
| tkelsey | :) | 15:22 |
| tmcpeak | I can +2 again :# | 15:22 |
| tkelsey | LOL :p | 15:23 |
| browne | i'll look now | 15:23 |
| tkelsey | thanks browne | 15:23 |
| browne | tkelsey: tested it, looks good, +2 | 15:25 |
| tkelsey | awesome, thanks browne! | 15:26 |
| browne | tkelsey: you're really cranking out the commits. really good fixes | 15:26 |
| openstackgerrit | Merged openstack/bandit: Adding documentation framework https://review.openstack.org/205499 | 15:27 |
| tkelsey | thanks browne, just stuff thats been in my pipeline for a while | 15:27 |
| tkelsey | its nice to have time to focus on bandit for a bit :) | 15:27 |
| browne | tkelsey: i bet. if others are like me, i feel like i have 5 jobs | 15:28 |
| *** bpokorny has joined #openstack-security | 15:28 | |
| tkelsey | haha yeah browne I know the feeling | 15:28 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding documentation for test plugins https://review.openstack.org/205505 | 15:30 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding any_other_function_with_shell_equals_true documentation https://review.openstack.org/207099 | 15:39 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding assert_used documentation https://review.openstack.org/207104 | 15:45 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding assert_used documentation https://review.openstack.org/207104 | 15:47 |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding any_other_function_with_shell_equals_true documentation https://review.openstack.org/207099 | 15:49 |
| *** alex_klimov has quit IRC | 15:51 | |
| openstackgerrit | Tim Kelsey proposed openstack/bandit: Adding "exec_used" documentation https://review.openstack.org/207110 | 15:52 |
| *** tkelsey has quit IRC | 15:58 | |
| *** y_sawai_ has joined #openstack-security | 16:05 | |
| *** y_sawai has quit IRC | 16:08 | |
| *** sdake has joined #openstack-security | 16:09 | |
| *** jraim has quit IRC | 16:13 | |
| *** serverascode has quit IRC | 16:13 | |
| *** jraim has joined #openstack-security | 16:26 | |
| *** browne has quit IRC | 16:27 | |
| *** sweston has joined #openstack-security | 16:33 | |
| *** sdake has quit IRC | 16:37 | |
| *** serverascode has joined #openstack-security | 16:42 | |
| *** sdake has joined #openstack-security | 16:53 | |
| *** jmckind has quit IRC | 17:04 | |
| *** salv-orlando has joined #openstack-security | 17:14 | |
| *** elo has joined #openstack-security | 17:14 | |
| *** browne has joined #openstack-security | 17:19 | |
| *** salv-orlando has quit IRC | 17:20 | |
| *** salv-orlando has joined #openstack-security | 17:22 | |
| *** shohel has quit IRC | 17:54 | |
| *** browne has quit IRC | 18:02 | |
| *** browne has joined #openstack-security | 18:04 | |
| *** openstackgerrit has quit IRC | 18:31 | |
| *** openstackgerrit has joined #openstack-security | 18:32 | |
| openstackgerrit | Tom Cocozzello proposed openstack/bandit: Activate pep8 check that _ is imported https://review.openstack.org/207160 | 18:32 |
| *** salv-orlando has quit IRC | 18:40 | |
| *** sdake has quit IRC | 18:43 | |
| *** y_sawai has joined #openstack-security | 18:45 | |
| *** sdake has joined #openstack-security | 18:46 | |
| *** y_sawai_ has quit IRC | 18:48 | |
| *** jmckind has joined #openstack-security | 18:50 | |
| *** salv-orlando has joined #openstack-security | 19:01 | |
| *** jmckind has quit IRC | 19:31 | |
| *** salv-orlando has quit IRC | 19:35 | |
| *** jmckind has joined #openstack-security | 19:43 | |
| *** salv-orlando has joined #openstack-security | 19:51 | |
| *** edmondsw has quit IRC | 20:01 | |
| *** openstackgerrit has quit IRC | 20:16 | |
| *** openstackgerrit has joined #openstack-security | 20:16 | |
| *** y_sawai has quit IRC | 20:30 | |
| *** hiddentoken has joined #openstack-security | 20:32 | |
| *** jmckind has quit IRC | 20:33 | |
| *** salv-orlando has quit IRC | 20:36 | |
| *** salv-orlando has joined #openstack-security | 20:46 | |
| *** edmondsw has joined #openstack-security | 20:50 | |
| *** dwyde has quit IRC | 20:59 | |
| *** shohel has joined #openstack-security | 21:06 | |
| *** singlethink has joined #openstack-security | 21:19 | |
| *** singlet__ has joined #openstack-security | 21:21 | |
| *** singleth_ has quit IRC | 21:22 | |
| *** singlethink has quit IRC | 21:24 | |
| *** hiddentoken has quit IRC | 21:30 | |
| *** shohel has quit IRC | 21:33 | |
| *** baby has joined #openstack-security | 21:35 | |
| baby | :) | 21:36 |
| *** dwyde has joined #openstack-security | 21:37 | |
| *** baby has quit IRC | 21:43 | |
| *** elo has quit IRC | 21:43 | |
| *** elo has joined #openstack-security | 21:44 | |
| tmcpeak | ^ the most pleasant spammer yet | 21:44 |
| elmiko | lol | 21:44 |
| sigmavirus24 | :) | 21:44 |
| sigmavirus24 | :) | 21:44 |
| sigmavirus24 | :) | 21:44 |
| sigmavirus24 | =P | 21:44 |
| elmiko | although, i have to say... | 21:44 |
| elmiko | nobody puts baby in the corner | 21:45 |
| tmcpeak | look at all this positivity | 21:45 |
| sigmavirus24 | elmiko: not with a face like that | 21:45 |
| elmiko | lol | 21:45 |
| tmcpeak | I would have put baby in the corner if it/she/he started speaking spanish | 21:45 |
| elmiko | haha | 21:46 |
| sigmavirus24 | tmcpeak: what has the spanish language ever done to you? | 21:46 |
| tmcpeak | 9/10 dentists agree that the #openstack-security spammers are predominantly Spanish speakers | 21:47 |
| sigmavirus24 | Are these lion poaching dentists/ | 21:48 |
| sigmavirus24 | *? | 21:48 |
| tmcpeak | lol, what an s-storm that turned out to be | 21:48 |
| elmiko | lion poaching... /me scratches head | 21:50 |
| tmcpeak | sigmavirus24: what's the deal with this? https://review.openstack.org/#/c/207160/1 | 21:52 |
| sigmavirus24 | tmcpeak: we don't do localization, right? | 21:54 |
| tmcpeak | I'm sad to say I don't really even know what that means | 21:54 |
| sigmavirus24 | We don't use translations for user-facing output | 21:55 |
| tmcpeak | like we don't have translated versions of Bandit? | 21:55 |
| tmcpeak | yeah, we don't | 21:55 |
| sigmavirus24 | Right | 21:55 |
| sigmavirus24 | So that line treats _ (commonly used to translate text) as a builtin | 21:55 |
| sigmavirus24 | So you can import it and hacking won't complain that you're importing a function | 21:55 |
| sigmavirus24 | We don't need it | 21:55 |
| sigmavirus24 | It's not really a big deal whether we merge it | 21:55 |
| tmcpeak | ok, if we did do localization in the future, would this make it eassier? | 21:56 |
| sigmavirus24 | If we ever have plans to do localization we'll need it again for hacking but I don't think that's in the cards for us | 21:56 |
| sigmavirus24 | so | 21:56 |
| sigmavirus24 | Right | 21:56 |
| tmcpeak | ok, I'll follow your lead - whatever you think makes sense here | 21:56 |
| sigmavirus24 | Do we think we'll want localization? | 21:58 |
| sigmavirus24 | I mean really even if we ever will add localization, we can just add this back when we need it | 21:58 |
| sigmavirus24 | It's a fairly well known thing in OpenStack landia | 21:59 |
| tmcpeak | ahh ok | 22:00 |
| tmcpeak | I don't particularly care about localization one way or the other | 22:00 |
| sigmavirus24 | we probably copied some project's config that uses oslo.i18n and that's why we have it there | 22:00 |
| sigmavirus24 | that or the cookiecutter that we use includes it by default | 22:00 |
| openstackgerrit | Merged openstack/bandit: Activate pep8 check that _ is imported https://review.openstack.org/207160 | 22:00 |
| tmcpeak | ahh ok | 22:00 |
| sigmavirus24 | The commit message is kind of meh | 22:01 |
| sigmavirus24 | but whatever | 22:01 |
| elmiko | if we ever find some translators, implementing the translation stuff in code is actually pretty painless | 22:01 |
| sigmavirus24 | Yep | 22:02 |
| *** markvoelker has quit IRC | 22:02 | |
| sigmavirus24 | It is another dependency though | 22:02 |
| elmiko | yea, and probably not worth it unless folks are asking for it | 22:02 |
| sigmavirus24 | ==elmiko | 22:02 |
| *** dwyde has quit IRC | 22:07 | |
| *** voodookid has quit IRC | 22:07 | |
| *** baby has joined #openstack-security | 22:25 | |
| *** voodookid has joined #openstack-security | 22:25 | |
| *** bknudson has quit IRC | 22:25 | |
| *** baby has quit IRC | 22:29 | |
| *** voodookid has quit IRC | 22:29 | |
| *** sigmavirus24 has quit IRC | 22:31 | |
| *** sigmavirus24 has joined #openstack-security | 22:34 | |
| *** singlet__ has quit IRC | 22:35 | |
| *** viraptor has joined #openstack-security | 22:35 | |
| *** sdake has quit IRC | 22:40 | |
| *** sdake has joined #openstack-security | 22:40 | |
| *** sdake has quit IRC | 22:42 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:43 | |
| *** voodookid has joined #openstack-security | 22:45 | |
| *** markvoelker_ has joined #openstack-security | 22:57 | |
| *** baby has joined #openstack-security | 23:02 | |
| *** voodookid has quit IRC | 23:05 | |
| *** baby has quit IRC | 23:08 | |
| *** elo1 has joined #openstack-security | 23:12 | |
| *** elo has quit IRC | 23:14 | |
| *** tmcpeak has quit IRC | 23:38 | |
| *** jamielennox is now known as jamielennox|away | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!