Thursday, 2017-04-13

mordredrods: hi! the designate client calls are probably pretty easy to get started with - although wow, I just realized three of four things you'd need to know that I don't have writtne down00:31
mordredbut tl;dr is - pick a test to work on (I always start with a single test when I'm doing a new service) - change the base class of the test class to base.RequestsMockTestCase instead of base.TestCase00:33
mordredadd an entry to shade/tests/unit/fixtures/catalog-v3.json for dns - then remove the @mock entries from one of the tests, run it and start watching what requests_mock complains is missing :)00:34
rodsmordred hi, this looked as an easy one https://github.com/openstack-infra/shade/blob/master/shade/openstackcloud.py#L171800:38
rodsjust started from it :)00:38
mordredawesome! I'm getting close to AFK for the night - but let me know if you get stuck anywhere and I'll do what I can to help00:46
rodsmordred cool, thx00:47
*** jamielennox is now known as jamielennox|away04:01
*** jamielennox|away is now known as jamielennox04:29
*** jamielennox is now known as jamielennox|away06:52
*** ioggstream has joined #openstack-shade07:28
*** Aqsa has joined #openstack-shade07:51
*** cdent has joined #openstack-shade08:47
-openstackstatus- NOTICE: zuul was restarted due to an unrecoverable disconnect from gerrit. If your change is missing a CI result and isn't listed in the pipelines on http://status.openstack.org/zuul/ , please recheck08:52
*** cdent has quit IRC09:07
*** cdent has joined #openstack-shade09:50
*** jamielennox|away is now known as jamielennox11:18
*** jamielennox is now known as jamielennox|away12:05
*** cdent has quit IRC12:12
*** gouthamr has joined #openstack-shade13:28
*** cdent has joined #openstack-shade13:33
openstackgerritMonty Taylor proposed openstack-infra/shade master: Pass in app_name information to keystoneauth  https://review.openstack.org/45626814:12
openstackgerritMonty Taylor proposed openstack-infra/shade master: Use keystone_session in _get_raw_client  https://review.openstack.org/45663314:12
openstackgerritMonty Taylor proposed openstack-infra/shade master: Pass shade version info to session user_agent  https://review.openstack.org/45663414:12
mordredjamielennox|away, samueldmq, morgan: after chatting with jamie yesterday, I believe that's what that wants to look like14:12
openstackgerritMonty Taylor proposed openstack-infra/shade master: Pass shade version info to session user_agent  https://review.openstack.org/45663415:06
*** melwitt_ has joined #openstack-shade15:09
*** dtroyer_zz has joined #openstack-shade15:09
*** mordred1 has joined #openstack-shade15:10
*** dtroyer has quit IRC15:10
*** melwitt has quit IRC15:10
*** thingee has quit IRC15:10
*** mordred has quit IRC15:10
*** TheJulia has quit IRC15:10
*** Shrews has quit IRC15:10
*** Shrews has joined #openstack-shade15:11
*** thingee has joined #openstack-shade15:13
*** TheJulia has joined #openstack-shade15:18
openstackgerritMonty Taylor proposed openstack/os-client-config master: Add ability to pass in user_agent  https://review.openstack.org/45255015:39
*** mordred1 is now known as mordred15:46
morganmordred: interesting15:56
*** openstack has joined #openstack-shade16:32
*** openstackstatus has joined #openstack-shade16:35
*** ChanServ sets mode: +v openstackstatus16:35
*** melwitt_ is now known as melwitt16:43
rodsit is possible that the names of these two tests have been inverted? https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_caching.py#L195 and https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_caching.py#L213?16:47
rodsseems like the first one is doing the invalidation but the second has `invalidates` in the name16:47
mordredrods: no - they're right. the first one is testing that list_volumes is being cached - the invalidates in the test is to verify that the previous call was returning the cached value16:50
mordredthe second test is testing that issuing a create automatically invalidates the cache16:50
mordredso the test doens'tneed to do an invalidate itself16:51
rodsoh, I see16:51
*** Aqsa has quit IRC17:03
*** ioggstream has quit IRC17:23
rodsmordred I'm trying to upgrade test_list_volumes to use requests_mock. For the cache tests we need to fake two api calls to return different results but looks like register_uris can be called just once per test. https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/base.py#L475. Any hint?17:25
rodssorry trying to get familiar with the code17:25
mordredrods: you can pass a list of calls in to it -- for instance: https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_flavors.py#L46-L5717:26
mordredso if you put in a list of the calls in sequence - it'll do the right things17:26
mordredrods: and no worries - there's a bunch of stuff going on - thanks for digging in!17:27
*** cdent has quit IRC18:45
*** gouthamr has quit IRC19:17
openstackgerritRosario Di Somma proposed openstack-infra/shade master: Use REST for the cinder volumes list  https://review.openstack.org/45673619:18
rods^^ still a working progress(there is an other test to fix) but I'd love some feedback :)19:22
*** cdent has joined #openstack-shade19:27
-openstackstatus- NOTICE: The Gerrit service on http://review.openstack.org is being restarted to address hung remote replication tasks.19:52
*** cdent has quit IRC19:59
*** ioggstream has joined #openstack-shade20:10
*** gouthamr has joined #openstack-shade20:10
*** Aqsa has joined #openstack-shade20:14
*** cdent has joined #openstack-shade21:04
*** ioggstream has quit IRC21:12
*** cdent has quit IRC21:25
*** jamielennox|away is now known as jamielennox22:19
*** Aqsa has quit IRC22:40
*** gouthamr has quit IRC23:24
*** gouthamr has joined #openstack-shade23:35

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!