| *** gouthamr has quit IRC | 02:49 | |
| *** ioggstream has joined #openstack-shade | 07:28 | |
| *** cdent has joined #openstack-shade | 08:24 | |
| *** Aqsa has joined #openstack-shade | 08:49 | |
| *** Aqsa has quit IRC | 10:02 | |
| *** Aqsa has joined #openstack-shade | 10:12 | |
| *** Aqsa has quit IRC | 12:02 | |
| *** gouthamr has joined #openstack-shade | 12:26 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: WIP: Use REST for the cinder volumes list https://review.openstack.org/456736 | 13:05 |
|---|---|---|
| *** ioggstream has quit IRC | 13:08 | |
| *** larainema has quit IRC | 14:02 | |
| *** larainema has joined #openstack-shade | 14:02 | |
| mordred | rods: awesome! I shall start looking now | 14:13 |
| rods | mordred hey, I'm not sure I understand this test https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_caching.py#L213 | 14:15 |
| rods | don't see where the volume creation that should invalidate the cache happens | 14:15 |
| mordred | aha! | 14:18 |
| mordred | rods: I didn't either - but it turns out I lied about what that's testing (oops) | 14:19 |
| mordred | it's testing that a volume with status "creating" causes the volume list to not be cached in the first place | 14:19 |
| mordred | (there is a filter in the caching logic that will not cache the list if any of the volumes are in a known-temporary state) | 14:20 |
| mordred | so I think if you change your first 'available' to 'creating' on line 221 in your patch, it should do the rightthing | 14:20 |
| mordred | so the test should be showing that GET is called twice, since the first GET returned a volume in 'creating' state | 14:21 |
| * mordred looks at the other test to try to spot what's unhappy there | 14:22 | |
| rods | mordred looks like the other tests is making a call to create_volume, I think I need to patch that before call before I can finish the work on the list_volume | 14:23 |
| mordred | nod. so - in the test_list_volumes test - I think it may need to be restructured a little bit, because of how self.assert_calls() is going to work ... I'll write a comment in the review | 14:24 |
| rods | mordred great, thanks for looking at it | 14:28 |
| mordred | rods: sweet - comments left - good work so far! | 14:29 |
| rods | :) | 14:30 |
| *** ioggstream has joined #openstack-shade | 14:43 | |
| *** cdent has quit IRC | 14:49 | |
| *** larainema has quit IRC | 16:12 | |
| *** Aqsa has joined #openstack-shade | 17:22 | |
| *** ioggstream has quit IRC | 17:30 | |
| *** cdent has joined #openstack-shade | 18:13 | |
| *** cdent has quit IRC | 18:24 | |
| *** Aqsa has quit IRC | 18:45 | |
| *** Aqsa has joined #openstack-shade | 18:54 | |
| *** Aqsa has quit IRC | 20:17 | |
| *** gouthamr has quit IRC | 20:35 | |
| *** gouthamr has joined #openstack-shade | 20:58 | |
| *** slaweq has joined #openstack-shade | 21:56 | |
| slaweq | hello | 21:57 |
| slaweq | I read mordred's mail about contributing to shade project and I wanted to help on transition from neutronclient to REST api calls | 21:58 |
| slaweq | do You know maybe if somebody is already doing this? | 21:58 |
| slaweq | or can I work on it? | 21:58 |
| *** gouthamr has quit IRC | 22:03 | |
| *** gouthamr has joined #openstack-shade | 23:21 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!