| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Move user list to REST and build API URL https://review.openstack.org/457745 | 00:08 |
|---|---|---|
| *** topol has quit IRC | 00:54 | |
| *** rods has quit IRC | 01:12 | |
| *** rods has joined #openstack-shade | 01:14 | |
| *** rods has quit IRC | 01:15 | |
| *** ioggstream has quit IRC | 01:15 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Discover the identity endpoint https://review.openstack.org/457832 | 01:30 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Move user list to REST https://review.openstack.org/457745 | 01:38 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Move user list to REST https://review.openstack.org/457745 | 01:51 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Move user list to REST https://review.openstack.org/457745 | 01:56 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Discover the identity endpoint https://review.openstack.org/457832 | 01:56 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Move user list to REST https://review.openstack.org/457745 | 01:58 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Discover the identity endpoint https://review.openstack.org/457832 | 01:58 |
| samueldmq | Ok I messed up with gerrit enough for today | 02:00 |
| *** yolanda has quit IRC | 02:26 | |
| *** yolanda has joined #openstack-shade | 02:26 | |
| *** gouthamr has quit IRC | 03:32 | |
| *** gkadam has joined #openstack-shade | 03:43 | |
| *** gkadam is now known as Guest79394 | 03:43 | |
| *** Guest79394 has quit IRC | 03:44 | |
| *** gkadam_ has joined #openstack-shade | 03:44 | |
| *** gkadam_ is now known as gkadam | 03:45 | |
| *** yfried has joined #openstack-shade | 05:18 | |
| *** yfried has quit IRC | 05:40 | |
| *** yfried has joined #openstack-shade | 05:54 | |
| *** ioggstream has joined #openstack-shade | 07:27 | |
| *** slaweq has joined #openstack-shade | 07:43 | |
| *** yolanda has quit IRC | 07:54 | |
| *** yolanda has joined #openstack-shade | 08:30 | |
| ioggstream | hi@all | 08:53 |
| ioggstream | I've stumbled upon this while openshift-on-openstack with 3.5 https://bugzilla.redhat.com/show_bug.cgi?id=1443270 | 08:54 |
| openstack | bugzilla.redhat.com bug 1443270 in Installer "Broken rpm dependencies during installation" [Unspecified,Closed: duplicate] - Assigned to sdodson | 08:54 |
| ioggstream | anyone on openshift-on-openstack playbooks ? | 08:56 |
| *** yolanda_ has joined #openstack-shade | 08:59 | |
| *** yolanda_ has quit IRC | 09:01 | |
| *** yolanda_ has joined #openstack-shade | 09:01 | |
| *** yolanda has quit IRC | 09:03 | |
| *** cdent has joined #openstack-shade | 09:08 | |
| *** slaweq has quit IRC | 09:09 | |
| ioggstream | ooops ;) sorry, bad chat :D | 09:28 |
| *** cdent has quit IRC | 10:00 | |
| *** cdent has joined #openstack-shade | 11:01 | |
| *** yfried has quit IRC | 11:02 | |
| *** ioggstream has quit IRC | 11:26 | |
| *** ioggstream has joined #openstack-shade | 11:53 | |
| *** ioggstream has quit IRC | 12:00 | |
| *** yolanda_ has quit IRC | 12:04 | |
| *** yolanda has joined #openstack-shade | 12:04 | |
| *** yolanda has quit IRC | 12:04 | |
| *** yolanda has joined #openstack-shade | 12:05 | |
| *** cdent has quit IRC | 12:18 | |
| *** ioggstream has joined #openstack-shade | 12:33 | |
| *** ioggstream has quit IRC | 12:37 | |
| openstackgerrit | Merged openstack-infra/shade master: Use REST for cinder list volumes https://review.openstack.org/457665 | 12:38 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Clarify some variable names in glance discovery https://review.openstack.org/458055 | 12:42 |
| *** ioggstream has joined #openstack-shade | 12:53 | |
| *** gouthamr has joined #openstack-shade | 12:59 | |
| *** ioggstream has quit IRC | 13:02 | |
| *** rods has joined #openstack-shade | 13:03 | |
| *** ioggstream has joined #openstack-shade | 13:04 | |
| openstackgerrit | Merged openstack-infra/shade master: _discover_latest_version is private and not used https://review.openstack.org/457787 | 13:09 |
| *** gkadam has quit IRC | 13:17 | |
| *** yolanda has quit IRC | 13:20 | |
| mordred | jamielennox: if you're still awake, samueldmq wrote up a doc string describing the process we're going to use for getting an identity adapater that works on all the clouds and honors user's override config: https://review.openstack.org/457832 | 13:21 |
| mordred | jamielennox: I'd love a sanity check from you on it - to see if we missed anything | 13:21 |
| mordred | jamielennox: one of the end results once we're done with this for each service is that we should be able to drop those default api_version override values out of os-client-config, which I know you've wanted for a while | 13:21 |
| jamielennox | mordred: is that discover something you're implementing? | 13:24 |
| jamielennox | keystoneauth has a process fairly similar - but not exactly that | 13:24 |
| jamielennox | mordred: if you pass version=(X,Y) to the get_endpoint function it invokes keystoneauth's discover which i know is good for identity | 13:27 |
| jamielennox | and will do the /v2.0 strip | 13:27 |
| mordred | jamielennox: oh neat. so - lemme go look at that. if that's pretty much good, can would you accept patches to keystoneauth to support the other services too? | 13:31 |
| mordred | (if they need it) | 13:31 |
| jamielennox | mordred: i know it works for the primary ones, but yea, absolutely we'd support the others | 13:31 |
| mordred | cool | 13:31 |
| mordred | I'll go poke at that in just a second- thanks | 13:32 |
| jamielennox | mordred: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/identity/base.py#L221 down is the logic for this | 13:32 |
| mordred | jamielennox: what if the user doens't pass a version and you just want the latest? | 13:32 |
| jamielennox | mordred: yea, the comment basically under ^ says that we return the service catalog url by default | 13:33 |
| *** yolanda has joined #openstack-shade | 13:33 | |
| mordred | ah I see you just return the catalog url there ... | 13:33 |
| jamielennox | and acknowledges it's a bad idea | 13:33 |
| mordred | could we maybe support another param like latest=True or something? | 13:33 |
| jamielennox | yea, something like that is fine | 13:33 |
| mordred | cool. we'll get a patch cookedup | 13:33 |
| jamielennox | or version=LATEST | 13:33 |
| *** rods has quit IRC | 13:34 | |
| mordred | yah | 13:34 |
| jamielennox | let me know tomorrow - night | 13:38 |
| mordred | jamielennox: there's one more case I'd like to add, maybe also by a flag - I'll just write a couple of patches for that and see what you think - it should be _very_ simple - also- thank you | 13:38 |
| jamielennox | ok | 13:38 |
| mordred | the get_discovery caching the discovery stuff is all great | 13:38 |
| jamielennox | no worries | 13:39 |
| jamielennox | we should probably etag that or something - but no one does that | 13:39 |
| mordred | well, we should anyway :) | 13:39 |
| jamielennox | ship cachecontrol by default :) | 13:40 |
| samueldmq | morning all | 13:43 |
| samueldmq | mordred: jamielennox o/ | 13:43 |
| *** rods has joined #openstack-shade | 13:46 | |
| *** yolanda has quit IRC | 14:08 | |
| *** yolanda has joined #openstack-shade | 14:08 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use requests-mock for all the test_attach_volume_* tests https://review.openstack.org/458100 | 14:15 |
| rods | another small step :) | 14:16 |
| rods | I hope to get all the tests in the test_volume.py module updated by today | 14:16 |
| mordred | rods: awesome. so - there is a thing you probably want to do on POST calls - which is add a validate= field. validate then itself takes a dictionary similar to the dictionary in register_uris ... | 14:21 |
| mordred | so you can do validate=dict(json={... to verify that the payload sent to the POST by the application is correct | 14:22 |
| mordred | you can see an example around line 171 here: https://review.openstack.org/#/c/457548/4/shade/tests/unit/test_security_groups.py | 14:23 |
| rods | mordred sure, I'll fix it | 14:25 |
| *** yolanda has quit IRC | 14:38 | |
| *** yolanda has joined #openstack-shade | 14:39 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use requests-mock for all the test_attach_volume_* tests https://review.openstack.org/458100 | 15:28 |
| *** yolanda has quit IRC | 15:28 | |
| *** yolanda has joined #openstack-shade | 15:29 | |
| mordred | rods: couple of more small things - the assert_calls() are important - if you want to deal with the normalize_volume_attachment in a different patch / later that's fine by me | 15:40 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Strip trailing slashes in test helper method https://review.openstack.org/458139 | 15:41 |
| mordred | rods: also - that ^^ should fix the // issue - but I don't think stripping it in the catalog in your patch is fine - really either way | 15:41 |
| mordred | (mostly wrote that patch in case someone else hit the same thing in the future) | 15:42 |
| rods | mordred makes sense, I'll move the _normalize_volume_attachment into attach_volume and revert the slash stripping | 15:50 |
| mordred | cool | 16:32 |
| *** ioggstream has quit IRC | 17:20 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use requests-mock for all the test_attach_volume_* tests https://review.openstack.org/458100 | 18:38 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use requests-mock for all the test_attach_volume_* tests https://review.openstack.org/458100 | 18:47 |
| *** rods has quit IRC | 18:58 | |
| *** rods has joined #openstack-shade | 19:01 | |
| *** cdent has joined #openstack-shade | 20:08 | |
| *** cdent has quit IRC | 20:17 | |
| *** gouthamr has quit IRC | 21:29 | |
| *** rods has quit IRC | 22:20 | |
| *** rods has joined #openstack-shade | 22:28 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Move user list to REST https://review.openstack.org/457745 | 23:39 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Discover the identity endpoint https://review.openstack.org/457832 | 23:39 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!