*** rods has quit IRC | 01:00 | |
*** gouthamr has joined #openstack-shade | 02:45 | |
*** gkadam has joined #openstack-shade | 02:53 | |
*** Matias has quit IRC | 03:30 | |
*** Matias has joined #openstack-shade | 03:32 | |
*** gouthamr has quit IRC | 05:54 | |
*** jamielennox has quit IRC | 07:28 | |
*** gkadam has quit IRC | 07:29 | |
*** gkadam has joined #openstack-shade | 07:29 | |
*** jamielennox has joined #openstack-shade | 07:42 | |
*** ioggstream has joined #openstack-shade | 07:55 | |
*** gkadam is now known as gkadam-afk | 09:26 | |
*** cdent has joined #openstack-shade | 09:30 | |
*** rods has joined #openstack-shade | 09:44 | |
*** cdent_ has joined #openstack-shade | 09:57 | |
*** cdent has quit IRC | 09:58 | |
*** cdent_ is now known as cdent | 09:58 | |
*** cdent_ has joined #openstack-shade | 10:38 | |
*** cdent has quit IRC | 10:40 | |
*** cdent_ is now known as cdent | 10:40 | |
*** cdent has quit IRC | 11:31 | |
*** openstackgerrit has quit IRC | 11:32 | |
*** yfried has joined #openstack-shade | 11:44 | |
yfried | mordred: ping, shade deps just killed us again :( | 11:44 |
---|---|---|
yfried | dhellmann: ^ | 11:51 |
*** rods has quit IRC | 12:05 | |
*** rods has joined #openstack-shade | 12:05 | |
*** rods has quit IRC | 12:10 | |
mordred | yfried: we haven't cut a release yet | 12:28 |
mordred | yfried: what's the issue this time? | 12:28 |
mordred | yfried: (I was actually just about to get a release made) | 12:28 |
yfried | mordred: https://paste.fedoraproject.org/paste/LuAMTicTcCpJlGrZOPgE3F5M1UNdIGYhyRLivL9gydE= | 12:29 |
mordred | yfried: k. https://review.openstack.org/458487 submitted for release | 12:36 |
yfried | mordred: were did you fix Bable? | 12:39 |
mordred | I don't depend on babel - it's in a transitive depend somewhere | 12:39 |
yfried | mordred: so it will break, won't it? | 12:40 |
mordred | it might break, yes - the pbr version is the one I can fix - we'll need to investigate more to see which libraries have incompatible babel versions | 12:41 |
yfried | mordred: why is it so hard to depend on shade? | 12:43 |
yfried | mordred: does Neutron hit the same bugs we do daily? | 12:43 |
mordred | it's because we are currently depending on the python client libs. everything about this will go away as soon as we're done not depending on them | 12:44 |
mordred | which is why we're spending basically all day every day doing nothing but removing out dependency on the shit-tastic python client libs | 12:45 |
mordred | in any case, this issue was caused because osc-lib released and it has a different exclusion on babel than novaclient does, but novaclient got depended on first so was the one to cause babel to be installed | 12:46 |
mordred | this is also hard specifically because of the use of pkg_resources which is _extra_ "helpful" in complaining about when you don't have the 'right' version of something installed at runtime | 12:47 |
*** gkadam-afk has quit IRC | 12:51 | |
yfried | mordred: please add pip check to some gate | 12:51 |
Shrews | That wouldn't be useful. We can't control the versions of libraries used the client libs. The only solution is to get rid of the client libs. | 12:57 |
mordred | yup | 13:02 |
mordred | next up - ironicclient | 13:03 |
mordred | unfortunately, TheJulia did a REALLY good job with it and there are many test | 13:03 |
mordred | thanks TheJulia | 13:03 |
mordred | :) | 13:03 |
Shrews | TheJulia iz teh awwsum | 13:04 |
*** rods has joined #openstack-shade | 13:04 | |
*** yfried has quit IRC | 13:17 | |
*** yfried has joined #openstack-shade | 13:17 | |
*** ioggstream has quit IRC | 13:24 | |
*** ioggstream has joined #openstack-shade | 13:34 | |
*** yfried has quit IRC | 13:34 | |
*** rods has quit IRC | 13:58 | |
*** yfried has joined #openstack-shade | 14:13 | |
*** rods has joined #openstack-shade | 14:14 | |
*** gouthamr has joined #openstack-shade | 14:18 | |
*** rods has quit IRC | 14:19 | |
*** rods has joined #openstack-shade | 14:21 | |
dtroyer_zz | mordred: /me is trying to sort out why osc-lib even has Babel in requirements.txt | 14:30 |
mordred | dtroyer_zz: transitive depends maybe? | 14:45 |
dtroyer_zz | It is, from osli_i18n, so osc-lib shouldn't be include it, eh? | 14:46 |
mordred | dtroyer_zz: if I make a fresh venv and pip install shade into it, then try to load an entrypoint with pkg_resources that touches shade, I get this: | 14:47 |
mordred | pkg_resources.ContextualVersionConflict: (Babel 2.4.0 (/home/mordred/foo/lib/python2.7/site-packages), Requirement.parse('Babel!=2.4.0,>=2.3.4'), set(['osc-lib'])) | 14:47 |
mordred | dtroyer_zz: although, to be fair, there are two other conflicts that have to be fixed before that surfaces | 14:47 |
dtroyer_zz | mordred: osc-lib matches osli.i18n for babel in g-r | 14:48 |
dtroyer_zz | in master | 14:48 |
mordred | dtroyer_zz: http://paste.openstack.org/show/607356/ is a reproduction walkthrough, should you be interested | 14:51 |
mordred | dhellmann: ^^ | 14:51 |
rods | mordred hi, I left a comment on this pr https://review.openstack.org/#/c/458100/4, can you give a look when you have a second? | 15:10 |
*** openstackgerrit has joined #openstack-shade | 15:54 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add documentation of algorithm for version discovery https://review.openstack.org/458565 | 15:54 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add text about microversions https://review.openstack.org/458566 | 15:54 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove future document https://review.openstack.org/458567 | 15:54 |
mordred | rods: responded - great question | 15:54 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove stray line https://review.openstack.org/458569 | 15:56 |
rods | mordred I like the idea of the assert_no_calls method, I'm gonna go with self.assertEqual(0, len(self.adapter.request_history)) for now and implement assert_no_calls in a different pull request | 15:57 |
mordred | sounds great | 15:58 |
mordred | rods: also, the strip trailing slash patch is winding its way through the gate now, so should be in soon | 15:58 |
rods | cool | 15:59 |
*** yfried has quit IRC | 16:00 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove future document https://review.openstack.org/458567 | 16:11 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add text about microversions https://review.openstack.org/458566 | 16:11 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add documentation of algorithm for version discovery https://review.openstack.org/458565 | 16:11 |
mordred | samueldmq: ^^ I took your PS-3 docstring and expanded it (greatly) into a document | 16:12 |
samueldmq | mordred: yay! I will take a look at it today for sure! | 16:59 |
openstackgerrit | Merged openstack-infra/shade master: Remove extra unneeded API calls https://review.openstack.org/457775 | 17:12 |
openstackgerrit | Merged openstack-infra/shade master: Clarify some variable names in glance discovery https://review.openstack.org/458055 | 17:13 |
*** ioggstream has quit IRC | 17:20 | |
*** cdent has joined #openstack-shade | 17:30 | |
*** yfried has joined #openstack-shade | 18:04 | |
*** cdent has quit IRC | 18:21 | |
*** yfried has quit IRC | 18:42 | |
*** yfried has joined #openstack-shade | 18:46 | |
*** yfried has quit IRC | 18:51 | |
openstackgerrit | Merged openstack-infra/shade master: Strip trailing slashes in test helper method https://review.openstack.org/458139 | 19:05 |
mordred | rods: ^^ there ya go | 19:05 |
rods | mordred great, I'll fix my commit in a minute | 19:06 |
openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use requests-mock for all the test_attach_volume_* tests https://review.openstack.org/458100 | 19:12 |
*** yfried has joined #openstack-shade | 19:27 | |
rods | mordred ^^ should be ready to go :) | 20:01 |
*** rods has quit IRC | 20:03 | |
*** rods has joined #openstack-shade | 20:05 | |
*** yfried has quit IRC | 20:20 | |
*** yolanda has quit IRC | 20:35 | |
*** cdent has joined #openstack-shade | 21:03 | |
*** cdent has quit IRC | 21:50 | |
*** cdent has joined #openstack-shade | 21:54 | |
*** gouthamr has quit IRC | 21:57 | |
*** jamielennox is now known as jamielennox|away | 22:25 | |
*** jamielennox|away is now known as jamielennox | 22:29 | |
*** rods has quit IRC | 22:51 | |
*** cdent has quit IRC | 22:59 | |
*** rods has joined #openstack-shade | 23:02 | |
*** gouthamr has joined #openstack-shade | 23:33 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!