| *** gouthamr has quit IRC | 00:53 | |
| *** gouthamr has joined #openstack-shade | 03:03 | |
| *** morgan has quit IRC | 03:21 | |
| *** yolanda has joined #openstack-shade | 04:13 | |
| *** slaweq has joined #openstack-shade | 04:53 | |
| *** slaweq has quit IRC | 04:58 | |
| *** gouthamr has quit IRC | 05:52 | |
| *** jamielennox is now known as jamielennox|away | 06:55 | |
| *** slaweq has joined #openstack-shade | 07:03 | |
| *** slaweq has quit IRC | 07:06 | |
| *** slaweq has joined #openstack-shade | 08:22 | |
| *** slaweq has quit IRC | 09:55 | |
| *** slaweq has joined #openstack-shade | 09:57 | |
| *** slaweq has quit IRC | 09:57 | |
| *** slaweq has joined #openstack-shade | 11:34 | |
| *** slaweq has quit IRC | 11:41 | |
| *** slaweq has joined #openstack-shade | 11:44 | |
| *** yolanda has quit IRC | 12:19 | |
| *** cdent has joined #openstack-shade | 12:20 | |
| *** cdent has quit IRC | 12:27 | |
| *** slaweq has quit IRC | 12:47 | |
| *** ioggstream has joined #openstack-shade | 13:55 | |
| *** slaweq has joined #openstack-shade | 14:15 | |
| *** ioggstream has quit IRC | 14:18 | |
| mordred | slaweq: yes - what you did is exactly right. the mocking of openstackcloud methods was wrong, and mocking at the rest layer is the right choice | 14:25 |
|---|---|---|
| mordred | slaweq: also - I think we can get rid of the mocking of has_service - although we can do that in a follow up - since we have a catalog, has_service should work properly | 14:26 |
| slaweq | mordred: good to know that :) | 14:26 |
| slaweq | ok, I will remove has_service mock from all those methods also | 14:26 |
| mordred | in general I think most of the use of mock that isn't request_mock should all go away eventually ... except for maybe a few places where we're testing caching where testing the actual content is not important and what we're testing is that we return data from cache or make method calls | 14:29 |
| slaweq | so if in floating ip test there is mock of "get_server" it should be also replaced with request_mocks, right? | 14:34 |
| slaweq | mordred: thx for +2 my patch | 14:39 |
| slaweq | I wanted to update it and remove mock_has_service from it :) | 14:40 |
| slaweq | but I will do it in next patch then :) | 14:40 |
| slaweq | You were too fast for me :P | 14:40 |
| *** rcarrillocruz has quit IRC | 14:40 | |
| *** rcarrillocruz has joined #openstack-shade | 14:41 | |
| rods | hello, once this get merged https://review.openstack.org/#/c/463071/1, we are one commit away from getting rid of the cinder client :) | 14:42 |
| slaweq | rods: so we are going in same way with cinder and neutron client :) | 14:43 |
| rods | slaweq cool :) | 14:43 |
| mordred | slaweq: yes - although if we wanted to wait on get_server things until we deal with nova_client that's fine | 14:58 |
| slaweq | mordred: ok | 14:59 |
| slaweq | I just found that this mock of get_server there is not necessary | 14:59 |
| slaweq | I removed it and all tests still passes | 14:59 |
| mordred | slaweq: excellent! | 15:03 |
| mordred | rods: I just approved that - but with a comment. I think it can be adjusted in a followup | 15:03 |
| rods | mordred thx, I'll fix it in the next patch | 15:06 |
| openstackgerrit | Merged openstack-infra/shade master: Remove neutronclient mocks from floating ips tests https://review.openstack.org/463070 | 15:13 |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Remove has_service mock from Neutron FIP tests https://review.openstack.org/463099 | 15:18 |
| slaweq | mordred: ^^ has_service mocks removed :) | 15:19 |
| slaweq | have a good saturday | 15:19 |
| mordred | slaweq: thanks! and you have a good saturday too | 15:20 |
| slaweq | saturday is almost finished for me :/ | 15:20 |
| slaweq | but thx | 15:20 |
| *** gouthamr has joined #openstack-shade | 15:33 | |
| *** slaweq has quit IRC | 15:36 | |
| openstackgerrit | Merged openstack-infra/shade master: Remove cinderclient mocks from snapshot tests https://review.openstack.org/463071 | 15:41 |
| *** rcarrill1 has joined #openstack-shade | 15:47 | |
| *** rcarrillocruz has quit IRC | 15:49 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/461375 | 15:59 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Add assert_calls check testing volume calls with timeout enabled https://review.openstack.org/463104 | 16:05 |
| openstackgerrit | Merged openstack-infra/shade master: Remove has_service mock from Neutron FIP tests https://review.openstack.org/463099 | 16:46 |
| *** slaweq has joined #openstack-shade | 17:10 | |
| *** slaweq has quit IRC | 18:17 | |
| *** gouthamr has quit IRC | 19:16 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/461375 | 19:23 |
| *** slaweq has joined #openstack-shade | 20:18 | |
| *** slaweq has quit IRC | 20:22 | |
| openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/461375 | 20:52 |
| *** gouthamr has joined #openstack-shade | 21:10 | |
| *** gouthamr has quit IRC | 21:43 | |
| *** slaweq has joined #openstack-shade | 22:15 | |
| *** gouthamr has joined #openstack-shade | 22:27 | |
| *** slaweq has quit IRC | 22:27 | |
| *** gouthamr has quit IRC | 22:47 | |
| *** gouthamr has joined #openstack-shade | 22:51 | |
| *** jamielennox|away is now known as jamielennox | 23:09 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!