| *** slaweq has joined #openstack-shade | 00:28 | |
| *** slaweq has quit IRC | 00:33 | |
| *** slaweq has joined #openstack-shade | 02:29 | |
| *** slaweq has quit IRC | 02:33 | |
| *** slaweq has joined #openstack-shade | 04:29 | |
| *** slaweq has quit IRC | 04:35 | |
| *** gkadam has joined #openstack-shade | 04:55 | |
| *** gkadam has quit IRC | 05:35 | |
| *** gouthamr has quit IRC | 06:28 | |
| *** slaweq has joined #openstack-shade | 06:30 | |
| *** slaweq has quit IRC | 06:35 | |
| *** yfried has joined #openstack-shade | 06:40 | |
| *** slaweq has joined #openstack-shade | 07:52 | |
| *** slaweq has quit IRC | 07:53 | |
| *** slaweq has joined #openstack-shade | 08:40 | |
| *** slaweq has quit IRC | 08:55 | |
| *** gkadam has joined #openstack-shade | 09:05 | |
| *** slaweq has joined #openstack-shade | 10:14 | |
| *** gkadam has quit IRC | 10:37 | |
| *** gkadam has joined #openstack-shade | 10:37 | |
| *** gkadam has quit IRC | 10:38 | |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Replace neutronclient with REST API calls in FIP commands https://review.openstack.org/463126 | 11:07 |
|---|---|---|
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Enable neutron service in server create and rebuild tests https://review.openstack.org/463127 | 11:16 |
| slaweq | mordred: hello | 11:16 |
| slaweq | when https://review.openstack.org/#/c/463126/ will be merged then we are done with replacing neutronclient by REST calls :) | 11:17 |
| mordred | wow! :) | 11:18 |
| slaweq | there is one more thing todo IMHO | 11:20 |
| slaweq | there is still _neutron_client() property in openstackcloud | 11:21 |
| slaweq | and it's used e.g. in shade/tests/functional/test_floating_ip.py | 11:21 |
| slaweq | should we replace it with network_client() and make raw REST calls in functional tests? | 11:21 |
| slaweq | or how You see it? | 11:21 |
| mordred | hrm. that's a good question. | 11:24 |
| mordred | slaweq: it looks like the use of neutron_client in the functional test is for add_interface_router, delete_interface_router and update_router with a note that shade doesn't have methods exposing those ... but we do have methods for those now | 11:25 |
| mordred | slaweq: maybe we should just update the functional tests to use the shade functions for those things - I think that was an oversight at some point | 11:26 |
| slaweq | yes, that sounds good | 11:26 |
| slaweq | ok, I will do it | 11:26 |
| slaweq | how I can test functional tests in shade locally? can it be done on "normal" devstack? | 11:26 |
| slaweq | or there are some special requirements for that? | 11:27 |
| mordred | it should work just great ona normal devstack - by default it expects there to be a cloud named devstack and a cloud named devstack-admin in the clouds.yaml file - but devstack writes such a file already | 11:29 |
| slaweq | ok, thx | 11:30 |
| slaweq | so I will do it soon :) | 11:30 |
| slaweq | and thx for +2 to my today's patches | 11:30 |
| *** slaweq has quit IRC | 11:44 | |
| *** yfried has quit IRC | 11:53 | |
| *** slaweq has joined #openstack-shade | 12:23 | |
| openstackgerrit | Merged openstack-infra/shade master: Add assert_calls check testing volume calls with timeout enabled https://review.openstack.org/463104 | 12:23 |
| openstackgerrit | Merged openstack-infra/shade master: Enable neutron service in server create and rebuild tests https://review.openstack.org/463127 | 12:33 |
| *** yfried has joined #openstack-shade | 12:34 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use REST API for volume snapshot calls https://review.openstack.org/463130 | 12:37 |
| *** cdent has joined #openstack-shade | 13:04 | |
| *** yfried has quit IRC | 13:15 | |
| *** slaweq has quit IRC | 13:40 | |
| openstackgerrit | Merged openstack-infra/shade master: Replace neutronclient with REST API calls in FIP commands https://review.openstack.org/463126 | 13:55 |
| *** slaweq has joined #openstack-shade | 14:34 | |
| *** slaweq has quit IRC | 14:48 | |
| *** slaweq has joined #openstack-shade | 15:11 | |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Remove usage of neutron_client from functional tests https://review.openstack.org/463146 | 15:28 |
| slaweq | mordred: one more question, should we remove neutronclient completly from shade? | 15:35 |
| slaweq | because for now it is still in requirements and us used e.g. in neutron_exception function in shade/_utils.py | 15:36 |
| slaweq | but I'm not sure if we need it in fact | 15:36 |
| slaweq | because we will not have neutron exceptions raised as we switched to REST calls, right? | 15:37 |
| mordred | slaweq: we should remove it from requirements and from shade/_utils (_utils is private so it's fine) | 15:50 |
| slaweq | ok, thx, I will do it then | 15:51 |
| mordred | for neutron_client in shade/openstackcloud.py - there is a pattern for the other ones we've removed (you can look at glance_client) where we do the import inside of the method in a try - and if we can't import neutronclient we'd throw an exception with an error message | 15:51 |
| slaweq | ok, I will check glance_client - thx | 15:52 |
| slaweq | once https://review.openstack.org/463146 will be merged it will be not used anywhere except those exceptions :) | 15:52 |
| *** cdent has quit IRC | 15:59 | |
| * mordred hands slaweq a nice fuzzy bunny rabbit | 16:10 | |
| slaweq | :) | 16:11 |
| * mordred was totally going to hack on ironicclient while slaweq was doing neutron and rods cinder - but got sucked down the hole of figuring out service version discovery which is now a set of like 8 API-WG documents ... hopes to climb back out soon | 16:11 | |
| slaweq | so now will be time to remove nova client probably | 16:15 |
| slaweq | but there will be a lot of work to do | 16:15 |
| slaweq | I have some presentation to do this week but later I will probably continue this work with nova or something else | 16:15 |
| slaweq | mordred: thx for quick review :) | 16:16 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use REST API for volume snapshot calls https://review.openstack.org/463130 | 16:41 |
| rods | ^^ had to rebase | 16:41 |
| rods | apparently I lied, trying to remove the cinderclient I realized there are a few more tests and call that need restification | 16:42 |
| rods | working on it | 16:42 |
| rods | *calls | 16:42 |
| *** slaweq has quit IRC | 16:59 | |
| *** slaweq has joined #openstack-shade | 17:00 | |
| *** slaweq has quit IRC | 17:04 | |
| openstackgerrit | Merged openstack-infra/shade master: Remove usage of neutron_client from functional tests https://review.openstack.org/463146 | 17:06 |
| *** yfried has joined #openstack-shade | 17:12 | |
| mordred | rods: whoops :) | 17:14 |
| rods | forgot about those https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_quotas.py#L73-L101 :) | 17:15 |
| mordred | rods: I have a question about https://review.openstack.org/#/c/463130/2/shade/_normalize.py | 17:16 |
| mordred | rods: do the rest calls just not return those fields or something? | 17:16 |
| mordred | rods: wow - yah. it sure does look like those aren't in the REST api at all. yay cinderclient | 17:18 |
| rods | mordred yeah, those fields are added by the cinderclient, so I had to add them when I switched to requests-mock | 17:20 |
| mordred | rods: an oops and another thing in there | 17:20 |
| mordred | rods: ++ makes sense | 17:20 |
| mordred | so strange | 17:20 |
| rods | mordred oh, my bad, fixing them | 17:24 |
| *** yfried has quit IRC | 17:45 | |
| *** cdent has joined #openstack-shade | 17:47 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use REST API for volume snapshot calls https://review.openstack.org/463130 | 17:59 |
| *** slaweq has joined #openstack-shade | 18:04 | |
| *** slaweq has quit IRC | 18:05 | |
| *** slaweq has joined #openstack-shade | 18:18 | |
| *** slaweq has quit IRC | 18:36 | |
| *** slaweq has joined #openstack-shade | 18:36 | |
| *** slaweq has quit IRC | 18:40 | |
| *** cdent has quit IRC | 19:10 | |
| *** cdent has joined #openstack-shade | 19:11 | |
| *** slaweq has joined #openstack-shade | 19:14 | |
| *** yolanda has joined #openstack-shade | 19:14 | |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Fix Neutron floating IP test https://review.openstack.org/463199 | 19:52 |
| slaweq | mordred: plop | 19:53 |
| slaweq | I just found one bug in floating ips test | 19:53 |
| slaweq | I fixed it in https://review.openstack.org/463199 | 19:53 |
| slaweq | if You will have a while, please look on it | 19:54 |
| slaweq | I need it to finish removing neutronclient from requirements | 19:54 |
| *** slaweq has quit IRC | 19:59 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Remove cinderclient mocks from quotas tests https://review.openstack.org/463201 | 20:05 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Remove cinderclient mocks from quotas tests https://review.openstack.org/463201 | 20:19 |
| mordred | slaweq_: looks great | 20:31 |
| *** cdent has quit IRC | 21:03 | |
| openstackgerrit | Merged openstack-infra/shade master: Fix Neutron floating IP test https://review.openstack.org/463199 | 21:15 |
| *** slaweq has joined #openstack-shade | 22:08 | |
| *** cdent has joined #openstack-shade | 22:15 | |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Remove neutronclient from shade's dependencies https://review.openstack.org/463213 | 22:19 |
| slaweq | mordred: thx, ^^ with this one all should be done with neutronclient | 22:19 |
| slaweq | I hope I didn't forget anything :) | 22:20 |
| *** ianw_ has joined #openstack-shade | 22:21 | |
| *** slaweq has quit IRC | 22:22 | |
| *** jroll has quit IRC | 22:22 | |
| *** ianw has quit IRC | 22:22 | |
| *** dtroyer has quit IRC | 22:22 | |
| *** ianw_ is now known as ianw | 22:22 | |
| *** dtroyer has joined #openstack-shade | 22:23 | |
| *** slaweq has joined #openstack-shade | 22:31 | |
| *** slaweq has quit IRC | 22:32 | |
| *** jroll has joined #openstack-shade | 22:42 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!