| *** slaweq has joined #openstack-shade | 02:10 | |
| *** slaweq has quit IRC | 02:15 | |
| *** gkadam has joined #openstack-shade | 03:24 | |
| *** gkadam has quit IRC | 03:24 | |
| *** gkadam has joined #openstack-shade | 03:24 | |
| *** slaweq has joined #openstack-shade | 03:38 | |
| *** slaweq has quit IRC | 03:43 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/465225 | 03:45 |
|---|---|---|
| *** gouthamr has quit IRC | 03:57 | |
| *** mgagne has quit IRC | 06:53 | |
| *** mgagne has joined #openstack-shade | 06:56 | |
| *** mgagne is now known as Guest24103 | 06:56 | |
| *** ioggstream has joined #openstack-shade | 07:43 | |
| *** gkadam is now known as gkadam-afk | 07:52 | |
| *** slaweq has joined #openstack-shade | 09:56 | |
| *** slaweq has quit IRC | 10:01 | |
| *** slaweq has joined #openstack-shade | 10:32 | |
| *** slaweq has quit IRC | 10:37 | |
| -openstackstatus- NOTICE: gerrit is being restarted to help stuck git replication issues | 10:54 | |
| *** cdent has joined #openstack-shade | 11:19 | |
| *** iogg has joined #openstack-shade | 11:32 | |
| *** ioggstream has quit IRC | 11:32 | |
| *** yfried has joined #openstack-shade | 11:51 | |
| *** yfried has quit IRC | 12:22 | |
| *** yfried has joined #openstack-shade | 12:23 | |
| *** yfried has quit IRC | 12:23 | |
| *** yfried has joined #openstack-shade | 12:23 | |
| *** gkadam-afk is now known as gkadam | 12:35 | |
| *** gouthamr has joined #openstack-shade | 12:40 | |
| *** iogg has quit IRC | 14:02 | |
| *** iogg has joined #openstack-shade | 14:03 | |
| *** rcarrillocruz has quit IRC | 14:20 | |
| *** yfried has quit IRC | 14:31 | |
| *** Guest24103 is now known as mgagne | 14:32 | |
| *** mgagne has quit IRC | 14:32 | |
| *** mgagne has joined #openstack-shade | 14:32 | |
| *** iogg has quit IRC | 14:35 | |
| *** ioggstream has joined #openstack-shade | 14:36 | |
| *** yfried has joined #openstack-shade | 14:38 | |
| *** slaweq has joined #openstack-shade | 14:39 | |
| *** slaweq has quit IRC | 14:48 | |
| *** gkadam has quit IRC | 14:50 | |
| rods | mordred looks like there's a bug in the list_volumes call, https://storyboard.openstack.org/#!/story/2001022 | 14:57 |
| rods | working on it | 14:57 |
| mordred | rods: I've been thinking recently that perhaps the magic bit in shade/_adapter.py that strips out the top-level dict parameter is maybe one step of magic too far ... what do you think? | 15:54 |
| *** gouthamr_ has joined #openstack-shade | 15:58 | |
| rods | mordred ya, I like the idea to make it explicit in the methods | 15:59 |
| *** gouthamr has quit IRC | 15:59 | |
| mordred | it originally seemed like pretty much everything always returned a value with a single top-level dict ... but there are enough times when that isn't true - it seems a win for explicitness | 16:00 |
| mordred | that's going to be an _ugly_ patch :) | 16:00 |
| rods | even though looks like list_volumes is working in my test, I'm gonna test it with a vanilla shade enviroment, but if it works Id like to ask more info to understand what's going on | 16:01 |
| mordred | rods: oh! the bug is saying that the result in his cloud returns {"volumes_links": "", "volumes":[{},...]} | 16:06 |
| mordred | so maybe some versions of cinder return a volumes_links dict? | 16:06 |
| *** yfried has quit IRC | 16:12 | |
| *** rcarrillocruz has joined #openstack-shade | 16:18 | |
| rods | mordred the only reference I found about 'volume_links' is something from the telekom.de cloud https://cloud.telekom.de/infrastruktur/open-telekom-cloud/dokumentation/native-openstack-api/cinder-api/volumes/ | 16:25 |
| mordred | rods: (asking in #openstack-cinder ... but I think it points to it being safer for us to return the full dict and the pull out the key we want in the methods instead of assuming good behavior | 16:28 |
| *** gouthamr_ has quit IRC | 16:28 | |
| rods | mordred ya, that seems the way to go | 16:29 |
| mordred | rods: do you want to do that? it's lkely going to be a huge and tedious patch... basically removing 135-142 in shade/_adapter.py and then dealing with the carnage | 16:32 |
| rods | mordred yup, I can do that | 16:32 |
| rods | want me to update that ticket on storyboard? | 16:34 |
| mordred | sure! | 16:35 |
| * mordred hands rods bodyarmor | 16:35 | |
| *** gouthamr has joined #openstack-shade | 17:01 | |
| *** ioggstream has quit IRC | 17:03 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Make sure security_groups is always a list https://review.openstack.org/465672 | 17:03 |
| mordred | Shrews, rcarrillocruz (or anyone really): ^^ (responding to an ansible bug) | 17:05 |
| *** yfried has joined #openstack-shade | 17:07 | |
| rcarrillocruz | at the expense of maybe unit tests stating -1, +2 from me | 17:10 |
| mordred | rcarrillocruz: bah. that's just silly | 17:11 |
| * rcarrillocruz not a fan of unit tests | 17:11 | |
| rods | mordred did you get any reply from the #openstack-cinder channel about the volumes_link? sorry wasn't logged into the channel when you asked | 17:16 |
| mordred | nope. poking sean | 17:20 |
| mordred | rods: maybe we should do a small patch in list volumes that checks to see if it got volume/volume_links and if so pulls out the volume content (could even just be in _normalize_volume actually) | 17:21 |
| mordred | then cut a release of shade with that - so that reworking the whole adapter stack can be in teh next release | 17:21 |
| mordred | (tis' going to be such a big patch it would be nice to isolate it slightly ya know?) | 17:22 |
| mordred | it's slighly ugly to do the special case- but we can at least fix the know break quickly | 17:22 |
| *** yfried has quit IRC | 17:22 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Make sure security_groups is always a list https://review.openstack.org/465672 | 17:22 |
| rods | mordred ya, seems reasonable to me | 17:22 |
| mordred | Shrews: if you have a sec - you wrote the original nova_client code in https://review.openstack.org/#/c/464772/- would love an ack from you on the replacement (also, the switch uncovered a race condition which is why I switched to deleting by server_id) | 17:25 |
| Shrews | mordred: in a bit | 17:25 |
| *** yfried has joined #openstack-shade | 17:41 | |
| Shrews | mordred: lgtm | 17:44 |
| *** yfried has quit IRC | 17:45 | |
| mordred | Shrews: thanks | 17:46 |
| rods | mordred need to step away for a few, I'll work on the volumes_list patch as soon as I get back | 17:49 |
| mordred | rods: sweet. thanks! | 17:49 |
| *** yfried has joined #openstack-shade | 17:56 | |
| *** jamielennox is now known as jamielennox|away | 17:59 | |
| *** jamielennox|away is now known as jamielennox | 18:05 | |
| openstackgerrit | Merged openstack-infra/shade master: Remove direct uses of nova_client in functional tests https://review.openstack.org/464772 | 18:49 |
| openstackgerrit | Merged openstack-infra/shade master: Make sure security_groups is always a list https://review.openstack.org/465672 | 18:49 |
| *** yfried has quit IRC | 18:52 | |
| openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/465225 | 19:00 |
| *** mordred has quit IRC | 19:05 | |
| *** mordred has joined #openstack-shade | 19:06 | |
| *** cdent has quit IRC | 20:05 | |
| *** slaweq has joined #openstack-shade | 20:38 | |
| *** slaweq has quit IRC | 20:38 | |
| *** slaweq has joined #openstack-shade | 20:41 | |
| *** gouthamr has quit IRC | 20:44 | |
| *** gouthamr has joined #openstack-shade | 21:14 | |
| *** slaweq has quit IRC | 21:54 | |
| *** gouthamr has quit IRC | 23:12 | |
| *** gouthamr has joined #openstack-shade | 23:20 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!