*** jamielennox is now known as jamielennox|away | 00:27 | |
*** jamielennox|away is now known as jamielennox | 00:41 | |
*** jamielennox is now known as jamielennox|away | 02:40 | |
*** gouthamr has quit IRC | 02:47 | |
*** gouthamr has joined #openstack-shade | 02:47 | |
*** gkadam has joined #openstack-shade | 03:07 | |
*** gkadam_ has joined #openstack-shade | 03:08 | |
*** gkadam_ has quit IRC | 03:08 | |
*** jamielennox|away is now known as jamielennox | 03:33 | |
*** yfried has joined #openstack-shade | 05:30 | |
*** yfried has quit IRC | 05:59 | |
*** yfried has joined #openstack-shade | 06:03 | |
*** gouthamr has quit IRC | 06:36 | |
*** yfried has quit IRC | 08:52 | |
*** yfried has joined #openstack-shade | 08:56 | |
*** yfried has quit IRC | 09:00 | |
*** yfried has joined #openstack-shade | 09:01 | |
*** cdent has joined #openstack-shade | 09:24 | |
*** yfried has quit IRC | 10:00 | |
*** yfried has joined #openstack-shade | 10:02 | |
*** jamielennox is now known as jamielennox|away | 10:04 | |
*** cdent has quit IRC | 10:46 | |
*** openstackgerrit has quit IRC | 10:48 | |
*** cdent has joined #openstack-shade | 11:13 | |
*** yfried has quit IRC | 12:35 | |
*** gkadam has quit IRC | 12:41 | |
*** cdent has quit IRC | 12:41 | |
*** ioggstream has joined #openstack-shade | 12:44 | |
*** gouthamr has joined #openstack-shade | 12:57 | |
*** cdent has joined #openstack-shade | 13:10 | |
*** yfried has joined #openstack-shade | 13:26 | |
*** yfried has quit IRC | 13:40 | |
*** jamielennox|away is now known as jamielennox | 13:49 | |
*** cdent has quit IRC | 13:49 | |
*** rcarrillocruz has quit IRC | 15:05 | |
*** cdent has joined #openstack-shade | 15:20 | |
*** slaweq has joined #openstack-shade | 15:22 | |
*** slaweq has quit IRC | 15:22 | |
*** slaweq has joined #openstack-shade | 15:23 | |
*** openstackgerrit has joined #openstack-shade | 15:36 | |
openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: WIP: Fix issue with list_volumes when pagination is used https://review.openstack.org/466016 | 15:36 |
---|---|---|
rods | mordred ^^ I left a comment, I'd like you opinion when you have a sec | 16:00 |
rods | *your | 16:00 |
*** rcarrillocruz has joined #openstack-shade | 16:02 | |
mordred | rods: yes - I think tha tpatch looks good for now - but I definitely agree - it's _definitely_ not a complete fix | 16:13 |
mordred | rods: we currently support pagination in list_images - but I think that's the only place we've implemented it | 16:13 |
mordred | rods: maybe the steps should be a) land this patch to stop the immediate bleeding b) implement pagination sort of like how list_images is doing it c) do the adapter change we talked about yesterday d) work through adding pagination support to all of the list calls | 16:15 |
rods | mordred ya, I'm writing a quick test for this patch and once it lands I'm gonna start the work for point _b_ | 16:18 |
mordred | d may or may not want to be a thing we do at adapter layer - or may just need to be a pattern we apply in each list call ... probably need to learn more about how many different ways pagination happens | 16:19 |
mordred | rods: awesome! | 16:19 |
*** yfried has joined #openstack-shade | 17:12 | |
*** cdent has quit IRC | 19:10 | |
*** gouthamr has quit IRC | 19:37 | |
rods | mordred should we report as an issue the fact that in the cinder API doc there's no mention of the `volumes_links` as possible Response paramater for the /v2/{tenant_id}/volumes/detail request? https://developer.openstack.org/api-ref/block-storage/v2/?expanded=list-volumes-with-details-detail | 19:41 |
*** gouthamr has joined #openstack-shade | 19:55 | |
*** gouthamr has quit IRC | 19:57 | |
*** gouthamr has joined #openstack-shade | 20:00 | |
mordred | rods: absolutely | 20:03 |
*** gouthamr has quit IRC | 20:04 | |
mordred | btw - grepping for "volumes_links" will not find anyting in the cinder tree ... | 20:04 |
mordred | but in cinder/api/common.py there is a method _get_collection_links which takes a collection name | 20:04 |
rods | found this https://github.com/openstack/cinder/blob/master/cinder/api/v2/views/volumes.py#L160 | 20:04 |
mordred | yup | 20:05 |
mordred | that'll do it | 20:05 |
*** slaweq has quit IRC | 20:11 | |
*** slaweq has joined #openstack-shade | 20:11 | |
*** cdent has joined #openstack-shade | 20:23 | |
*** yfried has quit IRC | 20:26 | |
*** gouthamr has joined #openstack-shade | 20:29 | |
openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Fix issue with list_volumes when pagination is used https://review.openstack.org/466016 | 20:45 |
*** cdent has quit IRC | 21:01 | |
*** ioggstream has quit IRC | 21:15 | |
*** gouthamr has quit IRC | 21:37 | |
*** slaweq has quit IRC | 21:52 | |
*** slaweq has joined #openstack-shade | 22:06 | |
*** slaweq has quit IRC | 22:15 | |
openstackgerrit | Merged openstack-infra/shade master: Fix issue with list_volumes when pagination is used https://review.openstack.org/466016 | 22:51 |
*** gouthamr has joined #openstack-shade | 23:02 | |
*** gouthamr has quit IRC | 23:13 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!