| *** thrash is now known as thrash|g0ne | 00:40 | |
| *** gouthamr has joined #openstack-shade | 01:56 | |
| *** rods has quit IRC | 03:26 | |
| *** gkadam has joined #openstack-shade | 03:40 | |
| *** mrhillsman has quit IRC | 05:02 | |
| *** mordred has quit IRC | 05:02 | |
| *** dhellmann has quit IRC | 05:02 | |
| *** mrhillsman has joined #openstack-shade | 05:02 | |
| *** dhellmann has joined #openstack-shade | 05:03 | |
| *** mordred has joined #openstack-shade | 05:04 | |
| *** slaweq has joined #openstack-shade | 06:08 | |
| *** slaweq has quit IRC | 06:12 | |
| *** gouthamr has quit IRC | 06:47 | |
| *** rods has joined #openstack-shade | 07:42 | |
| *** rods has quit IRC | 07:42 | |
| *** rods has joined #openstack-shade | 07:44 | |
| *** rods has quit IRC | 07:44 | |
| *** rods has joined #openstack-shade | 07:45 | |
| *** rods has quit IRC | 07:45 | |
| *** rods has joined #openstack-shade | 07:45 | |
| *** rods has quit IRC | 07:46 | |
| *** rods has joined #openstack-shade | 07:46 | |
| *** rods has quit IRC | 07:46 | |
| *** rods has joined #openstack-shade | 07:47 | |
| *** rods has quit IRC | 07:47 | |
| *** rods has joined #openstack-shade | 07:48 | |
| *** rods has quit IRC | 07:48 | |
| *** rods has joined #openstack-shade | 07:49 | |
| *** rods has quit IRC | 07:49 | |
| *** rods has joined #openstack-shade | 07:49 | |
| *** rods has quit IRC | 07:50 | |
| *** rods has joined #openstack-shade | 07:50 | |
| *** rods has quit IRC | 07:50 | |
| *** rods has joined #openstack-shade | 07:51 | |
| *** rods has quit IRC | 07:51 | |
| *** rods has joined #openstack-shade | 07:52 | |
| *** rods has joined #openstack-shade | 07:53 | |
| *** rods has quit IRC | 07:53 | |
| *** ioggstream has joined #openstack-shade | 07:55 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** slaweq has joined #openstack-shade | 08:32 | |
| *** mrhillsman has quit IRC | 08:51 | |
| *** mrhillsman has joined #openstack-shade | 08:52 | |
| *** rods has joined #openstack-shade | 09:20 | |
| *** rods has quit IRC | 09:25 | |
| *** thrash|g0ne is now known as thrash | 11:50 | |
| *** dtroyer has quit IRC | 12:23 | |
| *** dtroyer has joined #openstack-shade | 12:32 | |
| *** gkadam has quit IRC | 12:43 | |
| *** gouthamr has joined #openstack-shade | 13:46 | |
| *** gouthamr has quit IRC | 13:49 | |
| *** gouthamr has joined #openstack-shade | 13:49 | |
| *** rods has joined #openstack-shade | 14:44 | |
| *** slaweq has quit IRC | 14:50 | |
| *** openstackgerrit has joined #openstack-shade | 16:22 | |
| openstackgerrit | Merged openstack/os-client-config master: Updated from global requirements https://review.openstack.org/494865 | 16:22 |
|---|---|---|
| SamYaple | shouldnt delete_user() support domain_id? https://github.com/openstack-infra/shade/blob/master/shade/openstackcloud.py#L1089 | 16:23 |
| SamYaple | yea because if we don't support domain_id then we can't support "name" because users are only unique per domain | 16:25 |
| *** ioggstream has quit IRC | 16:26 | |
| SamYaple | mordred: while walking through alot of these apis ive notied a lack of *_id params. for example, when deleting a service i already have the service_id, but the delete_service() function only takes name_or_id leading it to have to lookup the services again | 16:26 |
| SamYaple | would you be opposed to adding user_id service_id domain_id etc fields to everything? | 16:26 |
| mordred | SamYaple: MAYBE - there's an interface weirdness here I think we should think about - but I'm in an in-person meeting atm | 16:26 |
| SamYaple | ah ok | 16:27 |
| mordred | SamYaple: that said - a thing that may not be evident is that you can pass an object dict to name_or_id params | 16:27 |
| mordred | SamYaple: you can also do delete_service(name_or_id=dict(id=service_id)) (or you should be able to and if you can't it's a bug) if you know you have an id and you want to skip the get | 16:28 |
| SamYaple | hmmm | 16:28 |
| SamYaple | ok ill have to dig into _utils._filter_list | 16:28 |
| SamYaple | i wasn't aware name_or_id could be a dict | 16:28 |
| mordred | SamYaple: which is my verbose way of saying I agree with the thing you want to do - but I think we've got a few different cobbled together ways of doing it and we should step back and think about how we want to deal with this broadly so we don't make things yuckier | 16:29 |
| SamYaple | agreed there | 16:29 |
| mordred | SamYaple: ya- we added a dict optimization a little while ago - but it's not a super awesome or evident interface | 16:29 |
| SamYaple | but its there now so its safe to use it, yes? | 16:29 |
| SamYaple | like its not going away | 16:29 |
| mordred | yah | 16:30 |
| mordred | totally safe - we depend on it internally | 16:30 |
| SamYaple | kk. ill see how far that gets me with removing the GETs | 16:30 |
| mordred | cool | 16:31 |
| SamYaple | having dedicated *_id vars might make it more clear long term, but being fairly generic and overloading name_or_id makes it a bit more adaptable to api changes | 16:32 |
| SamYaple | not sure how i feel about it yet | 16:32 |
| SamYaple | name_or_id=dict(id=user.id, domain_id=domain.id) should work right? | 17:05 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Service List https://review.openstack.org/482195 | 17:05 |
| *** thrash is now known as thrash|biab | 17:07 | |
| samueldmq | there is something wrong with shade jobs | 17:14 |
| samueldmq | ^ just succeeded and only tox-py35-constraints was ran | 17:14 |
| samueldmq | run* | 17:15 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Service Update https://review.openstack.org/482196 | 17:23 |
| mordred | samueldmq: that's from zuul v3 - zuul v3 hasn't resonded yet | 17:27 |
| samueldmq | aha! thanks | 17:33 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Service Delete https://review.openstack.org/482197 | 17:34 |
| *** slaweq has joined #openstack-shade | 17:44 | |
| *** slaweq has quit IRC | 17:49 | |
| *** thrash|biab is now known as thrash | 17:56 | |
| *** gouthamr has quit IRC | 17:57 | |
| *** gouthamr has joined #openstack-shade | 18:00 | |
| *** slaweq has joined #openstack-shade | 18:45 | |
| *** slaweq has quit IRC | 18:51 | |
| SamYaple | ok mordred. delete_user will delete with only the user name (not id) if the user lives in the domain the token is scoped for | 18:56 |
| SamYaple | im not able ot delete a user in a different domain, even proving the id in the form of name_or_id='{"id":"XXX"}' | 18:56 |
| SamYaple | providing* | 18:56 |
| *** ioggstream has joined #openstack-shade | 18:57 | |
| SamYaple | mordred: delete_user will search_users but search_users doesn't provide the ability to search a specific domain_id. you cannot search users across all domains when mixing sql and ldap | 19:02 |
| SamYaple | so with shade and ldap you can only delete users in the default domain (default as configured in the keystone.conf) | 19:03 |
| SamYaple | we need to extend list_users to allow domain_id too | 19:08 |
| openstackgerrit | Merged openstack-infra/shade master: De-client-ify Service List https://review.openstack.org/482195 | 19:23 |
| *** ioggstream has quit IRC | 19:24 | |
| *** slaweq has joined #openstack-shade | 19:38 | |
| *** olaph1 has joined #openstack-shade | 19:41 | |
| *** olaph has quit IRC | 19:41 | |
| SamYaple | list_roles also needs to accept domain_id, though i dont htink that has anything to do with ldap this time | 19:46 |
| SamYaple | there is also no update_role function at all. that needs to be added | 19:58 |
| *** gouthamr has quit IRC | 20:58 | |
| *** gouthamr has joined #openstack-shade | 21:35 | |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Fix cleaning of Cinder volumes in functional tests https://review.openstack.org/496939 | 21:39 |
| *** slaweq has quit IRC | 21:51 | |
| *** rods has quit IRC | 22:52 | |
| *** rods has joined #openstack-shade | 22:54 | |
| SamYaple | the same issue with groups. groups also needs a domain_id specfic thing | 23:23 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!