| * SamYaple sighs | 00:46 | |
| SamYaple | the logic in grant role is a bit foobar | 00:46 |
|---|---|---|
| SamYaple | https://github.com/openstack-infra/shade/blob/master/shade/operatorcloud.py#L1675 is inaccurate | 00:47 |
| SamYaple | you can be granted a role in a domain without belonging to that domain | 00:47 |
| SamYaple | mordred: im not sure if this would be a change in shade behaviour to fix it | 00:51 |
| SamYaple | basically granting a user or group a role to a domain if the user or group is not in that domain fails | 00:52 |
| *** rods has quit IRC | 01:36 | |
| *** thrash is now known as thrash|g0ne | 02:09 | |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Fix user role grants https://review.openstack.org/496980 | 02:28 |
| SamYaple | mordred ^ that definetly changes behaviour, but the previous behaviour was wrong and broken | 02:28 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Allow domain_id for roles https://review.openstack.org/496992 | 02:53 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Allow domain_id for roles https://review.openstack.org/496992 | 03:00 |
| *** gkadam has joined #openstack-shade | 03:24 | |
| *** gouthamr has quit IRC | 05:13 | |
| *** rods has joined #openstack-shade | 06:29 | |
| *** slaweq has joined #openstack-shade | 06:32 | |
| *** gkadam_ has joined #openstack-shade | 07:40 | |
| *** gkadam has quit IRC | 07:42 | |
| *** gkadam_ has quit IRC | 07:45 | |
| *** rods has quit IRC | 07:58 | |
| *** rods has joined #openstack-shade | 07:58 | |
| *** rods has quit IRC | 07:59 | |
| *** rods has joined #openstack-shade | 07:59 | |
| *** rods has quit IRC | 07:59 | |
| *** rods has joined #openstack-shade | 08:00 | |
| *** rods has quit IRC | 08:00 | |
| *** rods has joined #openstack-shade | 08:01 | |
| *** rods has quit IRC | 08:01 | |
| *** rods has joined #openstack-shade | 08:02 | |
| *** rods has quit IRC | 08:02 | |
| *** rods has joined #openstack-shade | 08:02 | |
| *** rods has quit IRC | 08:03 | |
| *** rods has joined #openstack-shade | 08:03 | |
| *** rods has quit IRC | 08:07 | |
| *** spredzy has quit IRC | 08:36 | |
| *** rods has joined #openstack-shade | 09:00 | |
| *** slaweq has quit IRC | 09:11 | |
| *** slaweq has joined #openstack-shade | 09:12 | |
| *** spredzy has joined #openstack-shade | 09:16 | |
| *** slaweq has quit IRC | 09:16 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Service Update https://review.openstack.org/482196 | 09:18 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Service Delete https://review.openstack.org/482197 | 09:30 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Switch to _is_client_version in list_services https://review.openstack.org/497171 | 09:34 |
| *** slaweq has joined #openstack-shade | 09:59 | |
| *** ioggstream has joined #openstack-shade | 10:04 | |
| *** thrash|g0ne is now known as thrash | 11:08 | |
| *** ioggstream has quit IRC | 11:18 | |
| *** rods has quit IRC | 11:25 | |
| *** ioggstream has joined #openstack-shade | 12:03 | |
| *** rods_ has joined #openstack-shade | 12:11 | |
| *** rods_ has quit IRC | 12:12 | |
| *** rods_ has joined #openstack-shade | 12:19 | |
| *** gouthamr has joined #openstack-shade | 13:27 | |
| *** rods_ has quit IRC | 13:36 | |
| *** rods has joined #openstack-shade | 13:37 | |
| *** slaweq has quit IRC | 14:29 | |
| SamYaple | instead of adding several new *_id paramaters everywhere, how about a new param named 'ids' that would be a dict we could query? | 15:04 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Allow domain_id for roles https://review.openstack.org/496992 | 15:26 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Fix user role grants https://review.openstack.org/496980 | 15:26 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Allow domain_id for roles https://review.openstack.org/496992 | 15:33 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Fix user role grants https://review.openstack.org/496980 | 15:33 |
| *** openstackgerrit has quit IRC | 16:04 | |
| *** ioggstream has quit IRC | 16:23 | |
| *** thrash is now known as thrash|biab | 16:31 | |
| *** openstackgerrit has joined #openstack-shade | 16:36 | |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Support domain_id for user operations https://review.openstack.org/497483 | 16:36 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Support domain_id for user operations https://review.openstack.org/497483 | 16:38 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Support domain_id for user operations https://review.openstack.org/497483 | 16:51 |
| mordred | SamYaple: sorry I've been absent today - I'll be around better tomorrow | 16:52 |
| mordred | SamYaple: there is a thought I want to put in your head whileyou're looking at that stuff ... | 16:52 |
| mordred | SamYaple: we had an idea a little while ago about making a context manager or something like that which would be "do this operation in the context of this other project/domain" | 16:53 |
| mordred | SamYaple: so thatyou could do with cloud.in_project('other-project') as cloud_other_project: cloud_other_project.create_network('foo') | 16:54 |
| mordred | SamYaple: it's not the same as what your'e doing now - because there's ALSO obviously some things that specifically take domian/project arguments | 16:54 |
| mordred | but for some resources project/domain is tied to what you've authed to and the admin usage of making one in a different project gets wonky from shade | 16:55 |
| mordred | SamYaple: mostly mentioning it if, while you're touching any of this you have an aha and are like "oh, that would solve all my problems in XXX way" | 16:55 |
| SamYaple | mordred: ill have to mull over a context manager | 16:55 |
| SamYaple | i was playing with a patch that added an 'ids' argument to basically all the functions that could be referened for ids of things | 16:56 |
| mordred | SamYaple: my simplistic thinking was that it would essentially give you a new OpenStackCloud object based on the current one but with project_id/domain_id overridden | 16:56 |
| SamYaple | right now i just need to get some minimum functionality done (like domain_id support in *_user functions | 16:56 |
| SamYaple | ) | 16:56 |
| mordred | ++ | 16:56 |
| mordred | I'll look at those patches either tomorrow or today on the plane | 16:56 |
| mordred | thanks for working on those btw | 16:56 |
| SamYaple | no problem. the shade salt modules for keystone are almost done, but this is holding it up | 16:57 |
| mordred | woot | 16:57 |
| SamYaple | im hoping to get the patches for shade done and maybe merged this week | 16:57 |
| SamYaple | do you have an idea of when a new shade version might be cut? | 16:57 |
| mordred | I was just thinking this morning that I need to get a new one cut | 16:58 |
| SamYaple | ok let me double time these patches because i want them in | 16:58 |
| mordred | SamYaple: no rush - I'll cut one whenever we get them in - you're the only one with a specific pressing need | 16:58 |
| SamYaple | right now the place im working is..... using salt modules (written in python) to wrap the openstack cli..... | 16:59 |
| SamYaple | it hurts to type that | 16:59 |
| SamYaple | mordred: this patch is most important for your attention, it changes the behaviour of shade. granted its changed to the correct way but still https://review.openstack.org/#/c/496980/ | 17:04 |
| *** slaweq has joined #openstack-shade | 17:06 | |
| slaweq | mordred: hello | 17:14 |
| slaweq | mordred: yesterday I made patch for cleaning cinder volumes: https://review.openstack.org/#/c/496939/1 | 17:14 |
| slaweq | I rechecked it few times and it didn't fails on cinder tests | 17:15 |
| slaweq | so maybe it will help little bit | 17:15 |
| slaweq | please take a look on it if You will have a while | 17:15 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Support domain_id for user operations https://review.openstack.org/497483 | 17:20 |
| *** thrash|biab is now known as thrash | 17:22 | |
| mordred | slaweq: awesome - looks great! | 17:29 |
| slaweq | mordred: thx | 17:30 |
| mordred | SamYaple: the domain argument for grant_role / revoke_role wasn't working because you potentially need different domains foruser, project and group - am I understanding you right? | 17:32 |
| SamYaple | mordred: yes | 17:35 |
| SamYaple | also, a user or group can be granted a role for a domain (no project involed) | 17:36 |
| SamYaple | why do we not take advantage of the keystone filter options that are available, instead we opt to do filtering in shade itself after retrieving a full list of data? | 17:52 |
| mordred | nod. just maing sure I grokked the issue | 18:00 |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Add domain_id to groups https://review.openstack.org/497537 | 18:04 |
| *** olaph has joined #openstack-shade | 18:38 | |
| *** olaph1 has quit IRC | 18:40 | |
| *** rods has quit IRC | 19:33 | |
| *** gouthamr has quit IRC | 20:01 | |
| *** gouthamr has joined #openstack-shade | 20:05 | |
| openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Make endpoint id an optional paramater https://review.openstack.org/497601 | 20:20 |
| *** gouthamr has quit IRC | 20:22 | |
| openstackgerrit | Merged openstack-infra/shade master: Fix cleaning of Cinder volumes in functional tests https://review.openstack.org/496939 | 20:27 |
| *** slaweq has quit IRC | 20:47 | |
| *** slaweq has joined #openstack-shade | 20:59 | |
| *** gouthamr has joined #openstack-shade | 21:05 | |
| *** rods has joined #openstack-shade | 21:13 | |
| *** slaweq has quit IRC | 21:52 | |
| *** thrash is now known as thrash|g0ne | 21:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!