*** dshulyak has joined #openstack-solar | 07:28 | |
pigmej | dshulyak: online? | 08:36 |
---|---|---|
dshulyak | aha | 08:36 |
pigmej | hey :) | 08:36 |
pigmej | could you please look into https://bugs.launchpad.net/solar/+bug/1546992 after you catch-up with changes ? | 08:37 |
openstack | Launchpad bug 1546992 in Solar "Two problematic tests on postgresql backend" [High,New] - Assigned to Dima Shulyak (dshulyak) | 08:37 |
dshulyak | ok, what is going on with integration actually? | 08:38 |
pigmej | as very short story: Lukasz is working on your f2s thingy, he ported it to recent solar https://github.com/loles/f2s | 08:39 |
pigmej | I don't know how deep is porting to recent fuel though, lukasz will provide details obviously :) | 08:39 |
pigmej | and from solar side, we have PG backend which works (but these 2 tests are failing for some reason, I can provide more details if needed), and in 9.0 we're trying to deliver solar as experimental stuff MAYBE with some feedback to UI (needs checking, but probably sending correct message to rabbit will be enough) | 08:42 |
dshulyak | i started rewrite of that f2s to make it fully automated and synced with current version of fuel tasks, and also how you guys decided to communicate with fuel components? | 08:42 |
dshulyak | have you created any specs? you know there is only 2 weeks left | 08:42 |
pigmej | yup | 08:42 |
pigmej | I mean we know that there are just 2 weeks left. Lukasz have some ideas as I remember, he will for sure provide them. | 08:44 |
dshulyak | those tests https://bugs.launchpad.net/solar/+bug/1546992 failing all the time? | 08:44 |
openstack | Launchpad bug 1546992 in Solar "Two problematic tests on postgresql backend" [High,New] - Assigned to Dima Shulyak (dshulyak) | 08:44 |
pigmej | sure | 08:45 |
pigmej | but only in tests, when I was trying to do the same but outside of tests, then everything worked, so I suppose that we do some weird things in these tests, I also discovered one unused path in solar-worker when I worked on PG backend | 08:46 |
pigmej | https://review.openstack.org/#/c/281759/ (this one) | 08:48 |
pigmej | dshulyak: when you will start debugging that tests you will see that graph is empty so wait_finish exits immediately | 08:49 |
pigmej | with 0 tasks there | 08:49 |
pigmej | dshulyak: pg db is in recent image, just change in config and reprovision | 09:01 |
dshulyak | change in config? | 09:01 |
dshulyak | is it default? | 09:01 |
dshulyak | or riak is stil ldefault? | 09:01 |
pigmej | depends where :) | 09:02 |
pigmej | for vagrant env, we exposed `solar_db_backend: riak` | 09:02 |
pigmej | so you need to change it in vagrant-settings.yaml | 09:03 |
pigmej | riak | postgres | 09:03 |
pigmej | and for testing scripts (devops) we exposed SOLAR_DB_BACKEND env variable | 09:04 |
pigmej | so you can easily select what do you want. | 09:04 |
pigmej | and in jenkins you can also select that backend | 09:05 |
openstackgerrit | Maciej Kwiek proposed openstack/solar-resources: Change sudo to become in ansible resources https://review.openstack.org/283009 | 09:05 |
pigmej | mkwiek: I have to say that "become: yes" is most stupid syntax that I saw in ansible... | 09:08 |
mkwiek | pigmej: I will not argue with you :D | 09:08 |
mkwiek | http://www.quickmeme.com/img/73/731ccce423f2b4cefc59fd9f40b111306e457e9a1b1f49405a3dc5ffbcb7310f.jpg | 09:09 |
pigmej | mkwiek: could you please also adjust bootstrap scripts ? | 09:09 |
pigmej | (I'm not sure if we have sudo there though) | 09:09 |
mkwiek | in solar core repo? | 09:09 |
pigmej | yup | 09:10 |
mkwiek | sure, will check | 09:10 |
pigmej | bootstrap subdir ;) | 09:10 |
dshulyak | oh cmon | 09:10 |
dshulyak | you are installing backends condittionally | 09:10 |
dshulyak | whyyyy | 09:10 |
pigmej | dshulyak: ? | 09:11 |
pigmej | they are installed always | 09:11 |
pigmej | we just run one or another | 09:11 |
pigmej | or you can run both if you want | 09:11 |
dshulyak | - include: postgres.yaml | 09:11 |
dshulyak | when: lookup('env', 'SOLAR_DB_BACKEND') == "postgres" | 09:11 |
pigmej | yeah but it only runs it :) | 09:11 |
pigmej | you can perfectly run both backends if you want just `vagrant provision solar-dev` after you change in config | 09:13 |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Change sudo to become in ansible resources https://review.openstack.org/283014 | 09:16 |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Change sudo to become in bootstrap playbooks https://review.openstack.org/283014 | 09:17 |
*** tzn has joined #openstack-solar | 09:23 | |
*** salmon_ has joined #openstack-solar | 09:28 | |
dshulyak | pigmej: are you sure that this one was failing - test_two_path_fixture ? | 09:47 |
pigmej | mkwiek: your patches are working :) | 09:47 |
pigmej | dshulyak: yes I am | 09:47 |
pigmej | hmm | 09:47 |
pigmej | but let me chcek | 09:47 |
pigmej | yeah | 09:48 |
pigmej | this one | 09:48 |
pigmej | dshulyak: | 09:52 |
pigmej | https://bpaste.net/show/73c651fdfbe5 | 09:52 |
dshulyak | ok, so this is different failure | 09:53 |
dshulyak | it is not completely empty | 09:53 |
pigmej | yeah this one has different failure | 09:54 |
pigmej | I forgot to mention it | 09:55 |
dshulyak | this one was also present with sqlite, i dont remember, but it was something with isolation i believe | 09:56 |
dshulyak | i think there is similar problem right now | 09:57 |
salmon_ | this one is better https://bpaste.net/raw/83cdc65f96ed :) | 09:57 |
salmon_ | hi | 09:57 |
pigmej | dshulyak: hmm, isolation you say hmm. | 09:58 |
dshulyak | salmon_: where it failed? | 10:03 |
salmon_ | dshulyak: on fuel when I run solar orch run-once | 10:03 |
dshulyak | salmon_: is it random failure? | 10:05 |
salmon_ | dshulyak: no, it happens each time. May it be connected to bad zeromq package? | 10:05 |
dshulyak | it looks like failure in msgpack | 10:06 |
dshulyak | i believe i pinned zeromq version in reqs | 10:06 |
dshulyak | maybe you should try to downgrade msgpack :) | 10:06 |
dshulyak | salmon_: ^ | 10:06 |
salmon_ | dshulyak: I will try. The thing we zeromq is that there is no package for it on fuel. I had to add repo from here http://zeromq.org/distro:centos | 10:07 |
salmon_ | dshulyak: and you pinned only python client | 10:08 |
dshulyak | yeap | 10:08 |
dshulyak | libzmq on ubuntu was ok | 10:08 |
dshulyak | i mean it was working most recent version | 10:08 |
salmon_ | I will check it one more time | 10:09 |
salmon_ | dshulyak: I extracted f2s dir from solar https://github.com/loles/f2s | 10:12 |
dshulyak | i saw this one, i think there is several problems with this f2s, it is not synced with latest fuel and idk if there was any additional tasks addded, so i want to improve f2s to be fully automated | 10:14 |
dshulyak | and there is no support for proper cross-dependencies | 10:14 |
salmon_ | dshulyak: it's not compatible | 10:15 |
dshulyak | which were added during task-based development | 10:15 |
dshulyak | compatible? | 10:15 |
salmon_ | for example core_repos does not exist | 10:15 |
dshulyak | yeah, thats good :) | 10:16 |
salmon_ | dshulyak: ok, I can finish making f2s compatible with current solar. I mean generating correct Composer files | 10:17 |
salmon_ | dshulyak: or do you want it to reewrite completly | 10:21 |
salmon_ | ? | 10:21 |
salmon_ | also I'm not sure if we need for now to patch hiera to get inputs for tasks | 10:21 |
azvyagintsev | hi guys. looks like you need to pack solar into rpm package, i can take this task :) | 10:24 |
tzn | that's cool! | 10:24 |
tzn | we would appreciate help here | 10:24 |
salmon_ | awesome :) | 10:24 |
azvyagintsev | ok, so i will :) | 10:24 |
tzn | at he same time, all stuff should be also packaged into deb as well | 10:24 |
pigmej | azvyagintsev: cool, | 10:24 |
dshulyak | salmon_: i wanted to kinda refactor it, with resuing some code probably | 10:24 |
salmon_ | at the same time? only if it's automated | 10:24 |
pigmej | azvyagintsev: we're currently removing version pinning there | 10:25 |
dshulyak | salmon_: what is the alternative for getting inputs? | 10:25 |
pigmej | (we have some pinned requirements in reqs.txt) | 10:25 |
dshulyak | or you want just generate all inputs for everyone? | 10:25 |
dshulyak | s/every task | 10:25 |
salmon_ | dshulyak: do we need inputs? | 10:25 |
pigmej | azvyagintsev: for RPM for fuel you can ignore whole riak dependency (it adds some stuff), because for fuel we will for sure using PostgreSQL | 10:26 |
azvyagintsev | @pigmej , hmm ? you'r about py pining? | 10:26 |
pigmej | azvyagintsev: yup :( | 10:26 |
salmon_ | dshulyak: in fuel currently one task is generating data in hiera and rest tasks are using it. We can do the same | 10:26 |
azvyagintsev | ah, yup - for sure :) first of all i will made and skeleton...nevermind - anyway, it will be on review :) | 10:27 |
salmon_ | dshulyak: we can dynamicly add input to the resource in solar now so if you want to change it you can add it then | 10:27 |
dshulyak | salmon_: i guess we can, and it might be even easier to sync with fuel, but we will need to put some hack into hiera | 10:28 |
salmon_ | dshulyak: what kind of hack? | 10:28 |
dshulyak | order of files | 10:29 |
salmon_ | ah, yes | 10:29 |
salmon_ | dshulyak: ok, Can I update resource/composer yaml generation or will it wast of time? | 10:29 |
salmon_ | *will it be a | 10:30 |
pigmej | azvyagintsev: so can we count on you in case of packaging stuff ? | 10:31 |
azvyagintsev | i guess yes, at least for rpm | 10:33 |
azvyagintsev | (also,are you going to implement auto-build job? i can talk with Fuel-Build team about adding solar to packetary bulds) | 10:34 |
pigmej | ok, perfect. Obviously feel free to contact us in case of *any* problems | 10:34 |
dshulyak | salmon_: it wont be, but we need to make several changes to current composition layer: 1. split it into smaller chunks (because currently file with roles contains all tasks, even conditional) 2. take into account cross-dependencies for events | 10:35 |
pigmej | well, could be usefull but I would not call it critical, because for sure we will include some tested solar version in fuel, so automaticaly builded stuff is not mission critical right now, especially that we will be unable to test it properly. | 10:35 |
dshulyak | salmon_: btw what was the idea of communication between solar and fuel? | 10:36 |
pigmej | dshulyak, salmon_: Do we need *any* changes in Nailgun / other fuel components for f2s ? | 10:36 |
dshulyak | it depends on ux we want to support | 10:37 |
pigmej | certainly no solar specific ux stuff | 10:37 |
salmon_ | dshulyak: well, there were some ideas but for 9.0 I think f2s approach is the only one possible: Console only, provision with fuel, continue with solar | 10:37 |
dshulyak | pigmej: what do you mean? | 10:38 |
pigmej | there was an idea that we can send message to rabbit and provide feedback for user. | 10:38 |
pigmej | dshulyak: one of ideas is to configure cluster in fuel and *DON"T CLICK DEPLOY" | 10:38 |
salmon_ | pigmej: I don't know if we have a time to do it right | 10:38 |
pigmej | ok, so let's aim for "DONT CLICK DEPLOY" method | 10:38 |
pigmej | :) | 10:38 |
salmon_ | but we can try | 10:38 |
salmon_ | but! we need working f2s first to test it | 10:39 |
pigmej | is there any chance that you both will be able to respond let's say late tomorrow what's possible? | 10:39 |
pigmej | salmon_ dshulyak do you both need more hands for f2s ? | 10:39 |
salmon_ | for now no, we need to figure out how to split the work first | 10:39 |
dshulyak | salmon_: i think you can concentrate on single role deployment, and in the meantime i will adjust old f2s version to split composition layer, and generate events based on cross-dependencies | 10:45 |
salmon_ | dshulyak: sounds good | 10:45 |
salmon_ | dshulyak: can we use my fork of your fork? :D | 10:46 |
dshulyak | salmon_: yes, i will you fork your fork of my fork | 10:46 |
dshulyak | ok messed up it a bit | 10:46 |
salmon_ | :D | 10:47 |
pigmej | fork fork of fork ? | 10:47 |
mkwiek | guys, a question regarding requirements: we have some kind of manual conditionals in requirements.txt: you can comment/uncomment riak/pewee/psycopg2 lines. Should we just let the package require all of these packages? | 10:48 |
azvyagintsev | aand, first one issue : python-jsonschema on centos got 2.3.0-1.el7, but you require python-jsonschema==2.4.0 | 10:48 |
azvyagintsev | pgmej: ^^ lets just try ignore issue? | 10:49 |
pigmej | mkwiek: don't touch these commented stuff for now | 10:49 |
dshulyak | i also had an idea of installing nailgun and nailgun-agent on the vagrant box, it will allow to expirement faster | 10:49 |
pigmej | I mean, don't change their meaning | 10:49 |
pigmej | azvyagintsev: hmm, yeah try to ignore it for now | 10:49 |
azvyagintsev | (if it will be hard-requirment, i can ask *linux team for creating new package) | 10:49 |
salmon_ | dshulyak: yeah, good idea. The question is: will nailgun work this way? :D | 10:49 |
dshulyak | i think so, to my knowledge we will need to adjust networking configuration in nailgun config, and nailgun url in nailgun-agent config | 10:50 |
pigmej | mkwiek: for 9.0 we will use PostgreSQL on fuel-master | 10:50 |
salmon_ | dshulyak: waiting for playbook :P | 10:51 |
pigmej | so default will be psycopg2 + peewee. | 10:51 |
pigmej | azvyagintsev: info for you # psycopg2 | 10:51 |
pigmej | # psycogreen | 10:51 |
pigmej | these two are required too | 10:51 |
azvyagintsev | ok | 10:52 |
mkwiek | pigmej: ok, thanks for info | 10:52 |
pigmej | azvyagintsev: from what I see there is a chance that 2.3 will work perfectly fine :) | 10:54 |
pigmej | azvyagintsev: could you please dump centos package versions of stuff that we have in solar ? | 10:55 |
azvyagintsev | sure :) i will add it into comments in spec | 10:57 |
pigmej | k | 10:58 |
azvyagintsev | some part- http://paste2.org/hFtxOzvj | 10:58 |
pigmej | azvyagintsev: thx | 10:59 |
azvyagintsev | pigmej: so, we got at least 3 "winners" :( http://paste2.org/gKGOFCEp | 11:07 |
pigmej | shit :D | 11:07 |
azvyagintsev | should i talk with mos-linux team ? they can prepare this few packages, if we really need them | 11:07 |
pigmej | psycogreen is for sure needed | 11:07 |
pigmej | fabric is used in Fuel afair, so it's strange that it's not packaged | 11:08 |
azvyagintsev | hm, let me check.. | 11:09 |
pigmej | and that tabulate, we can easily drop it if needed (it's used in only one place, just for pretty error printing) | 11:09 |
azvyagintsev | ah, awesome.. as usual, they just ignore python* naming.. ok, give me few second to re-check again.. | 11:10 |
pigmej | :D:D | 11:10 |
*** tzn has quit IRC | 11:10 | |
azvyagintsev | so yeah, at least minus Fabric issue | 11:13 |
pigmej | cool, | 11:13 |
pigmej | and that inflection can be removed mkwiek ^ | 11:14 |
pigmej | brb | 11:14 |
*** kun_huang has quit IRC | 11:40 | |
*** mihgen has quit IRC | 11:40 | |
*** kun_huang has joined #openstack-solar | 11:43 | |
*** mihgen has joined #openstack-solar | 11:47 | |
mkwiek | I have problem with just one package when running tox tests: pyzmq. If I align it to global requirements tox run hangs after most of the tests are run. it works on the pinned version that we have in our requirements: 13.0.2, but fails with 14.3.1 (which is minimal in OS global requirements) and 15.2.0 | 11:49 |
mkwiek | there is a comment about this in requirements.txt: "#zerorpc doesnt consume messages with >13.0.2, need to debug" | 11:49 |
mkwiek | did anyone had a chance to debug that? | 11:50 |
mkwiek | *have | 11:50 |
pigmej | dshulyak: ^ | 12:00 |
*** tzn has joined #openstack-solar | 12:10 | |
*** tzn has quit IRC | 12:11 | |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Align requirements with global-requirements.txt https://review.openstack.org/283054 | 12:20 |
openstackgerrit | Aleksey Zvyagintsev proposed openstack/solar: Add rpm spec file for solar https://review.openstack.org/283056 | 12:21 |
salmon_ | pigmej: look finaly some reviews from other guys :) | 12:22 |
pigmej | yeah :) | 12:23 |
*** tzn has joined #openstack-solar | 12:23 | |
azvyagintsev | salmon_: so, we really need multipledispatch ;( | 12:25 |
azvyagintsev | * in centos, i mean | 12:25 |
azvyagintsev | and few others , i guess..so, should i ask mos-linux guys? and by the way, are we going to build solar packages with mos-infra resources (it will be really god :) ) | 12:27 |
pigmej | azvyagintsev: well we can remove multipledispatch easily | 12:28 |
azvyagintsev | i don't think so | 12:29 |
azvyagintsev | solar --help | 12:29 |
azvyagintsev | Traceback (most recent call last): | 12:29 |
azvyagintsev | File "/usr/bin/solar", line 6, in <module> | 12:29 |
azvyagintsev | from solar.cli.main import run | 12:29 |
azvyagintsev | File "/usr/lib/python2.7/site-packages/solar/cli/main.py", line 28, in <module> | 12:29 |
azvyagintsev | from solar.core import resource as sresource | 12:29 |
azvyagintsev | File "/usr/lib/python2.7/site-packages/solar/core/resource/__init__.py", line 15, in <module> | 12:29 |
azvyagintsev | from solar.core.resource.resource import load | 12:29 |
azvyagintsev | File "/usr/lib/python2.7/site-packages/solar/core/resource/resource.py", line 24, in <module> | 12:29 |
azvyagintsev | from multipledispatch import dispatch | 12:29 |
azvyagintsev | ImportError: No module named multipledispatch | 12:29 |
azvyagintsev | (wow, awesome message. sry) | 12:29 |
azvyagintsev | or you mean ,remove it from code at all ? | 12:29 |
salmon_ | dshulyak: my change are here https://github.com/loles/f2s/pull/1 | 12:32 |
salmon_ | dshulyak: I will try to deploy compute role now | 12:32 |
salmon_ | well, after 20 min break | 12:33 |
pigmej | azvyagintsev: we can | 12:36 |
mkwiek | pigmej: can we delete these @dispatch decorators from Resource class? | 12:37 |
salmon_ | delete? now. Rewrite? yes :) | 12:37 |
pigmej | yup | 12:38 |
pigmej | I can do it but I need ~30 minutes | 12:38 |
pigmej | I can start in 30 minutes | 12:38 |
pigmej | azvyagintsev: if it's blocking for you, just comment it (solar will not work properly) but you could test pacakging | 12:39 |
mkwiek | is it just for overloading the __init__? | 12:41 |
pigmej | ;yp | 12:45 |
pigmej | yup | 12:45 |
pigmej | we can easily do the same without multidispatch | 12:45 |
pigmej | first version may be ugly though | 12:45 |
azvyagintsev | pigmej: nevermind, to it in time :) package builds and installs - i will re-fix version's after https://review.openstack.org/283054 merge. and get back to spec again. its really simple issue, and in general- spec can be reviewed now. | 12:50 |
azvyagintsev | * do it in time | 12:50 |
mkwiek | the biggest issue right now seem to be pyzmq incompatibility, but maybe we can leave it pinned? | 12:56 |
dshulyak | mkwiek: what version used in openstack? | 13:01 |
mkwiek | dshulyak: pyzmq>=14.3.1 | 13:02 |
dshulyak | it is pinned cause zerorpc wasnt able to consume messages with 15.* and i knew that it was ok with 13.* | 13:05 |
dshulyak | i dont remember if i tested it with 14.* | 13:05 |
mkwiek | yeah, 14.x also seem to not work | 13:06 |
mkwiek | so I guess we will need it in this version on FMN | 13:06 |
dshulyak | what do we have in fuel? or zeromq is not package at all? | 13:06 |
dshulyak | s/packaged | 13:06 |
mkwiek | I think it's not needed in nailgun | 13:08 |
mkwiek | it's not here: https://github.com/openstack/fuel-web/blob/master/nailgun/requirements.txt | 13:09 |
dshulyak | yeah thats for sure, but maybe it was packaged for centos | 13:09 |
dshulyak | openstack centos i mean | 13:09 |
mkwiek | no idea, azvyagintsev do you know what version of pyzmq is available in packages? | 13:10 |
pigmej | ok, I'm back | 13:21 |
pigmej | so what's the state of packaging? | 13:21 |
pigmej | mkwiek: can we set it <= ? | 13:24 |
azvyagintsev | pigmej: noone at all ;( | 13:25 |
pigmej | azvyagintsev: I will remove that multipledispatch, sounds ok ? | 13:26 |
azvyagintsev | sure | 13:26 |
pigmej | both multipledispatch and tabulate | 13:26 |
pigmej | btw for zmq in worst case we can deliver precompilled so | 13:27 |
mkwiek | pigmej: not sure what the latest version that works with solar is | 13:27 |
mkwiek | yeah, we have the benefit of this package not being used on FMN yet :D | 13:28 |
pigmej | FMN ? | 13:28 |
azvyagintsev | pigmej: precompiled ? you mean in rpm? | 13:28 |
pigmej | yeah as a part of solar | 13:29 |
mkwiek | pigmej: Fuel Master Node | 13:30 |
pigmej | ah | 13:31 |
azvyagintsev | ok, so after you remove multipledispatch and maybe some more, i will re-check req's and create a ticket for packaging team. | 13:32 |
pigmej | k | 13:33 |
pigmej | hmmmmm | 13:36 |
pigmej | salmon_: dshulyak anyone remeber what WAS find_missing_connections doing ? | 13:36 |
pigmej | salmon_: in fact it was in virtual resoruce part... | 13:36 |
dshulyak | i dont | 13:37 |
pigmej | Because that tabulate is used in non working part... | 13:37 |
pigmej | because we don't have find_missing_connections anymore :D | 13:38 |
salmon_ | pigmej: just delete this part https://github.com/openstack/solar/blob/master/solar/cli/resource.py#L173-L185 :) | 13:40 |
salmon_ | an old idea | 13:40 |
pigmej | yeah I did it:P | 13:40 |
salmon_ | Przemek added it | 13:40 |
pigmej | https://github.com/openstack/solar/blob/master/solar/cli/resource.py#L167 I also deleted this ;P | 13:41 |
salmon_ | good :) | 13:41 |
pigmej | :) | 13:41 |
mkwiek | pigmej: is it ok for me to work on this one: https://bugs.launchpad.net/solar/+bug/1540304 ? | 13:49 |
openstack | Launchpad bug 1540304 in Solar "When solar worker is not running run-once doesn't return error" [High,Confirmed] - Assigned to Maciej Kwiek (maciej-iai) | 13:49 |
salmon_ | :) | 13:50 |
pigmej | mkwiek: it's not that simple, because zmq doesn't provide any info on other side, so we will need additional socket to check if it's alive | 13:50 |
salmon_ | mkwiek: it's tricky | 13:50 |
mkwiek | I can read from your messages "take something easier" :D | 13:52 |
pigmej | well it's not hard, it' | 13:52 |
pigmej | it's tricky | 13:52 |
pigmej | this is important also: https://bugs.launchpad.net/solar/+bug/1541022 | 13:53 |
openstack | Launchpad bug 1541022 in Solar "Weird timings in stats in solar o report" [Undecided,New] - Assigned to Dima Shulyak (dshulyak) | 13:53 |
pigmej | but Idk what's the state there from dshulyak | 13:53 |
mkwiek | I didn't want to snatch bugs from other people, but dshulyak if you won't be doing this one, can I have it? | 13:56 |
pigmej | this also https://bugs.launchpad.net/solar/+bug/1545813 | 13:56 |
openstack | Launchpad bug 1545813 in Solar "Better error reporting in solar-worker when database is wrongly configured" [Undecided,New] | 13:56 |
pigmej | in fact you may start from https://bugs.launchpad.net/solar/+bug/1545813 (it's easy I would say) :D | 13:57 |
mkwiek | ok, thanks! | 13:57 |
pigmej | and about that weird times: https://bugs.launchpad.net/solar/+bug/1547411 this is probably related, but it was none vs none | 13:57 |
openstack | Launchpad bug 1547411 in Solar "[orch] TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType'" [Undecided,New] | 13:57 |
pigmej | you also created https://bugs.launchpad.net/solar/+bug/1547529 and you know how easy it's to mess with arguments ordering | 13:58 |
openstack | Launchpad bug 1547529 in Solar "solar-worker accepts arguments which don't do anything" [Undecided,New] | 13:58 |
pigmej | oh that none is duplicated https://bugs.launchpad.net/solar/+bug/1547411 vs https://bugs.launchpad.net/solar/+bug/1547537 | 13:59 |
openstack | Launchpad bug 1547411 in Solar "[orch] TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType'" [Undecided,New] | 13:59 |
openstack | Launchpad bug 1547537 in Solar "`solar orch report` yields an error when there are no resources" [Undecided,New] | 13:59 |
openstackgerrit | Bogdan Dobrelya proposed openstack/solar: (WIP) Add packer build for docker container https://review.openstack.org/281767 | 14:01 |
pigmej | mkwiek: see ? just say that you have nothing to do and I will find stuff :P | 14:01 |
dshulyak | thats is leftover after i changed defaults in tasks, none -> 0.0. | 14:01 |
mkwiek | pigmej: yeah, I can see :D | 14:04 |
pigmej | mkwiek: as you see dshulyak has some details for you :) | 14:05 |
pigmej | dshulyak: yeah I suppose, but it's also good way to allow mkwiek to understand some parts :) | 14:05 |
pigmej | dshulyak: "- versioning and external actions scripts" what do you mean by that ? | 14:06 |
dshulyak | hm, i messed up equality check there, i thought it the same as for small integers | 14:07 |
dshulyak | pigmej: i suppose when we will use fuel - actions will be stored in original place | 14:08 |
dshulyak | e.g - /etc/puppet/modules | 14:08 |
pigmej | dshulyak: we can use links :) | 14:09 |
dshulyak | and they are kinda versioned there | 14:09 |
dshulyak | for fuel 8.0 we have /etc/puppet/8.0 | 14:09 |
dshulyak | for 9.0 /etc/puppet/9.0 | 14:09 |
pigmej | well, we still have this support for defining them in meta as full paths | 14:09 |
dshulyak | no need for links i guess, just path wont be relative | 14:09 |
pigmej | afair we can give full path too | 14:09 |
pigmej | but it changed like milion times ;D | 14:10 |
dshulyak | this what was done in latest version of f2s, to avoid desync, this is just a reminder that i need to add version to the path | 14:11 |
pigmej | ah k | 14:11 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Remove unused libraries https://review.openstack.org/283093 | 14:14 |
pigmej | guys please review it, it will unblock packaging stuff + reqs | 14:14 |
*** openstackgerrit has quit IRC | 14:17 | |
*** openstackgerrit has joined #openstack-solar | 14:17 | |
mkwiek | pigmej: I think you forgot to remove tabulate from requirements.txt? | 14:20 |
pigmej | fuck | 14:20 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Remove unused libraries https://review.openstack.org/283093 | 14:21 |
pigmej | done :) | 14:21 |
pigmej | thx mkwiek ;) | 14:21 |
openstackgerrit | Merged openstack/solar: Remove unused libraries https://review.openstack.org/283093 | 14:31 |
pigmej | mkwiek: please adjust your patch now :) | 14:34 |
mkwiek | sure | 14:34 |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Align requirements with global-requirements.txt https://review.openstack.org/283054 | 14:39 |
mkwiek | done | 14:41 |
mkwiek | although wait! I need to pin pyzmq | 14:42 |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Align requirements with global-requirements.txt https://review.openstack.org/283054 | 14:42 |
openstackgerrit | Bogdan Dobrelya proposed openstack/solar-resources: Do not use atomic file updates for hosts_file https://review.openstack.org/283120 | 15:14 |
*** tzn has quit IRC | 15:29 | |
pigmej | salmon_: dshulyak please check fixes from mkwiek about requirements AND about become user stuff :) | 15:56 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fixed non working test on riak backend https://review.openstack.org/283155 | 16:51 |
*** tzn has joined #openstack-solar | 16:54 | |
*** tzn has quit IRC | 17:29 | |
openstackgerrit | Aleksey Zvyagintsev proposed openstack/solar: Add rpm spec file for solar https://review.openstack.org/283056 | 17:32 |
pigmej | azvyagintsev: are you sure that there is no python-zmq for centos ? | 17:47 |
pigmej | no three is no :( it's just in openstack-* repos ;/ | 17:50 |
azvyagintsev | yup ;( | 17:52 |
azvyagintsev | it's not a problem for our package team (i guess :) ) | 17:52 |
pigmej | btw I added one comment about inflection package, can be safely removed :) | 17:53 |
pigmej | removal of tabulate & multipledispatch is merged already :) | 17:53 |
pigmej | so you can remove them too :) | 17:53 |
azvyagintsev | and https://review.openstack.org/#/c/283093/ also remove few dep's) | 17:55 |
azvyagintsev | actually, i'm waiting for https://review.openstack.org/#/c/283054/ to merge. | 17:55 |
pigmej | me too :D | 17:55 |
pigmej | hmm, I thought I gave it +1, at least I did it now ;) | 17:56 |
pigmej | azvyagintsev: btw, will you take care about missing packages too ? | 17:57 |
azvyagintsev | yup | 17:57 |
pigmej | cool. | 17:57 |
azvyagintsev | (if you mean, add rpm packages into fuel repos :) ) | 17:58 |
pigmej | sure | 17:58 |
pigmej | that's what I meant :) | 17:58 |
azvyagintsev | ok :) | 17:58 |
pigmej | what else could I mean azvyagintsev :P | 18:02 |
*** angdraug has joined #openstack-solar | 18:05 | |
azvyagintsev | ( pigmej: re-write code for not using this modules?)) ) | 18:15 |
azvyagintsev | do we need python-semver ? i found only python-semantic_version (have no idea what it is :) ) | 18:20 |
pigmej | azvyagintsev: I need to go, semver is used only in one place, maybe we could replace it with this library | 18:22 |
azvyagintsev | ok. thanks | 18:22 |
pigmej | semantic_version is smaller | 18:22 |
pigmej | if it does the same then it will be super easy to adjust :) | 18:22 |
*** tzn has joined #openstack-solar | 18:26 | |
*** salmon_ has quit IRC | 18:50 | |
*** tzn has quit IRC | 18:59 | |
*** dshulyak has quit IRC | 19:10 | |
*** angdraug has quit IRC | 19:33 | |
*** salmon_ has joined #openstack-solar | 19:51 | |
*** tzn has joined #openstack-solar | 19:55 | |
*** tzn has quit IRC | 20:29 | |
*** dshulyak has joined #openstack-solar | 20:30 | |
*** openstackgerrit has quit IRC | 20:47 | |
*** openstackgerrit has joined #openstack-solar | 20:47 | |
*** tzn has joined #openstack-solar | 21:44 | |
openstackgerrit | Lukasz Oles proposed openstack/solar: Fix no attribute: result has no s https://review.openstack.org/283286 | 22:24 |
openstackgerrit | Merged openstack/solar-resources: Change sudo to become in ansible resources https://review.openstack.org/283009 | 22:31 |
*** tzn has quit IRC | 22:37 | |
openstackgerrit | Merged openstack/solar: Change sudo to become in bootstrap playbooks https://review.openstack.org/283014 | 22:40 |
openstackgerrit | Merged openstack/solar: Align requirements with global-requirements.txt https://review.openstack.org/283054 | 22:40 |
openstackgerrit | Merged openstack/solar: Fix no attribute: result has no s https://review.openstack.org/283286 | 22:40 |
*** dshulyak has quit IRC | 22:51 | |
*** salmon_ has quit IRC | 22:51 | |
*** tzn has joined #openstack-solar | 23:37 | |
*** tzn has quit IRC | 23:41 | |
*** tzn has joined #openstack-solar | 23:42 | |
*** tzn has quit IRC | 23:43 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!