openstackgerrit | Annie Lezil proposed openstack/solar: Fixed alignment issues in the text https://review.openstack.org/283326 | 00:18 |
---|---|---|
*** tzn has joined #openstack-solar | 01:25 | |
*** tzn has quit IRC | 01:30 | |
*** tzn has joined #openstack-solar | 02:44 | |
*** tzn has quit IRC | 02:48 | |
*** tzn has joined #openstack-solar | 07:22 | |
*** tzn has quit IRC | 07:27 | |
*** dshulyak has joined #openstack-solar | 07:57 | |
mkwiek | hello guys! I have a question: where do we keep db config in solar? where does the "riak://127.0.0.1:port" come from? | 08:11 |
mkwiek | also, a question about this bug: https://bugs.launchpad.net/solar/+bug/1545813 "When worker has different solar_db than cli". Does it mean that worker has correct db string, which it can use to connect to db, but it's different than the one that regular solar cli uses? | 08:15 |
openstack | Launchpad bug 1545813 in Solar "Better error reporting in solar-worker when database is wrongly configured" [Undecided,Confirmed] - Assigned to Maciej Kwiek (maciej-iai) | 08:15 |
mkwiek | is this even an error? I mean, how can we know while starting solar-worker what db string will cli use? | 08:16 |
mkwiek | pigmej: ^^ | 08:20 |
dshulyak | mkwiek: hey, take a look at L56 in config.py, there can be several overrides, in vagrant environment relevant config stored in /.solar_config_override | 08:27 |
mkwiek | dshulyak: thanks! | 08:29 |
dshulyak | i think the first thing we need to do is to log database configuration, i even think that i was adding this logging somewhere but it is not commited, the second problem is that worker doesnt fail when graph is not written to database | 08:30 |
mkwiek | dshulyak: when should graph writing occur? | 08:37 |
dshulyak | writing will occur either when you type - solar or create or solar ch process, but if cli will use different config file (different db connection)… | 08:40 |
pigmej | hey guys :) | 08:41 |
pigmej | mkwiek: you can export SOLAR_DB=.... | 08:41 |
pigmej | and check yourself :) | 08:41 |
pigmej | dshulyak: have you seen: https://review.openstack.org/#/c/283155/2/solar/dblayer/test/test_real.py ? | 08:44 |
dshulyak | pigmej: why is it non-working? | 08:45 |
pigmej | because we (I) added resolver for bucket | 08:46 |
pigmej | so whole resolving is hidden | 08:46 |
dshulyak | i forgot | 08:46 |
dshulyak | ok | 08:46 |
pigmej | me too :D | 08:46 |
pigmej | and riak client dislike how mock works so I had to do ugly workaround ;/ | 08:46 |
dshulyak | 1. will we propagate inputs from higher-level composition to lower-level? 2. do we support AND lookups with tags? | 08:56 |
pigmej | dshulyak: ? | 08:56 |
dshulyak | :) | 08:56 |
dshulyak | which part? | 08:56 |
pigmej | 1st | 08:57 |
pigmej | dshulyak: :> | 08:59 |
dshulyak | yes, one sec | 09:00 |
pigmej | k | 09:00 |
dshulyak | pigmej: http://paste.openstack.org/show/487855/ this is two separate vrs | 09:01 |
dshulyak | compositiions of whatever | 09:01 |
pigmej | yeah and the question is about ? | 09:01 |
dshulyak | 1st is like collection | 09:01 |
dshulyak | will lower-level composition will see params that we will pass to higher-level one? | 09:02 |
pigmej | afair no | 09:03 |
pigmej | https://github.com/openstack/solar-resources/blob/master/templates/nodes/1.0.0/nodes.yaml | 09:03 |
pigmej | + https://github.com/openstack/solar-resources/blob/master/templates/node/1.0.0/node.yaml | 09:03 |
pigmej | we have isolation of inputs passed to separate VRS | 09:04 |
pigmej | Composer thigns* | 09:04 |
dshulyak | i’ve seen examples with input declaration | 09:04 |
dshulyak | ok, i guess i will just declare them as well | 09:04 |
dshulyak | what about 2nd ? | 09:04 |
pigmej | afair the idea was to separate namespaces, I mean each resource has it's own namespace there | 09:04 |
dshulyak | we do support AND lookups? | 09:04 |
pigmej | hmm | 09:04 |
pigmej | what do you mean by that? | 09:04 |
pigmej | Lukasz improved Ply thingy for complicated queries | 09:05 |
dshulyak | with_tags: [resource=deploy_start, 'node={{node}}'] | 09:05 |
pigmej | https://github.com/openstack/solar/blob/master/solar/test/test_operations_with_tags.py#L56 | 09:05 |
dshulyak | is it via ply or it can be done on a backend? | 09:06 |
pigmej | https://github.com/openstack/solar/blob/master/solar/core/resource/resource.py#L376 | 09:06 |
dshulyak | ply means we need to load a lot of things | 09:06 |
pigmej | the good part is that it's just index scan, and it's fast enough it most cases | 09:06 |
pigmej | we return all candidates ids, then filter them, and then fetch only these which are needed | 09:07 |
pigmej | we can't do AND queries on backend level | 09:07 |
pigmej | we COULD provide optional functions per backend though | 09:07 |
dshulyak | ok, i just spotted that there will be a lot of them, we will try and then decide | 09:08 |
pigmej | we have that cache enabled there, so maybe it's not a big problem | 09:09 |
pigmej | and if that cache is not enabled then we can enable it there :) | 09:09 |
*** salmon_ has joined #openstack-solar | 09:12 | |
*** salmon_ has quit IRC | 09:15 | |
*** salmon_ has joined #openstack-solar | 09:16 | |
openstackgerrit | Merged openstack/solar: Fixed non working test on riak backend https://review.openstack.org/283155 | 09:36 |
salmon_ | pigmej: remove workflow from this https://review.openstack.org/#/c/283326/1 it's broken | 09:38 |
salmon_ | fast! | 09:38 |
pigmej | salmon_: I tested it | 09:38 |
pigmej | why it's broken you say? | 09:38 |
salmon_ | lines are too long now | 09:38 |
salmon_ | this is correct fix: https://bpaste.net/show/5c5843a2455a | 09:39 |
pigmej | ah I forgot about line length ... | 09:39 |
salmon_ | :) | 09:40 |
pigmej | jenkins already gave +2 ;P | 09:42 |
salmon_ | :( | 09:43 |
pigmej | but it's not merged so there is still a chance :D | 09:44 |
pigmej | salmon_: "We are trying to have max 80 characters in a line." :D:D:D | 09:44 |
pigmej | and well tox -edocs prints a lot of stuff right now;p | 09:44 |
salmon_ | well, there is no auto test for it and there are still some lines with more than 80 characters | 09:45 |
salmon_ | pigmej: yeah, but message about line length is at the end :) | 09:45 |
pigmej | ;D | 09:46 |
mkwiek | can't we add another gate check to OS infra for this? | 09:48 |
pigmej | well, we could but run tox -edocs :P | 09:50 |
salmon_ | dshulyak: we need to agree on repository path :) | 09:51 |
pigmej | the problem is that after bogdando added these checkniceness etc we have a lot of warnings there :D | 09:51 |
pigmej | maybe we should create bug for fixing these docs... | 09:56 |
*** tzn has joined #openstack-solar | 10:01 | |
*** tzn has quit IRC | 10:01 | |
*** tzn has joined #openstack-solar | 10:01 | |
*** tzn has quit IRC | 10:03 | |
*** azvyagintsev_ has joined #openstack-solar | 10:03 | |
*** azvyagintsev_ has quit IRC | 10:05 | |
*** alexz__ has joined #openstack-solar | 10:08 | |
*** alexz__ has quit IRC | 10:21 | |
pigmej | dshulyak: salmon_ can you do some PoC of non connections based approach ? | 10:42 |
pigmej | even non working PoC, just some described steps. | 10:44 |
salmon_ | pigmej: for now nothing is working :P | 10:45 |
pigmej | yeah i expected it | 10:48 |
pigmej | but can you describe a predicted workflow ? | 10:48 |
salmon_ | "same as in fuel" | 10:49 |
pigmej | we need it from solar side | 10:49 |
*** dshulyak has quit IRC | 11:06 | |
openstackgerrit | Bogdan Dobrelya proposed openstack/solar-resources: Do not use atomic file updates for hosts_file https://review.openstack.org/283120 | 11:06 |
*** dshulyak has joined #openstack-solar | 11:25 | |
salmon_ | dshulyak: I merged your changes and will rebase main | 11:26 |
*** azvyagintsev_h__ has joined #openstack-solar | 11:42 | |
pigmej | brb | 11:43 |
pigmej | back | 11:48 |
salmon_ | dshulyak: why this is empty now https://github.com/loles/f2s/blob/master/vrs/role_base-os.yaml ? there are 3 tasks there https://github.com/openstack/fuel-library/blob/master/deployment/puppet/deployment_groups/tasks.yaml#L120-L133 | 11:49 |
dshulyak | salmon_: thats because relationship from group to task is not parsed, only from task to group, this shouldnt affect any other role | 11:52 |
salmon_ | hmm, ok. We will see :) | 11:53 |
pigmej | can I help somehow you both ? | 11:54 |
dshulyak | bogdando: where are fuel-library fixtures? | 11:57 |
dshulyak | ok i found them | 11:58 |
dshulyak | https://github.com/openstack/fuel-noop-fixtures/blob/master/hiera/neut_vlan.ceph.ceil-compute.overridden_ssl.yaml | 11:58 |
dshulyak | pigmej: if you want you can get those f2s artifacts and some fixture, and try to deploy something | 11:59 |
dshulyak | but you will need to change network config | 11:59 |
pigmej | nothing "more" general? | 12:01 |
dshulyak | we also need to preare 2 specs, one about exposing compiled graph, another that will describe general integration, even if it wont be complete | 12:05 |
pigmej | anyway, we're going to deliver f2s as separate package, right? | 12:07 |
pigmej | because we need to include 2 things in fuel, solar itself and fs2, isn't it? | 12:07 |
dshulyak | i think yes, from f2s we need 2 parts - solar resources and compositions (repository) and client that will take data from fuel and pass it to solar | 12:09 |
pigmej | so we need to package it too? | 12:09 |
salmon_ | yup | 12:10 |
pigmej | resoruces and compositions => add to solar repository as "fuel", and the client is what, python program, right? | 12:10 |
dshulyak | yes | 12:10 |
salmon_ | dshulyak: why did you remove fuel_node? | 12:12 |
salmon_ | vrs/fuel_node.yaml | 12:13 |
dshulyak | salmon_: because i forgot that there was also non-generated parts.. | 12:13 |
salmon_ | ah :) | 12:13 |
salmon_ | dshulyak: will you revert it? | 12:13 |
salmon_ | I think genkeys also | 12:14 |
salmon_ | dshulyak: you can put it in separate directory | 12:14 |
dshulyak | yeah, lets revert it, i didnt think that you will merge it | 12:14 |
salmon_ | merge fast, iterate faster! | 12:15 |
salmon_ | dshulyak: not revert everything. just not generated parts | 12:16 |
dshulyak | ah | 12:16 |
dshulyak | :) | 12:16 |
salmon_ | ah, there was WIP in the tittle. Sorry, I didn't notice :( | 12:17 |
salmon_ | Ok, I will revert not generated parts | 12:17 |
dshulyak | there is only 2 | 12:18 |
salmon_ | fuel_node and genkeys? | 12:18 |
salmon_ | prep.yaml also | 12:19 |
dshulyak | salmon_: yes, sorry - 3, btw can you describe how you are using inputs, because i removed them from every resource | 12:20 |
dshulyak | and i removed role data | 12:20 |
salmon_ | oh | 12:20 |
salmon_ | why did you remove role_data? | 12:20 |
dshulyak | because role data schema is sum of all inputs (astute.yaml + globals.yaml) and it is probably outdated | 12:24 |
dshulyak | and also i thought that you want to feed data to globals resource | 12:24 |
dshulyak | and then share it via hack in hiera | 12:24 |
dshulyak | no? | 12:24 |
salmon_ | dshulyak: I wanted to do it the same way as fuel is doing. By having data only in "role resource" which adds it to hiera | 12:25 |
dshulyak | salmon_: but then this resource is not what was needed, isnt it? | 12:32 |
dshulyak | also it seems we have problem with schema.. | 12:32 |
salmon_ | dshulyak: please explain more :) | 12:33 |
dshulyak | it can be dynamicly extended with plugins.. | 12:33 |
salmon_ | role data? | 12:33 |
salmon_ | or global data? | 12:34 |
dshulyak | what is global? | 12:35 |
dshulyak | settings? | 12:35 |
salmon_ | dshulyak: I think we need a call | 12:35 |
dshulyak | yeah, lets use syncup channel | 12:35 |
salmon_ | ok | 12:35 |
salmon_ | pigmej: if you want to join^ | 12:35 |
pigmej | I joined | 12:50 |
pigmej | but noone is there | 12:50 |
salmon_ | we were fast :) | 12:57 |
pigmej | back :) | 13:21 |
pigmej | yaeh | 13:21 |
salmon_ | afk, will be back later | 13:45 |
*** salmon_ has quit IRC | 13:49 | |
pigmej | hmm wtf | 13:53 |
pigmej | dshulyak: did anyone fixed some things in pg backend or these 2 tests? | 13:54 |
dshulyak | pigmej: i didnt | 13:54 |
pigmej | because one of them started to work | 13:57 |
pigmej | :| | 13:57 |
dshulyak | yes, i was asking about it yesterday | 13:58 |
pigmej | but I also pasted: https://bpaste.net/show/73c651fdfbe5 | 13:58 |
pigmej | also yesterday | 13:58 |
pigmej | ok finally crashed it | 13:59 |
pigmej | https://bpaste.net/show/d003ee822280 | 13:59 |
bogdando | folks, the docker experimantal support seems ok, this https://review.openstack.org/#/c/281767 works for me with the patch https://review.openstack.org/#/c/283120/ | 14:26 |
bogdando | I suggest you to test it, merge as is. Later we can address workarounds (then vagrant ready for docker nets) | 14:27 |
bogdando | And later we can add support for multi nets as well, to deploy the openstack example | 14:27 |
bogdando | pigmej, ^^ | 14:28 |
bogdando | I didn't test preprovisioned mode though, I have no idea how it should be working | 14:28 |
openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Add packer build for docker container https://review.openstack.org/281767 | 14:31 |
pigmej | bogdando: Yeah I'm going to check it :) | 14:35 |
pigmej | bogdando: can you also take care about migrating to centos from ubuntu ? | 14:35 |
pigmej | or you prefer to wait from packaging stuff that azvyagintsev is doing? | 14:35 |
bogdando | pigmej, I think we should add centos packer things, right near to existing ones for ubuntu. | 14:36 |
bogdando | I see no point in removing that we already have | 14:36 |
pigmej | yup | 14:37 |
bogdando | I will take a look | 14:37 |
pigmej | but it will double maintenance time, we need to think about it. Maybe we will leave then the ubuntu as "old" stuff | 14:37 |
bogdando | do we have a bug for this created? :) | 14:37 |
pigmej | nope, you can create it | 14:38 |
*** salmon_ has joined #openstack-solar | 14:40 | |
pigmej | bogdando: olar-master-docker.json where is that file? | 14:40 |
pigmej | nvm! | 14:40 |
*** salmon_ has quit IRC | 14:44 | |
mkwiek | hey guys, do we have a generic way to retrieve an object from database? I can't find anything like this in tests | 14:44 |
mkwiek | I would like to retrieve an object with given uid | 14:45 |
*** salmon_ has joined #openstack-solar | 14:45 | |
bogdando | pigmej, https://bugs.launchpad.net/solar/+bug/1548851 | 14:45 |
openstack | Launchpad bug 1548851 in Solar "Run solar nodes as docker containers (Centos7 based)" [Medium,New] - Assigned to Bogdan Dobrelya (bogdando) | 14:45 |
pigmej | bogdando: not like that | 14:46 |
pigmej | we need 'master' node to be centos :) | 14:46 |
bogdando | for now, there is only single image | 14:46 |
pigmej | not exactly docker, it has to be centos :) | 14:46 |
bogdando | I suggested to start with docker, and finish with libvirt/vbox providers/boxes | 14:47 |
bogdando | And let's make the split master/slaves images as a separate bug | 14:47 |
bogdando | we relly should not do all in one place | 14:47 |
mkwiek | nvm, I think I got it | 14:48 |
pigmej | bogdando: sure, we need to split the images :) | 14:48 |
pigmej | but ok, let's first do docker + centos thingy | 14:49 |
pigmej | :) | 14:49 |
pigmej | but we still will need vbox/libvirt stuff I'm afraid for compaitbility | 14:49 |
bogdando | I will update them as well | 14:49 |
bogdando | you can check the patch for docker at ubuntu, the diff to atlas json is really small | 14:50 |
pigmej | bogdando: cool :) | 14:51 |
pigmej | mkwiek: dbmodel.get(id) | 14:51 |
pigmej | all dblayer tests are in solar/dblayer/tests | 14:51 |
mkwiek | pigmej: yeah, but I need to know what dbmodel the key belongs to, right? | 14:52 |
mkwiek | so if I have system_log:1d38ec24-8042-4d62-ac10-b74a9179f60c I need to call system_log type model? | 14:53 |
pigmej | sure you need to know it :) | 14:54 |
pigmej | hmm this one has no model at all | 14:54 |
pigmej | hmm | 14:55 |
pigmej | yeah it's a list of all log items with the same log, why do you ask mkwiek ? | 14:55 |
mkwiek | I am trying to figure out if anything with uid that I have is available in the database | 14:56 |
mkwiek | I want to prevent Locks from locking non-existent uids | 14:57 |
pigmej | oh that's not a good idea I think | 14:57 |
pigmej | because it will require additional lookups | 14:57 |
mkwiek | yeah, I am aware of that | 14:57 |
pigmej | which will be executed in all cases, even these which are good :) | 14:58 |
pigmej | what exactly are you trying to solve now? | 14:58 |
mkwiek | still working on this one: https://bugs.launchpad.net/solar/+bug/1545813 | 15:00 |
openstack | Launchpad bug 1545813 in Solar "Better error reporting in solar-worker when database is wrongly configured" [Undecided,Confirmed] - Assigned to Maciej Kwiek (maciej-iai) | 15:00 |
mkwiek | when there are two different databases | 15:00 |
mkwiek | what would you suggest then? | 15:00 |
mkwiek | sending a message with current db config with zmq message and printing a warning if it doesn't match? | 15:01 |
mkwiek | this might be better | 15:02 |
pigmej | mkwiek: well no why like that ? | 15:02 |
pigmej | just proceed, and when you try to fetch graph info you will have empty graph | 15:02 |
pigmej | then you can raise error that graph does not exists | 15:02 |
mkwiek | hmm, that's a good point | 15:02 |
mkwiek | thanks! | 15:03 |
pigmej | :) | 15:03 |
pigmej | mkwiek: when you're fixing worst case scenario, you shouln't introduce new things in good cases (there are some exceptions though :D) | 15:07 |
pigmej | bogdando: it sems that i need to configure my fedora first .. | 15:07 |
mkwiek | pigmej: yeah, I guess I just wanted to fiddle with locking :D | 15:08 |
bogdando | pigmej, there is docs update in the patch | 15:08 |
bogdando | but it doesn't cover docker install | 15:09 |
pigmej | bogdando: well on fedora only root can use docker; p | 15:11 |
bogdando | addgroup trick doesn't work? | 15:11 |
bogdando | by default only root can use it at ubuntu as well | 15:12 |
pigmej | bogdando: adding user to docker is not recommended | 15:13 |
pigmej | but it should work | 15:13 |
bogdando | sure, but it works. This is only for qa/dev/ci jobs | 15:13 |
bogdando | the docker provider I mean | 15:13 |
pigmej | nope it doesn't solve it | 15:20 |
pigmej | ehs stupid selinux | 15:21 |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Raise an error for empty plan https://review.openstack.org/283632 | 15:27 |
pigmej | bogdando: is it expected that it provisions *very* slow? | 15:37 |
bogdando | no, vagrant ups it for like 20 sec at my box | 15:37 |
pigmej | yeah but just building images etc | 15:38 |
pigmej | probably ubuntu docker container installs more stuff than iso :) | 15:39 |
pigmej | https://bpaste.net/show/5cace2952081 | 15:42 |
pigmej | bogdando: | 15:42 |
pigmej | https://bpaste.net/show/4a8db3a8ddb4 | 15:42 |
pigmej | crashes for me | 15:42 |
pigmej | wtf is that error... | 15:43 |
pigmej | mkwiek: I think jenkins will give you -1 :P | 15:45 |
*** dshulyak has quit IRC | 15:47 | |
pigmej | bogdando: I think it requires me to thave the same docker in my system that is in centos.... | 15:51 |
pigmej | bogdando: I commented :) | 15:54 |
*** dshulyak has joined #openstack-solar | 16:10 | |
mkwiek | pigmej: I am OK with that, wanted to commit sth before I step out of office in case my computer magically erases all the data :D | 16:19 |
pigmej | mkwiek: good choice :p | 16:19 |
*** dshulyak has quit IRC | 19:17 | |
*** angdraug has joined #openstack-solar | 19:18 | |
*** dshulyak has joined #openstack-solar | 20:02 | |
*** angdraug has quit IRC | 22:05 | |
*** dshulyak has quit IRC | 22:24 | |
*** salmon_ has quit IRC | 22:58 | |
*** mihgen has quit IRC | 22:58 | |
*** kun_huang has quit IRC | 22:58 | |
*** nihilifer has quit IRC | 22:58 | |
*** pigmej has quit IRC | 22:58 | |
*** sylwesterB has quit IRC | 22:58 | |
*** evgenyl has quit IRC | 22:58 | |
*** mkwiek has quit IRC | 22:58 | |
*** azvyagintsev_h__ has quit IRC | 22:58 | |
*** azvyagintsev has quit IRC | 22:58 | |
*** ikalnitsky has quit IRC | 22:58 | |
*** bogdando has quit IRC | 22:58 | |
*** ChanServ has quit IRC | 22:58 | |
*** bogdando has joined #openstack-solar | 23:01 | |
*** ikalnitsky has joined #openstack-solar | 23:01 | |
*** kun_huang has joined #openstack-solar | 23:01 | |
*** mihgen has joined #openstack-solar | 23:01 | |
*** salmon_ has joined #openstack-solar | 23:01 | |
*** mkwiek has joined #openstack-solar | 23:01 | |
*** evgenyl has joined #openstack-solar | 23:01 | |
*** sylwesterB has joined #openstack-solar | 23:01 | |
*** nihilifer has joined #openstack-solar | 23:01 | |
*** pigmej has joined #openstack-solar | 23:01 | |
*** azvyagintsev_h__ has joined #openstack-solar | 23:03 | |
*** azvyagintsev has joined #openstack-solar | 23:03 | |
*** pigmej has quit IRC | 23:04 | |
*** pigmej has joined #openstack-solar | 23:04 | |
*** ChanServ has joined #openstack-solar | 23:06 | |
*** asimov.freenode.net sets mode: +o ChanServ | 23:06 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!