Tuesday, 2017-01-17

*** catintheroof has joined #openstack-swift00:11
torgomaticlespaul: you can run those curl commands that swift-get-nodes spits out and that'll tell you what's where, but AFAIK there's nothing to automate that for a single object00:15
torgomaticswift-dispersion-report does that for the entire cluster00:16
*** jerrygb has quit IRC00:18
claygr with swift-dispersion-report or something similar you can always make the call to remove dead-not-coming-back nodes from the ring will reassign the primaries00:22
clayg...00:23
claygweird..00:23
claygi was trying to say that powering off the nodes won't trigger over-replication - the assumption is unavailability - not a loss in durability00:23
claygif you start over-replication on split brain or network congestion or timeout you can fill up your cluster pretty quick00:24
*** sams-gleb has joined #openstack-swift00:24
clayg... and then lastly yeah - if overall partition health dictates - you always have the option to make a ring change to remove the downed nodes and rebalance00:25
*** admin6 has quit IRC00:29
*** sams-gleb has quit IRC00:29
*** jerrygb has joined #openstack-swift00:34
kota_morning00:40
notmynameif i'm reading the ML correctly, it looks like we need to tag a swiftclient release this week00:44
*** PavelK has quit IRC00:46
claygnotmyname: do you?  i missed that?00:47
notmynamefrom http://lists.openstack.org/pipermail/openstack-dev/2017-January/110218.html00:48
mattoliveraunotmyname: richard said this morning he needs to tag or organise a release for horizon this week, so yeah, we probably do.00:48
notmynameLibrary projects should be branched with, or shortly after, their00:49
notmyname  final release this week (use Jan 19 as the deadline)00:49
claygare we releasing Octocat this week?00:49
notmynameno00:50
claygscared me00:50
notmynamebut they always want the library projects to release quite a bit earlier00:50
notmynameoh! I think we have another week https://releases.openstack.org/ocata/schedule.html00:51
notmynamethis is "non-client libraries"00:51
mattoliverau\o/ now get back to watching a talk or something :P00:52
notmynameanyone can watch https://linux.conf.au/stream00:54
*** winggundamth has joined #openstack-swift01:05
*** catintheroof has quit IRC01:09
*** jerrygb has quit IRC01:13
*** winggundamth has quit IRC01:16
kota_clayg: here?01:17
claygkota_: hi kota_ :D01:17
kota_hi clayg01:17
kota_I'm now looking/condidering about the patch https://review.openstack.org/#/c/418690/01:17
patchbotpatch 418690 - swift - Fix race in new partitions detecting new/invalid s...01:17
kota_exactly, we should move to drop for using getmtime for file validation (i mean not modified since the last reference)01:19
kota_clayg: but not sure I could follow your idea completely01:19
kota_clayg: because the shell for-loop looks to report nothing you expected01:20
claygkota_: my thought was just that that change needs to mock getmtime or else it doesn't pass reliably01:20
kota_clayg: the console log is https://gist.github.com/bloodeagle40234/2239939c6cb42b6b23635936a427ef3401:20
claygkota_: oic, on my machine with your diff applied (to drop the getmtime mocking) it fails predicably for me01:20
kota_clayg: it looks like, all tests passed for 10 times, correctly01:20
claygthe test works for me as written01:20
clayg... only fails if I remove the getmtime mocking01:21
kota_clayg: i ran it with my patch01:21
claygperhaps your computer is slower than mine ;)  or your mounted filesystem has better getmtime resolution?01:21
kota_clayg: and then, I just checked also the situation Pavel reported (i.e. getmtime could increment the mtime in LXC), https://gist.github.com/bloodeagle40234/9eaf53aac466003cc8e6c43b0a0f66b201:21
claygkota_: well I think that as long as you force it to be bigger the mock works01:22
kota_it also doesn't fail, because even if we got different mtime there, IIRC, it's ok if no new entry comming to invalidation file?01:22
claygit's only when the filesystem might return the same mtime for a file that was modified will you loose the second update01:22
kota_clayg: ah, my laptop may be slower.... though :/01:23
*** trananhkma has quit IRC01:24
claygkota_: I believe it should be clear that an update can overwrite if the getmtime we take to start matches the getmtime we take before write_pickle - *but* somehow another process finished get_hashes while we were hashing and the *contents* of hashes.pkl are different (despite same mtime)01:24
claygkota_: for me your patch to remove the getmtime mock failed like this -> https://gist.github.com/clayg/81be81ef339c7cc276b34c04be6c218c01:25
kota_clayg: hooo, that looks worse, exactly01:26
kota_ok it makes me sense.01:26
kota_and if the patch 418690 land before patch 419787, patch 419787 will remove the mock (it doesn't look to remove yet) right?01:28
patchbothttps://review.openstack.org/#/c/418690/ - swift - Fix race in new partitions detecting new/invalid s...01:28
patchbothttps://review.openstack.org/#/c/419787/ - swift - Better optimistic lock in get_hashes01:28
patchbothttps://review.openstack.org/#/c/419787/ - swift - Better optimistic lock in get_hashes01:28
claygso OMM (and also apparently PavelK's) it is possible to have modified file return same getmtime value rarely - but rather than address that particular issue this change just mocks out getmtime so it can focus on only on not lossing the invalidate_suffix updates01:28
kota_clayg: because the patch 419787 will replace the getmtime to inode info.01:28
patchbothttps://review.openstack.org/#/c/419787/ - swift - Better optimistic lock in get_hashes01:28
claygkota_: the patches are not currently "in series"01:29
kota_clayg: ok, gotcha01:29
kota_clayg: will turn out my score with final run-through01:30
kota_clayg: thanks01:30
claygif patch 418690 lands first - i'll probably have to rebase 419787 - it would probably be good to audit for no-longer-needed mocking of getmtime in test_diskfile - not sure if I did that01:30
patchbothttps://review.openstack.org/#/c/418690/ - swift - Fix race in new partitions detecting new/invalid s...01:30
claygmaybe inside the mock - where it makes the call to create delete of the second suffix - if you check it's get_hashes result it probably finds/hashes both suffixes - so the problem is really only the earlier one that started stomping on the other processes' changes01:33
claygyeah the inode thing is going to be a lot better for that01:33
*** mingyu has joined #openstack-swift01:50
clayggah!  I call set_replicas to double up for my ec duplication factor and then rebalance and get "The time between rebalances must be at least min_part_hours" but that's non-sense - you have pleanty of part-frags that you can reassign swift-ring-builder - we need patch 32696701:53
patchbothttps://review.openstack.org/#/c/326967/ - swift - Rebalance with min_part_seconds_left > 001:53
claygtimburke: first try!!!!!! swift info --json | jq .swift.policies[].name01:56
claygoh look out!01:58
clayghttps://gist.github.com/clayg/fefdf585aa1f570bf0fc57407f4cd4f101:58
claygoh hrm... nothing really makes the duplicated frags avoid each others failure domains02:02
*** jerrygb has joined #openstack-swift02:14
kota_clayg: oh sorry, I was apart a bit for being asked from my collegue, will take a look  https://review.openstack.org/#/c/326967/ too.02:16
patchbotpatch 326967 - swift - Rebalance with min_part_seconds_left > 002:16
claygkota_: i was just griping in general02:17
claygkota_: you don't have to reoganize your review backlog on my account - i'm over it02:17
claygrebalance -f does the trick02:17
kota_sure, that is a trick to force to rebalance02:18
*** klrmn has quit IRC02:21
*** jamielennox is now known as jamielennox|away02:25
*** sams-gleb has joined #openstack-swift02:27
*** sams-gleb has quit IRC02:31
*** tqtran has quit IRC02:33
*** mingyu has quit IRC02:40
*** mingyu has joined #openstack-swift02:45
*** mingyu_ has joined #openstack-swift02:47
*** mingyu has quit IRC02:47
claygkota_: I left some notes on the ec duplicate frag patch - don't feel an particular need to address anything specificially if it strikes you as not quite correct - my review is a wip02:55
claygdinnertime!02:55
kota_clayg: much appreciated! enjoy your time!02:55
*** JimCheung has quit IRC03:01
*** mingyu_ has quit IRC03:02
*** jamielennox|away is now known as jamielennox03:03
*** bkopilov has quit IRC03:05
*** bkopilov_ has quit IRC03:06
*** klrmn has joined #openstack-swift03:17
*** mingyu has joined #openstack-swift03:19
*** links has joined #openstack-swift03:32
*** klrmn has quit IRC03:42
*** mingyu has quit IRC03:48
*** mingyu has joined #openstack-swift03:54
*** takashi has joined #openstack-swift03:59
*** psachin has joined #openstack-swift04:09
*** sheel has joined #openstack-swift04:13
timburkeclayg: w00t!04:18
*** jlwhite has quit IRC04:21
*** dmorita has quit IRC04:25
*** bkopilov has joined #openstack-swift04:27
*** mingyu has quit IRC04:27
*** mingyu has joined #openstack-swift04:27
*** mingyu has quit IRC04:27
*** sams-gleb has joined #openstack-swift04:29
*** sams-gleb has quit IRC04:34
*** bkopilov_ has joined #openstack-swift04:34
mahaticclayg: thanks for taking care of this patch 390901!04:35
patchbothttps://review.openstack.org/#/c/390901/ - swift - Confirm receipt of SLO PUT with etag (MERGED)04:35
*** dmorita has joined #openstack-swift04:49
*** dmorita has quit IRC04:53
*** SkyRocknRoll has joined #openstack-swift04:54
*** ppai has joined #openstack-swift05:07
*** jerrygb has quit IRC05:08
*** jlwhite has joined #openstack-swift05:20
*** dfflanders has quit IRC05:26
*** Jeffrey4l_ has joined #openstack-swift06:30
*** sams-gleb has joined #openstack-swift06:31
*** tqtran has joined #openstack-swift06:33
*** Jeffrey4l has quit IRC06:34
*** Jeffrey4l_ is now known as Jeffrey4l06:34
*** tqtran has quit IRC06:35
*** sams-gleb has quit IRC06:36
*** ppai has quit IRC06:45
*** ppai has joined #openstack-swift07:03
*** tesseract has joined #openstack-swift07:16
*** ChubYann has quit IRC07:32
*** ppai has quit IRC07:49
*** dmellado has quit IRC08:02
*** ppai has joined #openstack-swift08:02
*** dmellado has joined #openstack-swift08:04
*** hseipp has joined #openstack-swift08:04
*** rledisez has joined #openstack-swift08:10
openstackgerritMathias Bjoerkqvist proposed openstack/swift: Retrieve encryption root secret from Barbican  https://review.openstack.org/36487808:18
*** geaaru has joined #openstack-swift08:23
*** sams-gleb has joined #openstack-swift08:33
*** sams-gleb has quit IRC08:38
*** ppai has quit IRC08:44
*** ppai has joined #openstack-swift09:01
*** sams-gleb has joined #openstack-swift09:14
*** mvk has quit IRC09:30
*** Shashikant86 has joined #openstack-swift09:32
*** cbartz has joined #openstack-swift09:36
*** Shashikant86 has quit IRC09:37
*** acoles_ is now known as acoles09:38
*** jordanP has joined #openstack-swift09:38
*** Shashikant86 has joined #openstack-swift09:45
acolesclayg: lol @ " maybe folks are scared to review the other suffix fixes because they think I get frustrated things are moving to slowly and go +A you patch anyway (I totaly might!)" so yeah, which way do i bet? :)09:46
acolesPavelK (ah, he's not here) fwiw I am going to review clayg's set of patches09:48
*** hseipp has quit IRC09:50
*** hseipp has joined #openstack-swift09:54
*** jordanP has quit IRC10:04
*** mvk has joined #openstack-swift10:06
*** Shashikant86 has quit IRC10:19
openstackgerritKota Tsuyuzaki proposed openstack/swift: EC Fragment Duplication - Foundational Global EC Cluster Support  https://review.openstack.org/21916510:27
*** kei_yama has quit IRC10:29
openstackgerritChristian Schwede proposed openstack/swift: Add support to increase object ring partition power  https://review.openstack.org/33729710:29
*** mvk has quit IRC10:32
*** mvk has joined #openstack-swift10:47
*** sams-gleb has quit IRC10:50
*** sams-gleb has joined #openstack-swift10:50
*** mingyu has joined #openstack-swift10:53
mathiasbwhat's the easiest way of figuring out where a 401 error originates from?10:54
mathiasbnothing obvious in /var/log/swift/; swift stat <cont> <obj> succeeds; swift stat <cont> fails10:55
*** sams-gleb has quit IRC10:55
*** Shashikant86 has joined #openstack-swift11:02
openstackgerritChristian Schwede proposed openstack/swift: Add support to increase object ring partition power  https://review.openstack.org/33729711:08
*** sams-gleb has joined #openstack-swift11:09
*** takashi has quit IRC11:10
*** mingyu has quit IRC11:15
*** oshritf_ has joined #openstack-swift11:17
*** hseipp has quit IRC11:19
*** hseipp has joined #openstack-swift11:20
*** jordanP has joined #openstack-swift11:25
*** dmorita has joined #openstack-swift11:26
*** mvk has quit IRC11:28
*** dmorita has quit IRC11:31
*** sams-gle_ has joined #openstack-swift11:36
*** sams-gleb has quit IRC11:36
openstackgerritChristian Schwede proposed openstack/swift: Rebalance with min_part_seconds_left > 0  https://review.openstack.org/32696711:37
*** ganders has joined #openstack-swift11:40
*** mvk has joined #openstack-swift11:41
*** ppai has quit IRC11:41
*** ppai has joined #openstack-swift11:42
*** cdelatte has joined #openstack-swift11:59
*** links has quit IRC12:12
*** Shashikant86 has quit IRC12:13
*** bkopilov_ has quit IRC12:22
*** bkopilov has quit IRC12:23
*** tesseract has quit IRC12:23
*** catintheroof has joined #openstack-swift12:32
*** ppai has quit IRC12:44
*** klamath has joined #openstack-swift12:44
*** klamath has quit IRC12:45
*** klamath has joined #openstack-swift12:45
acolesmathiasb: not sure but could be if you have a .r:* ACL on the container. I *think* that 401 (vs 403) implies not token/identity supplied with the request12:49
* acoles afk12:49
*** SkyRocknRoll has quit IRC12:53
*** ppai has joined #openstack-swift12:57
*** links has joined #openstack-swift12:58
*** Shashikant86 has joined #openstack-swift12:58
*** links has quit IRC13:01
*** vint_bra has joined #openstack-swift13:13
*** Shashikant86 has quit IRC13:29
mathiasbacoles: thanks, I tried changing the ACL but no luck with the GET/stat so far13:45
*** mingyu has joined #openstack-swift13:45
*** ppai has quit IRC13:50
*** Shashikant86 has joined #openstack-swift14:00
*** Shashikant86 has quit IRC14:00
acolesmathiasb: if this is keystone auth then if you set the proxy log level to debug you may see some logging that indicates the basis on which the object GET is granted. Also look for any message in of the 401 response.14:09
acoless/in of/in body of/14:10
*** SkyRocknRoll has joined #openstack-swift14:14
*** jerrygb has joined #openstack-swift14:14
*** Shashikant86 has joined #openstack-swift14:15
*** sams-gle_ has quit IRC14:19
*** bkopilov_ has joined #openstack-swift14:32
*** bkopilov has joined #openstack-swift14:33
*** mingyu has quit IRC14:34
*** sams-gleb has joined #openstack-swift14:36
*** tqtran has joined #openstack-swift14:36
*** psachin has quit IRC14:37
*** tqtran has quit IRC14:38
*** SkyRocknRoll has quit IRC14:43
*** mingyu has joined #openstack-swift14:49
*** manij has quit IRC15:00
*** manij has joined #openstack-swift15:01
*** manij has quit IRC15:05
*** mingyu has quit IRC15:08
*** mingyu has joined #openstack-swift15:09
*** pcaruana has quit IRC15:15
*** david-lyle has joined #openstack-swift15:42
*** mvk has quit IRC15:51
openstackgerritClay Gerrard proposed openstack/swift: Pretend *some* parts min_part_hours_passed  https://review.openstack.org/31122615:51
*** tanee has quit IRC15:53
*** bikmak has joined #openstack-swift15:53
*** david-lyle has quit IRC15:55
*** _JZ_ has joined #openstack-swift15:58
*** mingyu has quit IRC16:03
*** Shashikant86 has quit IRC16:06
*** sheel has quit IRC16:07
*** david-lyle has joined #openstack-swift16:07
*** Shashikant86 has joined #openstack-swift16:10
*** chsc has joined #openstack-swift16:35
*** Shashikant86 has quit IRC16:43
*** Shashikant86 has joined #openstack-swift16:46
*** tanee has joined #openstack-swift16:46
*** oshritf_ has quit IRC16:54
*** silor has joined #openstack-swift17:00
*** Shashikant86 has quit IRC17:03
*** ganders has quit IRC17:04
openstackgerritAlistair Coles proposed openstack/swift: Add more tests for diskfile consolidate_hashes  https://review.openstack.org/42138517:08
acolesclayg: fyi I am on patch 418691 but got distracted by untested conditions17:09
patchbothttps://review.openstack.org/#/c/418691/ - swift - Fix performance regression with hash invalidations17:09
*** mvk has joined #openstack-swift17:17
*** geaaru has quit IRC17:24
*** hseipp has quit IRC17:28
*** ganders has joined #openstack-swift17:30
*** vinsh has joined #openstack-swift17:30
timburkegood morning17:43
*** dmorita has joined #openstack-swift17:44
*** rledisez has quit IRC17:52
*** rledisez has joined #openstack-swift17:56
*** rledisez has quit IRC17:57
*** rledisez has joined #openstack-swift17:59
*** rledisez has quit IRC18:00
cbartztimburke: Good morning. Is it possible that you could take a look over patch 414232 ?18:11
patchbothttps://review.openstack.org/#/c/414232/ - swift - Exclude containers for account quota18:11
*** ganders has quit IRC18:30
*** ganders has joined #openstack-swift18:34
*** tqtran has joined #openstack-swift18:38
*** klrmn has joined #openstack-swift18:39
*** tqtran has quit IRC18:40
*** david-lyle has quit IRC18:47
*** JimCheung has joined #openstack-swift18:48
*** tqtran has joined #openstack-swift19:04
*** acoles is now known as acoles_19:07
*** klrmn has quit IRC19:24
*** klrmn has joined #openstack-swift19:28
*** klrmn has quit IRC19:28
*** PavelK has joined #openstack-swift19:31
*** klrmn has joined #openstack-swift19:34
*** ChubYann has joined #openstack-swift19:37
*** lespaul has quit IRC19:40
*** tqtran has quit IRC19:41
*** NM has joined #openstack-swift19:47
*** ganders has quit IRC19:48
*** jordanP has quit IRC19:49
*** Fin1te has joined #openstack-swift19:49
*** david-lyle has joined #openstack-swift19:50
*** Fin1te has left #openstack-swift19:50
caiobrentano_Hi folks... does anyone knows about SLO objects?19:51
timburkei love SLOs!19:52
caiobrentano_Checking my logs, I'm seeing repeated PUT requests (from the SLO middleware), for the same segments19:52
caiobrentano_timburke: lol19:52
caiobrentano_is this the expected behaviour?19:53
timburkeit's lying, it's doing HEADs against the segments (to verify they exist, have the correct size/etag if provided, ...) during the PUT for the manifest19:53
caiobrentano_so, the method is wrong in the log?19:54
timburkeat least, as i recall. we should really fix that. you should be able to confirm that's what's going on by looking at the object-server logs for the same transaction19:54
timburkeyup19:54
timburkei mean, kind of. the client method *is* a PUT, but that's not what's going on with the backend19:54
caiobrentano_my log record: http://pastebin.com/1UDisbKC19:56
*** silor has quit IRC19:57
caiobrentano_timburke I don't think I understood what you said about "the client method *is* a PUT, but that's not what's going on with the backend"19:58
*** tqtran has joined #openstack-swift20:03
timburkewhen the client wants to complete the SLO, they send a PUT request with a JSON body listing all of the segments that should be used. during that PUT, the SLO middleware issues a bunch of HEAD requests to the segments before finally sending the PUT for the manifest. so all these things happen as a result of the external client sending a PUT, but that isn't terribly informative or useful so it'd be better if we logged it as a HEAD (whic20:04
timburkeh it was)20:04
*** tqtran has quit IRC20:05
timburkecaiobrentano_: from your logs, that first line (tx34dfb28714b1406086c0f) looks like the actual upload of the segment. the subsequent lines were likely the result of manifest PUTs and should have been recorded as HEADs. you can confirm that by grepping for (for example) tx8cd5c665d17b4e689ceaf in your object-server logs and checking the request method there20:07
caiobrentano_timburke got it! thanks for the class about SLO! :)20:07
caiobrentano_timburke: I did this grep on the object-server I found the HEAD request20:08
NMtimburke: Caio has left the building but thanks again. By any reason could SLO delete a segment?20:18
timburkeNM: if the client sends a DELETE to the manifest with ?multipart-manifest=delete, then the SLO middleware will delete all of the segments as well20:19
NM We couldn't find any DELETE request. But we found a .ts file where the segment should be.20:39
timburkeso *someone* deleted them. may have been the middleware, or it may have been the client (i know swiftclient will delete segments by default when overwriting or deleting large objects. you can include a --leave-segments flag to skip that)20:42
claygNM object-expirer?20:44
claygssync has this weird bug where it sync's expired object .data files as tombstones -> https://bugs.launchpad.net/swift/+bug/165232320:45
openstackLaunchpad bug 1652323 in OpenStack Object Storage (swift) "ssync syncs an expired object as a tombstone, probe test_object_expirer fails" [Medium,Confirmed]20:45
NMtimburke: Well, I couldn't find any delete request on the proxy. clayg: That is my first suspect but according to the logs, our client doesn't use expires. One thing that I'll check is if I can find any DELETE on the object services since I couldn't find on the proxies.20:52
NMtimburke: clayg: thanks for the help. I need to get my kid. If I find anything interesting I'll share tomorrow.20:53
*** NM has quit IRC20:53
*** eckesicle__ has joined #openstack-swift20:55
openstackgerritClay Gerrard proposed openstack/swift: Pretend *some* parts min_part_hours_passed  https://review.openstack.org/31122620:55
*** sams-gle_ has joined #openstack-swift20:58
*** sams-gleb has quit IRC20:58
*** eckesicle__ is now known as eckesicle20:59
*** JimCheung has quit IRC21:00
*** JimCheung has joined #openstack-swift21:00
*** PavelK has quit IRC21:03
*** dfflanders has joined #openstack-swift21:03
*** JimCheung has quit IRC21:04
*** dmorita has quit IRC21:05
*** dmorita has joined #openstack-swift21:06
*** dmorita has quit IRC21:06
*** dmorita has joined #openstack-swift21:07
*** cdelatte has quit IRC21:17
*** clu_ has joined #openstack-swift21:22
*** JimCheung has joined #openstack-swift21:31
*** sams-gle_ has quit IRC21:34
*** Jeffrey4l has quit IRC21:35
*** dmorita has quit IRC21:37
*** dmorita has joined #openstack-swift21:37
*** dmorita_ has joined #openstack-swift21:38
*** dmorita has quit IRC21:38
*** Jeffrey4l has joined #openstack-swift21:48
mattoliveraumorning21:56
*** d0ugal has quit IRC21:59
timburkegood morning mattoliverau!21:59
timburkei guess notmyname ought to show up soon :-)21:59
*** d0ugal has joined #openstack-swift21:59
*** d0ugal has quit IRC21:59
*** d0ugal has joined #openstack-swift21:59
*** tqtran has joined #openstack-swift22:06
*** tqtran has quit IRC22:08
*** catintheroof has quit IRC22:20
*** vint_bra has quit IRC22:33
*** sams-gleb has joined #openstack-swift22:35
*** sams-gleb has quit IRC22:39
*** david-lyle has quit IRC22:51
*** andymccr has quit IRC23:20
*** asettle has quit IRC23:20
*** klamath has quit IRC23:27
*** kei_yama has joined #openstack-swift23:33
*** chsc has quit IRC23:36
*** lespaul has joined #openstack-swift23:42

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!