| opendevreview | Matthew Oliver proposed openstack/swift master: account info: Add --sync/-s option https://review.opendev.org/c/openstack/swift/+/924820 | 06:21 |
|---|---|---|
| opendevreview | Alistair Coles proposed openstack/swift master: Delete s3api MPU segments when expiring the manifest https://review.opendev.org/c/openstack/swift/+/800701 | 10:24 |
| opendevreview | Alistair Coles proposed openstack/swift master: DNM expirer: new options to control task iteration https://review.opendev.org/c/openstack/swift/+/914713 | 10:24 |
| opendevreview | Alistair Coles proposed openstack/swift master: Configurable expiring_objects_task_container_per_day https://review.opendev.org/c/openstack/swift/+/920452 | 10:24 |
| opendevreview | Alistair Coles proposed openstack/swift master: refactor: remove iter_task_accounts_to_expire https://review.opendev.org/c/openstack/swift/+/919639 | 15:20 |
| opendevreview | Alistair Coles proposed openstack/swift master: Parallel distirbuted task container iteration https://review.opendev.org/c/openstack/swift/+/918366 | 15:20 |
| opendevreview | Alistair Coles proposed openstack/swift master: Parallel distirbuted task container iteration https://review.opendev.org/c/openstack/swift/+/918366 | 15:31 |
| opendevreview | Alistair Coles proposed openstack/swift master: Parallel distributed task container iteration https://review.opendev.org/c/openstack/swift/+/918366 | 15:32 |
| acoles | timburke: need to skip meeting (again, sorry) - got family visiting | 16:40 |
| opendevreview | Tim Burke proposed openstack/swift master: Implement context manager protocol for logging mutexes https://review.opendev.org/c/openstack/swift/+/924768 | 16:44 |
| opendevreview | Tim Burke proposed openstack/swift master: Pass timeout as kwarg https://review.opendev.org/c/openstack/swift/+/924771 | 16:45 |
| timburke | acoles, no worries -- thanks for the reviews on those first few py313 patches! | 16:57 |
| kota | good morning | 20:54 |
| fuleco | Hello | 20:54 |
| timburke | o/ | 20:59 |
| timburke | #startmeeting swift | 21:00 |
| opendevmeet | Meeting started Wed Jul 24 21:00:02 2024 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:00 |
| opendevmeet | The meeting name has been set to 'swift' | 21:00 |
| timburke | who's here for the swift meeting? | 21:00 |
| kota | o/ | 21:00 |
| fuleco | o/ | 21:00 |
| mattoliver | o/ | 21:00 |
| timburke | as usual, the agenda's at | 21:01 |
| timburke | #link https://wiki.openstack.org/wiki/Meetings/Swift | 21:01 |
| timburke | and i even remembered to update it this week ;-) | 21:01 |
| timburke | first up | 21:01 |
| timburke | #topic pkg_resources warnings | 21:02 |
| timburke | there's been a good bit of progress! p 922151 p 922870 and p 922871 all merged | 21:02 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/922151 - swift - Use entry_points for a bunch more executables (MERGED) - 5 patch sets | 21:02 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/922870 - swift - Use entry_points for swift-init (MERGED) - 2 patch sets | 21:02 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/922871 - swift - Pull swift-dispersion-populate to its own module (MERGED) - 2 patch sets | 21:02 |
| timburke | thanks for the reviews mattoliver, zaitcev, clayg! | 21:03 |
| timburke | next in the chain is | 21:03 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/922872 | 21:03 |
| patch-bot | patch 922872 - swift - Pull swift-*-info scripts into swift.cli.info - 3 patch sets | 21:03 |
| timburke | and then to complete the entry_point transition | 21:03 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/924776 | 21:03 |
| patch-bot | patch 924776 - swift - Move remaining bin scripts to cli modules - 3 patch sets | 21:03 |
| mattoliver | I worked my way up the chain yesterday. | 21:04 |
| timburke | on top of that i've now got p 924795 to remove all of bin/ -- but i'm a little torn | 21:04 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/924795 - swift - Remove legacy bin/ scripts - 2 patch sets | 21:04 |
| mattoliver | What was the plan with the last one, yeah that one? | 21:04 |
| mattoliver | do we rip the bandaid or support them for a few releases? | 21:05 |
| timburke | yeah, so -- i'm of two minds. on the one hand, we've had at least one case of people relying on them existing (though they switched to using the actual installed script) | 21:06 |
| timburke | on the other, i don't really *want* to have them any longer than necessary. if the contract is "pip install swift leaves me with executables on my PATH", all those patches preserve it | 21:07 |
| timburke | and using bin scripts directly from a swift checkout seems very much a developer workflow, not something we'd expect operators to be doing | 21:08 |
| mattoliver | hmm | 21:08 |
| timburke | what're everyone else's thoughts about it? | 21:09 |
| mattoliver | well devs can now just point to the cli scripts themselves and call the main | 21:10 |
| mattoliver | which is probably nicer anyway | 21:10 |
| mattoliver | BUT if there is 1 person out there we know about there could be more. So feel torn. | 21:10 |
| fuleco | I taking a look at the patch... | 21:11 |
| timburke | fwiw, the one and only case i'm aware of was from years ago: p 416787 | 21:11 |
| patch-bot | https://review.opendev.org/c/openstack/devstack/+/416787 - devstack - Use the installed swift scripts (MERGED) - 1 patch set | 21:11 |
| mattoliver | Do we add a decprecated to them in the next release notes and remove them the one after? BUT on the other hand I agree, we're still providing all the scripts just via pip. | 21:11 |
| mattoliver | It is git. we could rip them out and if anyone complains revert :P But I guess that's hard because it'll have to wait a release | 21:12 |
| fuleco | It seems like the code is simply moved around right? I personally think that there is no reason to keep it as individual scripts specifically. Provided the migration to new versions can be solved at most with a search/replace operation I personally think we should proceed with this | 21:13 |
| timburke | yeah, that's the other route i was considering. call out the deprecation in release notes, add warnings in the bin/ scripts, wait a release or two, *then* remove | 21:13 |
| fuleco | As mattoliver said, maybe release a deprecation notice before though | 21:13 |
| kota | +1 | 21:14 |
| mattoliver | The generated scripts are basically identical to the existing ones | 21:14 |
| mattoliver | Anyone packaging swift will have setuptools / pip install and generate the scripts. And we don't point to the old ones in setup.cfg anymore.. | 21:15 |
| mattoliver | so only only people who will notice any difference are people checking out the code and then trying to run (which is that really supported)? | 21:16 |
| mattoliver | So the "we're already supporting/providing the same bin scripts" is a strong one too. | 21:16 |
| mattoliver | fuleco and kota seem to +1 the deprecation route, so let's go with that :) | 21:17 |
| timburke | all right, i can add that. thanks for thinking about it with me everyone! | 21:18 |
| timburke | next up | 21:18 |
| timburke | #topic iso timestamps and swift-drive-audit | 21:18 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/924352 | 21:18 |
| patch-bot | patch 924352 - swift - swift-drive-audit: Work with ISO timestamps (MERGED) - 1 patch set | 21:18 |
| timburke | quick update: it merged! and i made sure that the change was reflected when it moved around in p 924776 | 21:19 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/924776 - swift - Move remaining bin scripts to cli modules - 3 patch sets | 21:19 |
| timburke | thanks mattoliver, jianjian, and DHE for taking a look | 21:20 |
| timburke | next up | 21:20 |
| timburke | #topic py313 | 21:20 |
| mattoliver | nps | 21:20 |
| timburke | i said a while ago that i'd try out swift under py313, and i finally did! | 21:20 |
| timburke | the long and short of it is that we're mostly still blocked waiting on deps to support it | 21:21 |
| mattoliver | kk, I guess that's expected | 21:21 |
| timburke | cffi is currently busted, preventing xattrs from building -- but they've got a merged-but-not-yet-released fix | 21:21 |
| timburke | #link https://github.com/python-cffi/cffi/issues/95 | 21:21 |
| timburke | greenlet is also busted, but vstinner is working on it | 21:22 |
| timburke | #link https://github.com/python-greenlet/greenlet/pull/396 | 21:22 |
| timburke | eventlet's busted, too | 21:22 |
| timburke | #link https://github.com/eventlet/eventlet/issues/964 | 21:22 |
| mattoliver | So all the things are broken :P | 21:23 |
| timburke | there's a PR to get over the immediate error, and by taking all three i could at least get some unit tests running! | 21:23 |
| mattoliver | nice one | 21:23 |
| timburke | not the full suite though; that bombs out during collection because webob (required by keystonemiddleware, required for some s3api tests) still uses the now-removed cgi module | 21:24 |
| timburke | #link https://github.com/Pylons/webob/issues/437 | 21:24 |
| timburke | but -- with at least *some* tests running, it did turn out a couple new issues | 21:25 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/924768 | 21:25 |
| patch-bot | patch 924768 - swift - Implement context manager protocol for logging mut... - 2 patch sets | 21:25 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/924771 | 21:25 |
| patch-bot | patch 924771 - swift - Pass timeout as kwarg - 2 patch sets | 21:25 |
| timburke | the second one just resolves a deprecation warning, but it seems best to nip it in the bud | 21:26 |
| mattoliver | oh cool | 21:27 |
| timburke | the only other known-issue is our own use of the cgi module -- and jianjian and i had some good back-and-forth on p 887908 recently | 21:27 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/887908 - swift - Stop using cgi.parse_header - 4 patch sets | 21:27 |
| mattoliver | great stuff timburke | 21:28 |
| timburke | the only other thing i've found so far is a hang in test/unit/common/test_utils.py::TestUtils::test_monkey_patch -- presumably because eventlet isn't fully happy yet | 21:30 |
| timburke | that's as far as i've gotten so far -- haven't tried to functionally validate yet, though that hang makes me pessimistic | 21:31 |
| timburke | the remaining items, i don't know that there's a whole lot to report | 21:32 |
| mattoliver | either way, its a great steps forward | 21:32 |
| mattoliver | and you found some needed improvements, so that's a win | 21:33 |
| mattoliver | thanks for digging in! | 21:33 |
| timburke | 👍 | 21:33 |
| timburke | we could check in real quick in case i'm wrong, though | 21:33 |
| timburke | #topic account-reaper and sharded containers | 21:33 |
| timburke | mattoliver, i'm guessing you haven't had a chance to do much with p 924034? i know *i* haven't | 21:34 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/924034 - swift - WIP: reaper: Support reaping sharded containers - 1 patch set | 21:34 |
| mattoliver | Oh yeah, I've been playing with is. My first attempt is that one, and it talks direct client | 21:34 |
| mattoliver | but there is a bunch of recursion using direct client which is a little messy. | 21:35 |
| mattoliver | So makes me think it might just be better to use internal client that can already speak sharding | 21:35 |
| mattoliver | But that involves adding an interenalclient to the reaper (which I guess I'm not against). | 21:35 |
| mattoliver | So the plan is to do a second internal client version and see how that shakes out, and it might look cleaner. | 21:36 |
| timburke | i think the main issue there would be the early 410, but presumably we could get around with some x-backend- header flag | 21:36 |
| mattoliver | yeah | 21:36 |
| mattoliver | and if I did squash an internal client in there, then maybe it makes sense to use it everywhere in the reaper and remove direct client (or maybe having both is ok). | 21:37 |
| timburke | adding another internal_client user seems perfectly reasonable, though; that seems more and more like a thing that we just expect to have available | 21:37 |
| timburke | would probably be good for swift-account-audit to use it, too -- could resolve a few bugs | 21:38 |
| mattoliver | yeah, esp because sharding it mostly implemented in the proxy, so internal client gives us that. | 21:38 |
| mattoliver | +100 | 21:38 |
| mattoliver | I noticed that that otherday too | 21:38 |
| mattoliver | So my plan is to attempt an internal client version. Maybe we can make a decision on direction then | 21:39 |
| timburke | 👍 | 21:39 |
| mattoliver | I'll try and get something at least basic up by next meeting | 21:39 |
| timburke | #topic multi-policy containers | 21:39 |
| timburke | fuleco, i'm guessing you're still good for now? | 21:40 |
| fuleco | Yep, all good. | 21:40 |
| fuleco | We're working a bit on our clients for now, so little news on my side | 21:40 |
| timburke | 👍 | 21:41 |
| timburke | #topic operator node exclusion | 21:41 |
| timburke | and i still haven't responded to the latest on the ML | 21:41 |
| timburke | i should try to do that this week | 21:42 |
| timburke | in part because | 21:42 |
| timburke | #topic no meeting next week | 21:42 |
| timburke | i'm going to be out on vacation next week | 21:42 |
| mattoliver | oh yeah.. I was going to read that, opened it in a tab and never did... sorry too | 21:42 |
| mattoliver | oh kk | 21:42 |
| mattoliver | that gives me 2 weeks to get the internal client reaper written :P | 21:42 |
| timburke | i suppose that doesn't preclude there being a meeting, but i won't be around to chair it :-) | 21:43 |
| mattoliver | Well let's plan to skip it for now. If anything major does come up, I'm happy to chair. | 21:43 |
| timburke | sounds good, thanks mattoliver | 21:43 |
| timburke | that's all i've got | 21:43 |
| timburke | #topic open discussion | 21:43 |
| timburke | anything else we'd like to bring up? | 21:43 |
| mattoliver | Gives kota and I a good chance to sleep in :) | 21:44 |
| mattoliver | The qatar summer students are finishing up this week. But a few have said their interesting in continuing to work to 1 get things finished and to tackle some more of the projects we set. | 21:45 |
| mattoliver | * and 2 tackle some more.. | 21:45 |
| mattoliver | So I think it went well, esp if they want to keep hacking on Swift :) | 21:46 |
| mattoliver | Although it does mean I have to write some kind of report for their uni or something this week. | 21:46 |
| timburke | oh, right! i should take a look at the still-open patches today | 21:47 |
| mattoliver | yeah, there's | 21:47 |
| mattoliver | #link https://review.opendev.org/c/openstack/swift/+/922833 | 21:47 |
| patch-bot | patch 922833 - swift - Periodic reaper recon dump showing current progress - 7 patch sets | 21:47 |
| mattoliver | #link https://review.opendev.org/c/openstack/swift/+/924549 | 21:48 |
| patch-bot | patch 924549 - swift - WIP: account_quota: migrating quota_bytes and quot... - 2 patch sets | 21:48 |
| mattoliver | ^ that's the follow up to move things to the x-account-quota-namespace | 21:48 |
| timburke | #link https://review.opendev.org/c/openstack/swift/+/924431 | 21:48 |
| patch-bot | patch 924431 - swift - container storage-policy modification operator tool - 1 patch set | 21:48 |
| mattoliver | #link https://review.opendev.org/c/openstack/swift/+/924431 | 21:48 |
| patch-bot | patch 924431 - swift - container storage-policy modification operator tool - 1 patch set | 21:48 |
| mattoliver | Oh you beat me :P | 21:49 |
| timburke | thanks mattoliver, and thanks for mentoring them this summer! | 21:49 |
| mattoliver | Yeah and that one | 21:49 |
| mattoliver | nps, my timezone seemed to match better so it made sense. And they were good peeps. | 21:49 |
| mattoliver | that all I got | 21:50 |
| timburke | all right, i think i'll call it then | 21:50 |
| timburke | thank you all for coming, and thank you for working on swift! | 21:50 |
| timburke | #endmeeting | 21:51 |
| opendevmeet | Meeting ended Wed Jul 24 21:51:03 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:51 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2024/swift.2024-07-24-21.00.html | 21:51 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2024/swift.2024-07-24-21.00.txt | 21:51 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2024/swift.2024-07-24-21.00.log.html | 21:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!