| vipul | I don't know if / how we express that in the temaplate | 00:00 |
|---|---|---|
| *** tanisdl has quit IRC | 00:00 | |
| hub_cap | good call... wheres SpamapS when u need him | 00:01 |
| *** krow has quit IRC | 00:10 | |
| hub_cap | vipul: no noticable difference between the old and new configs | 00:13 |
| hub_cap | im going to merge this later today when the robots +1 it, so +2 it if you like me | 00:13 |
| hub_cap | https://review.openstack.org/#/c/49089 | 00:14 |
| vipul | just one comment, can you change the .sample to reflect the defaults? | 00:14 |
| vipul | so at least they are used in tests, etc | 00:14 |
| hub_cap | im fine w/ smaller sample confs | 00:14 |
| hub_cap | cuz a test env may be different ( and for failures u might want lower timeouts) | 00:14 |
| hub_cap | theres possiubly a "test this timeout" reason for why its that way in the sample confs | 00:15 |
| * hub_cap isint sure | 00:15 | |
| vipul | fair enough.. | 00:15 |
| vipul | i'm good with it otherwise | 00:15 |
| *** yogeshmehra has quit IRC | 00:16 | |
| *** yogeshmehra has joined #openstack-trove | 00:17 | |
| *** yogeshmehra has quit IRC | 00:21 | |
| *** krow has joined #openstack-trove | 00:23 | |
| *** krow has quit IRC | 00:24 | |
| *** mmcdaris has quit IRC | 00:35 | |
| *** nosnos has joined #openstack-trove | 00:50 | |
| *** shakayumi has quit IRC | 00:56 | |
| *** mmcdaris has joined #openstack-trove | 00:57 | |
| *** mmcdaris has quit IRC | 01:00 | |
| hub_cap | vipul: robots say its a-ok https://review.openstack.org/#/c/49089 | 01:06 |
| vipul | ok merging it | 01:06 |
| hub_cap | <3<3 | 01:06 |
| *** radez_g0n3 is now known as radez | 01:20 | |
| openstackgerrit | A change was merged to openstack/trove: Volume timeout is set too low https://review.openstack.org/49089 | 01:21 |
| *** erkules_ has joined #openstack-trove | 01:31 | |
| *** erkules has quit IRC | 01:33 | |
| *** zacksh_ is now known as zacksh | 01:47 | |
| *** demorris has joined #openstack-trove | 02:45 | |
| SlickNik | hub_cap / vipul: Just got on after travelling. Thanks for taking care of the volume timeout issues. | 02:47 |
| hub_cap | :) welcome back SlickNik | 02:48 |
| SlickNik | my turn to travel today. :P | 02:48 |
| vipul | SlickNik: you survived - how was The Game | 02:48 |
| SlickNik | Was pretty awesome. | 02:48 |
| vipul | where'd you place? | 02:48 |
| SlickNik | Yah we survived and caused a revolution in the state of Pangram. | 02:48 |
| SlickNik | Not sure yet, they have to tally up the scores. | 02:49 |
| SlickNik | Should be out by next week. | 02:49 |
| vipul | cool | 02:49 |
| SlickNik | After everyone catches up on sleep :P | 02:49 |
| SlickNik | And starts crunching the numbers. | 02:50 |
| vipul | hub_cap: have you used 'initialize_service_hook' in rpc.service? | 02:51 |
| vipul | hub_cap, SlickNik: what's the proper way to do a looping call that's non-blocking (on a separate thread) | 02:52 |
| vipul | I guess I could just use Looping Call | 02:54 |
| hub_cap | reasoning vipul? | 02:55 |
| hub_cap | sry that 2 word sentence makes no sense | 02:56 |
| hub_cap | can u give me a scenario | 02:56 |
| SlickNik | yah, oslo common has a LoopingCall function that you can use. | 02:56 |
| vipul | On start of GuestAgent, i want to do something custom, something that loops and does an operation every 60 seconds.. | 02:56 |
| vipul | this is primarily to complete the Heartbeats in Kombu that was removed out of Oslo | 02:57 |
| vipul | basically need to send a heartbeat to the amqp connection | 02:57 |
| SlickNik | It's using greenthreads, so other stuff should run fine while it's not active. | 02:57 |
| vipul | Yea, it's just not spawning a thread, so i assume it's running in the main thread? | 02:58 |
| hub_cap | vipul: thre is a periodic task decorator you can use | 02:58 |
| hub_cap | @periodic_task or something like that | 02:58 |
| hub_cap | https://github.com/openstack/oslo-incubator/blob/master/openstack/common/periodic_task.py | 02:58 |
| hub_cap | @periodic_task(spacing=N [, run_immediately=[True|False]]) | 02:59 |
| hub_cap | this will be run on approximately every N seconds. If this number is | 02:59 |
| hub_cap | ... | 02:59 |
| SlickNik | @periodic_task is correct | 02:59 |
| hub_cap | so just create a method, and put @periodic_task.periodic_task(spacing=60) | 02:59 |
| vipul | I could use that possibly but that would mean creating an inner class that extends periodictask | 02:59 |
| vipul | https://github.com/openstack/oslo-incubator/blob/master/openstack/common/rpc/service.py#L65 | 02:59 |
| vipul | I want it to be invoked via that | 02:59 |
| hub_cap | so this is not in the guest? | 03:00 |
| vipul | That is.. one sec | 03:00 |
| hub_cap | initialize_service_hook is a mgr call... im not sure if you are trying to do something _in_ the guest or on the mgr | 03:01 |
| vipul | I need to do it in the manager | 03:01 |
| vipul | since that's where i have a handle to amqp connection | 03:02 |
| hub_cap | ok so you need to send an amqp event every X seconds? | 03:02 |
| vipul | Yea | 03:03 |
| hub_cap | icic | 03:03 |
| hub_cap | have u looked into what the notification logic does already? | 03:03 |
| vipul | A bit.. i don't want to publish to a queue though | 03:03 |
| hub_cap | wait this is 1x per installation? not per instance, ya? | 03:03 |
| vipul | one per instance | 03:03 |
| hub_cap | but u need amqp handle? | 03:03 |
| SlickNik | vipul just to clarify, you mean mysql_mgr on the guest not the taskmgr, right? | 03:04 |
| vipul | https://lists.launchpad.net/openstack/msg15111.html | 03:05 |
| hub_cap | so you dont send a msg, but need to be in the mgr, so periodic_task is out, ya? | 03:06 |
| vipul | I could do something where in the defintion of that initialize_service_hook method, instantiate a new class that extends a periodic task | 03:08 |
| hub_cap | the periodic task stuff needs to be "hooked up" | 03:08 |
| vipul | Oh it doens't automatically invoke the tasks on instantiation? | 03:08 |
| hub_cap | https://github.com/openstack/trove/blob/master/trove/common/rpc.py#L55 | 03:09 |
| hub_cap | do this | 03:09 |
| vipul | I could do that in the init_service_hook method too | 03:09 |
| hub_cap | https://github.com/openstack/trove/blob/master/bin/trove-guestagent#L60 | 03:09 |
| hub_cap | you can create > 1 services i think in the launcher | 03:09 |
| vipul | I can't | 03:10 |
| vipul | beacuse a service implies a set of queues | 03:10 |
| vipul | and a set of connections | 03:10 |
| hub_cap | only cuz we make it so | 03:10 |
| hub_cap | https://github.com/openstack/trove/blob/master/trove/common/rpc.py#L55 | 03:10 |
| hub_cap | override __init__ | 03:10 |
| hub_cap | :) | 03:10 |
| hub_cap | then just do this | 03:10 |
| hub_cap | https://github.com/openstack/cinder/blob/master/bin/cinder-volume | 03:10 |
| hub_cap | https://github.com/openstack/cinder/blob/master/bin/cinder-volume#L70 | 03:11 |
| vipul | what does create() do that's different | 03:13 |
| hub_cap | so if you adhere to the service launcher vipul | 03:14 |
| hub_cap | it calls like 2 methods | 03:14 |
| hub_cap | https://github.com/openstack/trove/blob/fbf4a56efdf719f26c073526a3551c1158060f88/trove/openstack/common/service.py#L100 | 03:14 |
| hub_cap | and just have a start() method that does what u want | 03:15 |
| hub_cap | which is the same as rpc start method | 03:15 |
| hub_cap | u can add it to the binscript | 03:15 |
| hub_cap | as another Launcher like i showed u the cinder one | 03:15 |
| hub_cap | and it will do parent/child pid stuff for you | 03:15 |
| hub_cap | and handle signals and clean itself up etc... | 03:15 |
| hub_cap | and be in its own gt | 03:16 |
| hub_cap | if u want to go that far | 03:16 |
| vipul | Ok i see... that's an option | 03:16 |
| vipul | ugh i wish they fixed heartbeats in Oslo | 03:17 |
| vipul | instead of just removing the partial patch | 03:17 |
| hub_cap | im sure there are 10 other ways to do it lol | 03:17 |
| hub_cap | but thats a way that only involves mod'ing the binscript | 03:17 |
| hub_cap | and the rest of the code lives outside of the guest itself | 03:18 |
| *** krow has joined #openstack-trove | 03:27 | |
| *** krow has quit IRC | 03:35 | |
| *** krow has joined #openstack-trove | 03:37 | |
| *** radez is now known as radez_g0n3 | 03:37 | |
| *** demorris has quit IRC | 03:54 | |
| *** krow has quit IRC | 04:18 | |
| hub_cap | SICK | 04:19 |
| hub_cap | gmail is analyzing my email and looking for flight data | 04:19 |
| hub_cap | i know when my nieces flight is coming in by googling the airport | 04:19 |
| jcooley | sweet | 04:30 |
| hub_cap | jcooley: if you have any flights in your gmail | 04:32 |
| hub_cap | google "my flights" | 04:32 |
| *** erkules_ is now known as erkules | 04:34 | |
| jcooley | hub_cap: no flight data in gmail. been using outlook :( | 04:41 |
| * hub_cap hisses | 04:41 | |
| *** krow has joined #openstack-trove | 04:43 | |
| *** adrian_otto has quit IRC | 04:57 | |
| *** mmcdaris has joined #openstack-trove | 05:12 | |
| *** adrian_otto has joined #openstack-trove | 05:16 | |
| *** krow has quit IRC | 05:27 | |
| *** krow has joined #openstack-trove | 05:30 | |
| *** rushiagr has joined #openstack-trove | 06:10 | |
| *** vipul is now known as vipul-away | 06:16 | |
| *** yogeshmehra has joined #openstack-trove | 06:16 | |
| *** yogeshmehra has quit IRC | 06:27 | |
| *** yogeshmehra has joined #openstack-trove | 06:29 | |
| *** vipul-away is now known as vipul | 06:30 | |
| openstackgerrit | Pradeep Kumar Chandani proposed a change to openstack/trove: Service Registration using conf file https://review.openstack.org/41055 | 06:34 |
| *** mmcdaris has quit IRC | 06:38 | |
| *** rushiagr has quit IRC | 06:47 | |
| *** yogeshmehra has quit IRC | 07:07 | |
| *** ashestakov has joined #openstack-trove | 07:09 | |
| *** rushiagr has joined #openstack-trove | 07:20 | |
| *** ashestakov has quit IRC | 07:25 | |
| *** isviridov_ has joined #openstack-trove | 07:30 | |
| *** isviridov_ has quit IRC | 07:32 | |
| *** krow has quit IRC | 07:32 | |
| PradeepChandani | change password for User API is now working | 07:34 |
| PradeepChandani | I am using command : ~/trove-integration/scripts/redstack rd-client user change_password --id <ID> --name <UserName> --password <NewUserPassword> --databases <DatabaseName> | 07:35 |
| *** isviridov_ has joined #openstack-trove | 07:36 | |
| *** rushiagr has quit IRC | 07:37 | |
| *** rushiagr has joined #openstack-trove | 07:42 | |
| *** krow has joined #openstack-trove | 07:47 | |
| *** isviridov_ has quit IRC | 07:53 | |
| *** isviridov__ has joined #openstack-trove | 07:53 | |
| *** rushiagr has quit IRC | 07:59 | |
| *** isviridov_ has joined #openstack-trove | 08:06 | |
| *** isviridov__ has quit IRC | 08:07 | |
| *** ashestakov has joined #openstack-trove | 08:07 | |
| *** rushiagr has joined #openstack-trove | 08:08 | |
| *** adrian_otto has quit IRC | 08:15 | |
| *** timfreund has quit IRC | 08:16 | |
| *** krow has quit IRC | 08:17 | |
| *** rushiagr has quit IRC | 08:27 | |
| *** rushiagr has joined #openstack-trove | 08:30 | |
| *** timfreund has joined #openstack-trove | 08:36 | |
| *** krow has joined #openstack-trove | 08:40 | |
| *** ppenjoy has joined #openstack-trove | 08:49 | |
| *** rushiagr has quit IRC | 08:49 | |
| *** ppenjoy has quit IRC | 08:53 | |
| *** ppenjoy has joined #openstack-trove | 09:02 | |
| *** ashestakov_ has joined #openstack-trove | 09:12 | |
| *** rushiagr has joined #openstack-trove | 09:25 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Extract generic part of GA code from MySQL specific modules https://review.openstack.org/48435 | 09:41 |
| *** ppenjoy has left #openstack-trove | 09:48 | |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Support service types https://review.openstack.org/47936 | 09:59 |
| *** ashestakov has quit IRC | 10:13 | |
| *** rushiagr has quit IRC | 10:27 | |
| *** rushiagr has joined #openstack-trove | 10:29 | |
| *** krow has quit IRC | 10:42 | |
| *** krow has joined #openstack-trove | 10:46 | |
| *** isviridov__ has joined #openstack-trove | 10:47 | |
| *** isviridov_ has quit IRC | 10:47 | |
| *** isviridov__ has quit IRC | 10:48 | |
| *** isviridov_ has joined #openstack-trove | 10:49 | |
| *** isviridov__ has joined #openstack-trove | 10:52 | |
| *** isviridov_ has quit IRC | 10:53 | |
| *** isviridov__ has quit IRC | 10:53 | |
| *** rushiagr has quit IRC | 10:53 | |
| *** isviridov_ has joined #openstack-trove | 10:53 | |
| *** isviridov_ has quit IRC | 10:58 | |
| *** rushiagr has joined #openstack-trove | 11:03 | |
| *** isviridov_ has joined #openstack-trove | 11:07 | |
| *** radez_g0n3 is now known as radez | 11:09 | |
| dmakogon | PradeepChandani: around ? | 11:11 |
| PradeepChandani | yes | 11:14 |
| dmakogon | PradeepChandani: ho | 11:14 |
| dmakogon | hi | 11:14 |
| dmakogon | i'm wondering about your review | 11:15 |
| dmakogon | PradeepChandani: could you explain me what exactly you've done in https://review.openstack.org/41055 ? | 11:16 |
| PradeepChandani | yes | 11:16 |
| dmakogon | PradeepChandani: please, it would be great | 11:17 |
| PradeepChandani | for any service type first of all it will search in code using dict | 11:17 |
| PradeepChandani | if not found it there it would try to find it from config file | 11:17 |
| PradeepChandani | otherwise raise exception saying that No manager found | 11:17 |
| dmakogon | PradeepChandani: where dict is specified ? | 11:18 |
| dmakogon | PradeepChandani: guestagent conf ? | 11:18 |
| PradeepChandani | yes | 11:19 |
| PradeepChandani | and dict is in trove.guestagent.dbaas | 11:20 |
| *** rushiagr has quit IRC | 11:20 | |
| dmakogon | PradeepChandani: why in review there is no changes in trove.guestagent.dbaas and guestagent.conf ? | 11:21 |
| dmakogon | PradeepChandani: it would be great if you write example and comment it with # | 11:21 |
| PradeepChandani | no changes in trove.guestagent.dbaas because dict is already there for service types | 11:22 |
| dmakogon | ok with dbaas | 11:22 |
| PradeepChandani | and any one want to add new service type he just need to add in guestagent.conf | 11:22 |
| dmakogon | but config - still should be updates, am i wrong ? | 11:23 |
| PradeepChandani | no.. | 11:23 |
| PradeepChandani | no update required | 11:23 |
| PradeepChandani | if any body want to add new service type which is not in dict he can add it in config file | 11:23 |
| dmakogon | format ? | 11:24 |
| dmakogon | could you update your review with current format | 11:25 |
| dmakogon | format which specifies new service entry in config | 11:25 |
| PradeepChandani | format will be <service_type>+_guestagent_impl | 11:27 |
| dmakogon | could you type full format, with keyword | 11:28 |
| *** rushiagr has joined #openstack-trove | 11:28 | |
| PradeepChandani | you mean I need to add amend comment section for specify format of entry in config file | 11:29 |
| dmakogon | yes | 11:30 |
| PradeepChandani | ok will do that | 11:30 |
| dmakogon | thanks | 11:30 |
| dmakogon | i'll +1 it after that, if it means something 2 u :) | 11:31 |
| PradeepChandani | thaks | 11:31 |
| PradeepChandani | I will update | 11:31 |
| PradeepChandani | Thanks* | 11:31 |
| PradeepChandani | :) | 11:31 |
| *** nosnos has quit IRC | 11:33 | |
| PradeepChandani | Hi Damkogon | 11:37 |
| *** matsuhashi has quit IRC | 11:37 | |
| PradeepChandani | if I specigy path like this : <service_type>_guestagent_impl = <path of Manager> | 11:37 |
| PradeepChandani | is it fine ? | 11:37 |
| openstackgerrit | Pradeep Kumar Chandani proposed a change to openstack/trove: Service Registration using conf file https://review.openstack.org/41055 | 11:43 |
| dmakogon | PradeepChandani: i'll take a look | 11:47 |
| dmakogon | PradeepChandani: what about adding this hint to config ? | 11:48 |
| isviridov | PradeepChandani, what is deploying flow for such extention? | 11:52 |
| PradeepChandani | hi Isviridov..are you talking for 41055 change set | 11:53 |
| isviridov | Yeap, is it expected that guest agent implementation can be out of trove package? | 11:55 |
| PradeepChandani | it can be | 11:57 |
| isviridov | We are working on plugubility and extensibility in code. But what about deployment, looks like in one environment we can have several implementation installed into the system separately | 11:59 |
| PradeepChandani | the change is made if Manager not found in dbaas dict then it will look for trove.guestagent config file if not there it will raise exception | 12:03 |
| PradeepChandani | if any one want to add new service type he need to add Manager entry in config file | 12:04 |
| *** isviridov__ has joined #openstack-trove | 12:06 | |
| *** isviridov_ has quit IRC | 12:06 | |
| *** pdmars_ has joined #openstack-trove | 12:08 | |
| *** Kapil has joined #openstack-trove | 12:10 | |
| *** Kapil has quit IRC | 12:19 | |
| *** rushiagr has quit IRC | 12:19 | |
| *** Kapil has joined #openstack-trove | 12:21 | |
| *** haomaiwang has joined #openstack-trove | 12:26 | |
| *** krow has quit IRC | 12:26 | |
| *** rushiagr has joined #openstack-trove | 12:47 | |
| *** radez is now known as radez_g0n3 | 12:53 | |
| *** rushiagr has quit IRC | 12:54 | |
| *** rushiagr has joined #openstack-trove | 13:08 | |
| *** robertmyers has joined #openstack-trove | 13:12 | |
| PradeepChandani | can anyone look into https://bugs.launchpad.net/trove/+bug/1233152 | 13:12 |
| PradeepChandani | please | 13:12 |
| *** jcru has joined #openstack-trove | 13:14 | |
| dmakogon | PradeepChandani: ok | 13:15 |
| PradeepChandani | thanks | 13:17 |
| dmakogon | PradeepChandani: is it failing only in redstack ? | 13:20 |
| PradeepChandani | I have checked it in redstack only | 13:22 |
| PradeepChandani | where else can we check this ? | 13:22 |
| dmakogon | fully-deployed OS | 13:25 |
| *** rushiagr has quit IRC | 13:37 | |
| *** Barker has joined #openstack-trove | 13:38 | |
| *** Kapil has quit IRC | 13:42 | |
| *** grapex has joined #openstack-trove | 13:44 | |
| *** tanisdl has joined #openstack-trove | 14:06 | |
| *** rushiagr has joined #openstack-trove | 14:08 | |
| *** radez_g0n3 is now known as radez | 14:11 | |
| *** demorris has joined #openstack-trove | 14:19 | |
| *** grapex has quit IRC | 14:24 | |
| *** adrian_otto has joined #openstack-trove | 14:25 | |
| *** grapex has joined #openstack-trove | 14:25 | |
| *** SnowDust has joined #openstack-trove | 14:27 | |
| *** rushiagr has quit IRC | 14:38 | |
| *** tanisdl has quit IRC | 14:39 | |
| *** tanisdl has joined #openstack-trove | 14:40 | |
| *** kevinconway has quit IRC | 14:43 | |
| *** kevinconway has joined #openstack-trove | 14:58 | |
| *** demorris has quit IRC | 14:58 | |
| hub_cap | im not sure it would matter PradeepChandani dmakogon between redstack and fully deployed OS | 15:02 |
| hub_cap | its just talking to the trove-api, and failing :) | 15:02 |
| *** Barker has quit IRC | 15:05 | |
| *** demorris has joined #openstack-trove | 15:09 | |
| *** jaishanker has joined #openstack-trove | 15:11 | |
| SnowDust | hub_cap : whats the word about PradeepChandani i missed the conversation | 15:22 |
| hub_cap | i think hes still having issues SnowDust | 15:23 |
| *** yogeshmehra has joined #openstack-trove | 15:23 | |
| dmakogon | hub_cap: is this bug confirmed ? | 15:24 |
| hub_cap | but good news. there are some people at HP looking at heat integration so i think it will make the heat implementation better, and faster | 15:24 |
| hub_cap | dmakogon: what bug? do u have a link? | 15:24 |
| dmakogon | hub_cap: https://bugs.launchpad.net/trove/+bug/1233152 | 15:24 |
| *** isviridov_ has joined #openstack-trove | 15:24 | |
| hub_cap | i have nto confirmed it | 15:24 |
| *** isviridov__ has quit IRC | 15:25 | |
| *** datsun180b has joined #openstack-trove | 15:26 | |
| dmakogon | hub_cap: i've got news about DNS, floating IPs | 15:26 |
| dmakogon | hub_cap: https://blueprints.launchpad.net/heat/+spec/designate-resource | 15:26 |
| *** isviridov__ has joined #openstack-trove | 15:26 | |
| hub_cap | what does the heat resource have to do w/ our dns impl? | 15:27 |
| dmakogon | heat gonna implement Designate support, and we gonna re-use it | 15:27 |
| SnowDust | hub_cap: a heated LOL | 15:27 |
| dmakogon | SnowDust: lol | 15:27 |
| *** yogeshmehra has quit IRC | 15:28 | |
| dmakogon | hub_cap: what are our plans for deep heat integration ? | 15:28 |
| *** isviridov_ has quit IRC | 15:29 | |
| *** jmontemayor has joined #openstack-trove | 15:30 | |
| hub_cap | we will eventually use heat | 15:31 |
| datsun180b | aww here i was hoping we'd have another rename vote and run the risk of becoming Pony | 15:32 |
| hub_cap | LOL datsun180b | 15:32 |
| dmakogon | hub_cap: what about re-implementing everything with heat ? | 15:33 |
| hub_cap | dmakogon: that is the plan | 15:33 |
| dmakogon | hub_cap: and getting rid of nova-brutal-stuff | 15:33 |
| SnowDust | dmakogon: why re-implement if everything works .. just template hardwired | 15:33 |
| hub_cap | but there are issues w/ the integration right now | 15:33 |
| dmakogon | hub_cap: what kind ? | 15:33 |
| hub_cap | so if u want to abandon your change to dns, we can wait until we use heat to do floating ips | 15:34 |
| *** Barker has joined #openstack-trove | 15:34 | |
| hub_cap | confirm resize is one | 15:34 |
| hub_cap | heat trusts integration is another | 15:34 |
| hub_cap | to me, if u need floating IP support / dns support, we should add it to trove | 15:34 |
| hub_cap | it will be easier to move the implementation after we fully integrate heat | 15:35 |
| *** paul_lodronio has joined #openstack-trove | 15:35 | |
| dmakogon | hub_cap: cat i propose another service registry mechanism instead of https://review.openstack.org/41055 ? | 15:35 |
| dmakogon | hub_cap: agreed | 15:36 |
| SnowDust | LOL ! | 15:36 |
| hub_cap | dmakogon: sure. it has to allow for external services (ones not defined in the upstream code) | 15:37 |
| dmakogon | hub_cap: ok, thanks | 15:38 |
| dmakogon | git status | 15:38 |
| dmakogon | lol, missed console)) | 15:38 |
| hub_cap | nothing to commit, working directory clean | 15:38 |
| SnowDust | but hub_cap / dmakogon i surely suggest the re implementation of trove/common/template.HeatTemplate | 15:38 |
| hub_cap | yes plz SnowDust | 15:38 |
| hub_cap | it can be done better | 15:39 |
| dmakogon | SnowDust: i thinks yes, it should be super-mega flexible))) | 15:39 |
| hub_cap | heat is a work in progress, so dont think it cant be changed | 15:39 |
| hub_cap | it should be changed, and made better | 15:39 |
| SnowDust | so that it can handle multiple runtime templates .. yeah .. thats what i meant dmakogon | 15:39 |
| SnowDust | thanks | 15:39 |
| hub_cap | ok must run to the grocery store, cu guys in a while | 15:39 |
| dmakogon | SnowDust: do not forget about HHDSL | 15:39 |
| dmakogon | hub_cap: cu | 15:40 |
| SnowDust | let me learn that first .. | 15:40 |
| SnowDust | dmakogon: so whats it | 15:40 |
| dmakogon | SnowDust: yes, it's future feature) | 15:40 |
| SnowDust | bt what ? | 15:41 |
| hub_cap | i think he means http://docs.openstack.org/developer/heat/template_guide/hot_guide.html | 15:41 |
| SnowDust | Heat orchestration template ? | 15:41 |
| hub_cap | ok cu guys | 15:41 |
| *** isviridov_ has joined #openstack-trove | 15:41 | |
| redthrux | hub_cap: i just saw yur ping | 15:44 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: GA refactoring https://review.openstack.org/49176 | 15:44 |
| *** isviridov__ has quit IRC | 15:44 | |
| *** isviridov__ has joined #openstack-trove | 15:45 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: GA refactoring https://review.openstack.org/49176 | 15:46 |
| *** isviridov_ has quit IRC | 15:46 | |
| *** SnowDust has quit IRC | 15:48 | |
| dmakogon | guys, please, take a look and +/- 1/2 | 15:49 |
| dmakogon | https://review.openstack.org/#/c/48305/ | 15:49 |
| *** demorris has quit IRC | 15:53 | |
| *** ashestakov_ has quit IRC | 16:00 | |
| *** SnowDust has joined #openstack-trove | 16:01 | |
| *** demorris has joined #openstack-trove | 16:03 | |
| dmakogon | kevinconway: around ? | 16:10 |
| kevinconway | dmakogon: yeah, what's up? | 16:11 |
| dmakogon | kevinconway: i have answered to your question | 16:11 |
| dmakogon | kevinconway: supposing answer is clear) | 16:12 |
| kevinconway | are you sure that those tests aren't the same? | 16:12 |
| kevinconway | what I mean is, the second one looks like it does all that the first does | 16:12 |
| kevinconway | plus some extra | 16:12 |
| openstackgerrit | Jenkins proposed a change to openstack/python-troveclient: Updated from global requirements https://review.openstack.org/49205 | 16:15 |
| openstackgerrit | Jenkins proposed a change to openstack/trove: Updated from global requirements https://review.openstack.org/49207 | 16:15 |
| kevinconway | dmakogon: I didn't -1 because I don't think it's wrong. I was curious if the first test ever even ran because it gets overwritten by the second. | 16:16 |
| kevinconway | may be possible just to remove the first test | 16:16 |
| dmakogon | kevinconway: oh, i'm not telling that you -1 it, just notifying that i answered you | 16:17 |
| dmakogon | kevinconway: about tests run process - all tests are executing no matter if there another test with same name | 16:18 |
| *** isviridov_ has joined #openstack-trove | 16:21 | |
| *** demorris has quit IRC | 16:21 | |
| *** isviridov__ has quit IRC | 16:23 | |
| kevinconway | dmakogon: are you sure? How can the test runner collect something that is overwritten? | 16:25 |
| dmakogon | kevinconway: let's say - it's magic ;) | 16:25 |
| *** SnowDust has quit IRC | 16:26 | |
| datsun180b | I figure they're two different tests that unfortunately had the same name, so the first one never got a fair shot when the second one came around | 16:26 |
| kevinconway | dmakogon: I'm not sure about that. I don't think it runs. Anyway, this conversation is too long for 6 lines of code and it isn't worth a -1. | 16:31 |
| dmakogon | kevinconway: lol, yes | 16:32 |
| dmakogon | datsun180b: but tox in jenkins logs telling that all tests are completed | 16:33 |
| datsun180b | i'm already on your side, we had both tests written, might as well give them different names | 16:33 |
| *** isviridov_ has quit IRC | 16:36 | |
| *** jaishanker has quit IRC | 16:36 | |
| dmakogon | kevinconway: +1 my review))) | 16:39 |
| *** isviridov_ has joined #openstack-trove | 16:39 | |
| openstackgerrit | Ed Cranford proposed a change to openstack/trove: Trove-conductor. https://review.openstack.org/45116 | 16:41 |
| dmakogon | can anyone retrigger this build ? | 16:42 |
| datsun180b | I've got to fix my devstack changes before that thing flies right though | 16:42 |
| hub_cap | what build dmakogon? | 16:43 |
| dmakogon | hub_cap: https://rdjenkins.dyndns.org/job/Trove-Gate/1120 | 16:43 |
| dmakogon | hub_cap: i don't understand how it is failed ... | 16:45 |
| hub_cap | restore failed dmakogon... thats all i know | 16:46 |
| datsun180b | fyi the conductor deal is probably going to fail since conductor doesn't have its configs yet, devstack pull request pending | 16:47 |
| hub_cap | makes sense... can u put the link on your conductor review once the devstack pull is up | 16:50 |
| *** ashestakov has joined #openstack-trove | 16:50 | |
| datsun180b | once i submit it anyway. making sure the instance goes active in my env here | 16:53 |
| hub_cap | for sure | 16:55 |
| *** yogeshmehra has joined #openstack-trove | 16:58 | |
| harlowja | so whats the rename going to be hub_cap :-P | 17:03 |
| hub_cap | openstack-trove | 17:04 |
| hub_cap | :P | 17:04 |
| *** isviridov__ has joined #openstack-trove | 17:04 | |
| harlowja | :) | 17:05 |
| *** isviridov_ has quit IRC | 17:07 | |
| hub_cap | thatll teach em' | 17:08 |
| *** isviridov__ has quit IRC | 17:08 | |
| *** isviridov_ has joined #openstack-trove | 17:08 | |
| harlowja | ya, always namespace :-P | 17:08 |
| *** isviridov_ has quit IRC | 17:10 | |
| datsun180b | so then will we be openstack-openstack-trove when we get packaged | 17:13 |
| harlowja | more openstack! | 17:13 |
| harlowja | ha | 17:13 |
| *** isviridov_ has joined #openstack-trove | 17:14 | |
| *** isviridov_ has quit IRC | 17:16 | |
| *** isviridov_ has joined #openstack-trove | 17:19 | |
| *** isviridov_ has quit IRC | 17:22 | |
| *** isviridov_ has joined #openstack-trove | 17:25 | |
| *** SnowDust has joined #openstack-trove | 17:26 | |
| *** isviridov_ has quit IRC | 17:26 | |
| yogeshmehra | dmakogon: this is on the change - https://review.openstack.org/#/c/41055/ | 17:26 |
| *** jmontemayor has quit IRC | 17:29 | |
| *** jmontemayor has joined #openstack-trove | 17:29 | |
| datsun180b | blargh, i'm missing more than i thought from that config | 17:35 |
| *** demorris has joined #openstack-trove | 17:38 | |
| hub_cap | dmakogon: how come you -1'd that without giving a reason? (see msg from yogeshmehra above) | 17:39 |
| *** yidclare has left #openstack-trove | 17:39 | |
| yogeshmehra | hub_cap: i'll catch up with dmakogon...he missed writing the other approach he was talkin bout... | 17:44 |
| hub_cap | yes i think so yogeshmehra :) | 17:45 |
| *** jmontemayor has quit IRC | 17:45 | |
| *** amcrn has joined #openstack-trove | 17:47 | |
| *** yidclare has joined #openstack-trove | 17:51 | |
| hub_cap | holy moly my hat is the github unicorn | 17:54 |
| hub_cap | https://github.com/images/error/angry_unicorn.png | 17:54 |
| hub_cap | grr is github down?! | 17:55 |
| hub_cap | 17:43 UTCWe are continuing to investigate errors loading GitHub.com and reports of git failures. | 17:55 |
| datsun180b | well that would explain "cloning into /opt/stack/cinder" taking forever | 17:56 |
| kevinconway | datsun180b: yeah, i've noticed that if your github endpoint goes down during a clone the process hangs forever | 17:57 |
| datsun180b | fun | 17:57 |
| kevinconway | it won't always fail. just run forever. | 17:57 |
| datsun180b | lousy halting problem | 17:57 |
| kevinconway | also, github coming back up does not change the status. it still keeps going. stuck. in a state of limbo. forever | 17:58 |
| hub_cap | datsun180b: u can change those to the openstack git | 18:00 |
| datsun180b | they should already be updated | 18:00 |
| hub_cap | are they in devstack too? | 18:00 |
| *** jmontemayor has joined #openstack-trove | 18:01 | |
| datsun180b | well maybe not | 18:01 |
| datsun180b | but things seem to be chugging along fine right now | 18:01 |
| *** Barker has quit IRC | 18:03 | |
| kevinconway | hub_cap: has anyone done any testing to see if openstack git is more stable than github? | 18:03 |
| kevinconway | because i've seen GH errors all the time | 18:03 |
| hub_cap | well its more stable in that its smaller and doesnt do all the extra shit GH does | 18:04 |
| hub_cap | like pretty graphs w/ your code | 18:04 |
| hub_cap | its git w/ a ugly web interface | 18:04 |
| hub_cap | :) | 18:04 |
| hub_cap | but the infra team really pimps it, so id assume its got decent uptime | 18:04 |
| hub_cap | i just cloned from it to contiue working | 18:04 |
| datsun180b | "no module named paste". really now | 18:06 |
| redthrux | install paste-deploy first | 18:07 |
| redthrux | (that's what i've had to do) but i thought that was resolved | 18:07 |
| datsun180b | well i'm thinking my vm just fell over during the kickstart | 18:09 |
| datsun180b | lucky they're disposable | 18:09 |
| *** adrian_otto has quit IRC | 18:10 | |
| hub_cap | ++ | 18:11 |
| datsun180b | did you hear that craig managed to get trove to work with vagrant+vbox | 18:17 |
| cp16net | word | 18:19 |
| redthrux | ++ | 18:21 |
| hub_cap | datsun180b: i saw | 18:22 |
| hub_cap | http://lists.openstack.org/pipermail/openstack-dev/2013-October/015864.html | 18:23 |
| datsun180b | hey i'm just making conversation | 18:24 |
| hub_cap | ;) | 18:24 |
| datsun180b | though depending on how useful craig's changes just made this repo to the project maybe it's a good idea to discuss ownership of this repo | 18:24 |
| datsun180b | i mean i'm all for having my name on it | 18:25 |
| datsun180b | and by 'useful' i mean as measured by uptake | 18:25 |
| *** rnirmal has joined #openstack-trove | 18:31 | |
| cp16net | haha | 18:32 |
| cp16net | hub_cap: you know whats weird is i have not recieved that email i sent out to the list yet.. | 18:33 |
| cp16net | thats weird | 18:33 |
| datsun180b | I think you're spared as it knows you sent it | 18:34 |
| kevinconway | cp16net: I haven't seen your email either | 18:34 |
| *** krow has joined #openstack-trove | 18:35 | |
| hub_cap | yo wont | 18:36 |
| hub_cap | *you wont | 18:36 |
| hub_cap | you dont get the emails you send or reply to cp16net | 18:36 |
| cp16net | oh | 18:36 |
| hub_cap | i got it tho | 18:36 |
| *** krow has quit IRC | 18:36 | |
| cp16net | that makes sense then | 18:36 |
| cp16net | i thought i usually did | 18:36 |
| * cp16net shruggs | 18:36 | |
| *** Barker has joined #openstack-trove | 18:37 | |
| *** isviridov_ has joined #openstack-trove | 18:38 | |
| *** krow has joined #openstack-trove | 18:39 | |
| *** isviridov_ has quit IRC | 18:40 | |
| *** jmontemayor has quit IRC | 18:47 | |
| *** krow has quit IRC | 18:47 | |
| *** isviridov_ has joined #openstack-trove | 18:47 | |
| hub_cap | raise Exception("Call to " + url + " did not return a body.") | 18:49 |
| hub_cap | ^ ^ what, do yall think, is a better exception to throw here? | 18:49 |
| SnowDust | url was bathing .. body busy ... so just clothes came ... as response .. | 18:50 |
| cp16net | lol | 18:51 |
| SnowDust | http verb humor ! | 18:51 |
| datsun180b | i know we've got responses that are empty, so would it be appropriate to label this as ResponseEmpty or something to mention that a non-empty response was expected? | 18:51 |
| datsun180b | i'm thinking every 202 Accepted we give back for example, or is that not even part of what you're talking about | 18:52 |
| hub_cap | would AttributeError be good for this datsun180b? | 18:52 |
| vipul | ExpectationFailed -- may be confused with the Expect header not being met thouhg | 18:52 |
| hub_cap | SnowDust: lol | 18:52 |
| datsun180b | if you're looking for response.body then yes | 18:53 |
| *** jmontemayor has joined #openstack-trove | 18:53 | |
| kevinconway | just from a string nitpicking standpoint: "Call to %r did not return a body" % (url,) might be better | 18:53 |
| datsun180b | but if it's present but None I don't think it's appropriate | 18:53 |
| kevinconway | or %s | 18:53 |
| hub_cap | https://github.com/openstack/python-troveclient/blob/master/troveclient/accounts.py#L38 | 18:53 |
| hub_cap | right its checking for None | 18:54 |
| datsun180b | We do that enough it's probably worth making it its own exception | 18:54 |
| hub_cap | yes we do it a ton | 18:54 |
| datsun180b | AttributeError is for when object.attr doesn't exist, so I don't think it's appropriate here | 18:55 |
| *** adrian_otto has joined #openstack-trove | 18:56 | |
| hub_cap | makes sense.. no attr here | 18:56 |
| hub_cap | ill create a BodyNotFound(NotFound), whaddya think? | 18:57 |
| hub_cap | actually datsun180b fwiw, im trying to use these | 18:57 |
| hub_cap | https://github.com/openstack/oslo-incubator/blob/master/openstack/common/apiclient/client.py | 18:57 |
| hub_cap | oops | 18:58 |
| hub_cap | https://github.com/openstack/oslo-incubator/blob/master/openstack/common/apiclient/exceptions.py | 18:58 |
| hub_cap | ValidationError, id think? | 18:59 |
| datsun180b | maybe. ExpectationError would suggest that an accepted: was violated, but I bet technically the empty string is a valid json document, and maybe a valid xml doc too | 19:00 |
| datsun180b | yeah ValidationError seems closest | 19:01 |
| SnowDust | ExpectationError is appropriate .. .. when the url is bathing ;) LOL !! | 19:03 |
| SnowDust | otherwise .. standard errors are the best .. | 19:04 |
| datsun180b | https://review.openstack.org/#/c/49237/ look what i did | 19:04 |
| hub_cap | lol SnowDust | 19:04 |
| *** isviridov__ has joined #openstack-trove | 19:05 | |
| *** yogesh has joined #openstack-trove | 19:07 | |
| *** isviridov_ has quit IRC | 19:08 | |
| *** isviridov_ has joined #openstack-trove | 19:11 | |
| *** isviridov__ has quit IRC | 19:11 | |
| *** isviridov_ has quit IRC | 19:13 | |
| *** isviridov_ has joined #openstack-trove | 19:16 | |
| *** isviridov_ has quit IRC | 19:18 | |
| *** rigormortiz_ has joined #openstack-trove | 19:21 | |
| openstackgerrit | Ed Cranford proposed a change to openstack/trove: Trove-conductor. https://review.openstack.org/45116 | 19:22 |
| *** isvirido` has joined #openstack-trove | 19:26 | |
| *** jaishanker_ has quit IRC | 19:27 | |
| *** rigormortiz has quit IRC | 19:27 | |
| *** isviridov has quit IRC | 19:27 | |
| datsun180b | oh man, that makes sense. on a whim i base64 decoded one of those behemoth auth tokens | 19:28 |
| datsun180b | hadn't realized there was that much info in it | 19:28 |
| hub_cap | ya dude! | 19:30 |
| hub_cap | its got a ton of stuff cached in it | 19:30 |
| hub_cap | its not just a ugly token ;) | 19:30 |
| datsun180b | oh it's still an ugly token but it's also got the service catalog base64 encoded in there | 19:31 |
| ashestakov | hi guys | 19:35 |
| *** vipul is now known as vipul-away | 19:35 | |
| *** SnowDust has quit IRC | 19:35 | |
| ashestakov | doing resize_instance, i see "Calling start_db_with_conf_changes with timeout 150", but on GA side i see noting happens | 19:35 |
| *** isviridov has joined #openstack-trove | 19:38 | |
| *** yogeshmehra has quit IRC | 19:38 | |
| *** isviridov has quit IRC | 19:40 | |
| datsun180b | ashestakov: did mysql start properly? did the guest agent log anything to /tmp/logfile? did apt-get update complete? | 19:42 |
| *** grapex has quit IRC | 19:43 | |
| *** grapex has joined #openstack-trove | 19:43 | |
| ashestakov | datsun180b: mysql started/stopped properly before restart for resize, after instance started, GA do receiving nothing from mq | 19:43 |
| datsun180b | strange. anything mentioning a timeout in taskmanager after the restart? | 19:44 |
| datsun180b | wow, devstack has a lot of open reviews on gerrit | 19:45 |
| datsun180b | i added it to my watchlist and suddenly i have four pages of reviews | 19:46 |
| *** yogeshmehra has joined #openstack-trove | 19:49 | |
| hub_cap | HAH oops | 19:49 |
| hub_cap | you will get notified of your review | 19:49 |
| ashestakov | datsun180b: Timeout while waiting on RPC response - topic: "guestagent.60ae5b30-3da3-4145-b975-b1533efc637a", RPC method: "start_db_with_conf_changes" info: "<unknown>" | 19:50 |
| *** yogesh has quit IRC | 19:50 | |
| *** yogesh has joined #openstack-trove | 19:51 | |
| datsun180b | so the message got onto the queue, but the GA just didn't pick it up when it was restarted. i wonder what happened | 19:51 |
| datsun180b | maybe the resized instance took too long to wake up and start the guest agent up, and taskmanager got tired of waiting? | 19:52 |
| *** yogesh has quit IRC | 19:55 | |
| ashestakov | datsun180b: not sure, but i see on GA start - DEBUG trove.openstack.common.rpc.service [-] Creating Consumer connection for Service guestagent start | 19:58 |
| *** isviridov has joined #openstack-trove | 20:00 | |
| *** Barker has quit IRC | 20:02 | |
| *** isviridov has quit IRC | 20:02 | |
| datsun180b | beats me. either restart wore out taskmanager's timeout or the guestagent simply didn't pick that message off the queue | 20:02 |
| *** isviridov has joined #openstack-trove | 20:05 | |
| *** vipul-away is now known as vipul | 20:05 | |
| datsun180b | yeah i have no idea how to rattle that devstack review. beastly, machinery is in place and i have no idea how to appease it | 20:06 |
| *** Barker has joined #openstack-trove | 20:07 | |
| *** isviridov has quit IRC | 20:07 | |
| *** rnirmal has quit IRC | 20:08 | |
| ashestakov | datsun180b: checked again, its not timeout problem | 20:08 |
| *** yogesh has joined #openstack-trove | 20:08 | |
| datsun180b | i'm out of ideas then | 20:09 |
| *** Barker has quit IRC | 20:10 | |
| *** adrian_otto has quit IRC | 20:14 | |
| *** yogesh has quit IRC | 20:16 | |
| *** yogesh has joined #openstack-trove | 20:17 | |
| datsun180b | so hub_cap are you running for PTL unopposed? do we still get an election? | 20:19 |
| *** dmakogon_ has joined #openstack-trove | 20:20 | |
| datsun180b | i'm imagining the scene from The Dictator where a tank "convinces" people to move to the "Vote for Aladeen" line | 20:20 |
| hub_cap | datsun180b: nope | 20:20 |
| datsun180b | but that would've been fun | 20:21 |
| hub_cap | <3 sbc | 20:21 |
| hub_cap | i dont know how to spell his name | 20:21 |
| hub_cap | so sbc | 20:21 |
| *** ashestakov has quit IRC | 20:21 | |
| *** yogesh has quit IRC | 20:21 | |
| *** yogesh has joined #openstack-trove | 20:22 | |
| *** vipul is now known as vipul-away | 20:24 | |
| *** vipul-away is now known as vipul | 20:25 | |
| *** isviridov has joined #openstack-trove | 20:27 | |
| *** yogesh has quit IRC | 20:28 | |
| *** isviridov has quit IRC | 20:28 | |
| *** yogesh has joined #openstack-trove | 20:28 | |
| dmakogon_ | what's up ? | 20:29 |
| *** isviridov has joined #openstack-trove | 20:32 | |
| *** yogesh has quit IRC | 20:32 | |
| dmakogon_ | hub_cap: around ? | 20:33 |
| hub_cap | aye | 20:34 |
| *** isviridov has quit IRC | 20:34 | |
| dmakogon_ | hub_cap: have you retrigged my review ? =( | 20:35 |
| hub_cap | link plz i forgot earlier | 20:35 |
| dmakogon_ | https://rdjenkins.dyndns.org/job/Trove-Gate/1120 | 20:35 |
| hub_cap | also, you -1'd a review, yogeshmehra knows the review # | 20:36 |
| hub_cap | but you left no comment as to why | 20:36 |
| hub_cap | or what you disliked about it | 20:36 |
| hub_cap | i know u said u were going to propose a different way of doing registry | 20:36 |
| dmakogon_ | or, take a look at it, because there is random error occures | 20:36 |
| hub_cap | but you didnt say so | 20:36 |
| dmakogon_ | hub_cap: i'm doing it | 20:36 |
| hub_cap | sure but at least say someting on the review | 20:36 |
| dmakogon_ | hub_cap: this review is another one | 20:36 |
| hub_cap | -1 w/o a reason doesnt make sense to other people, or the person whos code it is | 20:37 |
| dmakogon_ | hub_cap: i could describe it | 20:37 |
| hub_cap | u can just say | 20:37 |
| hub_cap | id like to propose a different way of doing this | 20:37 |
| dmakogon_ | ok | 20:37 |
| hub_cap | instead of | 20:37 |
| hub_cap | 01 | 20:37 |
| hub_cap | -1 | 20:37 |
| *** isviridov has joined #openstack-trove | 20:37 | |
| hub_cap | and nothign else | 20:37 |
| dmakogon_ | hub_cap: ii know | 20:38 |
| dmakogon_ | hub_cap: wont do that again | 20:38 |
| hub_cap | <3<3 | 20:38 |
| yogeshmehra | dmakogon: can we discuss the otehr approach here... | 20:38 |
| *** adrian_otto has joined #openstack-trove | 20:38 | |
| hub_cap | no need to describe it though, if you are doing a gist or a blueprint or somethign else | 20:38 |
| hub_cap | yes dmakogon_ yogeshmehra discuss | 20:39 |
| dmakogon_ | hub_cap: i just want to freeze it until i propose my own vision | 20:39 |
| hub_cap | yes understandable dmakogon_ | 20:39 |
| hub_cap | propose! | 20:39 |
| dmakogon_ | hub_cap: i'll make a gist quickly now | 20:39 |
| hub_cap | <3 | 20:39 |
| yogeshmehra | awesome.. | 20:40 |
| hub_cap | dmakogon_ the only requirement is that you can specify an implementation thats not in the codebase (like if you had a proprietary impl of a database) | 20:40 |
| dmakogon_ | yes | 20:41 |
| dmakogon_ | hub_cap: that is what i'm doing) | 20:41 |
| dmakogon_ | <3 | 20:41 |
| hub_cap | awesome | 20:41 |
| *** isviridov has quit IRC | 20:44 | |
| *** Barker has joined #openstack-trove | 20:44 | |
| datsun180b | augh, i bet those conductor failures won't be gone until the devstack changes happen | 20:45 |
| *** yogesh has joined #openstack-trove | 20:45 | |
| datsun180b | though i have no idea what's up with metaclass __init__ failing | 20:46 |
| *** yogesh has quit IRC | 20:47 | |
| *** isviridov has joined #openstack-trove | 20:47 | |
| *** yogesh has joined #openstack-trove | 20:48 | |
| *** isviridov has quit IRC | 20:49 | |
| dmakogon_ | hub_cap: datsun180b: https://gist.github.com/crazymac/6784871 | 20:51 |
| dmakogon_ | hub_cap: something like that | 20:51 |
| datsun180b | oh that makes sense, i that was in my conf.sample but not in the updated devstack poop | 20:51 |
| hub_cap | dmakogon_ we had done that a while ago | 20:52 |
| *** yogesh has quit IRC | 20:52 | |
| datsun180b | i think conductor's conf is missing its manager line | 20:52 |
| *** isviridov has joined #openstack-trove | 20:52 | |
| *** demorris has quit IRC | 20:52 | |
| datsun180b | i'm so "glad" we moved all that installation business to devstack | 20:53 |
| dmakogon_ | hub_cap: so, why is that doesnt merged or at least there is a review | 20:53 |
| *** isviridov_ has joined #openstack-trove | 20:53 | |
| *** adrian_otto has quit IRC | 20:53 | |
| *** Barker has quit IRC | 20:54 | |
| *** isviridov has quit IRC | 20:54 | |
| dmakogon_ | hub_cap: my main point is that i'm updating service registry instead of looking directly into config file for specific option which is not even dict option but string. | 20:56 |
| hub_cap | im not sure that matters really cuz there will only be 1 "special" manager for the impl | 20:57 |
| dmakogon_ | hub_cap: if you take a deep look in review which proposed by Pradeep, you will see that he's doing service lookup by string option | 20:58 |
| hub_cap | if you were spinning up 3 different special managers in the guest code on a instance, i can see the point | 20:58 |
| hub_cap | you would need a dict | 20:58 |
| dmakogon_ | hub_cap: i think GA config should be common without customazing for each of deployments | 20:59 |
| yogeshmehra | or if there are multiple "special" managers you are working on | 20:59 |
| hub_cap | ok fair enough | 20:59 |
| *** yogesh has joined #openstack-trove | 21:00 | |
| dmakogon_ | so, hub_cap, yogeshmehra is my propose acceptable ? | 21:01 |
| hub_cap | yogeshmehra good with that? go w/ the original approach, but with the difference i asked for originally to not specify "all" of the options in the config (exactly like what dmakogon_ says) | 21:01 |
| *** yogesh has quit IRC | 21:01 | |
| *** pdmars_ has quit IRC | 21:01 | |
| yogeshmehra | plz gimme a minute | 21:01 |
| *** yogesh has joined #openstack-trove | 21:02 | |
| *** harlowja has quit IRC | 21:02 | |
| vipul | so we're doing exactly what's there + changing the additional opts to dict_opts? | 21:02 |
| yogeshmehra | why do we want a dictionary in the config... | 21:02 |
| dmakogon_ | vipul: right | 21:02 |
| dmakogon_ | yogeshmehra: if we are ok with common guestagent config then yes | 21:03 |
| hub_cap | vipul: we are doing what we decided a long wile ago (dict in config) | 21:03 |
| hub_cap | but what i was originally unhappy with was the fact that we specified EVERY mgr in the config | 21:04 |
| vipul | Ok i'm fine with that... so now the dict in the config becomes service_registrty_ext | 21:04 |
| vipul | maybe we should neame the cfg variable that.. | 21:04 |
| vipul | 'service_registry_ext' | 21:04 |
| hub_cap | Patch set 7 i commented "My only question is should we remove the service registry in code, or just optionally add it from the config if you want to add non standard modules?" | 21:04 |
| hub_cap | im ok with this option | 21:04 |
| yogeshmehra | again, are we trying to handle the case where there are moe than one "special" managers? | 21:04 |
| dmakogon_ | hub_cap: we should keep service registry only for defaults | 21:05 |
| hub_cap | yogeshmehra: yes | 21:05 |
| *** Barker has joined #openstack-trove | 21:05 | |
| hub_cap | dmakogon_: yes ive said this since the beginning | 21:06 |
| dmakogon_ | hub_cap: for other reasons we could use config dict directly | 21:06 |
| *** yogesh has quit IRC | 21:06 | |
| dmakogon_ | hub_cap: sorry, missed | 21:06 |
| hub_cap | dmakogon_: if you look @ earlier patches it _is_ using DictOpt | 21:06 |
| yogeshmehra | let us go with it...i am ok | 21:06 |
| vipul | What woudl be cool is if we merged the two dicts | 21:06 |
| dmakogon_ | hub_cap: yes i already looked at all patches | 21:06 |
| yogeshmehra | nice extension | 21:07 |
| dmakogon_ | vipul: nice joke, dear friend)) | 21:07 |
| vipul | so on load of SERVICE_REGISTRY.. it could combine itself with values for 'service_registry_ext' (No joke :)) | 21:07 |
| kevinconway | vipul: itertools.chain | 21:07 |
| kevinconway | and if we get to py3 you can use ChainDict | 21:07 |
| vipul | there we go | 21:08 |
| hub_cap | kevinconway: why not just a.update(b) | 21:08 |
| dmakogon_ | hub_cap: because we are tough guys with super-knoladge of Py3 | 21:09 |
| dmakogon_ | knowladge | 21:09 |
| datsun180b | chain > update | 21:09 |
| hub_cap | can u tell me why? srsly, im not a python guy so i need schooling | 21:09 |
| datsun180b | it acknowledges a hierarchy | 21:10 |
| datsun180b | maybe the end result is the same for a lookup but it just feels less clobbery | 21:10 |
| vipul | preserves order? | 21:10 |
| datsun180b | it's not just for dictionaries either | 21:11 |
| kevinconway | so for the ChainMap you could ChainMap(dict1, dict2, dict3) and it does lookups in left to right order | 21:11 |
| hub_cap | {a:b}, {a:c} | 21:11 |
| kevinconway | without actually mutating any of the dictionaries | 21:11 |
| hub_cap | ok that makes sense | 21:12 |
| hub_cap | does itertools.chain do the same? | 21:12 |
| kevinconway | no, not exactly | 21:12 |
| datsun180b | i thought we were talking about itertools.chain | 21:12 |
| datsun180b | isn't chainmap out of collections? | 21:13 |
| hub_cap | we are talking about both datsun180b | 21:13 |
| kevinconway | ChainMap is py3 only | 21:13 |
| hub_cap | as in, why not do update now, id like to know the diff between chain and update in py2 | 21:13 |
| kevinconway | chain takes any number of iterables and produces a generator of all those iterables merged | 21:13 |
| hub_cap | ok so it behaves the same as ChainDict | 21:14 |
| *** yogesh has joined #openstack-trove | 21:14 | |
| hub_cap | gives u a ptr to the dict's | 21:14 |
| hub_cap | so in that case we'd want itertools.chain(custom_dict, code_dict) | 21:14 |
| datsun180b | "pointer" | 21:15 |
| kevinconway | in py2 there's not really a huge benefit to using dict(chain(dict1.iteritems(),…)) over dict1.update(dict2) except that it doesn't mutate dict1 | 21:15 |
| datsun180b | what | 21:15 |
| *** jcru has quit IRC | 21:15 | |
| vipul | I think it's important to allow the conf values to be looked up first.. that allows someone to load a different manager for 'mysql' as well | 21:16 |
| *** krow has joined #openstack-trove | 21:16 | |
| vipul | maybe that won't work too well.. cuz of collision | 21:17 |
| *** yogesh has quit IRC | 21:17 | |
| datsun180b | well i had fun sandboxing with itertools.chain just now | 21:17 |
| dmakogon_ | http://stackoverflow.com/questions/38987/how-can-i-merge-union-two-python-dictionaries-in-a-single-expression | 21:17 |
| *** yogesh has joined #openstack-trove | 21:18 | |
| kevinconway | dmakogon_: yeah, thats where chain would be good | 21:18 |
| kevinconway | instead of doing list(iter1 + iter2) | 21:18 |
| kevinconway | you could chain them | 21:18 |
| dmakogon_ | z3 = dict(chain(x.iteritems(), y.iteritems())) | 21:18 |
| kevinconway | the real benefit comes from getting everything into a generator instead of an list | 21:19 |
| kevinconway | then you get some super memory performance | 21:19 |
| dmakogon_ | kevinconway: agreed, i'll update my gist | 21:19 |
| datsun180b | ab = dict(((k, a.get(k, b.get(k))) for k in set(a.keys() + b.keys()))) | 21:19 |
| datsun180b | isn't that the worst | 21:20 |
| kevinconway | datsun180b: please no | 21:20 |
| dmakogon_ | kevinconway: lol, super memory perfomance and OpenStack - two things that cannot live together))) | 21:20 |
| datsun180b | look at all that (((( and )))), it's beautiful | 21:20 |
| dmakogon_ | or at least noone tries))) | 21:20 |
| *** yogesh has quit IRC | 21:22 | |
| hub_cap | datsun180b: lisp? | 21:22 |
| hub_cap | in this case i dont think we need chain, fwiw | 21:22 |
| hub_cap | we are clobbering a one time use dict in the binscript thats used to start the app | 21:22 |
| datsun180b | hub_cap: i've marked some time with lisp and clojure | 21:22 |
| hub_cap | thats it | 21:22 |
| hub_cap | then we are done w/ it | 21:22 |
| hub_cap | datsun180b: emacs? ;) | 21:23 |
| datsun180b | hub_cap: would you believe it | 21:23 |
| hub_cap | i would believe its why u hate it | 21:23 |
| kevinconway | i think we just need to get the entire openstack community plus the third party dependencies up to py3 compatibility so we can use ChainMap in this one case | 21:23 |
| datsun180b | i don't hate emacs, it just doesn't do what i want the way i want | 21:24 |
| hub_cap | kevinconway: +1 | 21:24 |
| dmakogon_ | btw, guys, i've got question about deployments | 21:25 |
| dmakogon_ | hub_cap: datsun180b: kevinconway: are we going to support something like puppet/cheff ? | 21:26 |
| datsun180b | dmakogon_: how about vagrant! | 21:26 |
| hub_cap | dmakogon_ for what? | 21:27 |
| hub_cap | like deploying trove to a real env? | 21:27 |
| dmakogon_ | no | 21:27 |
| dmakogon_ | hub_cap: for databases installing on VMs | 21:27 |
| hub_cap | like configuring an instance? | 21:27 |
| dmakogon_ | yes | 21:27 |
| hub_cap | how is the pkg mgr not good enough? | 21:28 |
| kevinconway | isn't that also part of the HEAT process? | 21:28 |
| dmakogon_ | hub_cap: a lot of wheel-inventions ;) | 21:28 |
| hub_cap | kevinconway: ill get there ;) | 21:28 |
| *** yogeshmehra has quit IRC | 21:29 | |
| hub_cap | heat just uses apt anyway kevinconway, hence the Q | 21:29 |
| hub_cap | dmakogon_ im not sure i see apt-get install mysql-server as reinventing the wheel | 21:29 |
| hub_cap | if we had 19 packages to set up, and 19 config files to edit, then maybe.... | 21:29 |
| dmakogon_ | mysql takes all dep's with itself | 21:30 |
| dmakogon_ | almosta all NoSQL doesn't grap any of their own dependencies | 21:30 |
| hub_cap | sudo apt-get install cassandra | 21:31 |
| *** radez is now known as radez_g0n3 | 21:31 | |
| dmakogon_ | nope | 21:31 |
| dmakogon_ | that wont work | 21:31 |
| hub_cap | sudo apt-get install mongodb-10gen | 21:32 |
| hub_cap | thats BS dude, it totally works | 21:32 |
| hub_cap | if u set up the apt repo | 21:32 |
| hub_cap | it works fine | 21:32 |
| hub_cap | http://docs.mongodb.org/manual/tutorial/install-mongodb-on-debian/ | 21:32 |
| dmakogon_ | maybe, but it won't work for cassandra | 21:32 |
| dmakogon_ | i'll take a look at mongo later | 21:33 |
| hub_cap | it depends on what you are doing | 21:33 |
| hub_cap | if your talking using yarn to install it then we need to do some instrumenting | 21:33 |
| hub_cap | but thats not going to be solved via a chef server | 21:33 |
| dmakogon_ | than puppet | 21:33 |
| hub_cap | or puppet scripts | 21:34 |
| konetzed | sounds like the packages need to be written to have the deps correct | 21:34 |
| dmakogon_ | i've already got awesome manifests for cluster-ready cassandra | 21:34 |
| hub_cap | i tihink dmakogon_ is saying that w/ cassandra you need to install something like ZK/yarn first, right? | 21:34 |
| hub_cap | so there are dependencies | 21:34 |
| dmakogon_ | yes | 21:34 |
| dmakogon_ | hub_cap: although java | 21:35 |
| dmakogon_ | oracle or open | 21:35 |
| dmakogon_ | there is different mechanisms for java installing | 21:35 |
| hub_cap | i dont care about that, im going to assume java is installed on a base image :) | 21:35 |
| dmakogon_ | ppa, wget+tar | 21:35 |
| konetzed | dmakogon_: depends on who you talk to, sysadmin will says package manager is the only way | 21:35 |
| dmakogon_ | that was for oracle-jdk | 21:35 |
| dmakogon_ | konetzed: excuse me, but this stuff should be installed on instance booting | 21:36 |
| dmakogon_ | booting in trove terms | 21:36 |
| konetzed | dmakogon_: sure and use the package manger | 21:37 |
| konetzed | :D | 21:37 |
| hub_cap | hell thats what puppet is doing :) | 21:37 |
| hub_cap | i dont want to incur the cost of having the extra tools dmakogon_ | 21:37 |
| hub_cap | we can express them in heat templates | 21:38 |
| hub_cap | and if we cant | 21:38 |
| hub_cap | then we can fix heat templates :) | 21:38 |
| *** yogeshmehra has joined #openstack-trove | 21:39 | |
| hub_cap | consider heat your puppet dmakogon_ | 21:40 |
| dmakogon_ | ok =)) | 21:40 |
| *** yogesh has joined #openstack-trove | 21:40 | |
| hub_cap | also dmakogon_ | 21:41 |
| hub_cap | datastax installation http://www.datastax.com/docs/1.0/install/install_deb | 21:41 |
| hub_cap | i was so confused as to why i was looking @ ZK/yarn | 21:41 |
| hub_cap | i was looking @ cdh | 21:41 |
| hub_cap | sudo apt-get install python-cql=1.0.10-1 | 21:41 |
| hub_cap | or | 21:41 |
| hub_cap | sudo apt-get install dsc=1.0.10 cassandra=1.0.10 | 21:41 |
| dmakogon_ | i know | 21:42 |
| dmakogon_ | i know how to setup cassandra | 21:42 |
| *** harlowja has joined #openstack-trove | 21:42 | |
| dmakogon_ | let's move on | 21:43 |
| vipul | Can we go back to the service_registry :) | 21:45 |
| vipul | i just thought of a new requirement.. I actually do want to be able to replace the mysql manager | 21:45 |
| vipul | I don't know if service_registry_ext will solve that | 21:45 |
| vipul | So maybe merging the two isn't the best Idea.. maybe the solution is to look at the Dict in cfg first -- and if you don't find the service_type.manager there, then look in code | 21:46 |
| hub_cap | service_reg.update(service_reg_ext) | 21:48 |
| dmakogon_ | vipul: what about validating dict ? | 21:48 |
| vipul | hub_cap: same keys? | 21:49 |
| hub_cap | https://gist.github.com/hub-cap/6785680 | 21:49 |
| dmakogon_ | if 'mysql' in service_registry_ext.keys(): service_registry_ext.delete('mysql') | 21:49 |
| vipul | hub_cap: ok good | 21:50 |
| hub_cap | simple enough eh? | 21:50 |
| hub_cap | itd work w/ chain too | 21:50 |
| vipul | should have tried that | 21:50 |
| vipul | dmakogon_: i think what hub_cap said works | 21:50 |
| hub_cap | but depending on which object you "update", itll clobber one of those | 21:50 |
| dmakogon_ | hub_cap: ext.update(default) | 21:51 |
| vipul | dmakogon_: That would probably do the opposite of what we want | 21:52 |
| dmakogon_ | vipul: idea to update with new impl for default ? | 21:52 |
| dmakogon_ | vipul: if it so, then yse | 21:53 |
| dmakogon_ | yes | 21:53 |
| vipul | what's in ext should override defaults | 21:53 |
| dmakogon_ | yes | 21:53 |
| datsun180b | hey i see an "in" over a dict | 21:53 |
| dmakogon_ | i get it | 21:53 |
| datsun180b | .keys is needless | 21:53 |
| hub_cap | my gist wins all | 21:54 |
| hub_cap | :) | 21:54 |
| hub_cap | vipul: agrees | 21:54 |
| *** yogesh has quit IRC | 21:54 | |
| hub_cap | whether he does or not, i say he does | 21:54 |
| *** yogesh has joined #openstack-trove | 21:55 | |
| dmakogon_ | hub_cap: i'll post review tomorrow for service registry | 21:55 |
| hub_cap | dmakogon_: plz dont | 21:57 |
| hub_cap | let the author who did it already post the review | 21:57 |
| hub_cap | tehre is no reason to take it from him ;) | 21:57 |
| *** yogeshmehra has quit IRC | 21:57 | |
| vipul | hub_cap: +1 | 21:57 |
| dmakogon_ | hub_cap: i'm not taking it from him just using his blueprint | 21:57 |
| *** krow has quit IRC | 21:57 | |
| vipul | dmakogon_: I think what would be good is to give this feedback to him in the patch | 21:57 |
| dmakogon_ | vipul: the reason why i doing it is that original author doesn't agreed with my suggestion | 21:59 |
| vipul | dmakogon_: I still think it's better to come to a comprimise / solution within a single patch instead of pushing competing patches up | 21:59 |
| *** yogesh has quit IRC | 21:59 | |
| hub_cap | dmakogon_: vipul is correct | 22:00 |
| dmakogon_ | ok, just let his current patch being merged and i'll submit new review for updating it | 22:00 |
| hub_cap | no | 22:00 |
| hub_cap | put your comment on it | 22:00 |
| hub_cap | and we will make sure it gets updated | 22:01 |
| hub_cap | he works for vipul | 22:01 |
| dmakogon_ | ok | 22:01 |
| hub_cap | so vipul will make it so | 22:01 |
| hub_cap | right vipul :) | 22:01 |
| hub_cap | in general though, if someone does not agree w/ your comments, you go to the core team and ahve them addressed | 22:01 |
| vipul | hub_cap: sure ;) -- at least what we just talked about now.. we need to make sure that's in place before anything gets merged | 22:01 |
| hub_cap | and we make teh decision | 22:02 |
| hub_cap | and the author, if he wants to commit the code (my guess is heas paid to do it), updates the code | 22:02 |
| hub_cap | if he does not, the review is abandoned and then you can do it, but not before | 22:02 |
| hub_cap | its bad form, so to speak | 22:02 |
| dmakogon_ | i posted comment on the review, now supposing that he would do that | 22:02 |
| hub_cap | yup!! | 22:03 |
| dmakogon_ | hub_cap: vipul: https://review.openstack.org/#/c/49176/ | 22:04 |
| vipul | dmakogon_: thanks! | 22:04 |
| hub_cap | +1 horray | 22:04 |
| hub_cap | the robot didint complain dmakogon_ | 22:05 |
| dmakogon_ | hub_cap: i know)) | 22:05 |
| hub_cap | dmakogon_: andrey is doing some of this work too w/ his change | 22:06 |
| datsun180b | some of those lines looked longer that 80 chars but i guess not! | 22:06 |
| dmakogon_ | all of us doing some work around GA | 22:06 |
| hub_cap | ok but you are consulting together on it? | 22:06 |
| dmakogon_ | yes | 22:06 |
| hub_cap | i dont want yall to clobber each others work | 22:06 |
| hub_cap | ok great | 22:06 |
| hub_cap | ill consider it independent then | 22:06 |
| dmakogon_ | andrey is working on versions/db_engines, i'm working on db_engines | 22:08 |
| datsun180b | oh geez, i hadn't even considered that i'd need to write a fake conductor | 22:08 |
| hub_cap | and ikhudoshyn is working on somethign else too | 22:08 |
| dmakogon_ | hub_cap: yes | 22:08 |
| hub_cap | https://review.openstack.org/#/c/48435 | 22:08 |
| hub_cap | cool can u comment on amcrns question in the review | 22:08 |
| dmakogon_ | all of us working on GA refactoring/imporving | 22:08 |
| hub_cap | so he knows you guys are working together | 22:08 |
| dmakogon_ | ikhudoshyn is sitting in front of me ;) | 22:09 |
| *** Barker has quit IRC | 22:10 | |
| dmakogon_ | and all of us, Andrey, Me and Illya, are working on guestagent | 22:10 |
| openstackgerrit | Michael Basnight proposed a change to openstack/trove: fixing symlink attack bug present in the application. https://review.openstack.org/49276 | 22:11 |
| isviridov_ | BTW cores, what about https://review.openstack.org/#/c/45238/ ? Looks like no objections, but still in the queue | 22:11 |
| hub_cap | im happy w it, ive +2d it | 22:12 |
| hub_cap | ;) | 22:12 |
| isviridov_ | Thx hub_cap i know | 22:12 |
| dmakogon_ | hub_cap: please, if you mind review mine with GA refactoring | 22:13 |
| hub_cap | yes i haave | 22:14 |
| hub_cap | just havent +1d it yet | 22:15 |
| hub_cap | had to deal with | 22:15 |
| hub_cap | https://bugs.launchpad.net/nova/+bug/1154809 | 22:15 |
| hub_cap | security vulnerability | 22:15 |
| amcrn | hub_cap, you missed a space between the octothorpe and 'signing_dir': -2 | 22:15 |
| amcrn | ;) | 22:15 |
| hub_cap | also dmakogon_ plz put a comment to amcrn about the review | 22:16 |
| hub_cap | amcrn: +2 for you | 22:16 |
| hub_cap | octothorpe, most people dont know the official name | 22:16 |
| *** robertmyers has quit IRC | 22:16 | |
| amcrn | it sounds so classy | 22:16 |
| hub_cap | doesnt it? better than "has" | 22:16 |
| hub_cap | hash | 22:16 |
| hub_cap | or pound | 22:16 |
| dmakogon_ | hub_cap: about security groups ? | 22:17 |
| amcrn | I lift my pinky whenever I type octothorpe, just to complete the charade | 22:17 |
| hub_cap | LOL amcrn | 22:17 |
| hub_cap | yes ive put it on the agenda for tomorrow dmakogon_ | 22:17 |
| hub_cap | to discuss | 22:17 |
| datsun180b | i just press capital 3, gets the same job done | 22:17 |
| hub_cap | but no pinky flair datsun180b | 22:18 |
| dmakogon_ | hub_cap: ok | 22:18 |
| datsun180b | my pinkies are busy pressing other keys | 22:18 |
| hub_cap | datsun180b: emacs? | 22:18 |
| hub_cap | ;) | 22:18 |
| datsun180b | touch typing man | 22:18 |
| hub_cap | lol http://ergoemacs.org/emacs/i/emacs_user_at_work_by_earlcolour.jpg | 22:19 |
| dmakogon_ | hub_cap: amcrn: https://review.openstack.org/#/c/45723/ | 22:19 |
| datsun180b | hub_cap: http://www.octodadgame.com/ | 22:19 |
| datsun180b | and with that, i'm out | 22:20 |
| *** datsun180b has quit IRC | 22:20 | |
| dmakogon_ | hub_cap: amcrn: after this one every use cases(degraded networking etc.) would be just a guesses for beer-discuss | 22:21 |
| dmakogon_ | if poll_untill causes timeout that mean that task is failed and nothing else | 22:22 |
| *** isviridov_ has quit IRC | 22:22 | |
| hub_cap | hah ya dmakogon_ +1 to beer | 22:23 |
| amcrn | dmakogon_: ? | 22:24 |
| dmakogon_ | amcr: your complain about removing components in exception block is not soundly | 22:25 |
| dmakogon_ | , if we would follow your logic than we would not allow to delete that kind of instances for reason becoming active someday in future life | 22:25 |
| amcrn | my comment didn't advocate for anything? I'm just pointing out that it's possible with the introduction of that logic, that a database instance is provisioned with all ports open. | 22:26 |
| amcrn | likely? no. possible? yes | 22:27 |
| *** krow has joined #openstack-trove | 22:28 | |
| dmakogon_ | trove customer doesn't knows anything about VM and opend port on it | 22:29 |
| dmakogon_ | for developer - if it fails it's a trash | 22:29 |
| dmakogon_ | nothing else | 22:29 |
| dmakogon_ | amcrn: noone would spin-up dead(in trove term) VM when it got failed to become active in some reason | 22:31 |
| amcrn | i'm not following? using only that review as a guide, it's possible for the guest to initialize as ACTIVE, assuming a scenario in which on cloud-init an "apt-get update" goes extremely slow | 22:31 |
| dmakogon_ | customer want a database, he do not give a s#%t about VM | 22:32 |
| amcrn | and for the Security Group to be deleted due to the PollTimeout being exceeded | 22:32 |
| dmakogon_ | amcrn: you are suppose to know about that kind of issues with networking they are not predictable, if something went wrong on apt-get or other tasks - instance recieves label FAILED | 22:35 |
| dmakogon_ | just increase timeout | 22:35 |
| dmakogon_ | you cannot guess what kind of problem happend | 22:35 |
| dmakogon_ | think like customer not like developer | 22:36 |
| *** krow has quit IRC | 22:36 | |
| dmakogon_ | suppose you want a database, and you know that it would take a time for delivering of it, so if time passed and database is not reachable - something went wrongm, report admin | 22:37 |
| *** amcrn is now known as amcrn[a] | 22:38 | |
| dmakogon_ | then you, customer, trying to get another one database and you are getting Quota exceeded | 22:38 |
| dmakogon_ | is it ok ? | 22:38 |
| hub_cap | dmakogon_ if its failed its still counted against your quota | 22:39 |
| hub_cap | or building | 22:39 |
| hub_cap | only if its deleted is it not counted | 22:39 |
| dmakogon_ | trove manages quota on instances not on security groups | 22:39 |
| dmakogon_ | am i right > | 22:39 |
| dmakogon_ | ? | 22:39 |
| hub_cap | correct | 22:40 |
| hub_cap | i was referring to a instance, not a secgrp | 22:40 |
| dmakogon_ | in terms of instances, i've submited a review about setting status to FAILED on timeouted instances | 22:41 |
| dmakogon_ | if it would be accepted | 22:41 |
| dmakogon_ | than customer would be able to delete failed instances with simple delete | 22:41 |
| dmakogon_ | not even force delete | 22:41 |
| dmakogon_ | but instance componenets should be cleaned up before setting FAILED status | 22:42 |
| dmakogon_ | hub_cap: ok with that ? | 22:42 |
| hub_cap | sure dmakogon_ | 22:42 |
| *** adrian_otto has joined #openstack-trove | 22:42 | |
| hub_cap | i cant remember, mayb grapex or redthrux can, but instances go to failed in production | 22:43 |
| dmakogon_ | that is why i'm not implementing cleanup for volumes | 22:43 |
| dmakogon_ | because volumes are managed by quota | 22:43 |
| dmakogon_ | i'm cleaning up everithing that managed with tenant qouta but not trove quota | 22:44 |
| dmakogon_ | hub_cap: ok with that ? | 22:44 |
| hub_cap | we will discuss "cleaning" tomorrow | 22:44 |
| hub_cap | redthrux: is running a production system and has issues w/ teh cleanup stuff | 22:45 |
| hub_cap | so i will let him talk about it | 22:45 |
| dmakogon_ | i know, but i'm asking you know)) | 22:45 |
| hub_cap | and im deferring | 22:45 |
| hub_cap | ;) | 22:45 |
| dmakogon_ | you are cunning | 22:45 |
| hub_cap | :P | 22:46 |
| dmakogon_ | https://review.openstack.org/#/c/45723/ - can you take a look at this one | 22:46 |
| dmakogon_ | this is not related to cleanup | 22:46 |
| *** vipul is now known as vipul-away | 22:47 | |
| dmakogon_ | hub_cap: and this https://review.openstack.org/#/c/48305/ | 22:47 |
| *** vipul-away is now known as vipul | 22:47 | |
| hub_cap | yes in a while. i need to do a little coding | 22:47 |
| dmakogon_ | ok | 22:48 |
| dmakogon_ | cu, tommorow | 22:48 |
| dmakogon_ | going to sleep | 22:48 |
| hub_cap | cu | 22:49 |
| *** dmakogon_ has quit IRC | 22:50 | |
| *** adrian_otto has quit IRC | 22:53 | |
| *** adrian_otto has joined #openstack-trove | 22:53 | |
| *** paul_lodronio has left #openstack-trove | 22:55 | |
| *** jmontemayor has quit IRC | 22:57 | |
| openstackgerrit | Conrad Weidenkeller proposed a change to openstack/trove-integration: blueprint redis-base-image https://review.openstack.org/49284 | 22:59 |
| *** krow has joined #openstack-trove | 23:03 | |
| hub_cap | cweid: ^ ^ | 23:03 |
| cweid | oh nifty you guys are so fancy... | 23:04 |
| hub_cap | hey i ddint post this earlier but its somethig to lol at | 23:11 |
| hub_cap | https://review.openstack.org/#/c/49195/ | 23:11 |
| hub_cap | robot submitted it, robot ran the tests, which failed, and robot commented "I noticed tempest failed, I think you hit bug ..." | 23:11 |
| hub_cap | so -infra has built conversations into its gerrit stuff lol | 23:11 |
| *** krow has quit IRC | 23:12 | |
| *** tanisdl has quit IRC | 23:25 | |
| *** vipul is now known as vipul-away | 23:38 | |
| *** krow has joined #openstack-trove | 23:38 | |
| *** vipul-away is now known as vipul | 23:41 | |
| *** krow has quit IRC | 23:42 | |
| *** yidclare has quit IRC | 23:43 | |
| *** krow has joined #openstack-trove | 23:44 | |
| *** yidclare has joined #openstack-trove | 23:46 | |
| *** krow has quit IRC | 23:46 | |
| *** yidclare has quit IRC | 23:48 | |
| *** adrian_otto has quit IRC | 23:48 | |
| *** adrian_otto has joined #openstack-trove | 23:57 | |
| *** adrian_otto has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
