*** yogeshmehra has quit IRC | 00:13 | |
*** yogeshmehra has joined #openstack-trove | 00:14 | |
*** yogeshmehra has quit IRC | 00:18 | |
*** matsuhashi has joined #openstack-trove | 00:18 | |
*** nosnos has joined #openstack-trove | 00:34 | |
openstackgerrit | Auston McReynolds proposed a change to openstack/trove: User-Create Host Does Not Allow Wildcarded Octet https://review.openstack.org/54216 | 00:57 |
---|---|---|
openstackgerrit | Auston McReynolds proposed a change to openstack/trove: User-Create Host Does Not Allow Wildcarded Octet https://review.openstack.org/54216 | 01:02 |
openstackgerrit | Auston McReynolds proposed a change to openstack/trove: User-Create Host Does Not Allow Wildcarded Octet https://review.openstack.org/54216 | 01:09 |
*** demorris has quit IRC | 01:18 | |
*** lnxnut has joined #openstack-trove | 01:20 | |
*** amcrn has quit IRC | 01:23 | |
*** amytron has quit IRC | 01:24 | |
*** anteaya has quit IRC | 01:43 | |
*** haomaiwang has quit IRC | 01:54 | |
*** haomaiwang has joined #openstack-trove | 01:54 | |
*** haomaiwa_ has joined #openstack-trove | 01:58 | |
*** haomaiwang has quit IRC | 01:59 | |
*** erkules_ has joined #openstack-trove | 02:07 | |
*** erkules has quit IRC | 02:09 | |
*** SnowDust has joined #openstack-trove | 02:52 | |
*** jasonb365 has joined #openstack-trove | 03:00 | |
*** matsuhashi has quit IRC | 03:20 | |
*** matsuhashi has joined #openstack-trove | 03:21 | |
*** SnowDust has quit IRC | 03:24 | |
*** matsuhashi has quit IRC | 03:25 | |
*** lnxnut has quit IRC | 03:43 | |
*** lnxnut has joined #openstack-trove | 03:43 | |
*** lnxnut has quit IRC | 03:48 | |
*** cp16net-home has joined #openstack-trove | 03:52 | |
*** jasonb365 has quit IRC | 03:55 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: changing the routes for the api to be clear https://review.openstack.org/54224 | 04:13 |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: making the bin scripts called with main() https://review.openstack.org/54225 | 04:13 |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: Fixes trove-api daemon fake mode functionality. https://review.openstack.org/51262 | 04:13 |
*** openstackgerrit has quit IRC | 04:36 | |
*** openstackgerrit has joined #openstack-trove | 04:36 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: Fixes trove-api daemon fake mode functionality. https://review.openstack.org/51262 | 04:41 |
*** matsuhashi has joined #openstack-trove | 04:42 | |
*** adrian_otto has joined #openstack-trove | 04:47 | |
*** yogeshmehra has joined #openstack-trove | 04:52 | |
*** matsuhashi has quit IRC | 05:02 | |
*** matsuhashi has joined #openstack-trove | 05:03 | |
*** demorris has joined #openstack-trove | 05:06 | |
*** SushilKM has joined #openstack-trove | 05:06 | |
*** matsuhashi has quit IRC | 05:08 | |
*** coolsvap has joined #openstack-trove | 05:09 | |
*** yogeshmehra has quit IRC | 05:12 | |
*** yogeshmehra has joined #openstack-trove | 05:12 | |
*** yogeshme_ has joined #openstack-trove | 05:13 | |
*** yogeshmehra has quit IRC | 05:13 | |
*** cp16net-home has quit IRC | 05:28 | |
*** erkules_ is now known as erkules | 05:39 | |
openstackgerrit | Vipul Sabhaya proposed a change to openstack/trove: Fix bug in Security Group association to Instance https://review.openstack.org/54235 | 05:41 |
*** yogeshme_ has quit IRC | 05:45 | |
*** demorris has quit IRC | 05:47 | |
*** yogeshme_ has joined #openstack-trove | 05:48 | |
*** esp has left #openstack-trove | 06:08 | |
*** SushilKM has quit IRC | 06:12 | |
*** SushilKM has joined #openstack-trove | 06:15 | |
*** haomaiwa_ has quit IRC | 06:18 | |
*** haomaiwang has joined #openstack-trove | 06:19 | |
*** adrian_otto has quit IRC | 06:20 | |
*** tanisdl_ has joined #openstack-trove | 06:26 | |
*** tanisdl has quit IRC | 06:28 | |
*** yidclare has quit IRC | 06:28 | |
*** david-lyle has quit IRC | 06:28 | |
*** tanisdl_ is now known as tanisdl | 06:28 | |
*** yidclare has joined #openstack-trove | 06:29 | |
*** david-lyle has joined #openstack-trove | 06:30 | |
*** SnowDust has joined #openstack-trove | 06:35 | |
*** haomaiwang has quit IRC | 06:40 | |
*** haomaiwang has joined #openstack-trove | 06:40 | |
*** SushilKM has quit IRC | 06:45 | |
*** yogeshme_ has quit IRC | 06:52 | |
*** coolsvap has quit IRC | 07:04 | |
*** denis_makogon has joined #openstack-trove | 07:05 | |
*** EmilienM has quit IRC | 07:22 | |
*** denis_makogon_ has joined #openstack-trove | 07:24 | |
*** ashestakov has joined #openstack-trove | 07:24 | |
*** EmilienM has joined #openstack-trove | 07:25 | |
*** denis_makogon has quit IRC | 07:26 | |
*** coolsvap has joined #openstack-trove | 07:57 | |
*** ashestakov has quit IRC | 08:04 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 08:17 |
*** nosnos_ has joined #openstack-trove | 08:29 | |
*** haomaiwa_ has joined #openstack-trove | 08:30 | |
*** SushilKM has joined #openstack-trove | 08:30 | |
*** nosnos has quit IRC | 08:30 | |
*** haomaiwang has quit IRC | 08:32 | |
*** denis_makogon_ has quit IRC | 08:46 | |
*** nosnos has joined #openstack-trove | 09:02 | |
*** nosnos_ has quit IRC | 09:03 | |
*** radez_g0n3 is now known as radez | 09:57 | |
*** ashestakov has joined #openstack-trove | 10:05 | |
*** nosnos has quit IRC | 10:31 | |
*** nosnos has joined #openstack-trove | 10:32 | |
*** nosnos has quit IRC | 10:36 | |
openstackgerrit | nilakhya proposed a change to openstack/trove: Pluggable Extentions using multiple routes https://review.openstack.org/54280 | 10:38 |
*** ppenjoy has joined #openstack-trove | 11:04 | |
*** ppenjoy has left #openstack-trove | 11:04 | |
*** dukhlov has quit IRC | 11:06 | |
*** dukhlov has joined #openstack-trove | 11:06 | |
*** radez is now known as radez_g0n3 | 11:31 | |
*** SushilKM has quit IRC | 11:37 | |
*** SushilKM has joined #openstack-trove | 11:44 | |
openstackgerrit | nilakhya proposed a change to openstack/trove: Pluggable Extentions using multiple routes https://review.openstack.org/54280 | 11:54 |
*** pdmars has joined #openstack-trove | 12:03 | |
*** pdmars has quit IRC | 12:10 | |
*** pdmars has joined #openstack-trove | 12:20 | |
*** demorris has joined #openstack-trove | 12:24 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/54315 | 12:32 |
*** demorris has quit IRC | 12:33 | |
*** haomaiwa_ has quit IRC | 12:42 | |
*** haomaiwang has joined #openstack-trove | 12:42 | |
*** debasish has joined #openstack-trove | 12:46 | |
*** Barker has joined #openstack-trove | 13:03 | |
*** jcru has joined #openstack-trove | 13:08 | |
*** anteaya has joined #openstack-trove | 13:10 | |
*** SushilKM has quit IRC | 13:51 | |
*** radez_g0n3 is now known as radez | 13:52 | |
*** adrian_otto has joined #openstack-trove | 13:52 | |
*** coolsvap has quit IRC | 13:54 | |
*** robertmy_ has joined #openstack-trove | 13:58 | |
*** robertmyers has joined #openstack-trove | 13:59 | |
*** robertmy_ has quit IRC | 13:59 | |
*** robertmy_ has joined #openstack-trove | 14:02 | |
*** robertmyers has quit IRC | 14:02 | |
*** robertmy_ is now known as robertmyers | 14:03 | |
*** grapex has joined #openstack-trove | 14:03 | |
*** amytron has joined #openstack-trove | 14:04 | |
*** lnxnut has joined #openstack-trove | 14:30 | |
*** amytron has quit IRC | 14:34 | |
*** amytron has joined #openstack-trove | 14:35 | |
*** datsun180b has joined #openstack-trove | 14:37 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/python-troveclient: adds support for configurations management https://review.openstack.org/53169 | 14:49 |
ikhudoshyn | cp16net: ping | 14:50 |
cp16net | ikhudoshyn: hi | 14:50 |
cp16net | whoops | 14:50 |
cp16net | pong | 14:50 |
ikhudoshyn | cp16net: pls find my answer on ur comment https://review.openstack.org/#/c/53378/ | 14:51 |
cp16net | ahhhh | 14:51 |
cp16net | until conductor changes that.. | 14:51 |
cp16net | :-P | 14:51 |
*** jasonb365 has joined #openstack-trove | 14:53 | |
cp16net | dmakogon: ping | 14:54 |
ikhudoshyn | i look forward to when it happens too)) | 14:54 |
cp16net | yeah it looks close to being done | 14:54 |
cp16net | rather merged | 14:55 |
dmakogon | cp16net, pong | 14:58 |
dmakogon | cp16net, 'sup ? | 14:58 |
*** coolsvap has joined #openstack-trove | 14:58 | |
*** openstackgerrit has quit IRC | 15:00 | |
*** openstackgerrit has joined #openstack-trove | 15:01 | |
*** SnowDust has quit IRC | 15:07 | |
*** adrian_otto has quit IRC | 15:07 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Fix issue with PBR https://review.openstack.org/54352 | 15:10 |
*** jasonb365 has quit IRC | 15:12 | |
dmakogon | robertmyers, ping | 15:16 |
robertmyers | dmakogon: pong | 15:16 |
dmakogon | https://review.openstack.org/#/c/54315/ | 15:16 |
dmakogon | robertmyers, and also i answered you ML thread | 15:16 |
*** jasonb365 has joined #openstack-trove | 15:17 | |
robertmyers | cool, the review looks nice | 15:18 |
dmakogon | robertmyers, have you received email ? | 15:20 |
robertmyers | I haven't even gotten mine yet :) | 15:20 |
robertmyers | email is ta slow | 15:20 |
robertmyers | :) | 15:20 |
dmakogon | robertmyers, i need to hear your thoughts about placement strategy | 15:22 |
cp16net | dmakogon: hmm so casandra needs the jdk huh? | 15:23 |
dmakogon | cp16net, yes | 15:24 |
cp16net | that sounds odd | 15:24 |
dmakogon | cp16net, and usage of jdk with cassandra is production way | 15:24 |
robertmyers | dmakogon: I would like it if there was just one template directory. But I could be persuaded to have them be separate | 15:24 |
cp16net | i've not used casandra but when i was reading over it seems odd | 15:24 |
cp16net | but ok | 15:24 |
cp16net | i'll remove the -1 | 15:25 |
dmakogon | cp16net, thanks | 15:25 |
robertmyers | the jinja get_tempates can look in mulitple directories too | 15:25 |
dmakogon | robertmyers, using suggested by you placement strategy is not so flexible | 15:26 |
dmakogon | robertmyers, because you need to modify EVN every time you bring new datastore support | 15:26 |
dmakogon | robertmyers, suggested by me is a bit global | 15:27 |
robertmyers | no, you can do ENV.get_template('{data_store}/foo') | 15:27 |
robertmyers | or ENV.get_template('config/foo') | 15:28 |
robertmyers | or ENV.get_template('heat/foo') | 15:28 |
dmakogon | robertmyers, {value} - could be used ? | 15:28 |
robertmyers | no, you'd have to do string replacement | 15:29 |
dmakogon | robertmyers, jinja could work with dynamic variables ? | 15:29 |
robertmyers | like this? | 15:29 |
robertmyers | or ENV.get_template('%s/foo' % data_store) | 15:29 |
dmakogon | robertmyers, i thought that jinja could work with routs without string replacements | 15:30 |
robertmyers | I'll have to consult the docs a bit | 15:30 |
dmakogon | robertmyers, i've spent some time on reading jinja sources, and i understood that jinja could work with complete path, it can't work with dynamic routes | 15:32 |
*** adrian_otto has joined #openstack-trove | 15:33 | |
robertmyers | but you could use select_template | 15:33 |
robertmyers | http://jinja.pocoo.org/docs/api/#jinja2.Environment.select_template | 15:33 |
robertmyers | and pass a number of template paths | 15:33 |
*** tanisdl has quit IRC | 15:34 | |
*** radez is now known as radez_g0n3 | 15:34 | |
*** paul_lodronio has joined #openstack-trove | 15:34 | |
dmakogon | robertmyers, i suppose such select is the same as get | 15:34 |
dmakogon | robertmyers, we have no validation for templates | 15:34 |
robertmyers | ENV.select_template(['data_store/config', 'data_store.config']) | 15:35 |
*** radez_g0n3 is now known as radez | 15:35 | |
robertmyers | is what I'm thinking | 15:35 |
dmakogon | robertmyers, it would bring us to duplicating | 15:36 |
robertmyers | then you could have a flat structure or nested | 15:36 |
robertmyers | no, if finds the first one | 15:36 |
robertmyers | so you go in order of most specific | 15:36 |
dmakogon | robertmyers, as, i suppose, you've seen i'm using paths template defined through config | 15:36 |
*** SushilKM has joined #openstack-trove | 15:37 | |
dmakogon | robertmyers, you are trying to protect yourself from missing template, but idea is to use more global placement strategy that would not be harmful for Trove | 15:38 |
dmakogon | robertmyers, missing configuration template is not so critical, but missing heat template would lead us to big epic fail | 15:39 |
robertmyers | why would it be harmful to just use the directory name in the get_template? | 15:39 |
dmakogon | robertmyers, we have only one path for templates | 15:39 |
robertmyers | dmakogon: yes so inside of that place configuration and heat | 15:40 |
robertmyers | then in get_template('heat/data_store.heat.template') | 15:41 |
dmakogon | robertmyers, but i don't want to use path builder through % | 15:41 |
robertmyers | i'm confused because you already are? | 15:41 |
robertmyers | template_filename = "%s.heat.template" % service_type | 15:42 |
robertmyers | instead template_filename = "heat/%s.heat.template" % service_type | 15:42 |
dmakogon | anyway, i'd like to have it like i did | 15:43 |
robertmyers | dmakogon: i'd like to have it my way too :) | 15:44 |
robertmyers | but this is a really good start | 15:45 |
*** haomaiwang has quit IRC | 15:45 | |
robertmyers | I'd be okay with it | 15:45 |
dmakogon | robertmyers, thanks | 15:45 |
*** haomaiwang has joined #openstack-trove | 15:46 | |
*** aignatov has quit IRC | 15:53 | |
openstackgerrit | Andrey Shestakov proposed a change to openstack/trove: Add support of datastore types https://review.openstack.org/47934 | 15:54 |
dmakogon | robertmyers, ping again) | 15:54 |
dmakogon | robertmyers, about your nit))) point is that we could store template anywhere we want. That is what is thought when i was writing this code. | 15:55 |
*** jrodom has joined #openstack-trove | 16:02 | |
*** robertmy_ has joined #openstack-trove | 16:06 | |
*** robertmyers has quit IRC | 16:06 | |
*** SushilKM has quit IRC | 16:06 | |
robertmy_ | dmakogon: I'm just suggesting that we have one custom path for all templates | 16:08 |
*** robertmy_ is now known as robertmyers | 16:08 | |
robertmyers | you could still put that anywhere you wanted | 16:09 |
dmakogon | robertmyers, i got it, but would be a bit flexible to let admin decide where to store templates ? | 16:09 |
dmakogon | robertmyers, in your case i should store whole directory together | 16:09 |
robertmyers | dmakogon: no we could have sub directories to store the various templates | 16:10 |
robertmyers | either by type or by data_store | 16:10 |
robertmyers | /etc/trove/templates/heat | 16:10 |
robertmyers | /etc/trove/templates/configuration | 16:10 |
robertmyers | or | 16:10 |
robertmyers | /etc/trove/templates/data_store/ | 16:11 |
robertmyers | /etc/trove/templates/mysql/config | 16:11 |
robertmyers | /etc/trove/templates/mysql/heat | 16:11 |
ikhudoshyn | grapex: hi, could u re-approve this pls https://review.openstack.org/#/c/53378/ | 16:14 |
grapex | ikhudoshyn: Done | 16:16 |
ikhudoshyn | grapex: would be great if u re-approve this too (at least when robots +1 it) https://review.openstack.org/#/c/50597/ -- I rebased it against the latest master | 16:16 |
ikhudoshyn | grapex: tnx | 16:17 |
grapex | vipul SlickNik: Any chance you guys could look at some of these? https://review.openstack.org/#/c/45116/ , https://review.openstack.org/#/c/53165/ , https://review.openstack.org/#/c/53381/ | 16:17 |
ikhudoshyn | grapex: btw, do we know what to do with broken integration? | 16:17 |
grapex | ikhudoshyn: I don't. | 16:17 |
*** jasonb365 has quit IRC | 16:27 | |
openstackgerrit | A change was merged to openstack/trove: Add Backup/Restore Checksum Validation https://review.openstack.org/53165 | 16:35 |
*** jasonb365 has joined #openstack-trove | 16:38 | |
*** jasonb365 has quit IRC | 16:40 | |
juice | grapex: you appear to be the sole approver today...this is a minor change but a major fix that is holding up a deployment ->https://review.openstack.org/#/c/54235 | 16:55 |
juice | security groups are not getting assigned to instances - this is a regression bug | 16:56 |
*** esp has joined #openstack-trove | 16:56 | |
vipul | anyone know why the gate is broken? seem to be failing to upload image | 16:57 |
vipul | https://gist.github.com/vipulsabhaya/7218531 | 16:57 |
vipul | I recall some disucssion on this yesterday | 16:57 |
vipul | was there a fix? | 16:58 |
robertmyers | vipul: not yet | 16:58 |
vipul | robertmyers: thx | 17:00 |
vipul | grapex: you'll have to 'trust me' that this works :) https://review.openstack.org/#/c/54235 | 17:00 |
vipul | grapex: need it approved today if possible | 17:00 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 17:01 |
grapex | vipul: Oh no, I believe you. :) | 17:03 |
grapex | vipul: I +2'd, go ahead and approve. | 17:03 |
vipul | awesome thanks grapex | 17:03 |
datsun180b | i hear core is bestowing boons today | 17:04 |
grapex | vipul: no problem | 17:04 |
datsun180b | where do i get in line? | 17:04 |
grapex | vipul SlickNik: Now, if one of you could look at Conductor: https://review.openstack.org/#/c/45116/ | 17:05 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Datastore backup flexibility https://review.openstack.org/52905 | 17:05 |
vipul | grapex: Ok i owe you one, so that's next on my list :) | 17:05 |
dmakogon | guys, could anyone review this one ? https://review.openstack.org/#/c/52666/ | 17:07 |
dmakogon | and this one https://review.openstack.org/#/c/51884/ | 17:07 |
openstackgerrit | A change was merged to openstack/trove: Fix bug in Security Group association to Instance https://review.openstack.org/54235 | 17:08 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/54315 | 17:09 |
ikhudoshyn | vipul: ping | 17:10 |
*** ashestakov has quit IRC | 17:10 | |
ikhudoshyn | vipul: https://review.openstack.org/#/c/53378/ , pls, that was ur -2, now I hope I made it better | 17:11 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 17:11 |
*** haomaiwang has quit IRC | 17:12 | |
*** haomaiwang has joined #openstack-trove | 17:13 | |
dmakogon | vipul, could you please re-approve this one (i rebase it)? https://review.openstack.org/#/c/52905/ | 17:15 |
juice | thanks grapex! | 17:16 |
*** yogeshmehra has joined #openstack-trove | 17:22 | |
dmakogon | Guys, i suppose we are ok with one heat template per datastore type for single instance ? | 17:38 |
yogeshmehra | dmakogon: do we need to discuss on AWS vs OS expressions? | 17:40 |
dmakogon | yogeshmehra, i research a bit, there is no OS resource for instance and volume | 17:41 |
dmakogon | yogeshmehra, so, not there is nothing to discuss | 17:41 |
yogeshmehra | ok... | 17:42 |
dmakogon | https://github.com/openstack/heat/blob/master/heat/engine/resources/instance.py#L611-L612 | 17:42 |
dmakogon | https://github.com/openstack/heat/blob/master/heat/engine/resources/volume.py#L428-L429 | 17:42 |
dmakogon | oh, we need to update volume resource | 17:42 |
dmakogon | yogeshmehra, example https://github.com/openstack/heat-templates/blob/f30713405b1221d86bb6c4af3810597a32a5aca1/hot/F18/NovaInstanceWithCinderVolume_Native.yaml#L48-L58 | 17:44 |
dmakogon | yogeshmehra, are you working on heat template ? | 17:45 |
*** amcrn has joined #openstack-trove | 17:46 | |
dmakogon | yogeshmehra, ping | 17:47 |
SlickNik | esp: rdjenkins gate is broken because of this https://bugs.launchpad.net/ubuntu/+source/python-pbr/+bug/1245676 | 17:55 |
SlickNik | fyi | 17:55 |
*** ashestakov has joined #openstack-trove | 17:55 | |
SlickNik | Once a fix for that gets pushed out, things should start working. | 17:55 |
esp | thx SlickNik | 17:55 |
*** jmontemayor has joined #openstack-trove | 17:55 | |
esp | thought it was me :) | 17:55 |
*** Barker has quit IRC | 17:56 | |
dmakogon | lol | 17:58 |
dmakogon | any idea how to avoid this ? | 17:58 |
dmakogon | everyone should use 0.5.21 | 17:58 |
dmakogon | or someone who did bad commit should be punished after he fixes it | 18:00 |
*** Barker has joined #openstack-trove | 18:01 | |
dmakogon | hm, i have same ubuntu, but i didn't got error | 18:01 |
dmakogon | strange | 18:01 |
*** SushilKM has joined #openstack-trove | 18:05 | |
yogeshmehra | dmakogon: had to step into a meeting | 18:08 |
yogeshmehra | sushilKM is working on heat template | 18:09 |
amcrn | SlickNik: thanks for the info | 18:12 |
*** Barker has quit IRC | 18:12 | |
*** SnowDust has joined #openstack-trove | 18:22 | |
*** jasonb365 has joined #openstack-trove | 18:24 | |
*** jasonb365 has quit IRC | 18:25 | |
*** jasonb365 has joined #openstack-trove | 18:27 | |
*** amytron_ has joined #openstack-trove | 18:32 | |
*** SnowDust has quit IRC | 18:32 | |
*** Barker has joined #openstack-trove | 18:32 | |
*** amytron has quit IRC | 18:33 | |
*** amytron_ is now known as amytron | 18:33 | |
*** SnowDust has joined #openstack-trove | 18:45 | |
*** Barker has quit IRC | 18:46 | |
*** Barker has joined #openstack-trove | 18:51 | |
*** jasonb365 has quit IRC | 18:56 | |
*** jasonb365 has joined #openstack-trove | 18:58 | |
*** jasonb365 has quit IRC | 19:00 | |
*** jasonb365 has joined #openstack-trove | 19:01 | |
*** anteaya has quit IRC | 19:03 | |
*** anteaya has joined #openstack-trove | 19:08 | |
*** denis_makogon has joined #openstack-trove | 19:12 | |
*** SushilKM has quit IRC | 19:14 | |
*** SushilKM has joined #openstack-trove | 19:15 | |
*** coolsvap has quit IRC | 19:17 | |
denis_makogon | anybody home ? | 19:33 |
datsun180b | rax is in meetings | 19:34 |
yogeshmehra | dmakogon: there? | 19:38 |
*** SushilKM has quit IRC | 19:47 | |
*** vipul is now known as vipul-away | 19:49 | |
denis_makogon | yogeshmehra, yes | 19:58 |
yogeshmehra | denis_makogon: https://review.openstack.org/#/c/54315/ | 19:58 |
yogeshmehra | i did not get the intent | 19:58 |
yogeshmehra | is it not duplicate | 19:58 |
denis_makogon | yes this one is not a dublicate | 19:59 |
denis_makogon | this one is implemented in another way suggested by community | 19:59 |
yogeshmehra | ok, but community has been giving comments...on the patchset | 20:00 |
yogeshmehra | why a new patchset? | 20:01 |
SnowDust | why a separate commit :-) ? | 20:04 |
denis_makogon | yogeshmehra, because i'd like to community to decide which one is better, and SnowDust was taking to long to answer all comments | 20:04 |
denis_makogon | SnowDust, you still able to challange me commit | 20:04 |
denis_makogon | *my | 20:04 |
*** harlowja has quit IRC | 20:04 | |
yogeshmehra | denis_makogon: the challenge is, why a new commit? :-) | 20:05 |
denis_makogon | yogeshmehra, SnowDust have you recieved ML with robertmyers complains ? | 20:05 |
*** harlowja has joined #openstack-trove | 20:05 | |
*** vipul-away is now known as vipul | 20:05 | |
denis_makogon | yogeshmehra, stackanalytics.org | 20:05 |
SnowDust | denis_makogon : jinja templating .. point was taken ! | 20:05 |
denis_makogon | good | 20:06 |
SnowDust | and understood .. with ur comments on it | 20:06 |
SnowDust | when u disagreed .. citing community .. and then accepting .. later | 20:06 |
*** mmcdaris has joined #openstack-trove | 20:06 | |
denis_makogon | SnowDust, preasure | 20:06 |
SnowDust | i was following it .. throughout .. | 20:06 |
yogeshmehra | SnowDust: i think the point which is valid is, the delay in responses... | 20:06 |
denis_makogon | personaly, your patchset is better | 20:07 |
denis_makogon | jinja is heavy tank against this task | 20:07 |
SnowDust | yeah i have a brilliant co-author .. Denis M. working with me :-) has to be ! | 20:07 |
denis_makogon | and jinja doing a lot of tasks we really don't nead | 20:07 |
denis_makogon | *need | 20:08 |
SnowDust | :-) then why did u code it ? | 20:08 |
denis_makogon | SnowDust, true, i would add you to Co-author | 20:08 |
denis_makogon | SnowDust, to see reaction | 20:08 |
SnowDust | no .. need ! | 20:08 |
SnowDust | lets conserve energy | 20:08 |
denis_makogon | SnowDust, we still could fight for you patchset | 20:08 |
denis_makogon | ML !! | 20:08 |
denis_makogon | not in chat | 20:09 |
denis_makogon | ML | 20:09 |
denis_makogon | and only | 20:09 |
SnowDust | understand .. | 20:09 |
denis_makogon | robertmyers already started topic for this question | 20:10 |
denis_makogon | SnowDust, have you subscribed on openstack-dev ? | 20:11 |
vipul | denis_makogon: competing patches are not cool - please work with the original author to rework a patchset, not submit a new one cuz maybe you thikn your's is better | 20:11 |
denis_makogon | vipul, i know that, the reason why i didn't push new patchset into SnowDust review is that they are a bit different | 20:12 |
vipul | denis_makogon: what happens if merge both patchsets? | 20:12 |
denis_makogon | vipul, we would have another one way to load templates | 20:13 |
denis_makogon | personaly i don't want to use jinja for this task | 20:13 |
vipul | denis_makogon: they implement the same BP - and take two different approaches | 20:14 |
vipul | denis_makogon: sure, then make a case for why not, and let the original author change it | 20:14 |
denis_makogon | vipul, because we need it fast, this task has status "emergencу" | 20:17 |
denis_makogon | vipul, i suppose we need to range estimate for iit | 20:17 |
denis_makogon | SnowDust, you could take my whole patchset and push it to your review | 20:18 |
denis_makogon | SnowDust, estimate is 1d maximum | 20:18 |
SnowDust | ok i will finish my side of it in few hours from now | 20:19 |
yogeshmehra | denis_makogon: ur patchset, was it worked uponthe review comments on the existing patchset? | 20:20 |
denis_makogon | yes | 20:20 |
denis_makogon | 100% | 20:20 |
yogeshmehra | but then you are syaing u dont agree with that | 20:21 |
denis_makogon | yogeshmehra, me - i don't like it | 20:21 |
denis_makogon | community what's it that way | 20:21 |
*** radez is now known as radez_g0n3 | 20:22 | |
yogeshmehra | sure... | 20:22 |
denis_makogon | huge problem is that noone fights for his own review | 20:22 |
SnowDust | i did say .. that i am limited by the scope of BP .. | 20:23 |
SnowDust | also did ask the PTL to orient the reviewers .. | 20:24 |
denis_makogon | so, in this case could win the race worth review from others ... | 20:24 |
*** jasonb365_ has joined #openstack-trove | 20:24 | |
denis_makogon | jinja is bad dependency | 20:24 |
SnowDust | thats why i opposed it when we were discussing the BP | 20:24 |
robertmyers | denis_makogon: I disagree | 20:24 |
robertmyers | for loading it is much better | 20:25 |
denis_makogon | robertmyers, in proccessor tick jinja looses | 20:25 |
robertmyers | i don't wish to replace the logic of the templates | 20:25 |
SnowDust | jinja is not dependancy here .. but twist :-) | 20:25 |
robertmyers | jinja is just as fase as reading from the os | 20:25 |
*** jasonb365 has quit IRC | 20:25 | |
*** jasonb365_ is now known as jasonb365 | 20:25 | |
robertmyers | jinja caches the templates | 20:25 |
SnowDust | we dont have to twist it .. if it can be done with simplest code pieces which themselves are not complicated | 20:25 |
denis_makogon | robertmyers, not only reading | 20:26 |
denis_makogon | robertmyers, we do we need to cache templates ? | 20:26 |
SnowDust | how caching helps here ? | 20:26 |
SnowDust | when . .the instance creation time is 1000x times more than the template fetch activity ? | 20:26 |
robertmyers | so you don't have to read from the file system each template read | 20:26 |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Adding designate dns support to trove https://review.openstack.org/54412 | 20:27 |
denis_makogon | caching is advantage only at HighLoad systems | 20:27 |
robertmyers | speed isn't the issue is all i'm saying | 20:27 |
SnowDust | robertmyers : why will we cache it here .. when . .the instance creation time is 1000x times more than the template fetch activity | 20:27 |
robertmyers | Jinja will not slow it down | 20:27 |
denis_makogon | robertmyers, same as os | 20:28 |
denis_makogon | what if someday jinja would brake ? | 20:28 |
robertmyers | >> robertmyers, in proccessor tick jinja looses | 20:28 |
vipul | the advantage is that you have a consistent code path for loading dependencies like this | 20:29 |
vipul | we should consider even doing this for the user_data we load | 20:29 |
robertmyers | denis_makogon: what if our simple logic to read from the os has bugs | 20:29 |
robertmyers | vipul: +1 | 20:30 |
denis_makogon | vipul, you not convinced me | 20:30 |
vipul | Ok simple example.. say you want to include the heat template in Trove package, instaed of on the file system | 20:31 |
vipul | how does the current proposal handle that.. | 20:32 |
vipul | it seems that we have a different choices for where to put say a my.cnf template.. but if you want to load a heat template, it better be on the file system | 20:32 |
robertmyers | vipul: that is my point | 20:33 |
denis_makogon | vipul, we have mandatory path, package is also directory in terms of operating system | 20:33 |
robertmyers | we gain the sane loading tools and lose nothing | 20:33 |
denis_makogon | in this case i would like to see optinal algorithms for config loading | 20:33 |
*** mayfield has joined #openstack-trove | 20:35 | |
vipul | i dont' like have different code paths, and having to know that you can only load templates | 20:36 |
vipul | if it's on the filesystem | 20:36 |
*** radez_g0n3 is now known as radez | 20:36 | |
denis_makogon | i quit this discussion until SnowDust will update his review | 20:37 |
denis_makogon | if i made this review i should want to get it merge, ok, concept of my bp is perfect, jinja is our everything, ok)) | 20:39 |
denis_makogon | waiting for comments on review | 20:39 |
denis_makogon | and also it would be nice to get my reviews reviewed | 20:40 |
vipul | there is value in simplifying our code base so deployers don't need to keep track of every minute detail | 20:43 |
vipul | what robertmyers is suggests goes a long way towards that | 20:43 |
denis_makogon | k | 20:44 |
yogeshmehra | so what is gather is: use jinja to load the template...(so that it can be included in the package as other conf files do)...AND the have the template parameters handle the service-type hardcoding | 20:44 |
yogeshmehra | what i gather* | 20:45 |
vipul | yogeshmehra: Yes, we don't have to use Jinja to do what Heat does.. as what's been discussed in the email thread | 20:45 |
vipul | but let's go with a common mechanism for loading these types of dependencies | 20:45 |
yogeshmehra | this will enable us to be consistent...and then load the same template for any number of services (depending on how geneirc we can make our templates)) | 20:46 |
SnowDust | yogeshmehra: update the BP .. so reviewers have clarity | 20:46 |
SnowDust | with this new discussion | 20:46 |
yogeshmehra | robertmyers: does this suffice? | 20:47 |
denis_makogon | yogeshmehra, do not parametrise template with service type, PLEASE !!! | 20:47 |
denis_makogon | 1 template per service type | 20:47 |
robertmyers | yogeshmehra: yes | 20:48 |
yogeshmehra | so this is the point of contention still... | 20:48 |
denis_makogon | yogeshmehra, i suppose we discuss it 3 or more ti,es | 20:48 |
yogeshmehra | yes we did./.. | 20:48 |
denis_makogon | *times | 20:48 |
yogeshmehra | i agree... | 20:48 |
denis_makogon | static templates, fixed parameters, no modifying | 20:48 |
yogeshmehra | denis_makogon: i know what u r saying | 20:49 |
SnowDust | service type will be there in template itself .. and template has its own unique name | 20:49 |
yogeshmehra | i think we discussed this in detail; | 20:49 |
robertmyers | denis_makogon: yes, that is what I want too | 20:49 |
denis_makogon | robertmyers, <3 | 20:49 |
robertmyers | you can even wrap it in {% raw%} {% endraw %} | 20:49 |
robertmyers | to make it so | 20:50 |
yogeshmehra | mysql percona, will have same template... | 20:50 |
yogeshmehra | would they be just the replica.. | 20:50 |
yogeshmehra | except for hardcoded servicetype | 20:50 |
yogeshmehra | i mean same template content but different templates, is it? | 20:51 |
denis_makogon | yogeshmehra, soon percona would desapear as service type | 20:51 |
SnowDust | thats why i hated templating .. as admin perspective ( even if i did a lot of django ) .. they have to understand the noodles and chopsticks | 20:51 |
yogeshmehra | denis_makogon: ok... | 20:51 |
yogeshmehra | SnowDust: lets stay on topic... :-) | 20:51 |
denis_makogon | SnowDust, yes, that is their job | 20:51 |
datsun180b | i don't know that i understand the noodles and chopsticks of the phrase "understand the noodles and chopsticks" | 20:52 |
yogeshmehra | "nuts and bolts" :-) | 20:52 |
denis_makogon | datsun180b, they should know heat | 20:52 |
SnowDust | yogeshmehra: replied to robertmyers on {% raw%} {% endraw %} | 20:52 |
yogeshmehra | oh...silly me | 20:52 |
yogeshmehra | :-) | 20:52 |
yogeshmehra | so is the consensus only on....using the jinja for loading... | 20:53 |
yogeshmehra | ? | 20:53 |
yogeshmehra | plz bear with me... :-) | 20:53 |
denis_makogon | yogeshmehra, what are your estimates to finish ? | 20:53 |
yogeshmehra | SnowDust wanted to finish it in next hour or so | 20:53 |
denis_makogon | yogeshmehra, only jinja | 20:53 |
denis_makogon | yogeshmehra, i hope | 20:54 |
yogeshmehra | but given the timezone he is in... | 20:54 |
yogeshmehra | may be tomorrow | 20:54 |
denis_makogon | k | 20:55 |
denis_makogon | but we need it fast, i suppose | 20:55 |
yogeshmehra | denis_makogon: completely agree +1 | 20:55 |
denis_makogon | SnowDust, when you finish ping me and i'll close my review | 20:56 |
grapex | SnowDust: "Noodles and chopsticks," I like that phrase, I think I'm going to start stealing it. :) | 20:57 |
yogeshmehra | by the way, on AWS vs OS, i think IS is still incomplete, per denis_makogon's point earlier | 20:57 |
SnowDust | sure ! | 20:57 |
yogeshmehra | IS -> OS | 20:57 |
SnowDust | grapex : meant .. when u are hungry .. u dont need to learn the food and the new tool to relish it ! | 20:57 |
denis_makogon | yogeshmehra, i thought this topic closed | 20:57 |
yogeshmehra | denis_makogon: just double checking | 20:57 |
denis_makogon | yogeshmehra, only volume has OS resource | 20:57 |
SnowDust | same is templating with heat concept :D | 20:58 |
grapex | SnowDust: Ah! I like that even better then. :) | 20:58 |
* denis_makogon gone to watch new Elementary episode | 20:59 | |
*** demorris has joined #openstack-trove | 20:59 | |
SnowDust | grapex: dont use in summit ! .. u may be deported hehe | 20:59 |
grapex | SnowDust: The US government has already bribed China to ensure they can get rid of me for at least a week. | 21:00 |
grapex | I think the next Summit should take place on international waters at a semi-disclosed location in the middle of the Pacific. | 21:01 |
*** sbisbee_ has joined #openstack-trove | 21:01 | |
SnowDust | grapex: Guantanamo ? | 21:01 |
grapex | Various companies will send cargo or cruise ships and circle them. | 21:01 |
grapex | SnowDust: That could work too! I heard the beaches there are beautiful. | 21:01 |
grapex | hub_cap actually lived there at one point in his life, you should ask him about it. | 21:02 |
yogeshmehra | denis_makogon: isn't OS:Nova:Server sufficing instance expression in AS? | 21:02 |
SnowDust | http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Nova::Server | 21:02 |
yogeshmehra | AWS?* | 21:02 |
*** saurabhs has joined #openstack-trove | 21:02 | |
SnowDust | this is equivalent of http://docs.openstack.org/developer/heat/template_guide/cfn.html#AWS::EC2::Instance | 21:02 |
SnowDust | but not 100% compatible .. | 21:02 |
denis_makogon | yogeshmehra, did you look at heat code ? | 21:02 |
SnowDust | and thats why modred / robertmyers suggested a change | 21:02 |
*** pdmars has quit IRC | 21:03 | |
vipul | what is missing in OS templates that is implemented in AWS | 21:03 |
yogeshmehra | well...i did bit of dry run around the provisioning | 21:03 |
yogeshmehra | but whats the point? | 21:03 |
yogeshmehra | vipul: yeah, we ar eon that topic... | 21:03 |
robertmyers | SnowDust: I actually don't care about the actual template contents, just was wondering why not | 21:04 |
SnowDust | AWS::CloudFormation::Init < missing in OS::nova::server | 21:04 |
denis_makogon | SnowDust, +1 | 21:04 |
SnowDust | but can be overcome using UserData | 21:04 |
yogeshmehra | yeah... | 21:04 |
vipul | ok.. so there is a workaround | 21:04 |
SnowDust | yeah .. | 21:05 |
SnowDust | need to test that .. | 21:05 |
yogeshmehra | SnowDust: we need tot est that | 21:05 |
yogeshmehra | test that* | 21:05 |
yogeshmehra | crazy finger syndrome...sorry | 21:05 |
denis_makogon | we need heat-master | 21:05 |
yogeshmehra | :-) | 21:05 |
vipul | So if it will actually work, then why not implement it correctly the first time? | 21:06 |
SnowDust | vipul: right .. trying that | 21:06 |
vipul | SnowDust: Ok - just checking.. i heard opposition so just clarifying | 21:06 |
SnowDust | vipul: i did oppose coz it was around the template .. rather around the refactoring i did :-) | 21:07 |
*** erkules has quit IRC | 21:07 | |
*** westmaas has quit IRC | 21:07 | |
*** sbisbee has quit IRC | 21:07 | |
*** hub_cap has quit IRC | 21:07 | |
SnowDust | but .. its for the benefit of community .. so going as per community :-) | 21:07 |
yogeshmehra | denis_makogon: heat-master? | 21:09 |
vipul | SnowDust: +1 | 21:10 |
denis_makogon | yogeshmehra, a guy who knows everything about heat | 21:10 |
*** amytron has quit IRC | 21:11 | |
yogeshmehra | denis_makogon: funny but i thought its a component i don't know about, which gives extra-terrestrial apis for heat... | 21:12 |
yogeshmehra | :-) | 21:12 |
*** amytron has joined #openstack-trove | 21:12 | |
*** erkules has joined #openstack-trove | 21:14 | |
*** westmaas has joined #openstack-trove | 21:14 | |
*** mmcdaris has quit IRC | 21:14 | |
*** hub_cap has joined #openstack-trove | 21:16 | |
*** lnxnut has quit IRC | 21:19 | |
*** radez is now known as radez_g0n3 | 21:22 | |
*** mmcdaris has joined #openstack-trove | 21:24 | |
*** paul_lodronio has left #openstack-trove | 21:26 | |
esmute | Any ideas what is wrong with rd-jenkins? | 21:32 |
openstackgerrit | Jenkins proposed a change to openstack/trove: Updated from global requirements https://review.openstack.org/54433 | 21:33 |
amcrn | esmute: [10:55:08] <SlickNik> esp: rdjenkins gate is broken because of this https://bugs.launchpad.net/ubuntu/+source/python-pbr/+bug/1245676 | 21:34 |
esmute | Thanks amcrn | 21:35 |
datsun180b | oh don't even joke about that update Jenkins | 21:35 |
amcrn | np | 21:35 |
*** jasonb365 has quit IRC | 21:35 | |
esp | thx amcrn ! | 21:35 |
*** harlowja has quit IRC | 21:36 | |
*** harlowja has joined #openstack-trove | 21:37 | |
*** mayfield has quit IRC | 21:38 | |
grapex | datsun180b: https://review.openstack.org/#/c/54436/ | 21:50 |
clarkb | grapex: about that, how are they working now? | 21:50 |
grapex | clarkb: The Trove tests? | 21:51 |
datsun180b | grapex: yeah i saw that | 21:51 |
clarkb | grapex: ya | 21:51 |
datsun180b | i figure i can't hurt your review with my +1 | 21:52 |
grapex | clarkb: Well enough- there is different problem affecting the "reddwarf" gate which runs against a fully stood up VM, but the tests which run with Tox seem to have no problems. | 21:53 |
datsun180b | that problem has something to do with pbr 0.5.22 crying during our disk-image-builder process iirc | 21:54 |
*** yogeshmehra has quit IRC | 21:54 | |
clarkb | datsun180b: is that problem related to 54436? I am trying to understand why that change is necessary when presumably the tests have been running previously. Were we just not running the tests in openstack infra land previously? | 21:55 |
datsun180b | clarkb: sorry, unrelated | 21:56 |
grapex | clarkb: Are the Tox classified as part of "Infra Land?" | 21:56 |
clarkb | grapex: sure as we run tox in infra land | 21:56 |
grapex | clarkb: Ok, then yes. Here's an example: https://review.openstack.org/#/c/45116/ | 21:56 |
datsun180b | 54436 is something we need, i noticed at the end of friday that git-review seemed to have updated our requirements for my patchset, assumedly from global-reqs | 21:57 |
datsun180b | among those changes somehow probo was removed from my reqs | 21:57 |
clarkb | oohhhh it was grandfathered in, I get it now | 21:57 |
datsun180b | https://review.openstack.org/#/c/45116/16..17/test-requirements.txt | 21:58 |
datsun180b | thing is, i didn't ask for those reqs to be updated right then, i have no idea what triggered it | 21:58 |
clarkb | datsun180b: rebase probably | 21:59 |
clarkb | git log should be able to confirm | 22:00 |
grapex | clarkb: So, without that we can't proceed. Is there a problem with merging it? | 22:00 |
clarkb | grapex: nope, I just wanted to make sure I understood why it suddenly needed to go in. I get it now | 22:00 |
grapex | clarkb: Yeah, sorry I missed it earlier. | 22:00 |
grapex | datsun180b: And sorry I didn't really get what you were trying to tell me when you brought this up yesterday. :( | 22:01 |
datsun180b | it's okay, 45116 ps 19 has the reqs it needs | 22:01 |
grapex | datsun180b: I just thought it was another one of your tall tales! | 22:01 |
datsun180b | i'm learning that you have some kind of allergy to in medias res | 22:02 |
*** Barker has quit IRC | 22:02 | |
datsun180b | at least when it comes to my stories | 22:03 |
grapex | datsun180b: I like it for films and plays, just not when you're explaining a technical issue. :) | 22:04 |
datsun180b | i'll take care to cover my context better in the future | 22:05 |
*** robertmyers has quit IRC | 22:07 | |
*** harlowja has quit IRC | 22:08 | |
*** jodom has joined #openstack-trove | 22:19 | |
*** SnowDust has quit IRC | 22:20 | |
*** jrodom has quit IRC | 22:21 | |
*** denis_makogon has quit IRC | 22:21 | |
*** mmcdaris has quit IRC | 22:30 | |
grapex | vipul SlickNik: Any update on this? https://review.openstack.org/#/c/45116/ | 22:45 |
*** datsun180b has quit IRC | 22:48 | |
vipul | grapex: sorry have not had a chance, promise to look though | 22:51 |
vipul | too much firefighting | 22:51 |
*** jcru has quit IRC | 22:52 | |
grapex | vipul: Well, I can sympathize with you on that one. Just try to look at it soon-ish, it would be nice if Datsun180b could get out from under it for awhile. | 22:53 |
*** harlowja has joined #openstack-trove | 23:08 | |
*** grapex has quit IRC | 23:17 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add optional ip address filter for hiding ips https://review.openstack.org/53766 | 23:26 |
*** jmontemayor has quit IRC | 23:36 | |
*** yogeshmehra has joined #openstack-trove | 23:36 | |
*** amytron has quit IRC | 23:40 | |
*** demorris_ has joined #openstack-trove | 23:49 | |
*** jcooley_ has joined #openstack-trove | 23:57 | |
*** demorris has quit IRC | 23:58 | |
*** jesusaurus has quit IRC | 23:58 | |
*** jcooley has quit IRC | 23:58 | |
*** demorris_ is now known as demorris | 23:58 | |
*** jcooley_ is now known as jcooley | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!