| *** adrian_otto1 has joined #openstack-trove | 00:05 | |
| *** jesusaurus has joined #openstack-trove | 00:06 | |
| *** adrian_otto has quit IRC | 00:07 | |
| *** adrian_otto1 has quit IRC | 00:10 | |
| *** yogeshmehra has quit IRC | 00:14 | |
| *** matsuhashi has joined #openstack-trove | 00:30 | |
| *** grapex has joined #openstack-trove | 00:45 | |
| *** grapex has joined #openstack-trove | 00:46 | |
| *** nosnos has joined #openstack-trove | 01:03 | |
| *** amytron has joined #openstack-trove | 01:04 | |
| *** jrodom has joined #openstack-trove | 01:05 | |
| *** grapex has quit IRC | 01:06 | |
| *** jrodom has quit IRC | 01:12 | |
| *** jasonb365 has joined #openstack-trove | 01:20 | |
| *** vipul is now known as vipul-away | 01:31 | |
| *** yidclare has quit IRC | 01:32 | |
| *** vipul-away is now known as vipul | 01:36 | |
| *** saurabhs has quit IRC | 01:39 | |
| *** erkules_ has joined #openstack-trove | 02:05 | |
| *** erkules has quit IRC | 02:08 | |
| *** amcrn has quit IRC | 02:38 | |
| *** saurabhs has joined #openstack-trove | 02:48 | |
| *** lnxnut has joined #openstack-trove | 02:58 | |
| *** anteaya has quit IRC | 03:00 | |
| *** coolsvap has joined #openstack-trove | 03:13 | |
| *** vipul has quit IRC | 03:20 | |
| *** vipul has joined #openstack-trove | 03:21 | |
| *** jasonb365 has quit IRC | 03:23 | |
| *** saurabhs has quit IRC | 03:37 | |
| *** lnxnut has quit IRC | 03:42 | |
| *** lnxnut has joined #openstack-trove | 03:43 | |
| *** lnxnut has quit IRC | 03:47 | |
| *** adrian_otto has joined #openstack-trove | 04:02 | |
| *** vipul is now known as vipul-away | 04:05 | |
| *** harlowja has quit IRC | 04:07 | |
| *** vipul-away is now known as vipul | 04:10 | |
| *** demorris_ has joined #openstack-trove | 04:18 | |
| *** demorris has quit IRC | 04:19 | |
| *** demorris_ is now known as demorris | 04:19 | |
| *** arborism has joined #openstack-trove | 04:37 | |
| *** SnowDust has joined #openstack-trove | 04:47 | |
| *** demorris has quit IRC | 04:52 | |
| *** vipul is now known as vipul-away | 05:02 | |
| *** vipul-away is now known as vipul | 05:19 | |
| *** SnowDust has quit IRC | 05:34 | |
| *** adrian_otto has quit IRC | 05:44 | |
| *** svapneel has joined #openstack-trove | 05:49 | |
| *** coolsvap has quit IRC | 05:50 | |
| *** svapneel has quit IRC | 05:50 | |
| *** coolsvap has joined #openstack-trove | 05:50 | |
| *** denis_makogon has joined #openstack-trove | 06:06 | |
| *** SushilKM has joined #openstack-trove | 06:07 | |
| *** yogeshmehra has joined #openstack-trove | 06:28 | |
| *** SnowDust has joined #openstack-trove | 06:34 | |
| *** ashestakov has quit IRC | 06:40 | |
| *** vipul is now known as vipul-away | 07:06 | |
| *** arborism has quit IRC | 07:30 | |
| *** haomaiwang has quit IRC | 07:47 | |
| *** jaishanker has joined #openstack-trove | 07:47 | |
| *** haomaiwang has joined #openstack-trove | 07:48 | |
| *** erkules_ is now known as erkules | 07:49 | |
| *** denis_makogon has quit IRC | 08:26 | |
| *** yogeshmehra has quit IRC | 08:33 | |
| *** yogeshmehra has joined #openstack-trove | 08:33 | |
| *** yogeshmehra has quit IRC | 08:37 | |
| *** jaishanker has quit IRC | 08:58 | |
| *** matsuhashi has quit IRC | 09:03 | |
| *** matsuhashi has joined #openstack-trove | 09:03 | |
| *** matsuhas_ has joined #openstack-trove | 09:08 | |
| *** matsuhashi has quit IRC | 09:08 | |
| *** jaishanker has joined #openstack-trove | 09:15 | |
| *** ashestakov has joined #openstack-trove | 10:03 | |
| SlickNik | fyi: just figured out what's going on with pbr and the rdjenkins gate after some debugging. | 10:24 |
|---|---|---|
| SlickNik | fyi: https://review.openstack.org/#/c/54510/ | 10:24 |
| SlickNik | fyi: should be able to work on a rdjenkins workaround in the am. | 10:24 |
| dmakogon | SlickNik, nice | 10:30 |
| *** ppenjoy has joined #openstack-trove | 10:31 | |
| *** ppenjoy has left #openstack-trove | 10:31 | |
| *** matsuhas_ has quit IRC | 11:01 | |
| *** matsuhashi has joined #openstack-trove | 11:02 | |
| *** matsuhashi has quit IRC | 11:11 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/54315 | 11:26 |
| *** jaishanker has quit IRC | 11:27 | |
| *** SnowDust has quit IRC | 11:35 | |
| *** SnowDust has joined #openstack-trove | 11:47 | |
| *** matsuhashi has joined #openstack-trove | 12:02 | |
| *** pdmars has joined #openstack-trove | 12:09 | |
| *** pdmars has quit IRC | 12:21 | |
| *** radez_g0n3 is now known as radez | 12:24 | |
| *** nosnos has quit IRC | 12:27 | |
| *** pdmars has joined #openstack-trove | 12:27 | |
| openstackgerrit | nilakhya proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/53499 | 12:40 |
| *** radez is now known as radez_g0n3 | 12:49 | |
| *** SushilKM has quit IRC | 12:55 | |
| openstackgerrit | nilakhya proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/53499 | 12:58 |
| *** anteaya has joined #openstack-trove | 13:00 | |
| *** matsuhashi has quit IRC | 13:07 | |
| *** matsuhashi has joined #openstack-trove | 13:08 | |
| *** matsuhas_ has joined #openstack-trove | 13:09 | |
| *** matsuhashi has quit IRC | 13:10 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/54315 | 13:33 |
| *** amytron has quit IRC | 13:33 | |
| *** haomaiwa_ has joined #openstack-trove | 13:51 | |
| openstackgerrit | nilakhya proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/53499 | 13:53 |
| *** haomaiwang has quit IRC | 13:54 | |
| *** jasonb365 has joined #openstack-trove | 13:57 | |
| *** radez_g0n3 is now known as radez | 13:57 | |
| *** Barker has joined #openstack-trove | 14:09 | |
| *** amytron has joined #openstack-trove | 14:10 | |
| *** robertmyers has joined #openstack-trove | 14:12 | |
| *** coolsvap has quit IRC | 14:12 | |
| *** robertmyers has quit IRC | 14:14 | |
| *** robertmy_ has joined #openstack-trove | 14:14 | |
| *** jcru has joined #openstack-trove | 14:15 | |
| *** jmontemayor has joined #openstack-trove | 14:19 | |
| openstackgerrit | nilakhya proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/53499 | 14:24 |
| *** matsuhas_ has quit IRC | 14:25 | |
| *** matsuhashi has joined #openstack-trove | 14:25 | |
| *** datsun180b has joined #openstack-trove | 14:29 | |
| *** matsuhashi has quit IRC | 14:30 | |
| *** mayfield has joined #openstack-trove | 14:36 | |
| *** haomaiwang has joined #openstack-trove | 14:45 | |
| *** haomaiwa_ has quit IRC | 14:47 | |
| *** adrian_otto has joined #openstack-trove | 14:51 | |
| *** ashestakov has quit IRC | 14:52 | |
| *** SnowDust has quit IRC | 14:58 | |
| *** SnowDust has joined #openstack-trove | 15:00 | |
| SnowDust | can anyone help with reasoning the latest fail logs of jenkins for my patchset https://review.openstack.org/#/c/53499/ | 15:01 |
| datsun180b | SnowDust: I see "common.test_template.TemplateTest.test_heat_template_loading_and_validating" | 15:03 |
| datsun180b | TemplateNotFound: tmpe0lTDx.heat.template | 15:03 |
| robertmy_ | SnowDust: I don't see the reasoning for creating a dummy template. The default template should be moved to the trove/templates so that the jinja packageloader finds it | 15:06 |
| *** Barker has quit IRC | 15:06 | |
| robertmy_ | no need to validate that jinja works with a custom path | 15:06 |
| *** robertmy_ is now known as robertmyers | 15:06 | |
| *** paul_lodronio has joined #openstack-trove | 15:07 | |
| *** mayfield has quit IRC | 15:08 | |
| SnowDust | datsun180b: i saw that .. but reasons ? | 15:10 |
| datsun180b | beats me | 15:10 |
| SnowDust | robertmy_ : we discussed right ? | 15:11 |
| SnowDust | it will be in /etc/trove/heat_templates/ as per the community | 15:11 |
| SnowDust | which discussed and agreed | 15:11 |
| robertmyers | SnowDust: when ? | 15:11 |
| SnowDust | when the blueprint got approved | 15:11 |
| SnowDust | yogeshmehra the owner of the bp can explain well | 15:11 |
| robertmyers | we should only have one template directory. it does not make sense for each template type to create a new directory | 15:12 |
| SnowDust | robertmyers : the reason for external dir was .. | 15:12 |
| SnowDust | not all datastore type/service type templates will come out of the box | 15:13 |
| robertmyers | yes | 15:13 |
| SnowDust | they will be coming from the external code that the implementor can keep properitory | 15:13 |
| robertmyers | that is why you have a config path to set | 15:13 |
| robertmyers | but you only need one | 15:13 |
| SnowDust | it would have been best if we talked this out with hub_cap | 15:14 |
| robertmyers | there is no reason you can't store all the templates in different paths | 15:14 |
| SnowDust | he too was ok with two ... | 15:14 |
| robertmyers | I will | 15:14 |
| SnowDust | robertmyers : many thanks | 15:14 |
| robertmyers | even so you can put the defaults in trove/templates | 15:14 |
| robertmyers | so that out of the box the supported types work | 15:14 |
| SnowDust | if u see my implementation . . | 15:15 |
| robertmyers | eventually all will have a base 'reference' template | 15:15 |
| SnowDust | out of the box originates from the root directory which is external | 15:15 |
| SnowDust | and thats the intent of this BP | 15:15 |
| robertmyers | that makes no sense? | 15:15 |
| robertmyers | the default is the confuse our users? | 15:16 |
| SnowDust | how can .. ? | 15:16 |
| SnowDust | if u keep trove configs there in /etc/trove | 15:16 |
| SnowDust | how does this confuses with heat templates ? | 15:16 |
| SnowDust | heat templates are in their native form .. and have no jinja transformation | 15:17 |
| SnowDust | and /etc/ is well known to all admins | 15:17 |
| robertmyers | I'm not telling you to use jinja to render it | 15:17 |
| robertmyers | just to put it in the common location | 15:17 |
| robertmyers | there is no need for us to use multiple paths | 15:18 |
| SnowDust | robertmyers : did get that .. in previous discussion . .we are just using the jinja's loader | 15:18 |
| robertmyers | i'll bring it up with hub_cap | 15:18 |
| SnowDust | robertmyers: lets talk this when all are here | 15:18 |
| robertmyers | that is all I want to use the jinja loader | 15:19 |
| robertmyers | the first look up is custom path(s) then the last lookup is the package loader | 15:19 |
| SnowDust | its already there in the last patchset :-) as per ur comments .. | 15:19 |
| SnowDust | but .. yeah path thing lets talk | 15:19 |
| robertmyers | Filesystem loaders should come before the package loader | 15:21 |
| *** radez is now known as radez_g0n3 | 15:21 | |
| robertmyers | then all you need to do is place the default in the trove.templates | 15:21 |
| openstackgerrit | Tim Simpson proposed a change to openstack/trove: Fix checksum verification exception. https://review.openstack.org/54565 | 15:21 |
| *** grapex has joined #openstack-trove | 15:23 | |
| SnowDust | but i dont get why will an external directory confuse the user ? | 15:25 |
| SnowDust | who is an admin | 15:25 |
| SnowDust | who knows the configuration files | 15:25 |
| *** yidclare has joined #openstack-trove | 15:25 | |
| SnowDust | trove/templates/ for different types of templates is more confusing | 15:26 |
| *** jmontemayor has quit IRC | 15:26 | |
| *** mayfield has joined #openstack-trove | 15:31 | |
| *** jmontemayor has joined #openstack-trove | 15:37 | |
| *** adrian_otto has quit IRC | 15:38 | |
| *** adrian_otto has joined #openstack-trove | 15:38 | |
| robertmyers | trove/templates in the the main package is the default location for all supported data_store types | 15:41 |
| robertmyers | when an administrator wants to deploy they will most likely need to customize the template and place that in /etc/trove/heat_templates | 15:42 |
| robertmyers | but out of the box it should work without extra setup | 15:43 |
| SnowDust | robertmyers : if u are talking about the deployment scenario | 15:46 |
| SnowDust | where the directory needs to be created additionaly .. | 15:46 |
| SnowDust | lets be sure .. we will use automation to clone / download the code / and copy things from it | 15:47 |
| SnowDust | and even install it | 15:47 |
| SnowDust | but yeah .. lets get more people to talk about it | 15:47 |
| SnowDust | as i am implementing the BP and am not biased in any way | 15:47 |
| SnowDust | what ever is majority will go with it | 15:48 |
| *** Barker has joined #openstack-trove | 15:54 | |
| *** lnxnut has joined #openstack-trove | 16:00 | |
| openstackgerrit | nilakhya proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/53499 | 16:04 |
| *** SushilKM has joined #openstack-trove | 16:12 | |
| SnowDust | trove 101 question .. | 16:33 |
| SnowDust | tox doesnot fail locally .. fails in openstack for py27/ py26 | 16:33 |
| SnowDust | anyone ? | 16:34 |
| datsun180b | well what's the failure | 16:34 |
| SnowDust | but in my case .. it should not fail .. | 16:34 |
| SnowDust | its working so normally locally | 16:34 |
| SnowDust | i can see the test working .. | 16:35 |
| datsun180b | https://gist.github.com/ share your errors with us | 16:35 |
| *** coolsvap has joined #openstack-trove | 16:54 | |
| *** mmcdaris has joined #openstack-trove | 16:55 | |
| SnowDust | datsun180b: http://paste.openstack.org/show/50236/ | 16:55 |
| SnowDust | can anyone help ? http://paste.openstack.org/show/50236/ | 16:56 |
| datsun180b | error: py26 interpreter not found is kind of a big deal, tangent to your problems | 17:00 |
| SnowDust | LOL .. | 17:00 |
| SnowDust | but what abt py 27 | 17:00 |
| SnowDust | it passes right ? | 17:00 |
| openstackgerrit | Tim Simpson proposed a change to openstack/trove: Fix checksum verification exception. https://review.openstack.org/54565 | 17:01 |
| datsun180b | but we build for both interpreters | 17:01 |
| grapex | vipul: Can you look at this? https://review.openstack.org/#/c/54565/ | 17:01 |
| datsun180b | anyway i'm still looking at your results, if i find anything that sticks out i'll let you know | 17:01 |
| SnowDust | datsun180b did u look at the paste fully .. i mean in end i share my tmp directory | 17:06 |
| SnowDust | there its showing the template files .. | 17:06 |
| SnowDust | anyways take ur time | 17:06 |
| *** radez_g0n3 is now known as radez | 17:13 | |
| datsun180b | i wonder if it has anything to do with the way jenkins runs jobs on that machine, you might be quarantined to your workspace | 17:14 |
| *** yogeshmehra has joined #openstack-trove | 17:17 | |
| *** jmontemayor has quit IRC | 17:17 | |
| *** jmontemayor has joined #openstack-trove | 17:23 | |
| SnowDust | datsun180b: did not understand that | 17:25 |
| *** vipul-away is now known as vipul | 17:27 | |
| *** harlowja has joined #openstack-trove | 17:29 | |
| *** SnowDust has quit IRC | 17:35 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add optional ip address filter for hiding ips https://review.openstack.org/53766 | 17:37 |
| *** SnowDust has joined #openstack-trove | 17:47 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Replace GUID with generated password https://review.openstack.org/52525 | 17:50 |
| *** mmcdaris has quit IRC | 17:53 | |
| *** amcrn has joined #openstack-trove | 17:54 | |
| *** mmcdaris has joined #openstack-trove | 17:58 | |
| *** yidclare has quit IRC | 17:58 | |
| datsun180b | i cannot stand that usage test that intermittently fails because of a 1-second delta we i can't control | 18:08 |
| hub_cap | is it a bug that cannot be fixed? | 18:09 |
| robertmyers | we can loosen the check around that time | 18:10 |
| hub_cap | if so we should change the assert to assertAlmostEqual | 18:10 |
| robertmyers | yes | 18:10 |
| hub_cap | but the past few times weve corrected it | 18:10 |
| hub_cap | im just afraid of masking a few second time bug in a assertAlmostEqual call if in fact it is a bug | 18:10 |
| hub_cap | i dont know enough about the use case for wahts going wrong tho | 18:11 |
| datsun180b | it's just a one-second boundary | 18:11 |
| datsun180b | this isn't superman iii, i think we can let one second go | 18:11 |
| robertmyers | I think it might be that we are setting a value in the test at the time of action and checking the actual time | 18:11 |
| datsun180b | ^^ | 18:11 |
| cp16net | there is an open bug for that | 18:13 |
| *** denis_makogon has joined #openstack-trove | 18:13 | |
| SnowDust | can anyone help ? http://paste.openstack.org/show/50236/ | 18:15 |
| SnowDust | plz ... all | 18:15 |
| grapex | datsun180b: Did the moral parable that was Superman III teach you nothing, Datsun!? | 18:16 |
| datsun180b | grapex: oh so now we're capitalizing our handles are we | 18:17 |
| denis_makogon | SnowDust, template not found - wrong path | 18:17 |
| SnowDust | denis_makogon : run tox locally | 18:18 |
| SnowDust | it will pass | 18:18 |
| SnowDust | look at my paste | 18:18 |
| SnowDust | and that baffles | 18:18 |
| denis_makogon | SnowDust, you have wrong configuration | 18:20 |
| denis_makogon | SnowDust, you've broke all template loading system | 18:20 |
| denis_makogon | localy you have /etc/... but at tox doesn't knew anything about that directory | 18:21 |
| denis_makogon | SnowDust, robertmyers post a comment on your review | 18:21 |
| SnowDust | denis_makogon .. look at my test | 18:22 |
| SnowDust | i dont use /etc/ | 18:22 |
| SnowDust | i have stubbed the env there | 18:22 |
| SnowDust | i read robertmyers : and recieved his comments well .. but cannot add another patchset until i understand | 18:23 |
| SnowDust | how tox runs past this without errors locally | 18:23 |
| *** sbisbee_ is now known as sbisbee | 18:23 | |
| denis_makogon | for cursory glance, your test is broken because of incorrect configuration, i suppose you should deal with it | 18:23 |
| SnowDust | denis_makogon : but how my local goes past this ? thats my question .. | 18:25 |
| SnowDust | i will do the patchset right now | 18:25 |
| SnowDust | let me see if that fixes | 18:25 |
| *** SushilKM has quit IRC | 18:27 | |
| robertmyers | SnowDust: the build box is probably placing your temp files somewhere other than /tmp | 18:29 |
| SnowDust | robertmyers: yeah thats the problem .. | 18:29 |
| datsun180b | waugh, i suggested the same thing like an hour ago | 18:29 |
| SnowDust | yeah datsun180b also pointed that | 18:30 |
| robertmyers | but the test you have is sort of useless as you are just testing that jinja works | 18:30 |
| robertmyers | add a default template and fetch it for a success | 18:30 |
| robertmyers | no need for a temporary file | 18:30 |
| SnowDust | but how a developer simulate the rd-jenkins gate ? | 18:31 |
| SnowDust | he wrote and tested in his side .. and it fails upstream . . | 18:32 |
| SnowDust | irrespective of the code's use | 18:32 |
| robertmyers | not all machines temp dirs are the same | 18:32 |
| datsun180b | you're not supposed to be building tests to suit the gate | 18:32 |
| robertmyers | that is the proble | 18:32 |
| SnowDust | datsun180b .. that means .. i should be making best efforts and still be sleepless | 18:34 |
| SnowDust | or should write the code and throw it first to the gate | 18:34 |
| datsun180b | what? | 18:35 |
| SnowDust | as its doing things not as similar to my local | 18:35 |
| robertmyers | SnowDust: the test should be written to avoid using temp files | 18:35 |
| denis_makogon | SnowDust, configure your test correctly | 18:35 |
| denis_makogon | SnowDust, you could do it without temp files | 18:35 |
| SnowDust | ok tx ! | 18:35 |
| SnowDust | robertmyers: tx ! | 18:36 |
| denis_makogon | robertmyers, +1 for avoiding temp files | 18:36 |
| SnowDust | robertmyers> but the test you have is sort of useless as you are just testing that jinja works | 18:42 |
| SnowDust | denis_makogon : is co author of the review .. and thanks to him we have those tests | 18:42 |
| SnowDust | i have just changed it to suite jinja | 18:42 |
| SnowDust | anyways .. working again .. ! | 18:42 |
| denis_makogon | wow SnowDust current tests are not mine))) | 18:42 |
| SnowDust | thats good .. denis_makogon .. :) | 18:42 |
| robertmyers | no, I'm saying you are setting up a completely new jinja env and testing that | 18:43 |
| hub_cap | so ive been out a few days | 18:43 |
| hub_cap | did we decide to use jinja for the heat templates? | 18:43 |
| denis_makogon | robertmyers, could you take a look at my review wit templating ? | 18:43 |
| robertmyers | hub_cap: for template loading | 18:43 |
| denis_makogon | hub_cap, somehow yes | 18:43 |
| robertmyers | not for rendering | 18:43 |
| hub_cap | :o lol we had decided a while ago to not use it cuz the only benefit was template loading | 18:44 |
| denis_makogon | hub_cap, https://review.openstack.org/#/c/54315/ | 18:44 |
| denis_makogon | hub_cap, benefit also caching | 18:44 |
| SnowDust | thanks hub_cap for clarifying that .. i been telling | 18:44 |
| robertmyers | well, template loading is a good feature | 18:44 |
| hub_cap | yes it is robertmyers :) | 18:44 |
| robertmyers | it also makes it easier to follow | 18:44 |
| hub_cap | well im glad we arent using it for templating at least ;) | 18:45 |
| yogeshmehra | hub_cap: the other reason was to make it consistent the way the other service configs are loaded... | 18:45 |
| robertmyers | less custom template loading logic that we have to write | 18:45 |
| denis_makogon | robertmyers, btw i update my review, now it fits to templates/{datastore}/... | 18:46 |
| hub_cap | has anyone been seeing this https://gist.github.com/hub-cap/7237765 | 18:46 |
| hub_cap | warning: LocalManifestMaker: standard file '-c' not found | 18:46 |
| denis_makogon | hub_cap, yes | 18:46 |
| hub_cap | i just fired up a new cloud image and hit this | 18:46 |
| robertmyers | yes | 18:46 |
| hub_cap | is it _our_ issue or upstream? | 18:46 |
| denis_makogon | hub_cap, whole build system is broken | 18:46 |
| robertmyers | upstream | 18:47 |
| hub_cap | is there a review to fix it | 18:47 |
| SnowDust | hub_cap : SlickNik fixed this | 18:47 |
| robertmyers | pbr on ubuntu | 18:47 |
| hub_cap | has their been chatter on the ML? | 18:47 |
| hub_cap | ok SnowDust ill consult SlickNik | 18:47 |
| denis_makogon | about ubuntu and pbr | 18:47 |
| yogeshmehra | denis_makogon: for the information of the community, are we still going ahead with 2 patchsets for the same bp...? | 18:47 |
| denis_makogon | i haven't got issue installing pbr 0.5.22 on 12.04 | 18:47 |
| hub_cap | https://review.openstack.org/#/c/54510/ | 18:48 |
| hub_cap | sweet | 18:48 |
| SlickNik | hub_cap: come to infra right now. Just chatting about it. | 18:48 |
| denis_makogon | yogeshmehra, i'd like to push my changes to SnowDust review | 18:48 |
| hub_cap | i should be in alrady | 18:48 |
| hub_cap | SlickNik: ^ ^ | 18:48 |
| SlickNik | ah, okay cool. :) | 18:48 |
| denis_makogon | SnowDust, could i push my changes to your review ? | 18:48 |
| yogeshmehra | denis_makogon: when do u plan to do it... | 18:49 |
| denis_makogon | yogeshmehra, when SnowDust allows it to do | 18:49 |
| denis_makogon | mine review done like robertmyers offers | 18:49 |
| denis_makogon | and it seams really good way | 18:50 |
| hub_cap | SlickNik: is there a workaround for it currently? | 18:50 |
| denis_makogon | next step after it gets merged i would do the same for cloudinits | 18:50 |
| hub_cap | like, say, install this review and setup develop pbr SlickNik ? | 18:50 |
| SlickNik | hub_cap: it's affecting our guest image build | 18:50 |
| SlickNik | hub_cap: so a manual workaround won't work. | 18:51 |
| SlickNik | mordred is planning to release a new pbr version shortly, so we won't need a workaround. | 18:52 |
| hub_cap | k cool. i can wait for a while | 18:52 |
| cp16net | good | 18:52 |
| mordred | I will release in approx 1 hour | 18:52 |
| cp16net | <3 | 18:52 |
| mordred | it needs to pass gate, and I've got a meeting | 18:52 |
| SlickNik | <3 mordred. | 18:53 |
| hub_cap | mordred: u da man | 19:01 |
| *** Barker has quit IRC | 19:03 | |
| *** Barker has joined #openstack-trove | 19:05 | |
| robertmyers | denis_makogon: I think your implementation is really close | 19:06 |
| *** ashestakov has joined #openstack-trove | 19:09 | |
| denis_makogon | robertmyers, something else ? | 19:10 |
| SnowDust | denis_makogon: why we removed heatkey ? | 19:10 |
| denis_makogon | ssh | 19:10 |
| denis_makogon | we are not supporting it | 19:10 |
| SnowDust | means we will have it disabled even if external services want it ? | 19:11 |
| denis_makogon | robertmyers, thanks, i got it | 19:11 |
| denis_makogon | SnowDust, for now yes | 19:11 |
| * amcrn high-fives SlickNik + mordred, thanks guys for the quick pbr resolution | 19:11 | |
| denis_makogon | i already ask you about usecase of ssh'ing in databases(avoiding HBase, Hive) | 19:12 |
| yogeshmehra | denis_makogon: heat disabled version still supports sshing... | 19:12 |
| denis_makogon | yogeshmehra, trove doesn't support ssh'ing | 19:13 |
| yogeshmehra | yeah, thats right... | 19:13 |
| denis_makogon | yogeshmehra, heat support everything | 19:13 |
| hub_cap | your image supports ssh'ing ;) | 19:13 |
| yogeshmehra | hub_cap: true... | 19:13 |
| yogeshmehra | really a trove-integration part | 19:14 |
| denis_makogon | hub_cap, we already discuss ssh usage in trove | 19:14 |
| denis_makogon | hub_cap, with ashestakov BP | 19:14 |
| yogeshmehra | denis_makogon: so, if my template wants to support sshing... | 19:14 |
| yogeshmehra | i should have a way out.. | 19:14 |
| denis_makogon | yogeshmehra, where does integration uses ssh'ing ?? | 19:14 |
| hub_cap | denis_makogon: im only pointing it out | 19:14 |
| hub_cap | yogeshmehra: u can put a custom template w/ a heat key | 19:14 |
| denis_makogon | hub_cap, yes, but we are talking about databases, not instances/servers | 19:15 |
| hub_cap | the problem w/ the heat key is that _every_ tenant needs access to it | 19:15 |
| yogeshmehra | thats right... | 19:15 |
| denis_makogon | hub_cap, an i wrong ? | 19:15 |
| hub_cap | denis_makogon: im not sure why youre being argumentative :) im agreeing w/ you | 19:15 |
| denis_makogon | hub_cap, hah | 19:15 |
| hub_cap | ssh is not a feature of trove, its a feature of the development image we built | 19:15 |
| denis_makogon | hub_cap, i missed it =))) | 19:15 |
| hub_cap | thats it :) | 19:15 |
| denis_makogon | hub_cap, sorry i'm a bit tired | 19:16 |
| hub_cap | denis_makogon: :P | 19:16 |
| denis_makogon | hub_cap, how was your travel ? | 19:16 |
| yogeshmehra | so, in that case, instead of coming as param...it will be hardcoded into template...? | 19:16 |
| denis_makogon | yogeshmehra, no | 19:16 |
| denis_makogon | yogeshmehra, we are avoiding ssh | 19:16 |
| SnowDust | that means .. for ssh u need to modify two places images / heat-templates | 19:16 |
| denis_makogon | yogeshmehra, at all (i suppose until someone brings usecase) | 19:17 |
| yogeshmehra | SnowDust: +1 | 19:17 |
| SnowDust | as you authored the mysql one without support for ssh port | 19:17 |
| yogeshmehra | denis_makogon: i am not saying that it should be built into trove...inc ase somebody wants it... | 19:17 |
| hub_cap | denis_makogon: this time i didnt travel :) i took time off because of family | 19:17 |
| yogeshmehra | anyways... | 19:17 |
| yogeshmehra | i understand.. | 19:17 |
| denis_makogon | anyway, by security rules you are closing everything and leave 3306 | 19:17 |
| hub_cap | yogeshmehra: we are purposefully leaving it out | 19:18 |
| yogeshmehra | sure... | 19:18 |
| yogeshmehra | but the custom template can still do it... | 19:18 |
| hub_cap | if you add it in, u need to add in a call to nova to register a ssh key w/ every tenant first | 19:18 |
| hub_cap | no it cant alone | 19:18 |
| hub_cap | u need waht i just said | 19:18 |
| yogeshmehra | yup | 19:18 |
| denis_makogon | yogeshmehra, if somebody wants it, he should be able to write his own template | 19:18 |
| yogeshmehra | thats true | 19:18 |
| hub_cap | well it can if u just use userdata | 19:18 |
| denis_makogon | hub_cap, oh, i suppose everything is ok | 19:18 |
| hub_cap | but if u register the same key w/ every tenant, how secure is it really? :) why not just put it in your image build instead and not worry about the extra step to call nova | 19:19 |
| denis_makogon | hub_cap, have you finished you CAD modeling ? | 19:19 |
| hub_cap | denis_makogon: yes it is | 19:19 |
| hub_cap | denis_makogon: almost. i had to find the electrical diagrams so i could do the electrical modeling | 19:19 |
| yogeshmehra | hub_cap: +1 | 19:19 |
| hub_cap | yogeshmehra: so technically, we are opinionated about "not" adding heat key support in the app ;) | 19:20 |
| denis_makogon | hub_cap, oh, yeah electricity, good luck in it) | 19:20 |
| yogeshmehra | hub_cap: i understand...thanks... :-) | 19:20 |
| denis_makogon | yogeshmehra, if you want ssh, use userdata) | 19:20 |
| denis_makogon | yogeshmehra, easy) | 19:21 |
| yogeshmehra | yeah, thanks | 19:21 |
| *** vipul is now known as vipul-away | 19:25 | |
| *** vipul-away is now known as vipul | 19:25 | |
| SnowDust | reviews ...https://review.openstack.org/#/c/54280/ | 19:26 |
| *** SnowDust has quit IRC | 19:30 | |
| *** SnowDust has joined #openstack-trove | 19:51 | |
| SlickNik | /join #openstack-meeting-alt | 19:58 |
| SlickNik | meeting time again | 19:59 |
| datsun180b | ValueError: Status description potato salad is not a valid ServiceStatus. | 20:01 |
| datsun180b | that should be expected | 20:01 |
| esp | lol | 20:02 |
| *** tanisdl has joined #openstack-trove | 20:06 | |
| *** adrian_otto has quit IRC | 20:07 | |
| *** saurabhs has joined #openstack-trove | 20:09 | |
| *** saurabhs has left #openstack-trove | 20:09 | |
| *** mayfield has quit IRC | 20:12 | |
| *** mayfield has joined #openstack-trove | 20:12 | |
| *** paul_lodronio has left #openstack-trove | 20:15 | |
| *** yidclare has joined #openstack-trove | 20:24 | |
| *** yidclare has quit IRC | 20:25 | |
| *** SnowDust has quit IRC | 20:31 | |
| *** yidclare has joined #openstack-trove | 20:40 | |
| mordred | SlickNik: hey | 20:55 |
| *** demorris has joined #openstack-trove | 20:56 | |
| mordred | SlickNik: I can't release for another couple of hours - I'm behind a stupid firewall right now | 20:56 |
| * hub_cap is sad mordred | 20:56 | |
| mordred | hub_cap: be sad about the firewall | 20:56 |
| mordred | I also don't have my gpg key on any of my cloud servers (for obvious reasons) | 20:56 |
| mordred | so I'd have to figure out the stuff that people do to work behidn this thing, which I'm just flat not going to do | 20:57 |
| hub_cap | oh well yes mordred, im no longer sad | 20:57 |
| SlickNik | mordred: okay, thanks for the heads up. | 20:57 |
| mordred | SlickNik: I'll do it as soon as I'm in my hotel | 20:57 |
| hub_cap | <3 mordred | 20:58 |
| hub_cap | ok my folks are chomping at the bit to "do something" | 20:58 |
| SlickNik | mordred: awesome thanks! | 20:58 |
| hub_cap | so im off for the aftn | 20:58 |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Support datastore types https://review.openstack.org/47936 | 20:58 |
| ashestakov | hub_cap: grapex vipul ^ ^ | 20:59 |
| mordred | SlickNik: clarkb is going to do it | 21:00 |
| SlickNik | mordred: cool, even better thx! | 21:01 |
| *** Barker has quit IRC | 21:03 | |
| vipul | amcrn please put your thoughts in ^ | 21:04 |
| amcrn | vipul: ok | 21:04 |
| vipul | ashestakov: i don't see the change from datastore_type -> datastore | 21:04 |
| ashestakov | that was not joke... | 21:04 |
| vipul | i dont' think so :) | 21:05 |
| vipul | amcrn: ? | 21:05 |
| amcrn | lol | 21:05 |
| amcrn | it wasn't a joke, no | 21:05 |
| amcrn | i think the word "datastore" makes the right answer seem less obvious. if we had used "engine", does /engines sound correct, or /engine_types? | 21:06 |
| ashestakov | why not type? | 21:06 |
| ashestakov | that exactly types | 21:07 |
| amcrn | ? | 21:07 |
| amcrn | by making /datastore a resource, intrinsically it's assumed that there are multiple datastores, which can only mean each has a distinguishing feature or attribute | 21:08 |
| amcrn | in this case, that's it's type, or engine_type, or whatever classifier you want to use | 21:08 |
| amcrn | in short, "_type" is redundant | 21:09 |
| ashestakov | can we get agreement that this is last rename? | 21:09 |
| vipul | +1 to '/datastores' | 21:10 |
| vipul | +1 to what amcrn said in the meeting.. which is below | 21:10 |
| vipul | from amcrn: /datastores is a summary of all datastores, /datastores/:id is a summary of one datastore, /datastores/:id/versions is for a list of versions for one datastore, and /datastores/:id/versions/:id is the verbose information for a particular version of a datastore | 21:10 |
| ashestakov | amcrn: vipul, can i keep datastore_type and DatastoreType in code? | 21:12 |
| *** pdmars has quit IRC | 21:12 | |
| vipul | Don't think we should.. be consistent with the routes | 21:12 |
| ashestakov | if "datastore" means type, what name do you like for version? | 21:13 |
| amcrn | not sure I follow? | 21:14 |
| ashestakov | and how to name parameter on cli? | 21:14 |
| ashestakov | --datastore Mysql --??? 5.5.32 | 21:14 |
| amcrn | is there already an established precedent in another openstack cli? | 21:15 |
| amcrn | (talking out loud, i can't think of one off-hand) | 21:15 |
| amcrn | --size isn't qualified as --volume_size, although arguably it should have; so considering that there are likely to be other versionable assets in the future, I'd hazard a guess of --datastore-version | 21:17 |
| amcrn | rather, --datastore_version (since --availability_zone already set the underscore precedent) | 21:18 |
| *** radez is now known as radez_g0n3 | 21:19 | |
| ashestakov | and? | 21:21 |
| amcrn | hrm, actually, it looks like all other clis use hyphen vs. underscore, that should probably be fixed in the trove cli | 21:22 |
| amcrn | so assuming that's agreed upon, my vote is for --datastore-version. if underscore stays, then --datastore_version | 21:23 |
| amcrn | (unless someone else has an opinion on the matter) | 21:23 |
| ashestakov | --datastore and --datastore-version? | 21:23 |
| amcrn | assuming the underscore to hyphen migration, yes. | 21:24 |
| amcrn | otherwise, --datastore and --datastore_version | 21:24 |
| datsun180b | it'll get eaten by argumentparser and interpreted as an underscore anyway iirc | 21:24 |
| ashestakov | how to name parameters in "datastore" group ? | 21:24 |
| SlickNik | ashestakov / amcrn: I'd prefer to stay consistent with other clients and use - instead of _ | 21:24 |
| amcrn | +1 SlickNik | 21:25 |
| amcrn | ashestakov: what do you mean by "datastore group"? | 21:25 |
| ashestakov | i asking not about - or _, i trying to understand if you are not ok with _type, how to name it insttead? | 21:25 |
| amcrn | datastore_type => datastore | 21:26 |
| ashestakov | now for create instance we have datastore object with {type, version} parameters | 21:26 |
| amcrn | oh, you're asking from a api/json perspective? | 21:26 |
| ashestakov | yes | 21:27 |
| amcrn | that shouldn't need to change | 21:27 |
| ashestakov | and another question - have i rename variables and class names in code? | 21:27 |
| amcrn | per vipul's comment earlier, you should follow the conventions that preceded you | 21:28 |
| ashestakov | what exactly? | 21:30 |
| vipul | ashestakov: try to name classes in the CLI as close as possible to the Routes defined | 21:36 |
| *** robertmyers has quit IRC | 21:36 | |
| ashestakov | are DatastoreType DatastoreVersion not ok? | 21:37 |
| *** demorris has quit IRC | 21:38 | |
| vipul | how about just Datastore and DatastoreVersion | 21:38 |
| ashestakov | stupid for me, but i want just to finish this stuff | 21:40 |
| *** mayfield has quit IRC | 21:46 | |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Support datastore types https://review.openstack.org/47936 | 21:52 |
| ashestakov | vipul: amcrn ^ ^ | 21:52 |
| *** adrian_otto has joined #openstack-trove | 22:01 | |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Support datastore types https://review.openstack.org/47936 | 22:02 |
| *** ashestakov has quit IRC | 22:03 | |
| *** amytron_ has joined #openstack-trove | 22:04 | |
| *** amytron has quit IRC | 22:05 | |
| *** amytron_ is now known as amytron | 22:05 | |
| *** yogeshmehra has quit IRC | 22:05 | |
| *** grapex has quit IRC | 22:05 | |
| *** grapex has joined #openstack-trove | 22:07 | |
| *** grapex has quit IRC | 22:08 | |
| *** grapex has joined #openstack-trove | 22:08 | |
| openstackgerrit | Ed Cranford proposed a change to openstack/trove: Conductor proxies host db access for guests https://review.openstack.org/45116 | 22:25 |
| datsun180b | that ought to do it | 22:26 |
| *** datsun180b has quit IRC | 22:26 | |
| *** amytron has quit IRC | 22:34 | |
| denis_makogon | vipul, could you please retrigg this reviews ? https://review.openstack.org/#/c/52905/ https://review.openstack.org/#/c/53876/ https://review.openstack.org/#/c/51884/ | 22:35 |
| denis_makogon | vipul, it would be very nice) | 22:36 |
| *** jcru has quit IRC | 22:58 | |
| *** AGiardini has quit IRC | 23:09 | |
| *** grapex has quit IRC | 23:10 | |
| *** Barker has joined #openstack-trove | 23:13 | |
| *** jasonb365 has quit IRC | 23:17 | |
| *** Barker has quit IRC | 23:24 | |
| *** denis_makogon has quit IRC | 23:24 | |
| *** Barker has joined #openstack-trove | 23:26 | |
| *** jmontemayor has quit IRC | 23:27 | |
| *** adrian_otto has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!