*** amytron has quit IRC | 00:01 | |
*** jimbobhickville has quit IRC | 00:05 | |
*** edmund has quit IRC | 00:20 | |
*** rnirmal has quit IRC | 00:45 | |
*** radez_g0n3 is now known as radez | 00:45 | |
*** nosnos has joined #openstack-trove | 01:59 | |
*** yogesh has quit IRC | 02:21 | |
*** amcrn has joined #openstack-trove | 02:40 | |
*** mat-lowery has joined #openstack-trove | 02:46 | |
*** erkules_ has joined #openstack-trove | 02:53 | |
*** amytron has joined #openstack-trove | 02:53 | |
*** erkules has quit IRC | 02:55 | |
*** mat-lowe_ has joined #openstack-trove | 02:58 | |
*** mat-lowery has quit IRC | 02:58 | |
*** mat-lowe_ has quit IRC | 03:02 | |
*** mat-lowery has joined #openstack-trove | 03:03 | |
*** mat-lowe_ has joined #openstack-trove | 03:04 | |
*** radez is now known as radez_g0n3 | 03:06 | |
*** mat-lowery has quit IRC | 03:08 | |
openstackgerrit | Mat Lowery proposed a change to openstack/trove: Get service endpoints from catalog. https://review.openstack.org/68015 | 03:24 |
---|---|---|
*** mattgriffin has quit IRC | 04:17 | |
*** yogesh_ has joined #openstack-trove | 04:27 | |
*** yogesh has joined #openstack-trove | 04:30 | |
*** yogesh_ has quit IRC | 04:34 | |
*** mattgriffin has joined #openstack-trove | 04:40 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 05:06 | |
*** SushilKM has joined #openstack-trove | 05:44 | |
openstackgerrit | Mat Lowery proposed a change to openstack/trove: Get service endpoints from catalog https://review.openstack.org/68015 | 05:49 |
*** SergeyLukjanov is now known as SergeyLukjanov_a | 06:12 | |
*** SergeyLukjanov_a is now known as SergeyLukjanov_ | 06:13 | |
*** rongze has joined #openstack-trove | 06:26 | |
*** haomaiwa_ has quit IRC | 06:36 | |
*** haomaiwang has joined #openstack-trove | 06:36 | |
*** amytron has quit IRC | 06:38 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 06:42 | |
*** haomaiwa_ has joined #openstack-trove | 06:45 | |
*** haomaiwang has quit IRC | 06:48 | |
*** haomaiwa_ has quit IRC | 06:56 | |
*** haomaiwang has joined #openstack-trove | 06:56 | |
*** haomaiwa_ has joined #openstack-trove | 06:59 | |
*** haomaiwang has quit IRC | 07:01 | |
*** mat-lowe_ has quit IRC | 07:15 | |
*** mat-lowery has joined #openstack-trove | 07:20 | |
*** mat-lowery has quit IRC | 07:26 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 07:29 | |
*** amcrn has quit IRC | 07:45 | |
*** mattgriffin has quit IRC | 07:54 | |
*** erkules_ is now known as erkules | 08:04 | |
*** flaper87|afk is now known as flaper87 | 08:14 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 08:37 | |
*** mattgriffin has joined #openstack-trove | 08:37 | |
shalini_ | denis_makogon: There? | 08:48 |
openstackgerrit | shivam shukla proposed a change to openstack/trove: Tests for heat based instance workflow https://review.openstack.org/66499 | 08:54 |
*** krast has joined #openstack-trove | 08:57 | |
*** SnowDust has joined #openstack-trove | 08:59 | |
SnowDust | denis_makogon : there ? | 09:00 |
*** mattgriffin has quit IRC | 09:00 | |
*** krast has quit IRC | 10:34 | |
*** krast has joined #openstack-trove | 10:36 | |
openstackgerrit | Eugeniya Kudryashova proposed a change to openstack/python-troveclient: Use HTTPClient from common Oslo code https://review.openstack.org/68065 | 10:45 |
openstackgerrit | Eugeniya Kudryashova proposed a change to openstack/python-troveclient: Update to the latest code from Oslo https://review.openstack.org/64439 | 10:45 |
openstackgerrit | Eugeniya Kudryashova proposed a change to openstack/python-troveclient: Replaced troveclient.exceptions with common.apiclient.exceptions https://review.openstack.org/65956 | 10:45 |
*** rongze has quit IRC | 10:51 | |
*** yogesh has quit IRC | 10:54 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects host-validation for mysql-user https://review.openstack.org/67566 | 10:59 |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 11:15 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add stack_id for future usage https://review.openstack.org/67873 | 11:18 |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 11:19 | |
*** rongze has joined #openstack-trove | 11:22 | |
*** rongze has quit IRC | 11:27 | |
*** rongze has joined #openstack-trove | 11:35 | |
*** rongze has quit IRC | 11:41 | |
*** SnowDust has quit IRC | 11:47 | |
*** SnowDust has joined #openstack-trove | 12:00 | |
*** yogesh has joined #openstack-trove | 12:05 | |
*** yogesh has quit IRC | 12:10 | |
*** tenaglia has quit IRC | 12:10 | |
*** SnowDust has quit IRC | 12:19 | |
*** rongze has joined #openstack-trove | 12:35 | |
*** rongze has quit IRC | 12:41 | |
*** SergeyLukjanov is now known as SergeyLukjanov_a | 13:02 | |
*** SergeyLukjanov_a is now known as SergeyLukjanov_ | 13:03 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 13:09 | |
*** pdmars has joined #openstack-trove | 13:14 | |
*** SushilKM has quit IRC | 13:24 | |
*** nosnos has quit IRC | 13:30 | |
*** nosnos has joined #openstack-trove | 13:31 | |
*** rongze has joined #openstack-trove | 13:35 | |
*** nosnos has quit IRC | 13:38 | |
*** rongze has quit IRC | 13:40 | |
*** Barker has joined #openstack-trove | 14:20 | |
openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Initial support for single instance Cassandra Database https://review.openstack.org/52666 | 14:26 |
*** jcru has joined #openstack-trove | 14:30 | |
*** rongze has joined #openstack-trove | 14:35 | |
openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Initial support for single instance Cassandra Database https://review.openstack.org/52666 | 14:37 |
*** rongze has quit IRC | 14:39 | |
*** SergeyLukjanov is now known as SergeyLukjanov_a | 14:42 | |
*** SergeyLukjanov_a is now known as SergeyLukjanov_ | 14:43 | |
*** kevinconway has joined #openstack-trove | 14:49 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 14:50 | |
*** robertmyers has joined #openstack-trove | 14:54 | |
*** djohnstone has joined #openstack-trove | 15:02 | |
*** djohnstone has quit IRC | 15:02 | |
*** djohnstone1 has joined #openstack-trove | 15:02 | |
*** djohnstone1 has quit IRC | 15:03 | |
*** djohnstone has joined #openstack-trove | 15:03 | |
*** djohnstone1 has joined #openstack-trove | 15:04 | |
*** jimbobhickville has joined #openstack-trove | 15:05 | |
*** djohnstone has quit IRC | 15:07 | |
*** djohnstone1 is now known as djohnstone | 15:11 | |
*** rongze has joined #openstack-trove | 15:12 | |
*** mrsnivvel has quit IRC | 15:17 | |
*** datsun180b has joined #openstack-trove | 15:22 | |
*** mattgriffin has joined #openstack-trove | 15:23 | |
*** amytron has joined #openstack-trove | 15:30 | |
*** rnirmal has joined #openstack-trove | 15:30 | |
*** tanisdl has joined #openstack-trove | 15:37 | |
*** mat-lowery has joined #openstack-trove | 15:42 | |
*** grapex has joined #openstack-trove | 15:43 | |
*** grapex has quit IRC | 15:44 | |
*** grapex has joined #openstack-trove | 15:45 | |
openstackgerrit | Ed Cranford proposed a change to openstack/trove: Ignore outdated messages sent to conductor https://review.openstack.org/67611 | 15:50 |
datsun180b | aww stupid git add -u | 15:50 |
openstackgerrit | Ed Cranford proposed a change to openstack/trove: Ignore outdated messages sent to conductor https://review.openstack.org/67611 | 15:51 |
openstackgerrit | Ed Cranford proposed a change to openstack/trove: Ignore outdated messages sent to conductor https://review.openstack.org/67611 | 15:52 |
datsun180b | sorry about that | 15:52 |
denis_makogon | git add -A | 15:52 |
datsun180b | problem is the conf file got modified and i didn't mean to include those changes | 15:53 |
*** cweidenkeller has joined #openstack-trove | 15:54 | |
denis_makogon | oh, sometimes it happens | 15:57 |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 15:57 | |
*** mat-lowery has quit IRC | 15:58 | |
*** jmontemayor has joined #openstack-trove | 16:01 | |
*** plodronio_ has joined #openstack-trove | 16:04 | |
*** plodronio has quit IRC | 16:04 | |
*** plodronio_ is now known as plodronio | 16:04 | |
*** SushilKM has joined #openstack-trove | 16:09 | |
*** SushilKM has quit IRC | 16:13 | |
*** datsun180b has quit IRC | 16:14 | |
*** ashestakov has joined #openstack-trove | 16:24 | |
*** ashestakov has quit IRC | 16:24 | |
*** mat-lowery has joined #openstack-trove | 16:24 | |
*** SushilKM has joined #openstack-trove | 16:25 | |
*** mat-lowery has quit IRC | 16:25 | |
*** mat-lowery has joined #openstack-trove | 16:25 | |
*** mat-lowery has quit IRC | 16:26 | |
*** mat-lowe_ has joined #openstack-trove | 16:26 | |
*** mat-lowe_ has quit IRC | 16:27 | |
*** jasonb365 has joined #openstack-trove | 16:27 | |
*** mat-lowery has joined #openstack-trove | 16:27 | |
*** mat-lowery has quit IRC | 16:28 | |
*** mat-lowe_ has joined #openstack-trove | 16:28 | |
*** mat-lowe_ has quit IRC | 16:29 | |
*** mat-lowery has joined #openstack-trove | 16:29 | |
*** SushilKM has quit IRC | 16:39 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database https://review.openstack.org/51884 | 16:39 |
*** SushilKM has joined #openstack-trove | 16:40 | |
jcru | would appreciate some core member reviews: https://review.openstack.org/#/c/66979/ | 16:40 |
*** esp has joined #openstack-trove | 16:45 | |
*** datsun180b has joined #openstack-trove | 16:47 | |
grapex | Question about this review: https://review.openstack.org/#/c/66369/4 | 16:51 |
grapex | A long time ago, I remember reading that a single line pydoc comment could have the triple quotes on the same line | 16:51 |
grapex | so like: | 16:51 |
grapex | def function(): | 16:51 |
grapex | """Does something.""" | 16:51 |
grapex | But if the pydoc comment spanned multiple lines, the style suggested was that the first triple quote be on a line all by itself | 16:52 |
grapex | This pull requests implies that the new rule is the opening triad of double quotes needs to be on the same line as the text no matter what. Is that really some new OpenStack style rule? | 16:52 |
SushilKM | @grapex, but that has changed now | 16:53 |
SushilKM | and they have the new rule, which is just opposite to that | 16:53 |
grapex | SushilKM: Where is this rule? | 16:53 |
*** rongze has quit IRC | 16:57 | |
*** rongze has joined #openstack-trove | 16:57 | |
*** SushilKM has quit IRC | 16:58 | |
*** SushilKM has joined #openstack-trove | 16:59 | |
SushilKM | @grapex rule is H404 multi line docstring should start with a summary | 16:59 |
grapex | Ah, I remember it now! | 17:01 |
grapex | Ok, I think my only issue then is the summary needs to be one line | 17:01 |
*** rongze has quit IRC | 17:02 | |
SushilKM | actually, to go with rule is they say in general docstring should be one liner, but when it is a bigger docstring then, preseed with a summary line | 17:03 |
grapex | def getid(obj): | 17:03 |
grapex | """Abstracts the common pattern of allowing both an object or an object's | 17:03 |
grapex | ID as a parameter when dealing with relationships. | 17:03 |
grapex | """ | 17:03 |
grapex | It should be like this: | 17:03 |
grapex | def getid(obj): | 17:03 |
grapex | """Grabs an id from object or integer. | 17:03 |
grapex | 17:03 | |
grapex | Abstracts the common pattern of allowing both an object or an object's | 17:03 |
grapex | ID as a parameter when dealing with relationships. | 17:03 |
grapex | """ | 17:03 |
grapex | SushilKM: So either those docstrings should become smaller, or you need to add a single line summary before them. | 17:04 |
openstackgerrit | Ed Cranford proposed a change to openstack/trove: Ignore outdated messages sent to conductor https://review.openstack.org/67611 | 17:04 |
SushilKM | okies, so if thats the case i may then need to come up with new edited comments | 17:05 |
grapex | SushilKM: Ok. Thanks! | 17:06 |
datsun180b | seems to me like a single docstring.lstrip() would have solved this problem | 17:06 |
SushilKM | whats that @datsun180b | 17:08 |
datsun180b | """this comment""" versus """\nthis comment""" | 17:08 |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects service URLS from %s/%s/ to %s/%s/ https://review.openstack.org/68175 | 17:08 |
datsun180b | oh i'm thinking of examples i've seen where the triple quote itself was on one line and the first line of the docstring was on the following | 17:09 |
*** lifeless has quit IRC | 17:09 | |
*** lifeless1 has joined #openstack-trove | 17:09 | |
*** isviridov has quit IRC | 17:09 | |
*** isviridov has joined #openstack-trove | 17:09 | |
datsun180b | if we're moving to a one-liner then fulltext then the answer's not so simple again | 17:10 |
*** plodronio has quit IRC | 17:12 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 17:22 | |
*** yidclare has joined #openstack-trove | 17:27 | |
*** rongze has joined #openstack-trove | 17:28 | |
*** ashestakov has joined #openstack-trove | 17:29 | |
*** rongze has quit IRC | 17:32 | |
*** rongze has joined #openstack-trove | 17:35 | |
*** rongze has quit IRC | 17:40 | |
*** harlowja_away is now known as harlowja | 17:51 | |
hub_cap | ok i think the milestone for i2 is being cut today (they may defer a wk, ill know during projct status meeting) | 17:52 |
hub_cap | so we cant really approve any reviews except the ones already in the gate until they cut it | 17:53 |
hub_cap | unless we get a wk extension (otherwise itll be like no merges till tomorrow) | 17:53 |
*** amcrn has joined #openstack-trove | 17:54 | |
datsun180b | hub_cap: i bet that's worth sticking in the /topic at least for a while | 17:58 |
hub_cap | when i figure out whats goin on i will | 18:04 |
hub_cap | its quite possible itll be business as usual | 18:04 |
*** radez_g0n3 is now known as radez | 18:23 | |
openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Datastores improvements https://review.openstack.org/60588 | 18:25 |
vgnbkr | Hi all. I'm going to take a crack at https://bugs.launchpad.net/trove/+bug/1212436, but thought I'd run my proposed solution by the group. | 18:29 |
hub_cap | hi vgnbkr plz do | 18:30 |
vgnbkr | We need to get rid of first-boot.d for the ubuntu and fedora guest agents. All they do is set ip forwarding and ntp. | 18:31 |
vgnbkr | I suggest that rather than the proposed solution of using os-config-refresh, we just make the appropriate changes in post-install.d. | 18:31 |
vgnbkr | Comments? | 18:31 |
hub_cap | if thats all they do, i dont see an issue w/ that | 18:38 |
vgnbkr | How do people usually manage their dev environments? Make a local branch for each bug fix? | 18:40 |
vgnbkr | (talking git here) | 18:40 |
robertmyers | vgnbkr: yeah, I usually do git checkout -b bug-XXXX | 18:41 |
robertmyers | then is it easy to remember which branch is for what | 18:42 |
datsun180b | yeah when you submit a review to gerrit it uses your branch name as the topic | 18:42 |
vgnbkr | Great. Thanks. | 18:43 |
*** yogesh has joined #openstack-trove | 18:43 | |
datsun180b | that is, if there's not a bug or blueprint | 18:45 |
*** SushilKM has quit IRC | 18:53 | |
*** lifeless1 is now known as lifeless | 18:59 | |
*** datsun180b has quit IRC | 19:07 | |
*** michael-yu has joined #openstack-trove | 19:37 | |
*** mat-lowery has quit IRC | 19:43 | |
openstackgerrit | Andrey Shestakov proposed a change to openstack/trove: Datastores improvements https://review.openstack.org/63844 | 19:50 |
hub_cap | denis_makogon: around? i still cant get your review to work (when i prov instances they dont come online) | 19:56 |
kevinconway | hub_cap: you are forgetting the --make-it-work flag | 19:58 |
hub_cap | oh snap | 20:00 |
hub_cap | i was using the --turn-it-off-and-on-again | 20:00 |
openstackgerrit | Khyati Sheth proposed a change to openstack/trove: Mask database user's password in trove logs https://review.openstack.org/66075 | 20:01 |
*** mat-lowery has joined #openstack-trove | 20:12 | |
*** mat-lowery has quit IRC | 20:13 | |
*** mat-lowe_ has joined #openstack-trove | 20:14 | |
vgnbkr | So I missed trove-integration/scripts/files/bootstrap_init-mysql.sh being copied into first-boot.d, which I'll need to fix, too. | 20:15 |
hub_cap | :o | 20:16 |
vgnbkr | Looking through it, I see that it is disabling apparmor for mysql. It seems like that could somewhat invalidate the integration tests. | 20:16 |
hub_cap | good cuz thats really ugly code hehe | 20:16 |
vgnbkr | Thoughts? | 20:16 |
vgnbkr | If the guest-agent needs to update files that are covered by apparmor, don't we need to make sure that it works in production? | 20:17 |
hub_cap | well im not sure anyone uses this in production vgnbkr | 20:17 |
hub_cap | ive always asserted that people should be building their own images and this is for development :) | 20:17 |
vgnbkr | I mean guest-agent. | 20:17 |
hub_cap | well the guest-agent code doesnt do that rigth? | 20:18 |
hub_cap | its the bash scripts that run in the image | 20:18 |
vgnbkr | The comments say that guest-agent needs to update conf files. | 20:18 |
hub_cap | ah | 20:18 |
openstackgerrit | Khyati Sheth proposed a change to openstack/trove: Mask database user's password in trove logs https://review.openstack.org/66075 | 20:18 |
vgnbkr | From boottstrap_init-mysql: | 20:19 |
vgnbkr | # Disable AppArmor so that trove guestagent can change the conf | 20:19 |
vgnbkr | # TODO this should probably be done in the guest and then re-enabled install | 20:19 |
hub_cap | yea so thats the thing | 20:19 |
vgnbkr | Maybe I'll just take it out and see where I get. | 20:19 |
hub_cap | we have to assume that the guest has the abilyt to update confs in a vm | 20:20 |
hub_cap | so its up to the operator to make that the case | 20:20 |
hub_cap | in this case, the "operator" is a set of scripts building a developement image | 20:20 |
openstackgerrit | Jenkins proposed a change to openstack/trove: Updated from global requirements https://review.openstack.org/68253 | 20:30 |
*** jasonb365_ has joined #openstack-trove | 20:32 | |
*** jasonb365 has quit IRC | 20:35 | |
*** jasonb365_ is now known as jasonb365 | 20:35 | |
*** rongze has joined #openstack-trove | 20:37 | |
*** rongze has quit IRC | 20:42 | |
*** khyati has joined #openstack-trove | 20:49 | |
openstackgerrit | A change was merged to openstack/database-api: Change xml and json files that contain only text to *.txt files https://review.openstack.org/67585 | 20:52 |
*** jasonb365 has quit IRC | 20:52 | |
*** jasonb365 has joined #openstack-trove | 20:53 | |
*** cweidenkeller has quit IRC | 21:11 | |
*** michael-yu has quit IRC | 21:15 | |
*** ashestakov has quit IRC | 21:17 | |
*** jasonb365 has quit IRC | 21:21 | |
*** mat-lowe_ has quit IRC | 21:26 | |
*** khyati has quit IRC | 21:28 | |
*** jasonb365 has joined #openstack-trove | 21:28 | |
*** michael-yu has joined #openstack-trove | 21:28 | |
*** mat-lowery has joined #openstack-trove | 21:29 | |
*** mat-lowery has quit IRC | 21:30 | |
*** mat-lowe_ has joined #openstack-trove | 21:30 | |
*** amcrn has quit IRC | 21:31 | |
*** khyati has joined #openstack-trove | 21:33 | |
*** amcrn has joined #openstack-trove | 21:33 | |
*** mat-lowe_ has quit IRC | 21:40 | |
*** mat-lowery has joined #openstack-trove | 21:40 | |
openstackgerrit | Justin Hopper proposed a change to openstack/trove: Fixed Instance Status usage https://review.openstack.org/66063 | 21:52 |
*** Barker has quit IRC | 21:53 | |
*** datsun180b has joined #openstack-trove | 22:03 | |
*** Barker has joined #openstack-trove | 22:07 | |
*** harlowja is now known as harlowja_away | 22:14 | |
*** vipul is now known as vipul-away | 22:19 | |
*** vipul-away is now known as vipul | 22:25 | |
*** vipul is now known as vipul-away | 22:25 | |
*** djohnstone has quit IRC | 22:28 | |
*** harlowja_away is now known as harlowja | 22:35 | |
*** radez is now known as radez_g0n3 | 22:38 | |
*** SergeyLukjanov is now known as SergeyLukjanov_a | 22:50 | |
*** SergeyLukjanov_a is now known as SergeyLukjanov_ | 22:51 | |
*** jmontemayor has quit IRC | 22:51 | |
datsun180b | oh boy oh boy oh boy dropping xml means https://github.com/openstack/trove/blob/master/trove/common/cfg.py#L241 gets to change | 22:52 |
datsun180b | i was about to submit that on its own but that would be dumb, we actually need to remove xml support first | 22:53 |
*** Barker has quit IRC | 22:56 | |
*** robertmyers has quit IRC | 22:59 | |
*** kevinconway has quit IRC | 23:03 | |
*** rnirmal has quit IRC | 23:04 | |
*** harlowja has quit IRC | 23:07 | |
*** amytron has quit IRC | 23:09 | |
*** khyati has quit IRC | 23:09 | |
*** michael-yu has quit IRC | 23:16 | |
*** jimbobhickville has quit IRC | 23:17 | |
*** michael-yu has joined #openstack-trove | 23:17 | |
*** datsun180b has left #openstack-trove | 23:24 | |
*** khyati has joined #openstack-trove | 23:26 | |
*** yogesh has quit IRC | 23:28 | |
*** jasonb365 has quit IRC | 23:38 | |
*** amcrn has quit IRC | 23:40 | |
*** jcru has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!