Monday, 2014-05-05

*** yogeshmehra has quit IRC00:01
*** Barker has joined #openstack-trove00:22
*** shakamunyi has joined #openstack-trove00:23
*** amytron has joined #openstack-trove00:27
*** yogeshmehra has joined #openstack-trove00:38
*** ams0 has joined #openstack-trove00:38
*** achampion has quit IRC00:41
*** ams0 has quit IRC00:43
*** achampion has joined #openstack-trove00:46
*** shakamunyi has quit IRC00:48
*** yogeshmehra has quit IRC00:56
*** shakamunyi has joined #openstack-trove01:13
*** erkules has quit IRC01:24
*** amytron has quit IRC01:29
*** amytron has joined #openstack-trove01:30
*** amytron has quit IRC01:32
*** erkules has joined #openstack-trove01:37
*** ams0 has joined #openstack-trove01:38
*** Barker has quit IRC01:41
*** ams0 has quit IRC01:43
*** ViswaV_ has joined #openstack-trove02:15
*** grapex has quit IRC02:18
*** ViswaV has quit IRC02:19
*** coolsvap|afk is now known as coolsvap02:35
*** robertmyers has joined #openstack-trove02:46
*** shakamunyi has quit IRC02:57
*** jasonb365 has joined #openstack-trove03:15
*** ams0 has joined #openstack-trove03:39
*** ams0 has quit IRC03:43
*** robertmyers has quit IRC04:06
*** robertmyers has joined #openstack-trove04:06
*** robertmyers has quit IRC04:10
*** jasonb365 has quit IRC04:11
*** ViswaV_ has quit IRC04:18
*** ViswaV has joined #openstack-trove04:19
*** jasonb365 has joined #openstack-trove04:19
*** jasonb365 has quit IRC04:26
*** achampion has quit IRC04:26
*** achampion has joined #openstack-trove04:28
*** jasonb365 has joined #openstack-trove04:30
*** ViswaV has quit IRC04:30
*** ViswaV has joined #openstack-trove04:31
*** haomaiwang has joined #openstack-trove04:31
*** haomaiwang has quit IRC04:32
*** haomaiwang has joined #openstack-trove04:33
*** jasonb365 has quit IRC04:40
*** achampion has quit IRC04:43
*** SushillKM has joined #openstack-trove04:43
*** jasonb365 has joined #openstack-trove04:44
*** achampion has joined #openstack-trove04:45
*** achampion has quit IRC04:55
*** achampion has joined #openstack-trove04:56
*** jasonb365 has quit IRC05:01
*** ams0 has joined #openstack-trove05:08
*** amytron has joined #openstack-trove05:10
*** sgotliv has joined #openstack-trove05:20
*** haomai___ has joined #openstack-trove05:22
*** haomaiwang has quit IRC05:22
*** ams0 has quit IRC05:26
*** haomaiwang has joined #openstack-trove05:26
*** ams0 has joined #openstack-trove05:26
*** ViswaV_ has joined #openstack-trove05:28
*** ViswaV has quit IRC05:28
*** haomai___ has quit IRC05:29
*** ams0 has quit IRC05:30
*** sgotliv has quit IRC05:40
*** shivam_ has joined #openstack-trove05:40
*** sgotliv has joined #openstack-trove05:41
*** ViswaV_ has quit IRC05:43
*** ViswaV has joined #openstack-trove05:43
*** ViswaV has quit IRC05:51
*** ViswaV has joined #openstack-trove05:51
*** ams0 has joined #openstack-trove05:56
*** yogeshmehra has joined #openstack-trove05:57
*** ViswaV_ has joined #openstack-trove06:00
*** ViswaV has quit IRC06:00
*** SnowDust has joined #openstack-trove06:02
*** ashishsnigam has joined #openstack-trove06:05
*** sgotliv has quit IRC06:18
*** yogeshmehra has quit IRC06:24
*** ViswaV_ has quit IRC06:29
*** ViswaV has joined #openstack-trove06:29
*** yogeshmehra has joined #openstack-trove06:32
*** ams0 has quit IRC06:32
*** global_ has joined #openstack-trove06:39
*** ViswaV_ has joined #openstack-trove06:41
*** ViswaV has quit IRC06:44
openstackgerritShalini khandelwal proposed a change to openstack/trove-integration: Initial support for Vertica Datastore in trove  https://review.openstack.org/8980406:49
*** ViswaV_ has quit IRC07:23
*** ViswaV has joined #openstack-trove07:24
*** ViswaV_ has joined #openstack-trove07:25
*** ViswaV has quit IRC07:25
*** flaper87|afk is now known as flaper8707:29
*** ViswaV_ has quit IRC07:32
*** ViswaV has joined #openstack-trove07:32
*** global_ is now known as shalini_07:33
openstackgerritShalini khandelwal proposed a change to openstack/trove-integration: Added datastore type in test.conf  https://review.openstack.org/8496407:35
openstackgerritshivam shukla proposed a change to openstack/trove: Added check for not use heat in security group delete  https://review.openstack.org/6917607:36
*** ams0 has joined #openstack-trove07:38
*** yogeshmehra has quit IRC07:42
*** openstackgerrit has quit IRC07:53
*** ViswaV has quit IRC07:53
*** ViswaV has joined #openstack-trove07:56
*** ams0 has quit IRC08:27
*** ViswaV has quit IRC08:29
*** ViswaV has joined #openstack-trove08:29
*** ams0 has joined #openstack-trove08:34
*** ViswaV has quit IRC08:34
*** ViswaV has joined #openstack-trove08:35
*** ams0 has quit IRC08:39
*** ams0 has joined #openstack-trove08:40
*** ViswaV has quit IRC08:40
*** ams0 has quit IRC08:44
*** ams0_ has joined #openstack-trove08:47
*** ams0_ has quit IRC08:59
*** ams0 has joined #openstack-trove09:00
*** ams0 has quit IRC09:05
*** ams0 has joined #openstack-trove09:05
*** ams0_ has joined #openstack-trove09:07
*** ams0 has quit IRC09:10
*** ViswaV has joined #openstack-trove09:10
*** sgotliv has joined #openstack-trove09:12
*** ViswaV has quit IRC09:22
*** ViswaV has joined #openstack-trove09:23
*** haomaiwang has quit IRC09:25
*** ViswaV has quit IRC09:27
*** ViswaV has joined #openstack-trove09:28
*** ViswaV has quit IRC09:39
*** ViswaV has joined #openstack-trove09:40
*** ViswaV_ has joined #openstack-trove09:46
*** ViswaV has quit IRC09:46
*** ViswaV_ has quit IRC09:56
*** ViswaV has joined #openstack-trove09:57
*** ViswaV has quit IRC10:19
*** ViswaV has joined #openstack-trove10:19
*** SnowDust has quit IRC10:22
*** ViswaV_ has joined #openstack-trove10:27
*** ViswaV has quit IRC10:27
*** ViswaV_ has quit IRC10:29
*** ViswaV has joined #openstack-trove10:30
*** SnowDust has joined #openstack-trove10:36
*** coolsvap is now known as coolsvap|afk10:40
*** ViswaV has quit IRC10:46
*** ViswaV has joined #openstack-trove10:46
*** ViswaV_ has joined #openstack-trove10:47
*** ViswaV has quit IRC10:47
*** ViswaV has joined #openstack-trove11:00
*** ViswaV_ has quit IRC11:00
*** ams0_ has quit IRC11:02
*** ams0 has joined #openstack-trove11:02
*** ViswaV has quit IRC11:04
*** ViswaV has joined #openstack-trove11:06
*** ams0 has quit IRC11:06
*** ViswaV_ has joined #openstack-trove11:17
*** ViswaV has quit IRC11:17
*** haomaiwa_ has joined #openstack-trove11:21
*** ViswaV_ has quit IRC11:33
*** ViswaV has joined #openstack-trove11:36
*** SushillKM has quit IRC11:43
*** SushillKM has joined #openstack-trove11:48
*** sgotliv has quit IRC11:48
*** SnowDust has quit IRC11:56
*** ViswaV has quit IRC11:56
*** ViswaV has joined #openstack-trove12:00
*** ams0 has joined #openstack-trove12:00
*** ams0_ has joined #openstack-trove12:02
*** ViswaV has quit IRC12:03
*** ams0 has quit IRC12:06
*** ams0_ has quit IRC12:15
*** ams0 has joined #openstack-trove12:16
*** ams0_ has joined #openstack-trove12:30
*** ams0 has quit IRC12:33
*** ViswaV has joined #openstack-trove12:39
*** NehaV has joined #openstack-trove12:40
*** ashishsnigam has quit IRC12:43
*** NehaV has quit IRC12:44
*** achampion has quit IRC12:48
*** ViswaV_ has joined #openstack-trove12:49
*** ViswaV has quit IRC12:50
*** flaper87 has quit IRC12:52
*** NehaV has joined #openstack-trove12:52
*** flaper87|afk has joined #openstack-trove12:56
*** flaper87|afk is now known as flaper8712:56
*** flaper87 has quit IRC12:56
*** flaper87 has joined #openstack-trove12:56
*** NehaV1 has joined #openstack-trove13:02
*** NehaV has quit IRC13:05
*** sgotliv has joined #openstack-trove13:06
*** ViswaV_ has quit IRC13:15
*** ViswaV has joined #openstack-trove13:16
*** jcru has joined #openstack-trove13:23
*** jcru has joined #openstack-trove13:23
*** radez_g0n3 is now known as radez13:24
*** ViswaV has quit IRC13:31
*** ViswaV_ has joined #openstack-trove13:31
*** openstackgerrit has joined #openstack-trove13:36
*** SushillKM has quit IRC13:37
*** SushillKM has joined #openstack-trove13:37
*** grapex has joined #openstack-trove13:37
*** yidclare has quit IRC13:38
*** yidclare has joined #openstack-trove13:39
*** yidclare has left #openstack-trove13:39
*** Barker has joined #openstack-trove13:44
*** SushillKM has quit IRC13:50
*** openstackgerrit has quit IRC13:51
*** achampion has joined #openstack-trove13:52
*** ams0_ has quit IRC13:54
*** ams0 has joined #openstack-trove13:54
*** grapex has quit IRC13:56
*** grapex has joined #openstack-trove13:56
*** ams0 has quit IRC13:57
*** ams0 has joined #openstack-trove13:57
*** ams0 has quit IRC13:58
*** ams0 has joined #openstack-trove13:58
*** mattgriffin has joined #openstack-trove14:07
*** freyes has joined #openstack-trove14:09
*** kevinconway has joined #openstack-trove14:16
*** rueb7363 has joined #openstack-trove14:17
*** rwsu has joined #openstack-trove14:18
*** ViswaV_ has quit IRC14:25
*** ViswaV has joined #openstack-trove14:26
*** jasonb365 has joined #openstack-trove14:37
*** NehaV1 has quit IRC14:37
*** NehaV has joined #openstack-trove14:37
*** sgotliv has quit IRC14:41
*** dmakogon has joined #openstack-trove14:50
*** denis_makogon has quit IRC14:50
*** dmakogon is now known as denis_makogon14:50
*** dmakogon_ has joined #openstack-trove14:51
denis_makogonSlickNik, ping14:51
*** jasonb365_ has joined #openstack-trove14:57
*** jasonb365 has quit IRC14:58
*** jasonb365_ is now known as jasonb36514:58
*** NehaV1 has joined #openstack-trove15:00
*** robertmyers has joined #openstack-trove15:01
*** NehaV has quit IRC15:03
*** thedodd has joined #openstack-trove15:06
*** sgotliv has joined #openstack-trove15:06
*** pdmars has joined #openstack-trove15:09
*** robertmyers has quit IRC15:15
*** robertmyers has joined #openstack-trove15:16
*** doddstack has joined #openstack-trove15:16
*** ashishsnigam has joined #openstack-trove15:18
*** thedodd has quit IRC15:19
*** robertmyers has quit IRC15:20
*** jasonb365 has quit IRC15:29
*** haomaiwa_ has quit IRC15:29
*** Barker has quit IRC15:29
*** haomaiwang has joined #openstack-trove15:30
iccha1NehaV1: around?15:32
*** sgotliv has quit IRC15:34
*** haomaiwang has quit IRC15:37
*** mattgriffin has quit IRC15:38
*** haomaiwa_ has joined #openstack-trove15:38
*** mattgriffin has joined #openstack-trove15:40
*** radez is now known as radez_g0n315:41
*** openstackgerrit has joined #openstack-trove15:42
*** haomaiwa_ has quit IRC15:43
*** radez_g0n3 is now known as radez15:44
*** coolsvap|afk is now known as coolsvap15:45
*** amytron has quit IRC15:45
*** shivamshukla_ has joined #openstack-trove15:50
*** demorris has joined #openstack-trove15:54
*** sgotliv has joined #openstack-trove15:56
hub_capgrapex: wrt the "show stack traces in fake mode", can we not fix it in olso? I dont know what the issue is but the subtext of your commit says something is wrong w oslo15:59
*** robertmy_ has joined #openstack-trove16:00
*** Barker has joined #openstack-trove16:02
*** jmontemayor has joined #openstack-trove16:04
*** robertmyers has joined #openstack-trove16:04
*** robertmy_ has quit IRC16:05
*** shivamshukla_ has quit IRC16:05
*** robertmyers has joined #openstack-trove16:05
*** NehaV1 has quit IRC16:06
*** NehaV has joined #openstack-trove16:06
*** jasonb365 has joined #openstack-trove16:07
*** ams0__ has joined #openstack-trove16:09
*** ams0 has quit IRC16:09
*** ViswaV has quit IRC16:12
*** ViswaV has joined #openstack-trove16:13
*** ViswaV_ has joined #openstack-trove16:15
*** sgotliv has quit IRC16:16
*** ViswaV has quit IRC16:18
openstackgerritPeter Stachowski proposed a change to openstack/python-troveclient: Added check for empty attributes in trove CLI  https://review.openstack.org/9216216:22
*** ams0__ has quit IRC16:31
*** SushillKM has joined #openstack-trove16:38
*** SushillKM has quit IRC16:41
*** SushillKM has joined #openstack-trove16:41
SushillKMhello cores16:42
SushillKMplease review https://review.openstack.org/8031516:42
*** ashishsnigam has quit IRC16:44
*** jmontemayor has quit IRC16:50
*** jasonb365 has quit IRC16:51
*** jasonb365 has joined #openstack-trove16:54
*** SushillKM has quit IRC16:58
esmuteHappy monday everyone. Hope you guys had an awesome weekend. Just to get prepared for the week, can you review these patches? They are short and sweet. https://review.openstack.org/#/c/81379/ https://review.openstack.org/#/c/89717/ https://review.openstack.org/#/c/89719/ https://review.openstack.org/#/c/90462/. Many thanks!16:58
*** SushillKM has joined #openstack-trove16:59
*** ramashri has joined #openstack-trove17:03
*** Barker has quit IRC17:05
*** ashishsnigam has joined #openstack-trove17:11
*** Barker has joined #openstack-trove17:15
*** harlowja_away is now known as harlowja17:16
*** shivamshukla_ has joined #openstack-trove17:18
grapexhub_cap: Yo- about that fix stack traces for fake mode pull request17:19
grapexFirst off, I swear it worked when I left on Friday, but today I can see it obviously doesn't.17:19
grapexAs for fixing it in Oslo, I'm going to put a pull request in there, but the answer is I'm not sure if they'll accept it so I thought I'd patch it for the time being17:20
*** openstackgerrit has quit IRC17:20
*** openstackgerrit has joined #openstack-trove17:24
*** sbfox has joined #openstack-trove17:28
*** ashishsnigam has quit IRC17:30
*** ashishsnigam has joined #openstack-trove17:30
*** doddstack has quit IRC17:34
*** grapex has quit IRC17:36
*** grapex has joined #openstack-trove17:36
*** Barker has quit IRC17:37
*** jmontemayor has joined #openstack-trove17:37
*** amcrn has joined #openstack-trove17:46
SushillKMhttps://bugs.launchpad.net/trove-integration/+bug/131608017:49
SushillKMregarding this bug, i thnk we shud put performance_schema in the ignore_dbs17:49
SushillKMsince this is a special schema17:50
dougshelley66that seems to be a dupe of https://bugs.launchpad.net/trove/+bug/129700017:50
*** ramashri has quit IRC17:51
denis_makogondougshelley66, ++17:52
SushillKMyeah its similar .... and the solution lies in putting an entry to ignore_dbs17:52
*** GeorgeLorch has joined #openstack-trove17:52
denis_makogonSushillKM, simple answer - yes, of course17:53
ashishsnigamhttps://etherpad.openstack.org/p/TroveTempestTesting17:53
SushillKMcool17:53
SushillKMthanks17:53
*** jasonb365 has quit IRC17:54
ashishsnigamHi folks.. We need to change devstack to have a default datastore.17:55
ashishsnigamSo that tempest codes for trove can be written.17:56
ashishsnigamAny comments?17:56
*** jasonb365 has joined #openstack-trove17:56
denis_makogonashishsnigam, you could use tempest tests inside the trove-integration17:56
denis_makogonashishsnigam, 'cuz we're planning to move datastore/version registration from trove-manage to API17:57
SlickNikashishsnigam: Sounds reasonable. Check with peterstac to see if he's working on something similar so that you don't step on each other's toes.17:57
SlickNik#startmeeting trove-bp-review18:00
openstackMeeting started Mon May  5 18:00:07 2014 UTC and is due to finish in 60 minutes.  The chair is SlickNik. Information about MeetBot at http://wiki.debian.org/MeetBot.18:00
denis_makogonSlickNik, are we still going to move all possible features from -manage to public API ?18:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.18:00
openstackThe meeting name has been set to 'trove_bp_review'18:00
*** PeterSchwaller_ has joined #openstack-trove18:00
SlickNikGiving folks a couple of minutes to trickle in to the bp review.18:00
cp16netyea18:00
* juice is trickling18:01
SlickNikJust wanted to mention a point of order.18:01
dougshelley66denis_makogon, SlickNik - isn't the point to move away from trove-integration to tempest with devstack CI?18:01
openstackgerritSushil Kumar proposed a change to openstack/trove: Adds performance_schema to ignore_dbs  https://review.openstack.org/9217618:01
denis_makogondougshelley66, of course, but it's like temporary solution18:01
SlickNikdougshelley66: Yes, the plan is to move away from trove-integration.18:02
juiceslicknik - what was your point of order18:02
SlickNikdougshelley66: Let's chat after the bp meeting.18:02
dougshelley66SlickNik certainly18:02
denis_makogonmattgriffin, it's your turn, i guess18:03
mattgriffindenis_makogon, hello!18:03
denis_makogonmattgriffin, hello, Mat =)18:03
mattgriffinso i've proposed 3 BPs18:03
mattgriffin1. https://blueprints.launchpad.net/trove/+spec/support-percona-xtrabackup-2.218:03
denis_makogon#link https://blueprints.launchpad.net/trove/+spec/support-percona-xtrabackup-2.218:04
mattgriffinthere was a question last week about backwards compability18:04
mattgriffinof backups18:04
SlickNikmattgriffin: hang on one sec.18:04
mattgriffinSlickNik, ack18:04
*** grapex_ has joined #openstack-trove18:05
*** NehaV1 has joined #openstack-trove18:05
SlickNikI don't think cores are around yet.18:05
grapex_Sorry, got disconnected18:05
SlickNikgrapex just got here.18:05
SlickNiknp.18:05
SlickNikSo just a point of order before we start.18:05
*** demorris has quit IRC18:05
SlickNikTo be fair to all parties involved — if you submit more than one unrelated bp per review meeting — only the first one will be talked about as part of the queue.18:05
*** michael-yu has joined #openstack-trove18:06
openstackgerritSushil Kumar proposed a change to openstack/trove: Resolves volume resize issue  https://review.openstack.org/8031518:06
SlickNikWe can talk about the other ones if we have time.18:06
*** demorris has joined #openstack-trove18:06
grapex_SlickNik: I like it18:06
SlickNikOkay, with that out of the way.18:07
SlickNik#topic Percona support18:07
*** grapex has quit IRC18:07
SlickNikmattgriffin:18:07
mattgriffinSlickNik, hi :)18:07
SlickNikgo ahead18:07
*** NehaV has quit IRC18:07
mattgriffinhi all. i created some Summit proposals but was told that the best route was to submit BPs18:08
*** NehaV has joined #openstack-trove18:08
SlickNikSo a couple of things regarding the bps.18:08
mattgriffinok18:08
*** NehaV has left #openstack-trove18:09
*** NehaV has joined #openstack-trove18:09
SlickNikIt's still early days for supporting xtradbcluster (https://blueprints.launchpad.net/trove/+spec/support-pxc-5.5-and-5.6) since we don't have a clustering API in trove yet.18:09
mattgriffinSlickNik, ack18:10
denis_makogonSlickNik, agreed, looks like another package for current percona support18:10
konetzedSlickNik: *fingers crossed* for clustering :D18:10
mattgriffinSlickNik, just looking for ways that percona can plug into the team and help ... perhaps that API is a way forward during Juno18:10
denis_makogonmattgriffin, we can ask them to join amcrn's design sessions18:11
SlickNikWe have a summit session on the clustering API design, and plan to have it nailed by then.18:11
mattgriffincool18:11
SlickNik(amcrn is doing a great job of leading that)18:11
SlickNikAs for support for percona-server. THe plan is to support it through the mysql-manager itself.18:12
*** NehaV1 has quit IRC18:12
denis_makogonSlickNik, sound very reasonable18:12
SlickNikThere's a session on unifying guest-agents that will discuss that and hub_cap's driving that one.18:12
mattgriffinSlickNik, any work needed to get PS 5.6 into the mix for support?18:12
cp16netyeah it should be similar enough not to have another impl for percona18:12
mattgriffinSlickNik, ok... then chat about that in ATL18:13
mattgriffin?18:13
SlickNikmattgriffin: Should be fairly straightforward; don't think there's an issue there.18:13
SlickNikcp16net: Yes, the idea is to have the mysql guest support percona as well.18:14
*** yogeshmehra has joined #openstack-trove18:14
SlickNikmattgriffin: So for xtrabackup, was there a backward compat issue?18:15
mattgriffinSlickNik, i checked into it. no issue but GeorgeLorch is here if there are additional questions18:15
*** yogeshmehra has quit IRC18:16
*** yogeshme_ has joined #openstack-trove18:16
*** PeterSchwaller_ is now known as PeterSchwaller18:16
SlickNikmattgriffin: Okay, sounds good. In that case, it's probably okay for us to move to xtrabackup- 2.2 for backup/restore.18:17
mattgriffinSlickNik, with xtrabackup, there are likely features that trove isn't using that would be helpful to users.18:17
mattgriffinSlickNik, cool18:17
SlickNikWill follow up with GeorgeLorch about new features.18:17
mattgriffinSlickNik, great!18:17
*** SushillKM has quit IRC18:17
SlickNikThanks mattgriffin.18:17
mattgriffinSlickNik, thank you18:17
cp16neti see last time juice asked about direct integration with XtraBackup to s3/swift18:18
mattgriffincp16net, that's unfortunately not going to be available until late 2014 in 3.018:18
SlickNikOkay, let's move on.18:19
SlickNik#topic Instance database log manipulations18:19
denis_makogon#link https://blueprints.launchpad.net/trove/+spec/dbinstance-log18:19
denis_makogonlast time this one appeared, were asked several questions18:19
denis_makogonyou can find them at the wiki page18:20
*** yogeshme_ has quit IRC18:20
*** yogeshmehra has joined #openstack-trove18:20
*** ramashri has joined #openstack-trove18:20
denis_makogonquestions are related to log rotation18:20
denis_makogonand sys log18:20
denis_makogon*sys log service18:20
*** doddstack has joined #openstack-trove18:21
denis_makogonshort answer to rotation - it can be done within scheduled task18:21
*** ranjitha has joined #openstack-trove18:21
konetzedwhy cant you use logrotate?18:21
denis_makogonkonetzed, we can, that's what i wrote18:21
konetzeddenis_makogon: sorry just saw that link, must have glanced over it first time18:22
denis_makogonkonetzed, but to keep full log history we need to push log to Swift18:22
denis_makogononce rotation time comes, guest pushes database log into the Swift18:22
denis_makogonbut this task can be accomplished once scheduled task appears18:23
denis_makogonwe had design session for scheduled tasks18:23
denis_makogon*have18:23
*** shivamshukla_ has quit IRC18:23
esmutedenis_makogon: How can you configure the the DB log config? rotation, file size and all the other logging goodness18:23
denis_makogonesmute, everything is written at wiki page18:24
denis_makogonesmute, size, schedule, file18:24
denis_makogonetc18:24
esmutedenis_makogon: ok.. i just read the API portion18:24
denis_makogonesmute, cool =)18:25
amcrndenis_makogon: your wiki mentions the template, it doesn't mention how it's actually rendered with dynamic values18:25
denis_makogonamcrn, https://wiki.openstack.org/wiki/Trove/DBInstanceLogOperation#Log_files_rotation18:25
denis_makogon{{ how_often }}18:26
amcrnwhere does "actual rotation count" come from18:26
denis_makogonamcrn, from guest config18:26
juicedenis_makogon: I still feel that either this is a generic component that could be added to dbaas as something installable or a 3rd party component - i.e. why are we building this?18:26
SlickNikdenis_makogon: Your wiki doesn't mention any API endpoints for this. What's the endpoint that I need to actually hit?18:26
denis_makogonjuice, from PaaS level perspective, you cannot access the VM directly, only through some API18:27
amcrndenis_makogon: https://wiki.openstack.org/wiki/Trove/DBInstanceLogOperation#Configuration is missing your guest config18:27
denis_makogonamcrn, that's true18:27
juicedenis_makogon: I understand that but log shipping is a solved issue18:27
denis_makogonamcrn, thanks for catch18:27
vipuldenis_makogon: We should forget about iteration 2 for now.. just focus on iteration 1.  I'm missing how the user would save off a log file.. and how the deployer would choose which files can be saved.. and what timestamp a saved log file represents18:27
denis_makogonjuice, we cannot use syslog server18:28
denis_makogonvipul, log files will be shipped to Swift container18:28
cp16netdenis_makogon: can how do you add log files that are not specified in this "default" setup of log files?18:28
vipuldenis_makogon: i understand that.. i feel like this can be simplified sooo much for v118:29
denis_makogoncp16net, i'm specifying at database logs only18:29
denis_makogonvipul, how ?18:29
SlickNikOkay, so I don't want this to turn into a design session.18:29
denis_makogonSlickNik, agreed18:29
kevinconwaySlickNik: what if....18:29
denis_makogonlets talk about meeting18:29
denis_makogon#action Fix wiki page (conf. section)18:30
vipul1. we need an endpoint that let's a user 'save' a file.. given the name of a file.. 2. we need an endpiont that lists all saved files, and their timestamps.. Done18:30
SlickNikSo I think we all agree that the BP needs some better definition around phase 1 of this.18:30
SlickNikdenis_makogon: thanks.18:30
denis_makogonvipul, that's what i proposed as v118:30
esmutedenis_makogon: so only the logs that are created/saved will be the ones accessible?18:31
*** radez is now known as radez_g0n318:31
denis_makogonesmute, yes18:31
denis_makogonesmute, only database logs18:31
SlickNikLet's defer this until next week, when denis_makogon updates the page with this info.18:31
denis_makogonlet's move forward18:31
esmuteso if i want daily logs (or hourly) i would have to add a cronjob/script to run every hour and invoke the dblog-create api?18:31
SlickNikthanks #denis_makogon18:31
denis_makogonSlickNik, agreed18:31
denis_makogonesmute, lets talk after18:32
SlickNik#topic Update database instance name18:32
SlickNiknehav around?18:32
NehaVhey18:32
NehaVits a bp to allow users to rename db instance18:32
denis_makogonone question, what's the justification of it ?18:32
denis_makogonwhat it stands for ?18:32
NehaVa change to the existing update instance call18:32
NehaVUsers have requested the ability to rename instances after they are created18:33
denis_makogonNehaV, nova allows it ?18:33
NehaVyes18:33
iccha1yes18:33
denis_makogonNehaV, why does DNS is not enough?18:33
iccha1all projects allow name changes18:33
iccha1its id changes which are not allowed18:33
cp16neti think a good example is i created a dev-instance and i'm now using it in prod so i'd like to change the name to prod-instance18:33
NehaVa user should be allowed to change the name of their instance18:34
denis_makogoncp16net, thanks for an example18:34
grapex_Sounds pretty simple. Even when you're just making test instances, it can be painful sometimes when you can't rename them18:34
amcrnmakes sense to me18:34
denis_makogonNehaV, does heat allows that ?18:34
SlickNikone question.18:35
cp16netyeah and nothing should be tied directly to the name any way18:35
SlickNikNehaV: So the bp mentions it being a PUT, but I think it's more likely a PATCH since you're not including all the json that specifies the resource.18:35
NehaVi m not sure about heat18:35
denis_makogonSlickNik, ++18:35
iccha1cp16net: +118:35
cp16nettru18:35
vipulis the plan to propogate the name change to the nova instance?18:35
denis_makogonNehaV, please take a look at heat, since we're planning to move at it, as soon as possible18:35
iccha1SlickNik: then the config call wpould also have to change ?18:35
*** saurabhs has joined #openstack-trove18:36
vipulthe one issue i see is the nova instance name is usually also the hostname of the VM18:36
denis_makogonvipul, ++18:36
vipulso we are indirectly relying on it18:36
esmutevipul: Does renaming a nova instance, rename the hostname?18:36
vipulesmute: good question, i'm not sure18:36
denis_makogonesmute, yes18:36
iccha1do u propagate instance name to nova server name?18:37
denis_makogoniccha1, yes, we're doing it18:37
vipuliccha1: we do.. unless DNS is enabled18:37
denis_makogonvipul, that's also true18:37
grapex_Maybe I'm missing something- why is it important to rename the Nova instance name?18:37
cp16netyeah then its the dns name18:37
grapex_The issue is though DNS names are configured via a strategy18:38
grapex_At Rax they are these weird guid looking things that don't have to be the same as anything else18:38
vipulgrapex_: if you don't use dns in Trove, the instance name = nova instance name18:38
denis_makogonalso, heat changes host name "as it want's", by adding huge hash to resource name18:38
grapex_vipul: Trust, but I guess I don't get why the nova and Trove names would have to be the same.18:39
vipulwell the only issue i see is the hostname of the VM will not be tied to the Trove instance name18:39
denis_makogonNehaV, are you planning to rename instance hostname, or just Trove instance name ?18:39
denis_makogonvipul, same for me18:40
NehaVtrove instance name18:40
vipulso for example.. we use that hostname + uuid + other stuff today to generate a 'salt key'18:40
denis_makogonin this case, it's valid18:40
vipulwe can probably work around that..18:40
vipulbut just raising it as a potential issue18:40
denis_makogoni guess we can changes Trove instances name, since it's not chained with compute instance name18:41
grapex_vipul: I see.18:41
saurabhslike nova when you change name of the instance, nothing on the instance is affected, updated name is visible in nova list, but if you do 'hostname' on the instance you will continue to see the old name.18:41
iccha1we should be relying only on ids, and never on names.18:41
saurabhswe should do something similar change it it in trove database only and not change anything in nova18:41
denis_makogoniccha1, we just doing it18:41
denis_makogonsaurabhs, that's valid18:42
esmutesaurabhs: so nova rename does not update the hostname?18:42
kevinconwayiccha1: but ba3e352a-577f-4a40-9646-aaca5acf86f8 is so hard to pronounce18:42
saurabhsit updates it only in nova list I guesst. on instance for sure 'hostname' command returns you old name of the instance18:42
denis_makogonkevinconway, at least you can try ;)18:42
iccha1shakespeare said whats in a name kevinconway18:43
SlickNikOkay, I think we know pretty well what this entails.18:43
SlickNikLet's get a quick vote:18:43
vipulyea we should be able to work around it..18:43
esmute+1 update both trove and nova instance18:43
denis_makogon+1 only for Trove instances18:44
openstackgerritAnna Shen proposed a change to openstack/trove-integration: Trove guestagent should not use sample conf  https://review.openstack.org/8847818:44
openstackgerritAnna Shen proposed a change to openstack/trove-integration: Add neutron switch for int tests  https://review.openstack.org/8785618:44
openstackgerritAnna Shen proposed a change to openstack/trove-integration: Add support for a neutron-based install  https://review.openstack.org/7812318:44
cp16net#vote yes18:44
annashensorry guys18:44
SlickNik#vote update instance name? yes-only-trove, yes-trove-and-nova, no18:44
*** jasonb365 has quit IRC18:44
SlickNik#startvote update instance name? yes-only-trove, yes-trove-and-nova, no18:45
openstackBegin voting on: update instance name? Valid vote options are yes-only-trove, yes-trove-and-nova, no.18:45
denis_makogon#vote yes-only-trove18:45
openstackVote using '#vote OPTION'. Only your last vote counts.18:45
grapex_I'd like to make it an option18:45
esmute#vote  yes-trove-and-nova18:45
NehaV#vote yes-only-trove18:45
grapex_#vote yes-only-trove18:45
saurabhs#vote yes-only-trove18:45
robertmyers#vote yes-only-trove18:45
amcrn#vote yes-only-trove18:45
iccha1#vote yes-only-trove18:45
grapex_I want other deployers to be able to change the Nova name and do other things if they need to18:45
vipul#vote yes-only-trove18:45
grapex_Maybe we could add a function name to the configs that gets called when the name is changed, and by default its None18:45
SlickNikI'm with grapex_ on this one.18:45
cp16net#vote yes-only-trove18:45
denis_makogon#vote yes-only-trove18:46
grapex_SlickNik: The options didn't entail that18:46
grapex_but I'm sure it could be a fast-follow18:46
SlickNiksure18:46
*** radez_g0n3 is now known as radez18:46
SlickNik#endvote18:46
openstackVoted on "update instance name?" Results are18:46
kevinconwaygrapex_: you mean like an event callback?18:46
openstackyes-trove-and-nova (1): esmute18:46
openstackyes-only-trove (9): iccha1, robertmyers, saurabhs, denis_makogon, amcrn, cp16net, grapex_, NehaV, vipul18:46
esmutelandslide18:46
iccha1SlickNik: i would still like your put vs patch concern addressed though18:47
SlickNikiccha1: same here18:47
SlickNikIIRC, config groups used patch, but I'll have to check the code.18:47
cp16netyeah but i think it should be ok to start on the small change18:47
SlickNikcp16net might have a better idea.18:48
SlickNikLet's take that offline and work it out.18:48
cp16netyeah we have added patch for that18:48
cp16netfor attach/detach18:48
iccha1cp16net: configurations uses patch?18:48
NehaVthe current update instance call has put for updating a config group to an instance18:48
iccha1cool the docs are updated then18:48
cp16neticcha1: yup18:48
iccha1*outdated18:48
* cp16net thinks i'm up to date :-P18:49
iccha1https://wiki.openstack.org/wiki/Trove/Configurations#Update_an_Instance_.28PUT.2918:49
SlickNikgrapex_: I'm okay with having the trove-only option go in. We can fast follow with a config and nova rename if needed. :)18:49
SlickNikLet's move on.18:49
SlickNik#topic Pluggable conductor manager18:49
SlickNikboden?18:49
denis_makogonseems he's out18:50
SlickNikI'm not sure what his IRC nick is.18:50
SlickNik#topic Allow configs to be rendered based on datastore version18:50
denis_makogonSlickNik, boden18:50
SlickNikcp16net: all yours18:51
denis_makogon++ for this BP18:51
SlickNikI think this really is a bug.18:51
cp16netyeah this needs to change a bit18:51
cp16netgrapex_: passed this off to me and i think i am a little behind... :-p18:51
cp16netsorry18:51
vipulwasn't there talk of collapsing the version + datastore into a single field18:52
vipulif that happens, is this a solved problem18:52
grapex_vipul: A single field in the class named "Datastore"?18:52
cp16netwell the templates we have are stored in /tempatles/{manager}/18:52
cp16netright now and we cant have like multiple tempaltes for different versions...18:52
vipulgrapex_: yes.. datastore_name may imply 'datastore + version'18:52
cp16netlike mysql 5.1 or 5.518:53
grapex_vipul: Well today the template is only picked using the datastore's manager18:53
cp16netthis makes the path easier to follow and make configurations for each version18:53
denis_makogonas for me, we should have root template /template/{datastore}/root.config18:53
cp16netbut still defaulting back to the manager if the others are not found18:53
denis_makogonand other templates are extending the root.config18:53
robertmyersmore options are better18:54
cp16netso after explaining that part... are there any questions about this ?18:54
SlickNikcp16net / denis_makogon: I think both of you are saying basically the same thing.18:54
grapex_robermyers: ++18:54
vipulcp16net: so you think it's better to derive the tempalte from datastore_version and if it does collapse into a single record.. then this would just follow?18:54
grapex_I'm sure we'll change this and then next week a deployer will wish we'd added something else18:54
denis_makogonSlickNik, cp16net if that's so, than cool =)18:54
grapex_vipul: the point here is to get the template from both the datastore name and the version18:55
denis_makogongrapex_, ++18:55
grapex_if it becomes a single record, that's ok, because the blueprint currently tries multiple paths18:55
grapex_the first is something like /template/{datastore_name}/{datastore_version}18:55
cp16netvipul: yeah this makes the deployer able to make the templates in a more specific place18:55
vipulgrapex_: yep, i got that.. i'm all for it.. just might become moot if someone does implement the single record solution18:55
amcrni generally agree with the proposal, but have a few minor nits (but that can be discussed at a later time in a smaller setting)18:56
robertmyerswe can always change the paths we check18:56
grapex_vipul: Sure18:56
denis_makogonrobertmyers, agreed18:56
grapex_but that's relying on a pretty huge refactor to the datastore stuff18:56
cp16netyeah thats just a list of configuration paths18:56
grapex_I am a horrible cynical man but I don't know if I believe that will happen18:56
grapex_Maybe we can have a hack-a-thon at the summit and change datastores. :)18:56
vipulgrapex_: fair enough it probably won't anytime soon18:57
cp16netamcrn: we can chat later and make sure we are on the same page18:57
amcrncp16net: sounds good18:57
cp16net:)18:57
grapex_vipul: Cool. Not kidding about the hackathon btw18:57
SlickNikSo I'm good with this one as well.18:57
cp16neti think its straight forward18:57
robertmyers+118:58
SlickNik#startvote Allow configs to be rendered based on datastore version? yes, no18:58
openstackBegin voting on: Allow configs to be rendered based on datastore version? Valid vote options are yes, no.18:58
openstackVote using '#vote OPTION'. Only your last vote counts.18:58
robertmyers#vote yes18:58
cp16net#vote yes18:58
SlickNik#vote yes18:58
amcrn#vote yes18:58
vipul#vote yes18:58
esmute#vote yes18:58
denis_makogon#vote yes18:58
grapex_#vote yes18:58
NehaV#vote yes18:58
SlickNik#endvote18:58
openstackVoted on "Allow configs to be rendered based on datastore version?" Results are18:58
openstackyes (9): SlickNik, robertmyers, denis_makogon, amcrn, cp16net, esmute, NehaV, vipul, grapex_18:58
SlickNikOkay, go for it cp16net18:59
SlickNikAnd that's all we have time for this week.18:59
SlickNik#endmeeting18:59
openstackMeeting ended Mon May  5 18:59:37 2014 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)18:59
openstackMinutes:        http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-05-05-18.00.html18:59
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-05-05-18.00.txt18:59
openstackLog:            http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-05-05-18.00.log.html18:59
cp16netthanks ev118:59
SlickNikThanks all!18:59
SlickNikI'll update the BP wiki page with notes / and move the unfinished business to next week19:00
denis_makogonif anyone want to discuss dblog API, i'm here =)19:00
denis_makogonbtw, next week is summit19:00
SlickNiknext meeting*19:00
dougshelley66SlickNik will there be IRC meetings next week?19:02
ashishsnigamSlickNik, denis_makogon: Can we now have a discussion on tempest?19:02
denis_makogonashishsnigam, of course19:03
ashishsnigampeterstac: u there?19:03
denis_makogonashishsnigam, as SlickNik said, you can add default datastore inside the devstack19:03
peterstacashishsnigam: hi19:03
SlickNikdougshelley66: Probably not, since most people will be at the summit. Will update everyone on Wednesday with concrete plans.19:03
denis_makogonashishsnigam, future plans should not bother you, if it blocks you from significant work (tests)19:04
dougshelley66SlickNik great thx19:04
SlickNikashishsnigam: Sure thing.19:05
SlickNikashishsnigam: So if you are writing datastore tests, and need a default datastore set, I would update the devstack trove install in lib/trove to do that.19:07
ashishsnigamSlickNik: Thanks a lot19:08
ashishsnigamI think only after that we can proceed with most of trove tests.19:09
SlickNikashishsnigam / peterstac: I'm really close to getting a ci-infra job set up for building a guest-image that devstack will be able to use as well. Hope to have it done by mid-end of this week.19:09
peterstacSlickNik: Sounds good19:09
*** grapex has joined #openstack-trove19:09
SlickNikashishsnigam: yes, as peterstac earlier pointed out you're going to need to be able to have a way of actually spinning up a guest for most other tests.19:10
ashishsnigamSlickNik: Cool19:10
ashishsnigamSlickNik: Ok19:10
denis_makogonvipul, ping19:11
vipuldenis_makogon: what's up19:11
denis_makogonvipul, i update wiki page, have you got 2-3 mins to review changes ?19:12
vipuldb logs?19:12
denis_makogonvipul, https://wiki.openstack.org/wiki/Trove/DBInstanceLogOperation19:12
denis_makogonvipul, yes19:12
vipuldenis_makogon: what are the endponts you are introducing?19:12
denis_makogonvipul, create, list with filters19:13
*** grapex_ has quit IRC19:13
denis_makogonvipul, create, list, show19:13
vipulwhat is the exact URL?19:14
*** jasonb365 has joined #openstack-trove19:14
*** yogeshmehra has quit IRC19:14
denis_makogonvipul, /{tenant_id}/dblogs19:15
vipulso why would you choose to make it a high-level resource vs. a subresource of an instance19:16
ashishsnigamSlickNik, peterstac: https://etherpad.openstack.org/p/TroveTempestTesting19:16
denis_makogonvipul, this one for listing the logs19:16
ashishsnigamAre we following this BP?19:16
denis_makogonvipul, /{tenant_id}/instances/{id}/dblog/{db_log}/create - for creating the log19:17
vipuldenis_makogon: to me, it seems like logs are owned by instances, so all operations should be as subresources of instances19:17
vipullet me gist something up really quick19:17
denis_makogonvipul, datastore owns the log description, instance owns the log files19:17
peterstacashishsnigam, SlickNik: Yes, I believe so - but it might be a bit out of date19:18
peterstacashishsnigam, SlickNik: We're also using https://etherpad.openstack.org/p/trove-tempest-items to keep track (I think you know that though ;) )19:20
SlickNikashishsnigam: These notes from the latest midcycle meetup are somewhat more recent: https://etherpad.openstack.org/p/trove-2014-meetup-tempest19:21
vipuldenis_makogon: https://gist.github.com/vipulsabhaya/c5191159612179b685a319:21
*** radez is now known as radez_g0n319:22
ashishsnigamThanks peterstac, SlickNik19:22
denis_makogonvipul, that's what i meant https://gist.github.com/denismakogon/e92b83f745abb093919019:23
denis_makogonvipul, we're not tracking the db logs at the backend19:24
*** coolsvap is now known as coolsvap|afk19:24
denis_makogonvipul, we're tracking the available logs, that were written by the deployer at conf file19:24
vipuldenis_makogon: sure ok, so even if we're not saving dblogs are records.. how does that impact the API i posted19:25
denis_makogonvipul, https://gist.github.com/vipulsabhaya/c5191159612179b685a3#file-gistfile1-txt-L29 has another look19:26
vipulBTW, these are important points to call out in a BP as well..19:26
vipullet me edit the swift URL19:26
denis_makogonvipul, Database section is empty - it means that logs are not tracked19:27
denis_makogonvipul, https://wiki.openstack.org/wiki/Trove/DBInstanceLogOperation#Get_the_list_of_all_available_database_logging_files_for_all_datastore_versions._HTTP_method_GET this is how it looks like19:27
vipuldenis_makogon: i think it would be more meaningful for others to say.. database changes are not required because dblogs are not tracked as a resource or something like that19:29
denis_makogonvipul, ok19:29
denis_makogonvipul, dblog itself is a sub-resource of the datastore, but actual log file is a sub-resource of the instance of course19:29
*** ranjitha has quit IRC19:29
*** sbfox has quit IRC19:30
vipulok so.. why is it necessary to provide a list operation where you get all datastores + all logs files in a single call19:30
openstackgerritPeter Stachowski proposed a change to openstack/python-troveclient: Fix trove CLI help UUID references  https://review.openstack.org/9218919:30
*** aratim has joined #openstack-trove19:30
vipulas opposed to, having /datastores/{datastore}/logs as the only way to available logs, for a single datastore19:30
denis_makogonvipul, when i wrote that i thought that it will be very informal to user19:31
ashishsnigamSlickNik peterstac: latest midcycle notes are really good points for me.19:32
vipulseems unnecessary to me..19:32
denis_makogonvipul, but, i guess, it can be eliminated  in favor of show operation19:32
denis_makogonvipul, you're right19:32
vipulok denis_makogon -- now moving on to save operation19:32
denis_makogonvipul, i'm gonna drop that section19:32
vipulthat route... i don't quite understand it19:33
peterstacashishsnigam: Good stuff - if you need any clarifications, you know where to find SlickNik ;)19:33
ashishsnigam:)19:33
vipulseems like all you need is /tenant_id/instances/{id}/logs and a request payload that has the name(s) of the log files you wanna save19:33
vipuldenis_makogon why is the filename, instance_id redundant in the body + url19:34
peterstacashishsnigam: Will you be at the summit next week in ATL?19:34
denis_makogonvipul, seems valid19:35
denis_makogonvipul, thanks19:35
*** ranjitha has joined #openstack-trove19:35
*** sbfox has joined #openstack-trove19:35
denis_makogonvipul, done19:35
vipulok so now you shoudl talk about how does one configure what logs are available to save19:36
vipuland what about the swift object naming?  it seems like container/file you have in the location attribute.. should really indicate timestamp or something19:37
denis_makogonvipul, it can be accomplished through dict option, specific to datastore19:37
*** ranjitha has quit IRC19:37
vipulcan you please give those examples19:37
vipuland why are we calling everything a 'dblog' -- isn't the idea to allow system logs to be saved as well if we want?19:37
vipuljust call it 'logs'19:37
denis_makogonallowed_logs = {general_log': '/var/log/mysql/mysql.log', 'log_slow_queries': '/var/log/mysql/mysql-slow.log',}19:37
denis_makogonvipul, {instance_id} + {path according to income filename} + {daytime}.log19:39
denis_makogonvipul, i think it's more than enough for name convention19:39
vipulwhy isn't instance_id just a container19:39
vipulis naming convention something that you configure in guestagent.conf?19:40
*** sbfox has quit IRC19:40
denis_makogonyes19:40
vipulif so, what are available params i can compose a convention with19:40
vipulie. is the Guest keeping a list of keys that can be subsituted?19:41
denis_makogon%(instance_id)s + %(log_filename)s + %(daytime)s.log19:41
ashishsnigampeterstac: no19:41
vipulso if i want %(tenant_id)s is that allowed19:41
denis_makogoni guess no19:41
vipulhow does someone know that19:41
vipulwhy not keep it simple19:42
denis_makogonfilename + timestamp ?19:42
vipulsave it as 'dblogcontainer/{instance_id}/filename.timestamp19:42
peterstacashishsnigam: ok, thought we might touch base there to co-ordinate the trove/tempest stuff19:42
vipulit's fixed.. it's always the same19:42
peterstacashishsnigam: we'll do it through the etherpad then :)19:43
denis_makogonvipul, ok19:43
vipulwhat does manifest convention mean19:43
ashishsnigamsure :)19:44
denis_makogonvipul, container entity file type19:45
ashishsnigampeterstac: Thanks a lot and good night.19:45
denis_makogonvipul, plain text file, archive19:45
vipuldenis_makogon: are you planning to zip the log files?19:45
*** ashishsnigam has quit IRC19:45
denis_makogonvipul, yes19:45
denis_makogonvipul, it depends of conf values, that used for backups19:46
denis_makogon*depends on19:46
vipulwhat is the difference between allow_database_logging and 'allow_database_log_files_audit'19:48
vipuldenis_makogon19:48
denis_makogonvipul, i renamed that one to Storage container file extension19:48
*** michael-yu has quit IRC19:48
denis_makogonvipul,  allow_database_logging used for rendering database config file19:48
denis_makogonallow_database_log_files_audit - chained with allowed_files,19:49
vipuli still don't know what the difference is19:49
vipuldenis_makogon: please be clear when you state things.. don't just assume we all knkow19:50
vipulit might take 20 seconds to add a sentence of how/why you'd set it19:50
denis_makogonvipul, i'd better re-write configuration according to current changes19:51
denis_makogonvipul, will do that by the tomorrow19:51
vipulok19:51
denis_makogonvipul, can we talk tomorrow ?19:52
vipulsure i'll be arond19:52
denis_makogonlike at the same time19:52
denis_makogonvipul, thanks for your help19:52
vipulyup19:52
imsplitbitamcrn: you around?19:55
*** michael-yu has joined #openstack-trove19:56
*** ams0 has joined #openstack-trove20:01
*** grapex has quit IRC20:08
*** grapex has joined #openstack-trove20:08
*** NehaV has quit IRC20:10
*** ams0 has quit IRC20:11
iccha1hey SlickNik around? cp16net20:11
SlickNikiccha1: here, 'sup?20:11
*** ranjitha has joined #openstack-trove20:15
*** michael-yu has quit IRC20:23
*** achampion has quit IRC20:27
*** ams0 has joined #openstack-trove20:28
*** ranjitha has quit IRC20:29
*** michael-yu has joined #openstack-trove20:33
*** ranjitha has joined #openstack-trove20:33
*** ramashri has quit IRC20:35
cp16neticcha1: hollar20:47
iccha1SlickNik: cp16net so I was looking at the code and looks like the only patch call is for changing configurations and update instance is a put call https://github.com/openstack/trove/blob/1f3a4fda8712dadaa4f2fe743ac566907d31d3c1/trove/common/api.py#L18120:49
*** aratim1 has joined #openstack-trove20:50
iccha1so there are couple of approaches we can take here, One is we keep the PUT call and while updating name, the caller has to ensure the configuration reference is present as well20:50
iccha1we cannot modify this to patch call, since it would be breaking api contract20:51
iccha1we could add an additional patch call apart from put if we would like, to allow users to specify only one field to modify20:51
*** aratim has quit IRC20:52
dougshelley66iccha1 - for changing configurations, couldn't we add the new call and eventually deprecate patch?20:54
SlickNikiccha1: I'd be in favor of doing the latter (and frankly deprecate the current PUT call in juno)20:54
*** ams0 has quit IRC20:54
iccha1dougshelley66: changing configurations is a sperate resource path, this is changing instance20:54
dougshelley66iccha1: i understand; i was commenting on the question of consistency20:55
iccha1dougshelley66: u mean deprecate put?20:55
iccha1SlickNik: dougshelley66 yes i like the notion of deprecating put as well20:55
dougshelley66iccha1: i assume we only want to have one path to execute a "modify" and currently we have 2?20:56
dougshelley66so we should pick one and move forward with it?20:56
iccha1so the question being do we just add the patch call, and our put works only for configuration?20:56
iccha1dougshelley66: yes if we add patch we would have two20:56
iccha1for instance update20:56
dougshelley66kind of funny because the trove cli calls that modify for config "configuration-patch"20:57
dougshelley66i assume at that level is should be "configuration-modify"20:57
dougshelley66?20:57
dougshelley66anyone, don't mean to derail your discussion here20:57
dougshelley66s/anyone/anyway20:57
SlickNikdougshelley66: this is for attach not for patch, I think.20:57
SlickNikdougshelley66: i.e. attach config to an instance, not configuration-patch.20:58
iccha1yup20:58
SlickNikdougshelley66: The configuration-patch call is actually a PATCH call.20:58
SlickNikiccha1: Yes; no point in adding functionality to a call we're planning on deprecating.20:58
iccha1SlickNik: just wondering from a rest stand point if it is sound20:59
iccha1put call working only on partial fields of an instance20:59
iccha1but it is already like that20:59
SlickNikiccha1: The PUT call as it is today isn't sound.20:59
iccha1SlickNik: hehe u said exactly the same thing20:59
iccha1cool glad to know we re on the same page21:00
*** ramashri has joined #openstack-trove21:10
*** ams0 has joined #openstack-trove21:13
openstackgerritKevin Conway proposed a change to openstack/trove: Fix missing use of test config datastore version in tests  https://review.openstack.org/9220921:22
kevinconwaySlickNik: grapex: one liner bug fix for the trove tests: https://review.openstack.org/#/c/92209/21:24
*** ams0 has quit IRC21:24
*** ams0 has joined #openstack-trove21:24
grapexkevinconway: Oh man21:24
grapexvipul amcrn hub_cap: Can you all look at this? ^21:25
*** ams0_ has joined #openstack-trove21:30
*** ams0 has quit IRC21:30
*** denis_makogon has quit IRC21:30
openstackgerritPeter Stachowski proposed a change to openstack/python-troveclient: Correct grammar in trove CLI help  https://review.openstack.org/9221121:32
*** ams0_ has quit IRC21:35
*** ams0 has joined #openstack-trove21:55
*** ams0 has quit IRC21:58
*** ams0 has joined #openstack-trove21:58
SlickNikgrapex: Just noticed that these values are coming from the defaults in trove/tests/config.py, and that the default version there (mysql-5.5) doesn't match the version created by redstack during kick-start (5.5)21:59
SlickNikgrapex / kevinconway: if the version is not specified, it uses the default version. But in this case, the wrong version is explicitly specified, so the create-instance call will fail.22:00
grapexSlickNik: Ugh?22:01
SlickNikugh indeed :(22:02
*** ams0 has quit IRC22:03
SlickNikgrapex / kevinconway: Put in a comment to this effect in the review.22:07
SlickNikThanks for catching the issue.22:07
grapexSlickNik: Actually- you're saying the defaults in trove/tests/config.py don't match redstack?22:08
grapexI think the better approach is to leave this review unmerged but change trove-integration to generate a correct test file22:09
grapexEither way I guess22:09
grapexIt might make more sense for the default to do nothing22:09
grapexAs in, not explicitly specify the datastore_version22:10
*** jasonb365 has quit IRC22:17
*** kevinconway has quit IRC22:18
*** jcru has quit IRC22:21
*** robertmyers has quit IRC22:21
*** rueb7363 has quit IRC22:21
*** rueb7363 has joined #openstack-trove22:21
*** rueb7363 has quit IRC22:21
*** rueb7363 has joined #openstack-trove22:21
*** robertmyers has joined #openstack-trove22:21
*** demorris has quit IRC22:22
*** pdmars has quit IRC22:22
*** robertmyers has quit IRC22:26
*** ams0 has joined #openstack-trove22:26
*** aratim1 has quit IRC22:30
*** ranjitha has quit IRC22:32
*** doddstack has quit IRC22:36
*** michael-yu has quit IRC22:36
*** ramashri has quit IRC22:37
*** michael-yu has joined #openstack-trove22:39
*** grapex has quit IRC22:47
*** rueb7363 has quit IRC22:49
openstackgerritRamashri Umale proposed a change to openstack/trove: Fix prepare call for redis guest agent  https://review.openstack.org/8486322:51
*** mattgriffin has quit IRC22:53
*** jmontemayor has quit IRC22:59
*** ams0_ has joined #openstack-trove23:13
*** ams0_ has quit IRC23:15
*** ams0_ has joined #openstack-trove23:15
*** ams0 has quit IRC23:17
*** aratim has joined #openstack-trove23:17
*** aratim has quit IRC23:19
*** ams0_ has quit IRC23:20
*** amytron has joined #openstack-trove23:31
*** flaper87 is now known as flaper87|afk23:43
*** radez_g0n3 is now known as radez23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!