openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 00:05 |
---|---|---|
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats https://review.openstack.org/81682 | 00:05 |
*** michael-yu has quit IRC | 00:11 | |
*** michael-yu has joined #openstack-trove | 00:19 | |
*** amytron has quit IRC | 00:21 | |
*** radez is now known as radez_g0n3 | 00:22 | |
*** ramashri has joined #openstack-trove | 00:23 | |
*** radez_g0n3 is now known as radez | 00:27 | |
*** demorris has joined #openstack-trove | 00:38 | |
*** michael-yu has quit IRC | 00:40 | |
*** serverascode has quit IRC | 00:42 | |
*** serverascode has joined #openstack-trove | 00:43 | |
*** michael-yu has joined #openstack-trove | 00:47 | |
*** michael-yu has quit IRC | 00:59 | |
*** demorris has quit IRC | 01:00 | |
*** michael-yu has joined #openstack-trove | 01:00 | |
*** GeorgeLorch has quit IRC | 01:01 | |
*** mattgriffin has joined #openstack-trove | 01:04 | |
*** mattgriffin has quit IRC | 01:05 | |
*** shakamunyi has joined #openstack-trove | 01:05 | |
*** amcrn has quit IRC | 01:09 | |
*** michael-yu has quit IRC | 01:11 | |
*** michael-yu has joined #openstack-trove | 01:13 | |
*** yogeshmehra has joined #openstack-trove | 01:14 | |
*** shakayumi has joined #openstack-trove | 01:15 | |
*** ams0 has joined #openstack-trove | 01:18 | |
*** shakamunyi has quit IRC | 01:18 | |
*** erkules_ has joined #openstack-trove | 01:20 | |
*** ams0 has quit IRC | 01:22 | |
*** robertmyers has joined #openstack-trove | 01:23 | |
*** robertmyers has quit IRC | 01:23 | |
*** yogeshmehra has quit IRC | 01:23 | |
*** erkules has quit IRC | 01:23 | |
*** robertmyers has joined #openstack-trove | 01:23 | |
*** yogeshmehra has joined #openstack-trove | 01:23 | |
*** ramashri has quit IRC | 01:24 | |
*** yogeshmehra has quit IRC | 01:28 | |
*** mattgriffin has joined #openstack-trove | 01:29 | |
*** achampion has joined #openstack-trove | 01:30 | |
*** achampion has quit IRC | 01:36 | |
*** achampion has joined #openstack-trove | 01:37 | |
*** saurabhs has quit IRC | 01:38 | |
*** erkules_ is now known as erkuls | 01:39 | |
*** erkuls is now known as erkules | 01:40 | |
*** sbfox has joined #openstack-trove | 01:41 | |
*** michael-yu has quit IRC | 02:01 | |
*** sbfox has quit IRC | 02:03 | |
*** jcooley has joined #openstack-trove | 02:07 | |
*** ams0 has joined #openstack-trove | 02:18 | |
*** ams0 has quit IRC | 02:23 | |
*** mattgriffin has quit IRC | 02:42 | |
*** sbfox has joined #openstack-trove | 02:53 | |
*** shakayumi has quit IRC | 02:58 | |
*** coolsvap|afk is now known as coolsvap | 03:04 | |
openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support (WORKINPROGRESS) https://review.openstack.org/88349 | 03:08 |
*** sbfox has quit IRC | 03:14 | |
*** sbfox has joined #openstack-trove | 03:18 | |
*** ams0 has joined #openstack-trove | 03:19 | |
*** coolsvap is now known as coolsvap|afk | 03:21 | |
*** ams0 has quit IRC | 03:23 | |
*** shalini_ has quit IRC | 03:27 | |
*** radez is now known as radez_g0n3 | 03:34 | |
*** coolsvap|afk is now known as coolsvap | 03:35 | |
*** ramishra has joined #openstack-trove | 03:37 | |
*** harlowja is now known as harlowja_away | 03:39 | |
*** robertmyers has quit IRC | 03:40 | |
*** robertmyers has joined #openstack-trove | 03:41 | |
*** jasonb365 has joined #openstack-trove | 03:43 | |
*** harlowja_away is now known as harlowja | 03:45 | |
*** robertmyers has quit IRC | 03:45 | |
*** jasonb365 has quit IRC | 03:50 | |
*** jasonb365 has joined #openstack-trove | 03:52 | |
*** jasonb365_ has joined #openstack-trove | 04:04 | |
*** jasonb365 has quit IRC | 04:05 | |
*** jasonb365_ is now known as jasonb365 | 04:05 | |
*** sbfox has quit IRC | 04:05 | |
*** haomaiwang has joined #openstack-trove | 04:16 | |
*** mattgriffin has joined #openstack-trove | 04:18 | |
*** ams0 has joined #openstack-trove | 04:19 | |
*** haomaiwang has quit IRC | 04:20 | |
*** ams0 has quit IRC | 04:24 | |
*** ViswaV_ has quit IRC | 04:26 | |
*** haomaiwa_ has joined #openstack-trove | 04:26 | |
*** ViswaV has joined #openstack-trove | 04:29 | |
*** ViswaV_ has joined #openstack-trove | 04:31 | |
*** ViswaV has quit IRC | 04:33 | |
*** global_ has joined #openstack-trove | 04:35 | |
*** haomaiwa_ has quit IRC | 04:43 | |
*** ams0 has joined #openstack-trove | 04:47 | |
*** sbfox has joined #openstack-trove | 04:49 | |
*** ams0 has quit IRC | 04:52 | |
*** ams0 has joined #openstack-trove | 04:54 | |
*** PeterSchwaller_ has joined #openstack-trove | 05:11 | |
*** PeterSchwaller has quit IRC | 05:14 | |
*** harlowja is now known as harlowja_away | 05:22 | |
*** haomaiwa_ has joined #openstack-trove | 05:23 | |
*** SushillKM has joined #openstack-trove | 05:27 | |
*** ams0 has quit IRC | 05:28 | |
*** ams0 has joined #openstack-trove | 05:28 | |
*** ams0 has quit IRC | 05:34 | |
*** yogeshmehra has joined #openstack-trove | 05:44 | |
*** shivam_ has quit IRC | 05:45 | |
*** shivamshukla has quit IRC | 05:45 | |
*** michael-yu has joined #openstack-trove | 05:46 | |
*** ams0 has joined #openstack-trove | 05:57 | |
*** mattgriffin has quit IRC | 05:59 | |
openstackgerrit | Yongli He proposed a change to openstack/trove: Use six.StringIO/BytesIO instead of StringIO.StringIO https://review.openstack.org/73911 | 06:00 |
openstackgerrit | Yongli He proposed a change to openstack/trove: Apply six for metaclass https://review.openstack.org/73136 | 06:03 |
*** haomaiwa_ has quit IRC | 06:07 | |
*** haomaiwang has joined #openstack-trove | 06:07 | |
*** ams0 has quit IRC | 06:08 | |
*** shivam has joined #openstack-trove | 06:10 | |
*** ams0 has joined #openstack-trove | 06:11 | |
*** cweidenkeller has quit IRC | 06:21 | |
*** haomai___ has joined #openstack-trove | 06:23 | |
*** haomaiwang has quit IRC | 06:26 | |
*** sbfox has quit IRC | 06:26 | |
*** ams0 has quit IRC | 06:30 | |
*** sbfox has joined #openstack-trove | 06:33 | |
*** sbfox has quit IRC | 06:38 | |
*** ashishsnigam has joined #openstack-trove | 06:49 | |
*** ramishra has quit IRC | 06:49 | |
*** DeepikaG has joined #openstack-trove | 07:00 | |
*** michael-yu has quit IRC | 07:04 | |
*** flaper87|afk is now known as flaper87 | 07:06 | |
*** global_ is now known as shalini_ | 07:07 | |
*** DeepikaG has quit IRC | 07:12 | |
openstackgerrit | Yongli He proposed a change to openstack/trove: Apply six for metaclass https://review.openstack.org/73136 | 07:20 |
openstackgerrit | Yongli He proposed a change to openstack/trove: Use six.StringIO/BytesIO instead of StringIO.StringIO https://review.openstack.org/73911 | 07:30 |
*** ramishra has joined #openstack-trove | 07:39 | |
*** ams0 has joined #openstack-trove | 08:15 | |
*** ramishra has quit IRC | 08:22 | |
*** jasonb365 has quit IRC | 08:34 | |
*** ramishra has joined #openstack-trove | 08:38 | |
*** ams0 has quit IRC | 08:48 | |
*** ams0 has joined #openstack-trove | 08:57 | |
*** dmakogon_ is now known as denis_makogon | 09:08 | |
*** yogeshmehra has quit IRC | 09:12 | |
*** ams0 has quit IRC | 09:13 | |
*** yogeshmehra has joined #openstack-trove | 09:13 | |
*** ams0 has joined #openstack-trove | 09:13 | |
*** yogeshmehra has quit IRC | 09:17 | |
*** ams0 has quit IRC | 09:17 | |
*** parstac_pete_ has joined #openstack-trove | 09:49 | |
*** peterstac has quit IRC | 09:50 | |
*** parstac_pete_ is now known as peterstac | 09:50 | |
denis_makogon | SlickNik, https://gist.github.com/denismakogon/897294c41e8a071ff34a | 10:16 |
denis_makogon | SlickNik, as i promise, this is how stack_update works | 10:16 |
denis_makogon | SlickNik, with guaranteed verification | 10:17 |
*** demorris has joined #openstack-trove | 10:18 | |
*** demorris has quit IRC | 10:51 | |
*** sgotliv has joined #openstack-trove | 11:26 | |
openstackgerrit | Pradeep Kumar Chandani proposed a change to openstack/trove: database-delete API is not validating database https://review.openstack.org/81186 | 11:41 |
*** ashishsnigam has quit IRC | 11:57 | |
*** sbfox has joined #openstack-trove | 12:08 | |
*** pdmars has joined #openstack-trove | 12:10 | |
*** konetzed has quit IRC | 12:19 | |
*** konetzed has joined #openstack-trove | 12:19 | |
*** haomaiwa_ has joined #openstack-trove | 12:44 | |
*** haomai___ has quit IRC | 12:45 | |
*** konetzed has quit IRC | 12:48 | |
*** sgotliv has quit IRC | 12:54 | |
*** konetzed has joined #openstack-trove | 12:55 | |
*** achampion has quit IRC | 12:55 | |
*** ramishra has quit IRC | 12:56 | |
*** haomai___ has joined #openstack-trove | 12:57 | |
*** haomaiwa_ has quit IRC | 12:57 | |
*** amytron has joined #openstack-trove | 12:58 | |
*** SushillKM has quit IRC | 13:01 | |
*** SushilKM has joined #openstack-trove | 13:01 | |
*** IvanZ has joined #openstack-trove | 13:02 | |
*** ashishsnigam has joined #openstack-trove | 13:07 | |
*** SushilKM has quit IRC | 13:10 | |
*** demorris has joined #openstack-trove | 13:10 | |
*** grapex has joined #openstack-trove | 13:14 | |
*** coolsvap is now known as coolsvap|afk | 13:15 | |
*** jcru has joined #openstack-trove | 13:28 | |
*** ramishra has joined #openstack-trove | 13:33 | |
*** radez_g0n3 is now known as radez | 13:33 | |
*** grapex has quit IRC | 13:34 | |
*** grapex has joined #openstack-trove | 13:35 | |
*** IvanZ has quit IRC | 13:36 | |
*** kevinconway has joined #openstack-trove | 13:40 | |
openstackgerrit | Kevin Conway proposed a change to openstack/trove: Fix missing use of test config datastore version in tests https://review.openstack.org/92209 | 13:43 |
*** kevinconway has quit IRC | 13:44 | |
*** kevinconway has joined #openstack-trove | 13:44 | |
*** achampion has joined #openstack-trove | 13:44 | |
*** rueb7363 has joined #openstack-trove | 13:46 | |
*** IvanZ has joined #openstack-trove | 13:47 | |
*** freyes has quit IRC | 14:09 | |
openstackgerrit | Peter Stachowski proposed a change to openstack/python-troveclient: Correct grammar in trove CLI help https://review.openstack.org/92211 | 14:11 |
openstackgerrit | Peter Stachowski proposed a change to openstack/python-troveclient: Fix trove CLI help UUID references https://review.openstack.org/92189 | 14:12 |
openstackgerrit | Peter Stachowski proposed a change to openstack/python-troveclient: Added check for empty attributes in trove CLI https://review.openstack.org/92162 | 14:14 |
*** demorris has quit IRC | 14:14 | |
*** robertmyers has joined #openstack-trove | 14:19 | |
*** haomai___ has quit IRC | 14:32 | |
*** haomaiwa_ has joined #openstack-trove | 14:32 | |
*** robertmyers has quit IRC | 14:33 | |
*** robertmyers has joined #openstack-trove | 14:34 | |
*** freyes has joined #openstack-trove | 14:37 | |
*** demorris has joined #openstack-trove | 14:42 | |
*** shivamshukla_ has joined #openstack-trove | 14:43 | |
*** ashishsnigam has quit IRC | 14:44 | |
*** PierreRambaud has quit IRC | 14:46 | |
*** NehaV has joined #openstack-trove | 14:46 | |
*** shakayumi has joined #openstack-trove | 14:51 | |
openstackgerrit | Peter Stachowski proposed a change to openstack/python-troveclient: Fix trove help for datastore-version-list and -show https://review.openstack.org/92382 | 14:59 |
*** aratim has joined #openstack-trove | 15:03 | |
*** ViswaV has joined #openstack-trove | 15:11 | |
*** jmontemayor has joined #openstack-trove | 15:14 | |
*** ViswaV_ has quit IRC | 15:16 | |
*** michael-yu has joined #openstack-trove | 15:18 | |
*** thedodd has joined #openstack-trove | 15:19 | |
*** jcooley has quit IRC | 15:19 | |
*** jcooley has joined #openstack-trove | 15:20 | |
*** jcooley has quit IRC | 15:24 | |
*** shivamshukla_ has quit IRC | 15:27 | |
*** SushillKM has joined #openstack-trove | 15:27 | |
*** michael-yu has quit IRC | 15:27 | |
*** sbfox has quit IRC | 15:27 | |
*** haomaiwa_ has quit IRC | 15:29 | |
*** haomaiwa_ has joined #openstack-trove | 15:30 | |
*** jasonb365 has joined #openstack-trove | 15:31 | |
*** shakayumi has quit IRC | 15:31 | |
*** shakamunyi has joined #openstack-trove | 15:32 | |
*** haomaiwa_ has quit IRC | 15:34 | |
*** IvanZ has quit IRC | 15:38 | |
*** setho has joined #openstack-trove | 15:40 | |
*** sbfox has joined #openstack-trove | 15:40 | |
openstackgerrit | Peter Stachowski proposed a change to openstack/python-troveclient: Fixed trove CLI help inconsistencies https://review.openstack.org/92394 | 15:42 |
*** mattgriffin has joined #openstack-trove | 15:42 | |
*** sbfox has quit IRC | 15:43 | |
*** aratim has left #openstack-trove | 15:45 | |
*** ViswaV has quit IRC | 15:46 | |
*** ViswaV has joined #openstack-trove | 15:47 | |
*** IvanZ has joined #openstack-trove | 15:58 | |
*** jcooley has joined #openstack-trove | 15:59 | |
*** jcooley has quit IRC | 15:59 | |
*** jcooley has joined #openstack-trove | 15:59 | |
*** ramashri has joined #openstack-trove | 16:00 | |
*** saurabhs has joined #openstack-trove | 16:01 | |
*** sgotliv has joined #openstack-trove | 16:01 | |
SushillKM | hello | 16:07 |
SushillKM | I wanted to know the purpose of https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/service.py#L52-L55 | 16:21 |
SushillKM | coz I think this is something wrong | 16:21 |
SushillKM | is anyone there | 16:21 |
SushillKM | who could confirm me the same | 16:21 |
*** ams0 has joined #openstack-trove | 16:22 | |
cp16net | SushillKM: whats up? | 16:23 |
SushillKM | hey cp16net | 16:23 |
amrith | SushillKM, what is the problem ur seeing | 16:23 |
SushillKM | how r u | 16:23 |
cp16net | i'm doing pretty well | 16:24 |
SushillKM | INCLUDE_MARKER_OPERATORS is used @ https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/service.py#L431 | 16:24 |
*** sbfox has joined #openstack-trove | 16:24 | |
kevinconway | SlickNik: grapex: this bug fix is updated and passes the tests: https://review.openstack.org/#/c/92209/ | 16:24 |
amrith | and 489 | 16:24 |
SushillKM | and also at https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/service.py#L489 | 16:24 |
SushillKM | and both the places | 16:24 |
SushillKM | it means column >='sometext' | 16:24 |
SushillKM | if include_marker = True | 16:25 |
amrith | are you asking for it to be quoted? | 16:25 |
SushillKM | nopes | 16:25 |
SushillKM | i m saying | 16:25 |
amrith | if include_marker is false it emits | 16:25 |
amrith | Marker > something | 16:26 |
amrith | if it is true it emits | 16:26 |
SushillKM | its should ---- True: "==" ------- | 16:26 |
SushillKM | and | 16:26 |
amrith | Marker >= something | 16:26 |
SushillKM | False: "<>" | 16:26 |
amrith | no | 16:26 |
amrith | include marker is used to decide whether or not you want to indicate the marker value. but always show what is greater than marker | 16:26 |
*** robertmyers has quit IRC | 16:26 | |
cp16net | no its listing the users | 16:26 |
amrith | see sample code that should be emited in the comment | 16:26 |
*** robertmyers has joined #openstack-trove | 16:26 | |
amrith | cp16net, correct | 16:26 |
amrith | see line 467 as an example | 16:27 |
cp16net | yeah that doc string is really helpful | 16:27 |
amrith | cp16net, if it is correct ;) | 16:27 |
SushillKM | ok now tell me | 16:27 |
SushillKM | how do u compare text to be >= text | 16:27 |
cp16net | true | 16:28 |
cp16net | but its been tested pretty well | 16:28 |
amrith | what? | 16:28 |
SushillKM | how can u say "sushilkm" >= "cp16net" | 16:28 |
amrith | alpha comparison is how mysql does it | 16:28 |
amrith | sure you can | 16:28 |
amrith | s > c | 16:28 |
*** robertmyers has quit IRC | 16:28 | |
amrith | so sushilkm > cp16net | 16:28 |
*** robertmyers has joined #openstack-trove | 16:28 | |
cp16net | i would argue thats wrong... :-P but yes that is true. | 16:28 |
SushillKM | hehehe cp16net | 16:29 |
SushillKM | i can prove thats wrong | 16:29 |
SushillKM | i guess this marker is used by extensions to check if database was existing before creating it | 16:30 |
cp16net | marker is used for pagination for listing the databases and users | 16:30 |
SushillKM | but seeing the code it doesnot looks like that | 16:31 |
SushillKM | if u see line 463 | 16:31 |
SushillKM | Marker = CONCAT(User, '@', Host) | 16:31 |
cp16net | so... | 16:32 |
*** ams0 has quit IRC | 16:32 | |
cp16net | Marker is the column | 16:32 |
cp16net | and marker is the kwarg | 16:32 |
cp16net | where marker was passed in api with the query param | 16:33 |
amrith | yup | 16:34 |
SushillKM | jst a sec | 16:34 |
cp16net | if its not working as expected can you make a test senario that would show it? | 16:35 |
SushillKM | can u see that | 16:35 |
SushillKM | https://github.com/openstack/trove/blob/master/trove/extensions/mysql/models.py#L296 | 16:35 |
cp16net | that would be great | 16:35 |
cp16net | thats for the database/schema list | 16:36 |
SushillKM | yup so thats what i m saying in my earlier links too | 16:37 |
cp16net | its the same concept as the user's marker | 16:37 |
cp16net | its just checking to see if the schema already exists | 16:37 |
cp16net | limit 1 including the marker=True | 16:38 |
amrith | cp16net, or excluding it from the output? no? | 16:38 |
cp16net | so you should only get one | 16:38 |
SushillKM | yeah but the point it is using marker=schema_name | 16:38 |
SushillKM | and include_marker=True | 16:38 |
amrith | cp16net, the exact one or the next one if it doesn't exist | 16:38 |
SushillKM | because of which a condition gets appended in list_database | 16:38 |
SushillKM | that | 16:39 |
cp16net | well that would mean you can only create 1 database | 16:39 |
SushillKM | schema_name >= 'what_we_sent_from_Schemas.load_with_client' | 16:39 |
cp16net | and never any more that fall later in the alphabet right? | 16:39 |
kevinconway | grapex: SlickNik: meh, looks like the jenkins job couldn't clean up after itself. all the tests passed though. | 16:39 |
kevinconway | anyway to re-run that? | 16:39 |
grapex | SlickNik: I've noticed that the retrigger button has changed | 16:40 |
openstackgerrit | Peter Stachowski proposed a change to openstack/python-troveclient: Fixed trove CLI help inconsistencies https://review.openstack.org/92394 | 16:41 |
esp | kevinconway: grapex: yeah I don’t know if SlickNik has to add you a user group to see the retrigger. | 16:41 |
grapex | esp SlickNik: I used to be in that group... uh-oh, is there something I should know about? '~' | 16:42 |
*** shakamunyi has quit IRC | 16:42 | |
esp | grapex: lol, no I think something did change config-wise but I can’t remember what SlickNik told me. | 16:43 |
grapex | esp: heh, ok | 16:43 |
grapex | J/k | 16:43 |
*** ams0 has joined #openstack-trove | 16:43 | |
esp | kevinconway: grapex: there is also this https://rdjenkins.dyndns.org/gerrit_manual_trigger/ | 16:44 |
grapex | I can't seem to get to that ip | 16:44 |
esp | hmm. let me check to see if I messed up the url | 16:45 |
esp | maybe SlickNik needs to adjust the secgroups on that ip or something | 16:45 |
esp | kevinconway: do you want me to try retrigger your job? | 16:45 |
kevinconway | esp: if you would please | 16:46 |
esp | k, lets see if it will let me | 16:46 |
esp | well it didn’t complain... | 16:47 |
esp | so, maybe go take a long lunch and everything will be cool when you return? | 16:47 |
*** casanch1 has joined #openstack-trove | 16:48 | |
* esp goes on a quick coffee run | 16:49 | |
*** michael-yu has joined #openstack-trove | 16:51 | |
*** michael-yu has quit IRC | 16:55 | |
openstackgerrit | Daniel Salinas proposed a change to openstack/trove: Adds the foundation for datastore capabilities https://review.openstack.org/83503 | 16:56 |
*** michael-yu has joined #openstack-trove | 16:56 | |
openstackgerrit | Peter Stachowski proposed a change to openstack/python-troveclient: Fixed help positional order of arguments https://review.openstack.org/92408 | 17:00 |
*** michael-yu has quit IRC | 17:02 | |
*** amcrn has joined #openstack-trove | 17:04 | |
*** ams0 has quit IRC | 17:06 | |
*** SushillKM has quit IRC | 17:06 | |
*** harlowja_away is now known as harlowja | 17:07 | |
SlickNik | denis_makogon: So that gist you linked earlier still doesn't have any sort of callback to trove, to verify that mysql is running after the resize. | 17:09 |
SlickNik | denis_makogon: So the issue with using heat to do trove resizes is still not fixed. | 17:09 |
SlickNik | denis_makogon: I thought you were driving that? | 17:10 |
SlickNik | kevinconway: Thanks for updating the patch to the tests. | 17:14 |
*** demorris has quit IRC | 17:14 | |
SlickNik | grapex: I had to update the gerrit trigger plugin for it to work correctly with the new version of gerrit that review.o.o is now using. | 17:15 |
grapex | SlickNik: Ah | 17:16 |
grapex | ok | 17:16 |
SlickNik | grapex: You should still be able to see the trigger button as long as you're logged in. | 17:17 |
SlickNik | The permissions are based off of this group - https://launchpad.net/~trove | 17:18 |
*** SushillKM has joined #openstack-trove | 17:21 | |
grapex | SlickNik: Ok, I'll try it soon | 17:24 |
grapex | I've got to go now though | 17:25 |
grapex | Talk to you all later | 17:25 |
grapex | and see you at the summit. :) | 17:25 |
SlickNik | later grapex! | 17:25 |
SushillKM | hey slicknik | 17:26 |
SlickNik | hey SushillKM | 17:28 |
SlickNik | How's it going? | 17:28 |
*** SushilKM has joined #openstack-trove | 17:28 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 17:29 |
SushilKM | wanted to discuss about this | 17:30 |
SushilKM | https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/service.py#L52-L55 | 17:30 |
*** SushillKM has quit IRC | 17:31 | |
*** ranjitha has joined #openstack-trove | 17:33 | |
SlickNik | SushilKM: what about it? | 17:34 |
SushilKM | i m not able to understand the purpose of >= | 17:34 |
SushilKM | because when i saw extensions code for database create | 17:35 |
SushilKM | https://github.com/openstack/trove/blob/master/trove/extensions/mysql/models.py#L296-L297 | 17:35 |
SushilKM | it passes schema_name as marker and include_marker as true to database_list method | 17:36 |
SlickNik | SushilKM: So the marker is used to aid pagination. | 17:36 |
SushilKM | and this leads to appending a condition | 17:36 |
SushilKM | schema_name >= 'database_to_be_created' | 17:36 |
*** ramishra has quit IRC | 17:36 | |
SushilKM | i did not understand this | 17:37 |
SushilKM | how cud it aid pagination | 17:37 |
openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support (WORKINPROGRESS) https://review.openstack.org/88349 | 17:37 |
SushilKM | I am seeing this | 17:38 |
SushilKM | https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql/service.py#L429-432 | 17:38 |
SlickNik | In that create call it's just using the marker to get a listing of that 1 database. | 17:38 |
SushilKM | though i started from there but anyways i wud still like to know how is this helping in pagination | 17:39 |
SlickNik | The general idea of using a marker in a list command is that it you use it to output databases in a sorted order after the marker. (up to a limit) | 17:40 |
SlickNik | As an example, if you have 26 schemas (let's say A-Z), and your page limit is 20. | 17:41 |
SlickNik | The output to your list command will show you only schemas A-T as part of your first page. | 17:41 |
SlickNik | You can then make a subsequent call to list, setting your marker as 'T'. | 17:41 |
SlickNik | And that would return schemas U-Z (or T-Z if you're using >=) as the response to your second call. | 17:42 |
SushilKM | ok i think i got that | 17:46 |
SushilKM | so marker was implemented for pagination stuff | 17:46 |
SushilKM | and later database-create api was written to take benefit of existent functionality of marker | 17:46 |
SushilKM | am I correct | 17:46 |
*** sbfox has quit IRC | 17:47 | |
SlickNik | Certainly looks that way from the code. | 17:47 |
SushilKM | okies | 17:47 |
SushilKM | but now i have a problem with the way create-database API in extensions try to do it | 17:48 |
SushilKM | if we create two databases | 17:48 |
SushilKM | testA and testa | 17:48 |
SushilKM | and retry creating them | 17:48 |
SushilKM | few times it would say it exists and few times it goes ahead | 17:48 |
SushilKM | which is because of this marker behavior | 17:48 |
*** eghobo has joined #openstack-trove | 17:49 | |
SushilKM | appended in query | 17:49 |
SlickNik | What makes the marker behavior non-deterministic? | 17:50 |
SushilKM | the query which executes to find the existence of schemas | 17:50 |
SushilKM | is | 17:50 |
SushilKM | SELECT schema_name as name, default_character_set_name as charset, default_collation_name as collation FROM information_schema.schemata WHERE schema_name NOT IN ('mysql', 'information_schema', 'lost+found', '#mysql50#lost+found') AND schema_name >= 'testA' ORDER BY schema_name ASC LIMIT 2 | 17:50 |
*** IvanZ has quit IRC | 17:50 | |
SushilKM | and sometimes this query results | 17:51 |
SushilKM | +-------+---------+-----------------+ | 17:51 |
SushilKM | | name | charset | collation | | 17:51 |
SushilKM | +-------+---------+-----------------+ | 17:51 |
SushilKM | | testA | utf8 | utf8_general_ci | | 17:51 |
SushilKM | | testa | utf8 | utf8_general_ci | | 17:51 |
SushilKM | +-------+---------+-----------------+ | 17:51 |
SushilKM | and sometimes opposite | 17:51 |
SushilKM | +-------+---------+-----------------+ | 17:51 |
SushilKM | | name | charset | collation | | 17:51 |
SushilKM | +-------+---------+-----------------+ | 17:51 |
SushilKM | | testa | utf8 | utf8_general_ci | | 17:51 |
SushilKM | | testA | utf8 | utf8_general_ci | | 17:51 |
SushilKM | +-------+---------+-----------------+ | 17:51 |
*** sbfox has joined #openstack-trove | 17:51 | |
SushilKM | because of which the diffrent behavior is encountered | 17:51 |
imsplitbit | hey guys can I get eyes on https://review.openstack.org/#/c/82123/ https://review.openstack.org/#/c/82124/ https://review.openstack.org/#/c/83503/ purdy please | 17:53 |
*** IvanZ has joined #openstack-trove | 17:54 | |
*** IvanZ has quit IRC | 17:55 | |
*** grapex has quit IRC | 17:57 | |
SushilKM | (#) | 17:57 |
*** coolsvap|afk is now known as coolsvap | 17:58 | |
dougshelley66 | SushilKM it looks related to using a case insensitive collation | 17:58 |
dougshelley66 | SushilKM having said that; mysql will usually still return the result set in a deterministic order | 17:59 |
SushilKM | i just used this to create them | 17:59 |
SushilKM | trove database-create <instance_id> testa | 17:59 |
cp16net | i hope its deterministic | 17:59 |
SushilKM | trove database-create <instance_id> testA | 17:59 |
cp16net | otherwise its a crap shoot | 18:00 |
SushilKM | so it was default collation | 18:00 |
dougshelley66 | the question is what is the collation of the connection to mysql whne yhou run that query above | 18:00 |
*** yogesh has joined #openstack-trove | 18:00 | |
SushilKM | so again that is done through trove's code itself i m not changing it manually everytime | 18:00 |
SushilKM | i m using the devstack setup for this | 18:01 |
*** casanch1 has quit IRC | 18:01 | |
*** eguz has joined #openstack-trove | 18:03 | |
*** eguz has quit IRC | 18:05 | |
*** SushilKM has quit IRC | 18:05 | |
*** eguz has joined #openstack-trove | 18:05 | |
cp16net | hmmm | 18:06 |
cp16net | i see the behavior now... | 18:06 |
*** eghobo has quit IRC | 18:06 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats https://review.openstack.org/81682 | 18:09 |
*** demorris has joined #openstack-trove | 18:09 | |
*** casanch1 has joined #openstack-trove | 18:09 | |
*** SushillKM has joined #openstack-trove | 18:09 | |
*** kevinconway has quit IRC | 18:09 | |
cp16net | SushillKM: make a bug.. | 18:09 |
cp16net | SushillKM: i see the same behavior | 18:09 |
kanzaros | SushilKM - you can also specify a collation on the column in the query - i.e. schema_name collate latin1_general_cs >= 'testA' | 18:10 |
SushillKM | yeah i got that ... i knew its a bug | 18:10 |
SushillKM | there r two ways to resolve | 18:10 |
*** kevinconway has joined #openstack-trove | 18:10 | |
cp16net | but its more deterministic than what you were saying from running the same creates ~20 times | 18:10 |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 18:10 |
SushillKM | since i was earlier not aware abt marker functionality | 18:10 |
kevinconway | anyone know why the gate is failing _after_ the tests pass? https://rdjenkins.dyndns.org/job/Trove-Gate/3583/console | 18:11 |
SushillKM | so it seems it wud need a small change in the functionality of create_database ..... | 18:11 |
SushillKM | in extensions | 18:11 |
SushillKM | @kanzaros ... since i m not running that query manually ... there is no point of putting collate in query for manual execution ... | 18:12 |
SushillKM | it wud need a change which i thnk has to work in marker functionality situation also ... | 18:12 |
SushillKM | anyways filing the bug ... | 18:12 |
*** jcooley has quit IRC | 18:13 | |
*** jcooley has joined #openstack-trove | 18:14 | |
*** jcooley has quit IRC | 18:14 | |
*** jcooley has joined #openstack-trove | 18:15 | |
SlickNik | back from standup. | 18:15 |
cp16net | SlickNik: so time to sitdown | 18:15 |
SlickNik | SushillKM: definitely sounds like a bug to me | 18:16 |
SushillKM | https://bugs.launchpad.net/trove/+bug/1316717 | 18:16 |
SlickNik | cp16net: already am (sitting down). | 18:16 |
SushillKM | i wanted to ask something about topy tool | 18:17 |
SushillKM | i tried it but it seems it works on files only and not directories | 18:17 |
SushillKM | would welcome any suggestions .... | 18:17 |
cp16net | SushillKM: i dunno what topy tool is | 18:18 |
SushillKM | huh | 18:19 |
SushillKM | i had put a patchset for correcting typos ... | 18:19 |
SushillKM | and other day some one used topy tool to find out typos .... | 18:19 |
cp16net | oh never heard of it... | 18:19 |
SushillKM | and later slicknik gave me a -1 and suggested to use topy tool and verify if thr r no more typos | 18:20 |
*** jcooley has quit IRC | 18:20 | |
cp16net | SushillKM: can you link me? | 18:20 |
*** ams0 has joined #openstack-trove | 18:20 | |
SushillKM | yeah just a sec | 18:20 |
SushillKM | https://github.com/intgr/topy | 18:20 |
*** michael-yu has joined #openstack-trove | 18:21 | |
SushillKM | but problem i faced while using the tool is it cud be used on a file and not a directory .... :( | 18:21 |
cp16net | hmm you could do some fancy bash to call it on every file | 18:21 |
*** sbfox has quit IRC | 18:22 | |
SushillKM | okies .... wud try that .... | 18:22 |
SushillKM | thanks for the suggestion ... | 18:22 |
cp16net | something i've done is use xargs | 18:22 |
cp16net | for example deleting all the *.pyc files | 18:23 |
cp16net | same concept | 18:23 |
SushillKM | and directories in directories | 18:23 |
cp16net | sure.. let me find my handy dandy alias i have for cleaning_pyc_files | 18:24 |
SushillKM | cool | 18:24 |
cp16net | alias clean_pyc_files='find . -name "*.pyc" -exec rm -rf {} \;' | 18:24 |
SushillKM | oh ya | 18:24 |
cp16net | well that one is using the -exec | 18:24 |
SushillKM | i forgot the -exec thing | 18:24 |
cp16net | but just do something like that :) | 18:24 |
SushillKM | cool | 18:24 |
SushillKM | thanks for reminder | 18:25 |
SushillKM | :) | 18:25 |
cp16net | pn | 18:25 |
cp16net | np | 18:25 |
*** sbfox has joined #openstack-trove | 18:31 | |
SushillKM | one more point i wanted to clarify .... rather take suggestion ... | 18:32 |
SushillKM | i was trying to setup with trove_volume_support=False | 18:33 |
SushillKM | everything went fine ... | 18:33 |
SushillKM | i was able to create an instance .... | 18:33 |
SushillKM | it came active too | 18:33 |
SushillKM | when i logged into guest instance found a problem | 18:34 |
SushillKM | that /dev/vdb was mounted as /mnt instead of /var/lib/mysql | 18:34 |
SushillKM | so i think this is a bug .... | 18:34 |
SushillKM | what say .... | 18:35 |
SushillKM | (#)(#)(#)(#)(#) | 18:35 |
SlickNik | SushillKM: I believe esmute has a review in flight to fix this issue. | 18:35 |
SushillKM | oh is it .... | 18:36 |
SushillKM | has he already checked-in the patchset | 18:36 |
SlickNik | https://review.openstack.org/#/c/81379/ | 18:36 |
esmute | SushillKM: restore on trove with ephemeral (trove_volume_support=False) fails due to this issue | 18:37 |
SushillKM | okies .... | 18:37 |
SushillKM | yeah it was same ..... | 18:37 |
*** ams0 has quit IRC | 18:42 | |
*** sriram_tesora has joined #openstack-trove | 18:43 | |
*** ams0 has joined #openstack-trove | 18:44 | |
*** jcooley has joined #openstack-trove | 18:46 | |
*** demorris has quit IRC | 18:47 | |
SushillKM | okies i wud test that .... | 18:48 |
SushillKM | thanks for the update slicknik | 18:48 |
*** casanch1 has quit IRC | 18:52 | |
*** coolsvap is now known as coolsvap|afk | 18:52 | |
*** grapex has joined #openstack-trove | 18:57 | |
*** demorris has joined #openstack-trove | 19:02 | |
*** demorris has quit IRC | 19:02 | |
*** IvanZ has joined #openstack-trove | 19:04 | |
*** IvanZ has quit IRC | 19:04 | |
*** grapex has quit IRC | 19:06 | |
*** ranjitha has quit IRC | 19:08 | |
*** jcooley has quit IRC | 19:10 | |
amrith | SushillKM, you may want to ping the other guy who used the tool | 19:12 |
amrith | he said he had a way to make it part of the tests | 19:12 |
amrith | that's why I -1'ed his change after you duped yours to it. | 19:12 |
SushillKM | yeah @amrith .. surely i wud complete it now got the hint .... (#) | 19:15 |
*** grapex has joined #openstack-trove | 19:17 | |
*** SushillKM has quit IRC | 19:19 | |
*** michael-yu has quit IRC | 19:22 | |
*** ams0 has quit IRC | 19:27 | |
*** ams0_ has joined #openstack-trove | 19:27 | |
*** michael-yu has joined #openstack-trove | 19:30 | |
*** jasonb365 has quit IRC | 19:30 | |
*** casanch1 has joined #openstack-trove | 19:31 | |
*** grapex has quit IRC | 19:36 | |
*** sgotliv has quit IRC | 19:38 | |
amrith | SlickNik, got a second? | 19:46 |
*** eguz has quit IRC | 19:55 | |
*** eghobo has joined #openstack-trove | 19:55 | |
*** casanch1 has quit IRC | 19:57 | |
kevinconway | SlickNik: that bug fix cleared: https://review.openstack.org/#/c/92209/ | 20:00 |
*** jcooley has joined #openstack-trove | 20:00 | |
*** harlowja has quit IRC | 20:01 | |
*** jcooley has quit IRC | 20:01 | |
*** casanch1 has joined #openstack-trove | 20:04 | |
*** harlowja has joined #openstack-trove | 20:04 | |
*** jasonb365 has joined #openstack-trove | 20:04 | |
*** ranjitha has joined #openstack-trove | 20:06 | |
*** ams0_ has quit IRC | 20:07 | |
SlickNik | amrith: here now. | 20:15 |
*** jasonb365 has quit IRC | 20:15 | |
SlickNik | kevinconway: Neat; thanks for the quick response! :) | 20:16 |
*** ams0 has joined #openstack-trove | 20:17 | |
*** freyes has quit IRC | 20:32 | |
*** freyes_ has joined #openstack-trove | 20:32 | |
*** dmakogon has joined #openstack-trove | 20:35 | |
*** jcooley has joined #openstack-trove | 20:38 | |
dmakogon | vipul, ping | 20:39 |
*** denis_makogon has quit IRC | 20:40 | |
*** dmakogon is now known as denis_makogon | 20:40 | |
*** dmakogon_ has joined #openstack-trove | 20:40 | |
*** jcooley has quit IRC | 20:41 | |
*** jcooley has joined #openstack-trove | 20:42 | |
*** michael-yu has quit IRC | 20:43 | |
*** saurabhs has quit IRC | 20:45 | |
*** saurabhs has joined #openstack-trove | 20:45 | |
*** michael-yu has joined #openstack-trove | 20:46 | |
*** jcooley has quit IRC | 20:46 | |
*** jcooley has joined #openstack-trove | 20:49 | |
*** sgotliv has joined #openstack-trove | 20:52 | |
*** jcooley has quit IRC | 20:54 | |
*** jcooley has joined #openstack-trove | 20:54 | |
*** freyes_ has quit IRC | 20:55 | |
*** ams0 has quit IRC | 20:58 | |
*** jcooley_ has joined #openstack-trove | 20:59 | |
*** jcooley has quit IRC | 20:59 | |
*** casanch1 has quit IRC | 21:00 | |
*** jcooley_ has quit IRC | 21:01 | |
*** jcooley has joined #openstack-trove | 21:02 | |
*** jcooley_ has joined #openstack-trove | 21:03 | |
*** ams0 has joined #openstack-trove | 21:03 | |
*** jcooley_ has quit IRC | 21:05 | |
*** freyes has joined #openstack-trove | 21:05 | |
*** harlowja has quit IRC | 21:05 | |
*** jcooley has quit IRC | 21:06 | |
*** casanch1 has joined #openstack-trove | 21:06 | |
*** jcooley has joined #openstack-trove | 21:10 | |
*** casanch1 has quit IRC | 21:10 | |
*** sriram_tesora has quit IRC | 21:11 | |
*** pdmars has quit IRC | 21:11 | |
*** jcooley has quit IRC | 21:11 | |
*** jcooley has joined #openstack-trove | 21:12 | |
*** ams0 has quit IRC | 21:12 | |
*** harlowja has joined #openstack-trove | 21:12 | |
*** jmontemayor has quit IRC | 21:14 | |
*** jcooley has quit IRC | 21:16 | |
*** jcooley has joined #openstack-trove | 21:16 | |
*** sgotliv has quit IRC | 21:18 | |
*** eguz has joined #openstack-trove | 21:18 | |
*** ams0 has joined #openstack-trove | 21:19 | |
openstackgerrit | Michael Yu proposed a change to openstack/trove: Adds backup/restore support for couchbase https://review.openstack.org/86731 | 21:21 |
openstackgerrit | Michael Yu proposed a change to openstack/trove: Add support for 'trove root-enable' in Couchbase https://review.openstack.org/81640 | 21:21 |
*** eghobo has quit IRC | 21:22 | |
*** saurabhs has quit IRC | 21:24 | |
openstackgerrit | Michael Yu proposed a change to openstack/trove: Adds backup/restore support for couchbase https://review.openstack.org/86731 | 21:26 |
*** jcooley has quit IRC | 21:29 | |
*** jcooley has joined #openstack-trove | 21:30 | |
*** jcooley_ has joined #openstack-trove | 21:30 | |
*** saurabhs has joined #openstack-trove | 21:31 | |
*** robertmyers has quit IRC | 21:34 | |
*** jcooley has quit IRC | 21:34 | |
*** robertmyers has joined #openstack-trove | 21:34 | |
*** jcooley_ has quit IRC | 21:36 | |
*** jcooley has joined #openstack-trove | 21:36 | |
*** jcooley has quit IRC | 21:41 | |
*** ams0 has quit IRC | 21:42 | |
*** ams0 has joined #openstack-trove | 21:46 | |
cp16net | i'll be on later peace out | 21:52 |
*** rueb7363 has quit IRC | 21:55 | |
*** jcooley has joined #openstack-trove | 21:55 | |
*** amytron has quit IRC | 22:00 | |
*** PeterSchwaller_ has quit IRC | 22:05 | |
*** PeterSchwaller has joined #openstack-trove | 22:06 | |
*** robertmyers has quit IRC | 22:06 | |
openstackgerrit | Michael Yu proposed a change to openstack/trove: Adds backup/restore support for couchbase https://review.openstack.org/86731 | 22:12 |
*** kevinconway has quit IRC | 22:18 | |
*** jcru has quit IRC | 22:18 | |
*** ams0 has quit IRC | 22:20 | |
*** achampion has quit IRC | 22:23 | |
denis_makogon | cp16net, congrats | 22:26 |
*** ams0 has joined #openstack-trove | 22:26 | |
*** NehaV has quit IRC | 22:35 | |
*** yogesh has quit IRC | 22:43 | |
*** thedodd has quit IRC | 22:43 | |
*** ranjitha has quit IRC | 22:45 | |
*** denis_makogon has quit IRC | 22:53 | |
*** mattgriffin has quit IRC | 22:53 | |
*** eguz has quit IRC | 22:56 | |
*** michael-yu has quit IRC | 22:56 | |
*** michael-yu has joined #openstack-trove | 22:57 | |
*** michael-yu has quit IRC | 22:57 | |
*** michael-yu has joined #openstack-trove | 23:02 | |
*** eghobo has joined #openstack-trove | 23:07 | |
*** eguz has joined #openstack-trove | 23:13 | |
*** eghobo has quit IRC | 23:17 | |
*** eguz has quit IRC | 23:19 | |
*** mattgriffin has joined #openstack-trove | 23:21 | |
*** achampion has joined #openstack-trove | 23:22 | |
*** sbfox has quit IRC | 23:35 | |
*** sbfox has joined #openstack-trove | 23:36 | |
*** ranjitha has joined #openstack-trove | 23:37 | |
*** sbfox has quit IRC | 23:52 | |
*** michael-yu has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!