*** matsuhashi has joined #openstack-trove | 00:31 | |
*** julienvey has joined #openstack-trove | 00:51 | |
*** julienvey has quit IRC | 00:55 | |
*** achampion has joined #openstack-trove | 01:17 | |
*** nosnos has joined #openstack-trove | 01:39 | |
*** julienvey has joined #openstack-trove | 01:52 | |
*** julienvey has quit IRC | 01:56 | |
*** ramishra has joined #openstack-trove | 02:23 | |
*** ramishra has quit IRC | 02:42 | |
*** ramishra has joined #openstack-trove | 02:43 | |
*** imsplitbit has joined #openstack-trove | 02:45 | |
*** julienvey has joined #openstack-trove | 02:52 | |
*** dkehn__ has joined #openstack-trove | 02:54 | |
*** achampio1 has joined #openstack-trove | 02:54 | |
*** achampion has quit IRC | 02:56 | |
*** dkehn_ has quit IRC | 02:57 | |
*** julienvey has quit IRC | 02:57 | |
*** robe5515 has quit IRC | 03:02 | |
*** robe5515 has joined #openstack-trove | 03:29 | |
*** achampio1 has quit IRC | 03:37 | |
*** matsuhashi has quit IRC | 03:39 | |
*** achampion has joined #openstack-trove | 03:46 | |
*** achampion has quit IRC | 03:52 | |
*** julienvey has joined #openstack-trove | 03:53 | |
*** nosnos has quit IRC | 03:54 | |
*** ramishra has quit IRC | 03:55 | |
*** julienvey has quit IRC | 03:58 | |
*** Longgeek has joined #openstack-trove | 04:13 | |
*** eghobo has joined #openstack-trove | 04:17 | |
*** achampion has joined #openstack-trove | 04:17 | |
*** ramishra has joined #openstack-trove | 04:34 | |
*** haomaiwang has joined #openstack-trove | 04:36 | |
*** robe5515 has quit IRC | 04:37 | |
*** matsuhashi has joined #openstack-trove | 04:39 | |
*** nosnos has joined #openstack-trove | 04:41 | |
*** nosnos has quit IRC | 04:46 | |
*** nosnos has joined #openstack-trove | 04:47 | |
*** julienvey has joined #openstack-trove | 04:54 | |
*** michael-yu has joined #openstack-trove | 04:54 | |
*** michael-yu has quit IRC | 04:57 | |
*** julienvey has quit IRC | 04:58 | |
*** achampion has quit IRC | 05:03 | |
*** fifieldt has joined #openstack-trove | 05:14 | |
*** coolsvap|afk has joined #openstack-trove | 05:17 | |
*** coolsvap|afk is now known as coolsvap | 05:18 | |
*** sgotliv has joined #openstack-trove | 05:22 | |
*** SnowDust has joined #openstack-trove | 05:27 | |
*** ajc_ has joined #openstack-trove | 05:29 | |
*** sgotliv has quit IRC | 05:33 | |
*** coolsvap is now known as coolsvap|afk | 05:33 | |
*** amytron has quit IRC | 05:34 | |
*** nosnos has quit IRC | 05:35 | |
*** nosnos has joined #openstack-trove | 05:37 | |
*** coolsvap|afk is now known as coolsvap | 05:41 | |
*** julienvey has joined #openstack-trove | 05:54 | |
*** achampion has joined #openstack-trove | 05:58 | |
*** julienvey has quit IRC | 05:59 | |
*** coolsvap is now known as coolsvap|afk | 06:03 | |
*** achampion has quit IRC | 06:04 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex https://review.openstack.org/100083 | 06:05 |
---|---|---|
*** matsuhashi has quit IRC | 06:05 | |
*** matsuhashi has joined #openstack-trove | 06:06 | |
*** Longgeek has quit IRC | 06:06 | |
*** Longgeek has joined #openstack-trove | 06:07 | |
*** matsuhashi has quit IRC | 06:11 | |
*** coolsvap|afk is now known as coolsvap | 06:13 | |
*** matsuhashi has joined #openstack-trove | 06:13 | |
*** matsuhashi has quit IRC | 06:19 | |
*** matsuhashi has joined #openstack-trove | 06:19 | |
*** SnowDust has quit IRC | 06:22 | |
*** coolsvap is now known as coolsvap|afk | 06:23 | |
*** openstackstatus has quit IRC | 06:27 | |
*** mat-lowery has quit IRC | 06:28 | |
*** ramishra has quit IRC | 06:28 | |
*** mat-lowery has joined #openstack-trove | 06:29 | |
*** Longgeek has quit IRC | 06:36 | |
*** Longgeek has joined #openstack-trove | 06:37 | |
*** eghobo has quit IRC | 06:37 | |
*** haomaiwang has quit IRC | 06:45 | |
*** ramishra has joined #openstack-trove | 06:53 | |
*** matsuhashi has quit IRC | 06:55 | |
*** julienvey has joined #openstack-trove | 06:55 | |
*** matsuhashi has joined #openstack-trove | 06:56 | |
*** julienvey has quit IRC | 07:00 | |
*** achampion has joined #openstack-trove | 07:01 | |
openstackgerrit | Shalini khandelwal proposed a change to openstack/trove: Initial support for Vertica Datastore in trove https://review.openstack.org/91761 | 07:02 |
*** ramishra has quit IRC | 07:04 | |
*** achampion has quit IRC | 07:05 | |
*** julienvey has joined #openstack-trove | 07:06 | |
*** ramishra has joined #openstack-trove | 07:08 | |
*** julienvey has quit IRC | 07:11 | |
*** bwil has joined #openstack-trove | 07:12 | |
*** coolsvap|afk is now known as coolsvap | 07:17 | |
*** sgotliv has joined #openstack-trove | 07:27 | |
*** coolsvap is now known as coolsvap|afk | 07:41 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/python-troveclient: use strutils.to_slug() instead of utils.slugify() https://review.openstack.org/95930 | 07:43 |
*** coolsvap|afk is now known as coolsvap | 07:54 | |
*** ihrachyshka has joined #openstack-trove | 07:59 | |
ihrachyshka | SlickNik: hey. what's the status of oslo.messaging port for Trove? | 07:59 |
*** sgotliv has quit IRC | 08:01 | |
*** achampion has joined #openstack-trove | 08:02 | |
*** achampion has quit IRC | 08:07 | |
*** sgotliv has joined #openstack-trove | 08:14 | |
*** ramishra has quit IRC | 08:16 | |
*** julienvey has joined #openstack-trove | 08:21 | |
*** makkie_ has quit IRC | 08:28 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix poll_until retriever when heat provisioning is enabled https://review.openstack.org/97194 | 08:57 |
*** ihrachyshka is now known as ihrachyshka|food | 08:59 | |
*** sgotliv has quit IRC | 09:02 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix tracking of SG's provisioned by Heat https://review.openstack.org/96795 | 09:04 |
*** ihrachyshka|food has quit IRC | 09:10 | |
*** sgotliv has joined #openstack-trove | 09:17 | |
SlickNik | ihrachyshka: esp is still working on it. The WIP patch is here: https://review.openstack.org/#/c/94484/ | 09:17 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add notifications for trove.instance.* actions https://review.openstack.org/101189 | 09:24 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Remove redundant heat templates from codebase https://review.openstack.org/99000 | 09:31 |
*** haomaiwa_ has joined #openstack-trove | 09:34 | |
*** haomaiwa_ has quit IRC | 09:39 | |
*** sgotliv has quit IRC | 09:45 | |
*** ihrachyshka has joined #openstack-trove | 09:55 | |
*** julienvey has quit IRC | 10:00 | |
*** haomaiwa_ has joined #openstack-trove | 10:23 | |
*** haomaiwa_ has quit IRC | 10:28 | |
*** haomaiwang has joined #openstack-trove | 10:34 | |
*** haomaiw__ has joined #openstack-trove | 10:47 | |
*** haomaiwang has quit IRC | 10:49 | |
*** ramishra has joined #openstack-trove | 10:53 | |
*** sgotliv has joined #openstack-trove | 11:02 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix updated timestamp for SecurityGroup model https://review.openstack.org/97510 | 11:10 |
*** coolsvap is now known as coolsvap|afk | 11:11 | |
*** julienvey has joined #openstack-trove | 11:19 | |
*** boden has joined #openstack-trove | 11:52 | |
*** ramishra has quit IRC | 11:57 | |
*** matsuhashi has quit IRC | 12:23 | |
*** matsuhashi has joined #openstack-trove | 12:23 | |
*** ramishra has joined #openstack-trove | 12:27 | |
*** matsuhashi has quit IRC | 12:28 | |
*** matsuhashi has joined #openstack-trove | 12:28 | |
*** pdmars has joined #openstack-trove | 12:33 | |
*** matsuhashi has quit IRC | 12:35 | |
*** pdmars has quit IRC | 12:35 | |
*** matsuhashi has joined #openstack-trove | 12:35 | |
*** pdmars has joined #openstack-trove | 12:36 | |
*** matsuhas_ has joined #openstack-trove | 12:38 | |
*** matsuhashi has quit IRC | 12:39 | |
*** ajc_ has quit IRC | 12:40 | |
*** ramishra_ has joined #openstack-trove | 12:50 | |
*** miqui has joined #openstack-trove | 12:50 | |
*** ramishra has quit IRC | 12:51 | |
*** ramishra_ has quit IRC | 13:00 | |
*** coolsvap|afk is now known as coolsvap | 13:01 | |
*** ramishra has joined #openstack-trove | 13:01 | |
*** matsuhas_ has quit IRC | 13:03 | |
*** matsuhashi has joined #openstack-trove | 13:03 | |
*** ramishra has quit IRC | 13:06 | |
*** matsuhashi has quit IRC | 13:08 | |
*** matsuhashi has joined #openstack-trove | 13:08 | |
*** matsuhashi has quit IRC | 13:13 | |
*** radez_g0n3 is now known as radez | 13:13 | |
*** pdmars has quit IRC | 13:14 | |
*** matsuhashi has joined #openstack-trove | 13:14 | |
*** pdmars has joined #openstack-trove | 13:14 | |
*** matsuhashi has quit IRC | 13:18 | |
*** dkehn__ is now known as dkehnx | 13:23 | |
*** ramishra has joined #openstack-trove | 13:23 | |
*** tvoran has joined #openstack-trove | 13:23 | |
*** nosnos has quit IRC | 13:29 | |
*** achampion has joined #openstack-trove | 13:34 | |
*** jcru has joined #openstack-trove | 13:38 | |
*** robe5515 has joined #openstack-trove | 13:48 | |
*** haomaiwang has joined #openstack-trove | 13:49 | |
*** haomaiw__ has quit IRC | 13:50 | |
*** haomaiw__ has joined #openstack-trove | 13:52 | |
*** haomaiwang has quit IRC | 13:54 | |
*** jcru has quit IRC | 13:58 | |
*** jcru has joined #openstack-trove | 13:59 | |
*** ramishra has quit IRC | 14:01 | |
*** ramishra has joined #openstack-trove | 14:01 | |
*** robe5515 has quit IRC | 14:20 | |
openstackgerrit | iccha-sethi proposed a change to openstack/trove: Allow users the ability to update the instance name https://review.openstack.org/92701 | 14:20 |
*** robe5515 has joined #openstack-trove | 14:21 | |
*** grapex has joined #openstack-trove | 14:27 | |
*** grapex has quit IRC | 14:28 | |
*** grapex has joined #openstack-trove | 14:28 | |
*** amytron has joined #openstack-trove | 14:34 | |
*** radez is now known as radez_g0n3 | 14:53 | |
boden | unit test question - I'm working on https://blueprints.launchpad.net/trove/+spec/pluggable-conductor-manager which is effectively adding a new conf prop... I don't see conf props being tested now; shall I add something or is that overkill? | 14:55 |
*** rwsu has joined #openstack-trove | 14:55 | |
*** sgotliv has quit IRC | 14:56 | |
*** sgotliv has joined #openstack-trove | 14:57 | |
sgotliv | dougshelley66, ping | 14:58 |
dougshelley66 | sgotliv hi | 14:58 |
sgotliv | dougshelley66, we have a small delay, few minutes | 14:58 |
dougshelley66 | sgotliv: no problem | 14:59 |
*** radez_g0n3 is now known as radez | 14:59 | |
*** ihrachyshka has quit IRC | 15:04 | |
*** jmontemayor has joined #openstack-trove | 15:06 | |
*** robertmyers has joined #openstack-trove | 15:17 | |
*** robertmyers has quit IRC | 15:19 | |
*** robertmyers has joined #openstack-trove | 15:19 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add backup size validation at restoring https://review.openstack.org/86300 | 15:22 |
openstackgerrit | Denis M. proposed a change to openstack/python-troveclient: Fix shell view for secgroup-* commands https://review.openstack.org/85314 | 15:25 |
*** bwil has quit IRC | 15:30 | |
*** dmakogon_ has quit IRC | 15:31 | |
*** kevinconway has joined #openstack-trove | 15:34 | |
*** ViswaV has joined #openstack-trove | 15:36 | |
*** sgotliv has quit IRC | 15:37 | |
*** ViswaV_ has joined #openstack-trove | 15:38 | |
iccha1 | hey cp16net https://review.openstack.org/#/c/82123/13/trove/common/api.py had a few concerns about the restful ness of instance metadata patch. feel free to ignore my rantings as I might lack context | 15:40 |
*** ViswaV has quit IRC | 15:41 | |
cp16net | iccha1: i think that comment is valid but i'd like use the api via curl or something to get a feel for this | 15:45 |
cp16net | i used the cmd line client and it made sense | 15:45 |
*** julienvey has quit IRC | 15:47 | |
*** sgotliv has joined #openstack-trove | 15:49 | |
*** eghobo has joined #openstack-trove | 15:51 | |
*** ViswaV_ has quit IRC | 15:52 | |
*** eghobo has quit IRC | 15:53 | |
*** jmontemayor has quit IRC | 15:57 | |
*** eghobo has joined #openstack-trove | 15:58 | |
iccha1 | cp16net: added one more comment | 16:00 |
cp16net | ok | 16:01 |
*** jmontemayor has joined #openstack-trove | 16:03 | |
*** jmontemayor_ has joined #openstack-trove | 16:04 | |
*** eguz has joined #openstack-trove | 16:07 | |
*** jmontemayor has quit IRC | 16:08 | |
*** amytron has quit IRC | 16:09 | |
*** ViswaV has joined #openstack-trove | 16:11 | |
*** eghobo has quit IRC | 16:11 | |
*** amytron has joined #openstack-trove | 16:13 | |
*** ramashri has joined #openstack-trove | 16:15 | |
*** ViswaV has quit IRC | 16:33 | |
*** robertmyers has quit IRC | 16:35 | |
*** robertmyers has joined #openstack-trove | 16:36 | |
*** eghobo has joined #openstack-trove | 16:40 | |
*** robertmyers has quit IRC | 16:40 | |
*** eguz has quit IRC | 16:42 | |
*** robertmyers has joined #openstack-trove | 16:44 | |
*** amcrn has joined #openstack-trove | 16:44 | |
*** jmontemayor_ has quit IRC | 16:45 | |
*** dkehn_ has joined #openstack-trove | 16:49 | |
*** boden_ has joined #openstack-trove | 16:50 | |
*** boden has quit IRC | 16:50 | |
*** jmontemayor has joined #openstack-trove | 16:50 | |
*** miqui_ has joined #openstack-trove | 16:50 | |
*** miqui has quit IRC | 16:51 | |
*** yidclare has joined #openstack-trove | 16:51 | |
*** dkehnx has quit IRC | 16:51 | |
*** boden has joined #openstack-trove | 16:53 | |
*** boden_ has quit IRC | 16:53 | |
*** sgotliv has quit IRC | 16:54 | |
*** boden has quit IRC | 16:54 | |
*** rueben has joined #openstack-trove | 16:58 | |
*** ViswaV has joined #openstack-trove | 17:03 | |
*** michael-yu has joined #openstack-trove | 17:06 | |
*** rueben has quit IRC | 17:09 | |
*** boden has joined #openstack-trove | 17:10 | |
*** rueben has joined #openstack-trove | 17:12 | |
*** ViswaV has quit IRC | 17:12 | |
*** amytron has quit IRC | 17:13 | |
*** ViswaV has joined #openstack-trove | 17:17 | |
*** eghobo has quit IRC | 17:17 | |
*** robertmyers has quit IRC | 17:18 | |
*** eghobo has joined #openstack-trove | 17:24 | |
*** ramishra has quit IRC | 17:25 | |
*** ramishra has joined #openstack-trove | 17:26 | |
*** ramishra_ has joined #openstack-trove | 17:27 | |
*** ramishra has quit IRC | 17:28 | |
*** ramashri has quit IRC | 17:33 | |
*** ramashri has joined #openstack-trove | 17:33 | |
*** mattgriffin has joined #openstack-trove | 17:36 | |
*** michael-yu has quit IRC | 17:38 | |
*** ramishra has joined #openstack-trove | 17:39 | |
*** Longgeek has quit IRC | 17:40 | |
*** ramishra_ has quit IRC | 17:41 | |
*** rueben has quit IRC | 17:42 | |
*** rueben has joined #openstack-trove | 17:45 | |
*** michael-yu has joined #openstack-trove | 17:48 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Added route for Admin API to support guest upgrade https://review.openstack.org/81410 | 17:52 |
openstackgerrit | iccha-sethi proposed a change to openstack/trove: Allow users the ability to update the instance name https://review.openstack.org/92701 | 17:53 |
*** ViswaV has quit IRC | 17:53 | |
*** ramishra has quit IRC | 17:53 | |
*** ViswaV has joined #openstack-trove | 17:55 | |
SlickNik | #startmeeting trove-bp-review | 18:00 |
openstack | Meeting started Mon Jun 23 18:00:57 2014 UTC and is due to finish in 60 minutes. The chair is SlickNik. Information about MeetBot at http://wiki.debian.org/MeetBot. | 18:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 18:00 |
*** demorris has joined #openstack-trove | 18:01 | |
openstack | The meeting name has been set to 'trove_bp_review' | 18:01 |
SlickNik | Agenda at: | 18:01 |
SlickNik | #link https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting#Agenda_for_Jun_23 | 18:01 |
SlickNik | Giving people a few minutes to show up. | 18:01 |
boden | o/ | 18:02 |
dougshelley66 | o/ | 18:02 |
glucas | o/ | 18:02 |
amrith | 0/ | 18:02 |
kevinconway | o/ | 18:02 |
peterstac | o/ | 18:02 |
amcrn | o/ | 18:02 |
esp | o/ | 18:02 |
iccha1 | o/ | 18:02 |
grapex | o/ | 18:02 |
tvoran | o/ | 18:03 |
schang | o/ | 18:03 |
SlickNik | Okay, let's get started. | 18:03 |
cp16net | hio | 18:03 |
SlickNik | #topic Heat integration | 18:03 |
SlickNik | #link https://blueprints.launchpad.net/trove/+spec/full-heat-integration | 18:03 |
vgnbkr | o | 18:03 |
SlickNik | denis_makogon? | 18:04 |
amrith | he's not online | 18:04 |
amrith | not even away ... | 18:04 |
SlickNik | hrm, also it seems to me that we discussed this last week and there were a couple of concerns. | 18:04 |
kevinconway | did you check dmakogan_ipod? | 18:05 |
SlickNik | There was a mailing list topic about it as well. | 18:05 |
*** demorris has quit IRC | 18:05 | |
SlickNik | Let's move on. | 18:05 |
SlickNik | I'll follow up with him offline if he had some specific question regarding it. | 18:05 |
SlickNik | #topic Configurable DB plugins | 18:06 |
SlickNik | #link https://blueprints.launchpad.net/trove/+spec/configurable-db-plugins | 18:06 |
boden | that's mine... BP in full is here: https://wiki.openstack.org/wiki/Trove/ConfigurableDBPlugins | 18:06 |
*** arist has joined #openstack-trove | 18:06 | |
boden | anyone get a chance to review? | 18:06 |
SlickNik | #link https://wiki.openstack.org/wiki/Trove/ConfigurableDBPlugins | 18:06 |
SlickNik | boden: I did. | 18:06 |
*** nehav has joined #openstack-trove | 18:06 | |
*** mriedem has joined #openstack-trove | 18:07 | |
SlickNik | Also had a chance to bounce some ideas off of a couple of other folks regarding this. | 18:07 |
boden | SlickNik -- comments / concerns / etc? | 18:07 |
dougshelley66 | boden - i had that question last week about whether other projects were doing this. Don't know if you had a chance to look into that | 18:08 |
*** ihrachyshka has joined #openstack-trove | 18:08 | |
SlickNik | Had a couple of concerns: 1. Can you define a scenario that uses this? I understand the part about the custom schemas, but what good would it do if trove wasn't aware of the said schemas. | 18:08 |
boden | dougshelley66 -- I didn't see others doing this | 18:09 |
SlickNik | And 2. Are there other OS Projects doing this. | 18:09 |
mriedem | does anyone here know if there was a conscious decision to make trove_api_workers default to None rather than 1 like trove_conductor_workers? | 18:09 |
vgnbkr | boden: why could the extra data not just be stored in a separate database? Why does Trove need to address this? | 18:10 |
*** ViswaV has quit IRC | 18:10 | |
boden | SlickNik -- re (1); adding a in-house extension / plugin which builds on trove... for example db logs which maintains details about when logs where captured... yes i know there is such a bp already, but for sake of arg one could add an API extension for it and then add db plugin to support the schema by leveraing trove's based sqlalchemy framework rather than re-implementing | 18:11 |
boden | SlickNik #2 -- haven't seen it done elsewhere | 18:13 |
SlickNik | I'm also a bit concerned about migrations. You do mention a path for migrations of custom tables. But my concern is around the custom migration scripts clobbering / overriding the schemas we're creating during normal trove migrations, which would end up causing subtle bugs. | 18:14 |
grapex | boden: I think I get what you're saying, but I think it would be difficult to make a facility like that upstream that would be as flexible as you'd want. You'd find yourself having to go back upstream for every tweak, and each time you'd be bombarded by questions which you (in my guess) wouldn't be able to give examples / reasons for. It would probably take just as long as if you made a seperate database and the featu | 18:14 |
grapex | re wouldn't be easily understood. | 18:14 |
*** rueben has quit IRC | 18:15 | |
vgnbkr | My concern with this is that it closely couples trove implementation to user implementation. These sorts of changes would make it difficult for Trove to change its implementation in the future, for no real benefit to Trove. | 18:15 |
*** sgotliv has joined #openstack-trove | 18:15 | |
vgnbkr | There may be cases where functionality is not possible without Trove support, but this just seems like a convenience feature. | 18:16 |
SlickNik | vgnbkr: agreed. | 18:17 |
SlickNik | I think this requires some cross-openstack discussion as well. | 18:17 |
SlickNik | The way we do sqlalchemy migrations is consistent with the rest of the OpenStack projects and has wider implications. | 18:17 |
boden | SlickNik -- in my PoC the plugins were totally separate tables in the database so overall seems low risk, however I can take these comments and re-think for next week | 18:18 |
boden | vgnbkr -- it does couple at the api /session level, but not higher... it allows those lower-level abstractions to leveraged easily to build upon whats in upstream trove core | 18:19 |
boden | SlickNik + vgnbkr; let me think on this for another week and we can revisit again next week... I've been side-tracked a bit lately on some non-openstack work so need to re-group | 18:20 |
SlickNik | boden: Sounds good. Can you perhaps also send out a thread on the ML asking for some cross-project feedback for this (or revive the old one?). I'd be curious to see what folks from other OS projects think about this. | 18:21 |
*** ihrachyshka has quit IRC | 18:21 | |
boden | SlickNik -- sure... just so we are on the same page tho; I'm talking about leveraging the sqlalchemy abstrations at the api/session level... these have not changed for awhile | 18:22 |
SlickNik | boden: yes, I understand. | 18:23 |
vgnbkr | boden: Right, but what if next year Openstack decides to use some other technology besides SqlAlchemy? | 18:23 |
SlickNik | boden: Thanks! | 18:23 |
*** ViswaV has joined #openstack-trove | 18:23 | |
cp16net | is that it? | 18:24 |
boden | cp16net - for my BP yes... I will take up deeper discussion off-line | 18:25 |
SlickNik | vgnbkr: That's a whole separate can of worms, and has been discussed at a couple of previous summits IIRC. (Folks decided against it IIRC) | 18:25 |
SlickNik | #topic Open Discussion | 18:25 |
cp16net | boden: sounds godo | 18:25 |
SlickNik | Did anyone have anything for open discussion related to BPs? | 18:26 |
* mriedem didn't realize this was a meeting :) | 18:26 | |
boden | I have question about implementing a BP... a bit off topic but I have your attention :) | 18:26 |
boden | I'm implementing https://blueprints.launchpad.net/trove/+spec/pluggable-conductor-manager which is effectively a new conductor conf property... do we need UTs for this? I haven't see trove or others really testing these via UTs | 18:27 |
SlickNik | boden: Let's talk about that after the meeting. | 18:27 |
SlickNik | That's all for now. | 18:28 |
SlickNik | #endmeeting | 18:28 |
openstack | Meeting ended Mon Jun 23 18:28:09 2014 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 18:28 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-06-23-18.00.html | 18:28 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-06-23-18.00.txt | 18:28 |
openstack | Log: http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-06-23-18.00.log.html | 18:28 |
SlickNik | Thanks guys! | 18:28 |
esp | thx SlickNik | 18:28 |
cp16net | thx | 18:28 |
amrith | thx SlickNik | 18:28 |
mriedem | nova certainly has unit tests for it's conductor | 18:28 |
mriedem | should have unit tests for everything... | 18:29 |
SlickNik | mriedem: We have unit tests for the conductor. | 18:29 |
boden | mreidem -- talking about CONF properties... I don't seem the individually tested | 18:29 |
SlickNik | mriedem: boden's talking about the CONF value that determines the conductor module to actually load, though. | 18:30 |
mriedem | so like unit test loading a fake or something | 18:30 |
SlickNik | mriedem: Yup, I think that's what needs to be done. | 18:31 |
vgnbkr | SlickNik: I was commenting that internal APIs are subject to change, rather than speaking specifically about SQLAlchemy. But good to know, so thanks. | 18:31 |
mriedem | vgnbkr: it's come up a couple times in nova | 18:31 |
SlickNik | boden: Can we have a fake conductor in the Unit tests that we load instead, and test that the fake got loaded correctly. | 18:31 |
mriedem | especially with nova objects | 18:31 |
boden | SlickNik + Mriedem - sure np... my comment is that it does not appear anyone else is testing such things right now | 18:31 |
mriedem | vgnbkr: i.e. remove the sqlalchemy api and have nova objects do direct sql | 18:32 |
mriedem | no one is working on that though as far as i know | 18:32 |
vgnbkr | mriedem: So hardcode for mysql? | 18:32 |
mriedem | vgnbkr: basically | 18:32 |
vgnbkr | (just out of curiosity) | 18:32 |
mriedem | which is of course bad if you're using something besdies mysql | 18:33 |
SlickNik | vgnbkr: I agree with your sentiment, just wanted to point out that it comes up every now and then. :) | 18:33 |
mriedem | *besides | 18:33 |
vgnbkr | mriedem: for performance reasons? | 18:33 |
mriedem | vgnbkr: yeah | 18:33 |
mriedem | ORM is heavy | 18:33 |
mriedem | might want to look at this https://blueprints.launchpad.net/nova/+spec/db-mysqldb-impl | 18:33 |
vgnbkr | Of course, but I'm surprised that it comes up in this context. | 18:33 |
vgnbkr | thx | 18:33 |
mriedem | rax already has some stuff internally where they override the main big nova db api calls and do directly to sql mysql calls | 18:34 |
*** demorris has joined #openstack-trove | 18:34 | |
vgnbkr | Yeah, for our other project we used Hibernate, but for the transactions stuff I had to code direct to db. | 18:35 |
*** eghobo has quit IRC | 18:35 | |
mriedem | btw, i've never stepped foot in trove before today when looking at how it's using trove_api_workers with respect to how the other projects are using api workers, because i'm moving some stuff to oslo to setting default workers | 18:37 |
mriedem | *for setting | 18:38 |
*** eghobo has joined #openstack-trove | 18:38 | |
SlickNik | mriedem: Looking at your previous question, I'm not sure if there was a specific reason the trove_api_workers was defaulted to None. | 18:39 |
*** rueben has joined #openstack-trove | 18:39 | |
mriedem | SlickNik: ok, trove appears to be the only integrated project to set api workers to None by default, rather than 1 | 18:39 |
mriedem | there is a subtle difference in the launcher used in the oslo service.py module | 18:39 |
mriedem | nova started defaulting api/conductor workers to the number of cpus, i'm moving to do the same for cinder atm, and looking at other projects | 18:40 |
*** isviridov is now known as isviridov|away | 18:40 | |
SlickNik | mriedem: I wonder if it's because of something RAX specific since they do some repose magic in front of their API servers for they prod deploy. | 18:40 |
*** rueben has quit IRC | 18:41 | |
SlickNik | in that case, grapex / cp16net might know a bit more. | 18:41 |
mriedem | SlickNik: not sure, i just assumed it was something that came about from looking at performance bottlenecks | 18:41 |
*** rueben has joined #openstack-trove | 18:42 | |
SlickNik | But I don't see why trove wouldn't want to / couldn't move to the same defaults. | 18:42 |
*** rueben has quit IRC | 18:42 | |
*** ViswaV has quit IRC | 18:43 | |
mriedem | SlickNik: oh the default workers thing wasn't rax | 18:43 |
mriedem | direct to sql was rax | 18:43 |
mriedem | nova changed default workers to number of CPUs as part of large ops testing in the gate | 18:44 |
*** rueben has joined #openstack-trove | 18:44 | |
*** eghobo has quit IRC | 18:45 | |
*** eghobo has joined #openstack-trove | 18:45 | |
grapex | SlickNik: The conductor thing was probably by accident, we don't need it like that for any reason I know of | 18:45 |
grapex | mriedem: ^ | 18:45 |
*** jmontemayor has quit IRC | 18:45 | |
cp16net | yeah i dont recall making any defaults based on CPUs | 18:46 |
mriedem | grapex: ok, thanks - technically there doesn't seem to be a difference in oslo | 18:46 |
mriedem | workers=None gives you a ServiceLauncher, workers > 0 gives you a ProcessLauncher with n services | 18:46 |
grapex | mriedem: Using the same arg to launch it in such different ways seems unexpected | 18:48 |
mriedem | http://git.openstack.org/cgit/openstack/oslo-incubator/tree/openstack/common/service.py#n508 | 18:49 |
mriedem | it is a bit odd | 18:49 |
mriedem | and not well documented | 18:49 |
mriedem | s/well// | 18:49 |
mriedem | i was wrong before, workers None or 1 is ServiceLauncher | 18:50 |
mriedem | > 1 is ProcessLauncher with n services | 18:50 |
grapex | I guess that makes sense | 18:50 |
mriedem | so trove is essentially the same as glance/cinder/ceilometer in that it's using a ServiceLauncher | 18:50 |
grapex | Assuming those two classes are very similar | 18:50 |
grapex | Well I know we're using the Process launcher here then | 18:50 |
*** ViswaV has joined #openstack-trove | 18:50 | |
mriedem | trove_api_workers defaults to None and trove_conductor_workers defaults to 1 | 18:51 |
*** michael-yu has quit IRC | 18:51 | |
mriedem | they come out to be the same thing | 18:51 |
grapex | mriedem: I just meant when deployed we're using the process launcher. Are you looking into getting rid of it? | 18:52 |
mriedem | no | 18:52 |
mriedem | looking to moving the default workers == number of cpus though | 18:52 |
mriedem | e.g. https://review.openstack.org/#/c/69266/ | 18:52 |
grapex | mriedem: Ah, cool. Thanks | 18:53 |
*** miqui_ is now known as miqui | 18:53 | |
SlickNik | mriedem: That makes sense. I wouldn't be opposed to that. | 18:54 |
mriedem | SlickNik: ok, sounds good | 18:55 |
*** rueben has quit IRC | 18:56 | |
*** rueben has joined #openstack-trove | 18:56 | |
*** yidclare has quit IRC | 18:59 | |
*** ramashri has quit IRC | 19:00 | |
*** esp has quit IRC | 19:09 | |
*** vipul has quit IRC | 19:10 | |
*** esmute has quit IRC | 19:10 | |
*** coolsvap is now known as coolsvap|afk | 19:16 | |
openstackgerrit | Greg Lucas proposed a change to openstack/trove: Add detach-replication support https://review.openstack.org/101981 | 19:16 |
*** sgotliv has quit IRC | 19:17 | |
*** mattgriffin has quit IRC | 19:22 | |
*** vipul has joined #openstack-trove | 19:23 | |
*** esp has joined #openstack-trove | 19:24 | |
*** SnowDust has joined #openstack-trove | 19:24 | |
*** esmute has joined #openstack-trove | 19:25 | |
*** jmontemayor has joined #openstack-trove | 19:38 | |
*** jmontemayor has quit IRC | 19:39 | |
*** jmontemayor has joined #openstack-trove | 19:39 | |
*** amytron has joined #openstack-trove | 19:45 | |
*** demorris has quit IRC | 19:48 | |
*** ramashri has joined #openstack-trove | 19:53 | |
*** mattgriffin has joined #openstack-trove | 19:54 | |
*** SnowDust has quit IRC | 19:57 | |
*** ihrachyshka has joined #openstack-trove | 19:58 | |
*** miqui has quit IRC | 19:58 | |
*** michael-yu has joined #openstack-trove | 19:59 | |
*** cweid has joined #openstack-trove | 19:59 | |
*** yidclare has joined #openstack-trove | 20:02 | |
*** ViswaV has quit IRC | 20:06 | |
*** boden has quit IRC | 20:09 | |
*** mriedem has quit IRC | 20:10 | |
*** mriedem has joined #openstack-trove | 20:11 | |
*** ViswaV has joined #openstack-trove | 20:20 | |
*** ViswaV_ has joined #openstack-trove | 20:20 | |
*** demorris has joined #openstack-trove | 20:23 | |
*** ViswaV has quit IRC | 20:25 | |
*** michael-yu has quit IRC | 20:34 | |
*** demorris has quit IRC | 20:38 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Updates RPC API to use oslo.messaging https://review.openstack.org/94484 | 20:39 |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 20:40 |
*** dkehn_ is now known as dkehnx | 20:41 | |
*** mriedem has left #openstack-trove | 20:45 | |
*** michael-yu has joined #openstack-trove | 20:51 | |
*** miqui has joined #openstack-trove | 20:57 | |
*** demorris has joined #openstack-trove | 20:59 | |
*** michael-yu has quit IRC | 21:01 | |
*** ramashri has quit IRC | 21:03 | |
*** michael-yu has joined #openstack-trove | 21:03 | |
*** ramashri has joined #openstack-trove | 21:03 | |
*** amcrn has quit IRC | 21:04 | |
*** pdmars has quit IRC | 21:05 | |
*** michael-yu has quit IRC | 21:08 | |
*** michael-yu has joined #openstack-trove | 21:10 | |
*** achampion has quit IRC | 21:16 | |
*** grapex has quit IRC | 21:19 | |
*** demorris has quit IRC | 21:22 | |
*** demorris has joined #openstack-trove | 21:22 | |
*** michael-yu has quit IRC | 21:25 | |
*** ihrachyshka has quit IRC | 21:39 | |
*** juantwo_ has joined #openstack-trove | 21:42 | |
*** juantwo has quit IRC | 21:42 | |
*** demorris has quit IRC | 21:42 | |
openstackgerrit | iccha-sethi proposed a change to openstack/trove: Allow users the ability to update the instance name https://review.openstack.org/92701 | 21:45 |
openstackgerrit | Greg Lucas proposed a change to openstack/trove: Add detach-replication support https://review.openstack.org/101981 | 22:00 |
*** rueben has quit IRC | 22:08 | |
*** robe5515 has quit IRC | 22:13 | |
*** annashen_ is now known as annashen | 22:21 | |
*** georgelorch has joined #openstack-trove | 22:27 | |
*** tvoran has quit IRC | 22:29 | |
*** demorris has joined #openstack-trove | 22:30 | |
*** ViswaV_ has quit IRC | 22:44 | |
*** yidclare has quit IRC | 22:45 | |
*** ViswaV has joined #openstack-trove | 22:46 | |
*** michael-yu has joined #openstack-trove | 22:51 | |
*** demorris has quit IRC | 22:51 | |
*** arist has left #openstack-trove | 22:54 | |
*** jcru has quit IRC | 22:55 | |
*** michael-yu has quit IRC | 22:56 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Use 'sudo install' for conf files instead of 'cp' https://review.openstack.org/102048 | 22:57 |
*** nehav has quit IRC | 22:57 | |
*** mattgriffin has quit IRC | 23:06 | |
*** kevinconway has quit IRC | 23:12 | |
*** amcrn has joined #openstack-trove | 23:21 | |
*** michael-yu has joined #openstack-trove | 23:27 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Use 'sudo install' for conf files instead of 'cp' https://review.openstack.org/102048 | 23:51 |
*** achampion has joined #openstack-trove | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!