| *** jmontemayor has quit IRC | 00:04 | |
| *** Riddhi has joined #openstack-trove | 00:05 | |
| *** kevinconway has quit IRC | 00:06 | |
| *** michael-yu has quit IRC | 00:25 | |
| *** amcrn has quit IRC | 00:52 | |
| *** topshare has joined #openstack-trove | 01:03 | |
| *** griff is now known as jgriffith | 01:11 | |
| *** mattgriffin has joined #openstack-trove | 01:18 | |
| *** rwsu has quit IRC | 01:18 | |
| *** michael-yu has joined #openstack-trove | 01:25 | |
| *** michael-yu has quit IRC | 01:26 | |
| *** topshare has quit IRC | 01:28 | |
| *** topshare has joined #openstack-trove | 01:29 | |
| openstackgerrit | Riddhi Shah proposed a change to openstack/trove: Associate flavor types with datastore versions https://review.openstack.org/109824 | 01:36 |
|---|---|---|
| *** robertmyers has joined #openstack-trove | 01:36 | |
| *** Barker has joined #openstack-trove | 01:37 | |
| *** nosnos has joined #openstack-trove | 01:38 | |
| *** haomaiwang has joined #openstack-trove | 01:43 | |
| *** haomaiwang has quit IRC | 01:44 | |
| *** haomaiwang has joined #openstack-trove | 01:45 | |
| *** ramashri has quit IRC | 01:50 | |
| *** haomaiw__ has joined #openstack-trove | 01:58 | |
| *** Riddhi has quit IRC | 01:58 | |
| *** Riddhi has joined #openstack-trove | 01:59 | |
| *** haomaiwang has quit IRC | 02:01 | |
| *** grapex has joined #openstack-trove | 02:02 | |
| *** Riddhi has quit IRC | 02:03 | |
| *** jmontemayor has joined #openstack-trove | 02:03 | |
| *** eghobo has quit IRC | 02:04 | |
| *** grapex_ has joined #openstack-trove | 02:05 | |
| *** topshare has quit IRC | 02:07 | |
| *** jmontemayor has quit IRC | 02:08 | |
| *** grapex has quit IRC | 02:09 | |
| *** jmontemayor has joined #openstack-trove | 02:10 | |
| *** topshare has joined #openstack-trove | 02:11 | |
| *** topshare has quit IRC | 02:22 | |
| *** topshare has joined #openstack-trove | 02:24 | |
| *** topshare has quit IRC | 02:39 | |
| *** topshare has joined #openstack-trove | 02:41 | |
| *** mattgriffin has quit IRC | 02:46 | |
| *** topshare has quit IRC | 02:50 | |
| *** topshare has joined #openstack-trove | 02:56 | |
| *** ramashri has joined #openstack-trove | 03:18 | |
| *** makkie has joined #openstack-trove | 03:18 | |
| *** ramashri has quit IRC | 03:22 | |
| *** eghobo has joined #openstack-trove | 03:24 | |
| *** ramashri has joined #openstack-trove | 03:25 | |
| *** nosnos has quit IRC | 03:28 | |
| *** robertmyers has quit IRC | 03:42 | |
| *** robertmyers has joined #openstack-trove | 03:42 | |
| *** robertmyers has quit IRC | 03:47 | |
| *** topshare has quit IRC | 03:51 | |
| *** topshare has joined #openstack-trove | 03:56 | |
| *** nosnos has joined #openstack-trove | 04:03 | |
| *** haomaiw__ has quit IRC | 04:09 | |
| *** haomaiwang has joined #openstack-trove | 04:10 | |
| *** eghobo has quit IRC | 04:15 | |
| *** Longgeek has joined #openstack-trove | 04:16 | |
| *** Longgeek has quit IRC | 04:18 | |
| *** Longgeek has joined #openstack-trove | 04:18 | |
| *** Longgeek has quit IRC | 04:19 | |
| *** Longgeek has joined #openstack-trove | 04:19 | |
| *** haomaiwang has quit IRC | 04:29 | |
| *** haomaiwa_ has joined #openstack-trove | 04:29 | |
| *** Barker has quit IRC | 04:36 | |
| *** eghobo has joined #openstack-trove | 04:36 | |
| *** eghobo has quit IRC | 04:36 | |
| *** eghobo has joined #openstack-trove | 04:36 | |
| *** jmontemayor has quit IRC | 04:44 | |
| *** ramashri has quit IRC | 04:52 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/python-troveclient: adding configuration paramters mgmt api https://review.openstack.org/79851 | 04:54 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/python-troveclient: adding configuration parameters mgmt api https://review.openstack.org/79851 | 04:54 |
| *** grapex_ has quit IRC | 05:03 | |
| *** haomaiwa_ has quit IRC | 05:04 | |
| *** haomaiwang has joined #openstack-trove | 05:04 | |
| *** haomaiw__ has joined #openstack-trove | 05:14 | |
| *** haomaiwang has quit IRC | 05:17 | |
| *** ViswaV has joined #openstack-trove | 05:20 | |
| *** dkehn_ has joined #openstack-trove | 05:22 | |
| *** dkehnx has quit IRC | 05:23 | |
| *** ramishra has joined #openstack-trove | 05:29 | |
| *** ViswaV has quit IRC | 05:32 | |
| *** juantwo has quit IRC | 05:32 | |
| *** topshare has quit IRC | 05:41 | |
| *** topshare has joined #openstack-trove | 05:45 | |
| *** jgriffit1 has joined #openstack-trove | 06:01 | |
| *** jgriffith has quit IRC | 06:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex https://review.openstack.org/108899 | 06:08 |
| *** flaper87|afk is now known as flaper87 | 06:13 | |
| *** fifieldt_ is now known as fifieldt | 06:15 | |
| *** michael-yu has joined #openstack-trove | 06:18 | |
| *** haomaiw__ has quit IRC | 06:19 | |
| *** fifieldt has quit IRC | 06:19 | |
| *** haomaiwang has joined #openstack-trove | 06:19 | |
| *** ramishra has quit IRC | 06:21 | |
| *** ramishra has joined #openstack-trove | 06:22 | |
| *** jgriffit1 is now known as jgriffith | 06:24 | |
| *** ramishra has quit IRC | 06:26 | |
| *** haomaiwang has quit IRC | 06:35 | |
| *** haomaiwang has joined #openstack-trove | 06:36 | |
| *** haomaiw__ has joined #openstack-trove | 06:42 | |
| *** haomaiwang has quit IRC | 06:42 | |
| openstackgerrit | A change was merged to openstack/trove: document running a small set of tests https://review.openstack.org/109023 | 06:49 |
| *** eghobo has quit IRC | 06:56 | |
| *** haomai___ has joined #openstack-trove | 06:58 | |
| *** haomaiw__ has quit IRC | 07:02 | |
| *** ramishra has joined #openstack-trove | 07:19 | |
| *** fifieldt has joined #openstack-trove | 07:23 | |
| *** ramishra_ has joined #openstack-trove | 07:24 | |
| *** ramishra has quit IRC | 07:24 | |
| *** ramishra_ has quit IRC | 07:54 | |
| *** ramishra has joined #openstack-trove | 07:54 | |
| *** boden has joined #openstack-trove | 07:58 | |
| *** ramishra has quit IRC | 07:59 | |
| *** ramishra has joined #openstack-trove | 08:08 | |
| *** haomai___ has quit IRC | 08:08 | |
| *** haomaiwang has joined #openstack-trove | 08:09 | |
| *** boblebauce has joined #openstack-trove | 08:09 | |
| *** ramishra has quit IRC | 08:11 | |
| *** ramishra has joined #openstack-trove | 08:12 | |
| *** ramishra has quit IRC | 08:16 | |
| *** michael-yu has quit IRC | 08:20 | |
| *** haomaiw__ has joined #openstack-trove | 08:24 | |
| openstackgerrit | A change was merged to openstack/trove: Reports enabled-root for restored instance https://review.openstack.org/72025 | 08:24 |
| *** haomaiwang has quit IRC | 08:26 | |
| *** michael-yu has joined #openstack-trove | 08:29 | |
| *** nosnos has quit IRC | 08:49 | |
| *** michael-yu has quit IRC | 08:49 | |
| *** marzif has joined #openstack-trove | 09:01 | |
| *** ramishra has joined #openstack-trove | 09:09 | |
| *** ramishra_ has joined #openstack-trove | 09:12 | |
| *** ramishra has quit IRC | 09:13 | |
| *** denis_makogon has joined #openstack-trove | 09:14 | |
| *** openstackgerrit has quit IRC | 09:16 | |
| *** openstackgerrit has joined #openstack-trove | 09:17 | |
| *** ramishra_ has quit IRC | 09:26 | |
| *** ramishra has joined #openstack-trove | 09:27 | |
| *** nosnos has joined #openstack-trove | 09:30 | |
| *** Longgeek_ has joined #openstack-trove | 09:31 | |
| *** ramishra has quit IRC | 09:31 | |
| *** Longgeek has quit IRC | 09:34 | |
| *** bharath has joined #openstack-trove | 09:36 | |
| *** erik_x1_ has joined #openstack-trove | 09:44 | |
| *** topshare has quit IRC | 09:44 | |
| *** flaper87 has quit IRC | 09:44 | |
| *** amrith has quit IRC | 09:44 | |
| *** sbadia has quit IRC | 09:44 | |
| *** dloi has quit IRC | 09:44 | |
| *** erik_x1 has quit IRC | 09:44 | |
| *** jcooley has quit IRC | 09:44 | |
| *** konetzed has quit IRC | 09:44 | |
| *** jcooley has joined #openstack-trove | 09:44 | |
| *** topshare has joined #openstack-trove | 09:45 | |
| *** flaper87 has joined #openstack-trove | 09:45 | |
| *** amrith has joined #openstack-trove | 09:45 | |
| *** dloi has joined #openstack-trove | 09:46 | |
| *** bharath has quit IRC | 09:47 | |
| *** sbadia has joined #openstack-trove | 09:47 | |
| *** konetzed has joined #openstack-trove | 09:49 | |
| *** ramishra has joined #openstack-trove | 09:51 | |
| *** ramishra has quit IRC | 10:03 | |
| *** ramishra has joined #openstack-trove | 10:04 | |
| *** ramishra has quit IRC | 10:09 | |
| *** nosnos has quit IRC | 10:22 | |
| *** IanGovett has joined #openstack-trove | 10:29 | |
| *** ramishra has joined #openstack-trove | 10:38 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/guestagent/datastore module https://review.openstack.org/107739 | 10:52 |
| *** topshare has quit IRC | 11:02 | |
| *** iartarisi has joined #openstack-trove | 11:05 | |
| *** ramishra has quit IRC | 11:11 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/mysql module https://review.openstack.org/107806 | 11:11 |
| *** ramishra has joined #openstack-trove | 11:12 | |
| *** ramishra has quit IRC | 11:17 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/mongodb https://review.openstack.org/107795 | 11:18 |
| *** ramishra has joined #openstack-trove | 11:43 | |
| *** mrsnivvel has quit IRC | 12:16 | |
| *** ramishra has quit IRC | 12:19 | |
| *** mrsnivvel has joined #openstack-trove | 12:29 | |
| *** mrsnivvel has quit IRC | 12:37 | |
| *** pdmars has joined #openstack-trove | 12:40 | |
| *** achampion has quit IRC | 12:44 | |
| *** mrsnivvel has joined #openstack-trove | 12:56 | |
| openstackgerrit | Paul Marshall proposed a change to openstack/trove: Remove accounts use of non-existent Nova extension https://review.openstack.org/110420 | 13:08 |
| *** jasondotstar has joined #openstack-trove | 13:09 | |
| *** topshare has joined #openstack-trove | 13:11 | |
| *** tvoran has joined #openstack-trove | 13:19 | |
| *** topshare has quit IRC | 13:23 | |
| *** topshare has joined #openstack-trove | 13:25 | |
| *** iartarisi has quit IRC | 13:29 | |
| *** IanGovett has quit IRC | 13:34 | |
| *** iartarisi has joined #openstack-trove | 13:34 | |
| *** achampion has joined #openstack-trove | 13:51 | |
| *** dkehn_ is now known as dkehnx | 13:55 | |
| SlickNik | grapex: regarding your earlier question about H302 — we don't _have_ to immediately re-write all of our code to follow it. We can choose to ignore the rule in tox.ini | 14:03 |
| *** Barker has joined #openstack-trove | 14:04 | |
| *** topshare has quit IRC | 14:07 | |
| *** kevinconway has joined #openstack-trove | 14:08 | |
| *** eghobo has joined #openstack-trove | 14:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Updated from global requirements https://review.openstack.org/106595 | 14:12 |
| *** juantwo has joined #openstack-trove | 14:14 | |
| *** juantwo has quit IRC | 14:16 | |
| *** juantwo has joined #openstack-trove | 14:17 | |
| *** grapex has joined #openstack-trove | 14:21 | |
| *** eghobo has quit IRC | 14:21 | |
| *** robertmyers has joined #openstack-trove | 14:22 | |
| *** grapex_ has joined #openstack-trove | 14:23 | |
| *** jcru has joined #openstack-trove | 14:24 | |
| *** grapex has quit IRC | 14:26 | |
| *** redthrux has joined #openstack-trove | 14:31 | |
| *** mattgriffin has joined #openstack-trove | 14:32 | |
| amrith | SlickNik, yt? | 14:33 |
| *** Riddhi has joined #openstack-trove | 14:33 | |
| SlickNik | amrith: yes, what's up? | 14:33 |
| amrith | you made a change some days ago | 14:33 |
| amrith | let me find you the link | 14:33 |
| amrith | https://review.openstack.org/#/c/107542/2/trove/guestagent/datastore/mongodb/manager.py,cm | 14:33 |
| *** Riddhi has quit IRC | 14:34 | |
| amrith | this is part of your change https://launchpad.net/bugs/1314803 | 14:34 |
| amrith | ever since, jenkins and only on python 2.7 | 14:34 |
| amrith | has been failing a test | 14:34 |
| amrith | at the very line where you made the change | 14:34 |
| *** Riddhi has joined #openstack-trove | 14:34 | |
| *** jmontemayor has joined #openstack-trove | 14:34 | |
| amrith | I'm able to recreate it sporadically on my machine | 14:34 |
| SlickNik | amrith: Do you have a stack trace of the failure? Is it intermittent? | 14:35 |
| amrith | you hit the issue in your change | 14:35 |
| amrith | it is intermittent | 14:35 |
| amrith | raceback (most recent call last): | 14:35 |
| amrith | File "/opt/stack/trove/trove/tests/unittests/guestagent/test_mongodb_manager.py", line 58, in test_prepare_from_backup | 14:35 |
| amrith | self._prepare_dynamic(backup_id='backup_id_123abc') | 14:35 |
| amrith | File "/opt/stack/trove/trove/tests/unittests/guestagent/test_mongodb_manager.py", line 91, in _prepare_dynamic | 14:35 |
| amrith | backup_info=backup_info) | 14:35 |
| amrith | File "trove/guestagent/datastore/mongodb/manager.py", line 66, in prepare | 14:35 |
| amrith | operating_system.update_owner('mongodb', 'mongodb', mount_point) | 14:35 |
| amrith | File "trove/guestagent/common/operating_system.py", line 109, in update_owner | 14:35 |
| amrith | run_as_root=True, root_helper="sudo") | 14:35 |
| amrith | File "trove/common/utils.py", line 278, in execute_with_timeout | 14:35 |
| amrith | return execute(*args, **kwargs) | 14:35 |
| amrith | File "trove/openstack/common/processutils.py", line 186, in execute | 14:35 |
| amrith | result = obj.communicate() | 14:35 |
| amrith | File "/usr/lib/python2.7/subprocess.py", line 799, in communicate | 14:35 |
| amrith | return self._communicate(input) | 14:35 |
| amrith | File "/usr/lib/python2.7/subprocess.py", line 1396, in _communicate | 14:35 |
| amrith | self.stdin.flush() | 14:35 |
| amrith | File "/opt/stack/trove/.tox/py27/local/lib/python2.7/site-packages/eventlet/greenio.py", line 419, in _operationOnClosedFile | 14:35 |
| amrith | raise ValueError("I/O operation on closed file") | 14:35 |
| amrith | ValueError: I/O operation on closed file | 14:35 |
| amrith | this was from most recent run on my vm | 14:35 |
| amrith | I stumbled on it when I rebased my mongodb branch for logging audit | 14:35 |
| amrith | the merge failed because we changed proximate lines | 14:36 |
| amrith | but after I resoved the conflicts and ran tox (which passed), I got a jenkins failure | 14:36 |
| amrith | http://logs.openstack.org/95/107795/6/check/gate-trove-python27/558a25e/console.html | 14:36 |
| *** jmontemayor_ has joined #openstack-trove | 14:36 | |
| amrith | and since it was py27 that failed, I reran the change on my vm and it failed | 14:36 |
| *** edmund has joined #openstack-trove | 14:37 | |
| amrith | so ... | 14:38 |
| amrith | just wanted to give you a heads up | 14:38 |
| amrith | that'd I'd be bugging this and trying to figure out what ails this beast | 14:38 |
| *** jmontemayor has quit IRC | 14:39 | |
| amrith | This, by the way, was the jenkins failure on your chkin http://logs.openstack.org/42/107542/2/check/gate-trove-python27/519b678 | 14:39 |
| amrith | SlickNik ^^ | 14:39 |
| SlickNik | amrith: Saw that. I thought I had seen the same issue once before at some point, so I opened a bug for the issue: https://bugs.launchpad.net/trove/+bug/1347337 | 14:42 |
| *** Barker has quit IRC | 14:42 | |
| amrith | mind if I grab it? | 14:42 |
| iccha | https://review.openstack.org/#/c/107117/ SlickNik vipul | 14:45 |
| iccha | this is the volume stuff per datastore | 14:45 |
| *** Barker has joined #openstack-trove | 14:47 | |
| *** kevinconway has quit IRC | 14:47 | |
| *** robertmy_ has joined #openstack-trove | 14:47 | |
| *** kevinconway has joined #openstack-trove | 14:47 | |
| *** robertmy_ has quit IRC | 14:49 | |
| SlickNik | amrith: Sure, go for it. Btw, I've seen this happen (even before that change) and on py26 as well. It's intermittent. | 14:49 |
| glucas | Any cores able to take a look at https://review.openstack.org/#/c/100381 ? Reddwarf tests won't pass without the dependent trove-int change so it doesn't show up on dashboards, but has been in the pipe a while. | 14:49 |
| *** robertmy_ has joined #openstack-trove | 14:49 | |
| *** robertmyers has quit IRC | 14:50 | |
| SlickNik | amrith: Probably safest to mock the call out. | 14:50 |
| amrith | SlickNik ... it is a race condition | 14:50 |
| amrith | the underlying operation finishes | 14:50 |
| amrith | and the process doing the chown finishes | 14:50 |
| amrith | then the flush on stdin fails | 14:51 |
| amrith | in this case the failure is in a test | 14:52 |
| amrith | but the call to mount would be invoked in non-test situations as well | 14:52 |
| *** thedodd has joined #openstack-trove | 14:52 | |
| amrith | and I'd rather (if possible) fix the actual problem | 14:52 |
| SlickNik | That's even better. I haven't had a chance to look at the code yet — but I think we're just using subprocess to do the chown, so I'm not entirely sure where the race condition lies. Is it within the subprocess call itself? | 14:56 |
| SlickNik | ^amrith: | 14:56 |
| *** rwsu has joined #openstack-trove | 14:58 | |
| amrith | I believe so | 14:59 |
| amrith | but I'll find out | 14:59 |
| amrith | the issue I have is not so much mocking this call out | 14:59 |
| amrith | but the fact that a call to some command with execute_with_timeout() can hit this problem sporadically. | 15:00 |
| amrith | that could happen on a real system too ;) | 15:00 |
| amrith | SlickNik ^^ | 15:00 |
| *** yidclare has joined #openstack-trove | 15:01 | |
| *** flaper87 is now known as flwang_ | 15:01 | |
| *** flwang_ is now known as flaper87 | 15:01 | |
| *** cweid has joined #openstack-trove | 15:10 | |
| *** ramashri has joined #openstack-trove | 15:12 | |
| *** yidclare has quit IRC | 15:12 | |
| *** IanGovett has joined #openstack-trove | 15:16 | |
| SlickNik | amrith: Cool, sounds good. Thanks much! | 15:17 |
| denis_makogon | hey, guys, i've sent almost tons of emails, but none of them weren't replayed =( | 15:38 |
| *** james_li has joined #openstack-trove | 15:42 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Add mgmt API for datastores https://review.openstack.org/89873 | 15:59 |
| openstackgerrit | Denis M. proposed a change to openstack/python-troveclient: Add mgmt API for datastores https://review.openstack.org/110704 | 16:00 |
| openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Add mgmt API for datastores https://review.openstack.org/110705 | 16:01 |
| *** eghobo has joined #openstack-trove | 16:07 | |
| *** grapex_ has quit IRC | 16:15 | |
| *** grapex has joined #openstack-trove | 16:16 | |
| grapex | vipul SlickNik: Can I get your eyes on this? https://review.openstack.org/#/c/107117/ | 16:17 |
| grapex | It relates to volumes | 16:17 |
| *** thedodd has quit IRC | 16:17 | |
| grapex | and there was an issue w/ ephemeral flavors. I think this pull request really cleans up a lot though | 16:17 |
| *** thedodd has joined #openstack-trove | 16:19 | |
| denis_makogon | cp16net, man, are you around ? | 16:19 |
| denis_makogon | grapex, +1 | 16:19 |
| denis_makogon | SlickNik, vipul, reddwarf is failing, it takes like 6-7 secs to got failed | 16:21 |
| *** jasondotstar has quit IRC | 16:22 | |
| cp16net | denis_makogon: sorta i'm in meetings so i might be slow to respond | 16:31 |
| *** flaper87 is now known as flaper87|afk | 16:35 | |
| denis_makogon | cp16net, about your custom jenkins job, would it work with patche for devstack ? | 16:36 |
| denis_makogon | *patches | 16:36 |
| cp16net | ummm i dont think it includes devstack | 16:36 |
| denis_makogon | cp16net, doh, =( | 16:36 |
| denis_makogon | cp16net, hm, well, gonna try it out manually | 16:37 |
| *** redthrux has left #openstack-trove | 16:38 | |
| cp16net | i tdont think so because devstack is in a different location than the rest of the folders when they are cloned | 16:38 |
| *** eghobo has quit IRC | 16:39 | |
| *** michael-yu has joined #openstack-trove | 16:39 | |
| *** jasondotstar has joined #openstack-trove | 16:40 | |
| *** jasondotstar has quit IRC | 16:40 | |
| *** michael-yu has quit IRC | 16:41 | |
| *** jasondotstar has joined #openstack-trove | 16:41 | |
| *** jasondotstar has quit IRC | 16:41 | |
| cp16net | denis_makogon: yeah devstack wont work right now | 16:42 |
| cp16net | i can possibly fix that | 16:42 |
| cp16net | that would be useful | 16:42 |
| denis_makogon | cp16net, actually would be nice to have a job that accepts a list of certain repo`s: devstack, integration, client, trove itself | 16:42 |
| *** jasondotstar has joined #openstack-trove | 16:43 | |
| cp16net | denis_makogon: why would you need a list of repos? | 16:43 |
| denis_makogon | cp16net, i mean review locations | 16:43 |
| cp16net | i think its better if they are tied to together with some blue print | 16:44 |
| cp16net | what case do you have where multiple reviews are not tied together with a bp? | 16:44 |
| *** boblebauce has quit IRC | 16:47 | |
| *** ramashri has quit IRC | 16:51 | |
| *** jmontemayor_ has quit IRC | 16:53 | |
| *** Barker has quit IRC | 16:53 | |
| *** Barker has joined #openstack-trove | 16:57 | |
| denis_makogon | cp16net, for now, i don't have them, but take a look at https://blueprints.launchpad.net/trove/+spec/datastores-mgmt-api | 16:58 |
| denis_makogon | cp16net, https://review.openstack.org/#/q/topic:bp/datastores-mgmt-api,n,z | 16:59 |
| openstackgerrit | Doug Shelley proposed a change to openstack/trove: Sync service.py from oslo-incubator https://review.openstack.org/110718 | 17:00 |
| *** ViswaV has joined #openstack-trove | 17:02 | |
| amrith | SlickNik, I figured it out. will update the bug. It's actually something that should be fixed in oslo-incubator, right along with the other things I'm doing there. So, i'll take care of it. | 17:02 |
| *** michael-yu has joined #openstack-trove | 17:03 | |
| *** michael-yu has quit IRC | 17:05 | |
| cp16net | denis_makogon: hmm looks like there is something else that i need to fix then | 17:06 |
| cp16net | is there are abandoned reviews | 17:06 |
| cp16net | i didnt account for those | 17:06 |
| *** yidclare has joined #openstack-trove | 17:13 | |
| *** iartarisi has quit IRC | 17:15 | |
| *** ViswaV has quit IRC | 17:16 | |
| *** jasondotstar is now known as jasondotstar|afk | 17:26 | |
| SlickNik | grapex: will do. Got back from out of town yesterday, and am planning on spending a chunk of time on reviews today. | 17:33 |
| SlickNik | So it's 20 minutes to the weekly meeting time, and there's nothing on the agenda for today. | 17:41 |
| SlickNik | So I'm considering canceling it and giving folks the hour back. | 17:42 |
| esp | thx SlickNik | 17:42 |
| amrith | SlickNik .. +1 | 17:43 |
| grapex | SlickNik: + 1 | 17:44 |
| *** IanGovett has quit IRC | 17:44 | |
| *** konetzed has quit IRC | 17:44 | |
| grapex | You should say "but this hour is to be used just on reviews!" | 17:44 |
| grapex | ha ha ha... wait | 17:44 |
| esp | grapex: nice one :) | 17:45 |
| grapex | SlickNik: You should totally do that | 17:45 |
| *** james_li has quit IRC | 17:45 | |
| grapex | "For today's review... ALL CORE PEOPLE SPEND THE NEXT HOUR ON REVIEWS. WE KNOW YOU'RE FREE, YOU CAN'T HIDE. DON'T YOU DARE TELL YOUR BOSSES THIS MEETING WAS CANCELLED EITHER." | 17:46 |
| SlickNik | lol @ grapex | 17:48 |
| cp16net | oh man | 17:48 |
| SlickNik | I know what I'm going to be doing over the next hour :) | 17:48 |
| *** Longgeek has joined #openstack-trove | 17:48 | |
| amrith | core ... Would you please spare some cycles and review these changes; all relate to audit logging. | 17:49 |
| amrith | They've been through several good rounds of maturation and all isses raised thus far have been addressed. I'd like to save churn and merges for all by having these go in at one time. | 17:49 |
| amrith | The numbers are | 17:49 |
| amrith | https://review.openstack.org/#/c/107726/ | 17:49 |
| amrith | https://review.openstack.org/#/c/107732/ | 17:49 |
| amrith | https://review.openstack.org/#/c/107739/ | 17:49 |
| amrith | https://review.openstack.org/#/c/107774/ | 17:49 |
| amrith | https://review.openstack.org/#/c/107787/ | 17:49 |
| amrith | https://review.openstack.org/#/c/107788/ | 17:49 |
| amrith | https://review.openstack.org/#/c/107795/ | 17:49 |
| amrith | https://review.openstack.org/#/c/107805/ | 17:49 |
| amrith | https://review.openstack.org/#/c/107806/ | 17:49 |
| cp16net | amrith: my irc client doesnt let me see links | 17:49 |
| cp16net | it just show https://... | 17:49 |
| amrith | one second | 17:50 |
| amrith | try this | 17:50 |
| amrith | core ... Would you please spare some cycles and review these changes; all relate to audit logging. | 17:50 |
| amrith | They've been through several good rounds of maturation and all isses raised thus far have been addressed. I'd like to save churn and merges for all by having these go in at one time. | 17:50 |
| amrith | The numbers are | 17:50 |
| amrith | http://review.openstack.org/#/c/107726/ | 17:50 |
| amrith | http://review.openstack.org/#/c/107732/ | 17:50 |
| amrith | http://review.openstack.org/#/c/107739/ | 17:50 |
| amrith | https://review.openstack.org/#/c/107774/ | 17:50 |
| amrith | http://review.openstack.org/#/c/107787/ | 17:50 |
| amrith | http://review.openstack.org/#/c/107788/ | 17:50 |
| amrith | http://review.openstack.org/#/c/107795/ | 17:50 |
| amrith | http://review.openstack.org/#/c/107805/ | 17:50 |
| amrith | http://review.openstack.org/#/c/107806/ | 17:50 |
| *** Longgeek_ has quit IRC | 17:51 | |
| amrith | cp16net, does this work? | 17:52 |
| cp16net | nope | 17:52 |
| grapex | Hey maybe we can talk about how much H302 sucks | 17:52 |
| amrith | #link http://review.openstack.org/#/c/107726/ | 17:52 |
| amrith | this better | 17:52 |
| cp16net | nope | 17:52 |
| grapex | Having to use pep8 h302- this must be what it feels like to lose a war. | 17:52 |
| * cp16net wondering how many times amrith will paste everything in irc | 17:53 | |
| cp16net | :-P | 17:53 |
| amrith | 107726, 107732, 107739, 107774, 107787, 107788, 107795, 107805, 107806 | 17:54 |
| SlickNik | If we want the changes to go in at one time, it's probably easiest to make it part of one review. | 17:54 |
| SlickNik | Although in this case, I don't see why you'd want the changes to go in at one time. | 17:54 |
| SlickNik | It probably easier for folks to review each smaller patchset per module, as they have time, no? | 17:54 |
| SlickNik | And changes needed to one module, won't affect the others from merging. | 17:54 |
| glucas | amrith: maybe create a gist | 17:54 |
| SlickNik | glucas: +1 | 17:54 |
| SlickNik | I think amrith's client is slowing down the messages to prevent a flood, but it's probably better to use paste or gist for a volume of info. | 17:55 |
| SlickNik | In any case — nothing on the agenda yet. So todays meeting is canceled. | 17:55 |
| cp16net | ok sounds good | 17:55 |
| SlickNik | Will update the meeting page. | 17:56 |
| * cp16net amrith btw i was just messing with you | 17:56 | |
| amrith | cp16net ... thanks a lot ;) | 17:57 |
| cp16net | hahahaha | 17:57 |
| cp16net | :-D | 17:57 |
| amrith | so SlickNik ... I'll leave them as they are for now. Let people take them as time permits. | 17:58 |
| grapex | Btw | 17:59 |
| grapex | just because I'm going through all of amrith's commits and will feel really bad if I'm getting this wrong | 17:59 |
| grapex | This is still the "best" way to get the text localization stuff in a module right? from trove.openstack.common.gettextutils import _ # noqa | 17:59 |
| amrith | no #noqa | 18:00 |
| grapex | Also... in the future if I don't add a period to logging statements will I get a minus 1? | 18:00 |
| amrith | H306 is being added for that. | 18:01 |
| amrith | the proposal went out (cp16net sent it) earlier today. | 18:01 |
| amrith | cp16net, say yes now. | 18:01 |
| *** saurabhs has joined #openstack-trove | 18:01 | |
| *** Barker has quit IRC | 18:01 | |
| *** Longgeek has quit IRC | 18:01 | |
| amrith | ;) | 18:02 |
| cp16net | amrith: maybe? | 18:02 |
| SlickNik | grapex: I'm not sure about the # noqa part, let me check on that. | 18:03 |
| amrith | SlickNik, I can confirrm that #noqa is not required | 18:03 |
| *** annashen_ has joined #openstack-trove | 18:03 | |
| SlickNik | ah, okay. I think the suggested way is to ignore that error in the tox.ini file. | 18:04 |
| SlickNik | grapex: Also, I'd hate to -1 on a "period missing at the end of a log line" | 18:06 |
| SlickNik | grapex: I'd put in a comment, and the author of the patchset can fix it if he's going to upload another patchset for a different reason. | 18:07 |
| SlickNik | but I don't see that as a reason for the -1 | 18:07 |
| *** annashen_ has quit IRC | 18:09 | |
| *** annashen_ has joined #openstack-trove | 18:09 | |
| *** annashen_ has quit IRC | 18:12 | |
| *** annashen_ has joined #openstack-trove | 18:12 | |
| *** annashen_ has quit IRC | 18:13 | |
| *** annashen_ has joined #openstack-trove | 18:13 | |
| *** annashen_ has quit IRC | 18:14 | |
| *** annashen has quit IRC | 18:15 | |
| cp16net | SlickNik: yeah i agree with that | 18:15 |
| cp16net | tedious things that dont effect the code execution shouldnt hold a pr up | 18:16 |
| cp16net | if its not caught in the gates | 18:16 |
| schang | SlickNik: Can you take a look at this review when you have a chance? 108020 ... It is the one being -1'ed because of the "Heat" verbiage. | 18:18 |
| *** jmontemayor has joined #openstack-trove | 18:21 | |
| *** jmontemayor has quit IRC | 18:21 | |
| *** jmontemayor has joined #openstack-trove | 18:22 | |
| SlickNik | schang: Will do. Thanks! | 18:22 |
| *** jasondotstar|afk is now known as jasondotstar | 18:33 | |
| *** eghobo has joined #openstack-trove | 18:37 | |
| *** Barker has joined #openstack-trove | 18:39 | |
| *** yidclare has quit IRC | 18:40 | |
| *** Barker has quit IRC | 18:43 | |
| *** james_li has joined #openstack-trove | 18:45 | |
| *** Barker has joined #openstack-trove | 18:45 | |
| *** Longgeek has joined #openstack-trove | 18:47 | |
| *** mrsnivvel has quit IRC | 19:05 | |
| *** jmontemayor has quit IRC | 19:06 | |
| *** mrsnivvel has joined #openstack-trove | 19:07 | |
| *** jmontemayor has joined #openstack-trove | 19:08 | |
| *** jmontemayor_ has joined #openstack-trove | 19:13 | |
| *** jmontemayor has quit IRC | 19:16 | |
| *** yidclare has joined #openstack-trove | 19:23 | |
| *** michael-yu has joined #openstack-trove | 19:23 | |
| *** sriram_tesora has joined #openstack-trove | 19:27 | |
| *** ramashri has joined #openstack-trove | 19:40 | |
| *** james_li has quit IRC | 19:52 | |
| *** yidclare has quit IRC | 19:57 | |
| *** flaper87|afk is now known as flaper87 | 19:57 | |
| *** james_li has joined #openstack-trove | 19:58 | |
| openstackgerrit | A change was merged to openstack/trove: Logging audit for trove/guestagent module https://review.openstack.org/107726 | 20:04 |
| *** boden has quit IRC | 20:13 | |
| openstackgerrit | Greg Lucas proposed a change to openstack/trove: Snapshot component for replication https://review.openstack.org/109687 | 20:34 |
| openstackgerrit | Greg Lucas proposed a change to openstack/trove: Mysql guest agent functionality for replication https://review.openstack.org/98147 | 20:35 |
| openstackgerrit | A change was merged to openstack/trove: Remove accounts use of non-existent Nova extension https://review.openstack.org/110420 | 20:41 |
| *** Riddhi has quit IRC | 20:52 | |
| *** Riddhi has joined #openstack-trove | 20:52 | |
| *** jmontemayor_ has quit IRC | 20:55 | |
| *** Riddhi has quit IRC | 20:56 | |
| *** jasondotstar has quit IRC | 20:59 | |
| *** juantwo has quit IRC | 21:01 | |
| *** Riddhi has joined #openstack-trove | 21:04 | |
| *** jmontemayor_ has joined #openstack-trove | 21:07 | |
| *** Longgeek has quit IRC | 21:13 | |
| *** grapex has quit IRC | 21:15 | |
| *** grapex has joined #openstack-trove | 21:15 | |
| *** jcru has quit IRC | 21:18 | |
| *** grapex has quit IRC | 21:20 | |
| *** rwsu has quit IRC | 21:31 | |
| *** jmontemayor_ has quit IRC | 21:33 | |
| *** peoplemerge has joined #openstack-trove | 21:34 | |
| *** rwsu has joined #openstack-trove | 21:39 | |
| *** cweid has quit IRC | 21:45 | |
| *** jmontemayor has joined #openstack-trove | 21:49 | |
| *** robertmy_ has quit IRC | 21:59 | |
| *** robertmyers has joined #openstack-trove | 22:00 | |
| *** robertmyers has quit IRC | 22:04 | |
| *** pdmars has quit IRC | 22:07 | |
| *** eghobo has quit IRC | 22:08 | |
| *** eghobo has joined #openstack-trove | 22:09 | |
| *** achampion has quit IRC | 22:13 | |
| *** flaper87 is now known as flaper87|afk | 22:15 | |
| *** Riddhi has quit IRC | 22:24 | |
| openstackgerrit | Riddhi Shah proposed a change to openstack/trove: Associate flavor types with datastore versions https://review.openstack.org/109824 | 22:25 |
| *** Riddhi has joined #openstack-trove | 22:25 | |
| *** yidclare has joined #openstack-trove | 22:27 | |
| *** saurabhs has quit IRC | 22:28 | |
| *** johnma has quit IRC | 22:28 | |
| *** michael-yu has quit IRC | 22:31 | |
| *** Riddhi has quit IRC | 22:32 | |
| *** yidclare has quit IRC | 22:37 | |
| *** juantwo has joined #openstack-trove | 22:39 | |
| *** juantwo has quit IRC | 22:40 | |
| *** juantwo has joined #openstack-trove | 22:41 | |
| *** thedodd has quit IRC | 22:51 | |
| *** saurabhs has joined #openstack-trove | 22:51 | |
| *** james_li has quit IRC | 22:52 | |
| *** saurabhs has left #openstack-trove | 22:58 | |
| *** mattgriffin has quit IRC | 23:00 | |
| *** sriram_tesora has quit IRC | 23:04 | |
| *** thedodd has joined #openstack-trove | 23:05 | |
| *** edmund has quit IRC | 23:12 | |
| *** Barker has quit IRC | 23:13 | |
| *** jmontemayor has quit IRC | 23:15 | |
| *** thedodd has quit IRC | 23:48 | |
| *** mattgriffin has joined #openstack-trove | 23:50 | |
| *** thedodd has joined #openstack-trove | 23:52 | |
| *** thedodd has quit IRC | 23:57 | |
| *** achampion has joined #openstack-trove | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!