| *** sonali5 has joined #openstack-trove | 00:02 | |
| *** chlong has quit IRC | 00:09 | |
| *** ashleighfarnham has quit IRC | 00:12 | |
| *** sonali5 has quit IRC | 00:20 | |
| *** ianbrown has quit IRC | 00:25 | |
| *** ianbrown has joined #openstack-trove | 00:28 | |
| *** bhaskarduvvuri has quit IRC | 00:31 | |
| openstackgerrit | Luigi Toscano proposed openstack/trove: Use configured datastore on instance creation https://review.openstack.org/255428 | 00:50 |
|---|---|---|
| openstackgerrit | Luigi Toscano proposed openstack/trove: Use a specific network for the test https://review.openstack.org/255429 | 00:50 |
| *** chlong has joined #openstack-trove | 01:05 | |
| *** chlong has quit IRC | 01:23 | |
| *** imandhan has quit IRC | 01:24 | |
| *** ianbrown has quit IRC | 01:31 | |
| *** ianbrown has joined #openstack-trove | 01:31 | |
| *** ianbrown has quit IRC | 01:33 | |
| *** ianbrown has joined #openstack-trove | 01:33 | |
| *** ianbrown has quit IRC | 01:44 | |
| *** ianbrown has joined #openstack-trove | 01:44 | |
| *** caishan has joined #openstack-trove | 01:53 | |
| *** pmackinn has quit IRC | 02:00 | |
| *** rcernin has quit IRC | 02:01 | |
| *** ianbrown has quit IRC | 02:20 | |
| *** ianbrown has joined #openstack-trove | 02:21 | |
| *** ianbrown has quit IRC | 02:27 | |
| *** ianbrown has joined #openstack-trove | 02:28 | |
| *** links has joined #openstack-trove | 02:33 | |
| *** chlong has joined #openstack-trove | 02:44 | |
| *** ianbrown_ has joined #openstack-trove | 02:44 | |
| *** ianbrown has quit IRC | 02:45 | |
| *** ianbrown_ has quit IRC | 02:47 | |
| *** ianbrown_ has joined #openstack-trove | 02:47 | |
| *** _amrith_ is now known as amrith | 03:31 | |
| amrith | vipul, hmm ... that name sounds familiar. | 03:32 |
| *** imandhan has joined #openstack-trove | 03:49 | |
| *** imandhan has quit IRC | 04:19 | |
| *** ViswaV has quit IRC | 04:38 | |
| *** ianbrown_ has quit IRC | 04:38 | |
| *** ianbrown__ has joined #openstack-trove | 04:39 | |
| *** ViswaV has joined #openstack-trove | 04:42 | |
| *** ianbrown__ has quit IRC | 04:45 | |
| *** ianbrown__ has joined #openstack-trove | 04:45 | |
| *** sonali5 has joined #openstack-trove | 05:02 | |
| *** ashleighfarnham has joined #openstack-trove | 05:20 | |
| *** imandhan has joined #openstack-trove | 05:49 | |
| *** links has quit IRC | 06:01 | |
| *** links has joined #openstack-trove | 06:01 | |
| *** chlong has quit IRC | 06:28 | |
| *** sgotliv_ has joined #openstack-trove | 06:48 | |
| *** links has quit IRC | 06:49 | |
| *** chlong has joined #openstack-trove | 06:49 | |
| *** sonali5 has quit IRC | 07:00 | |
| *** ashleighfarnham has quit IRC | 07:01 | |
| *** chlong has quit IRC | 07:04 | |
| *** sonali5 has joined #openstack-trove | 07:04 | |
| *** links has joined #openstack-trove | 07:05 | |
| *** rcernin has joined #openstack-trove | 07:11 | |
| *** imandhan has quit IRC | 07:19 | |
| *** imandhan has joined #openstack-trove | 07:19 | |
| *** chlong has joined #openstack-trove | 07:20 | |
| *** haomaiwang has joined #openstack-trove | 07:23 | |
| *** imandhan has quit IRC | 07:24 | |
| *** haomai___ has joined #openstack-trove | 07:57 | |
| *** haomaiwang has quit IRC | 07:58 | |
| *** haomai___ has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-trove | 08:01 | |
| *** ViswaV has quit IRC | 08:02 | |
| *** peterstac has quit IRC | 08:04 | |
| openstackgerrit | Merged openstack/trove: fix mongo create database https://review.openstack.org/246590 | 08:04 |
| *** dloi_ has quit IRC | 08:04 | |
| *** dloi has joined #openstack-trove | 08:04 | |
| *** chlong has quit IRC | 08:05 | |
| *** bhunter has quit IRC | 08:05 | |
| *** krugg has quit IRC | 08:05 | |
| *** mvandijk has quit IRC | 08:05 | |
| *** amrith has quit IRC | 08:05 | |
| *** dougshelley66 has quit IRC | 08:05 | |
| *** sonali5 has quit IRC | 08:06 | |
| *** amrith has joined #openstack-trove | 08:10 | |
| *** bhunter has joined #openstack-trove | 08:11 | |
| *** peterstac has joined #openstack-trove | 08:11 | |
| *** dougshelley66 has joined #openstack-trove | 08:11 | |
| *** mvandijk has joined #openstack-trove | 08:12 | |
| *** krugg has joined #openstack-trove | 08:12 | |
| *** links has quit IRC | 08:14 | |
| *** haomaiwang has quit IRC | 08:45 | |
| *** haomaiwang has joined #openstack-trove | 08:50 | |
| *** links has joined #openstack-trove | 08:52 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-trove | 09:01 | |
| *** haomaiwang has quit IRC | 09:07 | |
| *** haomaiwang has joined #openstack-trove | 09:14 | |
| *** hogepodge has quit IRC | 09:26 | |
| *** hogepodge has joined #openstack-trove | 09:28 | |
| *** openstackgerrit has quit IRC | 09:32 | |
| *** openstackgerrit has joined #openstack-trove | 09:32 | |
| *** links has quit IRC | 09:42 | |
| *** links has joined #openstack-trove | 09:55 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-trove | 10:01 | |
| *** links has quit IRC | 10:04 | |
| *** k4n0 has joined #openstack-trove | 10:15 | |
| *** k4n0 has quit IRC | 10:15 | |
| *** links has joined #openstack-trove | 10:17 | |
| *** caishan has quit IRC | 10:38 | |
| *** ianbrown__ has quit IRC | 10:52 | |
| *** ianbrown__ has joined #openstack-trove | 10:52 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-trove | 11:01 | |
| *** ianbrown__ has quit IRC | 11:01 | |
| *** ianbrown__ has joined #openstack-trove | 11:02 | |
| *** tosky has joined #openstack-trove | 11:06 | |
| *** ianbrown__ has quit IRC | 11:11 | |
| *** ianbrown__ has joined #openstack-trove | 11:11 | |
| *** sonali5 has joined #openstack-trove | 11:23 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwa_ has joined #openstack-trove | 12:01 | |
| *** sonali5 has quit IRC | 12:11 | |
| *** openstackgerrit has quit IRC | 12:47 | |
| *** openstackgerrit has joined #openstack-trove | 12:47 | |
| *** pmackinn has joined #openstack-trove | 12:54 | |
| *** swebb has quit IRC | 12:57 | |
| *** haomaiwa_ has quit IRC | 13:01 | |
| *** haomaiwa_ has joined #openstack-trove | 13:01 | |
| *** swebb has joined #openstack-trove | 13:03 | |
| *** amrith is now known as _amrith_ | 13:43 | |
| *** _crobertsrh is now known as crobertsrh | 13:49 | |
| *** zhiyan has quit IRC | 13:51 | |
| *** zhiyan has joined #openstack-trove | 13:53 | |
| *** openstackstatus has quit IRC | 13:57 | |
| *** links has quit IRC | 13:57 | |
| *** pmalik has quit IRC | 14:00 | |
| *** pmalik has joined #openstack-trove | 14:00 | |
| *** haomaiwa_ has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-trove | 14:01 | |
| *** mingdang1 has joined #openstack-trove | 14:22 | |
| *** chaozhechen_ has joined #openstack-trove | 14:24 | |
| *** mingdang1 has quit IRC | 14:57 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** 18WABEK5P has joined #openstack-trove | 15:01 | |
| *** chaozhechen_ has quit IRC | 15:11 | |
| *** chaozhechen_ has joined #openstack-trove | 15:11 | |
| *** chaozhechen_ has quit IRC | 15:16 | |
| *** chaozhechen_ has joined #openstack-trove | 15:16 | |
| *** _amrith_ is now known as amrith | 15:28 | |
| chaozhechen_ | Any one knows when is the trove weekly meeting? | 15:28 |
| amrith | I know. | 15:36 |
| vkmc | chaozhechen_, next Wednesday at 6.00pm UTC | 15:42 |
| vkmc | chaozhechen_, #openstack-meeting-alt | 15:42 |
| vkmc | chaozhechen_, more here https://wiki.openstack.org/wiki/Meetings/TroveMeeting | 15:42 |
| chaozhechen_ | vkmc: Thanks :) | 15:51 |
| *** vkmc is now known as vkmc-lunch | 15:56 | |
| tosky | pmalik: hi, around for some questions about the (new) integration tests (and https://review.openstack.org/255429 )? | 16:00 |
| *** 18WABEK5P has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-trove | 16:01 | |
| *** johnma has joined #openstack-trove | 16:08 | |
| *** csoukup has joined #openstack-trove | 16:15 | |
| cp16net | tosky: so in the tests there is a separate config that is being used | 16:34 |
| tosky | cp16net: yes, and isn't it the one reachable by trove.tests.config.CONFIG? While the suggested cfg.CONF is for the services configuration file, if I get it correctly | 16:35 |
| cp16net | so that the tests can have extened attrs for the test scenarios | 16:35 |
| cp16net | right | 16:36 |
| tosky | oki, so I can proceed | 16:37 |
| tosky | but then, are the new tests already in production? I think I haven't seen running on the gates, is it correct? And what are the plans regarding them/ | 16:37 |
| tosky | ? | 16:37 |
| cp16net | tosky: the tests/api/* tests are all for mysql currently | 16:38 |
| cp16net | cant be used for other datastores very easily | 16:38 |
| tosky | right | 16:38 |
| cp16net | they are the only tests running in the gate currently | 16:38 |
| cp16net | we are working to make sure that the scenario tests are coverering as much as the original tests | 16:39 |
| tosky | so, are the "new format" mysql tests not yet on par with the old ones? | 16:39 |
| cp16net | then we can switch to using those tests | 16:39 |
| tosky | you answered, ok :) | 16:39 |
| cp16net | :) | 16:39 |
| cp16net | thats the only reason right now we have 2 sets | 16:39 |
| cp16net | of tests | 16:39 |
| tosky | right, I understand | 16:39 |
| tosky | and in order to run the new tests, apart from what it's written there, is there a set of groups of tests that can be considered "stable" to compare the results? | 16:40 |
| cp16net | you should be able to see the groups in the int-tests.py | 16:40 |
| cp16net | redstack int-tests --group=mysql_supported | 16:41 |
| cp16net | i'd like to avoid such headaches by the end of the cycle and move to the new tests | 16:42 |
| tosky | cp16net: yes, I see all the groups, but the question is more: are all really really working now, or is there some set which is more stable than others? (maybe it's just "yes, all implemented are working") | 16:42 |
| *** rcernin has quit IRC | 16:42 | |
| cp16net | tosky: i have run them in the past | 16:43 |
| cp16net | not in the last month or 2 | 16:43 |
| tosky | ack, thanks | 16:43 |
| tosky | I will try | 16:44 |
| cp16net | as i've been working on clustering for pxc and making sure they are passing in the new tests | 16:44 |
| cp16net | since its a new datastore i havent run the mysql tests in a while | 16:44 |
| cp16net | i believe peterstac has tho | 16:44 |
| * tosky looks at peterstac | 16:45 | |
| cp16net | and i probably pmalik since he commented on the review you mentioned :-P | 16:45 |
| pmalik | tosky Yes, you were right, see my comment. | 16:51 |
| tosky | pmalik: thanks! | 16:51 |
| tosky | pmalik: if you had to estimate the percentage of completeness of the new scenario mysql tests compared to the old ones, how would you rate it? | 16:52 |
| *** sabeen has joined #openstack-trove | 16:53 | |
| *** david-lyle has quit IRC | 16:53 | |
| *** sabeen3 has joined #openstack-trove | 16:55 | |
| *** sabeen has quit IRC | 16:58 | |
| pmalik | tosky It depends which datastore you are talking about. If you consider datastore other than MySQL the new test suite has a significantly greater coverage than the 'old' api testsuite. If you consider just MySQL. It covers most of the stuff, it currently has some gaps in access/root tests. It however, in contrast to 'old' testsuite tests data operations as well - it pushes and verifies real data through the test instance | 16:58 |
| pmalik | s using a client connection. It also includes some coverage that the 'old' suite does not (logging stuff). It is a continuous process, we are filling the suite as we go, the 'old' *MySQL* tests had several years of head start. | 16:58 |
| tosky | pmalik: I was talking about MySQL in fact (well, also MariaDB); so I guess I really need to properly run also the new suite | 17:00 |
| tosky | thanks | 17:00 |
| *** haomaiwang has quit IRC | 17:01 | |
| *** haomaiwang has joined #openstack-trove | 17:01 | |
| *** vkmc-lunch is now known as vkmc | 17:05 | |
| pmalik | tosky As pointed out by Craig you can run --group=<datastore>_supported which should test only stuff currently supported by the datastore. You can also run multiple groups of your choosing like: './redstack int-tests --group=database --group=user'. You mau need to cherry-pick ' https://review.openstack.org/#/c/224363/ ' from review to get them fully work. There are also two more extensions to the suite currently in revie | 17:06 |
| pmalik | w depending on that one - configuration groups and extension to cluster tests. | 17:06 |
| zigo | Guys, I'm getting really mad with trove, it's telling me I need to run windows !!! http://paste.openstack.org/show/481532/ | 17:07 |
| zigo | Seriously, what is this issue about? | 17:07 |
| cp16net | zigo: thats in a dependency keyring | 17:08 |
| zigo | cp16net: Yup, saw that! :) | 17:08 |
| zigo | cp16net: And? | 17:08 |
| cp16net | zigo: i have never seen that | 17:08 |
| pmalik | zigo What environment are you on? | 17:08 |
| cp16net | what is the scenario you are running? | 17:09 |
| zigo | pmalik: I'm trying to build the Debian package of Trove (Mitaka b1). | 17:09 |
| zigo | So I'm running unit tests at package build. | 17:09 |
| zigo | Trove is one of the last 4 server projects I need to finish (all the rest of OpenStack builds fine and i can upload them). | 17:09 |
| tosky | pmalik, cp16net: apart from replacing the old tests with the old ones, any estimates for putting at least a non-voting gate jobs for the new tests? | 17:09 |
| pmalik | zigo, cp16net It is coming from the mock detector. It should ignore modules that cannot be imported. Hmm... | 17:09 |
| zigo | So, my environment is packaged base only (no venv), and running in an sbuild chroot. | 17:10 |
| *** ig0r_ has joined #openstack-trove | 17:11 | |
| cp16net | tosky: i'd say for an estimate i'd like to get to this point or further by the end of mitaka | 17:11 |
| tosky | cp16net: ack | 17:12 |
| pmalik | tosky I think that's the plan, but at least one little adjustment has to go to the redstack script before this can happen: https://review.openstack.org/#/c/250588/ | 17:12 |
| cp16net | zigo: that shouldnt be an issue from my experience | 17:12 |
| zigo | cp16net: Yeah, the question is: WTF is going on?!? :) | 17:13 |
| cp16net | zigo: pmalik but that is some new code there | 17:13 |
| pmalik | cp16net, zigo Not sure what is causing it. If you look at line 113 in 'tests.unittests.trove_testtools' it catches an ImportError, but this is throwing a RuntimeError, which is kind of weird... | 17:15 |
| pmalik | maybe we should just catch any error... | 17:16 |
| *** ashleighfarnham has joined #openstack-trove | 17:16 | |
| cp16net | zigo: it sounds like you can replicate this issue | 17:19 |
| cp16net | zigo: but how would i replicate it? | 17:19 |
| zigo | cp16net: Can you try to build the package? | 17:20 |
| cp16net | do you have the package scripts avail? | 17:20 |
| zigo | You need a Debian Jessie. | 17:20 |
| cp16net | thats what i run | 17:20 |
| *** ianbrown__ has quit IRC | 17:20 | |
| pmalik | Great, this looks like the code of the lib: https://github.com/rcritten/kernel-keyring/blame/master/keyring/backends/Windows.py#L82 | 17:20 |
| zigo | cp16net: http://openstack.alioth.debian.org/ | 17:20 |
| zigo | cp16net: Replace liberty by mitaka ... | 17:21 |
| *** ianbrown__ has joined #openstack-trove | 17:21 | |
| pmalik | Correction: https://bitbucket.org/kang/python-keyring-lib/src/b2e88501a6a9bc7f1c7c230a6431ac0860ff4e50/keyring/backends/Windows.py?at=default&fileviewer=file-view-default | 17:21 |
| zigo | cp16net: I'm trying with catching all errors... | 17:22 |
| cp16net | the unit tests run on ubuntu so i'm kinda surprised about this | 17:22 |
| zigo | cp16net: It has nothing to do with it. Rebuilding on ubuntu would most likely do the same. | 17:23 |
| zigo | Fixing trove_testtools.py to catch all exception does the trick. | 17:24 |
| *** ViswaV has joined #openstack-trove | 17:24 | |
| zigo | Thanks for the tip, now we got to make it upstream, I guess. | 17:25 |
| cp16net | zigo: can you file a bug on this plz? | 17:25 |
| pmalik | cp16net, zigo : I guess the problem here is that they are throwing a RuntimeException from static code. The module gets loaded on import and explodes when the detector tries to probe that property... | 17:26 |
| pmalik | zigo I can have it fixed ASAP. | 17:26 |
| * zigo files the bug | 17:27 | |
| cp16net | zigo: pmalik thanks. zigo can you pipe in on the review as well since you found it when pmalik pushes it? | 17:27 |
| zigo | https://bugs.launchpad.net/trove/+bug/1524918 | 17:28 |
| openstack | Launchpad bug 1524918 in Trove "Unit test errors in python-keyring when building Debian package" [Undecided,New] | 17:28 |
| cp16net | awesome thanks! | 17:28 |
| zigo | Please add me to the review, yes. | 17:29 |
| *** ViswaV has quit IRC | 17:29 | |
| zigo | "Thomas Goirand" is my id there... | 17:29 |
| amrith | cp16net, do you run debian jessie? | 17:30 |
| amrith | and do you see this problem? | 17:30 |
| cp16net | i do | 17:30 |
| cp16net | but i have never seen it | 17:30 |
| amrith | I get the point that we can mask the error by catching a broader exception and passing | 17:30 |
| cp16net | must be how the packaging happens | 17:30 |
| amrith | but I'm wondering why this is throwing for zigo but not you. | 17:30 |
| * amrith wonders whether debian packaging is running on Windows ;) | 17:30 | |
| cp16net | i'm runing with the tox venv | 17:31 |
| zigo | amrith: I'm not using devstack... | 17:31 |
| cp16net | sounds like the packaging does not | 17:31 |
| amrith | nor I | 17:31 |
| zigo | And ... "It works on devstack" (tm) | 17:31 |
| zigo | :) | 17:31 |
| cp16net | lolz | 17:31 |
| *** ViswaV has joined #openstack-trove | 17:31 | |
| amrith | good try, I'm not using devstack (or redstack) either | 17:32 |
| amrith | but I don't use debian | 17:32 |
| amrith | and I do have windows | 17:32 |
| amrith | so I guess I'm all set. | 17:32 |
| cp16net | windows makes my eyes bleed | 17:32 |
| cp16net | lol | 17:32 |
| *** openstackstatus has joined #openstack-trove | 17:37 | |
| *** ChanServ sets mode: +v openstackstatus | 17:38 | |
| amrith | cp16net, zigo looking at the keyring code I see no reason why it should even be throwing that exception | 17:42 |
| amrith | why does it even think it is in the windows code? | 17:42 |
| amrith | does it have a windows module loaded? | 17:42 |
| openstackgerrit | Petr Malik proposed openstack/trove: Catch all errors in Mock detector https://review.openstack.org/256011 | 17:43 |
| cp16net | looks like that find mocks is iterating over everything | 17:43 |
| pmalik | cp16net zigo : OK, it's here: https://review.openstack.org/#/c/256011/ | 17:43 |
| cp16net | and it might be installed with keystone | 17:43 |
| cp16net | on the host system | 17:44 |
| cp16net | and in our venv its not | 17:44 |
| cp16net | i'll bet thats the case | 17:44 |
| *** nshah has joined #openstack-trove | 17:45 | |
| cp16net | zigo: are you building all the packages from the same vm? | 17:45 |
| cp16net | and not starting fresh each timE? | 17:45 |
| amrith | pmalik, I just -1'ed with a comment | 17:48 |
| cp16net | hmm looks like its in our client as well | 17:49 |
| cp16net | so if you used the same venv for the troveclient and trove to run the unit tests i'll bet you get this error | 17:49 |
| dougshelley66 | ah interesting | 17:50 |
| amrith | how did you do that? | 17:51 |
| cp16net | ? | 17:51 |
| amrith | cp16net, how'd you use the same venv for troveclient and trove | 17:51 |
| amrith | I wanted to do what you are doing | 17:52 |
| cp16net | i'm just looking at the code | 17:52 |
| amrith | and you say "i'll bet you get" ... | 17:52 |
| cp16net | yeah so i searched for keyring across all the projects i have | 17:52 |
| cp16net | and found some keyring related stuff in the client | 17:52 |
| cp16net | not sure that its related yet or not | 17:53 |
| cp16net | hmm doesnt look like it | 17:53 |
| cp16net | amrith: since zigo said he wasnt using a venv to run the tests when packaging it must mean that all the python packages are available to the system | 17:54 |
| * amrith grumbles | 17:54 | |
| cp16net | if we are recursively going through all the mocks then it *MAY* cause this issue | 17:54 |
| zigo | cp16net: Correct. | 17:55 |
| cp16net | from global requirements i see keyring>=2.1,!=3.3 | 17:55 |
| cp16net | so if you install this in the tox venv we use for unittests | 17:55 |
| cp16net | ideally you should be able to replicate the issue | 17:55 |
| zigo | I'm using python-keyring from Jessie, so that's version 4.0. | 17:55 |
| cp16net | zigo: i wont hold that against you :-p | 17:57 |
| zigo | After fixing this issue, I still have another one: http://paste.openstack.org/show/481539/ | 17:57 |
| *** imandhan has joined #openstack-trove | 17:58 | |
| zigo | Any idea for that one? | 17:58 |
| pmalik | zigo OK, something is not being mocked out well here. Let me take a look. | 17:58 |
| zigo | Thanks. | 17:59 |
| cp16net | yup | 17:59 |
| zigo | Gosh, it's sooooooooo nice to work with OpenStack people ... :) | 17:59 |
| zigo | Always helpful. | 17:59 |
| cp16net | :) | 17:59 |
| amrith | so it sounds like the issue is that you are running the tests in an environment other than the one in which we nornally expect it to run. | 18:00 |
| amrith | hmm, so is the fix to (a) make all the tests run in this non tox environment or (b) have you run the tests in the tox environment? | 18:00 |
| *** haomaiwang has quit IRC | 18:01 | |
| amrith | zigo, always helpful except for me ;) | 18:01 |
| *** haomaiwang has joined #openstack-trove | 18:01 | |
| cp16net | ideally it would be good to run and install from a venv for each project | 18:01 |
| zigo | amrith: I *cannot* run tox within the packag building context. | 18:02 |
| amrith | can you run it outside of that context? | 18:02 |
| amrith | i.e. run tox in a venv | 18:02 |
| zigo | Mostly, because downloading when building is forbidden, and also, because I must use system packages. | 18:02 |
| amrith | and then package? | 18:02 |
| zigo | amrith: What would be the point? | 18:02 |
| cp16net | zigo: can you use a venv to build it? | 18:02 |
| zigo | cp16net: No. | 18:02 |
| zigo | amrith: The point is precisely to do tests in an environment which is *not* a venv. | 18:03 |
| zigo | So that I can test with what's in the system. | 18:03 |
| amrith | for that I'd use tests other than the mock tests that you are running ;) | 18:03 |
| amrith | like our int-tests | 18:03 |
| cp16net | and using system packages makes all the python-* libs available to all services | 18:03 |
| zigo | I need to go take care of my kids. | 18:04 |
| zigo | I'll come back tonight. | 18:04 |
| cp16net | zigo: ok | 18:04 |
| cp16net | amrith: i think ideally a package should be deployed with a venv | 18:05 |
| cp16net | but from a packager for debian, ubuntu, others... thats not ideal | 18:05 |
| cp16net | but i think thats a matter of prefernce | 18:06 |
| cp16net | from a clean vm you should be able to install everything to the system and it should work for each release | 18:07 |
| cp16net | thats the idea of the global requirements | 18:07 |
| cp16net | for each release to make sure they are synced up | 18:07 |
| amrith | cp16net, take a look at https://review.openstack.org/#/c/256011/ | 18:14 |
| *** amit213 has quit IRC | 18:14 | |
| cp16net | i agree with it | 18:15 |
| *** amit213 has joined #openstack-trove | 18:15 | |
| cp16net | i dont like catching the world either | 18:15 |
| amrith | agree with the change or the comment? | 18:15 |
| *** sabeen3 has quit IRC | 18:17 | |
| pmalik | zigo ok, I think I may have a fix for the other issue. It would be great if you could verify the patch resolves all issues and if so file a bug: http://paste.openstack.org/show/481542/ Thx. :-) | 18:18 |
| amrith | cp16net, I'm asking because if you are OK with it, I'll drop the -1 | 18:18 |
| cp16net | i'm replicating what zigo is doing and seeing if there is any further issues | 18:20 |
| pmalik | amrith cp16net I caught all because this is just a test and is not supposed to cause stuff like this. I am fine with limiting the exception scope though. | 18:20 |
| cp16net | i'll run it with except RunTimeError in my test | 18:20 |
| cp16net | i'll hold my review until i test it | 18:21 |
| pmalik | cp16net oh, you can try the other fix above as well then :) | 18:22 |
| cp16net | yup | 18:23 |
| cp16net | i have the operating_system.write_file mocked | 18:23 |
| cp16net | building the vm now | 18:23 |
| *** pmackinn has quit IRC | 18:28 | |
| *** lgreg has left #openstack-trove | 18:50 | |
| *** haomaiwang has quit IRC | 19:01 | |
| *** haomaiwa_ has joined #openstack-trove | 19:01 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/trove-specs: Implementing CEPH as a backend for backups https://review.openstack.org/256057 | 19:02 |
| *** tosky has quit IRC | 19:03 | |
| *** chaozhechen_ has quit IRC | 19:18 | |
| *** pmackinn has joined #openstack-trove | 19:26 | |
| pmackinn | dougshelley66, ping | 19:51 |
| dougshelley66 | pmackinn pong | 19:51 |
| pmackinn | dougshelley66, https://github.com/openstack/trove/blob/master/trove/templates/mysql/config.template#L11 | 19:52 |
| pmackinn | dougshelley66, why /data ? | 19:52 |
| dougshelley66 | https://bugs.launchpad.net/trove/+bug/1370646 | 19:53 |
| openstack | Launchpad bug 1370646 in Trove "Mysql datadir shouldn't be in the root of mounted filesystem" [Medium,Fix released] - Assigned to Simon Chang (changsimon) | 19:53 |
| pmackinn | dougshelley66, k thx | 19:54 |
| *** haomaiwa_ has quit IRC | 20:01 | |
| *** rcernin has joined #openstack-trove | 20:01 | |
| *** 18WABEVAW has joined #openstack-trove | 20:01 | |
| openstackgerrit | amrith proposed openstack/trove-specs: Add support for hbase in Trove https://review.openstack.org/256079 | 20:05 |
| *** johnma has quit IRC | 20:09 | |
| *** sabeen1 has joined #openstack-trove | 20:24 | |
| *** johnma has joined #openstack-trove | 20:39 | |
| *** sabeen3 has joined #openstack-trove | 20:39 | |
| *** sabeen1 has quit IRC | 20:39 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/trove-specs: Implementing CEPH as a backend for backups https://review.openstack.org/256057 | 20:48 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/trove-specs: Implementing CEPH as a backend for backups https://review.openstack.org/256057 | 20:57 |
| cp16net | building these packages seem to be a pain | 20:57 |
| cp16net | i think just giving zigo the changes to test and we can merge them would be WAY easier at this point | 20:58 |
| *** 18WABEVAW has quit IRC | 21:01 | |
| *** amrith is now known as _amrith_ | 21:01 | |
| *** haomaiwang has joined #openstack-trove | 21:02 | |
| *** haomaiwang has quit IRC | 21:10 | |
| *** haomaiwang has joined #openstack-trove | 21:16 | |
| *** lgreg1 has joined #openstack-trove | 21:17 | |
| *** lgreg1 has left #openstack-trove | 21:17 | |
| *** mingdang1 has joined #openstack-trove | 21:33 | |
| *** crobertsrh is now known as _crobertsrh | 21:37 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** haomaiwang has joined #openstack-trove | 22:01 | |
| openstackgerrit | Craig Vyvial proposed openstack/trove: mock out the guestagent write_file call https://review.openstack.org/256114 | 22:05 |
| *** imandhan has quit IRC | 22:06 | |
| *** hogepodge has quit IRC | 22:10 | |
| *** shakamunyi has quit IRC | 22:12 | |
| *** hogepodge has joined #openstack-trove | 22:13 | |
| *** shakamunyi has joined #openstack-trove | 22:15 | |
| *** mingdang1 has quit IRC | 22:19 | |
| *** david-lyle has joined #openstack-trove | 22:20 | |
| *** johnma has quit IRC | 22:38 | |
| *** rcernin has quit IRC | 22:45 | |
| *** sgotliv_ has quit IRC | 22:52 | |
| *** david-lyle has quit IRC | 22:55 | |
| *** haomaiwang has quit IRC | 23:01 | |
| *** haomaiwang has joined #openstack-trove | 23:01 | |
| *** openstackstatus has quit IRC | 23:01 | |
| *** sabeen3 has quit IRC | 23:21 | |
| *** pmackinn has quit IRC | 23:24 | |
| *** ViswaV has quit IRC | 23:36 | |
| *** ViswaV has joined #openstack-trove | 23:38 | |
| *** ViswaV has quit IRC | 23:43 | |
| *** jwang has quit IRC | 23:43 | |
| *** ViswaV has joined #openstack-trove | 23:43 | |
| *** sabeen1 has joined #openstack-trove | 23:47 | |
| *** jwang has joined #openstack-trove | 23:47 | |
| *** dsavineau has left #openstack-trove | 23:48 | |
| *** csoukup has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!