| opendevreview | chandan kumar proposed openstack/watcher master: Add watcher-no-datasource-tempest job https://review.opendev.org/c/openstack/watcher/+/939702 | 03:30 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/watcher master: [WIP] Enable prometheus and node exporter in watcher job https://review.opendev.org/c/openstack/watcher/+/939515 | 05:28 |
| opendevreview | chandan kumar proposed openstack/watcher master: [WIP] Enable prometheus and node exporter in watcher job https://review.opendev.org/c/openstack/watcher/+/939515 | 05:30 |
| opendevreview | chandan kumar proposed openstack/watcher master: Add watcher-no-datasource-tempest job https://review.opendev.org/c/openstack/watcher/+/939702 | 06:40 |
| opendevreview | chandan kumar proposed openstack/watcher master: Add watcher-no-datasource-tempest job https://review.opendev.org/c/openstack/watcher/+/939702 | 06:52 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Run make_host/instance statistics function for gnocchi datasource https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/939517 | 08:18 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Run make_host/instance statistics function for gnocchi datasource https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/939517 | 08:20 |
| opendevreview | Malinga Tembo proposed openstack/watcher-tempest-plugin master: Add new config option https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136 | 09:24 |
| opendevreview | Malinga Tembo proposed openstack/watcher-tempest-plugin master: Add new config option https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/938136 | 11:18 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add support for instance metrics to prometheus datasource https://review.opendev.org/c/openstack/watcher/+/938893 | 13:23 |
| amoralej | sean-k-mooney, ^ to avoid defining mock_instance again and again, i decided to create it in setup, I'm not sure if that's the best way | 13:24 |
| sean-k-mooney | that geneally what we do yes | 13:29 |
| sean-k-mooney | pull common setup into setUp or a _* helper function | 13:29 |
| sean-k-mooney | amoralej: there some other twweak woe could make but im happy enough to +2 that as is so i think we can proceed as is and see if others have any addtional review feedback | 13:33 |
| amoralej | thanks! | 14:07 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!