| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Show parameter spec in the strategy info page https://review.opendev.org/c/openstack/watcher-dashboard/+/960232 | 04:26 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: List strategies based on selected goal https://review.opendev.org/c/openstack/watcher-dashboard/+/960363 | 04:27 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add option to SKIP Actions https://review.opendev.org/c/openstack/watcher-dashboard/+/958209 | 04:28 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Fix translation context for watcher action states https://review.opendev.org/c/openstack/watcher-dashboard/+/959189 | 04:29 |
| opendevreview | Takashi Kajinami proposed openstack/watcher-tempest-plugin master: Add stable/2025.2 job https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/961343 | 07:09 |
| tkajinam | ^^^ we may want to merge this quickly | 07:09 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Use src_type to filter volumes in zone migration https://review.opendev.org/c/openstack/watcher/+/951843 | 11:02 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add test for zone_migration with instances and volumes https://review.opendev.org/c/openstack/watcher/+/952115 | 11:02 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Allow volume and vm migrations in zone_migration https://review.opendev.org/c/openstack/watcher/+/952116 | 11:02 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Support zone migration audit without compute_nodes https://review.opendev.org/c/openstack/watcher/+/950665 | 11:02 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Improve unit tests for zone migration strategy https://review.opendev.org/c/openstack/watcher/+/954350 | 11:02 |
| chandankumar | dviroel: sean-k-mooney Hello, can we get this merged [Update master for stable/2025.2](https://review.opendev.org/c/openstack/watcher-dashboard/+/960525) needed for [Add release note links for 2025.2 Flamingo](https://review.opendev.org/c/openstack/releases/+/961353). | 12:00 |
| dviroel | chandankumar: done, sorry for missing this one | 12:01 |
| chandankumar | dviroel: thank you! | 12:02 |
| chandankumar | 2025.2 python-watcherclient reno is not published yet, commented on the release patch | 12:14 |
| opendevreview | Merged openstack/watcher-tempest-plugin master: Add stable/2025.2 job https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/961343 | 12:20 |
| opendevreview | Merged openstack/watcher-dashboard master: Update master for stable/2025.2 https://review.opendev.org/c/openstack/watcher-dashboard/+/960525 | 12:29 |
| sean-k-mooney | we dont nessiarly need to wait for it to be by the way. there is usally a second patch to update the release ntoes for trailign porject or ones that were not ready at the time of the first | 12:29 |
| sean-k-mooney | so it can alwasy be fixed later | 12:30 |
| chandankumar | sean-k-mooney: thank you! | 12:47 |
| chandankumar | sean-k-mooney: dviroel hello, regarding https://review.opendev.org/c/openstack/watcher-dashboard/+/957232/12/watcher_dashboard/api/watcher.py microversion support for each request, I was checking horizon code, I found this https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/cinder.py#L38 , I am not finding any other example to pass microversion on each request. | 14:14 |
| chandankumar | Will I follow the horizon microversion approach or any other example you can point out? | 14:14 |
| sean-k-mooney | that proably beause horizon historically has not supproted micorversion properly | 14:15 |
| chandankumar | horizon microversion is only used for cinder only | 14:16 |
| sean-k-mooney | right which means it not talks to nova corerctly at all | 14:16 |
| sean-k-mooney | im currently readign how they are usign this to see if its a good pattern to follow | 14:17 |
| sean-k-mooney | they are cachign the client based on request and version https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/cinder.py#L231 | 14:17 |
| sean-k-mooney | that is proably inocrect also | 14:17 |
| sean-k-mooney | it woudl be incorrect to share clinet between request form diffent tenatn so we need to review that memoized decortor before considerign doing the same | 14:18 |
| chandankumar | here is from nova https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/_nova.py#L136 | 14:18 |
| sean-k-mooney | yep and lookign at the impleation this is not really going to cache much | 14:20 |
| sean-k-mooney | it will cache reqeust within the same request | 14:20 |
| sean-k-mooney | if you consturct the nova clinet twith the same version | 14:20 |
| sean-k-mooney | that arguablly not very helpful | 14:21 |
| sean-k-mooney | with that said it does lok like they have suprot for micoveriosn fo rnova too | 14:21 |
| sean-k-mooney | the question is do the encode the version per rquest or not | 14:21 |
| sean-k-mooney | so it looks like they defein there one concept of a "feature" https://github.com/openstack/horizon/blob/3b6a6d8ea74b6444dfc333e11a70d1cb1a077204/openstack_dashboard/api/cinder.py#L268-L288 | 14:25 |
| sean-k-mooney | and have a wrapper that consuct a version client with the relvent feature micorverison | 14:26 |
| sean-k-mooney | i dont think we shoudl have that layer of indriection and instead just specify the microversion directly. | 14:26 |
| sean-k-mooney | so that we do not need to miantian a dict like this https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/microversions.py#L29-L49 | 14:27 |
| sean-k-mooney | the dictionay looses too much information to take any of the accpeted values. | 14:28 |
| chandankumar | yes, you are correct | 14:29 |
| chandankumar | Other thing I am thinking to directly use https://github.com/openstack/python-watcherclient/blob/master/watcherclient/common/api_versioning.py | 14:30 |
| sean-k-mooney | which parts | 14:31 |
| sean-k-mooney | we woudl use some of that yes | 14:31 |
| sean-k-mooney | or we could. ideally we will eventually supprot watcer in the sdk | 14:31 |
| chandankumar | and from UI side, if UI side, start or end time is passed, pass proper version https://github.com/openstack/python-watcherclient/blob/fe8aa16dd734d663567dfc8666d652108c9d3bf9/watcherclient/common/api_versioning.py#L29 | 14:32 |
| sean-k-mooney | tehn remvoe the use of the python watcher client form the wtach-dashbaord entirly | 14:32 |
| chandankumar | to the client call | 14:32 |
| sean-k-mooney | yes so there ar two thing w eneed to take care of | 14:32 |
| sean-k-mooney | first we need to knwo what the max version that is supproted by the cloud | 14:32 |
| sean-k-mooney | and only display the ui elements supptoed by that cloud | 14:32 |
| sean-k-mooney | second when you pass data supproted by a specific microverison we need to rais the min version | 14:33 |
| sean-k-mooney | so as you said if you passed start and end time you woudl need to use 1.1 instead of 1.0 | 14:33 |
| chandankumar | yes correct! | 14:34 |
| sean-k-mooney | i would prefer to use 1.1 or defein our own constnat for that in the dashbaord plugin so that we dont need to update that if we move awway from watcherclient in the future | 14:34 |
| sean-k-mooney | what i woudl suggest is creating a new constants.py file with a defintion of each fo the 6 microverisons | 14:35 |
| sean-k-mooney | then use those in teh ui code | 14:35 |
| sean-k-mooney | i.e. create a constants.py here https://github.com/openstack/watcher-dashboard/tree/master/watcher_dashboard/common | 14:36 |
| chandankumar | above approach sounds good | 14:36 |
| sean-k-mooney | we could call it microverion.py and add soem utility function there as well | 14:37 |
| sean-k-mooney | i.e. is_supported, get_max_microverion and even the versioned client wrppers | 14:37 |
| sean-k-mooney | that will allwo you to do somethign like microversion.get_client(micoverion.START_END_TIME) | 14:38 |
| sean-k-mooney | or microverion.is_supproted(micoversion.SKIP_ACTION) | 14:39 |
| chandankumar | +1 | 14:40 |
| chandankumar | let me work on that. | 14:40 |
| chandankumar | sean-k-mooney: thank you! | 15:03 |
| sean-k-mooney | no worries | 15:04 |
| sean-k-mooney | hopefully that unblocks you and we can make progress on thsoe changes | 15:05 |
| chandankumar | sean-k-mooney: when you get time, please have a look at this https://review.opendev.org/c/openstack/watcher-dashboard/+/957535 and https://review.opendev.org/c/openstack/watcher-dashboard/+/959528 , seems to be good to go, thank you! | 15:05 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume retype with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/954625 | 17:08 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume migrate with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 17:08 |
| opendevreview | Merged openstack/watcher-dashboard master: Add support for passing parameters while creating audit https://review.opendev.org/c/openstack/watcher-dashboard/+/957535 | 17:36 |
| opendevreview | Merged openstack/watcher-dashboard master: Remove password parameter from watcher client initialization https://review.opendev.org/c/openstack/watcher-dashboard/+/959528 | 17:36 |
| opendevreview | Merged openstack/watcher master: Use src_type to filter volumes in zone migration https://review.opendev.org/c/openstack/watcher/+/951843 | 17:58 |
| opendevreview | Merged openstack/watcher master: Add test for zone_migration with instances and volumes https://review.opendev.org/c/openstack/watcher/+/952115 | 18:14 |
| dviroel | good, I also have a fix for zone_migration that I need to rebase... going to work on that now | 18:33 |
| opendevreview | Merged openstack/watcher master: Allow volume and vm migrations in zone_migration https://review.opendev.org/c/openstack/watcher/+/952116 | 18:43 |
| opendevreview | Merged openstack/watcher master: Support zone migration audit without compute_nodes https://review.opendev.org/c/openstack/watcher/+/950665 | 18:45 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Add unit tests for instance and volume not found in model https://review.opendev.org/c/openstack/watcher/+/956197 | 19:14 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Fix zone migration instance not found issue https://review.opendev.org/c/openstack/watcher/+/956198 | 19:14 |
| opendevreview | Merged openstack/watcher master: Improve unit tests for zone migration strategy https://review.opendev.org/c/openstack/watcher/+/954350 | 19:46 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!