| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Start and END time fields for continuous audit https://review.opendev.org/c/openstack/watcher-dashboard/+/957232 | 05:31 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Start and END time fields for continuous audit https://review.opendev.org/c/openstack/watcher-dashboard/+/957232 | 06:08 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Show parameter spec in the strategy info page https://review.opendev.org/c/openstack/watcher-dashboard/+/960232 | 06:10 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: List strategies based on selected goal https://review.opendev.org/c/openstack/watcher-dashboard/+/960363 | 06:10 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Use src_type to filter volumes in zone migration https://review.opendev.org/c/openstack/watcher/+/961439 | 07:34 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Add test for zone_migration with instances and volumes https://review.opendev.org/c/openstack/watcher/+/961440 | 07:34 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Allow volume and vm migrations in zone_migration https://review.opendev.org/c/openstack/watcher/+/961441 | 07:34 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Support zone migration audit without compute_nodes https://review.opendev.org/c/openstack/watcher/+/961442 | 07:34 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Improve unit tests for zone migration strategy https://review.opendev.org/c/openstack/watcher/+/961443 | 07:34 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Add test for missing destination in zone migration https://review.opendev.org/c/openstack/watcher/+/951531 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Handle missing dst_node parameter in zone_migration https://review.opendev.org/c/openstack/watcher/+/951535 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Set keystone_client default interface to public https://review.opendev.org/c/openstack/watcher/+/950294 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Check logs in some cinder and nova helper tests https://review.opendev.org/c/openstack/watcher/+/960715 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Fix incorrect logging format https://review.opendev.org/c/openstack/watcher/+/960716 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Enable storage model collector by default https://review.opendev.org/c/openstack/watcher/+/960717 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Add unit test zone migration with_attached_volume https://review.opendev.org/c/openstack/watcher/+/960746 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Handle missing dst_pool parameter in zone_migration https://review.opendev.org/c/openstack/watcher/+/960747 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Use src_type to filter volumes in zone migration https://review.opendev.org/c/openstack/watcher/+/961444 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Add test for zone_migration with instances and volumes https://review.opendev.org/c/openstack/watcher/+/961445 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Allow volume and vm migrations in zone_migration https://review.opendev.org/c/openstack/watcher/+/961446 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Support zone migration audit without compute_nodes https://review.opendev.org/c/openstack/watcher/+/961447 | 08:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Improve unit tests for zone migration strategy https://review.opendev.org/c/openstack/watcher/+/961448 | 08:00 |
| opendevreview | sean mooney proposed openstack/watcher master: Apply pyupgrade https://review.opendev.org/c/openstack/watcher/+/961450 | 08:08 |
| opendevreview | sean mooney proposed openstack/watcher master: apply pyupgrade to 3.10+ https://review.opendev.org/c/openstack/watcher/+/961451 | 08:08 |
| opendevreview | sean mooney proposed openstack/watcher master: adopt ruff check https://review.opendev.org/c/openstack/watcher/+/961452 | 08:08 |
| opendevreview | sean mooney proposed openstack/watcher master: Fix ruff check violations https://review.opendev.org/c/openstack/watcher/+/961453 | 08:08 |
| opendevreview | sean mooney proposed openstack/watcher master: Fix E402 violations and enable additional ruff checks https://review.opendev.org/c/openstack/watcher/+/961454 | 08:08 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Add test for missing destination in zone migration https://review.opendev.org/c/openstack/watcher/+/951533 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Handle missing dst_node parameter in zone_migration https://review.opendev.org/c/openstack/watcher/+/951536 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Set keystone_client default interface to public https://review.opendev.org/c/openstack/watcher/+/950543 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Check logs in some cinder and nova helper tests https://review.opendev.org/c/openstack/watcher/+/960719 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Fix incorrect logging format https://review.opendev.org/c/openstack/watcher/+/960720 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Enable storage model collector by default https://review.opendev.org/c/openstack/watcher/+/960721 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Add unit test zone migration with_attached_volume https://review.opendev.org/c/openstack/watcher/+/960735 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Handle missing dst_pool parameter in zone_migration https://review.opendev.org/c/openstack/watcher/+/960736 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Use src_type to filter volumes in zone migration https://review.opendev.org/c/openstack/watcher/+/961455 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Add test for zone_migration with instances and volumes https://review.opendev.org/c/openstack/watcher/+/961456 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Allow volume and vm migrations in zone_migration https://review.opendev.org/c/openstack/watcher/+/961457 | 08:22 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Support zone migration audit without compute_nodes https://review.opendev.org/c/openstack/watcher/+/961458 | 08:23 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Improve unit tests for zone migration strategy https://review.opendev.org/c/openstack/watcher/+/961459 | 08:23 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume migrate with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 11:18 |
| dviroel | jgilaber_: sean-k-mooney: one line fix, the last in the series for zone migration, at least for now :) | 11:21 |
| dviroel | https://review.opendev.org/c/openstack/watcher/+/956198 | 11:21 |
| dviroel | it depends on the patch that adds 2 new tests too: https://review.opendev.org/c/openstack/watcher/+/956197 | 11:22 |
| sean-k-mooney | i have the second patch open already | 11:25 |
| sean-k-mooney | but ill review the other shortly | 11:25 |
| sean-k-mooney | dviroel: boot look good to me | 11:26 |
| dviroel | ty | 11:27 |
| sean-k-mooney | ill need to rebase this anyway but as an fyi i would like to do part of the ruff series i previosly propsoed https://review.opendev.org/q/topic:%22pyupgrade%22+repo:openstack/watcher | 11:27 |
| sean-k-mooney | ill add this to the irc adgenda but if we are generally ok with this i woudl like to proceed with it after we ship 2025.2 | 11:28 |
| sean-k-mooney | to avoid merge confilct with other work | 11:28 |
| dviroel | fyi: the last fix for zone_migration is needed for the continuous audit tempest test: https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/954264 - which is also there for a while | 11:28 |
| dviroel | i will recheck this one ^ | 11:28 |
| sean-k-mooney | if you have time it would be nice to get some feedback on that but not urgent since it will be at least 2-3 weeks before we are ready to meove forward with it | 11:29 |
| dviroel | ack sean-k-mooney - i will take a look | 11:29 |
| sean-k-mooney | this stime i split it up alot more. the first patch is still like 1000 lines added/remove across 350 files but the changes are very limited i.e. remvoeing the utf8 encodeing or the old style class/supper calls sicne its only removeign the legacy py 2.7 compat code | 11:31 |
| sean-k-mooney | and since im not using the ruff formater in this serise there are no whitespace changes in general to make the review harder | 11:32 |
| sean-k-mooney | will the continuse audit tempest tst pass with 2025.2 or 2025.1 | 11:33 |
| sean-k-mooney | tempest test need to be compatible with all stable branches or they need to be configuabel and disabled by default | 11:34 |
| sean-k-mooney | they shoudl pass without needeing to backport the fix that it depends on in general | 11:34 |
| sean-k-mooney | or skip because they are nto enabled | 11:35 |
| dviroel | oh good question | 11:40 |
| dviroel | it will run since microversion will permits, but it will fail without the fixes | 11:41 |
| dviroel | we need to fix these CI jobs in this repo, for now | 11:41 |
| dviroel | let me start proposing something | 11:42 |
| sean-k-mooney | dviroel: so the right way to do this is to add a new watcher tempet plugin config option | 11:45 |
| sean-k-mooney | to enabel the continues audit feature i think | 11:45 |
| sean-k-mooney | that shoudl default to false | 11:46 |
| sean-k-mooney | in the master job we can enable it but we wont enbale that in the stable jobs. | 11:46 |
| sean-k-mooney | the other way is via a test regex exclude but that means changing it in the watcher repos and backporting that across stable branches | 11:47 |
| sean-k-mooney | before this can merge which mean waitign till after october 1st | 11:47 |
| dviroel | yeah, otherwise we need to wait until october 1st to start backporting the fix | 11:49 |
| sean-k-mooney | yep and it will mean more work ot update stable and downstream ci jobs | 11:50 |
| sean-k-mooney | if we do it via the config option and optiing in to the testing we wont break jobs by default | 11:50 |
| dviroel | correct | 11:50 |
| sean-k-mooney | we can deprecte the feature flag and drop it after 2025.2 goes eol in 12 months | 11:51 |
| sean-k-mooney | or perhaps 2025.1 in 18 | 11:51 |
| sean-k-mooney | i need to think about how that works but you get the idea | 11:51 |
| sean-k-mooney | when its not required on a stable brnach anymore | 11:52 |
| dviroel | yes | 11:52 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add option to SKIP Actions https://review.opendev.org/c/openstack/watcher-dashboard/+/958209 | 12:01 |
| chandankumar | dviroel: sean-k-mooney ^^ patches updated, feel free to review it in your free time, thank you! | 12:02 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Fix translation context for watcher action states https://review.opendev.org/c/openstack/watcher-dashboard/+/959189 | 12:04 |
| opendevreview | Ivan Anfimov proposed openstack/watcher-dashboard master: Remove url tags from README https://review.opendev.org/c/openstack/watcher-dashboard/+/961474 | 12:27 |
| opendevreview | Ivan Anfimov proposed openstack/watcher-dashboard master: Remove url tags from README https://review.opendev.org/c/openstack/watcher-dashboard/+/961474 | 12:28 |
| opendevreview | Ivan Anfimov proposed openstack/watcher-dashboard master: Migrate setup configuration to pyproject.toml https://review.opendev.org/c/openstack/watcher-dashboard/+/961476 | 12:32 |
| opendevreview | Ivan Anfimov proposed openstack/watcher-dashboard master: Migrate setup configuration to pyproject.toml https://review.opendev.org/c/openstack/watcher-dashboard/+/961476 | 12:36 |
| opendevreview | Takashi Kajinami proposed openstack/watcher-dashboard master: Use yaml format policy file https://review.opendev.org/c/openstack/watcher-dashboard/+/955652 | 14:13 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: Generate sample policy file in local directory https://review.opendev.org/c/openstack/watcher/+/961486 | 14:15 |
| opendevreview | Takashi Kajinami proposed openstack/watcher-dashboard master: Use yaml format policy file https://review.opendev.org/c/openstack/watcher-dashboard/+/955652 | 14:17 |
| *** dansmith_ is now known as dansmith | 14:39 | |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Add missing 1.6 API doc in rest version history https://review.opendev.org/c/openstack/watcher/+/961493 | 14:56 |
| dviroel | jgilaber_ sean-k-mooney ^ oops | 14:57 |
| sean-k-mooney | ah yes that shoudl be there | 14:57 |
| sean-k-mooney | the doc rendered from master so that will be enough to fix it for the live page but we shoudl backport that to 2025.2 as well | 14:58 |
| sean-k-mooney | but i also agree with markign this as low | 14:59 |
| dviroel | ack | 15:01 |
| jgilaber_ | thanks dviroel I'm merging it | 15:03 |
| *** jgilaber_ is now known as jgilaber | 15:04 | |
| sean-k-mooney | so if that chagne was actully required to make 1.6 fucntionatl, its not, it may have warrented an rc2 | 15:13 |
| sean-k-mooney | but in this case we are fine its only a docs bug | 15:14 |
| dviroel | ++ | 15:16 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: Generate sample policy file in local directory https://review.opendev.org/c/openstack/watcher/+/961486 | 16:34 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Add a scenario test with continuous audit https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/954264 | 18:19 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Enable Continuous Audit tests in CI https://review.opendev.org/c/openstack/watcher/+/961533 | 18:24 |
| dviroel | zuul is not helping today | 18:52 |
| sean-k-mooney | that looks lime maybe a slightly slow node | 19:22 |
| sean-k-mooney | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_92c/openstack/92c9feb62f1d4307b8b3077038165eb1/testr_results.html | 19:22 |
| sean-k-mooney | we coudl not delete the audit whiel it was runing in the test cleanup | 19:22 |
| sean-k-mooney | but presumabnly that was becasue the test took too long to run or we otherise teimed out? | 19:23 |
| sean-k-mooney | there is some sort of race there | 19:23 |
| dviroel | hum maybe, I was looking at the list datamodel error in this test, so i was ignoring this problem in the end | 19:26 |
| dviroel | " Couldn\'t delete when state is \'ONGOING\'" | 19:27 |
| dviroel | this is true, we can't delete ONGOING, we need to cancel it | 19:27 |
| dviroel | maybe the Cleanup function can be improved there, if we fail on a ONGOING audit, we need to cancel it first, and then delete | 19:28 |
| dviroel | you could -1 my tempest change based on that :) | 19:29 |
| dviroel | the datamodel failed because the test was missing min_microversion = "1.3" | 19:30 |
| dviroel | i proposed this change before the microversion support, so it was missing that | 19:30 |
| opendevreview | Merged openstack/watcher master: Add unit tests for instance and volume not found in model https://review.opendev.org/c/openstack/watcher/+/956197 | 20:36 |
| opendevreview | Merged openstack/watcher master: Fix zone migration instance not found issue https://review.opendev.org/c/openstack/watcher/+/956198 | 20:36 |
| opendevreview | Merged openstack/watcher master: Add missing 1.6 API doc in rest version history https://review.opendev.org/c/openstack/watcher/+/961493 | 20:37 |
| opendevreview | Merged openstack/watcher-dashboard master: Remove url tags from README https://review.opendev.org/c/openstack/watcher-dashboard/+/961474 | 20:46 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!