| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Add Continuous audit dummy strategy scenario test https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/955472 | 06:27 |
|---|---|---|
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Move unit tests to tests/unit folder https://review.opendev.org/c/openstack/watcher/+/967502 | 10:09 |
| opendevreview | Merged openstack/watcher-specs master: Improve Watcher Dashboard code quality and test infrastructure https://review.opendev.org/c/openstack/watcher-specs/+/963438 | 11:50 |
| amoralej | Hi, wrt https://bugs.launchpad.net/watcher/+bug/2131663 , I've crated a blueprint with a proposal to parametrize the migrate timeout in https://blueprints.launchpad.net/watcher/+spec/parametize-migrate-timeout , I'd like to implement that in two phases, 1st system-wide config option, 2nd per-strategy perameters | 11:58 |
| amoralej | for 1st one, I guess i need a spec, should i create one only for the config option or one spec for both phases? | 11:58 |
| amoralej | btw, after creating the blueprint i found https://blueprints.launchpad.net/watcher/+spec/instance-live-migration-timeout from 2021 , I think i can not take it over, so i should keep working in mine's? | 12:00 |
| jgilaber | amoralej, looks like I can modify the existing blueprint, want me to assign it to you and maybe then you'll be able to as well? | 12:02 |
| jgilaber | about the spec, I think we can cover both changes in one | 12:03 |
| amoralej | I'm not sure, tbh, my approach is pretty similar to the one described in there, so it may reflect the 1st step, although i will probably make it slightly different | 12:04 |
| amoralej | ^ about the blueprint | 12:04 |
| jgilaber | I see there is also an option to mark the blueprint as superseeded, so maybe we can do that for the old one and keep yours? | 12:04 |
| amoralej | I'd say so tbh, but let's see what others think | 12:05 |
| amoralej | it has been 4 years and I'd say the creator of that blueprint has not been contributing to watcher or other project since then | 12:08 |
| dviroel | amoralej: i think that the config option could the fix for the bug reported, and we can than discuss if we should backport it or not | 12:13 |
| dviroel | and the per-strategy/audit/etc you could cover using the blueprint | 12:13 |
| amoralej | dviroel, for the config option, do i need to create a spec? | 12:28 |
| dviroel | amoralej: i don't think so, for me is a bugfix | 12:31 |
| amoralej | if that's fine, I'll do that, thanks! | 12:35 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Refactor: Extract common test methods to BaseCommon class https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/967522 | 13:07 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: DNM - Testing job refactor on watcher repo https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/967526 | 13:22 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: DNM - Testing job refactor on watcher repo https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/967526 | 13:38 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!