| opendevreview | chandan kumar proposed openstack/watcher master: Replace watcher-grenade with grenade-multinode job https://review.opendev.org/c/openstack/watcher/+/986321 | 05:17 |
|---|---|---|
| opendevreview | Joan Gilabert proposed openstack/watcher master: Remove nova_helper retries for openstacksdk params https://review.opendev.org/c/openstack/watcher/+/975498 | 10:34 |
| sean-k-mooney | dviroel: mind taking a look at https://review.opendev.org/c/openstack/devstack-plugin-prometheus/+/986360 when your around. tl;dr we need to merge someting to cause the mirror to be created and updatign the pre-commit hooks which we shoudl do every few months is as good as any | 13:06 |
| dviroel | sean-k-mooney: ack, i will take a look | 13:07 |
| winiciusallan[m] | folks, shouldn't this patch ^ be notified by the opendevreview bot here on this channel? | 13:59 |
| winiciusallan[m] | not sure if there is another channel which tracks these changes | 13:59 |
| sean-k-mooney | the devstack-prometions plugin shoudl be notifed here and in the telemery channel yes | 14:01 |
| sean-k-mooney | winiciusallan[m]: assumign that what you were referitn too | 14:01 |
| winiciusallan[m] | yes, I'm refering to this one | 14:02 |
| dviroel | it is currently notified in #openstack-qa channel | 14:02 |
| winiciusallan[m] | I didn't see the stephen's patch, that's why im asking | 14:02 |
| dviroel | but i think that it could be notified elsewhere too | 14:03 |
| sean-k-mooney | ya it used to be sent to multipel lcoation i tought | 14:06 |
| sean-k-mooney | it might have been incorrectly redirected | 14:06 |
| sean-k-mooney | but we can fix that eailly enough | 14:07 |
| winiciusallan[m] | something that I could do? | 14:08 |
| sean-k-mooney | it need dviroel to sighn eoff on it by +1ing the review but it configured form https://github.com/openstack/project-config/blob/master/gerritbot/channels.yaml | 14:11 |
| sean-k-mooney | we need to add https://github.com/openstack/project-config/blob/master/gerritbot/channels.yaml#L950C5-L950C43 | 14:12 |
| sean-k-mooney | under watcher as well | 14:12 |
| sean-k-mooney | https://github.com/openstack/project-config/blob/master/gerritbot/channels.yaml#L1376 | 14:12 |
| sean-k-mooney | hum ok we just didnt add it correctly orginally https://github.com/openstack/project-config/commit/cddca933733e7e240141f3a7b92c2a0ea9cf79d1 | 14:13 |
| sean-k-mooney | or we did but we didnt add it to the watcher channel as well | 14:14 |
| winiciusallan[m] | I'll go for it. AFAIU dviroel just need to +1 the patch, isn't it? or is it need to be signed by him? | 14:33 |
| dviroel | winiciusallan[m]: go4it - it will be good to have this tracker here in watcher channel | 14:35 |
| winiciusallan[m] | dviroel: ack | 14:36 |
| winiciusallan[m] | done https://review.opendev.org/c/openstack/project-config/+/986386 | 14:49 |
| dviroel | winiciusallan[m]: thanks, voted | 15:31 |
| winiciusallan[m] | no worries, glad to help | 16:22 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher master: Update the How to contribute documentation https://review.opendev.org/c/openstack/watcher/+/986314 | 23:40 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher master: Update the How to contribute documentation https://review.opendev.org/c/openstack/watcher/+/986314 | 23:51 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!