| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher master: Update the How to contribute documentation https://review.opendev.org/c/openstack/watcher/+/986314 | 00:26 |
|---|---|---|
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Fix disk accounting for BFV instances https://review.opendev.org/c/openstack/watcher/+/986486 | 06:53 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add debug logging for host rejection in workload_balance https://review.opendev.org/c/openstack/watcher/+/986504 | 09:24 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Replace status_choices with display_choices https://review.opendev.org/c/openstack/watcher-dashboard/+/959189 | 09:25 |
| opendevreview | Merged openstack/watcher master: objects: Prepare for oslo.versionedobjects 3.10.0 https://review.opendev.org/c/openstack/watcher/+/985633 | 11:25 |
| opendevreview | Merged openstack/watcher master: objects: Avoid aliasing o.vo fields https://review.opendev.org/c/openstack/watcher/+/985634 | 11:48 |
| opendevreview | Merged openstack/watcher master: tox: Remove override of install_command https://review.opendev.org/c/openstack/watcher/+/985644 | 11:48 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Fix disk accounting for BFV instances https://review.opendev.org/c/openstack/watcher/+/986486 | 14:04 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Fix disk accounting for BFV instances https://review.opendev.org/c/openstack/watcher/+/986486 | 15:56 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher master: Update the How to contribute documentation https://review.opendev.org/c/openstack/watcher/+/986314 | 16:38 |
| sean-k-mooney | winiciusallan[m]: i shoudl also say the teim-ci comments are from an experimental ai code review system im running. while you should consdier it feedback use your own judgement | 18:35 |
| sean-k-mooney | winiciusallan[m]: feel ree to ignore it if you do not agree | 18:35 |
| sean-k-mooney | i try to traige its comment when i review patches but its not the same as human review so dont feel like you have to please it | 18:36 |
| winiciusallan[m] | sean-k-mooney: ack. tbh, I thought most of the bot comments very insightful, despite some false positives | 19:09 |
| winiciusallan[m] | they tend to always judge your code and give a plausible answear | 19:10 |
| winiciusallan[m] | I'll check what was addressed and push another patch if I think it is needed | 19:10 |
| winiciusallan[m] | thanks for the fast review :thumbsup: | 19:11 |
| sean-k-mooney | i dont know if you looked at the html report https://minio-api.teim.app/zuul-logs/82e/main/82ee445cb06f43c5969f95d60adae116/code-review/review-report.html but its summary was Overall Assessment: Ready with minor fixes | 19:25 |
| sean-k-mooney | whic i agree with | 19:25 |
| sean-k-mooney | i have tired to make it a constructive reviewer | 19:25 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Fix disk accounting for BFV instances https://review.opendev.org/c/openstack/watcher/+/986486 | 19:26 |
| winiciusallan[m] | sean-k-mooney @_oftc_sean-k-mooney:matrix.org: no I didn't. that's cool | 19:32 |
| sean-k-mooney | 98% of folk probaly dont since it not really obvious | 19:32 |
| sean-k-mooney | orgianlly it only create a report in the job logs then i made it comment inline | 19:33 |
| winiciusallan[m] | this is something just experimental, isnt it? | 19:33 |
| sean-k-mooney | yes | 19:33 |
| sean-k-mooney | its an experment we are doing in this team. it has been useful | 19:34 |
| winiciusallan[m] | the whole discussion about using AIs to review code... | 19:34 |
| sean-k-mooney | but i sometime wonder at want point the experimetn shoudl end | 19:34 |
| sean-k-mooney | ya so usign it to aid in review i think is ok | 19:34 |
| winiciusallan[m] | for the docs at least it proves useful, but a human in the loop should exist for sure | 19:34 |
| sean-k-mooney | allowing it ot make desciosn on if sometihng is good enouch to merge is a very diffent thing | 19:34 |
| sean-k-mooney | ya so that why orginally it preppares a reprot that i woudl go read when reviewing a patch | 19:35 |
| sean-k-mooney | to provide extra context to me as a reviewer | 19:35 |
| sean-k-mooney | i debated if providign that context to a new contibutor was a good or bad thing | 19:35 |
| winiciusallan[m] | this makes a lot of sense, especially because you, and a lot of contributors, work in more than one project | 19:36 |
| sean-k-mooney | winiciusallan[m]: if you have feedback on this in the future let me know | 19:36 |
| winiciusallan[m] | so there are a lot of context switch | 19:36 |
| winiciusallan[m] | I was thinking of start reviewing patches on watcher to see how people do things on this project | 19:37 |
| winiciusallan[m] | not sure if the context that you said is for a nrw contributor as reviewer or owner of a change | 19:38 |
| sean-k-mooney | its for both really | 19:38 |
| sean-k-mooney | part of the idea of the bot was to review for thing that are proejct convention and provide faster feedback then waiting for a human | 19:39 |
| sean-k-mooney | more reviewrs are alwasy welcome, review is more about establishing a shared understnading of the code then anythign else | 19:39 |
| sean-k-mooney | as a core revierer i can provide feedback on areas you might not fully understand and as a contibutor you can shed light on the probelem your trying to solve | 19:40 |
| sean-k-mooney | so its a back and fort but its a good way to learn | 19:40 |
| winiciusallan[m] | yeah | 19:41 |
| winiciusallan[m] | watcher is way easier because the base code is not that big, but still needs a knowledge about the cores concepts and how this things are connect | 19:42 |
| winiciusallan[m] | let's see how it goes | 19:42 |
| opendevreview | Douglas Viroel proposed openstack/watcher-specs master: Add spec for Audit Pipeline feature https://review.opendev.org/c/openstack/watcher-specs/+/969840 | 19:42 |
| winiciusallan[m] | I believe this is a pain from other newcomers which is: sometimes one is not too confident to give a feedback because they don't understand well | 19:43 |
| winiciusallan[m] | anyway... thinking out loud hahaha | 19:43 |
| sean-k-mooney | well fedback doe snto have to be directional it cna just be asking why an approch was taken | 19:44 |
| sean-k-mooney | that can be as usful as anything else | 19:45 |
| sean-k-mooney | i.e. if you tought somethign could be done simpler and you ask why the complex approch was taken | 19:45 |
| sean-k-mooney | at the very leset that is perhasp a signal that a code comment might help future us | 19:45 |
| sean-k-mooney | or that the commit message shoudl eb better | 19:45 |
| winiciusallan[m] | ya that's a good point of view | 19:50 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher master: Update the How to contribute documentation https://review.opendev.org/c/openstack/watcher/+/986314 | 21:35 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!