| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: [DNM] Add boot from volume tests to workload_balancing strategies https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986616 | 07:36 |
|---|---|---|
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Fix disk accounting for BFV instances https://review.opendev.org/c/openstack/watcher/+/986486 | 08:10 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Drop ExtendPlacementClient in favor of tempest placement lib https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986622 | 09:14 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher stable/2026.1: Skill boot-from-volume tests in stable release https://review.opendev.org/c/openstack/watcher/+/986623 | 09:50 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher stable/2026.1: Skip boot-from-volume tests in stable release https://review.opendev.org/c/openstack/watcher/+/986623 | 09:52 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher stable/2025.2: Skip boot-from-volume tests in stable release https://review.opendev.org/c/openstack/watcher/+/986624 | 09:52 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher stable/2025.1: Skip boot-from-volume tests in stable release https://review.opendev.org/c/openstack/watcher/+/986625 | 09:53 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher stable/2024.2: Skip boot-from-volume tests in stable release https://review.opendev.org/c/openstack/watcher/+/986626 | 09:55 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Fix disk accounting for BFV instances https://review.opendev.org/c/openstack/watcher/+/986486 | 10:08 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Add boot from volume tests to workload_balancing strategies https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986616 | 10:10 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Add boot from volume tests to workload_balancing strategies https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986616 | 10:15 |
| amoralej | Hi, gate for 2024.2 is broken https://review.opendev.org/c/openstack/watcher/+/986626 . Would it be fine if i propose to get rid of the 2024.1 job in watcher-tempest-plugin gate? we are running watcher-tempest-gnocchi-2024-2 there | 11:40 |
| jgilaber | yes, we'll need to do it anyway since the 2024.2 branch is moving to eol soon ( I think today the patches for that were supposed to merge) | 11:41 |
| amoralej | ok, I'll send the patch | 11:41 |
| jgilaber | aobut the patch linked, if the tempest test require a specific patch to run they should not run by default | 11:42 |
| jgilaber | and only run in branches where the patch is enabled by setting some configuration flag | 11:42 |
| amoralej | I sent patches to the stable branches to exclude bfv tags, see the depends-on in https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986616 | 11:45 |
| dviroel | i personally think that for "features" is better to use config options instead. If we keep adding tags, that will explode at some point. And it is also not the regular usage of tags in tempest | 11:48 |
| dviroel | setting a config option to be disabled by default will avoid all the patch to stable branches | 11:49 |
| amoralej | wfm, I will update my patches | 11:49 |
| amoralej | optimize.run_bfv_tests is fine? or run_bootfromvolume_tests ? wdyp | 11:51 |
| dviroel | bfv work for me, since config option allows you to add a description and mention that is boot from volume | 11:51 |
| amoralej | so i can enable it from master in https://review.opendev.org/c/openstack/watcher/+/986486 so that i can run it with depends-on in the tempest plugin gate | 11:52 |
| dviroel | i don't know, that would make you watcher patch depends on the tempest to merge first | 11:55 |
| dviroel | which is not usually the common workflow (e.g merge tempest tests before merging the feature itself) | 11:56 |
| amoralej | no, sorry, i mean the other way around. IIUC, I can add the option even if it's not registered in the plugin itself? but it's used in the watcher-plugin with the depends-on | 11:56 |
| amoralej | or will it fail ? | 11:56 |
| sean-k-mooney | amoralej: i have a ptch up for this | 11:57 |
| sean-k-mooney | amoralej: 2024.2 will be eol technially yesterday | 11:57 |
| amoralej | that way, we don't merge the patch in watcher until we validate it in the plugin with depends on | 11:57 |
| dviroel | the plugin can depends on the feature yeah | 11:57 |
| sean-k-mooney | 2024.1 shoudl not be tested anymore | 11:57 |
| sean-k-mooney | the oldes stable branch we shoudl be testingis 2025.1 and on that branch there should not be any grende jobs | 11:58 |
| sean-k-mooney | amoralej: excluidng hte bfv tag is not the right approch | 12:00 |
| sean-k-mooney | at least in general we shoudl not be modifying job defintion to get compatiabltiy when we add new test like this | 12:01 |
| amoralej | I'm implementing a new config option, as discussed with dviroel | 12:01 |
| sean-k-mooney | ack im jsut skimming back over the log | 12:01 |
| amoralej | sure, np, feedback is appreciated | 12:02 |
| sean-k-mooney | so my clenaup patch was for cyborg it seams https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/983194 | 12:02 |
| sean-k-mooney | i tought i also had one for watcher-tempest-plugin | 12:03 |
| sean-k-mooney | in any case we shoudl ahve a seperte patch to remove - watcher-tempest-gnocchi-2024-2 | 12:03 |
| sean-k-mooney | form check and gate | 12:04 |
| sean-k-mooney | takashi correctly added the 2026.1 jobs https://opendev.org/openstack/watcher-tempest-plugin/commit/cd03c9bf18e82277de408956f56ecbf05e3a274e | 12:04 |
| sean-k-mooney | we just didnt followup to delete 2024.2 | 12:05 |
| amoralej | i can add the patch | 12:06 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Remove 2024.2 jobs from the zuul gates https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986635 | 12:06 |
| amoralej | ^ | 12:06 |
| amoralej | we have two jobs for each one of the supported release, so i'd say we are fine with the existing jobs | 12:07 |
| sean-k-mooney | ya we shoudl be | 12:08 |
| dviroel | btw, sean-k-mooney jgilaber amoralej: the audit pipeline spec was updated yesterday: https://review.opendev.org/c/openstack/watcher-specs/+/969840 - ptal when you folks have some time | 12:09 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Fix disk accounting for BFV instances https://review.opendev.org/c/openstack/watcher/+/986486 | 12:31 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Add boot from volume tests to workload_balancing strategies https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986616 | 12:31 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Add boot from volume tests to workload_balancing strategies https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986616 | 12:44 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Add boot from volume test for zone_migration strategy https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/986641 | 12:44 |
| opendevreview | David proposed openstack/watcher-tempest-plugin master: Add comprehensive tests for action precondition validation https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/966860 | 13:57 |
| winiciusallan[m] | dviroel: wondering here about the core members section, I'm intending to leave as it is | 16:35 |
| winiciusallan[m] | despite the different projects have differente core members, most of them are the same across projects and they don't change very often, right? | 16:35 |
| winiciusallan[m] | i thought of adding an external link to gerrit https://review.opendev.org/admin/groups/q/filter:watcher | 16:35 |
| winiciusallan[m] | git it returns project which are not managed by the watcher core AFAIK | 16:36 |
| winiciusallan[m] | s/git/but | 16:37 |
| dviroel | winiciusallan[m]: they have similar members, but not are not equal | 16:40 |
| dviroel | the filter link doesn't seems to help I think | 16:41 |
| dviroel | in the end, the contributors doesn't really need to know who are the core reviewers | 16:41 |
| dviroel | In case of lack of review in a patch, they can request attention in this channel or in the weekly meeting. | 16:42 |
| dviroel | so that section is not really require I think | 16:42 |
| dviroel | up to you to keep as is or remove, or even add more info there | 16:42 |
| winiciusallan[m] | yeah | 16:43 |
| winiciusallan[m] | will push a follow up patch removing it. if we notice people struggling with it we can add it back | 16:44 |
| dviroel | the irc channel and the weekly meetings are the best way to get attention from reviewers. not all reviewers are part of a core team in the end.. | 16:45 |
| winiciusallan[m] | +1. thanks! | 16:46 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher master: Update the How to contribute documentation https://review.opendev.org/c/openstack/watcher/+/986314 | 19:03 |
| opendevreview | Merged openstack/watcher master: Update the How to contribute documentation https://review.opendev.org/c/openstack/watcher/+/986314 | 20:11 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!