| opendevreview | Takashi Kajinami proposed openstack/watcher master: Align default_log_level to global default https://review.opendev.org/c/openstack/watcher/+/995367 | 03:00 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 07:51 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Playwright integration test for skip action workflow https://review.opendev.org/c/openstack/watcher-dashboard/+/976594 | 07:52 |
| dviroel | amoralej: chandankumar: what is missing to get https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 merged? | 14:13 |
| dviroel | we already had some reviews there and I think that is pretty close to merge it | 14:14 |
| amoralej | dviroel, chandankumar my main concern was https://review.opendev.org/c/openstack/watcher-dashboard/+/970353/comment/e5aa2cfa_4ee66a1b/ which is fixed | 14:29 |
| dviroel | nive | 14:31 |
| dviroel | nice | 14:31 |
| dviroel | sean-k-mooney: around? do you have any concern on merging playwright patch? your last vote was -1, but there were some updates... | 14:32 |
| dviroel | going to hold it a bit just in case | 14:32 |
| dviroel | https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 14:32 |
| amoralej | wrt `playwright install` , comments from chandankumar clarifies it a bit and i was wrong wrt creating a separate target, we may do it in extra_setup_commands instead of commands but that's just minor optimization | 14:33 |
| dviroel | ack, marked as resolved | 14:33 |
| dviroel | amoralej: lets see if sean has any concern before W+1 | 14:33 |
| dviroel | otherwise we can w+1 later today | 14:33 |
| sean-k-mooney | dviroel: sot of im in the cybrog irc meeting | 14:34 |
| sean-k-mooney | as long as the tox env is not installing things like a broser | 14:34 |
| sean-k-mooney | i think i was mostly ok with it | 14:34 |
| sean-k-mooney | ill check back after the meeting | 14:34 |
| dviroel | sure, forgot about the meeting | 14:34 |
| sean-k-mooney | no worries | 14:34 |
| dviroel | no worries, please take a look later then | 14:34 |
| chandankumar | thank you everyone for reviewing it. :-) | 14:46 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Cache node utilization to fix vm_workload_consolidation at scale https://review.opendev.org/c/openstack/watcher/+/992676 | 14:57 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add allocation-based capacity checks to vm_workload_consolidation https://review.opendev.org/c/openstack/watcher/+/993088 | 14:57 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add allocation-based capacity checks to vm_workload_consolidation https://review.opendev.org/c/openstack/watcher/+/993088 | 15:30 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: Use built-in method to build RequestContext https://review.opendev.org/c/openstack/watcher/+/995382 | 17:08 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: Fix handling of X-Show-Deleted header https://review.opendev.org/c/openstack/watcher/+/995548 | 17:08 |
| sean-k-mooney | dviroel: i think tis mostly fine however the borwser install in tox shoudl not be there | 18:31 |
| dviroel | sean-k-mooney: it was there, then removed, and now it is back | 18:32 |
| dviroel | we need to check with chandankumar why it needs to be there | 18:32 |
| sean-k-mooney | right i asksed for it to be remvoed before | 18:32 |
| dviroel | so we can sync tomorrow with chandan to see if there is an alternative | 18:32 |
| dviroel | so for now we can hold | 18:32 |
| sean-k-mooney | https://review.opendev.org/c/openstack/watcher-dashboard/+/970353/comment/b4bd85cf_23d81aa8/ | 18:36 |
| sean-k-mooney | so the pre-playboox is usign playright rom node via npx | 18:36 |
| sean-k-mooney | isntead of using playright-python | 18:36 |
| sean-k-mooney | with upper cosntratis | 18:37 |
| dviroel | right, which causes version mismatch | 18:46 |
| sean-k-mooney | https://review.opendev.org/c/openstack/watcher-dashboard/+/970353/comment/b9676bbd_4b49ae56/ | 18:47 |
| sean-k-mooney | so i think that is how to resolve this | 18:47 |
| dviroel | ack, we can check if chandan can validate/update tomorrow then | 18:49 |
| sean-k-mooney | that combinign 2 slightly more advance tox feature where you can have evn variant and variant specific commands | 18:50 |
| sean-k-mooney | that what the `playwright:` prefix is | 18:51 |
| sean-k-mooney | https://tox.wiki/en/4.56.1/how-to/usage.html#platform-factors-with-environment-factors | 18:53 |
| sean-k-mooney | apprelty they use the term "factors" | 18:53 |
| sean-k-mooney | and they im combining that wiht https://tox.wiki/en/4.56.1/reference/config.html#generative-section-names | 18:54 |
| sean-k-mooney | huh i didnt know you coudl use the expations in the desp and setevn as well https://tox.wiki/en/4.56.1/reference/config.html#ini-expansion-syntax | 18:56 |
| opendevreview | Merged openstack/watcher master: Replace deprecated remotable_classmethod https://review.opendev.org/c/openstack/watcher/+/995372 | 19:52 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher-specs master: Add spec for Preemptible Instances feature https://review.opendev.org/c/openstack/watcher-specs/+/987171 | 21:32 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!