| opendevreview | Alfredo Moralejo proposed openstack/watcher-specs master: Add spec for Action Plan Transformers Framework https://review.opendev.org/c/openstack/watcher-specs/+/994607 | 10:44 |
|---|---|---|
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher-specs master: Add spec for Preemptible Instances feature https://review.opendev.org/c/openstack/watcher-specs/+/987171 | 12:18 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Add default_parameters support to Audit Templates https://review.opendev.org/c/openstack/watcher/+/993453 | 13:26 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Add metric cache to DataSourceBase https://review.opendev.org/c/openstack/watcher/+/995119 | 13:26 |
| dviroel | sean-k-mooney: amoralej: chandankumar - so, about "Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353" | 13:27 |
| dviroel | the main point in the discussion is about not installing browser using npx | 13:28 |
| dviroel | chandankumar: have you tried the approach pointed by sean? | 13:28 |
| dviroel | if not, can you test on your side and provide a feedback, before pushing a new ps? | 13:29 |
| sean-k-mooney | tox shoudl not install things as a sideffect in general | 13:30 |
| sean-k-mooney | the only exception to tha tbeing the venv depencies | 13:30 |
| sean-k-mooney | and ocne the venv is created we shoudl not need to redownload them i.e. you shoudl be ableo to ideally run offlien | 13:31 |
| sean-k-mooney | there are flag for tox to disabel that | 13:31 |
| sean-k-mooney | i.e. skip the depency installtion and jsut move to runing the test commands | 13:32 |
| sean-k-mooney | so ya we need node because playwrite is a node applcaiton | 13:32 |
| sean-k-mooney | but the depencies shoudl for it like a browser should really be installed seperatly once outside of tox | 13:33 |
| sean-k-mooney | if its done via tox it shoudl be optional and off by default | 13:33 |
| chandankumar | I am trying with python -m pip install playwright and then python -m playwrihjt install-deps webkit | 13:33 |
| sean-k-mooney | i dont know if that actully works by the way i think it will but it may not. | 13:34 |
| chandankumar | Since I was using npm, it will installing different version of webkit , they why I moved the webkit installtion in tox.ini | 13:34 |
| chandankumar | updating the cr | 13:34 |
| sean-k-mooney | well its not that your using npm | 13:34 |
| sean-k-mooney | its that your not translating the upper-constrait | 13:34 |
| sean-k-mooney | when using npm | 13:35 |
| sean-k-mooney | so the version of playwritng your using with npx and the version of playwright used by tox are diffenrent | 13:35 |
| sean-k-mooney | you coudl also do `tox -e venv -- python -m playwright install ...` in theory | 13:36 |
| sean-k-mooney | in the ci job | 13:36 |
| sean-k-mooney | that will avoid you having to manulaly install the correct version of playwright | 13:37 |
| amoralej | that should work, 1st run with --notest to create the venv, then execute playwright install manually in the venv and finally run tox -eintegration-playwright | 13:46 |
| chandankumar | workong on updting the pre-playbook | 13:46 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 13:48 |
| amoralej | i test the solution proposed by sean-k-mooney and we could create two tox envs integration-playwright and integration-playwright_with_deps or whatever and do the installation only in one of them if preferred | 13:48 |
| sean-k-mooney | integration and integration-playwright | 13:49 |
| sean-k-mooney | did you see my comment about the missing , | 13:49 |
| amoralej | nop | 13:49 |
| sean-k-mooney | integration should just run the tests | 13:49 |
| amoralej | lemme try it | 13:49 |
| sean-k-mooney | ya so in the {} | 13:49 |
| sean-k-mooney | it shoudl have been {,-playwright} | 13:49 |
| sean-k-mooney | so concatination the empty stric or -playwright | 13:50 |
| sean-k-mooney | *empty string | 13:50 |
| amoralej | ahhh, that may be it | 13:50 |
| amoralej | yep, works like a charm | 13:51 |
| sean-k-mooney | cool we use that for thing like `py3{,11,12,13,14}` | 13:53 |
| sean-k-mooney | to supprot py311 or py3 | 13:53 |
| sean-k-mooney | that not the most compellign exampel since py3 is oen fo the defautl ones that "just works" without you having to do that manually | 13:54 |
| sean-k-mooney | but if you wnat to have unit{-windows,mac} to supprot linux windows and mac} | 13:54 |
| sean-k-mooney | then you do it that way.... | 13:54 |
| sean-k-mooney | forgot the first , again :) | 13:55 |
| sean-k-mooney | `unit{,-windows,-mac}` works as `unit` `unit-windows` and `unit-mac` | 13:55 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 14:34 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 15:10 |
| chandankumar | sean-k-mooney: I am hitting https://paste.openstack.org/raw/bFFH2Mg6eRxFFF5dxKH7/ while using python -m pip install playwright, that's why I think I went with nodejs | 15:51 |
| chandankumar | Any pointers to overcome this issue | 15:53 |
| chandankumar | going with tox vnev way | 16:02 |
| chandankumar | of this one fails, will dig tomorrow | 16:07 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 16:07 |
| sean-k-mooney | thats because you globally installing instead of in va vnev | 16:52 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher-specs master: Add spec for Preemptible Instances feature https://review.opendev.org/c/openstack/watcher-specs/+/987171 | 18:13 |
| winiciusallan[m] | sean-k-mooney dviroel amoralej: I left a few comments in the spec regarding your comments. Just a few questions but I think we can decide them timely | 18:14 |
| winiciusallan[m] | thanks for taking time to review it :) | 18:14 |
| sean-k-mooney | sure. i will be going back to review it again shortly then calling it a day in then next hour or so | 18:18 |
| sean-k-mooney | winiciusallan[m]: ill finish the commit im creating quickly adn then rely in the review | 18:24 |
| winiciusallan[m] | sean-k-mooney: alright. no rush | 18:25 |
| dviroel | reviewing it now | 18:50 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher-specs master: Add spec for Preemptible Instances feature https://review.opendev.org/c/openstack/watcher-specs/+/987171 | 22:35 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!