*** alcabrera is now known as alcabrera|afk | 00:37 | |
*** kgriffs|afk is now known as kgriffs | 00:50 | |
*** kgriffs is now known as kgriffs|afk | 00:59 | |
*** kgriffs|afk is now known as kgriffs | 01:43 | |
*** reed has quit IRC | 01:48 | |
*** X019 has quit IRC | 02:06 | |
*** kgriffs is now known as kgriffs|afk | 02:07 | |
*** kgriffs|afk is now known as kgriffs | 02:15 | |
*** kgriffs is now known as kgriffs|afk | 03:06 | |
*** alcabrera|afk is now known as alcabrera | 03:14 | |
*** kgriffs|afk is now known as kgriffs | 03:33 | |
exploreshaifali | from where I can learn about storage plane of zaqar? | 03:52 |
---|---|---|
*** kgriffs is now known as kgriffs|afk | 04:34 | |
*** kgriffs|afk is now known as kgriffs | 04:38 | |
*** fifieldt_ has quit IRC | 04:42 | |
*** sgotliv has joined #openstack-zaqar | 04:43 | |
exploreshaifali | hi sgotliv | 04:45 |
sgotliv | exploreshaifali, hi | 04:45 |
exploreshaifali | sgotliv, I want to learn more about storage layer of zaqar, please can u help | 04:46 |
sgotliv | exploreshaifali, it depends on what you need, I am not a regular zaqar follower | 04:46 |
sgotliv | exploreshaifali, I can try | 04:47 |
exploreshaifali | sgotliv,please :) | 04:48 |
exploreshaifali | sgotliv, u are an zaqar developer? | 04:48 |
sgotliv | exploreshaifali, no I am not | 04:48 |
exploreshaifali | oh, ok np :) | 04:49 |
sgotliv | exploreshaifali, but shoot ask your questions ;-) | 04:49 |
sgotliv | exploreshaifali, I can bring someone who knows answers in the worst case | 04:50 |
exploreshaifali | sgotliv, question is same as above, how to start learning for storage layer of zaqar | 04:50 |
exploreshaifali | I am only aware that it has two main planes, one is control and another is data plane | 04:51 |
sgotliv | correct | 04:54 |
sgotliv | So now go and start reading code | 04:54 |
sgotliv | ControlDriverBase | 04:54 |
sgotliv | and DataDriverBase | 04:55 |
exploreshaifali | sgotliv, okay so I should understand everything via code only | 04:55 |
exploreshaifali | above two are classes? | 04:55 |
exploreshaifali | right | 04:55 |
sgotliv | Open them please | 04:55 |
sgotliv | I do the same :-) | 04:56 |
exploreshaifali | I am refering https://github.com/openstack/zaqar/tree/master/zaqar/queues/storage | 04:56 |
sgotliv | it takes me time to rebase a code | 04:58 |
sgotliv | I am reading it and I am not sure I understand why they need two driver types :-) | 05:03 |
exploreshaifali | sgotliv, which file u are reading? | 05:05 |
sgotliv | storage/base.py | 05:05 |
sgotliv | the explanation for the base drivers | 05:06 |
exploreshaifali | from https://github.com/openstack/zaqar where I need to move :P | 05:07 |
sgotliv | zaqar/queues/storage | 05:08 |
sgotliv | then open base.py | 05:09 |
exploreshaifali | sgotliv, yes :) | 05:09 |
sgotliv | opend this https://review.openstack.org/#/c/50721/ | 05:10 |
exploreshaifali | by "why they need two driver types" u mean for Control and Data drivers? | 05:10 |
sgotliv | this patch introduced those driver types and explain their purposes and differences | 05:10 |
sgotliv | yes | 05:11 |
sgotliv | I don't see an immediate usage for control drivers! | 05:12 |
exploreshaifali | sgotliv, as per I know, these two planes have diff purposes | 05:12 |
exploreshaifali | control plane is for all operate parts like all administrative tasks and all | 05:12 |
exploreshaifali | and data plane contain real data that need to move | 05:13 |
sgotliv | I understand that, this is obvious :-) | 05:13 |
sgotliv | however there is no any example for such administrative tasks | 05:14 |
sgotliv | Control driver seems to me like a theory | 05:14 |
exploreshaifali | :P | 05:14 |
exploreshaifali | my task is to separate these two planes, currently they share many things | 05:16 |
exploreshaifali | they both are kind a mix together | 05:16 |
exploreshaifali | like just one dbconfig for both | 05:17 |
sgotliv | who gave you this task? | 05:18 |
exploreshaifali | I am applying for OPW | 05:19 |
exploreshaifali | there a project for this task is mentioned :P | 05:19 |
sgotliv | oh congratulations! | 05:19 |
exploreshaifali | not yet, I am not selected right now | 05:19 |
sgotliv | Let's talk with flaper87|afk later this morning to clarify things. He is a great guy and zaqar expert | 05:20 |
exploreshaifali | yeah, he is the mentor | 05:20 |
sgotliv | really? | 05:20 |
exploreshaifali | yes, he is mentor for this project | 05:21 |
exploreshaifali | btw, sgotliv on which components of openstack u work? | 05:21 |
sgotliv | I am too lazy to work :-) | 05:21 |
*** alcabrera is now known as alcabrera|afk | 05:49 | |
*** exploreshaifali is now known as expshaifali|afk | 06:26 | |
*** prashanthr_ has joined #openstack-zaqar | 06:27 | |
*** expshaifali|afk is now known as exploreshaifali | 06:37 | |
*** flaper87|afk is now known as flaper87 | 06:49 | |
flaper87 | o/ | 06:50 |
flaper87 | exploreshaifali: hey, what's up? | 06:50 |
flaper87 | :) | 06:50 |
exploreshaifali | hi flaper87 :) | 06:50 |
flaper87 | exploreshaifali: how are you doing? | 06:51 |
exploreshaifali | I am just trying to understand storage layer | 06:51 |
exploreshaifali | and its two planes | 06:51 |
flaper87 | exploreshaifali: any specific question so far? | 06:51 |
*** prashanthr_ has quit IRC | 06:51 | |
exploreshaifali | I should start with understanding the code | 06:51 |
exploreshaifali | as mentioned by sgotliv | 06:51 |
exploreshaifali | so reading base.py file | 06:52 |
exploreshaifali | flapper87, am I on correct track? | 06:52 |
flaper87 | exploreshaifali: just 1 p :P | 06:53 |
flaper87 | flaper87 not flapper87 | 06:53 |
flaper87 | otherwise I won't see your mentions :D | 06:53 |
flaper87 | exploreshaifali: yup, you're on the right track | 06:53 |
exploreshaifali | :D yes | 06:53 |
flaper87 | reading the code is the way to go, you need to see how they are separated and how they interact with each other | 06:53 |
flaper87 | the other day I pointed you to the mongodb driver | 06:53 |
flaper87 | that's another good reference where you can see things working for real | 06:54 |
exploreshaifali | this file for mongodb driver https://github.com/openstack/zaqar/blob/master/zaqar/queues/storage/mongodb/driver.py | 06:54 |
flaper87 | correct | 06:55 |
exploreshaifali | ok :) | 06:55 |
exploreshaifali | flaper87, just one question in mind, marconi is old name of zaqar? | 06:56 |
flaper87 | exploreshaifali: yes | 06:58 |
exploreshaifali | and does it work with Python3.3 | 06:59 |
exploreshaifali | as here https://review.openstack.org/#/c/50721/ Jenkins failed its tests | 07:00 |
*** exploreshaifali is now known as expshaifali|afk | 07:01 | |
sgotliv | flaper87, I have a question | 07:01 |
flaper87 | sgotliv: let me think If I want to hear it :P | 07:02 |
flaper87 | sgotliv: kidding, go ahead | 07:02 |
flaper87 | expshaifali|afk: it does work with py3.3 | 07:02 |
flaper87 | expshaifali|afk: I mean, it's suppose to work with py3.3 | 07:02 |
flaper87 | ah no, it used to work with pypy until the gate broke. The client library does work with py3.3 though | 07:03 |
flaper87 | Zaqar works with py3.3 but some dependencies don't, AFAICS | 07:03 |
sgotliv | flaper87, I disagree with the term driver | 07:03 |
sgotliv | Data or Control | 07:03 |
flaper87 | sgotliv: that's not a question | 07:03 |
flaper87 | :P | 07:03 |
sgotliv | why you named them that way? | 07:03 |
sgotliv | is that a question :-) | 07:04 |
sgotliv | driver is a computer program that operates or controls a particular type of device | 07:04 |
sgotliv | in zaqar case they both operate the same "device" type - Redis, Mongo etc... | 07:05 |
flaper87 | sgotliv: because naming things is harder than writing code :D Right, just replace device with storage in this case | 07:05 |
flaper87 | I mean, each driver controls a specific storage | 07:05 |
sgotliv | what do you mean, replace? | 07:05 |
sgotliv | right | 07:06 |
flaper87 | that's why it's called driver | 07:06 |
sgotliv | I probably don't understand you | 07:06 |
flaper87 | I mean | 07:06 |
sgotliv | go to redis/driver.py | 07:06 |
sgotliv | why I see 2 different drivers inside? | 07:07 |
sgotliv | I expect to see here only one driver - Redis Driver | 07:07 |
flaper87 | Because there are 2 diferent Drivers. 1 is for the "data" plane and the other one is for the "control" plane | 07:07 |
flaper87 | no because you could use 2 different storage for each driver | 07:07 |
flaper87 | (which is the task expshaifali|afk will work on) | 07:07 |
sgotliv | I think its wrong approach :-) | 07:07 |
flaper87 | As of now, that's not clear but after they're separate you'll be able to do so | 07:08 |
flaper87 | why? | 07:08 |
sgotliv | driver is the piece of software wich is communicates with the Redis in this case | 07:08 |
sgotliv | control or data is the way you use it, right? | 07:09 |
flaper87 | No, it's just the typo of driver it is | 07:10 |
sgotliv | I agree this is a typo :-) | 07:10 |
flaper87 | type of* | 07:10 |
flaper87 | :D | 07:10 |
sgotliv | of we agree to disagree | 07:11 |
sgotliv | :-) now it my typo | 07:11 |
sgotliv | we agree to disagree | 07:11 |
*** fifieldt has joined #openstack-zaqar | 07:22 | |
*** sgotliv has quit IRC | 07:51 | |
*** openstackgerrit has quit IRC | 08:11 | |
*** expshaifali|afk is now known as exploreshaifali | 09:15 | |
*** njirap has joined #openstack-zaqar | 09:54 | |
*** sgotliv has joined #openstack-zaqar | 09:55 | |
*** malini1 has joined #openstack-zaqar | 10:48 | |
*** malini1 has quit IRC | 10:48 | |
*** malini1 has joined #openstack-zaqar | 10:49 | |
*** sgotliv has quit IRC | 10:54 | |
*** sgotliv has joined #openstack-zaqar | 11:08 | |
*** sgotliv has quit IRC | 11:19 | |
*** sgotliv has joined #openstack-zaqar | 11:21 | |
*** prashanthr_ has joined #openstack-zaqar | 11:50 | |
*** X019 has joined #openstack-zaqar | 12:18 | |
*** prashanthr_1 has joined #openstack-zaqar | 12:18 | |
*** njirap has quit IRC | 12:20 | |
prashanthr_1 | flaper87: Hello :) | 12:23 |
flaper87 | prashanthr_1: ahhh there you are | 12:23 |
flaper87 | finally | 12:23 |
flaper87 | prashanthr_1: how are you doing? | 12:23 |
flaper87 | prashanthr_1: any news on the sentinel thing? | 12:23 |
flaper87 | we *need* to get that done *before* Thursday | 12:24 |
flaper87 | :P | 12:24 |
prashanthr_1 | Ha ha yeah :) I am working on the bug we discussed about yesterday | 12:24 |
prashanthr_1 | kgriffs has commented that he would like to go ahead with the patch and update it | 12:25 |
prashanthr_1 | so that sentinel support can be added | 12:25 |
prashanthr_1 | flaper87: can you please go through the comments chain for the sentinel patch once ? | 12:27 |
* flaper87 gets the link | 12:27 | |
flaper87 | prashanthr_1: what's up with that? | 12:28 |
prashanthr_1 | flaper87: I just want to know if any further work is required on it ? | 12:28 |
prashanthr_1 | link->https://review.openstack.org/121474 | 12:29 |
flaper87 | I went through it yesterday and I think Kurt pretty much addressed my concerns too | 12:30 |
flaper87 | so, no other comments from me | 12:30 |
prashanthr_1 | flaper87: Thanks. I will rebase the changes and submit it so that it can be landed. | 12:31 |
flaper87 | prashanthr_1: awesome, thanks a lot | 12:31 |
flaper87 | sorry for the preasure | 12:31 |
flaper87 | but we need to get rc2 out asap | 12:31 |
*** njirap has joined #openstack-zaqar | 12:32 | |
prashanthr_1 | flaper87: No probs at all. It's totally my mistake here. After shifting to bangalore I have just not been able to focus. Really sorry about it. | 12:32 |
flaper87 | prashanthr_1: no need to be sorry, you've done an amazing work and when life happens, we just need to surf it | 12:33 |
*** jchai has joined #openstack-zaqar | 12:33 | |
prashanthr_1 | flaper87: Thanks :) | 12:34 |
*** openstackgerrit has joined #openstack-zaqar | 12:48 | |
*** sgotliv has quit IRC | 12:56 | |
*** jchai has quit IRC | 12:57 | |
*** sgotliv has joined #openstack-zaqar | 13:11 | |
*** sriram has joined #openstack-zaqar | 13:12 | |
*** mpanetta has joined #openstack-zaqar | 13:14 | |
*** bradjones has quit IRC | 13:15 | |
*** mpanetta_ has joined #openstack-zaqar | 13:16 | |
*** mpanetta has quit IRC | 13:16 | |
*** mpanetta_ is now known as mpanetta | 13:16 | |
*** jchai has joined #openstack-zaqar | 13:25 | |
*** kgriffs is now known as kgriffs|afk | 13:40 | |
*** prashanthr_1 has quit IRC | 13:45 | |
*** prashanthr_ has quit IRC | 13:48 | |
*** amitgandhinz has joined #openstack-zaqar | 14:07 | |
*** bradjones has joined #openstack-zaqar | 14:20 | |
*** kgriffs|afk is now known as kgriffs | 14:26 | |
*** cpallares has joined #openstack-zaqar | 14:29 | |
kgriffs | flaper87: ping | 14:35 |
flaper87 | kgriffs: pong | 14:52 |
*** reed has joined #openstack-zaqar | 14:56 | |
kgriffs | flaper87: hey | 15:03 |
kgriffs | a couple things | 15:03 |
kgriffs | first, I discovered that redis-py does something interesting and wanted to share | 15:03 |
kgriffs | after a connection error, it first does one retry on it's own before re-raising the error | 15:03 |
kgriffs | secondly, it will rest the connection when that happens, and there is some logic in the sentinel code to go find the new master in the case of a failover | 15:04 |
kgriffs | BUT | 15:04 |
kgriffs | if you tell sentinel to wait for a few seconds, say, before deciding a master is indeed "down", redis-py will raise MasterNotFound which is a subclass of ConnectionError | 15:05 |
kgriffs | so the decorator in the driver for retrying those is still necessary | 15:05 |
kgriffs | eventually it will succeed after a few retries once the sentinel elects the new master | 15:05 |
kgriffs | so, I think we are good there | 15:05 |
kgriffs | the one thing I do need to add though before submitting the updated patch | 15:06 |
kgriffs | is to specify a list of sentinels in the connection URI, vs. just one | 15:06 |
kgriffs | you are supposed to run >1 sentinel for HA | 15:06 |
kgriffs | does all that make sense? | 15:06 |
* kgriffs has been reading lots of source code lately | 15:06 | |
*** alcabrera|afk is now known as alcabrera | 15:21 | |
flaper87 | kgriffs: sorry, got distracted | 15:26 |
flaper87 | kgriffs: it does make sense | 15:26 |
kgriffs | ok | 15:26 |
flaper87 | glad to know redis-py does a bit of this already | 15:26 |
kgriffs | second question | 15:26 |
* flaper87 reads | 15:26 | |
* flaper87 won't get distracted | 15:27 | |
flaper87 | oh look, a fly | 15:27 |
kgriffs | which do you think looks better | 15:27 |
kgriffs | redis://s1.example.com,s2.example.com,s3.example.com?master=dumbledore | 15:27 |
kgriffs | redis://s1.example.com,s2.example.com,s3.example.com?sentinel=dumbledore | 15:27 |
kgriffs | context: | 15:28 |
kgriffs | http://redis.io/topics/sentinel | 15:28 |
kgriffs | (look for the "Configuring Sentinel" section) | 15:28 |
kgriffs | and | 15:28 |
kgriffs | https://github.com/andymccurdy/redis-py/blob/master/redis/sentinel.py#L145 | 15:28 |
flaper87 | mmh, what does redis-cli outputs as help for the `sentinel` command ? | 15:29 |
flaper87 | what about sentinel_master=dumbledore ? | 15:29 |
flaper87 | longer but clearer | 15:29 |
flaper87 | it makes it clear we are talking about the master node the sentinel needs to monitor | 15:30 |
*** malini has quit IRC | 15:30 | |
flaper87 | or `sm=dumbledore` | 15:30 |
flaper87 | and RTFM | 15:30 |
flaper87 | :P | 15:30 |
*** malini|afk has joined #openstack-zaqar | 15:30 | |
flaper87 | we can document it in the redis URI config option | 15:30 |
*** malini|afk is now known as malini_znc | 15:30 | |
flaper87 | bikeshedding in 3... 2... 1... GOOOOOOOOOOOOOOOOOOOOOO | 15:30 |
kgriffs | lol | 15:32 |
kgriffs | my bike shed burned down a few years ago along with my parent's house so I don't do that anymore. | 15:32 |
flaper87 | oh crap... :S | 15:33 |
kgriffs | jokes aside, I think sentinel_master is OK | 15:33 |
flaper87 | cool | 15:33 |
kgriffs | flaper87: yeah, well, they ended up moving into town out of the snow so it was probably a blessing in disguise. :) | 15:33 |
kgriffs | and actually the bike shed didn't burn down - it was up on the hill behind the house. | 15:34 |
flaper87 | kgriffs: youuuuuuuuuu liar!!!! :P | 15:34 |
* kgriffs repents | 15:34 | |
* kgriffs gives flaper87 gummy bears as penance | 15:36 | |
flaper87 | oh look, gummy bears | 15:36 |
* flaper87 eats them | 15:36 | |
*** echevemaster has joined #openstack-zaqar | 15:42 | |
njirap | hi everyone i need help with git review -s...i believe its ssh issues..the error is http://paste.openstack.org/show/119412/ | 15:43 |
njirap | and then the video with the useful tips on gerrit is private i cant view it please https://www.youtube.com/watch?v=mT2yC6ll5Qk&feature=youtu.be | 15:45 |
*** prashanthr_ has joined #openstack-zaqar | 15:51 | |
flaper87 | kgriffs: btw, I replied to your comments on the marker index patch | 15:52 |
flaper87 | njirap: mmh, that link doesn't seem to work | 15:53 |
flaper87 | I think paste.openstack.org is down | 15:53 |
kgriffs | flaper87: kk | 15:53 |
flaper87 | mind finding another paste service? | 15:53 |
flaper87 | like pastebin | 15:53 |
flaper87 | :D | 15:53 |
kgriffs | njirap: you can use github gists | 15:53 |
flaper87 | or that ^ | 15:53 |
njirap | http://paste.openstack.org/show/119412/ | 15:53 |
kgriffs | njirap: I'm getting a server error on that as well | 15:54 |
kgriffs | njirap: try this https://gist.github.com/ | 15:54 |
njirap | flaper87....I've hacked the issue by clearing my known_hosts filw | 15:56 |
flaper87 | njirap: did you add your key here? https://review.openstack.org/#/settings/ssh-keys | 15:56 |
njirap | file | 15:56 |
flaper87 | ok | 15:56 |
njirap | but the youtube video is un-view-able | 15:57 |
njirap | kgriffs..the keystone error for yesterday it was the /opt/stack one that was to be deleted not the dist_packages one....just for future reference :) | 16:01 |
openstackgerrit | Prashanth Raghu proposed a change to openstack/zaqar: Add support for redis-sentinel https://review.openstack.org/121474 | 16:05 |
kgriffs | njirap: ah, gtk | 16:07 |
openstackgerrit | Kurt Griffiths proposed a change to openstack/zaqar: Fix the typo in the description of the write concern error https://review.openstack.org/126610 | 16:13 |
*** njirap has quit IRC | 16:18 | |
*** exploreshaifali has quit IRC | 16:22 | |
*** echevemaster has quit IRC | 16:31 | |
*** sgotliv has quit IRC | 16:36 | |
kgriffs | flaper87: just thought of something | 16:51 |
flaper87 | oh god | 16:51 |
kgriffs | "sentinel_master" could be interpreted to mean" the sentinel's master, not the redis master that is being managed by the sentinel | 16:51 |
flaper87 | :P | 16:51 |
kgriffs | yeah, watch out when I think of things. ;) | 16:51 |
kgriffs | but I think that shouldn't be a problem | 16:52 |
flaper87 | mmh, then I'd lead to just master | 16:52 |
*** sgotliv has joined #openstack-zaqar | 16:52 | |
flaper87 | like redis-py does | 16:52 |
kgriffs | i mean, it may be a problem for people not super familiar with redis | 16:52 |
kgriffs | but whatever | 16:52 |
kgriffs | master may be a little cleaner | 16:52 |
flaper87 | ok, as long as we document it thoroughly in the URI help text, I think we're fine | 16:54 |
kgriffs | kk | 16:54 |
*** alcabrera is now known as alcabrera|afk | 16:55 | |
*** exploreshaifali has joined #openstack-zaqar | 17:04 | |
*** sgotliv has quit IRC | 17:21 | |
*** prashanthr_ has quit IRC | 17:41 | |
*** echevemaster has joined #openstack-zaqar | 17:47 | |
*** cpallares has quit IRC | 17:49 | |
*** vkmc has joined #openstack-zaqar | 17:58 | |
*** alcabrera|afk is now known as alcabrera | 17:59 | |
* vkmc lurks | 18:01 | |
*** amitgandhinz has quit IRC | 18:06 | |
*** sgotliv has joined #openstack-zaqar | 18:14 | |
*** sphoorti has joined #openstack-zaqar | 18:32 | |
*** vkmc_ has joined #openstack-zaqar | 18:33 | |
*** vkmc has quit IRC | 18:33 | |
*** vkmc_ is now known as vkmc | 18:33 | |
*** amitgandhinz has joined #openstack-zaqar | 18:43 | |
*** sphoorti has quit IRC | 18:44 | |
*** ametts has quit IRC | 18:56 | |
vkmc | ok, gotta go | 19:01 |
vkmc | babai | 19:01 |
vkmc | o/ | 19:01 |
*** vkmc has quit IRC | 19:01 | |
*** jchai is now known as jchai_afk | 19:05 | |
*** jchai_afk is now known as jchai | 19:09 | |
*** kgriffs is now known as kgriffs|afk | 19:11 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-zaqarclient: Updated from global requirements https://review.openstack.org/126685 | 19:17 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/zaqar: Updated from global requirements https://review.openstack.org/126688 | 19:18 |
*** jchai has quit IRC | 19:34 | |
*** bradjones has quit IRC | 19:44 | |
*** bradjones has joined #openstack-zaqar | 19:46 | |
flaper87 | kgriffs|afk: ping, I saw Prashanth posted a new patch. Any chance we can review that today? | 20:08 |
flaper87 | kgriffs|afk: I'm confused, I thought you were going to update the patch | 20:08 |
openstackgerrit | A change was merged to openstack/python-zaqarclient: Updated from global requirements https://review.openstack.org/126685 | 20:11 |
openstackgerrit | A change was merged to openstack/zaqar: Fix the typo in the description of the write concern error https://review.openstack.org/126610 | 20:40 |
*** bradjones has quit IRC | 20:52 | |
*** bradjones has joined #openstack-zaqar | 20:55 | |
exploreshaifali | hi flaper87 | 20:59 |
exploreshaifali | flaper87, I have looked at mongo driver file | 21:00 |
exploreshaifali | flaper87 ping :P | 21:01 |
*** sriram has quit IRC | 21:13 | |
*** alcabrera is now known as alcabrera|afk | 21:27 | |
flaper87 | exploreshaifali: pong? | 21:44 |
flaper87 | :D | 21:44 |
exploreshaifali | hi flaper | 21:45 |
exploreshaifali | *flaper87 | 21:45 |
exploreshaifali | I have gone through mongo driver file | 21:46 |
exploreshaifali | and got a sense of what need to do in the project | 21:46 |
flaper87 | exploreshaifali: awesome | 21:46 |
exploreshaifali | My task is something like putting the common code(like importing i18n._ and def connection() method) in a separate file and putting specific code(like import storage is only for storage plane and import controllers is only for control plane in different files and importing common code in both files | 21:46 |
*** mpanetta has quit IRC | 21:47 | |
flaper87 | kinda, that will likely happen but you'll need to do more than just that | 21:47 |
exploreshaifali | likeI have to split each file into 3 parts | 21:47 |
flaper87 | For example, both the Control and the Data plane are using the same config option for the store config | 21:48 |
exploreshaifali | yes, I will be happy by doing all that :P | 21:48 |
flaper87 | we need to change that and add a config section for each plane | 21:48 |
flaper87 | among other things like having more detailed tests | 21:48 |
flaper87 | and make sure we don't have cycles in the dependencies between those two | 21:49 |
exploreshaifali | ok, probably u are saying to have diff config section for both | 21:49 |
exploreshaifali | while I thought, that since it is common in both, it will be written once and get referred or imported by both | 21:49 |
exploreshaifali | as configs are same for both | 21:50 |
flaper87 | nope, that's exactly one of the things we need to change | 21:51 |
flaper87 | exploreshaifali: are you going to be around tomorrow my morning? | 21:51 |
flaper87 | I'd like to explain this a bit better to you | 21:51 |
exploreshaifali | ya sure | 21:51 |
exploreshaifali | I was about to write a e-mail to u | 21:52 |
flaper87 | ok, then lets make sure we meet here tomorrow and I'll walk you through why we need to split these to planes | 21:52 |
flaper87 | emails are good but lets try to discuss things here as much as possible so that others can chime in as well | 21:52 |
exploreshaifali | okay, what will be the timings in UTC? | 21:52 |
exploreshaifali | ahh.... increasing my competition :P | 21:53 |
exploreshaifali | no worries, fine :) | 21:53 |
*** malini1 has quit IRC | 21:53 | |
flaper87 | ah crap, I forgot I've something to do tomorrow morning. what about 12 UTC ? | 21:53 |
flaper87 | is that time ok for you? | 21:54 |
flaper87 | nah, don't feel like this is a competition, there's place for everyone and enough things to do | 21:54 |
exploreshaifali | Ook about competition | 21:55 |
exploreshaifali | and also about timings | 21:55 |
flaper87 | ok | 21:55 |
flaper87 | exploreshaifali: please, do keep digging. The more questions you ask, the clearer it will be for you :) | 21:55 |
exploreshaifali | flaper87, sure :) | 21:56 |
exploreshaifali | Thanks!! | 21:56 |
flaper87 | exploreshaifali: thank you ;) | 21:58 |
exploreshaifali | flaper87, thanking me for what? | 21:59 |
flaper87 | exploreshaifali: for your time, interest and perseverance. I appreciate you willing to work on this and I thank you for that. I look forward to see you around long enough to do way more. | 22:00 |
exploreshaifali | yes! I am enjoying it alot, talking and asking for help and getting work done... | 22:01 |
exploreshaifali | superb!! | 22:01 |
*** amitgandhinz has quit IRC | 22:26 | |
*** flaper87 is now known as flaper87|afk | 22:39 | |
*** X019 has quit IRC | 22:44 | |
openstackgerrit | Kurt Griffiths proposed a change to openstack/zaqar: Add support for redis-sentinel https://review.openstack.org/121474 | 23:31 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!