*** bradjones has quit IRC | 00:22 | |
*** bradjones has joined #openstack-zaqar | 00:24 | |
*** X019 has joined #openstack-zaqar | 00:46 | |
*** jeffrey4l has joined #openstack-zaqar | 01:54 | |
*** jeffrey4l has quit IRC | 01:59 | |
*** jeffrey4l has joined #openstack-zaqar | 02:11 | |
*** X019 has quit IRC | 02:25 | |
*** reed has quit IRC | 02:46 | |
*** reed has joined #openstack-zaqar | 02:47 | |
*** prashanthr_ has joined #openstack-zaqar | 03:31 | |
*** jeffrey4l has quit IRC | 03:59 | |
*** jeffrey4l has joined #openstack-zaqar | 04:19 | |
*** sgotliv has quit IRC | 05:03 | |
*** sgotliv has joined #openstack-zaqar | 05:10 | |
*** echevemaster has quit IRC | 06:01 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/zaqar: Imported Translations from Transifex https://review.openstack.org/126806 | 06:05 |
---|---|---|
*** reed has quit IRC | 06:07 | |
*** jeffrey4l has quit IRC | 06:54 | |
*** jeffrey4l has joined #openstack-zaqar | 07:07 | |
openstackgerrit | Jeffrey Zhang proposed a change to openstack/zaqar: Fix no links property in pool list response https://review.openstack.org/123462 | 08:08 |
*** prashanthr_ has quit IRC | 08:18 | |
*** bradjones has quit IRC | 08:22 | |
*** bradjones has joined #openstack-zaqar | 08:23 | |
openstackgerrit | Jeffrey Zhang proposed a change to openstack/zaqar: Fix no links property in flavor list response https://review.openstack.org/123626 | 08:50 |
exploreshaifali | hello, I have a question, in file https://github.com/openstack/zaqar/blob/master/zaqar/queues/storage/mongodb/driver.py | 09:13 |
exploreshaifali | someone around? | 09:14 |
*** jeffrey4l has quit IRC | 09:24 | |
*** prashanthr_ has joined #openstack-zaqar | 09:24 | |
*** jeffrey4l has joined #openstack-zaqar | 09:36 | |
openstackgerrit | Jeffrey Zhang proposed a change to openstack/zaqar: Fix the param name typo https://review.openstack.org/126850 | 09:43 |
*** jeffrey4l_ has joined #openstack-zaqar | 09:43 | |
*** jeffrey4l has quit IRC | 09:47 | |
*** jeffrey4l_ has quit IRC | 10:01 | |
*** njirap has joined #openstack-zaqar | 10:12 | |
*** jeffrey4l_ has joined #openstack-zaqar | 10:18 | |
*** jeffrey4l_ has quit IRC | 10:54 | |
*** jeffrey4l_ has joined #openstack-zaqar | 10:54 | |
*** flaper87|afk is now known as flaper87 | 10:55 | |
flaper87 | exploreshaifali: hey :) | 11:02 |
flaper87 | shoot | 11:02 |
exploreshaifali | faper87, hi :) | 11:03 |
exploreshaifali | flaper87, in file https://github.com/openstack/zaqar/blob/master/zaqar/queues/storage/mongodb/driver.py | 11:03 |
exploreshaifali | at line #195 in def database, it returns **self.connection[name]** but there is no connection attribute inside Class or its parent class. | 11:03 |
exploreshaifali | inside ControlDriver class | 11:05 |
exploreshaifali | or its parent class | 11:05 |
*** openstack has joined #openstack-zaqar | 14:13 | |
*** openstackstatus has joined #openstack-zaqar | 14:15 | |
*** ChanServ sets mode: +v openstackstatus | 14:15 | |
flaper87 | kgriffs: tiny nit in the error message, then +2. Promissed | 14:16 |
kgriffs | kk | 14:16 |
*** jeffrey4l_ has joined #openstack-zaqar | 14:21 | |
flaper87 | jeffrey4l_: hey, there? | 14:30 |
jeffrey4l_ | flaper87, yep | 14:30 |
flaper87 | jeffrey4l_: did you add tests for links ? https://review.openstack.org/#/c/123626/2 | 14:30 |
*** ametts has joined #openstack-zaqar | 14:30 | |
jeffrey4l_ | flaper87, I am trying to do that. | 14:30 |
jeffrey4l_ | I forget to add the test on the latest patch. | 14:31 |
flaper87 | jeffrey4l_: kk, thanks. Any chance you can do that today? | 14:31 |
jeffrey4l_ | It will be commit in few minute. | 14:31 |
kgriffs | flaper87: re that error message, how about this (at the top of the pad) | 14:32 |
kgriffs | https://etherpad.openstack.org/p/zaqar-scratch | 14:32 |
flaper87 | kgriffs: +2 | 14:33 |
kgriffs | kk, here it comes | 14:33 |
flaper87 | sorry for nitpicking on that but I've seen many people frustrated with error messages | 14:33 |
flaper87 | and we definitely don't want zaqar to be the target for complains on that | 14:33 |
* kgriffs really needs to write a sublime macro for splitting long strings | 14:34 | |
jeffrey4l_ | flaper87, I will submit it soon. | 14:34 |
mpanetta | hey, that's my job :P (complaining) | 14:34 |
kgriffs | flaper87: please, nitpick away! Let's make Zaqar have the best error messages of all the projects! | 14:34 |
mpanetta | Mmmm good error messages | 14:34 |
mpanetta | Us devops folks like that | 14:35 |
kgriffs | I want people to be all ready for a crappy installation experience, and then be like "WAH? that's all I have to do?" | 14:35 |
kgriffs | and then when something goes wrong, be all ready to tear my hair out over unhelpful errors | 14:35 |
mpanetta | kgriffs: Did zaqar ever have a crappy installation experience? | 14:35 |
kgriffs | and then be like "WAH? that actually... makes sense." | 14:36 |
kgriffs | mpanetta: no, we tried hard to make it easy from the beginning. :D | 14:36 |
*** reed has joined #openstack-zaqar | 14:36 | |
mpanetta | That is what I thought :P | 14:36 |
kgriffs | mpanetta: I mean, people who are used to installing some other projects that are harder | 14:36 |
mpanetta | Like devstack? :P | 14:37 |
* kgriffs declines to comment | 14:37 | |
mpanetta | haha | 14:37 |
flaper87 | LOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOL | 14:39 |
*** reed has quit IRC | 14:39 | |
openstackgerrit | Kurt Griffiths proposed a change to openstack/zaqar: Add support for redis-sentinel https://review.openstack.org/121474 | 14:39 |
*** reed has joined #openstack-zaqar | 14:39 | |
*** njirap has quit IRC | 14:39 | |
kgriffs | flaper87: speaking of error messages we still need to add tracing ID to all of ours | 14:40 |
flaper87 | kgriffs: +2 | 14:40 |
flaper87 | that's a good task for an OPW mentee | 14:40 |
flaper87 | what do you think? | 14:40 |
kgriffs | flaper87: now that you are PTL it's your job to keep track of all the things we have to do. :D | 14:40 |
flaper87 | it's not just adding codes but also having a way to track them | 14:40 |
* flaper87 feels betrayed | 14:41 | |
flaper87 | :P | 14:41 |
kgriffs | flaper87: yeah, that could be a good job for an intern | 14:41 |
kgriffs | maybe as a first task so they get to survey all the code | 14:41 |
kgriffs | help them get oriented | 14:41 |
*** X019 has joined #openstack-zaqar | 14:44 | |
flaper87 | LOL | 14:45 |
flaper87 | somehow I read: "Help *me* get oriented" | 14:45 |
flaper87 | brb | 14:49 |
*** flaper87 is now known as flaper87|afk | 14:49 | |
*** njirap has joined #openstack-zaqar | 14:53 | |
njirap | kgriffs ping | 15:02 |
kgriffs | o/ | 15:02 |
njirap | in the README for running functional tests am supposed to "Change `$ZAQAR_TESTS_CONFIGS_DIR/functional-tests.conf` and | 15:03 |
njirap | set `run_tests` to True." | 15:03 |
njirap | wheres the ZAQAR_TESTS_CONFIGS_DIR/functional-tests.conf | 15:03 |
openstackgerrit | Jeffrey Zhang proposed a change to openstack/zaqar: Fix no links property in flavor list response https://review.openstack.org/123626 | 15:03 |
*** jchai has joined #openstack-zaqar | 15:07 | |
*** alcabrera|afk is now known as alcabrera | 15:29 | |
*** prashanthr_ has joined #openstack-zaqar | 15:33 | |
kgriffs | sorry - had to run to a meeting | 15:38 |
kgriffs | njirap: the functional tests should run by default, so you don't have to change anything | 15:39 |
njirap | kgriffs: yeap they've run actually | 15:40 |
kgriffs | kk | 15:41 |
*** flaper87|afk is now known as flaper87 | 15:51 | |
*** alcabrera is now known as alcabrera|afk | 15:52 | |
openstackgerrit | Jeffrey Zhang proposed a change to openstack/zaqar: Fix no links property in pool list response https://review.openstack.org/123462 | 15:53 |
jeffrey4l_ | flaper87, the link property in flavor and pool list response are submitted. unittest test is added. Pls review it when u r free. https://review.openstack.org/123626 https://review.openstack.org/123462 | 15:54 |
flaper87 | jeffrey4l_: thanks a lot | 15:55 |
flaper87 | will do | 15:55 |
flaper87 | kgriffs: +2, I'm good with you +2'ing it | 15:55 |
*** jchai is now known as jchai_afk | 15:55 | |
flaper87 | unless malini can review the patch now :P | 15:56 |
kgriffs | would be good to have someone at least do a +1 sanity check | 15:56 |
kgriffs | IMO | 15:56 |
malini | which patch needs sanity check? | 15:56 |
flaper87 | malini: https://review.openstack.org/#/c/121474/7 | 15:57 |
*** jchai_afk is now known as jchai | 15:57 | |
flaper87 | kgriffs: re https://review.openstack.org/#/c/126270/1/zaqar/queues/storage/mongodb/messages.py,cm | 15:58 |
flaper87 | I used many concurrent p_q | 15:59 |
kgriffs | oic, just wasn't clear from the paste | 15:59 |
flaper87 | In my comment I filtered just /my_queue/ to show how markers are groupped | 15:59 |
flaper87 | grouped | 15:59 |
kgriffs | anyway, like I said, I think it will be OK | 15:59 |
flaper87 | yeah, TBH, I haven't found a good tool for chunk analysis | 15:59 |
flaper87 | I've been using queries to get that info | 15:59 |
flaper87 | and MMS is just monitoring | 15:59 |
kgriffs | someone should create an open-source MMS thing. :D | 16:00 |
kgriffs | and then we could add things like chunk analysis | 16:00 |
kgriffs | heatmaps | 16:00 |
kgriffs | etc. | 16:00 |
*** prashanthr_ has quit IRC | 16:04 | |
*** jeffrey4l_ has quit IRC | 16:05 | |
*** expshaifali|afk is now known as exploreshaifali | 16:07 | |
*** prashanthr_ has joined #openstack-zaqar | 16:08 | |
kgriffs | malini: thanks for the review! | 16:08 |
malini | yw :) | 16:09 |
flaper87 | malini: https://review.openstack.org/#/c/126270 I'll thank you too | 16:11 |
flaper87 | :P | 16:11 |
openstackgerrit | Kurt Griffiths proposed a change to openstack/zaqar: Reduce duration of some long-running tests https://review.openstack.org/126947 | 16:12 |
malini | nobody gives out pop-tarts these days :-( | 16:16 |
*** jchai is now known as jchai_afk | 16:17 | |
*** jchai_afk is now known as jchai | 16:19 | |
* flaper87 gives malini a truck full of pop-tarts | 16:22 | |
* malini starts chomping | 16:22 | |
malini | yum yum | 16:22 |
flaper87 | malini: kgriffs proposed/juno backports https://review.openstack.org/#/q/status:open+project:openstack/zaqar+branch:proposed/juno,n,z | 16:23 |
flaper87 | no hurries but it would be cool to have them merged by tomorrow | 16:23 |
kgriffs | ok | 16:23 |
kgriffs | BTW, were you going to try and get some of those Jeffrey Zhang patches as well once they land? | 16:24 |
* kgriffs remembers he is supposed to review those | 16:24 | |
flaper87 | kgriffs: yup, I'd love to backport them too | 16:25 |
kgriffs | https://etherpad.openstack.org/p/zaqar-smoke-testing | 16:28 |
kgriffs | flaper87: ^^^ | 16:28 |
openstackgerrit | A change was merged to openstack/zaqar: Add support for redis-sentinel https://review.openstack.org/121474 | 16:31 |
openstackgerrit | A change was merged to openstack/zaqar: Move marker field to the first position (index) https://review.openstack.org/126270 | 16:47 |
*** alcabrera|afk is now known as alcabrera | 16:51 | |
*** njirap has quit IRC | 16:59 | |
*** prashanthr_ has quit IRC | 17:04 | |
*** malini1 has joined #openstack-zaqar | 17:28 | |
*** malini has quit IRC | 17:30 | |
*** sriram has quit IRC | 17:32 | |
*** kgriffs is now known as kgriffs|afk | 17:46 | |
*** reed has quit IRC | 17:50 | |
*** anna__ has joined #openstack-zaqar | 17:59 | |
*** X019 has quit IRC | 18:01 | |
*** amitgandhinz has joined #openstack-zaqar | 18:04 | |
*** anna__ is now known as X019_ | 18:05 | |
*** echevemaster has joined #openstack-zaqar | 18:06 | |
*** shaifali has joined #openstack-zaqar | 18:19 | |
*** kgriffs|afk is now known as kgriffs | 18:35 | |
*** kgriffs is now known as kgriffs|afk | 18:45 | |
*** amitgandhinz has quit IRC | 19:07 | |
*** kgriffs|afk is now known as kgriffs | 19:29 | |
*** malini1 has quit IRC | 19:37 | |
*** amitgandhinz has joined #openstack-zaqar | 20:15 | |
*** mpanetta has quit IRC | 21:01 | |
*** earnThis has joined #openstack-zaqar | 21:06 | |
*** sgotliv has quit IRC | 21:11 | |
*** alcabrera is now known as alcabrera|afk | 22:02 | |
*** flaper87 is now known as flaper87|afk | 22:03 | |
openstackgerrit | Abhishek Chanda proposed a change to openstack/zaqar: Remove all traces of nose https://review.openstack.org/127042 | 22:05 |
*** earnThis has quit IRC | 22:05 | |
*** echevemaster has quit IRC | 22:13 | |
*** flwang has quit IRC | 22:23 | |
*** jchai has quit IRC | 22:25 | |
*** amitgandhinz has quit IRC | 22:33 | |
*** flwang has joined #openstack-zaqar | 22:36 | |
*** kgriffs is now known as kgriffs|afk | 22:39 | |
*** jeffrey4l_ has joined #openstack-zaqar | 22:50 | |
*** jeffrey4l_ is now known as jeffrey4l | 22:50 | |
*** kgriffs|afk is now known as kgriffs | 22:58 | |
*** kgriffs is now known as kgriffs|afk | 23:08 | |
*** shaifali has quit IRC | 23:19 | |
*** jeffrey4l has quit IRC | 23:56 | |
*** kgriffs|afk is now known as kgriffs | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!