*** jeffrey4l_ has quit IRC | 00:49 | |
*** jeffrey4l_ has joined #openstack-zaqar | 01:38 | |
*** jeffrey4l_ has quit IRC | 01:49 | |
*** jeffrey4l_ has joined #openstack-zaqar | 02:01 | |
*** openstackgerrit has quit IRC | 02:58 | |
*** jeffrey4l_ has quit IRC | 03:49 | |
*** jeffrey4l_ has joined #openstack-zaqar | 04:06 | |
*** echevemaster has quit IRC | 04:14 | |
*** jeffrey4l_ has quit IRC | 04:22 | |
*** jeffrey4l_ has joined #openstack-zaqar | 04:35 | |
*** sgotliv has joined #openstack-zaqar | 05:45 | |
*** flaper87|afk is now known as flaper87 | 06:46 | |
*** reed has joined #openstack-zaqar | 06:50 | |
jeffrey4l_ | flaper87, Good morning~ | 07:11 |
---|---|---|
flaper87 | jeffrey4l_: good morning/afternoon, Sir! | 07:12 |
jeffrey4l_ | flaper87, is there any difference between v1 and v1.1 in list queue? | 07:12 |
flaper87 | yes | 07:12 |
flaper87 | v1.1 did return 204. We decided to change that behavior for v1.1 | 07:12 |
flaper87 | erm, sorry. v1 returns 204, that is. | 07:12 |
jeffrey4l_ | yes. | 07:13 |
jeffrey4l_ | I just notice that. | 07:13 |
jeffrey4l_ | My patch about the link pro in list flavor/queue change both v1 and v1.1 | 07:14 |
flaper87 | jeffrey4l_: that's fine. We were discussing that yday. I think your patch is fine. We need to fix v1 | 07:15 |
flaper87 | Pools shouldn't have been released in v1 | 07:15 |
flaper87 | anyway, I'm glad you fixed that | 07:15 |
jeffrey4l_ | flaper87, I am a little confused by the wiki page which is a little out of date. | 07:16 |
flaper87 | jeffrey4l_: the v1.1 one? | 07:16 |
flaper87 | please, if you spot something, let us know | 07:16 |
jeffrey4l_ | You means that the wiki page is the latest version? | 07:18 |
flaper87 | jeffrey4l_: it should contain the spec of how we expect the API to be | 07:19 |
flaper87 | if there're mismatches we need to address them asap :P | 07:19 |
flaper87 | or at least discuss them | 07:19 |
jeffrey4l_ | check these two link https://git.openstack.org/cgit/openstack/zaqar/tree/zaqar/queues/transport/wsgi/v1_0/messages.py#n107 https://wiki.openstack.org/wiki/Zaqar/specs/api/v1#List_Messages | 07:19 |
flaper87 | jeffrey4l_: ah wait, forget about v1, we just care about v1.1 now. | 07:20 |
jeffrey4l_ | based on the wiki page, v1 list messages should return 204 when the message is empty. | 07:20 |
flaper87 | as in, we're not going to make breaking changes on v1 unless there're really aweful bugs (like the pools one) | 07:20 |
jeffrey4l_ | OK. | 07:21 |
jeffrey4l_ | Ah, it seems that I make a mistake. The one mentioned above is right. I missed some lines. | 07:23 |
*** sgotliv has quit IRC | 07:24 | |
jeffrey4l_ | flaper87, Check this http://paste.openstack.org/show/120080/ . About "Capture the stdout and stderr based on environment" https://review.openstack.org/#/c/124273/ . I blocked when using ipdb.set_trace() | 07:32 |
flaper87 | jeffrey4l_: yeah,I know what happens. As I mentioned in the review. I'm fine with the patch, I guess I haven't been beaten by that because I just use `nosetests` for debug | 07:34 |
jeffrey4l_ | flaper87, I using the nosetests too(check the comments in the paste link). I suppose that we may using difference version of ipdb/ipython/nose? | 07:36 |
flaper87 | jeffrey4l_: mmh, that's weird | 07:38 |
flaper87 | jeffrey4l_: can you try with just *pdb* ? | 07:38 |
flaper87 | instead of ipdb | 07:38 |
jeffrey4l_ | flaper87, Yes. I tried. pdb works. | 07:38 |
flaper87 | oh ok, so, it's something about ipdb | 07:39 |
flaper87 | interesting | 07:39 |
jeffrey4l_ | What's the version of ipdb/ipython are u using? | 07:39 |
flaper87 | mmh, right now I'm just using pdb | 07:40 |
*** sgotliv has joined #openstack-zaqar | 07:40 | |
jeffrey4l_ | Found it. it is caused by ipython | 07:43 |
jeffrey4l_ | /home/jeffrey/.dotfiles/virtualenvs/zaqar/local/lib/python2.7/site-packages/IPython/utils/io.py | 07:43 |
jeffrey4l_ | stderr = IOStream(sys.stderr, fallback=devnull) | 07:43 |
jeffrey4l_ | flaper87, in that file. ipython wrap the sys.stderr which raised exception. | 07:43 |
flaper87 | mmh, bad ipython, bad! | 07:44 |
flaper87 | :D | 07:44 |
jeffrey4l_ | ;p | 07:44 |
*** sgotliv has quit IRC | 08:37 | |
*** sphoorti has joined #openstack-zaqar | 09:02 | |
sphoorti | flaper87: Hello :D | 09:02 |
*** exploreshaifali has joined #openstack-zaqar | 09:04 | |
*** exploreshaifali has left #openstack-zaqar | 09:05 | |
*** jeffrey4l_ is now known as jeffrey4l | 09:06 | |
*** exploreshaifali has joined #openstack-zaqar | 09:07 | |
*** exploreshaifali has quit IRC | 09:11 | |
*** exploreshaifali has joined #openstack-zaqar | 09:12 | |
*** exploreshaifali has quit IRC | 09:27 | |
*** jeffrey4l has quit IRC | 09:35 | |
*** jeffrey4l has joined #openstack-zaqar | 09:49 | |
*** sgotliv has joined #openstack-zaqar | 09:59 | |
*** sgotliv_ has joined #openstack-zaqar | 10:35 | |
*** sgotliv has quit IRC | 10:38 | |
*** X019 has quit IRC | 10:41 | |
*** X019 has joined #openstack-zaqar | 10:54 | |
*** malini has joined #openstack-zaqar | 11:00 | |
*** malini has quit IRC | 11:01 | |
*** malini has joined #openstack-zaqar | 11:01 | |
*** sphoorti has quit IRC | 11:33 | |
*** X019 has quit IRC | 11:41 | |
*** X019 has joined #openstack-zaqar | 11:44 | |
*** jeffrey4l has quit IRC | 12:08 | |
*** jchai has joined #openstack-zaqar | 13:00 | |
*** jeffrey4l has joined #openstack-zaqar | 13:02 | |
*** malini has quit IRC | 13:07 | |
*** sriram has joined #openstack-zaqar | 13:09 | |
*** amitgandhinz has joined #openstack-zaqar | 13:14 | |
*** mpanetta has joined #openstack-zaqar | 13:16 | |
*** mpanetta has quit IRC | 13:18 | |
*** mpanetta has joined #openstack-zaqar | 13:18 | |
*** mpanetta has quit IRC | 13:19 | |
*** mpanetta has joined #openstack-zaqar | 13:19 | |
*** amitgandhinz has quit IRC | 13:37 | |
*** malini has joined #openstack-zaqar | 13:47 | |
flaper87 | malini: kgriffs|afk thoughts? https://review.openstack.org/#/c/127518/ | 14:14 |
flaper87 | I think this one is rc2 worth it too | 14:14 |
* malini checking | 14:14 | |
*** openstackgerrit has joined #openstack-zaqar | 14:15 | |
malini | Can you also update https://wiki.openstack.org/wiki/Zaqar/specs/api/v1.1#Renew_Claim ? | 14:16 |
flaper87 | malini: yup, will do | 14:18 |
*** jchai has quit IRC | 14:33 | |
*** jchai has joined #openstack-zaqar | 14:34 | |
*** sgotliv_ has quit IRC | 14:39 | |
flaper87 | malini: I'll also wait for kgriffs|afk to review that patch before updating the wiki. Just to make sure he also agrees with the default ttl thing | 14:39 |
malini | sure | 14:40 |
malini | flaper87: https://review.openstack.org/#/c/127518/1/zaqar/queues/transport/wsgi/v1_0/claims.py | 14:40 |
flaper87 | malini: 'sup ? | 14:41 |
flaper87 | :P | 14:41 |
malini | should it be ('grace', int, 0) or ('grace', int, None) ? | 14:41 |
flaper87 | 0 so it's not a required param in the API and it does not fail in the metadata['ttl'] + metadata['grace'] sum in the claim controller | 14:42 |
malini | aah..ok | 14:42 |
*** kgriffs|afk is now known as kgriffs | 14:46 | |
*** jeffrey4l has quit IRC | 14:48 | |
kgriffs | flavio, re https://review.openstack.org/#/c/127518/ | 14:49 |
flaper87 | kgriffs: shoot | 14:51 |
kgriffs | I think there has been a misunderstanding about the purpose of the grace period. It applies to the message expiration, not the claim expiration. | 14:52 |
kgriffs | the idea is that once a claim expires, you want messages to outlive it by some "grace" period so another worker has a chance to claim the message before it self-destructs | 14:52 |
flaper87 | kgriffs: oh mmh, I thought I did that. | 14:54 |
flaper87 | aaaaaaaaah wait | 14:54 |
flaper87 | I applied it to everything | 14:54 |
flaper87 | claim AND message | 14:54 |
flaper87 | (facepalm) | 14:54 |
kgriffs | yeah | 14:54 |
kgriffs | :) | 14:54 |
flaper87 | damn, now I feel dumb | 14:54 |
flaper87 | good thing we have you, kgriffs | 14:54 |
flaper87 | :D | 14:54 |
kgriffs | it's OK. I feel dumb at least 10 times a day | 14:54 |
kgriffs | ;) | 14:54 |
flaper87 | kgriffs: does the rest of the patch look fine ? | 14:55 |
malini | and somebody +2s flaper87 10 times a day | 14:55 |
*** amitgandhinz has joined #openstack-zaqar | 14:56 | |
kgriffs | lol | 14:56 |
kgriffs | flaper87: other thing I noticed at first glance was that the redis driver claim controller also needs it's defaults changed from 60 seconds | 14:58 |
kgriffs | s/it's/its | 14:58 |
flaper87 | kgriffs: yeah, I was revisiting that now | 14:58 |
* kgriffs stupid english | 14:58 | |
*** jeffrey4l has joined #openstack-zaqar | 15:01 | |
openstackgerrit | Flavio Percoco proposed a change to openstack/zaqar: Fix ttl and grace story for claims updates https://review.openstack.org/127518 | 15:06 |
flaper87 | kgriffs: ^ | 15:06 |
kgriffs | kk, I'll take a look | 15:07 |
*** alcabrera|afk is now known as alcabrera | 15:20 | |
*** alcabrera is now known as alcabrera|afk | 15:21 | |
kgriffs | oh cool, this is going to be handy. http://redis.io/commands/slowlog | 15:45 |
kgriffs | </random> | 15:45 |
*** malini has left #openstack-zaqar | 15:48 | |
*** reed has quit IRC | 15:55 | |
*** jchai is now known as jchai_afk | 16:06 | |
*** alcabrera|afk is now known as alcabrera | 16:14 | |
*** jeffrey4l has quit IRC | 16:46 | |
*** sgotliv_ has joined #openstack-zaqar | 16:49 | |
*** sgotliv_ has quit IRC | 16:55 | |
*** sgotliv_ has joined #openstack-zaqar | 17:38 | |
*** exploreshaifali has joined #openstack-zaqar | 17:53 | |
*** jchai_afk is now known as jchai | 17:57 | |
*** kgriffs is now known as kgriffs|afk | 18:31 | |
exploreshaifali | flaper87, around? | 18:35 |
exploreshaifali | flaper87, ping | 18:39 |
*** openstackgerrit has quit IRC | 18:48 | |
*** jchai is now known as jchai_afk | 18:52 | |
*** openstackgerrit has joined #openstack-zaqar | 18:54 | |
exploreshaifali | flaper87, ting | 19:05 |
exploreshaifali | :D | 19:05 |
*** mpanetta has quit IRC | 19:24 | |
*** jchai_afk is now known as jchai | 19:32 | |
exploreshaifali | hi jchai | 19:34 |
jchai | exploreshaifali: hello | 19:34 |
exploreshaifali | jchai, are u a developer of zaqar, I have few questions relatead to it | 19:35 |
jchai | exploreshaifali: nope. I'd try kgriffs|afk, flaper87, alcabrera, sriram | 19:41 |
exploreshaifali | jchai, ok, Thanks! | 19:42 |
alcabrera | oh, hi all. | 19:42 |
alcabrera | jchai, exploreshaifali: o/ | 19:42 |
exploreshaifali | alcabrera, hi | 19:43 |
alcabrera | I'm an ex-developer of zaqar, but I may be able to help. :) | 19:44 |
exploreshaifali | I just want to know in code https://github.com/openstack/zaqar/tree/master/zaqar/queues/storage | 19:44 |
exploreshaifali | mongo/driver | 19:44 |
exploreshaifali | where what conf object represent | 19:45 |
exploreshaifali | conf is an object of oslo.config.ConfOPts | 19:45 |
exploreshaifali | right? | 19:45 |
alcabrera | exploreshaifali: yup! | 19:45 |
alcabrera | it's... loaded at some point to contain the values specified here: https://github.com/openstack/zaqar/blob/master/etc/zaqar.conf.sample | 19:45 |
exploreshaifali | alcabrera, sorry but I am unablt to connect how it works | 19:48 |
exploreshaifali | just a min | 19:48 |
exploreshaifali | alcabrera, see https://github.com/openstack/zaqar/blob/master/zaqar/queues/storage/base.py#L43 | 19:48 |
exploreshaifali | I am searching for class oslo.conf.ConfOpts | 19:49 |
exploreshaifali | so that I can understand what exactly conf holds | 19:50 |
alcabrera | ah | 19:50 |
alcabrera | oslo.config lives in a separate project, and the link to it is - | 19:50 |
alcabrera | https://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L1574 | 19:50 |
exploreshaifali | yes | 19:50 |
exploreshaifali | I have gone through it a bit | 19:51 |
exploreshaifali | alcabrera, probaly it is relatead to https://github.com/openstack/zaqar/blob/master/zaqar/queues/storage/mongodb/options.py | 19:51 |
alcabrera | ah, yes! :) | 19:51 |
exploreshaifali | but how? | 19:52 |
exploreshaifali | I mean as per my knowledge of Python says | 19:52 |
exploreshaifali | there should be oslo.conf.ConfOpts class | 19:53 |
exploreshaifali | alcabrera, ^ | 19:53 |
alcabrera | hmmm | 19:54 |
alcabrera | there is such a class, though. o.o | 19:54 |
alcabrera | oslo.config.ConfigOpts | 19:54 |
alcabrera | which is brought into scope by 'import oslo.config' | 19:54 |
alcabrera | errm | 19:54 |
alcabrera | which part is missing? :x | 19:54 |
exploreshaifali | alcabrera, yes | 19:56 |
exploreshaifali | correct, got it | 19:56 |
exploreshaifali | and one more question | 19:56 |
exploreshaifali | alcabrera, https://github.com/openstack/zaqar/blob/master/zaqar/queues/storage/mongodb/options.py | 19:57 |
exploreshaifali | above file also import oslo.config.conf | 19:57 |
exploreshaifali | this file specify configs for storage driver | 19:58 |
exploreshaifali | right? | 19:58 |
alcabrera | yup. :) | 19:58 |
exploreshaifali | this is for storage layer of zaqar | 19:58 |
exploreshaifali | ? | 19:58 |
alcabrera | exploreshaifali: yup. | 19:58 |
exploreshaifali | and storage layer have 2 parts | 19:59 |
exploreshaifali | data plane and control plane | 19:59 |
exploreshaifali | alcabrera, both planes are managed by this single file | 19:59 |
alcabrera | exploreshaifali: that's correct. data: DataDriver, control: ControlDriver | 20:00 |
exploreshaifali | at present, database configs for both planes are same as there is same databse for both | 20:01 |
exploreshaifali | alcabrera, okay, first things first | 20:01 |
exploreshaifali | I am trying to understand if I want to divide data plane and control plane | 20:02 |
exploreshaifali | in 2 separate parts | 20:02 |
exploreshaifali | wht do I need to do with config fils | 20:02 |
exploreshaifali | *files | 20:02 |
exploreshaifali | alcabrera, ^ | 20:02 |
alcabrera | I don't think I can help there | 20:02 |
alcabrera | It's been too long since I last looked at zaqar | 20:03 |
exploreshaifali | alcabrera, np | 20:03 |
alcabrera | good luck, exploreshaifali. :) | 20:03 |
exploreshaifali | Thanks alot | 20:03 |
exploreshaifali | alcabrera, I ll still keep catching u for my more questions :P | 20:04 |
alcabrera | hehe. :P | 20:09 |
*** jchai is now known as jchai_afk | 20:11 | |
*** jchai_afk is now known as jchai | 20:11 | |
*** sgotliv_ has quit IRC | 20:30 | |
*** jchai has quit IRC | 20:43 | |
*** alcabrera is now known as alcabrera|afk | 20:59 | |
*** sriram has quit IRC | 21:22 | |
*** amitgandhinz has quit IRC | 22:13 | |
*** ametts has quit IRC | 22:27 | |
*** AAzza has quit IRC | 22:29 | |
*** AAzza_afk has joined #openstack-zaqar | 22:32 | |
*** AAzza_afk is now known as AAzza | 22:32 | |
*** sgotliv_ has joined #openstack-zaqar | 22:38 | |
*** flaper87 is now known as flaper87|afk | 22:46 | |
*** echevemaster has joined #openstack-zaqar | 22:52 | |
*** openstackgerrit has quit IRC | 22:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!