| *** kgriffs is now known as kgriffs|afk | 00:08 | |
| *** openstackstatus has quit IRC | 00:23 | |
| *** openstackstatus has joined #openstack-zaqar | 00:24 | |
| *** ChanServ sets mode: +v openstackstatus | 00:24 | |
| *** kgriffs|afk is now known as kgriffs | 01:00 | |
| *** kgriffs is now known as kgriffs|afk | 01:09 | |
| *** jeffrey4l has joined #openstack-zaqar | 01:23 | |
| *** kgriffs|afk is now known as kgriffs | 02:00 | |
| *** kgriffs is now known as kgriffs|afk | 02:10 | |
| *** jeffrey4l_ has joined #openstack-zaqar | 02:15 | |
| *** jeffrey4l has quit IRC | 02:19 | |
| *** kgriffs|afk is now known as kgriffs | 02:39 | |
| *** openstackgerrit has quit IRC | 02:45 | |
| *** jeffrey4l_ has quit IRC | 03:25 | |
| *** alcabrera|afk is now known as alcabrera | 03:33 | |
| *** jeffrey4l_ has joined #openstack-zaqar | 03:42 | |
| *** X019_ has quit IRC | 03:57 | |
| *** X019 has joined #openstack-zaqar | 03:58 | |
| *** kgriffs is now known as kgriffs|afk | 04:19 | |
| *** alcabrera is now known as alcabrera|afk | 04:39 | |
| *** jeffrey4l_ has quit IRC | 06:29 | |
| *** jeffrey4l_ has joined #openstack-zaqar | 06:42 | |
| *** prashanthr_ has joined #openstack-zaqar | 06:51 | |
| *** flaper87|afk is now known as flaper87 | 06:58 | |
| jeffrey4l_ | flaper87, could check the comment make by kgriffs|afk about list all pools ( https://review.openstack.org/#/c/123462/5/zaqar/queues/storage/pooling.py ) , I also send a email to talk about this. http://lists.openstack.org/pipermail/openstack-dev/2014-October/048140.html | 07:58 |
|---|---|---|
| jeffrey4l_ | What's your opinion? | 07:58 |
| *** prashanthr_ has quit IRC | 08:00 | |
| flaper87 | jeffrey4l_: I think it'd make more sense to use limit=None instead of 0 | 08:02 |
| flaper87 | store's that doesn't support "list all" will have to implement some kind of iterator, I guess | 08:02 |
| flaper87 | but it'd be weird to have stores implementing limit=10 and not limit=None | 08:03 |
| jeffrey4l_ | flaper87, So lets change the limit=10 to limit=None in the storage? When call `.list()`, all the data is returned unless the limit is given. | 08:06 |
| flaper87 | jeffrey4l_: no no, there must be a default limit. | 08:06 |
| flaper87 | but passing `limit=None` means return everything | 08:06 |
| jeffrey4l_ | ok. | 08:07 |
| flaper87 | What kgriffs|afk was asking in the review is whether limit=0 is currently used by all drivers and whether it means the same to everyone | 08:07 |
| flaper87 | I think we need to document this | 08:08 |
| flaper87 | but don't do it in that patch, we'll have a spearate patch for this | 08:08 |
| flaper87 | jeffrey4l_: keep your patch focused on the pool links stuff | 08:08 |
| jeffrey4l_ | flaper87, got it. Could u check the my comment about the response status when the no queue. | 08:11 |
| flaper87 | jeffrey4l_: I did, I think. I replied that I think 200 is correct | 08:11 |
| jeffrey4l_ | flaper87, I make some new comment. ;p | 08:11 |
| flaper87 | ah ok :P | 08:12 |
| jeffrey4l_ | I have to say it is a big change to change. all( queue, flavor, message) list response is affected. Should we change it in separate patch? Or just change my patch( just pool list)? | 08:13 |
| flaper87 | jeffrey4l_: replied | 08:13 |
| jeffrey4l_ | flaper87, I have to say it is a big change. all( queue, flavor, message) list response is affected. Should we change it in separate patch? Or just change my patch( just pool list)? | 08:16 |
| flaper87 | jeffrey4l_: wait, why? | 08:16 |
| flaper87 | queue's are already like that | 08:16 |
| flaper87 | why do you need to change messages? | 08:16 |
| jeffrey4l_ | flaper87, I don't think the queue works like that. https://git.openstack.org/cgit/openstack/zaqar/tree/zaqar/queues/transport/wsgi/v1_1/queues.py#n149 | 08:19 |
| flaper87 | jeffrey4l_: ah you mean about the No Content thing | 08:20 |
| jeffrey4l_ | flaper87, yes. | 08:21 |
| jeffrey4l_ | flaper87, base on the comments in my patch, when there are no more queues/pools, it return 200 rather than 204. | 08:21 |
| jeffrey4l_ | queues return 204 now. | 08:21 |
| flaper87 | but messages return 200 | 08:22 |
| jeffrey4l_ | flaper87, yes. it is my mistake. I just check the message's code. It return 200 now. | 08:23 |
| flaper87 | then there's a bug in the queue's stuff | 08:23 |
| flaper87 | I'll fix it | 08:24 |
| jeffrey4l_ | I think so . | 08:24 |
| flaper87 | we need to get that fix in ASAP before RC2 | 08:24 |
| flaper87 | jeffrey4l_: you do pools and flavors, I'll fix queues | 08:24 |
| jeffrey4l_ | flaper87, kk | 08:24 |
| flaper87 | how does that sound? | 08:24 |
| flaper87 | and, THANKS for spotting that | 08:24 |
| jeffrey4l_ | my pleasure ;p | 08:25 |
| *** njirap has joined #openstack-zaqar | 08:52 | |
| *** jeffrey4l_ has quit IRC | 08:54 | |
| *** jeffrey4l_ has joined #openstack-zaqar | 08:54 | |
| jeffrey4l_ | flaper87, my pool and flavor patch is uploaded. | 09:15 |
| flaper87 | jeffrey4l_: awesome, so is my fix | 09:18 |
| flaper87 | jeffrey4l_: will review in a bit | 09:18 |
| jeffrey4l_ | no problem. | 09:18 |
| *** jeffrey4l__ has joined #openstack-zaqar | 09:34 | |
| *** jeffrey4l__ is now known as jeffrey4l | 09:35 | |
| *** jeffrey4l_ has quit IRC | 09:38 | |
| *** exploreshaifali is now known as xxx | 09:40 | |
| *** xxx has left #openstack-zaqar | 09:41 | |
| *** exploreshaifali has joined #openstack-zaqar | 09:43 | |
| *** aj9 has joined #openstack-zaqar | 09:47 | |
| jeffrey4l | flaper87, what will the `marker` param be like when the list(queue/flavor/queue) response is empty. 1) not show? 2) empty string `markder=` 3) the request value? | 09:55 |
| flaper87 | jeffrey4l: I was asking myself the same question | 09:55 |
| flaper87 | it should be an empty string, I guess | 09:55 |
| flaper87 | actually, I think it's an empty string | 09:56 |
| flaper87 | hopefully, it's not `marker=None` | 09:56 |
| flaper87 | otherwise we're screwed | 09:56 |
| flaper87 | :P | 09:56 |
| jeffrey4l | If it is a empty string, the next link indicate the first page actually. | 09:56 |
| flaper87 | which is ok because nothing was returned | 09:59 |
| flaper87 | jeffrey4l: sorry, gtg for a bit, brb | 09:59 |
| jeffrey4l | flaper87, so i prefer use the request value( if marker exist, i.e. not None), otherwise not show. ;p | 09:59 |
| *** AAzza has quit IRC | 09:59 | |
| *** AAzza_afk has joined #openstack-zaqar | 10:00 | |
| *** AAzza_afk is now known as AAzza | 10:01 | |
| *** AAzza has quit IRC | 10:05 | |
| *** AAzza_afk has joined #openstack-zaqar | 10:06 | |
| *** AAzza_afk is now known as AAzza | 10:06 | |
| *** X019 has quit IRC | 10:07 | |
| *** exploreshaifali has quit IRC | 10:07 | |
| *** X019 has joined #openstack-zaqar | 10:23 | |
| *** X019 has quit IRC | 10:39 | |
| *** malini has joined #openstack-zaqar | 11:29 | |
| *** malini has quit IRC | 11:29 | |
| *** malini has joined #openstack-zaqar | 11:30 | |
| *** jeffrey4l has quit IRC | 11:37 | |
| *** jeffrey4l has joined #openstack-zaqar | 11:44 | |
| *** sgotliv has joined #openstack-zaqar | 11:49 | |
| *** jeffrey4l_ has joined #openstack-zaqar | 11:50 | |
| *** jeffrey4l has quit IRC | 11:50 | |
| *** jeffrey4l_ is now known as jeffrey4l | 11:55 | |
| *** bradjones has quit IRC | 11:59 | |
| *** aj9 has quit IRC | 12:12 | |
| *** malini has quit IRC | 12:15 | |
| *** malini_znc is now known as malini|afk | 12:15 | |
| *** openstackgerrit has joined #openstack-zaqar | 12:23 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Add docs for `Client` instances https://review.openstack.org/127182 | 12:23 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Add reference docs for latest recommended client https://review.openstack.org/127215 | 12:23 |
| flaper87 | openstackgerrit: you asshole, where have you been? | 12:23 |
| *** bradjones has joined #openstack-zaqar | 12:26 | |
| *** mpanetta has joined #openstack-zaqar | 12:51 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:53 | |
| *** amitgandhinz has quit IRC | 12:53 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:54 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Extend some docstrings with useful information https://review.openstack.org/127227 | 13:01 |
| *** sriram has joined #openstack-zaqar | 13:04 | |
| *** jchai has joined #openstack-zaqar | 13:29 | |
| *** malini|afk is now known as malini_znc | 13:40 | |
| *** malini has joined #openstack-zaqar | 13:40 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Extend some docstrings with useful information https://review.openstack.org/127227 | 13:47 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Add docs for `Client` instances https://review.openstack.org/127182 | 13:47 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Add reference docs for latest recommended client https://review.openstack.org/127215 | 13:47 |
| *** malini_znc is now known as malini|afk | 13:47 | |
| flaper87 | malini: kgriffs|afk I've dedicated time to write docs for the client library. if you can dedicate a couple of minutes to review those patchs, it'd be really cool | 13:47 |
| flaper87 | https://review.openstack.org/#/q/status:open+project:openstack/python-zaqarclient+branch:master+topic:docs,n,z | 13:48 |
| flaper87 | kgriffs|afk: malini flwang ^ | 13:48 |
| malini | do you have anything else dedicated for it? | 13:48 |
| malini | like pop-tarts? | 13:48 |
| flaper87 | malini: I've pop-tarts, gummy bears, nutella and a full dinner paid in a very nice italian restaurant | 13:49 |
| flaper87 | note that I said "full dinner" | 13:49 |
| malini | hmmm..tht sounds like a good deal | 13:50 |
| malini | on it now | 13:50 |
| malini | flaper87: do you plan to address Jeffrey's comment https://review.openstack.org/#/c/127171/1/test-requirements.txt ? | 13:52 |
| flaper87 | malini: oh mmh, just noticed it. yup. I'll fix that right away | 13:52 |
| flaper87 | malini: done | 13:53 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Setup developer docs for zaqarclient https://review.openstack.org/127171 | 13:53 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Extend some docstrings with useful information https://review.openstack.org/127227 | 13:53 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Add docs for `Client` instances https://review.openstack.org/127182 | 13:53 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-zaqarclient: Add reference docs for latest recommended client https://review.openstack.org/127215 | 13:53 |
| *** jeffrey4l has quit IRC | 14:08 | |
| malini | we need to add a gate-docs job | 14:08 |
| flaper87 | malini: I think it's automatic after teh `doc` folder lands | 14:08 |
| flaper87 | malini: I had forgotten about this patch: https://review.openstack.org/#/c/127175/ | 14:08 |
| flaper87 | it's quite urgent to review that one, would you mind doing so? | 14:08 |
| flaper87 | we need to get it merged for RC2, it fixes a critical bug | 14:09 |
| malini | checking now | 14:10 |
| flaper87 | thanks a lot | 14:11 |
| *** amitgandhinz has quit IRC | 14:15 | |
| *** sgotliv has quit IRC | 14:30 | |
| *** X019 has joined #openstack-zaqar | 14:37 | |
| flaper87 | kgriffs|afk: can I get your quick review on this one? https://review.openstack.org/#/c/127175/ | 14:46 |
| flaper87 | I need to backport it | 14:46 |
| flaper87 | ok, I backported it anyway | 14:47 |
| flaper87 | I'll have the meeting with ttx in a bit so, I kinda need to get everything in place | 14:48 |
| flaper87 | I'm afraid flavor's and pool's will have to wait | 14:48 |
| flaper87 | kgriffs|afk: I added some things to the smoke test etherpad | 14:52 |
| *** exploreshaifali has joined #openstack-zaqar | 14:54 | |
| *** njirap has quit IRC | 15:11 | |
| *** exploreshaifali has quit IRC | 15:34 | |
| *** exploreshaifali has joined #openstack-zaqar | 15:34 | |
| *** exploreshaifali has quit IRC | 15:34 | |
| *** kgriffs|afk is now known as kgriffs | 15:34 | |
| kgriffs | flaper87: here | 15:35 |
| flaper87 | kgriffs: sweet. Good morning | 15:35 |
| flaper87 | I think our priority is that queue's bug and the flavor/pool stuff | 15:35 |
| kgriffs | ok | 15:35 |
| kgriffs | flaper87: | 15:38 |
| kgriffs | https://review.openstack.org/#/c/127175/2/zaqar/tests/queues/transport/wsgi/v1_1/test_queue_lifecycle.py | 15:38 |
| kgriffs | seems like we should also test that the list of queues is empty | 15:38 |
| kgriffs | am I understanding the purpose of this patch correctly? | 15:38 |
| flaper87 | kgriffs: yup, can we do that in a follow-up patch? | 15:41 |
| flaper87 | kinda sorting out rc2 with ttx now | 15:41 |
| flaper87 | I'll rework the lifecycle test | 15:41 |
| *** alcabrera|afk is now known as alcabrera | 15:43 | |
| *** njirap has joined #openstack-zaqar | 15:43 | |
| kgriffs | flaper87: OK, I added a comment there. | 15:44 |
| flaper87 | kgriffs: I think we still have time so I'll probably do it right away | 15:44 |
| kgriffs | ok, other than that, +2 from me | 15:44 |
| kgriffs | flaper87: what else can I help with? | 15:45 |
| flaper87 | those where our priorities. the rest of the reviews can be done when you've some time | 15:45 |
| flaper87 | I worked on client docs today | 15:45 |
| flaper87 | kgriffs: https://review.openstack.org/#/q/status:open+project:openstack/python-zaqarclient+branch:master+topic:docs,n,z | 15:46 |
| flaper87 | kgriffs: ah and I also added stuff for the smoke test thing | 15:46 |
| kgriffs | kk | 15:46 |
| kgriffs | what do you think about positioning the v1.1 implementation in the Juno release as "beta" and we welcome SDK maintainers to add support and give us feedback? It just makes me nervous to see so much landing last-minute. | 15:47 |
| flaper87 | mmh, my concern about that is that v1 is not consistent and it has somethings we didn't like and removed in v1.1 | 15:49 |
| flaper87 | What about we dedicate tomorrow to re-review v1.1 | 15:49 |
| flaper87 | ? | 15:49 |
| kgriffs | I suppose if we do some extra careful review and testing it will be OK | 15:50 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/zaqar: Queue's empty list should return 200 and an object https://review.openstack.org/127175 | 15:52 |
| flaper87 | kgriffs: malini ^ | 15:52 |
| flaper87 | kgriffs: btw, we still have time until tomorrow to land jeffrey's patches | 15:53 |
| flaper87 | I think it's worth it | 15:53 |
| *** prashanthr_ has joined #openstack-zaqar | 15:55 | |
| *** prashanthr_ has quit IRC | 16:00 | |
| *** exploreshaifali has joined #openstack-zaqar | 16:06 | |
| *** njirap has quit IRC | 16:19 | |
| kgriffs | flaper87: what do you think about this breaking change to 1.0? | 16:25 |
| kgriffs | https://review.openstack.org/#/c/123462/6/zaqar/queues/transport/wsgi/v1_0/pools.py | 16:25 |
| kgriffs | pools were not really "officially" part of 1.0 | 16:25 |
| flaper87 | yeah, I was a bit hesitant at the beginning but came to the same conclusion | 16:26 |
| kgriffs | and were not documented in the spec, so I doubt anyone is using them | 16:26 |
| flaper87 | the real mistake was to include pools in 1.0 | 16:26 |
| kgriffs | yeah | 16:26 |
| flaper87 | so, I'd prefer to fix them, although it means breaking them | 16:26 |
| kgriffs | kk | 16:29 |
| kgriffs | TBH, we could probably just remove the code from the v1.0 altogether and then we no longer have to maintain it | 16:30 |
| flaper87 | kgriffs: I'm tempted but I think, assuming the worst case scenario, that I'd rather face accusations for breaking 1 endpoint than removing a whole feature that was in-use | 16:32 |
| flaper87 | I don't think anyone using v1.0 is using it but | 16:32 |
| *** sgotliv has joined #openstack-zaqar | 16:44 | |
| *** bradjones has quit IRC | 16:46 | |
| *** amitgandhinz has joined #openstack-zaqar | 16:48 | |
| *** kgriffs is now known as kgriffs|afk | 17:08 | |
| *** alcabrera is now known as alcabrera|afk | 17:59 | |
| exploreshaifali | flaper87: ping | 18:01 |
| exploreshaifali | flaper87: I was trying to is how configurations of datastores are defined for diff drives | 18:02 |
| *** kgriffs|afk is now known as kgriffs | 18:02 | |
| exploreshaifali | flaper87, The config object for all Driver classes is an object of oslo.config.ConfigOpts | 18:03 |
| exploreshaifali | *conf object | 18:03 |
| exploreshaifali | But where is this oslo.config.ConfigOpts? | 18:03 |
| exploreshaifali | hi kgriffs | 18:09 |
| kgriffs | o/ | 18:15 |
| *** jchai is now known as jchai_afk | 18:19 | |
| *** jchai_afk is now known as jchai | 18:19 | |
| *** aj9 has joined #openstack-zaqar | 18:24 | |
| exploreshaifali | kgriffs: please can u help explain conf object in all Driver classes | 18:27 |
| exploreshaifali | kgriffs: it is object of oslo.config.ConfOpt class? | 18:28 |
| *** kgriffs is now known as kgriffs|afk | 18:33 | |
| *** kgriffs|afk is now known as kgriffs | 18:37 | |
| *** sgotliv has quit IRC | 18:49 | |
| *** earnThis has joined #openstack-zaqar | 19:01 | |
| *** alcabrera|afk is now known as alcabrera | 19:02 | |
| *** jchai is now known as jchai_afk | 19:02 | |
| *** kgriffs is now known as kgriffs|afk | 19:15 | |
| *** jchai_afk is now known as jchai | 19:24 | |
| *** kgriffs|afk is now known as kgriffs | 19:31 | |
| *** malini has quit IRC | 20:00 | |
| openstackgerrit | A change was merged to openstack/zaqar: Queue's empty list should return 200 and an object https://review.openstack.org/127175 | 20:02 |
| *** fifieldt has quit IRC | 20:08 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/zaqar: Add missing \n at the end of file https://review.openstack.org/127332 | 20:10 |
| *** shaifali_ has joined #openstack-zaqar | 20:11 | |
| *** shaifali_ has quit IRC | 20:12 | |
| kgriffs | if anyone is around, I could use a quick review on this patch - https://review.openstack.org/#/c/126947/ | 20:15 |
| kgriffs | thanks in advance! | 20:15 |
| *** fifieldt has joined #openstack-zaqar | 20:21 | |
| flaper87 | kgriffs: looking | 20:22 |
| flaper87 | lol, I already reviewed | 20:22 |
| flaper87 | it | 20:22 |
| kgriffs | thanks, btw | 20:23 |
| * flaper87 goes back to his cave | 20:23 | |
| kgriffs | :) | 20:23 |
| *** amitgandhinz has quit IRC | 21:06 | |
| *** mpanetta has quit IRC | 21:11 | |
| *** sriram has quit IRC | 21:18 | |
| *** amitgandhinz has joined #openstack-zaqar | 21:20 | |
| *** jchai has quit IRC | 21:25 | |
| *** earnThis has quit IRC | 21:36 | |
| *** sgotliv has joined #openstack-zaqar | 21:42 | |
| *** alcabrera is now known as alcabrera|afk | 21:46 | |
| *** amitgandhinz has quit IRC | 22:12 | |
| *** sgotliv has quit IRC | 22:13 | |
| *** amitgandhinz has joined #openstack-zaqar | 22:33 | |
| *** amitgandhinz has quit IRC | 22:33 | |
| *** kgriffs is now known as kgriffs|afk | 22:58 | |
| *** aj9 has quit IRC | 23:02 | |
| *** echevemaster has joined #openstack-zaqar | 23:10 | |
| *** jeffrey4l has joined #openstack-zaqar | 23:10 | |
| *** flaper87 is now known as flaper87|afk | 23:25 | |
| *** exploreshaifali has quit IRC | 23:26 | |
| openstackgerrit | Jeffrey Zhang proposed a change to openstack/zaqar: Fix no links property in pool list response https://review.openstack.org/123462 | 23:44 |
| *** jeffrey4l_ has joined #openstack-zaqar | 23:44 | |
| openstackgerrit | A change was merged to openstack/zaqar: Fix the msg encode/decode error https://review.openstack.org/122340 | 23:48 |
| *** jeffrey4l has quit IRC | 23:48 | |
| openstackgerrit | Jeffrey Zhang proposed a change to openstack/zaqar: Fix no links property in flavor list response https://review.openstack.org/123626 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!