| *** amitgandhinz has joined #openstack-zaqar | 00:01 | |
| *** amitgandhinz has quit IRC | 00:05 | |
| *** davideagnello has quit IRC | 00:23 | |
| *** davideagnello has joined #openstack-zaqar | 00:24 | |
| *** davideagnello has quit IRC | 00:35 | |
| *** davideagnello has joined #openstack-zaqar | 00:36 | |
| *** kgriffs is now known as kgriffs|afk | 00:38 | |
| *** jasondotstar has quit IRC | 00:53 | |
| *** davideagnello has quit IRC | 01:16 | |
| *** davideagnello has joined #openstack-zaqar | 01:17 | |
| *** davideagnello has quit IRC | 01:19 | |
| *** davideagnello has joined #openstack-zaqar | 01:21 | |
| *** davideagnello has quit IRC | 01:30 | |
| *** davideagnello has joined #openstack-zaqar | 01:31 | |
| *** achanda_ has joined #openstack-zaqar | 01:34 | |
| *** achanda has quit IRC | 01:34 | |
| *** achanda_ has quit IRC | 01:38 | |
| *** achanda has joined #openstack-zaqar | 01:38 | |
| *** achanda has quit IRC | 03:21 | |
| *** echevemaster has joined #openstack-zaqar | 03:39 | |
| *** amalagon has quit IRC | 03:39 | |
| *** diga has joined #openstack-zaqar | 04:07 | |
| *** flwang1 has quit IRC | 04:31 | |
| *** amalagon has joined #openstack-zaqar | 04:31 | |
| *** echevemaster has quit IRC | 05:18 | |
| *** achanda has joined #openstack-zaqar | 05:25 | |
| *** exploreshaifali has joined #openstack-zaqar | 06:22 | |
| openstackgerrit | Shaifali Agrawal proposed openstack/zaqar: Removing QueueController from data to control plane https://review.openstack.org/144340 | 07:14 |
|---|---|---|
| exploreshaifali | flaper87, around? | 07:24 |
| exploreshaifali | good mooooooorning!! :) | 07:24 |
| flaper87 | exploreshaifali: hey | 07:25 |
| flaper87 | good morning | 07:25 |
| flaper87 | yes | 07:25 |
| exploreshaifali | thoughts for error *TypeError: __init__() takes exactly 4 arguments (3 given)* in http://logs.openstack.org/40/144340/11/check/gate-zaqar-python27/8e4847d/console.html | 07:25 |
| exploreshaifali | flaper87, ^ | 07:25 |
| flaper87 | exploreshaifali: did you update the pooling DataDriver and added the new argument to the constructor ? | 07:26 |
| exploreshaifali | flaper87, yes | 07:27 |
| exploreshaifali | also I have updated pipline DataDriver | 07:27 |
| flaper87 | exploreshaifali: I think you now need to update the tests' base classes | 07:31 |
| flaper87 | zaqar/tests/unit/base.py | 07:31 |
| flaper87 | There you'll have to pass the control to the DataDriver instances | 07:31 |
| exploreshaifali | flaper87, okay, one more thing | 07:32 |
| exploreshaifali | flaper87, we can remove queue_controller from DataDriver as in https://review.openstack.org/#/c/144340/12/zaqar/storage/base.py | 07:33 |
| flaper87 | err | 07:34 |
| flaper87 | ops | 07:34 |
| flaper87 | err | 07:34 |
| flaper87 | damnit | 07:34 |
| flaper87 | anyway | 07:34 |
| flaper87 | so yeah, we could remove it but you need to access: self.control_driver.queue_controller | 07:34 |
| exploreshaifali | instead of using self.queue_controller.create we can directly call self.control_driver.queue_controller.create | 07:34 |
| exploreshaifali | yes yes | 07:34 |
| flaper87 | exploreshaifali: ok, you'll need to fix that patch then :D | 07:36 |
| exploreshaifali | yup :D | 07:37 |
| flaper87 | exploreshaifali: great work there, btw! | 07:37 |
| exploreshaifali | flaper87, all thanks to you and vkmc :D | 07:43 |
| *** achanda has quit IRC | 07:54 | |
| *** exploreshaifali has quit IRC | 08:29 | |
| *** exploreshaifali has joined #openstack-zaqar | 08:32 | |
| *** boris-42 has quit IRC | 08:33 | |
| *** flwang1 has joined #openstack-zaqar | 09:12 | |
| *** flwang2 has joined #openstack-zaqar | 09:31 | |
| *** flwang1 has quit IRC | 09:32 | |
| exploreshaifali | flaper87, we connot remove queue_controller from DataDriver classes and also from DataDriverBase because pipeline and pooling have their own queue_controller | 09:48 |
| exploreshaifali | https://github.com/openstack/zaqar/blob/master/zaqar/storage/pipeline.py#L109 | 09:48 |
| exploreshaifali | flaper87, also where is test case defined for DataDriver | 09:49 |
| flaper87 | exploreshaifali: mmh, good point. lets keep it in the DataDriver for now then | 09:49 |
| exploreshaifali | I am looking for it, but not getting | 09:49 |
| flaper87 | exploreshaifali: zaqar/tests/unit/base.py | 09:49 |
| flaper87 | That's were the base class is defined | 09:49 |
| flaper87 | there's no specific test for DataDriver but for the impls themselves | 09:50 |
| flaper87 | however, I think the base class is the only thing you need to update | 09:50 |
| exploreshaifali | flaper87, there is no base.py file inside tests/unit folder | 09:51 |
| exploreshaifali | at other places I can find base.py file but they does not contain related to DataDriver | 09:52 |
| exploreshaifali | https://github.com/openstack/zaqar/tree/master/zaqar/tests/unit | 09:52 |
| exploreshaifali | https://github.com/openstack/zaqar/tree/master/tests/unit | 09:52 |
| flaper87 | exploreshaifali: zaqar/tests/unit/storage/base.py * | 09:52 |
| exploreshaifali | yes flaper87, but it does not contain anything for DataDriver https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/storage/base.py | 09:53 |
| exploreshaifali | how will know what is related to DataDriver | 09:54 |
| exploreshaifali | all the test cases defined their are for controllerBase and so | 09:54 |
| flaper87 | exploreshaifali: https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/storage/base.py#L37 | 09:55 |
| flaper87 | exploreshaifali: https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/storage/base.py#L61-L68 | 09:55 |
| *** flwang2 has quit IRC | 09:56 | |
| *** flwang1 has joined #openstack-zaqar | 10:00 | |
| *** diga has quit IRC | 10:06 | |
| *** boris-42 has joined #openstack-zaqar | 11:05 | |
| *** exploreshaifali has quit IRC | 11:17 | |
| vkmc | morning! | 12:04 |
| flaper87 | vkmc: morning :) | 12:08 |
| *** dynarro has joined #openstack-zaqar | 13:01 | |
| *** flwang1 has quit IRC | 13:25 | |
| *** flwang1 has joined #openstack-zaqar | 13:26 | |
| *** jchai has joined #openstack-zaqar | 14:06 | |
| *** exploreshaifali has joined #openstack-zaqar | 14:08 | |
| *** sriram has joined #openstack-zaqar | 14:13 | |
| exploreshaifali | vkmc, \o | 14:26 |
| exploreshaifali | kragniz, \o | 14:26 |
| exploreshaifali | good morning :) | 14:26 |
| kragniz | exploreshaifali vkmc morning! | 14:27 |
| vkmc | hi exploreshaifali, kragniz o/ | 14:27 |
| *** mpanetta has joined #openstack-zaqar | 14:29 | |
| *** jchai is now known as jchai_afk | 14:29 | |
| *** jchai_afk is now known as jchai | 14:35 | |
| *** amitgandhinz has joined #openstack-zaqar | 14:55 | |
| exploreshaifali | vkmc, do you know where TestBase exists? https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/storage/base.py#L35 | 14:59 |
| vkmc | exploreshaifali, let's think | 15:00 |
| * exploreshaifali thinking :P | 15:00 | |
| vkmc | exploreshaifali, what is that line doing? | 15:00 |
| vkmc | L35 | 15:00 |
| exploreshaifali | declaaring class | 15:00 |
| exploreshaifali | and inheriting another class | 15:00 |
| vkmc | cool | 15:00 |
| exploreshaifali | TestBase should be somewhere inside zaqar/tests | 15:01 |
| vkmc | so.. its inheriting from TestBase | 15:01 |
| vkmc | and how it is calling it? | 15:01 |
| exploreshaifali | using testing module | 15:01 |
| exploreshaifali | from zaqar import tests as testing | 15:01 |
| vkmc | exactly | 15:01 |
| vkmc | so... from zaqar import tests | 15:02 |
| vkmc | that is what we want to check | 15:02 |
| exploreshaifali | I have checked | 15:02 |
| exploreshaifali | https://github.com/openstack/zaqar/tree/master/tests | 15:02 |
| vkmc | we have tests defined in two levels | 15:03 |
| vkmc | here the whole explanation of it http://blog.flaper87.org/post/test-concepts-and-python/ | 15:03 |
| exploreshaifali | got it https://github.com/openstack/zaqar/blob/master/zaqar/tests/base.py#L26 | 15:03 |
| vkmc | but, checking where you are calling it | 15:03 |
| vkmc | exactly | 15:04 |
| vkmc | :) | 15:04 |
| exploreshaifali | vkmc, yes these 2 levels is a bit confusing :) | 15:04 |
| exploreshaifali | anyways, vkmc thanks!! | 15:04 |
| vkmc | exploreshaifali, no worries | 15:04 |
| exploreshaifali | :) | 15:04 |
| *** jasondotstar has joined #openstack-zaqar | 15:08 | |
| *** jasondotstar has quit IRC | 15:08 | |
| *** jasondotstar has joined #openstack-zaqar | 15:09 | |
| *** jasondotstar has quit IRC | 15:38 | |
| *** jasondotstar has joined #openstack-zaqar | 16:01 | |
| *** jasondotstar has quit IRC | 16:27 | |
| *** jchai is now known as jchai_afk | 16:33 | |
| *** amalagon has quit IRC | 16:50 | |
| *** amalagon has joined #openstack-zaqar | 16:50 | |
| *** amalagon has quit IRC | 16:54 | |
| *** jchai_afk is now known as jchai | 17:14 | |
| *** dynarro has quit IRC | 17:18 | |
| *** flwang1 has quit IRC | 17:25 | |
| *** echevemaster has joined #openstack-zaqar | 17:27 | |
| *** amalagon has joined #openstack-zaqar | 17:34 | |
| *** achanda has joined #openstack-zaqar | 17:43 | |
| *** jasondotstar has joined #openstack-zaqar | 17:44 | |
| *** boris-42 has quit IRC | 17:53 | |
| *** jchai is now known as jchai_afk | 18:10 | |
| *** exploreshaifali has quit IRC | 18:20 | |
| *** jasondotstar has quit IRC | 18:24 | |
| *** boris-42 has joined #openstack-zaqar | 18:28 | |
| *** flwang1 has joined #openstack-zaqar | 19:15 | |
| *** jchai_afk is now known as jchai | 19:20 | |
| *** flwang1 has quit IRC | 19:20 | |
| *** exploreshaifali has joined #openstack-zaqar | 19:25 | |
| exploreshaifali | vkmc, around? | 19:31 |
| vkmc | exploreshaifali, here! | 19:32 |
| exploreshaifali | I have changed constructor defination of DataDriver and DataDriverBase classes | 19:33 |
| exploreshaifali | so accordingly need to change test case for them | 19:33 |
| exploreshaifali | https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/storage/base.py#L61-L68 here some modification needed | 19:34 |
| exploreshaifali | but problem is I don't understand exactly what is happening here | 19:34 |
| exploreshaifali | vkmc, the changes I made in DataDriver classes is just added one more argument in its __init__() | 19:35 |
| exploreshaifali | which is control_driver | 19:35 |
| exploreshaifali | vkmc, I think on the lilne 62 self.driver = self.driver_class(self.conf, cache) I need to add one more argument | 19:36 |
| exploreshaifali | which represent control_driver | 19:36 |
| exploreshaifali | which is an instance of class COntrolDriver....but from where I will arrange an instance of ControlDriver there | 19:36 |
| exploreshaifali | vkmc, am I suppose to give more information? | 19:37 |
| exploreshaifali | :P | 19:37 |
| vkmc | so... let me read the backlog | 19:39 |
| exploreshaifali | backlog of what? | 19:40 |
| exploreshaifali | for test cases? | 19:40 |
| vkmc | k k | 19:41 |
| vkmc | the backlog that has the errors you were getting and lead you to modify the tests | 19:42 |
| vkmc | so are those changes for review? | 19:44 |
| exploreshaifali | vkmc, the current patch is not the latest one,but yes many errors are same | 19:44 |
| vkmc | yep | 19:44 |
| vkmc | you added another param to both datadriver and datadriverbase | 19:44 |
| exploreshaifali | yes | 19:44 |
| vkmc | and which is the error you are fixing? | 19:46 |
| vkmc | I'm checking py27 console log | 19:46 |
| exploreshaifali | yes for same log TypeError: __init__() takes exactly 4 arguments (3 given) | 19:46 |
| vkmc | k k | 19:47 |
| vkmc | it seems like the problem is here | 19:50 |
| vkmc | https://github.com/openstack/zaqar/blob/master/zaqar/storage/utils.py#L89-L99 | 19:50 |
| vkmc | precisely in L93 | 19:50 |
| vkmc | load_storage_driver should have a control_driver param | 19:51 |
| vkmc | not in the tests | 19:51 |
| exploreshaifali | vkmc, have added that https://review.openstack.org/#/c/144340/12/zaqar/storage/utils.py | 19:52 |
| vkmc | oh | 19:52 |
| vkmc | :) | 19:52 |
| *** fifieldt__ has joined #openstack-zaqar | 19:53 | |
| vkmc | this must be kgriffs|afk fault | 19:54 |
| exploreshaifali | vkmc, sorry but for what? :P | 19:55 |
| vkmc | BECAUSE | 19:55 |
| vkmc | haha | 19:55 |
| exploreshaifali | :D | 19:56 |
| vkmc | so... if control_driver is None, its not appended to the args | 19:56 |
| vkmc | if its not appended to the args, then you are calling init with 3, not 4 args | 19:56 |
| vkmc | and it fails | 19:56 |
| *** fifieldt_ has quit IRC | 19:56 | |
| vkmc | in which case control_driver should be None? | 19:57 |
| vkmc | it should be always passed | 19:57 |
| vkmc | or... if it can be none, then the datadriver __init__ method should have a default value | 19:57 |
| exploreshaifali | yes and it will be none only when load_storage_driver of utils is called for ControlDriver | 19:57 |
| exploreshaifali | and not for DataDriver | 19:57 |
| exploreshaifali | vkmc, https://review.openstack.org/#/c/144340/12/zaqar/bootstrap.py | 19:58 |
| exploreshaifali | DataDriver __init__ cannot have default value for drivers/DataDrier | 19:58 |
| vkmc | I see | 19:59 |
| vkmc | ok | 19:59 |
| vkmc | that is the output if you put a default value? | 19:59 |
| exploreshaifali | but yes I believe storage.pipeline and pooling's DataDriver does not need control_driver | 19:59 |
| exploreshaifali | vkmc, which output? | 20:00 |
| vkmc | > <exploreshaifali> DataDriver __init__ cannot have default value for drivers/DataDrier | 20:01 |
| *** achanda has quit IRC | 20:01 | |
| exploreshaifali | by that I mean..... driver.DataDriver's __init__ will always need control_driver instance | 20:02 |
| vkmc | ok | 20:02 |
| vkmc | so.. | 20:02 |
| vkmc | https://review.openstack.org/#/c/144340/12/zaqar/storage/utils.py | 20:03 |
| vkmc | control_driver shouldn't be none here | 20:03 |
| vkmc | or what am I missing? :D | 20:03 |
| *** achanda has joined #openstack-zaqar | 20:04 | |
| *** jasondotstar has joined #openstack-zaqar | 20:04 | |
| exploreshaifali | vkmc, I think I caught the issue | 20:05 |
| vkmc | exploreshaifali, yay | 20:05 |
| exploreshaifali | vkmc, in bootstrap.py | 20:05 |
| exploreshaifali | there is def storage(self) | 20:05 |
| vkmc | aha... | 20:05 |
| exploreshaifali | which call utills load_storage_driver | 20:06 |
| exploreshaifali | whoes argments we have changed | 20:06 |
| vkmc | aha... | 20:06 |
| exploreshaifali | but in bootstrap.py there is also def control(self) | 20:06 |
| vkmc | good catch | 20:06 |
| exploreshaifali | which call same method from utils.py | 20:07 |
| exploreshaifali | yeah | 20:07 |
| exploreshaifali | vkmc, so let me try to modify that and then see | 20:07 |
| exploreshaifali | rest other error :D | 20:07 |
| vkmc | maybe, if that methods loads different drivers and that is what is is giving you trouble | 20:07 |
| vkmc | you will need to create a different method | 20:07 |
| vkmc | in utils.py | 20:07 |
| exploreshaifali | yes, if needed we can do that too | 20:08 |
| exploreshaifali | correct | 20:08 |
| vkmc | cool | 20:08 |
| exploreshaifali | vkmc, no no | 20:08 |
| exploreshaifali | my catch is not correct | 20:08 |
| vkmc | boo :( | 20:09 |
| exploreshaifali | because load_storage_driver of utils.py have defined optional argument | 20:09 |
| exploreshaifali | control_driver=None | 20:09 |
| vkmc | ok so | 20:09 |
| *** jasondotstar has quit IRC | 20:09 | |
| *** jchai is now known as jchai_afk | 20:09 | |
| vkmc | we go back to what I was asking... | 20:09 |
| exploreshaifali | dammm | 20:09 |
| vkmc | if control_driver=None | 20:09 |
| exploreshaifali | ok | 20:09 |
| vkmc | then its not passed when you load the driver | 20:10 |
| vkmc | and the call to the datadriver fails | 20:10 |
| *** flwang1 has joined #openstack-zaqar | 20:10 | |
| vkmc | so... or you add a default value to datadriver | 20:10 |
| vkmc | or you refactor that method | 20:10 |
| exploreshaifali | for all DataDriver it will be passed | 20:11 |
| *** jchai_afk is now known as jchai | 20:11 | |
| vkmc | and in which case it won't be passed? | 20:15 |
| exploreshaifali | vkmc, it will not be passed for pooling.DataDriver pipeline.DataDriver and for ControlDriver | 20:16 |
| exploreshaifali | I have modified pooling.DataDriver and pipeline.DataDriver accordingly | 20:16 |
| exploreshaifali | that is in their __init__ have added optional argument | 20:17 |
| exploreshaifali | vkmc, do you want me to update the latest patch? | 20:17 |
| vkmc | exploreshaifali, plese do | 20:24 |
| vkmc | please* | 20:24 |
| exploreshaifali | ok :) | 20:24 |
| openstackgerrit | Shaifali Agrawal proposed openstack/zaqar: Removing QueueController from data to control plane https://review.openstack.org/144340 | 20:25 |
| *** flwang1 has quit IRC | 20:25 | |
| *** mpanetta has quit IRC | 20:28 | |
| *** mpanetta has joined #openstack-zaqar | 20:36 | |
| exploreshaifali | vkmc, ^^^ | 20:36 |
| exploreshaifali | few mistakes I caught in base.py | 20:37 |
| exploreshaifali | avoid them - extra comented line for the call func = functools.partial(self.queue_controller.create | 20:37 |
| exploreshaifali | and deleted @abc.abstractproperty for queue_controller of DataDriver | 20:38 |
| exploreshaifali | other then that all is uptodate | 20:38 |
| vkmc | exploreshaifali, did you checked https://github.com/openstack/zaqar/tree/master/tests/unit/storage/test_pool_*.py? | 21:14 |
| *** mpanetta has quit IRC | 21:14 | |
| exploreshaifali | vkmc, you are still struggling with it, Thanks a loooooooooooooot | 21:16 |
| exploreshaifali | no I haven't looked it | 21:16 |
| exploreshaifali | I was trting different things to sort the issue, which are coming in my mind | 21:16 |
| exploreshaifali | looking at those tests now | 21:17 |
| vkmc | exploreshaifali, haha I got distracted for a while, sorry about it | 21:18 |
| vkmc | k, let me know | 21:18 |
| exploreshaifali | vkmc, yes sure :) | 21:18 |
| *** mpanetta has joined #openstack-zaqar | 21:26 | |
| exploreshaifali | vkmc, prolly caught the error https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/storage/base.py#L62 here need to pass one more argument | 22:00 |
| exploreshaifali | that should be a ControlDriver instance | 22:00 |
| exploreshaifali | how will I get it there? | 22:01 |
| *** sriram has quit IRC | 22:02 | |
| *** achanda has quit IRC | 22:31 | |
| *** jchai has quit IRC | 22:40 | |
| *** achanda has joined #openstack-zaqar | 22:43 | |
| *** mpanetta has quit IRC | 22:56 | |
| *** amitgandhinz has quit IRC | 23:13 | |
| *** echevemaster has quit IRC | 23:43 | |
| *** echevemaster has joined #openstack-zaqar | 23:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!