| *** amitgandhinz has joined #openstack-zaqar | 00:24 | |
| *** amitgandhinz has quit IRC | 00:29 | |
| *** achanda has quit IRC | 00:31 | |
| *** achanda has joined #openstack-zaqar | 00:37 | |
| *** cpallares has quit IRC | 00:46 | |
| *** achanda has quit IRC | 00:50 | |
| *** amalagon has quit IRC | 00:51 | |
| *** amalagon has joined #openstack-zaqar | 00:51 | |
| *** achanda has joined #openstack-zaqar | 00:54 | |
| *** amalagon has quit IRC | 01:06 | |
| *** jasondotstar has joined #openstack-zaqar | 01:07 | |
| *** achanda has quit IRC | 01:30 | |
| openstackgerrit | Shaifali Agrawal proposed openstack/zaqar: Removing QueueController from data to control plane https://review.openstack.org/144340 | 01:41 |
|---|---|---|
| *** exploreshaifali has quit IRC | 01:48 | |
| *** kragniz_ has joined #openstack-zaqar | 01:59 | |
| *** kragniz has quit IRC | 02:06 | |
| *** achanda has joined #openstack-zaqar | 02:31 | |
| *** achanda has quit IRC | 02:36 | |
| *** achanda has joined #openstack-zaqar | 03:33 | |
| *** diga has joined #openstack-zaqar | 03:35 | |
| *** achanda has quit IRC | 03:37 | |
| *** jasondotstar has quit IRC | 03:47 | |
| *** zhiyan has quit IRC | 03:48 | |
| *** zhiyan has joined #openstack-zaqar | 03:49 | |
| *** exploreshaifali has joined #openstack-zaqar | 04:55 | |
| *** exploreshaifali has quit IRC | 05:00 | |
| *** achanda has joined #openstack-zaqar | 05:34 | |
| *** achanda has quit IRC | 05:39 | |
| *** achanda has joined #openstack-zaqar | 06:53 | |
| *** achanda has quit IRC | 07:39 | |
| *** achanda has joined #openstack-zaqar | 07:46 | |
| *** exploreshaifali has joined #openstack-zaqar | 07:50 | |
| *** dynarro has joined #openstack-zaqar | 08:05 | |
| *** achanda has quit IRC | 08:06 | |
| exploreshaifali | flaper87, gooooooood mooooooooooorning :) | 08:10 |
| exploreshaifali | flaper87, kindly review https://review.openstack.org/#/c/144340/ | 08:10 |
| flaper87 | exploreshaifali: yo yo yo | 08:13 |
| flaper87 | exploreshaifali: still failing :( | 08:13 |
| exploreshaifali | flaper87, here is list of different errors which log have http://dpaste.com/2ZYZABJ | 08:13 |
| flaper87 | exploreshaifali: anything I could help with ? | 08:13 |
| flaper87 | exploreshaifali: did you read those errors? | 08:13 |
| flaper87 | :) | 08:13 |
| exploreshaifali | flaper87, yes | 08:14 |
| exploreshaifali | I am trying to solve them | 08:14 |
| flaper87 | exploreshaifali: ok, do you know what's wrong ? | 08:14 |
| exploreshaifali | flaper87, no | 08:14 |
| flaper87 | exploreshaifali: what's the *real* error ? | 08:15 |
| flaper87 | exploreshaifali: if you open that paste, the error is there | 08:15 |
| exploreshaifali | flaper87, yes | 08:15 |
| flaper87 | exploreshaifali: so, what's the real error ? | 08:18 |
| exploreshaifali | flaper87, https://review.openstack.org/#/c/144340/14/zaqar/tests/unit/storage/base.py | 08:18 |
| exploreshaifali | I think errors are occuring from there | 08:18 |
| exploreshaifali | and re real error -- *'NoneType' object has no attribute 'queue_controller'* | 08:19 |
| flaper87 | exploreshaifali: ok, great. That basically means that some instance is getting `None` as the control_driver | 08:19 |
| *** achanda has joined #openstack-zaqar | 08:20 | |
| exploreshaifali | yup exactly | 08:20 |
| flaper87 | exploreshaifali: commented on the review | 08:20 |
| exploreshaifali | that could arise only from bootstrap.py | 08:20 |
| exploreshaifali | flaper87, hahah cool, thanks :) | 08:21 |
| flaper87 | exploreshaifali: I think you should revert your changes in the load_storage code | 08:21 |
| flaper87 | you *need* to pass an actual control_driver instance to `DataDriver` when needed | 08:21 |
| exploreshaifali | flaper87, the current code is aslo sending actual control_driver instance to dataDriver whenever bootstrap passes it | 08:22 |
| exploreshaifali | to utils's mehtod | 08:22 |
| exploreshaifali | secondly if we will take the old code it will give *only 3 arguments are give 4 expected* | 08:23 |
| flaper87 | exploreshaifali: I believe it's not passing valid control_drivers to the DataDriver and your second error confirms that | 08:24 |
| flaper87 | exploreshaifali: your if says: "if control_driver is not None" | 08:24 |
| flaper87 | which means it'll add the control_driver to the args if it is *not* None | 08:25 |
| flaper87 | if you're getting "only 3... expected 4" errors, that means `control_driver` is not always being passed | 08:25 |
| flaper87 | does that make sense? | 08:25 |
| exploreshaifali | okay... | 08:26 |
| exploreshaifali | yes making sense | 08:26 |
| exploreshaifali | but if so, that is control_driver is not always passed than there should be some problem in bootstrap.py | 08:26 |
| flaper87 | exploreshaifali: or probably some tests that still need to be update :) | 08:27 |
| exploreshaifali | flaper87, yes yes | 08:27 |
| exploreshaifali | cool let me look at it :) | 08:27 |
| exploreshaifali | brb | 08:28 |
| *** exploreshaifali has quit IRC | 08:28 | |
| *** achanda has quit IRC | 08:31 | |
| *** zhiyan has quit IRC | 08:55 | |
| *** zhiyan has joined #openstack-zaqar | 09:01 | |
| *** exploreshaifali has joined #openstack-zaqar | 09:06 | |
| *** dynarro has quit IRC | 09:26 | |
| *** flwang1 has joined #openstack-zaqar | 09:36 | |
| *** jasondotstar has joined #openstack-zaqar | 10:30 | |
| *** flwang1 has quit IRC | 10:46 | |
| *** wpf1 has quit IRC | 11:31 | |
| *** wpf1 has joined #openstack-zaqar | 11:44 | |
| *** kragniz_ is now known as kragniz | 11:45 | |
| *** echevemaster has quit IRC | 12:14 | |
| vkmc | morning! | 12:25 |
| exploreshaifali | vkmc, morning :) | 12:28 |
| exploreshaifali | flaper87, there are places other than bootstrap, that call load_storage_driver and I think due to them we are getting errors | 12:29 |
| exploreshaifali | like https://github.com/openstack/zaqar/blob/master/zaqar/storage/utils.py#L150 | 12:29 |
| flaper87 | vkmc: gooooooooooooooooooood morning, girl! | 12:29 |
| exploreshaifali | since control_mode is not set to true, so this call is for DataDriver | 12:29 |
| vkmc | exploreshaifali, flaper87, hiiiiiiiiiiiiiiiiiiiiiiiiii | 12:29 |
| exploreshaifali | Now we need to pass an instance of ControlDriver there | 12:30 |
| flaper87 | exploreshaifali: sounds correct. We need to update those calls in that case | 12:30 |
| flaper87 | and make sure they provide everything that's needed | 12:30 |
| exploreshaifali | but I don't know how to get its instance <- problem | 12:30 |
| flaper87 | exploreshaifali: where is `can_connect` being called from ? | 12:31 |
| exploreshaifali | flaper87, don't know let me search for it | 12:32 |
| exploreshaifali | flaper87, btw there is one more place where load_storage_driver is called https://github.com/openstack/zaqar/blob/master/zaqar/storage/pooling.py#L427 | 12:33 |
| exploreshaifali | but i think it will call pooling's DataDriver so there we don't need to add control_driver | 12:33 |
| exploreshaifali | right? | 12:33 |
| flaper87 | exploreshaifali: well, the Catalogue driver has an instance of the control | 12:34 |
| flaper87 | ... control_driver already | 12:34 |
| flaper87 | (sorry hit enter too early) | 12:34 |
| exploreshaifali | okay pooling.Catalog have an instance control in its __init__, so we can pass it in load_storage_driver argument | 12:39 |
| exploreshaifali | flaper87, utuils.can_connect is called a bunch of times here https://github.com/openstack/zaqar/blob/master/tests/unit/common/storage/test_utils.py#L33 | 12:51 |
| exploreshaifali | and https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v1_1/pools.py#L174 | 12:52 |
| exploreshaifali | ok, have fixed can_connect by calling load_storage_driver inside can_connect once again with control_mode=True | 13:07 |
| *** dynarro has joined #openstack-zaqar | 13:10 | |
| exploreshaifali | yuppieee get rid of AttributeError: 'NoneType' object has no attribute 'queue_controller' | 13:16 |
| exploreshaifali | now solving rest other errors :) | 13:17 |
| *** jchai has joined #openstack-zaqar | 13:19 | |
| *** exploreshaifali has quit IRC | 13:32 | |
| *** flwang has quit IRC | 13:35 | |
| *** jchai has quit IRC | 13:47 | |
| *** flwang has joined #openstack-zaqar | 13:48 | |
| *** miqui has joined #openstack-zaqar | 13:54 | |
| *** miqui_ has joined #openstack-zaqar | 13:57 | |
| *** csoukup has joined #openstack-zaqar | 14:04 | |
| *** sriram has joined #openstack-zaqar | 14:13 | |
| *** jchai has joined #openstack-zaqar | 14:23 | |
| *** mpanetta has joined #openstack-zaqar | 14:40 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:05 | |
| flaper87 | peeeeeeeeeeeeeeeeople | 16:01 |
| flaper87 | make some noise! | 16:01 |
| * kragniz makes some quiet and polite noise | 16:02 | |
| vkmc | whatsaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaap | 16:09 |
| *** diga_ has joined #openstack-zaqar | 16:51 | |
| *** sriram has quit IRC | 16:51 | |
| *** jchai is now known as jchai_afk | 17:00 | |
| *** amalagon has joined #openstack-zaqar | 17:03 | |
| *** jchai_afk is now known as jchai | 17:14 | |
| *** dynarro has quit IRC | 17:19 | |
| * vkmc lurks | 17:20 | |
| *** sriram has joined #openstack-zaqar | 17:24 | |
| *** achanda has joined #openstack-zaqar | 17:49 | |
| *** jasondotstar has joined #openstack-zaqar | 18:02 | |
| vkmc | flaper87, hey hey, around? | 18:23 |
| vkmc | flaper87, https://review.openstack.org/#/c/148297/2/zaqar/storage/mongodb/driver.py what does the p stands for? | 18:23 |
| flaper87 | vkmc: here | 18:49 |
| flaper87 | vkmc: partition | 18:50 |
| vkmc | flaper87, thx | 18:51 |
| *** c_soukup has joined #openstack-zaqar | 19:06 | |
| *** csoukup has quit IRC | 19:10 | |
| *** achanda has quit IRC | 19:13 | |
| *** achanda has joined #openstack-zaqar | 19:15 | |
| *** exploreshaifali has joined #openstack-zaqar | 19:44 | |
| *** flwang1 has joined #openstack-zaqar | 19:50 | |
| *** achanda has quit IRC | 19:51 | |
| *** flwang1 has quit IRC | 19:51 | |
| *** flwang2 has joined #openstack-zaqar | 19:51 | |
| *** achanda has joined #openstack-zaqar | 19:57 | |
| *** achanda has quit IRC | 20:12 | |
| *** achanda has joined #openstack-zaqar | 20:23 | |
| *** jasondotstar has quit IRC | 20:43 | |
| *** kgriffs|afk is now known as kgriffs | 20:55 | |
| *** davideagnello has quit IRC | 21:20 | |
| *** davideagnello has joined #openstack-zaqar | 21:21 | |
| *** fifieldt__ has quit IRC | 21:37 | |
| *** fifieldt__ has joined #openstack-zaqar | 21:38 | |
| *** flwang2 has quit IRC | 21:51 | |
| *** davideagnello has quit IRC | 21:56 | |
| *** davideagnello has joined #openstack-zaqar | 21:58 | |
| *** davideagnello has quit IRC | 22:02 | |
| *** davideagnello has joined #openstack-zaqar | 22:05 | |
| *** exploreshaifali has quit IRC | 22:11 | |
| *** flwang1 has joined #openstack-zaqar | 22:14 | |
| *** sriram has quit IRC | 22:15 | |
| *** mpanetta has quit IRC | 22:18 | |
| *** exploreshaifali has joined #openstack-zaqar | 22:46 | |
| *** amitgandhinz has quit IRC | 23:14 | |
| *** exploreshaifali has quit IRC | 23:22 | |
| *** diga_ has quit IRC | 23:30 | |
| *** jchai has quit IRC | 23:33 | |
| *** jasondotstar has joined #openstack-zaqar | 23:34 | |
| *** echevemaster has joined #openstack-zaqar | 23:46 | |
| *** c_soukup has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!