Tuesday, 2015-02-24

*** flwang1 has quit IRC00:09
*** flwang1 has joined #openstack-zaqar00:11
*** flwang1 has quit IRC00:13
*** amitgandhinz has joined #openstack-zaqar00:15
*** amitgandhinz has quit IRC00:47
*** flwang1 has joined #openstack-zaqar01:02
*** achanda has quit IRC01:21
*** amitgandhinz has joined #openstack-zaqar01:51
*** amitgandhinz has quit IRC01:56
*** kgriffs is now known as kgriffs|afk02:23
*** cpallares has quit IRC03:15
*** amalagon has quit IRC03:30
*** amitgandhinz has joined #openstack-zaqar03:40
*** amitgandhinz has quit IRC03:45
*** amalagon has joined #openstack-zaqar03:59
*** kgriffs|afk is now known as kgriffs04:29
*** flwang1 has quit IRC04:31
*** csoukup has joined #openstack-zaqar04:32
*** c_soukup has joined #openstack-zaqar05:09
*** csoukup_ has joined #openstack-zaqar05:10
*** csoukup has quit IRC05:13
*** c_soukup has quit IRC05:14
*** csoukup_ has quit IRC05:32
*** achanda has joined #openstack-zaqar05:34
*** reed has quit IRC06:45
*** exploreshaifali has joined #openstack-zaqar06:48
exploreshaifaligooooood morning :)06:53
*** exploreshaifali has quit IRC07:14
*** exploreshaifali has joined #openstack-zaqar07:17
exploreshaifaliflaper87: ping!07:32
*** flwang1 has joined #openstack-zaqar07:34
flaper87exploreshaifali: pong07:36
exploreshaifaliflaper87: what is happening here https://review.openstack.org/#/c/156249/3/glance/async/flows/base_import.py,cm at L23007:37
exploreshaifaliextenstions.extensions ?07:37
flaper87exploreshaifali: that's just to check whether some extensions where loaded07:40
flaper87the ExtensionManager is stored in an `extensions` variable07:40
flaper87which has an `extensions` attribute07:40
flaper87which is a list with the loaded extensions07:41
exploreshaifaliflaper87: is this extensions is same that we got in line 226 ?07:41
exploreshaifaliflaper87: okay07:41
exploreshaifaliflaper87: please can you check https://etherpad.openstack.org/p/exploreshaifali-opw-split-layers L29 , what mistake I did in new function, it is always returning None08:01
flaper87exploreshaifali: checking08:01
flaper87exploreshaifali: probably none, did you add the entry_point to setup.cfg ?08:01
exploreshaifaliflaper87: in setup.cfg I have added *zaqar.storage.builtin.stages =     mongodb = zaqar.storage.mongodb.messages:MessageQueueHandler* under section [entry_points]08:03
exploreshaifalimodified etherpad to show you how I added entry_point in setup.cfg08:05
exploreshaifaliflaper87: also I have added MessageQueueHandelr class inside mongodb/messages.py module08:06
*** kgriffs is now known as kgriffs|afk08:06
* flaper87 checks08:10
exploreshaifaliwhat a rhyme - "returning None, due to mistakes None"08:12
exploreshaifali:P08:12
flaper87exploreshaifali: :P08:12
flaper87that looks good08:12
exploreshaifali:D08:13
flaper87one nit, though. You may want to rename that "mongodb" thing to "message_queue_handler"08:13
flaper87or something like that08:13
flaper87then, once you do that, remember to run: pip install -e .08:13
flaper87if you don't do that, the entry_point won't be registered in your env, therefore it won't be loaded ;)08:13
exploreshaifaliflaper87: okay!08:14
exploreshaifaliflaper87: still it is returning None08:18
flaper87exploreshaifali: did you run pip install ?08:19
flaper87this is weird08:19
exploreshaifaliflaper87: yes, I run "pip install -e ."08:20
flaper87ok, that is weird08:22
flaper87could you please push everything to gerrit ?08:22
exploreshaifaliflaper87: sorry, I am in college right now, cannot push it on gerrit :(08:25
*** dynarro has joined #openstack-zaqar08:27
flaper87exploreshaifali: mmh, you need to make sure the entry_point is registered08:29
flaper87it sounds like it might not be registered08:29
flaper87how are you testing this?08:29
flaper87Are you sure it doesn't fail to load the entry_point ?08:30
exploreshaifaliflaper87: for testing rinnint - "tox -epy27"08:30
flaper87it may be failing with an exception08:30
flaper87oooooo08:30
exploreshaifaliflaper87: it is passing this case : " if len(extensions.extensions) == 0:         return None"08:30
exploreshaifaliwhile debugging it always goes inside this if08:31
exploreshaifaliflaper87:  when I tried to print out - "extensions.namespace" it was giving "zaqar.storage.builtin.stages"08:32
exploreshaifaliso I think extensions is getting correct value08:33
flaper87exploreshaifali: we need to get the full log of what's happening there08:34
flaper87I'm pretty sure it's failing to load the entry_point08:35
flaper87lemme check the code that is already on gerrit08:35
exploreshaifaliflaper87: present patch on gerrit does not contain anything related to pipeline08:35
flaper87exploreshaifali: class MessageQueueHandler(storage.Queue) <- you don't really need to inherit from storage.Queue. Doing this will require you to pass other things to the constructor08:37
flaper87that's probably the reason it's failing08:37
flaper87also, that means you need to implement all the abstract methods08:38
exploreshaifaliflaper87: so should I interit storage.Message instead ?08:38
flaper87no, it doesn't need to inherit from any controller08:39
flaper87just object08:39
flaper87you need to get the driver instance yourself08:39
flaper87I mean, you can inherit from storage.Queue08:39
flaper87but you then need to have "fake" implementations for the abstract methods08:39
flaper87which is probably not a terrible idea08:39
exploreshaifaliflaper87: okay08:40
*** achanda has quit IRC08:42
*** achanda has joined #openstack-zaqar08:49
*** kgriffs|afk is now known as kgriffs08:57
*** chandankumar has joined #openstack-zaqar08:59
*** exploreshaifali has quit IRC09:05
*** diga has quit IRC09:05
*** achanda has quit IRC09:06
*** kgriffs is now known as kgriffs|afk09:07
*** openstackgerrit has quit IRC09:36
*** openstackgerrit has joined #openstack-zaqar09:36
*** dynarro has quit IRC09:51
*** exploreshaifali has joined #openstack-zaqar10:35
*** chandankumar_ has joined #openstack-zaqar10:37
*** chandankumar has quit IRC10:38
*** kgriffs|afk is now known as kgriffs10:42
*** kgriffs is now known as kgriffs|afk10:52
exploreshaifaliflaper87, if MessageQueueController does not inherit any class then from where "self.driver"  variable come?11:04
exploreshaifaliit is something that is used inside _stats and _delete methods11:05
exploreshaifalihttps://review.openstack.org/#/c/144340/17/zaqar/storage/mongodb/messages.py11:05
exploreshaifaliflaper87, sorry, only _delete mehtod() need self.collection, _stats() not11:08
exploreshaifaliyet we need driver variable11:08
vkmchihi11:10
exploreshaifalivkmc, gooooood morning :)11:11
exploreshaifalivkmc, how are you ?11:12
vkmcexploreshaifali, good good, recovering from a massive headache, you?11:14
exploreshaifalivkmc, oh, get well soon!!11:14
exploreshaifaliI am good :)11:14
exploreshaifalifeeling sleepy now11:14
vkmcoh... what time is it there?11:15
exploreshaifalivkmc, its evening 511:15
exploreshaifali:P11:15
vkmcexploreshaifali, nap time then11:15
vkmcjajaja11:15
exploreshaifaliyea11:15
*** chandankumar_ has quit IRC11:38
*** chandankumar has joined #openstack-zaqar11:38
*** exploreshaifali has quit IRC11:40
*** exploreshaifali has joined #openstack-zaqar11:43
vkmcflaper87, hey there :) do you know anybody in global reqs I could ping for the autobahn dependency?11:49
exploreshaifalivkmc, flaper87 is also taking a nap11:51
exploreshaifali:P11:52
vkmcexploreshaifali, flaper87 is probably eating11:52
exploreshaifalivkmc, yea its around 2PM for him11:53
exploreshaifali:D11:53
vkmcI dunno why but he always have something tasty with him11:53
exploreshaifalihahaha11:53
*** exploreshaifali has quit IRC12:08
flaper87vkmc: I do know someone there12:09
flaper87I'll poke him12:09
* flaper87 back from lunch12:09
vkmcflaper87, thanks12:10
flaper87flwang1: FYI https://review.openstack.org/#/c/157746/12:10
flaper87we now need to pray to the gate gods12:10
*** AAzza_afk has joined #openstack-zaqar12:41
*** AAzzal has joined #openstack-zaqar12:42
*** AAzza has quit IRC12:43
*** AAzzal is now known as AAzza12:43
*** AAzza_afk has quit IRC12:46
*** kgriffs|afk is now known as kgriffs12:58
*** dynarro has joined #openstack-zaqar13:03
*** kgriffs is now known as kgriffs|afk13:08
*** exploreshaifali has joined #openstack-zaqar13:17
*** chandankumar has quit IRC13:20
exploreshaifaliflaper87, please can you suggest about "self.driver" variable, from where it will come if MessageQueueHandler does not inherit any class?13:41
exploreshaifaliself.driver is needed for self.driver .collection, which is needed for _delete() method13:42
flaper87exploreshaifali: I'd recommend you to look at what the other controllers do and do the same13:43
exploreshaifaliflaper87, yes, self.driver was defined https://github.com/openstack/zaqar/blob/master/zaqar/storage/base.py#L27713:45
exploreshaifalibut when I do same here inside MessageQueueHandler it says, driver is not defined13:45
exploreshaifaliit should, because here in MessageQueueHandler we are catching *args and *kwargs13:46
flaper87exploreshaifali: then what do you think you should do?13:47
* vkmc lurks13:48
exploreshaifaliflaper87, I have tried to print values of args and kwargs, but they are not printing13:48
flaper87exploreshaifali: because you're not passing them13:48
exploreshaifalias MessageQueueHandler's __init__() didn't called I think13:48
flaper87if you check invoke_args13:48
flaper87you just have conf there13:48
flaper87you need to pass the driver or whatever it's needed13:49
flaper87I'd recommend you to *not* use args and kwargs13:49
flaper87unless you really need to13:49
flaper87it's better to have things *explicit* in the code13:49
exploreshaifaliflaper87, yes, that make sense, Thanks!13:49
*** csoukup has joined #openstack-zaqar13:50
exploreshaifaliflaper87, but I have passed conf, so it should go inside args and should have printed out ?13:51
flaper87exploreshaifali: anytime girl, here so we can work together13:51
flaper87exploreshaifali: that is true13:51
flaper87that means there's probably something more13:51
flaper87I'd recommend you to write a specific test to test your function13:51
flaper87and add some breakpoints there13:51
flaper87so you can see what's exactly happening13:52
flaper87.bu4813:52
flaper87ops13:52
exploreshaifaliflaper87, ok13:52
* vkmc tries .bu48 in flaper87's bank account13:52
flaper87lol13:53
vkmccool, I bought some things in amazon13:53
vkmchope you don't mind flaper8713:53
flaper87not at all, please, buy something for your familly and friends too13:54
vkmcgreat, thanks13:54
* exploreshaifali also trying .bu48 in flaper87's account :P13:54
*** amitgandhinz has joined #openstack-zaqar13:55
vkmcI got a couple of this http://www.amazon.com/Giant-Gummy-Bear-approx-Pounds/dp/B00315HJ8C/ref=sr_1_1?s=grocery&ie=UTF8&qid=1424786078&sr=1-1&keywords=giant+gummy+bear13:55
*** amitgandhinz has quit IRC13:55
vkmcflaper87, you are invited to have some tea with us13:55
*** amitgandhinz has joined #openstack-zaqar13:55
vkmcexploreshaifali, I catched up with your progress in the splitting feature13:57
vkmcexploreshaifali, so... anything, just ping me too13:58
*** kgriffs|afk is now known as kgriffs13:58
exploreshaifalivkmc, Thanks a loooot :)13:58
exploreshaifalisurely I will ;)13:58
vkmccool13:59
*** amitgandhinz has quit IRC14:06
*** amitgandhinz has joined #openstack-zaqar14:07
*** kgriffs is now known as kgriffs|afk14:08
*** amitgandhinz has quit IRC14:11
*** chandankumar has joined #openstack-zaqar14:17
*** chandankumar_ has joined #openstack-zaqar14:36
*** chandankumar has quit IRC14:36
*** ametts has joined #openstack-zaqar14:52
*** exploreshaifali has quit IRC14:57
openstackgerritFlavio Percoco proposed openstack/zaqar: Make unreliable `False` by default  https://review.openstack.org/15871715:00
flaper87vkmc: flwang ^15:01
*** cpallares has joined #openstack-zaqar15:03
*** mpanetta has joined #openstack-zaqar15:06
*** mpanetta has quit IRC15:06
*** mpanetta has joined #openstack-zaqar15:23
*** mpanetta has quit IRC15:23
*** mpanetta has joined #openstack-zaqar15:24
cpallaresO/15:43
cpallares\O15:43
*** csoukup has quit IRC15:43
*** chandankumar_ has quit IRC15:45
*** chandankumar has joined #openstack-zaqar15:48
*** chandankumar has quit IRC15:54
*** reed has joined #openstack-zaqar16:09
*** csoukup has joined #openstack-zaqar16:11
*** amalagon has quit IRC16:21
*** amitgandhinz has joined #openstack-zaqar16:27
*** amitgandhinz has quit IRC16:27
*** amitgandhinz has joined #openstack-zaqar16:46
*** amitgandhinz has quit IRC16:46
*** amitgandhinz has joined #openstack-zaqar16:46
*** amitgandhinz has quit IRC16:59
*** dynarro has quit IRC17:01
*** exploreshaifali has joined #openstack-zaqar17:07
*** diga has joined #openstack-zaqar17:23
vkmchttps://review.openstack.org/#/c/158717/17:44
vkmcflaper87, ^ looks good!17:44
vkmcflaper87, if you fix the pep8 error I'll review17:44
*** chandankumar has joined #openstack-zaqar17:52
flaper87pep8 is my eternal curse18:15
flaper87I'll fix it18:15
vkmc:)18:19
*** chandankumar has quit IRC18:44
*** achanda has joined #openstack-zaqar18:52
*** ametts has quit IRC18:58
*** kgriffs|afk is now known as kgriffs19:04
*** csoukup has quit IRC19:11
*** kgriffs is now known as kgriffs|afk19:12
*** kgriffs|afk is now known as kgriffs19:14
*** cpallares has quit IRC19:18
exploreshaifalivkmc, I am searching where self.driver https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/queues.py#L89  is defined19:18
exploreshaifaliin the class above that line 'self.driver' is not defined19:18
exploreshaifalivkmc, so it would have come from class it is inheriting19:19
exploreshaifalivkmc, that is storage.Queue19:19
exploreshaifalivkmc, storage.Queue https://github.com/openstack/zaqar/blob/master/zaqar/storage/base.py#L28119:20
*** flwang1 has quit IRC19:20
exploreshaifaliit does not define __init__()19:20
exploreshaifaliso we can check the class that storage.Queue is inheriting19:20
exploreshaifalithat is ControllerBase19:20
exploreshaifaliControllerBase is https://github.com/openstack/zaqar/blob/master/zaqar/storage/base.py#L28119:21
exploreshaifalivkmc, there ?19:21
exploreshaifalivkmc, problem is ControlBase's __init_() accept only driver parameter19:22
* vkmc reads19:22
exploreshaifalibut while calling from mongodb.QueueController it is passing (*args, **kwargs)19:23
exploreshaifaliso how this above call can map to a method which accept just one parameter19:23
vkmcyou need to pass the driver?19:24
vkmcIIRC you were inheriting from a controller without need19:25
vkmcbut you need to pass some values19:26
vkmcso you need to inherit from object and then call the constructor of your controller with the desired params19:26
exploreshaifalivkmc, I want self.driver to be defined in my class19:27
exploreshaifalivkmc, I am not inheriting any class19:27
exploreshaifaliso looking for ways how can I initialize "self.driver" attribute19:27
exploreshaifalibut leaving what I want to do, I am more curious about how this current code is running?19:28
exploreshaifaliI am sure, there is something I am missing19:28
vkmcok, we need to figure out where is self.driver initializated19:32
vkmcfollowing the inheritance tree19:32
exploreshaifaliyes19:32
*** achanda has quit IRC19:33
exploreshaifalivkmc, it is in ControlBase https://github.com/openstack/zaqar/blob/master/zaqar/storage/base.py#L28119:33
vkmcso.. let's try to do so19:33
vkmcall right19:33
exploreshaifalithe problem is ControlerBase 's __init__() accept on single parameter i.e driver19:34
vkmcand you need to add more parameters to it?19:35
exploreshaifalibut from QueueController we are passing multiple arguments https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/queues.py#L8719:35
exploreshaifalino19:35
exploreshaifalivkmc, I just want to understand how this is working ?19:36
vkmcbut that is quite common... I mean, you are not instantiating ControllerBase directly19:36
vkmcthat is the 'base' precisely19:36
vkmcthen you especialize the controller according to your needs19:36
vkmcspecialize*19:36
exploreshaifalivkmc, yes we are not calling ControllerBase directly, but in between there in no other class that have defined their __init__()19:37
exploreshaifalilike QueueController is inheriting storage.Queue tht is base.Queue class19:38
exploreshaifaliso our call to surperclass will go to base.Queue class's __init__()19:38
vkmcthat's right19:39
exploreshaifalibut since base.Queue does not define any __init__() this call from QueueController will move to base.ControllerBase's __init__()19:39
exploreshaifalisince base.Queue is inheriting base.ControllerBase19:39
*** achanda has joined #openstack-zaqar19:41
*** kgriffs is now known as kgriffs|afk19:42
vkmcso, I understand your concern19:43
*** kgriffs|afk is now known as kgriffs19:43
exploreshaifali:P19:43
vkmcand I'm trying to look for an example of the usage of *args, **kwargs to make it clear :)19:44
vkmcits a python thing19:44
exploreshaifalivkmc, I understand *args and **kwargs19:44
exploreshaifalipositional args and key word args19:44
vkmcyeah, but why is it used like that there19:45
vkmcI know you understand the concept19:45
exploreshaifaliokay, I have tried to do it manually, without class - defined a method that accept only one parameter and while calling passed *args and kwargs19:46
exploreshaifaliso there it was giving error19:46
exploreshaifaliokay I can try same with classes too19:46
exploreshaifalilets see what happens19:46
vkmcI'm checking it out myself too19:49
*** kgriffs is now known as kgriffs|afk20:00
*** csoukup has joined #openstack-zaqar20:11
*** exploreshaifali has quit IRC20:24
*** flwang1 has joined #openstack-zaqar20:38
*** ametts has joined #openstack-zaqar20:48
*** kgriffs|afk is now known as kgriffs21:01
openstackgerritFlavio Percoco proposed openstack/zaqar: Make unreliable `False` by default  https://review.openstack.org/15871721:05
*** kgriffs is now known as kgriffs|afk21:10
flwang1shit happened?21:23
flwang1flaper87: around?21:23
flaper87flwang1: yes21:25
flaper87so, no idea what's going on there :(21:25
flwang1seems both the mongo and redis gate are not happy, holly shit21:26
flaper87mmh, what do the logs say?21:28
flaper87not to focuse with: "What does the fox say?"21:28
flaper87#badumps21:29
flwang1http://logs.openstack.org/29/151529/6/check/check-tempest-dsvm-mongodb-zaqar/caf67bc/console.html21:32
flwang1seems the tempest cases need to be updated21:33
flwang1for mongo21:34
flwang1but for redis, my patch got the same silent dead as before :(21:34
*** malini has joined #openstack-zaqar21:55
*** c_soukup has joined #openstack-zaqar22:02
flaper87what tempest tests need to be updated22:02
flaper87and why22:02
flaper87?22:02
flaper87that's weird22:02
flaper87as in zaqar tempest tests?22:03
*** csoukup has quit IRC22:04
*** mpanetta has quit IRC22:15
*** openstackgerrit has quit IRC22:37
*** openstackgerrit has joined #openstack-zaqar22:37
*** mpanetta has joined #openstack-zaqar22:46
*** mpanetta has quit IRC22:46
*** mpanetta has joined #openstack-zaqar22:47
*** malini has quit IRC22:49
*** achanda has quit IRC22:54
*** c_soukup has quit IRC22:55
*** mpanetta has quit IRC22:55
*** ametts has quit IRC23:09
*** achanda has joined #openstack-zaqar23:13
*** achanda has quit IRC23:48
*** achanda has joined #openstack-zaqar23:53
*** malini has joined #openstack-zaqar23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!