| *** kgriffs|afk is now known as kgriffs | 00:35 | |
| *** kgriffs is now known as kgriffs|afk | 00:46 | |
| *** malini has quit IRC | 00:48 | |
| *** achanda has quit IRC | 01:10 | |
| *** openstack has joined #openstack-zaqar | 01:12 | |
| *** achanda has joined #openstack-zaqar | 01:13 | |
| *** dmitryme2 has joined #openstack-zaqar | 01:23 | |
| *** dmitryme has quit IRC | 01:24 | |
| *** dmitryme2 is now known as dmitryme | 01:24 | |
| *** ekarlso has quit IRC | 01:35 | |
| *** vkmc has quit IRC | 01:35 | |
| *** flaper87 has quit IRC | 01:35 | |
| *** ekarlso has joined #openstack-zaqar | 01:39 | |
| *** vkmc has joined #openstack-zaqar | 01:39 | |
| *** flaper87 has joined #openstack-zaqar | 01:39 | |
| *** ekarlso has quit IRC | 01:40 | |
| *** vkmc has quit IRC | 01:40 | |
| *** flaper87 has quit IRC | 01:40 | |
| *** ekarlso has joined #openstack-zaqar | 01:41 | |
| *** vkmc has joined #openstack-zaqar | 01:41 | |
| *** flaper87 has joined #openstack-zaqar | 01:41 | |
| *** achanda has quit IRC | 01:51 | |
| *** achanda has joined #openstack-zaqar | 01:53 | |
| *** mpanetta has joined #openstack-zaqar | 01:56 | |
| *** mpanetta has quit IRC | 02:04 | |
| *** reed has quit IRC | 02:30 | |
| *** reed_ has joined #openstack-zaqar | 02:30 | |
| *** achanda has quit IRC | 02:44 | |
| *** reed_ is now known as reed | 02:48 | |
| *** reed has quit IRC | 02:48 | |
| *** reed has joined #openstack-zaqar | 02:48 | |
| *** achanda has joined #openstack-zaqar | 03:03 | |
| *** achanda has quit IRC | 03:41 | |
| *** achanda has joined #openstack-zaqar | 03:42 | |
| *** flwang1 has quit IRC | 03:51 | |
| *** reed has quit IRC | 03:55 | |
| *** achanda has quit IRC | 03:57 | |
| *** achanda has joined #openstack-zaqar | 04:02 | |
| *** achanda has quit IRC | 04:04 | |
| *** achanda has joined #openstack-zaqar | 04:12 | |
| *** malini has joined #openstack-zaqar | 04:18 | |
| *** malini has quit IRC | 04:27 | |
| *** kgriffs|afk is now known as kgriffs | 04:54 | |
| *** achanda has quit IRC | 05:12 | |
| *** chandankumar has joined #openstack-zaqar | 05:26 | |
| *** achanda has joined #openstack-zaqar | 05:35 | |
| *** chandankumar has quit IRC | 05:50 | |
| *** exploreshaifali has joined #openstack-zaqar | 05:51 | |
| *** chandankumar has joined #openstack-zaqar | 06:20 | |
| flaper87 | flwang: debugging the gate issue | 07:11 |
|---|---|---|
| exploreshaifali | gooooooooooood morning :D | 07:33 |
| flaper87 | flwang: https://review.openstack.org/#/c/159027/ | 07:39 |
| flaper87 | exploreshaifali: goooooooooooooooooooooooooooooooood morning | 07:39 |
| *** ekarlso has quit IRC | 07:48 | |
| exploreshaifali | flaper87: I am inspecting how 'self.driver' in inititalized in QueueController | 08:08 |
| exploreshaifali | so this is done somewhere in parent class of QueueControlller https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/queues.py#L87 | 08:08 |
| exploreshaifali | QueueController passes 2 arguments to its parent class' __init__() | 08:09 |
| flaper87 | exploreshaifali: yes, look at the parent clases and how that controller is initialized | 08:09 |
| exploreshaifali | QueueController's parent is base.Queue | 08:09 |
| exploreshaifali | which does not define __init__() | 08:09 |
| flaper87 | exploreshaifali: https://github.com/openstack/zaqar/blob/master/zaqar/bootstrap.py#L104-L116 | 08:09 |
| exploreshaifali | so base.Queue's parent is base.ControllerBase | 08:10 |
| exploreshaifali | flaper87: but base.ControllerBase's __init__() accept only 1 parameter | 08:12 |
| flaper87 | exploreshaifali: https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/driver.py#L189-L190 | 08:12 |
| flaper87 | that's what you need | 08:12 |
| exploreshaifali | flaper87: okay, but for a while lets leave what I need, I want to understand how it is working | 08:14 |
| exploreshaifali | problem is - QueueController passes 2 arguments to its parent class' __init__() | 08:15 |
| exploreshaifali | that does to base.ControllerBase's __init__() that accept only one argument | 08:15 |
| exploreshaifali | how this can work? | 08:15 |
| exploreshaifali | surely I am missing something in between | 08:16 |
| flaper87 | exploreshaifali: you're right. Lets clear how it works | 08:16 |
| flaper87 | so, the way it works is | 08:16 |
| flaper87 | The bootstrap class creates an instance of a storage driver | 08:16 |
| flaper87 | which you find in `driver.py` | 08:16 |
| exploreshaifali | okay | 08:17 |
| flaper87 | Then to access the different controllers, you'd access them through the storage driver | 08:17 |
| flaper87 | and depending on the driver you'll be able to access "data controllers" or "control controllers" | 08:17 |
| flaper87 | so, this thing you've created, should behave like the other controllers do | 08:17 |
| exploreshaifali | so the 'self.driver' that we need is this driver only to access controllers | 08:17 |
| flaper87 | therefore I think it should receive an instance of the driver | 08:17 |
| flaper87 | instead of receiving all the other things | 08:18 |
| flaper87 | lemme og and read your implementation again | 08:18 |
| exploreshaifali | flaper87: in my implementation we have decided MessageQueueHandler will not inherit any class | 08:19 |
| flaper87 | exploreshaifali: yeah, you will need the data driver | 08:20 |
| flaper87 | yes | 08:20 |
| flaper87 | that's correct | 08:20 |
| flaper87 | do you understand why is that? | 08:20 |
| exploreshaifali | yes I will need a data driver | 08:20 |
| exploreshaifali | flaper87: you mean, why we don't need to inherit any class? | 08:20 |
| flaper87 | yeah | 08:21 |
| exploreshaifali | first reason they are not needed, and also to reduce extra overhead of overrding abstract methods | 08:21 |
| *** achanda has quit IRC | 08:22 | |
| exploreshaifali | flaper87: ^^ | 08:22 |
| flaper87 | exploreshaifali: yeah, that's correct | 08:22 |
| flaper87 | cool | 08:22 |
| flaper87 | so, now | 08:22 |
| *** achanda has joined #openstack-zaqar | 08:22 | |
| flaper87 | mmh, I was looking for the function in your patch | 08:23 |
| flaper87 | anyway, in your function, you'll have to pass the driver in the invoke_args instead of the conf | 08:23 |
| flaper87 | the conf object is accessible through the driver | 08:23 |
| flaper87 | self.driver.conf | 08:23 |
| exploreshaifali | flaper87: sorry I should have updated patch | 08:24 |
| flaper87 | no worries | 08:24 |
| exploreshaifali | flaper87: okay, so will pass driver object | 08:24 |
| flaper87 | coolio | 08:24 |
| flaper87 | lemme know | 08:24 |
| exploreshaifali | flaper87: all above stuff is okay, but where does QueueController's call to superclass go then ? https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/queues.py#L87 | 08:25 |
| exploreshaifali | as per I understand it is going to base.ControllerBase's __init__() https://github.com/openstack/zaqar/blob/master/zaqar/storage/base.py#L276 | 08:26 |
| flaper87 | exploreshaifali: ah it doesn't go anywhere, you need to add self.driver = driver yourself | 08:51 |
| flaper87 | :) | 08:51 |
| flaper87 | since you're not using any superclass | 08:51 |
| exploreshaifali | flaper87: yea I got what is needed in current situation :) Thanks! | 08:52 |
| *** ekarlso has joined #openstack-zaqar | 08:53 | |
| *** dynarro has joined #openstack-zaqar | 08:55 | |
| flaper87 | exploreshaifali: awesome, let me know :) | 08:56 |
| exploreshaifali | flaper87: okay :D | 08:56 |
| flaper87 | exploreshaifali: we're almost there | 08:56 |
| flaper87 | there are many subtles things but you're keeping up with the fight | 08:56 |
| flaper87 | keep doing so | 08:56 |
| exploreshaifali | flaper87: its because I got surper awesome Mentor :P | 08:57 |
| * flaper87 looks around trying to find that super awesome mentor | 08:58 | |
| flaper87 | :P | 08:58 |
| exploreshaifali | lol | 09:00 |
| exploreshaifali | does flaper87 need one? | 09:00 |
| flaper87 | exploreshaifali: we all need one :) | 09:00 |
| exploreshaifali | yea yea.... I am luck I got one ;) | 09:01 |
| *** achanda has quit IRC | 09:02 | |
| exploreshaifali | lucky* | 09:04 |
| *** achanda has joined #openstack-zaqar | 09:04 | |
| exploreshaifali | brb lunch | 09:08 |
| *** achanda has quit IRC | 09:08 | |
| flaper87 | exploreshaifali: enjoy your meal | 09:10 |
| *** exploreshaifali has quit IRC | 09:12 | |
| *** dynarro has quit IRC | 09:47 | |
| *** kgriffs is now known as kgriffs|afk | 09:49 | |
| *** malini has joined #openstack-zaqar | 10:22 | |
| *** kgriffs|afk is now known as kgriffs | 10:51 | |
| *** kgriffs is now known as kgriffs|afk | 11:01 | |
| *** exploreshaifali has joined #openstack-zaqar | 11:46 | |
| *** kgriffs|afk is now known as kgriffs | 12:40 | |
| *** kgriffs is now known as kgriffs|afk | 12:50 | |
| *** diga has quit IRC | 13:37 | |
| *** dynarro has joined #openstack-zaqar | 14:01 | |
| openstackgerrit | Shaifali Agrawal proposed openstack/zaqar: Removing QueueController from data to control plane https://review.openstack.org/144340 | 14:01 |
| *** malini has quit IRC | 14:20 | |
| *** kgriffs|afk is now known as kgriffs | 14:26 | |
| *** kgriffs is now known as kgriffs|afk | 14:36 | |
| *** csoukup has joined #openstack-zaqar | 14:52 | |
| *** malini has joined #openstack-zaqar | 14:55 | |
| *** ametts has joined #openstack-zaqar | 14:58 | |
| *** openstackgerrit has quit IRC | 15:08 | |
| *** openstackgerrit has joined #openstack-zaqar | 15:08 | |
| *** cpallares has joined #openstack-zaqar | 15:13 | |
| openstackgerrit | Shaifali Agrawal proposed openstack/zaqar: Removing QueueController from data to control plane https://review.openstack.org/144340 | 15:19 |
| *** dynarro has quit IRC | 15:20 | |
| openstackgerrit | Shaifali Agrawal proposed openstack/zaqar: Removing QueueController from data to control plane https://review.openstack.org/144340 | 15:26 |
| *** exploreshaifali has quit IRC | 15:27 | |
| *** kgriffs|afk is now known as kgriffs | 15:37 | |
| *** kgriffs is now known as kgriffs|afk | 15:46 | |
| *** chandankumar has quit IRC | 15:47 | |
| *** kgriffs|afk is now known as kgriffs | 15:50 | |
| *** kgriffs is now known as kgriffs|afk | 15:51 | |
| *** chandankumar has joined #openstack-zaqar | 15:53 | |
| *** exploreshaifali has joined #openstack-zaqar | 16:01 | |
| exploreshaifali | flaper87, https://review.openstack.org/#/c/144340/ | 16:03 |
| *** dynarro has joined #openstack-zaqar | 16:04 | |
| *** malini has quit IRC | 16:05 | |
| *** malini has joined #openstack-zaqar | 16:05 | |
| *** malini has quit IRC | 16:07 | |
| *** exploreshaifali has quit IRC | 16:16 | |
| *** achanda has joined #openstack-zaqar | 16:24 | |
| *** kgriffs|afk is now known as kgriffs | 16:25 | |
| *** kgriffs is now known as kgriffs|afk | 16:27 | |
| *** exploreshaifali has joined #openstack-zaqar | 16:33 | |
| *** achanda has quit IRC | 16:36 | |
| *** reed has joined #openstack-zaqar | 16:38 | |
| exploreshaifali | flaper87, https://review.openstack.org/#/c/144340/20/zaqar/storage/pipeline.py L126 I passed just self, as there we don't have access to queue_controller() | 16:40 |
| flaper87 | exploreshaifali: lemme check | 16:42 |
| exploreshaifali | I know that won't be correct but atm thought to do that for the sake of patch update | 16:42 |
| *** openstackstatus has joined #openstack-zaqar | 16:43 | |
| *** ChanServ sets mode: +v openstackstatus | 16:43 | |
| flaper87 | exploreshaifali: mmh | 16:54 |
| flaper87 | mmh | 16:54 |
| flaper87 | thinking | 16:54 |
| flaper87 | mhh | 16:54 |
| flaper87 | I think what you want to do there is to pass self._storage | 16:54 |
| flaper87 | which is the *actual* driver | 16:54 |
| exploreshaifali | flaper87, okay! | 16:54 |
| flaper87 | `self` is a driver but it's the pipeline data driver | 16:54 |
| exploreshaifali | flaper87, ok, also please can you tell me from where *@_exists.purges* is coming in https://review.openstack.org/#/c/144340/20/zaqar/storage/mongodb/messages.py L877 | 16:56 |
| exploreshaifali | flaper87, I am getting *./zaqar/storage/mongodb/messages.py:877:6: F821 undefined name '_exists'* for it | 16:57 |
| flaper87 | exploreshaifali: that's literally kgriffs|afk fault | 17:01 |
| flaper87 | :P | 17:01 |
| flaper87 | exploreshaifali: _exists is the cache | 17:01 |
| exploreshaifali | lol | 17:01 |
| flaper87 | wait | 17:01 |
| flaper87 | lemme point you to some code | 17:01 |
| exploreshaifali | kgriffs|afk, :D | 17:01 |
| exploreshaifali | ok | 17:01 |
| vkmc | its always he's fault | 17:02 |
| flaper87 | https://github.com/openstack/zaqar/blob/master/zaqar/storage/mongodb/queues.py#L257-L264 | 17:02 |
| vkmc | his* | 17:02 |
| flaper87 | kgriffs|afk: dude, really... come back. We'll soon run out of excuses to blame you | 17:02 |
| flaper87 | mmh | 17:02 |
| flaper87 | actually, that won't ever happen | 17:02 |
| flaper87 | but we miss oyu here | 17:02 |
| vkmc | kgriffs|afk, yeah, we promise we will behave | 17:03 |
| vkmc | kgriffs|afk, now come back | 17:03 |
| *** malini has joined #openstack-zaqar | 17:05 | |
| *** chandankumar has quit IRC | 17:11 | |
| *** malini has quit IRC | 17:11 | |
| flaper87 | flwang: so, I gave your patch a try in a local vm | 17:12 |
| flaper87 | guess what? | 17:12 |
| flaper87 | it worked | 17:12 |
| flaper87 | vkmc: exploreshaifali and others https://review.openstack.org/#/c/159027/ (FYI) | 17:12 |
| * vkmc checks | 17:13 | |
| * exploreshaifali clicks | 17:13 | |
| *** dynarro has quit IRC | 17:25 | |
| *** exploreshaifali has quit IRC | 17:32 | |
| *** kgriffs|afk is now known as kgriffs | 17:37 | |
| *** kgriffs is now known as kgriffs|afk | 17:47 | |
| *** achanda has joined #openstack-zaqar | 18:47 | |
| *** kgriffs|afk is now known as kgriffs | 19:05 | |
| * kgriffs misses everyone | 19:05 | |
| *** malini has joined #openstack-zaqar | 19:07 | |
| * kgriffs even if they do blame him for All the Things™ | 19:07 | |
| *** malini has quit IRC | 19:08 | |
| *** malini has joined #openstack-zaqar | 19:09 | |
| *** kgriffs is now known as kgriffs|afk | 19:24 | |
| *** reed has quit IRC | 19:25 | |
| *** achanda has quit IRC | 19:27 | |
| *** achanda has joined #openstack-zaqar | 19:27 | |
| *** exploreshaifali has joined #openstack-zaqar | 19:27 | |
| *** reed has joined #openstack-zaqar | 19:28 | |
| *** chandankumar has joined #openstack-zaqar | 19:50 | |
| *** flwang1 has joined #openstack-zaqar | 19:56 | |
| *** achanda has quit IRC | 20:00 | |
| *** achanda has joined #openstack-zaqar | 20:08 | |
| flwang | flaper87: ping | 20:20 |
| flwang | flaper87: it should work :) | 20:20 |
| *** kgriffs|afk is now known as kgriffs | 20:25 | |
| *** exploreshaifali has quit IRC | 20:27 | |
| *** cpallares has quit IRC | 20:32 | |
| *** cpallares has joined #openstack-zaqar | 20:32 | |
| *** kgriffs is now known as kgriffs|afk | 20:35 | |
| *** ametts has quit IRC | 20:41 | |
| *** achanda has quit IRC | 20:47 | |
| *** achanda has joined #openstack-zaqar | 20:47 | |
| *** malini has quit IRC | 20:55 | |
| *** chandankumar has quit IRC | 21:01 | |
| *** echevemaster has joined #openstack-zaqar | 22:20 | |
| *** csoukup has quit IRC | 22:35 | |
| *** malini has joined #openstack-zaqar | 22:38 | |
| *** malini has quit IRC | 22:44 | |
| *** reed has quit IRC | 23:13 | |
| *** achanda has quit IRC | 23:26 | |
| *** achanda has joined #openstack-zaqar | 23:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!