*** achanda has joined #openstack-zaqar | 00:07 | |
*** achanda has quit IRC | 00:12 | |
*** amitgandhinz has joined #openstack-zaqar | 01:21 | |
*** amitgandhinz has quit IRC | 02:19 | |
flwang1 | flaper87: ping | 03:15 |
---|---|---|
flwang1 | vkmc: around? | 03:15 |
*** akanksha has quit IRC | 03:17 | |
*** achanda has joined #openstack-zaqar | 04:10 | |
*** achanda has quit IRC | 06:15 | |
*** achanda has joined #openstack-zaqar | 06:42 | |
*** achanda has quit IRC | 07:12 | |
*** pcaruana has quit IRC | 07:14 | |
*** exploreshaifali has joined #openstack-zaqar | 09:51 | |
exploreshaifali | flwang1: around? | 09:52 |
*** exploreshaifali has quit IRC | 09:56 | |
*** exploreshaifali has joined #openstack-zaqar | 10:51 | |
*** exploreshaifali has quit IRC | 11:14 | |
openstackgerrit | Masaki Matsushita proposed openstack/zaqar: Validate UUIDs (Message ID, Client UUID, Claim ID) before the driver sends it. https://review.openstack.org/164671 | 12:28 |
*** vkmc_ has joined #openstack-zaqar | 12:41 | |
*** openstackgerrit has quit IRC | 12:50 | |
*** openstackgerrit has joined #openstack-zaqar | 12:50 | |
*** fifieldt has joined #openstack-zaqar | 12:51 | |
*** jchai has joined #openstack-zaqar | 13:11 | |
*** sriram has joined #openstack-zaqar | 13:26 | |
*** amitgandhinz has joined #openstack-zaqar | 13:29 | |
*** mpanetta has joined #openstack-zaqar | 13:36 | |
*** exploreshaifali has joined #openstack-zaqar | 13:41 | |
openstackgerrit | Masaki Matsushita proposed openstack/zaqar: Validate UUIDs (Message ID, Client UUID, Claim ID) before the driver sends it. https://review.openstack.org/164671 | 13:44 |
*** dynarro has joined #openstack-zaqar | 13:52 | |
*** vkmc_ has quit IRC | 14:07 | |
*** achanda has joined #openstack-zaqar | 15:17 | |
*** achanda has quit IRC | 15:25 | |
*** reed has joined #openstack-zaqar | 15:26 | |
*** dynarro has quit IRC | 15:31 | |
*** achanda has joined #openstack-zaqar | 15:48 | |
*** exploreshaifali has quit IRC | 15:52 | |
*** cpallares has joined #openstack-zaqar | 15:56 | |
*** dynarro has joined #openstack-zaqar | 15:57 | |
*** achanda has quit IRC | 16:04 | |
*** openstackgerrit has quit IRC | 16:11 | |
*** openstackgerrit has joined #openstack-zaqar | 16:11 | |
*** flwang has joined #openstack-zaqar | 16:41 | |
*** exploreshaifali has joined #openstack-zaqar | 16:44 | |
flwang | flaper87: ping | 16:44 |
exploreshaifali | flwang, hello | 16:44 |
flwang | exploreshaifali: hi | 16:45 |
exploreshaifali | flwang, any thoughts for my patch - removing queuecontroler | 16:45 |
flwang | i used most of my day to review your code | 16:45 |
flwang | it make me a little bit nervous, TBH | 16:45 |
* exploreshaifali thinking - really so!!! | 16:46 | |
flwang | does the work code in your env? | 16:46 |
exploreshaifali | :P | 16:46 |
exploreshaifali | server gets started | 16:46 |
flwang | the zaqar server can start, but a lot of functions are broken | 16:47 |
exploreshaifali | but if we check it using *tox -epy27* if fails | 16:47 |
flwang | i'm wondering how did you test it? | 16:47 |
*** akshita has joined #openstack-zaqar | 16:47 | |
exploreshaifali | I test it using *tox -epy27* | 16:48 |
exploreshaifali | tests not get passed | 16:48 |
exploreshaifali | 3 major errors were there | 16:48 |
exploreshaifali | flwang, the one that I think main error is - http://paste.openstack.org/show/190986/ | 16:49 |
exploreshaifali | flwang, should we discuss the changes what I did, may be while discussing we will get any other solution? | 16:50 |
flwang | the error is because you're returning a list instead of a DataDriver | 16:51 |
flwang | the reason why it returns list is because you're adding those builtin pipeline stages | 16:51 |
flwang | so my question is why you think it would work? | 16:52 |
*** openstackgerrit has quit IRC | 16:54 | |
*** openstackgerrit has joined #openstack-zaqar | 16:54 | |
exploreshaifali | flwang, so you mean here https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v2_0/queues.py#L80 self._queue_controller is coming as list | 16:54 |
exploreshaifali | not object? | 16:54 |
flwang | yes | 16:55 |
flwang | it should be a DataDriver instance, not a list | 16:56 |
exploreshaifali | and from where I am returning list instead of DataDriver? | 16:56 |
exploreshaifali | from pipeline? | 16:57 |
exploreshaifali | https://review.openstack.org/#/c/144340/25/zaqar/storage/pipeline.py L98 | 16:57 |
flwang | yes | 17:00 |
*** wpf has quit IRC | 17:01 | |
*** wpf has joined #openstack-zaqar | 17:02 | |
exploreshaifali | okay | 17:03 |
exploreshaifali | let me see how to do that | 17:03 |
flwang | btw, are you confident to get it in kilo? | 17:11 |
*** dynarro has quit IRC | 17:17 | |
exploreshaifali | kilo release will be in May, right? | 17:20 |
exploreshaifali | till than surely I will get it | 17:20 |
flwang | not really, the m-3 will be released on 19 Mar | 17:20 |
exploreshaifali | oh ok! | 17:21 |
exploreshaifali | thanks for informing, lets do is asap! | 17:22 |
*** ametts has joined #openstack-zaqar | 17:26 | |
*** amitgandhinz has quit IRC | 17:36 | |
flwang | exploreshaifali: my pleasure | 17:38 |
flwang | flaper87: ping me when you're available | 17:38 |
*** achanda has joined #openstack-zaqar | 17:50 | |
vkmc | flwang, ping | 17:54 |
vkmc | hey guys | 17:54 |
flwang | vkmc: hey | 17:54 |
vkmc | :) how are you flwang? | 17:55 |
flwang | good good not bad | 17:55 |
flwang | frustrating for the redis driver of notifications | 17:55 |
*** achanda_ has joined #openstack-zaqar | 17:55 | |
flwang | vkmc: how about you? | 17:57 |
vkmc | flwang, frustrating with the websockets unit tests | 17:57 |
vkmc | haha | 17:57 |
vkmc | btw, we probably are going to ask for a freeze exception for main features | 17:58 |
*** achanda has quit IRC | 17:58 | |
*** amitgandhinz has joined #openstack-zaqar | 18:04 | |
flwang | vkmc: yep, i need an exception for notification :) | 18:21 |
*** akshita has quit IRC | 18:26 | |
*** flwang has quit IRC | 18:26 | |
openstackgerrit | Anna Ossowski proposed openstack/zaqar: Title: This change adds missing help strings for claims Body: This change adds missing help strings for some of the configurations available, including default_message_ttl, default_claim_ttl, default_claim_grace, max_queues_per_page, max_messages_per_page https://review.openstack.org/163168 | 18:38 |
openstackgerrit | Anna Ossowski proposed openstack/zaqar: This change adds missing help strings for claims https://review.openstack.org/163168 | 18:58 |
*** akanksha has joined #openstack-zaqar | 19:17 | |
*** flwang has joined #openstack-zaqar | 20:03 | |
flwang | flaper87: around? | 20:52 |
cpallares | flwang: I think flaper87 was traveling back to Italy today. | 21:01 |
cpallares | flwang, so he might now be around | 21:01 |
cpallares | *not | 21:01 |
flwang | cpallares: ok, got, thanks for the info | 21:01 |
*** mpanetta has quit IRC | 21:09 | |
*** jchai has quit IRC | 21:21 | |
*** akanksha has quit IRC | 21:27 | |
*** echevemaster_ has joined #openstack-zaqar | 21:52 | |
*** echevemaster_ has quit IRC | 21:58 | |
*** echevemaster has joined #openstack-zaqar | 21:58 | |
*** sriram has quit IRC | 22:03 | |
*** amitgandhinz has quit IRC | 22:16 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement redis driver for notifications https://review.openstack.org/164893 | 22:37 |
*** amitgandhinz has joined #openstack-zaqar | 23:27 | |
*** amitgandhinz has quit IRC | 23:31 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement webhook notifier driver https://review.openstack.org/151529 | 23:36 |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Add REST API for notification/subscriptions https://review.openstack.org/142432 | 23:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!